From 7f754843f51398d4c55ab7cd64b4b53754be3bb5 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 12 Jun 2018 21:09:40 +0200 Subject: [PATCH] dsdb: Fix CID 1436920 Unchecked return value Signed-off-by: Volker Lendecke Reviewed-by: Andrew Bartlett --- source4/dsdb/samdb/ldb_modules/audit_log.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/source4/dsdb/samdb/ldb_modules/audit_log.c b/source4/dsdb/samdb/ldb_modules/audit_log.c index fd2387699d3..23b4651b32d 100644 --- a/source4/dsdb/samdb/ldb_modules/audit_log.c +++ b/source4/dsdb/samdb/ldb_modules/audit_log.c @@ -1172,6 +1172,7 @@ static int add_transaction_id( talloc_get_type(ldb_module_get_private(module), struct audit_context); struct dsdb_control_transaction_identifier *transaction_id; + int ret; transaction_id = talloc_zero( req, @@ -1181,11 +1182,11 @@ static int add_transaction_id( return ldb_oom(ldb); } transaction_id->transaction_guid = ac->transaction_guid; - ldb_request_add_control(req, - DSDB_CONTROL_TRANSACTION_IDENTIFIER_OID, - false, - transaction_id); - return LDB_SUCCESS; + ret = ldb_request_add_control(req, + DSDB_CONTROL_TRANSACTION_IDENTIFIER_OID, + false, + transaction_id); + return ret; } -- 2.34.1