From 7d0f04a651e4bed7e1e6d587a1bdaf3cfa6f9e33 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Tue, 2 Nov 2010 15:32:16 +1100 Subject: [PATCH] s3-libsmbclient Don't store 'debug_stderr' on the libsmbclient context Following the review of this patch series by Derrell Lipman, remove the seperate storage of the debug_stderr variable from the libsmbclient SMBC_internal_data context. Andrew Bartlett --- source3/include/libsmb_internal.h | 5 ----- source3/libsmb/libsmb_context.c | 11 ----------- source3/libsmb/libsmb_setget.c | 11 ++++++++++- 3 files changed, 10 insertions(+), 17 deletions(-) diff --git a/source3/include/libsmb_internal.h b/source3/include/libsmb_internal.h index 0bfcd8fab78..39a32f99fb1 100644 --- a/source3/include/libsmb_internal.h +++ b/source3/include/libsmb_internal.h @@ -137,11 +137,6 @@ struct SMBC_internal_data { */ SMBCFILE * files; - /* - * Log to standard error instead of the more typical standard output - */ - bool debug_stderr; - /* * Support "Create Time" in get/set with the *xattr() functions, if * true. This replaces the dos attribute strings C_TIME, A_TIME and diff --git a/source3/libsmb/libsmb_context.c b/source3/libsmb/libsmb_context.c index 22e0a047172..6b56e45398d 100644 --- a/source3/libsmb/libsmb_context.c +++ b/source3/libsmb/libsmb_context.c @@ -555,17 +555,6 @@ smbc_init_context(SMBCCTX *context) return NULL; } - if (context->internal->debug_stderr) { - /* - * We do not have a unique per-thread debug state? For - * now, we'll just leave it up to the user. If any one - * context spefies debug to stderr then all will be (and - * will stay that way, as it is unsafe to flip back if - * stdout is in use for other things) - */ - setup_logging("libsmbclient", DEBUG_STDERR); - } - if ((!smbc_getFunctionAuthData(context) && !smbc_getFunctionAuthDataWithContext(context)) || smbc_getDebug(context) < 0 || diff --git a/source3/libsmb/libsmb_setget.c b/source3/libsmb/libsmb_setget.c index 0d260d7cf29..0a023467525 100644 --- a/source3/libsmb/libsmb_setget.c +++ b/source3/libsmb/libsmb_setget.c @@ -135,7 +135,16 @@ smbc_getOptionDebugToStderr(SMBCCTX *c) void smbc_setOptionDebugToStderr(SMBCCTX *c, smbc_bool b) { - c->internal->debug_stderr = b; + if (b) { + /* + * We do not have a unique per-thread debug state? For + * now, we'll just leave it up to the user. If any one + * context spefies debug to stderr then all will be (and + * will stay that way, as it is unsafe to flip back if + * stdout is in use for other things) + */ + setup_logging("libsmbclient", DEBUG_STDERR); + } } /** -- 2.34.1