From 70da27838bb3f6ed9c36add06ce0ccdf467ab1c3 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 15 Jul 2011 08:20:12 +0200 Subject: [PATCH] s3: Avoid leaking http_timestring in print_registry_key Autobuild-User: Volker Lendecke Autobuild-Date: Fri Jul 15 09:44:05 CEST 2011 on sn-devel-104 --- source3/utils/net_registry_util.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/source3/utils/net_registry_util.c b/source3/utils/net_registry_util.c index 084378f7920..22cb3a55b1c 100644 --- a/source3/utils/net_registry_util.c +++ b/source3/utils/net_registry_util.c @@ -27,12 +27,20 @@ void print_registry_key(const char *keyname, NTTIME *modtime) { + const char *ts = _("None"); + char *freeme = NULL; + + if (modtime != 0) { + freeme = http_timestring(talloc_tos(), + nt_time_to_unix(*modtime)); + ts = freeme; + } + d_printf(_("Keyname = %s\n"), keyname); - d_printf(_("Modtime = %s\n"), - modtime - ? http_timestring(talloc_tos(), nt_time_to_unix(*modtime)) - : _("None")); + d_printf(_("Modtime = %s\n"), ts); d_printf("\n"); + + TALLOC_FREE(freeme); } void print_registry_value(const struct registry_value *valvalue, bool raw) -- 2.34.1