From 0c8d5df5cadf59bb7833ccdd8f9c710c61d55cca Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 9 Nov 2013 18:32:21 +0100 Subject: [PATCH] dsdb: Fix Coverity ID 1034907 Dereference before null check "module" has already been dereferenced by ldb_module_get_private(module) Signed-off-by: Volker Lendecke Reviewed-by: Ira Cooper --- source4/dsdb/samdb/ldb_modules/partition.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/dsdb/samdb/ldb_modules/partition.c b/source4/dsdb/samdb/ldb_modules/partition.c index 63835d8d627..39e85e47540 100644 --- a/source4/dsdb/samdb/ldb_modules/partition.c +++ b/source4/dsdb/samdb/ldb_modules/partition.c @@ -811,7 +811,7 @@ static int partition_start_trans(struct ldb_module *module) /* Look at base DN */ /* Figure out which partition it is under */ /* Skip the lot if 'data' isn't here yet (initialization) */ - if ((module && ldb_module_flags(ldb_module_get_ctx(module)) & LDB_FLG_ENABLE_TRACING)) { + if (ldb_module_flags(ldb_module_get_ctx(module)) & LDB_FLG_ENABLE_TRACING) { ldb_debug(ldb_module_get_ctx(module), LDB_DEBUG_TRACE, "partition_start_trans() -> (metadata partition)"); } ret = ldb_next_start_trans(module); -- 2.34.1