Jeremy Allison [Thu, 18 Jan 2007 06:19:24 +0000 (06:19 +0000)]
r20873: Some correctness fixes w.r.t. Samba4 torture BASE-DELETE.
Allow us to correctly refuse to set delete on close on a
non-empty directory. There are still some delete-on-close
wrinkles to be fixed, but I understand how to do that better
now. I'll fix this tomorrow.
Jeremy.
(This used to be commit
029635885825a5562e7974a6f5675cce3bf1b5dc)
Günther Deschner [Wed, 17 Jan 2007 19:20:11 +0000 (19:20 +0000)]
r20862: When in disconnected mode there is no need to try a fallback to a site
less DNS query. This speeds up offline detection slightly.
Guenther
(This used to be commit
eda76ecf07a4d2f9bb5544e2c031cfad14d93e85)
Günther Deschner [Wed, 17 Jan 2007 19:14:34 +0000 (19:14 +0000)]
r20861: We only use sitespecific DNS lookups when looking for DCs or KDCs, not
for a PDC.
Guenther
(This used to be commit
0944c7861004bee2a9d0ac787f022f5bf1d181ac)
Günther Deschner [Wed, 17 Jan 2007 19:11:45 +0000 (19:11 +0000)]
r20860: Adding some small tweaks. When we have no sitename, there is no need to
ask for the list of DCs twice.
Guenther
(This used to be commit
a9baf27e1348dd6dadd7a2fafdf9c269087b80ac)
Volker Lendecke [Wed, 17 Jan 2007 18:26:37 +0000 (18:26 +0000)]
r20858: change_notify_reply_packet is static
(This used to be commit
a1d0644d156c360d52fb837d3eecddb202135ebe)
Jeremy Allison [Wed, 17 Jan 2007 18:25:35 +0000 (18:25 +0000)]
r20857: Silence gives assent :-). Checking in the fix for
site support in a network where many DC's are down.
I heard via Volker there is still a bug w.r.t the
wrong site being chosen with trusted domains but
we'll have to layer that fix on top of this.
Gd - complain if this doesn't work for you.
Jeremy.
(This used to be commit
97e248f89ac6548274f03f2ae7583a255da5ddb3)
Volker Lendecke [Wed, 17 Jan 2007 18:23:37 +0000 (18:23 +0000)]
r20856: Make "struct notify_mid_map" private to notify.c
(This used to be commit
beecef0c70521d28dd88552d661281d9c585eb22)
Volker Lendecke [Wed, 17 Jan 2007 16:23:45 +0000 (16:23 +0000)]
r20854: Ok, now I think we're at a point where looking at notify starts to make sense
again :-)
Volker
(This used to be commit
5533cdeec1b0cdee39b1d89e2320587dc9281ee6)
Volker Lendecke [Wed, 17 Jan 2007 15:47:36 +0000 (15:47 +0000)]
r20851: To read account policies from LDAP we need root.
Volker
(This used to be commit
b48ea4d7775dfc3216771fd328640c2c100a014d)
Günther Deschner [Wed, 17 Jan 2007 14:09:14 +0000 (14:09 +0000)]
r20848: Minor typo.
Guenther
(This used to be commit
fb730e1e7bb83d7dcf8a78302268e384fb9676ee)
Volker Lendecke [Wed, 17 Jan 2007 12:59:14 +0000 (12:59 +0000)]
r20846: Before this gets out of control...
This add a struct event_context and infrastructure for fd events to smbd. This
is step zero to import lib/events.
Jeremy, I rely on you to watch the change in receive_message_or_smb()
closely. For the normal code path this should be the only relevant change. The
rest is either not yet used or is cosmetic.
Volker
(This used to be commit
cd07f93a8aecb24c056e33b1ad3447a41959810f)
Jeremy Allison [Wed, 17 Jan 2007 02:44:27 +0000 (02:44 +0000)]
r20845: Somehow I missed this one - should have been part of the
previous commit :-(.
Jeremy.
(This used to be commit
8fe3829e8a884ce2ddb91121d46b7a3a385874c1)
Jeremy Allison [Wed, 17 Jan 2007 02:09:37 +0000 (02:09 +0000)]
r20844: Somewhat radical change - this may break the build (I will
watch carefully - so I'm doing it in one transaction so I can
roll back).
Change check_name(), reduce_name() and dptr_create() to
return NTSTATUS. This helps a lot in error path processing
and especially in reduce_name() allows us to ditch the flaky
and error-prone saving of errno and return errors directly.
Jeremy.
(This used to be commit
6133a694aa429d638320e39ffe1c49d172583ccf)
Jeremy Allison [Tue, 16 Jan 2007 21:04:30 +0000 (21:04 +0000)]
r20843: Get rid of last BOOL ok.
Jeremy.
(This used to be commit
a36d446fb612f87654c645f6507d413b95efaf21)
Jeremy Allison [Tue, 16 Jan 2007 20:53:50 +0000 (20:53 +0000)]
r20842: Only one more BOOL ok to go...
Jeremy.
(This used to be commit
de0bf477dab1d57b5f7bc6bf70d8e76f9bfac63f)
Jeremy Allison [Tue, 16 Jan 2007 20:49:51 +0000 (20:49 +0000)]
r20841: Remove more BOOL ok.
Jeremy.
(This used to be commit
c6b651966039b1c21facd4c4789bf873b5b49426)
Jeremy Allison [Tue, 16 Jan 2007 20:32:39 +0000 (20:32 +0000)]
r20840: Keep removing the old BOOL ok logic.
Jeremy.
(This used to be commit
224ff059915b2c92ec86d2c3c4b10c3bc552ffa2)
Jelmer Vernooij [Tue, 16 Jan 2007 18:26:02 +0000 (18:26 +0000)]
r20839: Fix other C++ warnings
(This used to be commit
d948d828d591b3467945f5a85a561ebb07299d9f)
Jeremy Allison [Tue, 16 Jan 2007 18:05:37 +0000 (18:05 +0000)]
r20838: Small fix from Jiri.Sasek@Sun.COM to fix null
pointer deref.
Jeremy
(This used to be commit
34d891c81ad4226bb1f0e26902c4e4afaba6d62f)
Jelmer Vernooij [Tue, 16 Jan 2007 17:48:59 +0000 (17:48 +0000)]
r20837: Use real type name, to fix compilation with -WC++-compat
(This used to be commit
840485686d2b3765bd01fbe442f712803d1f4c0f)
Volker Lendecke [Tue, 16 Jan 2007 15:50:25 +0000 (15:50 +0000)]
r20833: Reformatting
(This used to be commit
2c2d5308a23df0b6b078bc647ad550c43b51ee1e)
Jelmer Vernooij [Tue, 16 Jan 2007 15:42:03 +0000 (15:42 +0000)]
r20832: Remove extra pointers previously added to unique [out] pointers. Instead,
add [ref] pointers where necessary (top-level [ref] pointers,
by spec, don't appear on the wire).
This brings us closer to the DCE/RPC standard again.
(This used to be commit
580f2a7197b1bc9db14a643fdd112b40ef37aaef)
Günther Deschner [Tue, 16 Jan 2007 11:15:10 +0000 (11:15 +0000)]
r20828: Fix the build with libnscd.
Guenther
(This used to be commit
8284396faffbe0f58741ecacd62ba86e3ca645c6)
Volker Lendecke [Tue, 16 Jan 2007 10:59:17 +0000 (10:59 +0000)]
r20827: Increment the interface version.
Wilco: Existing modules should continue to work, they just must be recompiled.
Volker
(This used to be commit
f5babdce9b79ba6abed5d6f57daecc0ed1e14e15)
Volker Lendecke [Tue, 16 Jan 2007 08:17:26 +0000 (08:17 +0000)]
r20824: Send access to the trusted domain passwords through the pdb backend, so that
in the next step we can store them in LDAP to be replicated across DCs.
Thanks to Michael Adam <ma@sernet.de>
Volker
(This used to be commit
3c879745cfc39be6128b63a88ecdbfa3d9ce6c2d)
Stefan Metzmacher [Mon, 15 Jan 2007 19:28:02 +0000 (19:28 +0000)]
r20820: merge from samba4:
- include system/aio.h
- use full prototype for main
- use ifdef instead if
metze
(This used to be commit
024dd7d7c95bcf8d77914dc2063f16220358e690)
Stefan Metzmacher [Mon, 15 Jan 2007 19:10:54 +0000 (19:10 +0000)]
r20817: sync lib/replace with samba4
metze
(This used to be commit
352ee730308bbc151a742938818c9b8b3a6e8014)
Stefan Metzmacher [Mon, 15 Jan 2007 18:01:25 +0000 (18:01 +0000)]
r20811: fix comment
metze
(This used to be commit
1f49b9c387ca91da233b0d3bf7a50ef3f6d81f98)
Volker Lendecke [Mon, 15 Jan 2007 09:17:11 +0000 (09:17 +0000)]
r20796: Fix the same problem Jeremy has fixed (improper handling of deferred opens)
for delete_driver_files. Proper fix pending... :-)
Jeremy, please check.
Volker
(This used to be commit
21b8f15dd5ad567efeacf5ba22dc4d8c64b09b76)
Stefan Metzmacher [Mon, 15 Jan 2007 07:17:02 +0000 (07:17 +0000)]
r20789: merge from samba4:
- remove the epoll configure checks from libreplace
metze
(This used to be commit
3061c333eca4aaff6af4b200cfe07d17f87018b2)
Jeremy Allison [Sun, 14 Jan 2007 19:43:06 +0000 (19:43 +0000)]
r20781: Fix a couple of paths found by Volker where we weren't
correctly handling deferred opens.
Jeremy.
(This used to be commit
e47b79d1cef279a1de1128d114d423c1fd2b1e8d)
Simo Sorce [Sun, 14 Jan 2007 17:58:24 +0000 (17:58 +0000)]
r20774: I thought I committed this before Xmas holidays ...
This change is needed to make it possible to not expire
caches in disconnected mode.
Jerry, please can you look at this and confirm it is ok?
Simo.
(This used to be commit
9e8715e4e15d9cede8f4aa9652642995392617e6)
Volker Lendecke [Sun, 14 Jan 2007 11:25:42 +0000 (11:25 +0000)]
r20759: Dummy checkin to let the build farm pick up the new smbtorture4
(This used to be commit
14c88b560e5c8fd59b84333e92337805620ccd7c)
Simo Sorce [Sun, 14 Jan 2007 00:08:31 +0000 (00:08 +0000)]
r20745: Commit Finnish transalation of SWAT after review
(This used to be commit
a971374117772ab0288faae6a33bce929ea117fa)
Jeremy Allison [Sat, 13 Jan 2007 22:26:46 +0000 (22:26 +0000)]
r20744: Fix the build (I missed some chkpth -> checkpath renames).
Jeremy.
(This used to be commit
89b7a0630de0bd95a56263b36d433b4e73517a70)
Jeremy Allison [Sat, 13 Jan 2007 22:22:32 +0000 (22:22 +0000)]
r20743: Remove another BOOL ok from reply_getatr.
Jeremy.
(This used to be commit
c154f430710a4646fac42774817dfed7b936b087)
Jeremy Allison [Sat, 13 Jan 2007 22:10:18 +0000 (22:10 +0000)]
r20742: Rename chkpth -> checkpath for sanity's sake :-).
Start removing unneeded "BOOL ok" from this reply.c
(this logic is old, old, old..... :-).
Jeremy.
(This used to be commit
3d52268095c605a80dfcd371769198a332baa0a5)
Volker Lendecke [Sat, 13 Jan 2007 20:26:53 +0000 (20:26 +0000)]
r20740: Get rid of some if-statements
(This used to be commit
db93c1b98d5445071ad0af229afed1f11ab0a862)
Volker Lendecke [Sat, 13 Jan 2007 19:55:37 +0000 (19:55 +0000)]
r20738: Remove unused variable
(This used to be commit
c16ce9ebaab0175e7f1dc13798d5599388fa35d6)
Volker Lendecke [Sat, 13 Jan 2007 10:40:09 +0000 (10:40 +0000)]
r20725: Get rid of a bool passed down -- gd, please check
(This used to be commit
1ef910f423a9ec69af6abf5a4e2137e8a4e81755)
Jeremy Allison [Sat, 13 Jan 2007 02:34:43 +0000 (02:34 +0000)]
r20724: Get closer to passing RAW-OPEN. If the client is using
create disposition of FILE_CREATE then there's no need
to check can_delete_file_in_directory().
Jeremy.
(This used to be commit
eb32b60efc4c332295ff6fc7e5d575f4b40e8ff6)
Jeremy Allison [Sat, 13 Jan 2007 02:13:45 +0000 (02:13 +0000)]
r20722: RAW-CHKPATH should now pass, build farm should
go back to normal. Sorry about that.
Jeremy.
(This used to be commit
d4127034fb89185fe7464d57c9f56f7914da6141)
Jeremy Allison [Sat, 13 Jan 2007 01:29:10 +0000 (01:29 +0000)]
r20721: Fix the search unix_convert error returns. Only open
to go...
Jeremy.
(This used to be commit
89f03a8db40365f99c6755ff19a4bfbf8d1bd316)
Jeremy Allison [Sat, 13 Jan 2007 01:07:39 +0000 (01:07 +0000)]
r20720: Fix the chkpath problem, still looking at findfirst.
Jeremy.
(This used to be commit
c5be0082ef60cd041121a9c36f4af934cd60562d)
Jeremy Allison [Fri, 12 Jan 2007 23:47:16 +0000 (23:47 +0000)]
r20718: Sync up the filename path parsing changes from SAMBA_3_0_24.
The only difference between the two trees now w.r.t file
serving are the changes to smbd/open.c in this branch I need
to review.
Jeremy.
(This used to be commit
f4474edf6a0c71001dbd01429ef70bafad6abd74)
Jim McDonough [Fri, 12 Jan 2007 21:56:25 +0000 (21:56 +0000)]
r20717: Merge sharemode patch from Mathias Dietz <MDIETZ@de.ibm.com>.
The patch fixes the behaviour of GPFS sharemodes when
the access mask is no_access.
(This used to be commit
799967c66879b4d6e28f1af6ba27c67f0b1deaeb)
Volker Lendecke [Fri, 12 Jan 2007 14:16:30 +0000 (14:16 +0000)]
r20707: Clean up pdb_interface.c a bit -- patch from Michael Adam <ma@sernet.de>
(This used to be commit
d78c18a9fa494a2b3ef48db0abd987c740556e50)
Volker Lendecke [Fri, 12 Jan 2007 09:29:44 +0000 (09:29 +0000)]
r20700: In the main processing loop we select() on the fam socket. If it fires, it
might be possible that we hang in the receive_smb() although that socket is
not the reason for the select() to return.
This immediately reacts to the fam socket to become readable, and goes into
the select loop again. This fixes delays in files showing up in Windows.
Jeremy, James please review this and merge to 3_0_24 if appropriate.
Thanks,
Volker
(This used to be commit
c846153b2ed2f9aca82491888e391ccbe239e88a)
Volker Lendecke [Fri, 12 Jan 2007 08:49:09 +0000 (08:49 +0000)]
r20699: This is an attempt to fix bug 4326.
James, can you please confirm this and merge it to 3_0_24? For me it fixes the
segfault.
Thanks,
Volker
(This used to be commit
a841b7659ba7b76b2da7993e1f4402aa0e11716f)
Jeremy Allison [Fri, 12 Jan 2007 02:58:01 +0000 (02:58 +0000)]
r20695: Remove duplication of constants.
Jeremy.
(This used to be commit
66cca893e1aa035fa0aa05c0d542848f084fac31)
Jeremy Allison [Fri, 12 Jan 2007 02:48:37 +0000 (02:48 +0000)]
r20694: To get this right we need to do signed 64-bit
comparisons here, not unsigned as we're eventually
casting into what it normall a signed 32 bit
value. Guenther please check (but I think I'm right here).
Jeremy.
(This used to be commit
31f8e0edc0c3e76654728b2c204faa70830e1f1b)
Jeremy Allison [Fri, 12 Jan 2007 02:12:15 +0000 (02:12 +0000)]
r20692: Fix bug found by Guenther -
Just try to log on in offline mode without the fix: all accounts are expired,
although they are set to never expire in the PAC/info3.
NTTIME "Never" needs to get (time_t) -1.
We were casting a uint64 to time_t before
comparing, and we should have been doing it
the other way around.
Guenther please check this fixes things.
Jeremy.
(This used to be commit
f4e898b6224fd82d9805da771ef6040065de7b12)
Andrew Tridgell [Thu, 11 Jan 2007 23:10:16 +0000 (23:10 +0000)]
r20690: fix a bug that causes smbd to 'hang' intermittently.
The problem occurs like this:
1) running smbd as a domain member without winbindd
2) client1 connects, during auth smbd-1 calls update_trustdom_cache()
3) smbd-1 takes the trustdom cache timestamp lock, then starts
enumerate_domain_trusts
4) enumerate_domain_trusts hangs for some unknown reason
5) other clients connect, all block waiting for read lock on trustdom
cache
6) samba is now hung
The problem is the lock, and really its just trying to avoid a race
where the cure is worse than the problem. A race in updating the
trutdom cache is not a big issue. So I've just removed the lock.
It is still an open question why enumerate_domain_trusts() can
hang. Unfortunately I've not in a position to get a sniff at the site
that is affected. I suspect a full fix will involve ensuring that all
the rpc code paths have appropriate timeouts.
(This used to be commit
ab8d41053347a5b342ed5b59a0b0dd4983ca91e6)
Günther Deschner [Thu, 11 Jan 2007 15:41:02 +0000 (15:41 +0000)]
r20687: Implement grace logons for offline authentications in pam_winbind.
In case a user authenticated sucessfully and his password just expired
while beeing disconnected, we should allow a user to logon (given a
clear warning). We currently forced the user into a password change
dialogue in that scenario; this did not make much sense while offline.
Guenther
(This used to be commit
668b278653acfc4de7807834988f7af557e608a5)
Jelmer Vernooij [Thu, 11 Jan 2007 01:47:22 +0000 (01:47 +0000)]
r20674: Regenerate NDR parsers after pidl changes. This should fix a couple of
coverity warnings.
(This used to be commit
5f86d006debd880ec35db4ebe7db0663c5cb220f)
Lars Müller [Wed, 10 Jan 2007 21:46:39 +0000 (21:46 +0000)]
r20668: Also do not install the smbumount man page if we don't build smbumount.
(This used to be commit
82ce272b2464f06e8bcbed6452621daa05e12b5d)
Lars Müller [Wed, 10 Jan 2007 20:08:25 +0000 (20:08 +0000)]
r20666: Also do not install the smbmnt man page if SMBMOUNT_PROGS is not set.
(This used to be commit
aa122be8f7a33ebceeb43e4f0c5362047560b199)
Lars Müller [Wed, 10 Jan 2007 19:54:49 +0000 (19:54 +0000)]
r20664: Set the environment variable _before_ calling the shell.
(This used to be commit
9cecd62654d22b47d938a44a8aed63c558d511ad)
Lars Müller [Wed, 10 Jan 2007 19:16:59 +0000 (19:16 +0000)]
r20663: Do not install smbmount man page if we didn't called configure
--with-smbmount.
(This used to be commit
ee12348cf1e93d0e75714f3883bfea6525797dc1)
Volker Lendecke [Wed, 10 Jan 2007 15:31:42 +0000 (15:31 +0000)]
r20654: Fix from Karolin Seeger <ks@sernet.de>: Accept "forever", "off" and "never" as
key words for -1 as policy values for net sam policy.
Volker
(This used to be commit
b6347751d8f67dcaac5c1bcbc07f03073278f6fb)
Günther Deschner [Wed, 10 Jan 2007 12:34:24 +0000 (12:34 +0000)]
r20651: Fix "password expires soon" warning message for pam_winbind.
We were incorrectly calculating the days until the password expires and
we also need to look at the info3 pass_must_change_time for expiry
calculation.
Guenther
(This used to be commit
22d79237127a064a934928d175182adecc6300de)
Volker Lendecke [Wed, 10 Jan 2007 07:56:43 +0000 (07:56 +0000)]
r20644: Make some functions static, thanks to Michael Adam <ma@sernet.de> for the hint.
(This used to be commit
f1f5d035db067b85e55b1c4009407b47dedcf975)
Volker Lendecke [Tue, 9 Jan 2007 20:04:46 +0000 (20:04 +0000)]
r20636: Remove notify leftover
(This used to be commit
a174b49173e7185abb89e605e667e64e8dd87454)
Jeremy Allison [Tue, 9 Jan 2007 18:48:38 +0000 (18:48 +0000)]
r20635: Add placeholder to ensure we don't go into the
wcard unlink if bad_path was set. The error
returned here is almost certainly incorrect
and will need testing properly with smbtorture,
but I don't want to forget about this path
(yes Volker I know this is currently incorrect :-).
Jeremy.
(This used to be commit
06e20c287898d21e437ab117eb5eeeaf2420ba78)
Volker Lendecke [Tue, 9 Jan 2007 16:12:54 +0000 (16:12 +0000)]
r20634: A *LOT* more work is necessary before touching notify remotely starts to make
sense. Until then, remove it from the tree to keep the diff between 3_0_24 and
3_0 small.
Volker
(This used to be commit
f146a85e74c84e78a11e616a1cbeaeef4693a0e0)
Volker Lendecke [Tue, 9 Jan 2007 15:50:40 +0000 (15:50 +0000)]
r20632: The extended RAW-SAMBA3BADPATH test led me to some wrong assumptions, in
particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the
changes based on it. Using gentest is much more effective in this respect, but
it will take a while to figure out the wildcard error handling of W2k3.
Volker
(This used to be commit
58b8a242a7f08c1292d24fc73df170dbcd68c10d)
Günther Deschner [Tue, 9 Jan 2007 13:24:33 +0000 (13:24 +0000)]
r20630: Fix some trivial memleaks.
Guenther
(This used to be commit
3bb94a081888eca69796b14057b551b078ee9a77)
Volker Lendecke [Tue, 9 Jan 2007 09:03:33 +0000 (09:03 +0000)]
r20628: Looks bigger than it is. This is just re-indenting the if (dirname) that we've
taken care of above.
Volker
(This used to be commit
5e1da363bb3f2675beb9fd9240301bb432e5239b)
Volker Lendecke [Tue, 9 Jan 2007 08:56:24 +0000 (08:56 +0000)]
r20627: orig_name is not needed anymore, and slightly simplify logic by doing early
returns.
Volker
(This used to be commit
614651c6a72742173de5fa8723403880acc37c09)
Volker Lendecke [Tue, 9 Jan 2007 08:19:05 +0000 (08:19 +0000)]
r20626: Fix a memleak found by the IBM checker -- not on 3.0.24
(This used to be commit
9d0a789e32e6a6501421edb25bc8197c9e06846d)
Volker Lendecke [Mon, 8 Jan 2007 21:13:27 +0000 (21:13 +0000)]
r20619: bad_path is handled somewhere else, so can_delete does not need it anymore
(This used to be commit
1798987128be579a1a4574294a7c3094040ebaf2)
Volker Lendecke [Mon, 8 Jan 2007 21:08:31 +0000 (21:08 +0000)]
r20618: Fix a bug in bad_path handling that also exists in 3.0.23: For reply_unlink
under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the
bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT.
Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but
this is what W2k3 does.
Jeremy, I tried to call you, but you were not around. So I'll leave it up to
you to merge this.
Volker
(This used to be commit
b1edc3d053104204b966eed67d070ad5da40f17b)
Volker Lendecke [Mon, 8 Jan 2007 20:06:36 +0000 (20:06 +0000)]
r20617: Do not notify if the delete failed
(This used to be commit
c86fbdf8cc8f6f17b23e647bd1f4714c6095b860)
Volker Lendecke [Mon, 8 Jan 2007 16:52:58 +0000 (16:52 +0000)]
r20614: Dummy-checkin to trigger the build
(This used to be commit
7e444e1612fa49f7db4de3256e6c67025db28806)
Volker Lendecke [Mon, 8 Jan 2007 15:36:33 +0000 (15:36 +0000)]
r20612: A checkin I've wanted to do for ages: For bad_path==False set_bad_path_error
is equivalent to UNIX_ERROR. Expand the last reference. Lets see if I can kill
that as well :-)
Volker
(This used to be commit
794d5d38f19601bb5b30b965b41b844aacf1caeb)
Volker Lendecke [Mon, 8 Jan 2007 15:26:17 +0000 (15:26 +0000)]
r20611: All but one callers to set_bad_path_error have had the bad_path==True argument
being handled further up.
Volker
(This used to be commit
358673c36697a16aa87f9cebbace34abf16ed28e)
Volker Lendecke [Mon, 8 Jan 2007 14:16:42 +0000 (14:16 +0000)]
r20610: Fix a Solaris warning
(This used to be commit
60d7b349dbc12288a3da0486b571a1d83401d0b7)
Volker Lendecke [Mon, 8 Jan 2007 14:08:34 +0000 (14:08 +0000)]
r20608: ENOENT->NT_STATUS_OBJECT_NAME_NOT_FOUND is covered in the standard unix error mapping table
(This used to be commit
816c19aaeb812a94fd5669174c9beec60ce1a73f)
Volker Lendecke [Mon, 8 Jan 2007 13:21:43 +0000 (13:21 +0000)]
r20607: Next micro-step for reply_setatr
(This used to be commit
cea9a01434490fb8a17c3f12db7a092efda21186)
Volker Lendecke [Mon, 8 Jan 2007 13:18:23 +0000 (13:18 +0000)]
r20606: bad_path == True has been covered further up in reply_setatr.
I'm checking in micro-steps to make them independently checkable. This code
just very severely needs cleanup, but I don't want to break anything. So, be
patient with me, please :-)
Volker
(This used to be commit
c16775486baa89901f0d5126cb926c9e5a807743)
Volker Lendecke [Mon, 8 Jan 2007 13:05:36 +0000 (13:05 +0000)]
r20605: Simplify logic in reply_setatr slightly
(This used to be commit
f19db8f33ed3749f6b72ae3a4cee83574c606e88)
Volker Lendecke [Mon, 8 Jan 2007 08:09:29 +0000 (08:09 +0000)]
r20604: Fix two memleaks, Coverity ID 337, merge to 3_0_24
(This used to be commit
44f9d25a9026df29fcaae8723ef52b1d3101628b)
Volker Lendecke [Mon, 8 Jan 2007 08:05:49 +0000 (08:05 +0000)]
r20603: Slightly simplify logic
(This used to be commit
e4dea0e64747912da899e846b944c24804772259)
Volker Lendecke [Mon, 8 Jan 2007 08:00:53 +0000 (08:00 +0000)]
r20602: Fix coverity ID 339. SMB_ASSERT does not panic without -DDEVELOPER.
Volker
(This used to be commit
33b5950bec407e295b2c6139e21d062e376df330)
Volker Lendecke [Sun, 7 Jan 2007 18:08:50 +0000 (18:08 +0000)]
r20597: Survive some of the notify mask tests.
(This used to be commit
e4a2e63272dc5b20413597179d06b0185c4a6817)
Volker Lendecke [Sat, 6 Jan 2007 18:59:02 +0000 (18:59 +0000)]
r20589: Re-add lost bad_path handling, sorry.
(This used to be commit
244f96388c843fd629478d0069f68550a2006d06)
Stefan Metzmacher [Sat, 6 Jan 2007 10:10:25 +0000 (10:10 +0000)]
r20585: - allocate an OID range for LDB/LDAP extended operations
metze
(This used to be commit
5373897ef54ba5d04d214cd7a32d2c971059314c)
Stefan Metzmacher [Sat, 6 Jan 2007 01:10:20 +0000 (01:10 +0000)]
r20578: - allocate an OID range for samba4 LDB/LDAP Controls
- allocate an OID range for conflicting attributes/classes
metze
(This used to be commit
6fedd69f5e9a647cd50b08dba517e1f27a06a802)
Jeremy Allison [Fri, 5 Jan 2007 17:42:54 +0000 (17:42 +0000)]
r20558: Refactor rmdir_internals to use early termination rather
than lots of indented code. Change recursive_rmdir()
to return the smbd standards of True on success, False
on fail (it was doing the reverse, which was very confusing).
Jeremy.
(This used to be commit
27dc5bebda7ffbdcb2371638f6132063a953fba2)
Volker Lendecke [Fri, 5 Jan 2007 14:52:10 +0000 (14:52 +0000)]
r20546: Fix some IBM checker errors
(This used to be commit
8f67efd582655e03fea746eee499f3cab6cbdb4d)
Volker Lendecke [Fri, 5 Jan 2007 13:13:15 +0000 (13:13 +0000)]
r20544: Change copy_file() to return NTSTATUS. This is in preparation of turning
close_file() to NTSTATUS as well.
I'm not sure I got all the error codes right, but as I've never come across a
smb_copy() call in all my Samba work, I'm leaving it at that. If I'm
absolutely bored, I will write a thorough torture test.
As far as I can see, Samba4 even does not have a libcli implementation for
it... :-)
Volker
(This used to be commit
5ebdf02ba166df69e210e6f70c01a44e6205ecc1)
Volker Lendecke [Fri, 5 Jan 2007 11:31:28 +0000 (11:31 +0000)]
r20542: Make close_remove_share_mode retun NTSTATUS. Not that anybody cares yet...
(This used to be commit
c8995771531caa4ec9bcaef2c29b11ee7d8e49e6)
Volker Lendecke [Fri, 5 Jan 2007 11:18:59 +0000 (11:18 +0000)]
r20541: Fix some obvious glitches in wait_for_aio_completion. Hmmm. It seems
reply_close() at its heart is going to be an async call :-)
Volker
(This used to be commit
36f60407ae9b430dc5d7f67dd3e7ed8b1dbc93a8)
Günther Deschner [Thu, 4 Jan 2007 23:41:16 +0000 (23:41 +0000)]
r20536: In the offline PAM session close case the attempt to delete a
non-existing krb5 credential cache should not generate an error.
Guenther
(This used to be commit
11c6f573af5c1d3387e60f3fc44b00e28cd87813)
Jeremy Allison [Thu, 4 Jan 2007 23:25:04 +0000 (23:25 +0000)]
r20535: Fix make install to work when root doesn't have
write access into the source tree (like when your
directory is nfs mounted for example....).
Jeremy.
(This used to be commit
7dcb61d1b2d08270a8c718328a26ef4866a1c500)
Jeremy Allison [Thu, 4 Jan 2007 22:01:36 +0000 (22:01 +0000)]
r20532: From Volker...
"smbcli_setattr("") always returns ACCESS_DENIED, test extension to follow.
Merge to 3.0.24?"
Yep (with slight optimization).
Jeremy.
(This used to be commit
dcc7bca1adbc69f348d46291ec2cbfaf5d8486bc)
Jeremy Allison [Thu, 4 Jan 2007 20:46:13 +0000 (20:46 +0000)]
r20530: Don't want this call to get inadvertently re-added :-).
Jeremy.
(This used to be commit
68c4fbcf3397d6c43a3e5809b20a23116b1f8a31)
Volker Lendecke [Thu, 4 Jan 2007 16:26:15 +0000 (16:26 +0000)]
r20525: Closing a dir with del-on-close set requires the same as files: Don't actually
unlink/rmdir if another process still has it open.
Jeremy, this is a potential merger to 3.0.24.
Volker
(This used to be commit
8e1e896b02da99b5a48883c5f37fe146ad0fb5ce)
Volker Lendecke [Thu, 4 Jan 2007 15:12:22 +0000 (15:12 +0000)]
r20524: Simplify logic of close_remove_share_mode().
Volker
(This used to be commit
ade90dbf0c2cbd2cc49a6357f3dd220ea82fd215)
Günther Deschner [Wed, 3 Jan 2007 16:05:00 +0000 (16:05 +0000)]
r20512: Fix typo.
Guenther
(This used to be commit
36bd5cb21bdaf35c7dae47f8b8e93822b3f6188c)