samba.git
16 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Derrell Lipman [Wed, 16 Jan 2008 00:45:06 +0000 (00:45 +0000)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

16 years agoFix the API exported for auth_functions. Ensure we call
Jeremy Allison [Wed, 16 Jan 2008 00:13:11 +0000 (16:13 -0800)]
Fix the API exported for auth_functions. Ensure we call
passing 3 fstrings/sizeof(fstrings) as 3.0.x did. Found
by Derrell. Derrell please test !
Thanks,
Jeremy.

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Tue, 15 Jan 2008 23:09:35 +0000 (15:09 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoFix "status used uninitialized" warnings.
Jeremy Allison [Tue, 15 Jan 2008 23:09:13 +0000 (15:09 -0800)]
Fix "status used uninitialized" warnings.
Jeremy.

16 years agoAdding basic script to help in the creation of tarballs for release.
Gerald W. Carter [Tue, 15 Jan 2008 22:53:24 +0000 (16:53 -0600)]
Adding basic script to help in the creation of tarballs for release.

Developers can use this to create tarballs for testing or general
purpose QA.

   Usage: release-scripts/create-tarball

The script will prompt for information as necessary.

16 years agoUse NDR_PRINT_UNION_STRING instead of NDR_PRINT_UNION_DEBUG in rpcclient.
Günther Deschner [Tue, 15 Jan 2008 22:06:23 +0000 (23:06 +0100)]
Use NDR_PRINT_UNION_STRING instead of NDR_PRINT_UNION_DEBUG in rpcclient.

Guenther

16 years agoAdd some NDR_PRINT_*_STRING macros (returning talloced strings).
Günther Deschner [Tue, 15 Jan 2008 22:04:47 +0000 (23:04 +0100)]
Add some NDR_PRINT_*_STRING macros (returning talloced strings).

Guenther

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Tue, 15 Jan 2008 18:31:47 +0000 (10:31 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agolibsmb: Do not upper-case target name on NTLMv2 hash generation
Kai Blin [Tue, 15 Jan 2008 18:28:23 +0000 (19:28 +0100)]
libsmb: Do not upper-case target name on NTLMv2 hash generation

This makes our NTLMv2 hash generation compatible to the Davenport example
and fixes a bug when ntlm_auth is called with a non-upper-case --domain
parameter and client ntlmv2 auth = yes

Jerry, please consider for 3.2.0

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Tue, 15 Jan 2008 18:19:47 +0000 (10:19 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoea_tdb->xattr_tdb also inside the module itself
Volker Lendecke [Tue, 15 Jan 2008 16:06:12 +0000 (17:06 +0100)]
ea_tdb->xattr_tdb also inside the module itself

16 years agorename vfs_ea_tdb to vfs_xattr_tdb
Volker Lendecke [Tue, 15 Jan 2008 16:03:17 +0000 (17:03 +0100)]
rename vfs_ea_tdb to vfs_xattr_tdb

16 years agoUse autogenerated debugging functions in libnetjoin when requested.
Günther Deschner [Tue, 15 Jan 2008 16:00:14 +0000 (17:00 +0100)]
Use autogenerated debugging functions in libnetjoin when requested.

Guenther

16 years agoApply const to rpccli_lsa_query_info_policy() and rpccli_lsa_query_info_policy2().
Günther Deschner [Tue, 15 Jan 2008 15:40:02 +0000 (16:40 +0100)]
Apply const to rpccli_lsa_query_info_policy() and rpccli_lsa_query_info_policy2().

Guenther

16 years agolibwbclient: don't link talloc.o into libwbclient.a
Stefan Metzmacher [Tue, 15 Jan 2008 13:59:46 +0000 (14:59 +0100)]
libwbclient: don't link talloc.o into libwbclient.a

hopefully fix the build...(and hopefully the correct fix)

metze

16 years agoRevert "libwbclient: don't link talloc.o into libwbclient.a"
Stefan Metzmacher [Tue, 15 Jan 2008 14:56:58 +0000 (15:56 +0100)]
Revert "libwbclient: don't link talloc.o into libwbclient.a"

This reverts commit 9a4b6fd3e21f54a0ff83f1fd0d0d5331a2cfdd0a.

Sorry...

metze

16 years agoRemove unrequired TALLOC_FREE.
Günther Deschner [Tue, 15 Jan 2008 14:48:48 +0000 (15:48 +0100)]
Remove unrequired TALLOC_FREE.

Guenther

16 years agoInclude libnet_join.h in the right places.
Günther Deschner [Tue, 15 Jan 2008 14:43:19 +0000 (15:43 +0100)]
Include libnet_join.h in the right places.

Guenther

16 years agoUse autogenerated libnet_join header.
Günther Deschner [Tue, 15 Jan 2008 14:28:39 +0000 (15:28 +0100)]
Use autogenerated libnet_join header.

Guenther

16 years agoAdd ndr_print_ads_struct().
Günther Deschner [Tue, 15 Jan 2008 14:20:57 +0000 (15:20 +0100)]
Add ndr_print_ads_struct().

Guenther

16 years agoAdd ndr_print_sockaddr_storage and ndr_print_bool.
Günther Deschner [Tue, 15 Jan 2008 14:16:24 +0000 (15:16 +0100)]
Add ndr_print_sockaddr_storage and ndr_print_bool.

Guenther

16 years agoDefine libnet join interface in IDL.
Günther Deschner [Tue, 15 Jan 2008 13:48:34 +0000 (14:48 +0100)]
Define libnet join interface in IDL.

Guenther

16 years agolibwbclient: don't link talloc.o into libwbclient.a
Stefan Metzmacher [Tue, 15 Jan 2008 13:59:46 +0000 (14:59 +0100)]
libwbclient: don't link talloc.o into libwbclient.a

hopefully fix the build...

metze

16 years agoMerge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Derrell Lipman [Tue, 15 Jan 2008 13:58:47 +0000 (13:58 +0000)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test

16 years agoUse the proper boolean functions.
Michael Adam [Tue, 15 Jan 2008 13:56:00 +0000 (14:56 +0100)]
Use the proper boolean functions.

Michael

16 years agoRemove some trailing spaces.
Michael Adam [Tue, 15 Jan 2008 13:55:04 +0000 (14:55 +0100)]
Remove some trailing spaces.

Michael

16 years agokrb5_locator: winbind_krb5_locator.o doesn't need socket wrapper any more
Stefan Metzmacher [Tue, 15 Jan 2008 12:57:58 +0000 (13:57 +0100)]
krb5_locator: winbind_krb5_locator.o doesn't need socket wrapper any more

metze

16 years agonss_winbind: nss_winbind.so doesn't need socket wrapper any more
Stefan Metzmacher [Tue, 15 Jan 2008 12:56:57 +0000 (13:56 +0100)]
nss_winbind: nss_winbind.so doesn't need socket wrapper any more

metze

16 years agopam_winbind: pam_winbind.so doesn't need soecket wrapper any more
Stefan Metzmacher [Tue, 15 Jan 2008 12:56:15 +0000 (13:56 +0100)]
pam_winbind: pam_winbind.so doesn't need soecket wrapper any more

metze

16 years agolibwbclient: libwbclient.so doesn't need socket nor nss wrapper any more
Stefan Metzmacher [Tue, 15 Jan 2008 12:54:30 +0000 (13:54 +0100)]
libwbclient: libwbclient.so doesn't need socket nor nss wrapper any more

metze

16 years agonsswitch/: we don't need socket or nss wrapper in the winbind client code
Stefan Metzmacher [Tue, 15 Jan 2008 12:52:19 +0000 (13:52 +0100)]
nsswitch/: we don't need socket or nss wrapper in the winbind client code

As we don't need socket wrapper of nss wrapper in the winbind client code
we disable the function macros so that we don't endup with swrap_close()
or similar functions.

metze

16 years agoNo need to re-establish AD connection all the time.
Günther Deschner [Tue, 15 Jan 2008 10:00:37 +0000 (11:00 +0100)]
No need to re-establish AD connection all the time.

Guenther

16 years agoUse dsgetdcname() to find a dc when unjoining in libnetjoin.
Günther Deschner [Tue, 15 Jan 2008 09:58:27 +0000 (10:58 +0100)]
Use dsgetdcname() to find a dc when unjoining in libnetjoin.

Guenther

16 years agoRe-arrange pre- and postprocessing code in libnetjoin.
Günther Deschner [Tue, 15 Jan 2008 09:51:40 +0000 (10:51 +0100)]
Re-arrange pre- and postprocessing code in libnetjoin.

Guenther

16 years agoFix some warnings -- Jeremy, please check
Volker Lendecke [Mon, 14 Jan 2008 21:38:16 +0000 (22:38 +0100)]
Fix some warnings -- Jeremy, please check

16 years agoImplement vfs_ea_tdb
Volker Lendecke [Mon, 22 Oct 2007 16:14:57 +0000 (18:14 +0200)]
Implement vfs_ea_tdb

This is an option for file systems that do not implement xattrs: in
lockdir/eas.tdb an array of xatts per inode is stored.

It can not solve the problem that xattrs might reappear if a posix-level
process deletes a file and happens to re-create it under the same name. On file
systems with birthtime we might have a chance to detect this, but not with
standard posix. A future version might put relief on file systems that do have
xattrs but where these are severely limited in size/speed/whatever: We can put
a simple marker as a native xattr, but the xattrs proper are stored in the tdb.

Volker

16 years agolibwbclient: add wbclient.pc.in
Stefan Metzmacher [Tue, 15 Jan 2008 09:43:24 +0000 (10:43 +0100)]
libwbclient: add wbclient.pc.in

metze

16 years agolibwbclient: install wbclient.h into the same path as smbclient.h
Stefan Metzmacher [Tue, 15 Jan 2008 09:42:03 +0000 (10:42 +0100)]
libwbclient: install wbclient.h into the same path as smbclient.h

metze

16 years agolibwbclient: move wbc_err.h into wbclient.h as we only install one header
Stefan Metzmacher [Tue, 15 Jan 2008 09:24:09 +0000 (10:24 +0100)]
libwbclient: move wbc_err.h into wbclient.h as we only install one header

This makes the installed wbclient.h header usable.

metze

16 years agoAdd True/False bool cleanup script.
Günther Deschner [Tue, 15 Jan 2008 09:33:25 +0000 (10:33 +0100)]
Add True/False bool cleanup script.

Guenther

16 years agoWindows insists on write sizes < max_xmit on signed connections.
Jeremy Allison [Mon, 14 Jan 2008 21:46:06 +0000 (13:46 -0800)]
Windows insists on write sizes < max_xmit on signed connections.
Jeremy.

16 years agoFrom Alexander Bokovoy
Jeremy Allison [Mon, 14 Jan 2008 19:06:46 +0000 (11:06 -0800)]
From Alexander Bokovoy

names is a 'const char **names' here, passed from upper level. Passing
'names' as a talloc context will break things as 'names' is usually
likely is a local variable, not a talloc'd. And we want to have array
elements on a context of the array anyway.

Jeremy.

16 years agoFix crash in winbind clients: instead of talloc-based pointer we passed address of...
Alexander Bokovoy [Mon, 14 Jan 2008 18:32:59 +0000 (21:32 +0300)]
Fix crash in winbind clients: instead of talloc-based pointer we passed address of a local variable.

16 years agoAdd detection for need of update to the registry db.
Michael Adam [Mon, 14 Jan 2008 17:31:11 +0000 (18:31 +0100)]
Add detection for need of update to the registry db.

This only detects if the tdb sequence number has changed
since the data has last been read.

Michael

16 years agoSome more minor cleanup for "net rpc audit".
Günther Deschner [Mon, 14 Jan 2008 17:26:24 +0000 (18:26 +0100)]
Some more minor cleanup for "net rpc audit".

Guenther

16 years agoPrint principal in debug statement in kerberos_kinit_password() as well.
Günther Deschner [Mon, 14 Jan 2008 13:18:53 +0000 (14:18 +0100)]
Print principal in debug statement in kerberos_kinit_password() as well.

Guenther

16 years agoRe-run make idl to update lsa idl.
Günther Deschner [Mon, 14 Jan 2008 16:39:33 +0000 (17:39 +0100)]
Re-run make idl to update lsa idl.

Guenther

16 years agoUse lsa_PolicyInfo enum in lsa policy info calls.
Günther Deschner [Mon, 14 Jan 2008 16:37:35 +0000 (17:37 +0100)]
Use lsa_PolicyInfo enum in lsa policy info calls.

Guenther

16 years agoFix all callers of old rpccli_lsa_set_info_policy() call.
Günther Deschner [Mon, 14 Jan 2008 16:17:20 +0000 (17:17 +0100)]
Fix all callers of old rpccli_lsa_set_info_policy() call.

Guenther

16 years agoFix prototypes for lsa set info policy calls.
Günther Deschner [Mon, 14 Jan 2008 16:16:31 +0000 (17:16 +0100)]
Fix prototypes for lsa set info policy calls.

Guenther

16 years agoRemove old lsa set info policy call.
Günther Deschner [Mon, 14 Jan 2008 16:16:06 +0000 (17:16 +0100)]
Remove old lsa set info policy call.

Guenther

16 years agoRe-run make idl for new lsa calls.
Günther Deschner [Mon, 14 Jan 2008 16:13:17 +0000 (17:13 +0100)]
Re-run make idl for new lsa calls.

Guenther

16 years agoFill in IDL for lsa_SetInfoPolicy and lsa_SetInfoPolicy2.
Günther Deschner [Mon, 14 Jan 2008 16:10:31 +0000 (17:10 +0100)]
Fill in IDL for lsa_SetInfoPolicy and lsa_SetInfoPolicy2.

Guenther

16 years agoRemove more redundant lsa parsing functions.
Günther Deschner [Mon, 14 Jan 2008 14:47:42 +0000 (15:47 +0100)]
Remove more redundant lsa parsing functions.

Guenther

16 years agoFix bug #5171 (perl syntax error) found by Jason Filley <jason@snakelegs.org>
Michael Adam [Mon, 14 Jan 2008 14:44:41 +0000 (15:44 +0100)]
Fix bug #5171 (perl syntax error) found by Jason Filley <jason@snakelegs.org>

Michael

16 years agoFix rpcclient display_trust_dom_info().
Günther Deschner [Mon, 14 Jan 2008 14:39:51 +0000 (15:39 +0100)]
Fix rpcclient display_trust_dom_info().

Guenther

16 years agoUse pidl generated rpccli_lsa_QueryTrustedDomainInfoBySid when vampiring trusted
Günther Deschner [Mon, 14 Jan 2008 14:33:26 +0000 (15:33 +0100)]
Use pidl generated rpccli_lsa_QueryTrustedDomainInfoBySid when vampiring trusted
domain secrets.

Guenther

16 years agoRemove some more hand written LSA rpc.
Günther Deschner [Mon, 14 Jan 2008 14:27:57 +0000 (15:27 +0100)]
Remove some more hand written LSA rpc.

(rpccli_lsa_open_trusted_domain,
rpccli_lsa_query_trusted_domain_info,
cli_lsa_query_domain_info_policy).

Guenther

16 years agoStart removing hand-written lsa marshalling code (namely
Günther Deschner [Mon, 14 Jan 2008 14:19:30 +0000 (15:19 +0100)]
Start removing hand-written lsa marshalling code (namely
rpccli_lsa_open_trusted_domain_by_name,
rpccli_lsa_query_trusted_domain_info_by_sid and
rpccli_lsa_query_trusted_domain_info_by_name).

Guenther

16 years agoUse some more pidl generated LSA rpc in rpcclient.
Günther Deschner [Mon, 14 Jan 2008 14:15:47 +0000 (15:15 +0100)]
Use some more pidl generated LSA rpc in rpcclient.

Guenther

16 years agoFix "make test_shlibs": it showed unresolved symbols for -lwbclient.
Michael Adam [Mon, 14 Jan 2008 13:57:30 +0000 (14:57 +0100)]
Fix "make test_shlibs": it showed unresolved symbols for -lwbclient.

Michael

16 years agoRevert ""make test_shlibs" shows unresolved symbols for -lwbclient."
Günther Deschner [Mon, 14 Jan 2008 11:01:06 +0000 (12:01 +0100)]
Revert ""make test_shlibs" shows unresolved symbols for -lwbclient."

This reverts commit 0093f618e91f7dcc69d57dbd09d23acc614999aa.

16 years ago"make test_shlibs" shows unresolved symbols for -lwbclient.
Günther Deschner [Mon, 14 Jan 2008 09:43:49 +0000 (10:43 +0100)]
"make test_shlibs" shows unresolved symbols for -lwbclient.

Guenther

16 years agosamba3 already has tdb_validate()
Andrew Tridgell [Mon, 14 Jan 2008 05:26:52 +0000 (16:26 +1100)]
samba3 already has tdb_validate()

16 years agomerged tdb fix from ctdb tree
Andrew Tridgell [Mon, 14 Jan 2008 04:38:43 +0000 (15:38 +1100)]
merged tdb fix from ctdb tree

16 years agoReset the failed counter in test_wbinfo_s3.sh.
Michael Adam [Sun, 13 Jan 2008 23:23:11 +0000 (00:23 +0100)]
Reset the failed counter in test_wbinfo_s3.sh.

Michael

16 years agoFix a syntax error in script/tests/test_local_s3.sh .
Michael Adam [Sun, 13 Jan 2008 22:54:48 +0000 (23:54 +0100)]
Fix a syntax error in script/tests/test_local_s3.sh .

This will reveal the currently breaking tdbtorture to the build farm...

Michael

16 years agoAdd and modify comments in net_conf.c
Michael Adam [Sun, 13 Jan 2008 22:45:57 +0000 (23:45 +0100)]
Add and modify comments in net_conf.c

Michael

16 years agoAdd explicit creation of shares to net conf import function.
Michael Adam [Sun, 13 Jan 2008 22:30:08 +0000 (23:30 +0100)]
Add explicit creation of shares to net conf import function.

It has been removed from libnet_conf_set_parameter().

Michael

16 years agoMake use of the new libnet_conf_delete_global_parameter() function.
Michael Adam [Sun, 13 Jan 2008 22:20:51 +0000 (23:20 +0100)]
Make use of the new libnet_conf_delete_global_parameter() function.

Michael

16 years agoAdd a function libnet_conf_delete_global_parameter() to libnet_conf.c
Michael Adam [Sun, 13 Jan 2008 22:16:01 +0000 (23:16 +0100)]
Add a function libnet_conf_delete_global_parameter() to libnet_conf.c

Create the [global] section if it does not yet exist.

Michael

16 years agoAdd a function libnet_conf_get_global_parameter() to libnet_conf.c
Michael Adam [Sun, 13 Jan 2008 22:12:27 +0000 (23:12 +0100)]
Add a function libnet_conf_get_global_parameter() to libnet_conf.c

It creates the [global] section if it does not yet exist.

Michael

16 years agoMove libnet_conf_set_global_parameter() inside libnet_conf.c
Michael Adam [Sun, 13 Jan 2008 22:00:16 +0000 (23:00 +0100)]
Move libnet_conf_set_global_parameter() inside libnet_conf.c

Also remove the "convenience function" section comment.
The set_global_parameter function now has a right to exist
in the api.

Michael

16 years agoAdd a comment header to libnet_conf_set_global_parameter().
Michael Adam [Sun, 13 Jan 2008 21:56:56 +0000 (22:56 +0100)]
Add a comment header to libnet_conf_set_global_parameter().

Michael

16 years agoAdd auto-adding of [global] to libnet_conf_set_global_parameter().
Michael Adam [Sun, 13 Jan 2008 21:56:11 +0000 (22:56 +0100)]
Add auto-adding of [global] to libnet_conf_set_global_parameter().

Michael

16 years agoRemove auto-generation of missing share from libnet_conf_set_parameter().
Michael Adam [Sun, 13 Jan 2008 21:49:42 +0000 (22:49 +0100)]
Remove auto-generation of missing share from libnet_conf_set_parameter().

Günther, I wanted to have this as atomic as possible.
I will add this behaviour to libnet_conf_set_global_parameter() next
with the justification that [global] should exist transparently.

Michael

16 years agoFix smbc_listxattr() and friends (bug #5189)
Derrell Lipman [Sun, 13 Jan 2008 22:10:06 +0000 (17:10 -0500)]
Fix smbc_listxattr() and friends (bug #5189)

When the capability of using full names for DOS attributes was added, a bug
was introduced which caused the wrong number of bytes to be returned.  This
patch to smbc_listxattr_ctx() fixes the problem.

Thanks to Jack Schmidt for this patch.

Derrell

16 years agoFix the max_dead_record calculations
Volker Lendecke [Wed, 9 Jan 2008 22:00:48 +0000 (23:00 +0100)]
Fix the max_dead_record calculations

16 years agoFix compile and linking errors since last this code was tested
Derrell Lipman [Sun, 13 Jan 2008 17:07:18 +0000 (12:07 -0500)]
Fix compile and linking errors since last this code was tested

16 years agoFix Compiler warnings by including the proper header.
Michael Adam [Sun, 13 Jan 2008 11:52:25 +0000 (12:52 +0100)]
Fix Compiler warnings by including the proper header.

Michael

16 years agoIntroduce a libnet_conf context created by libnet_conf_open().
Michael Adam [Sun, 13 Jan 2008 00:40:05 +0000 (01:40 +0100)]
Introduce a libnet_conf context created by libnet_conf_open().

The libnet_conf_ctx stores the information necessary to interoperate
with the configuration. It is created by calling libnet_conf_open()
and destroyed by calling libnet_conf_close(). The context is passed
to all the libnet_conf functions. It currently stores the token to
access the registry. Later, it could store more data, e.g. the server
to connect to, credentials, and so on. For support of other backends
than registry or support of remote configuration, only the open
function will have to be changed.

In net_conf, the calls to the actual net_conf functions is wrapped
into a function that calls libnet_conf_open()/_close(). Thus an
individual variant of net_conf_runfunction2() and functable2 is
used to cope with functions being called by the wrapper with the
additional libnet_conf_ctx argument.

Michael

16 years agoidl: Replace non-standard "declare" keyword with typedef and regenerate.
Jelmer Vernooij [Sun, 13 Jan 2008 00:22:23 +0000 (01:22 +0100)]
idl: Replace non-standard "declare" keyword with typedef and regenerate.

16 years agoDon't early delete the share mode tdb data
Volker Lendecke [Sat, 12 Jan 2008 22:06:33 +0000 (23:06 +0100)]
Don't early delete the share mode tdb data

We now refer directly to the file name in the tdb data, so don't delete it.

16 years agoTrivial simplification
Volker Lendecke [Sat, 12 Jan 2008 22:05:23 +0000 (23:05 +0100)]
Trivial simplification

16 years agoRemove an unused variable
Volker Lendecke [Sat, 12 Jan 2008 18:12:30 +0000 (19:12 +0100)]
Remove an unused variable

16 years agoGet the inbuf on talloc_tos()
Volker Lendecke [Sat, 12 Jan 2008 20:09:43 +0000 (21:09 +0100)]
Get the inbuf on talloc_tos()

16 years agoConvert OpenDir to talloc, use talloc_tos()
Volker Lendecke [Sat, 12 Jan 2008 16:08:04 +0000 (17:08 +0100)]
Convert OpenDir to talloc, use talloc_tos()

This cuts some mallocs on NtCreate&X

16 years agoRestructure dbwrap_rbt
Volker Lendecke [Sat, 12 Jan 2008 09:38:17 +0000 (10:38 +0100)]
Restructure dbwrap_rbt

In this low-level code, play tricks to reduce the number of allocations to the
possible minimum. I would not recommend this for higher-level code, but here it
pays off.

16 years agoOne more empty line
Volker Lendecke [Fri, 11 Jan 2008 11:02:56 +0000 (12:02 +0100)]
One more empty line

16 years agodelete on close even prevents stat opens
Volker Lendecke [Fri, 11 Jan 2008 11:35:04 +0000 (12:35 +0100)]
delete on close even prevents stat opens

16 years agoThere's no point in calling FLOCK on a non-existing fd
Volker Lendecke [Fri, 11 Jan 2008 20:53:29 +0000 (21:53 +0100)]
There's no point in calling FLOCK on a non-existing fd

16 years agoCID 458. Don't leak dlopen handles on failing to load
Jeremy Allison [Sat, 12 Jan 2008 08:15:46 +0000 (00:15 -0800)]
CID 458. Don't leak dlopen handles on failing to load
module.
Jeremy.

16 years agoFix CID 469. new_acct can't be NULL here.
Jeremy Allison [Sat, 12 Jan 2008 08:09:35 +0000 (00:09 -0800)]
Fix CID 469. new_acct can't be NULL here.
Jeremy.

16 years agoFix CID 470. resolve_order can't be NULL here so simplify code.
Jeremy Allison [Sat, 12 Jan 2008 08:05:07 +0000 (00:05 -0800)]
Fix CID 470. resolve_order can't be NULL here so simplify code.
Jeremy.

16 years agoFix CID 475. work should not be checked against NULL
Jeremy Allison [Sat, 12 Jan 2008 07:56:48 +0000 (23:56 -0800)]
Fix CID 475. work should not be checked against NULL
here as it can never be null.
Jeremy.

16 years agoFix CID 476. Ensure a valid pac_data pointer is always passed to
Jeremy Allison [Sat, 12 Jan 2008 07:53:27 +0000 (23:53 -0800)]
Fix CID 476. Ensure a valid pac_data pointer is always passed to
ads_verify_ticket as it's always derefed.
Jeremy.

16 years agoCoverity 512, uninitialized var.
Jeremy Allison [Sat, 12 Jan 2008 07:43:33 +0000 (23:43 -0800)]
Coverity 512, uninitialized var.
Jeremy.

16 years agoStop Coverity complaining about uninitialized variables.
Jeremy Allison [Sat, 12 Jan 2008 07:41:17 +0000 (23:41 -0800)]
Stop Coverity complaining about uninitialized variables.
Jeremy.

16 years agoFix CID 498. Ensure we don't prs_mem_free an uninitialized
Jeremy Allison [Sat, 12 Jan 2008 07:24:13 +0000 (23:24 -0800)]
Fix CID 498. Ensure we don't prs_mem_free an uninitialized
prs_struct.
Jeremy.

16 years agoFix CID 505 - don't copy uninitialized memory.
Jeremy Allison [Sat, 12 Jan 2008 07:17:23 +0000 (23:17 -0800)]
Fix CID 505 - don't copy uninitialized memory.
Jeremy.