samba.git
15 months agotorture krb5.kdc.canon: Correct principal being checked in TEST_AS_REQ_SELF stage
Andrew Bartlett [Sun, 2 Sep 2018 22:41:10 +0000 (10:41 +1200)]
torture krb5.kdc.canon: Correct principal being checked in TEST_AS_REQ_SELF stage

We have already checked the client principal.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
15 months agotorture: Confirm that this element of the krb5.kdc test does not pass against Windows
Andrew Bartlett [Mon, 27 Aug 2018 03:01:41 +0000 (15:01 +1200)]
torture: Confirm that this element of the krb5.kdc test does not pass against Windows

This should be fixed, but in the meantime add clue to avoid regressions on
bug 11539.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
15 months agoselftest/samba4.blackbox.export.keytab: Update to use a principal with SPN as UPN
Andrew Bartlett [Mon, 3 Sep 2018 08:26:17 +0000 (20:26 +1200)]
selftest/samba4.blackbox.export.keytab: Update to use a principal with SPN as UPN

The ability the kinit with an SPN (not also being a UPN) has gone away as
windows doesn't offer this functionality.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
15 months agoselftest: Add new test to run krb5.kdc.canon against a user with an SPN for a UPN
Andrew Bartlett [Mon, 27 Aug 2018 03:00:12 +0000 (15:00 +1200)]
selftest: Add new test to run krb5.kdc.canon against a user with an SPN for a UPN

The failures in this test compared with Windows Server 1709 are added to
knownfail.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
15 months agoRevert "s4/heimdal: allow SPNs in AS-REQ"
Andrew Bartlett [Thu, 30 Nov 2017 03:30:49 +0000 (16:30 +1300)]
Revert "s4/heimdal: allow SPNs in AS-REQ"

This reverts commit 20dc68050df7b1b0c9d06f8251183a0a6283fcaf.

Tests (the krb5.kdc testsuite) show this behaviour is incorrect.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
15 months agoselftest/samba4.blackbox.export.keytab: Remove stray exit 0 and so run cleanup
Andrew Bartlett [Mon, 3 Sep 2018 04:38:20 +0000 (16:38 +1200)]
selftest/samba4.blackbox.export.keytab: Remove stray exit 0 and so run cleanup

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
15 months agotorture: Add tests to prove that kinit to an SPN is not allowed (unless it is also...
Andrew Bartlett [Thu, 16 Nov 2017 01:01:56 +0000 (14:01 +1300)]
torture: Add tests to prove that kinit to an SPN is not allowed (unless it is also a UPN)

The krb5.kdc.canon testsuite has been updated to pass against Windows
Server 1709 in four modes:

* A normal user
* A user with a UPN
* A user with an SPN (machine account)
* A user with an SPN as the UPN

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
15 months agothird_party: Import exact files from waf-2.0.8/waflib
Andrew Bartlett [Tue, 4 Sep 2018 21:58:21 +0000 (09:58 +1200)]
third_party: Import exact files from waf-2.0.8/waflib

wget https://waf.io/waf-2.0.8.tar.bz2
tar -xf waf-2.0.8.tar.bz2
rsync -a waf-2.0.8/waflib/ third_party/waf/waflib/

The previous import was damaged by auto-strip/correct of whitespace
and had other small corrections.

Check with git show -w.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep  5 09:29:39 CEST 2018 on sn-devel-144

15 months agoscript/autobuild: Fix formatting in send_email
Alexander Bokovoy [Mon, 3 Sep 2018 10:20:31 +0000 (13:20 +0300)]
script/autobuild: Fix formatting in send_email

Commit cb40e2bbc8a34a1ec3584ab585c5bf44c037ef0e introduced a print
statement with a broken formatting. Reported by pylint.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoscript/autobuild: re-use CACHE_SUFFIX from waflib
Alexander Bokovoy [Mon, 3 Sep 2018 10:07:23 +0000 (13:07 +0300)]
script/autobuild: re-use CACHE_SUFFIX from waflib

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: use CACHE_SUFFIX instead of a hard-coded name
Alexander Bokovoy [Mon, 3 Sep 2018 10:04:58 +0000 (13:04 +0300)]
buildtools/wafsamba: use CACHE_SUFFIX instead of a hard-coded name

waflib.Build provides CACHE_SUFFIX constant to append to the target
name. We have a reference to samba-specific cache suffix (.cache.py)
while original WAF uses _cache.py as a cache suffix since 2011 (see
commit 44a967e326cc2e670a31b3712e4763b72d65e81b in WAF project code).

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/mscat: fix logging in wscript
Alexander Bokovoy [Mon, 3 Sep 2018 09:51:59 +0000 (12:51 +0300)]
lib/mscat: fix logging in wscript

15 months agolib/audit_logging: update to waf 2.0
Alexander Bokovoy [Thu, 5 Jul 2018 11:26:57 +0000 (14:26 +0300)]
lib/audit_logging: update to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: remove ENFORCE_GROUP_ORDERING
Alexander Bokovoy [Wed, 4 Jul 2018 08:47:42 +0000 (11:47 +0300)]
buildtools/wafsamba: remove ENFORCE_GROUP_ORDERING

ENFORCE_GROUP_ORDERING is not needed with waf 2.0 anymore

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoctdb/wscript: rework how version number is retrieved
Alexander Bokovoy [Wed, 4 Jul 2018 08:05:10 +0000 (11:05 +0300)]
ctdb/wscript: rework how version number is retrieved

Using default context functions before waf initialization occured
is prone to error. Postpone calling samba_version.* code until we
got default context initialized.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoselftest/tests.py: update to support waf 2.0
Alexander Bokovoy [Tue, 3 Jul 2018 11:57:48 +0000 (14:57 +0300)]
selftest/tests.py: update to support waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript: port build_system_heimdal to waf 2.0
Alexander Bokovoy [Tue, 3 Jul 2018 10:07:44 +0000 (13:07 +0300)]
wscript: port build_system_heimdal to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript: port build_system_mitkrb5 to waf 2.0
Alexander Bokovoy [Tue, 3 Jul 2018 10:07:09 +0000 (13:07 +0300)]
wscript: port build_system_mitkrb5 to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: port stale_files to waf 2.0
Alexander Bokovoy [Tue, 3 Jul 2018 10:06:40 +0000 (13:06 +0300)]
buildtools/wafsamba: port stale_files to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: generate build options output with waf 2.0
Alexander Bokovoy [Tue, 3 Jul 2018 09:48:39 +0000 (12:48 +0300)]
buildtools/wafsamba: generate build options output with waf 2.0

With WAF 2.0 we get all defines in environment at the same level.
Fix build options source code generator to handle this.

I felt uneasy at filtering out some defines so instead the code
is mangling generic defines to be correct for C compiler by
replacing '-', '.', and '()' with an underscore ('_').

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoselftest/wscript: properly handle env.cwd which is a list, not a string
Alexander Bokovoy [Tue, 3 Jul 2018 08:18:05 +0000 (11:18 +0300)]
selftest/wscript: properly handle env.cwd which is a list, not a string

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowafsamba: install Python modules back to bin/python, not bin/python_modules
Alexander Bokovoy [Tue, 3 Jul 2018 08:09:12 +0000 (11:09 +0300)]
wafsamba: install Python modules back to bin/python, not bin/python_modules

Partially revert 80fce353e740c793619005ac102ab07fb5e7d280 which started
installing generated Python modules into python_modules directory back
in 2013. This, unfortunately, does not work anymore as Python gets quite
confused with our setup even when both bin/python and bin/python_modules
directories are part of sys.path.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: use cflags instead of ccflags for waf 2.0
Alexander Bokovoy [Wed, 27 Jun 2018 13:44:12 +0000 (16:44 +0300)]
buildtools/wafsamba: use cflags instead of ccflags for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: use context instead of options for cross-compile checks for...
Alexander Bokovoy [Wed, 27 Jun 2018 13:42:29 +0000 (16:42 +0300)]
buildtools/wafsamba: use context instead of options for cross-compile checks for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: crosscompile should use Utils.subprocess in waf 2.0
Alexander Bokovoy [Wed, 27 Jun 2018 13:34:53 +0000 (16:34 +0300)]
buildtools/wafsamba: crosscompile should use Utils.subprocess in waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: use top and out for waf 2.0
Alexander Bokovoy [Wed, 27 Jun 2018 12:03:08 +0000 (15:03 +0300)]
buildtools/wafsamba: use top and out for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agocdtb/wscript: use top and out for waf 2.0
Alexander Bokovoy [Wed, 27 Jun 2018 11:56:32 +0000 (14:56 +0300)]
cdtb/wscript: use top and out for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript: adopt to waf 2.0
Alexander Bokovoy [Wed, 27 Jun 2018 11:54:09 +0000 (14:54 +0300)]
wscript: adopt to waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: use top for waf 2.0
Alexander Bokovoy [Wed, 27 Jun 2018 11:33:36 +0000 (14:33 +0300)]
buildtools/wafsamba: use top for waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: change SAMBA_BUILD_ENV to use bldnode.abspath()
Alexander Bokovoy [Wed, 27 Jun 2018 10:45:56 +0000 (13:45 +0300)]
buildtools/wafsamba: change SAMBA_BUILD_ENV to use bldnode.abspath()

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoselftest/wscript: handle lists in environmental variables in waf
Alexander Bokovoy [Wed, 27 Jun 2018 09:26:09 +0000 (12:26 +0300)]
selftest/wscript: handle lists in environmental variables in waf

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowaf heimdal: use absolute path to compile_et
Alexander Bokovoy [Tue, 26 Jun 2018 21:25:03 +0000 (00:25 +0300)]
waf heimdal: use absolute path to compile_et

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowafsamba: use correct context for APPNAME
Alexander Bokovoy [Tue, 26 Jun 2018 21:24:31 +0000 (00:24 +0300)]
wafsamba: use correct context for APPNAME

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: compile asn1 files by adding missing code from compat15
Thomas Nagy [Tue, 26 Jun 2018 19:16:26 +0000 (21:16 +0200)]
buildtools/wafsamba: compile asn1 files by adding missing code from compat15

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript: adopt to waf-2.0
Alexander Bokovoy [Fri, 15 Jun 2018 14:03:28 +0000 (17:03 +0300)]
wscript: adopt to waf-2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoctdb/wscript: adopt to waf-2.0
Alexander Bokovoy [Fri, 15 Jun 2018 14:01:59 +0000 (17:01 +0300)]
ctdb/wscript: adopt to waf-2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba/samba_abi: always_run helper was deprecated in waf 2.0
Alexander Bokovoy [Fri, 15 Jun 2018 13:32:33 +0000 (16:32 +0300)]
buildtools/wafsamba/samba_abi: always_run helper was deprecated in waf 2.0

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource3/libsmb/wscript: remove unneeded import
Alexander Bokovoy [Fri, 15 Jun 2018 13:21:06 +0000 (16:21 +0300)]
source3/libsmb/wscript: remove unneeded import

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agonsswitch/libwbclient/wscript: import from waflib
Alexander Bokovoy [Fri, 15 Jun 2018 13:20:34 +0000 (16:20 +0300)]
nsswitch/libwbclient/wscript: import from waflib

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoauth/wscript: import from waflib
Alexander Bokovoy [Fri, 15 Jun 2018 13:18:34 +0000 (16:18 +0300)]
auth/wscript: import from waflib

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: add install_dir to build context
Alexander Bokovoy [Wed, 27 Jun 2018 13:06:44 +0000 (16:06 +0300)]
buildtools/wafsamba: add install_dir to build context

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: reduce imports
Alexander Bokovoy [Fri, 15 Jun 2018 13:17:14 +0000 (16:17 +0300)]
buildtools/wafsamba: reduce imports

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuildtools/wafsamba: adopt to waf 2.0.8
Alexander Bokovoy [Fri, 15 Jun 2018 10:32:00 +0000 (13:32 +0300)]
buildtools/wafsamba: adopt to waf 2.0.8

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/waf: upgrade to waf 2.0.8
Alexander Bokovoy [Fri, 15 Jun 2018 10:29:45 +0000 (13:29 +0300)]
third_party/waf: upgrade to waf 2.0.8

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoauth/wscript: fix options use
Alexander Bokovoy [Tue, 5 Jun 2018 16:24:55 +0000 (19:24 +0300)]
auth/wscript: fix options use

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoheimdal wscript changes
Alexander Bokovoy [Fri, 20 Apr 2018 11:01:51 +0000 (14:01 +0300)]
heimdal wscript changes

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript_configure_system_mitkrb5: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
wscript_configure_system_mitkrb5: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript_build_embedded_heimdal: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
wscript_build_embedded_heimdal: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript_build: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agowscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
third_party/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/uid_wrapper/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
third_party/uid_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/socket_wrapper/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
third_party/socket_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/resolv_wrapper/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
third_party/resolv_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/popt/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:33 +0000 (16:34 +0200)]
third_party/popt/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/pam_wrapper/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
third_party/pam_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/nss_wrapper/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
third_party/nss_wrapper/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/cmocka/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
third_party/cmocka/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party/aesni-intel/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
third_party/aesni-intel/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agotestsuite/headers/wscript_build: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
testsuite/headers/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource4/lib/tls/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
source4/lib/tls/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource4/heimdal_build/wscript_configure: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
source4/heimdal_build/wscript_configure: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource4/heimdal_build/wscript_build: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
source4/heimdal_build/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource4/dsdb/samdb/ldb_modules/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
source4/dsdb/samdb/ldb_modules/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource3/wscript_configure_system_ncurses: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
source3/wscript_configure_system_ncurses: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource3/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
source3/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosource3/build/charset.py: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
source3/build/charset.py: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoselftest/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
selftest/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agopython/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:32 +0000 (16:34 +0200)]
python/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agopidl/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
pidl/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agopackaging/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
packaging/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agonsswitch/wscript_build: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
nsswitch/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/util/wscript_configure: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/util/wscript_configure: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/util/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/util/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/tevent/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/tevent/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/tdb/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/tdb/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/talloc/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/talloc/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/replace/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/replace/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/ldb/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/ldb/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/crypto/wscript_configure: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/crypto/wscript_configure: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agolib/crypto/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
lib/crypto/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agodynconfig/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
dynconfig/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agodocs-xml/wscript_build: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:31 +0000 (16:34 +0200)]
docs-xml/wscript_build: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoctdb/wscript: update to handle waf 2.0.4
Alexander Bokovoy [Fri, 2 Feb 2018 14:34:30 +0000 (16:34 +0200)]
ctdb/wscript: update to handle waf 2.0.4

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothird_party:waf: update to upstream 2.0.4 release
Alexander Bokovoy [Wed, 31 Jan 2018 09:48:43 +0000 (11:48 +0200)]
third_party:waf: update to upstream 2.0.4 release

Update third_party/waf/ to 2.0.4 to bring us closer to Python 3

This change requires a number of changes in buildtools/ too.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuild:wafsamba: Remove unnecessary parameters to cmd_and_log
Thomas Nagy [Tue, 29 Aug 2017 18:54:43 +0000 (20:54 +0200)]
build:wafsamba: Remove unnecessary parameters to cmd_and_log

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuild:wafsamba: Ignore cfg_file absolute paths differences
Thomas Nagy [Sat, 15 Apr 2017 16:56:11 +0000 (18:56 +0200)]
build:wafsamba: Ignore cfg_file absolute paths differences

Due to build variants, cfg_file paths are written as absolute paths.

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agothirdparty:waf: New files for waf 1.9.10
Thomas Nagy [Sat, 26 Mar 2016 12:32:11 +0000 (13:32 +0100)]
thirdparty:waf: New files for waf 1.9.10

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoselftest/tests.py: Update path to waflib
Thomas Nagy [Thu, 13 Apr 2017 16:48:20 +0000 (18:48 +0200)]
selftest/tests.py: Update path to waflib

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoscript/autobuild: use --out instead of -b when calling configure
Thomas Nagy [Thu, 13 Apr 2017 16:47:50 +0000 (18:47 +0200)]
script/autobuild: use --out instead of -b when calling configure

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuild:wafsamba: detail where we are processing the autobuild
Thomas Nagy [Thu, 13 Apr 2017 16:46:50 +0000 (18:46 +0200)]
build:wafsamba: detail where we are processing the autobuild

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuild:wafsamba: Update dist/distcheck commands
Thomas Nagy [Thu, 13 Apr 2017 16:45:50 +0000 (18:45 +0200)]
build:wafsamba: Update dist/distcheck commands

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agobuild:wafsamba: Build on waf 1.9
Thomas Nagy [Sat, 26 Mar 2016 12:18:07 +0000 (13:18 +0100)]
build:wafsamba: Build on waf 1.9

Signed-off-by: Thomas Nagy <tnagy@waf.io>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agokrb5-samba: interdomain trust uses different salt principal
Alexander Bokovoy [Fri, 16 Feb 2018 16:15:28 +0000 (18:15 +0200)]
krb5-samba: interdomain trust uses different salt principal

Salt principal for the interdomain trust is krbtgt/DOMAIN@REALM where
DOMAIN is the sAMAccountName without the dollar sign ($)

The salt principal for the BLA$ user object was generated wrong.

dn: CN=bla.base,CN=System,DC=w4edom-l4,DC=base
securityIdentifier: S-1-5-21-4053568372-2049667917-3384589010
trustDirection: 3
trustPartner: bla.base
trustPosixOffset: -2147483648
trustType: 2
trustAttributes: 8
flatName: BLA

dn: CN=BLA$,CN=Users,DC=w4edom-l4,DC=base
userAccountControl: 2080
primaryGroupID: 513
objectSid: S-1-5-21-278041429-3399921908-1452754838-1597
accountExpires: 9223372036854775807
sAMAccountName: BLA$
sAMAccountType: 805306370
pwdLastSet: 131485652467995000

The salt stored by Windows in the package_PrimaryKerberosBlob
(within supplementalCredentials) seems to be
'W4EDOM-L4.BASEkrbtgtBLA' for the above trust
and Samba stores 'W4EDOM-L4.BASEBLA$'.

While the salt used when building the keys from
trustAuthOutgoing/trustAuthIncoming is
'W4EDOM-L4.BASEkrbtgtBLA.BASE', which we handle correct.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Sep  5 03:57:22 CEST 2018 on sn-devel-144

15 months agotestprogs/blackbox: let test_trust_user_account.sh check the correct kerberos salt
Stefan Metzmacher [Tue, 4 Sep 2018 08:53:52 +0000 (10:53 +0200)]
testprogs/blackbox: let test_trust_user_account.sh check the correct kerberos salt

This demonstrates the bug we currently have.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agotestprogs/blackbox: add testit[_expect_failure]_grep() to subunit.sh
Stefan Metzmacher [Tue, 4 Sep 2018 08:38:44 +0000 (10:38 +0200)]
testprogs/blackbox: add testit[_expect_failure]_grep() to subunit.sh

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agosamba-tool: add virtualKerberosSalt attribute to 'user getpassword/syncpasswords'
Stefan Metzmacher [Tue, 4 Sep 2018 08:16:59 +0000 (10:16 +0200)]
samba-tool: add virtualKerberosSalt attribute to 'user getpassword/syncpasswords'

This might be useful for someone, but at least it's very useful for
tests.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agos4:selftest: test kinit with the interdomain trust user account
Alexander Bokovoy [Fri, 16 Feb 2018 16:15:28 +0000 (18:15 +0200)]
s4:selftest: test kinit with the interdomain trust user account

To test it, add a blackbox test that ensures we pass a keytab-based
authentication with the trust user account for a trusted domain.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13539

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agoexamples: Fix mingw64 detection
Volker Lendecke [Tue, 4 Sep 2018 08:26:18 +0000 (10:26 +0200)]
examples: Fix mingw64 detection

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
15 months agos3:vfs: fix valgrind warning in SMB_VFS_{PREAD,PWRITE,FSYNC}_RECV()
Stefan Metzmacher [Wed, 29 Aug 2018 02:24:46 +0000 (04:24 +0200)]
s3:vfs: fix valgrind warning in SMB_VFS_{PREAD,PWRITE,FSYNC}_RECV()

tevent_req_received() destroys 'state', so we need helper variables
to hold the return value.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Sep  4 10:45:10 CEST 2018 on sn-devel-144