Andrew Tridgell [Sat, 5 Sep 1998 05:07:05 +0000 (05:07 +0000)]
tridge the destroyer returns!
prompted by the interpret_security() dead code that Jean-Francois
pointed out I added a make target "finddead" that finds potentially
dead (ie. unused) code. It spat out 304 function names ...
I went through these are deleted many of them, making others static
(finddead also reports functions that are used only in the local
file).
in doing this I have almost certainly deleted some useful code. I may
have even prevented compilation with some compile options. I
apologise. I decided it was better to get rid of this code now and add
back the one or two functions that are needed than to keep all this
baggage.
So, if I have done a bit too much "destroying" then let me know. Keep
the swearing to a minimum :)
One bit I didn't do is the ubibt code. Chris, can you look at that?
Heaps of unused functions there. Can they be made static?
(This used to be commit
2204475c87f3024ea8fd1fbd7385b2def617a46f)
Jeremy Allison [Sat, 5 Sep 1998 03:38:50 +0000 (03:38 +0000)]
Fixed one more Debug problem with inode in non-64 bit case.
Jeremy.
(This used to be commit
94d63cc382ac0d8a523db98b93750225082b09b1)
Jeremy Allison [Sat, 5 Sep 1998 03:14:40 +0000 (03:14 +0000)]
Bugfix for leak in reference counted file struct.
Added "nt smb support" parameter to allow NT SMB's to be turned off.
Jeremy.
(This used to be commit
63f65f5027d5022153fa2757b49c56829db1725b)
Andrew Tridgell [Sat, 5 Sep 1998 01:12:07 +0000 (01:12 +0000)]
got rid of interpret_security(). Thanks to Jean-Francois for pointing
out it is no longer used (replaced by enumerated types in loadparm.c)
(This used to be commit
88df8a8b25921389ee9d017b770bbae143cc51b8)
Jeremy Allison [Fri, 4 Sep 1998 20:53:58 +0000 (20:53 +0000)]
Modified dev_t and ino_t code to be 64 bit clean (including changes
to oplock break message passing). I think that smbd/nmbd are now
inode and offset size independent (at least for 32 bit and 64 bit
systems).
Now to expose all this new functionality to NT clients.....
Jeremy.
(This used to be commit
5910d07bbf45a34d3c901461f74704c029a79474)
Jeremy Allison [Fri, 4 Sep 1998 16:06:04 +0000 (16:06 +0000)]
Fixed uppercasing of share name (pointed out by Jean-Francois).
Jeremy.
(This used to be commit
dcce6b98d847d02148fb2ab15f8430b870e106bd)
Jeremy Allison [Fri, 4 Sep 1998 00:23:28 +0000 (00:23 +0000)]
More 64 bit stuff - now the fcntl locks are 64 bit clean.
Nearly at the stage where I can expose the 64-bit-ness to
the NT clients....
Jeremy.
(This used to be commit
422f1dd45074c0e28203aca5952e57bbe56676b6)
Jeremy Allison [Thu, 3 Sep 1998 18:40:31 +0000 (18:40 +0000)]
Ok - this is the 64 bit widening check in. It changes the configure
to check for stat64 and friends, and then changes much of Samba
to use the data type SMB_OFF_T for file size information.
stat/fstat/lstat/lseek/ftruncate have now become sys_stat etc. to hide
the 64 bit calls if needed.
Note that this still does not expose 64 bit functionality to the
client, as the changes to the reply_xxx smb's are not yet done.
This code change should make these changes possible.
Still to do before full 64 bit-ness to the client:
fcntl lock code.
statfs code
widening of dev_t and ino_t (now possible due to SMB_DEV_T and SMB_OFF_T
types being in place).
Let me know if wierd things happen after this check-in and I'll
fix them :-).
Jeremy.
(This used to be commit
14500936c321d15995c963766aac67bf1f4e3824)
Andrew Tridgell [Thu, 3 Sep 1998 05:37:15 +0000 (05:37 +0000)]
changed the SMBtrans reply code to align at the same alignment as
observed from NT. We were aligning the data before but not the
parameters. This aligns both.
This change may break some other parts of ipc.c if we have relied on
the alignment somewhere, so if you think this broke something then let
me know.
(This used to be commit
d252d331015b7606618ba1422bb669da003da293)
Andrew Tridgell [Thu, 3 Sep 1998 05:35:13 +0000 (05:35 +0000)]
we were setting the strings 1 too long in make_srv_share_info1_str()
(This used to be commit
29e1e59db8035e0fd2c088a969fa17549ce1b897)
Andrew Tridgell [Thu, 3 Sep 1998 03:14:31 +0000 (03:14 +0000)]
fixed a bug in the name mangling code. It implicitly assumed that
mangling a name can't increase it's size which isn't true. (imagine a
file called "L B" which mangles to "LB~XX")
The symptoms were that users couldn't run batch files from short
directory names that contained non 8.3 characters (such as spaces).
(This used to be commit
c319d8ea3f8b42bb3a8e501642971ed0bdb21583)
Jeremy Allison [Wed, 2 Sep 1998 17:23:41 +0000 (17:23 +0000)]
Fix for PR#9497 - not waiting for child.
Jeremy.
(This used to be commit
e817d836bba3aaf0f732d66bc5a4383a7f7005db)
Andrew Tridgell [Wed, 2 Sep 1998 05:00:47 +0000 (05:00 +0000)]
we are never interested in SIGPIPE so just ignore (block) it
always. Don't even install a handler.
(This used to be commit
72c383f4b7bcce5374632dc972df16ab0e2542b9)
Andrew Tridgell [Wed, 2 Sep 1998 02:12:07 +0000 (02:12 +0000)]
changed ref to samba.gif to use /swat/ prefix
(This used to be commit
f297662d64da9423e3d2efc6c602e40613c4236e)
Andrew Tridgell [Wed, 2 Sep 1998 02:02:30 +0000 (02:02 +0000)]
use /swat/ prefix in both inetd and cgi modes, to enable a static header.html
(This used to be commit
ddb788c24d043b18506138a7759b8128df1673aa)
Jeremy Allison [Tue, 1 Sep 1998 20:17:16 +0000 (20:17 +0000)]
Missed one struct stat.
Jeremy.
(This used to be commit
03ae657a36c986ba4248b297e64ec7898a1914e6)
Jeremy Allison [Tue, 1 Sep 1998 20:11:54 +0000 (20:11 +0000)]
More abstraction of file system data types, to move to a 64
bit file interface for the NT SMB's.
Created a new define, SMB_STRUCT_STAT that currently is
defined to be struct stat - this wil change to a user
defined type containing 64 bit info when the correct
wrappers are written for 64 bit stat(), fstat() and lstat()
calls.
Also changed all sys_xxxx() calls that were previously just
wrappers to the same call prefixed by a dos_to_unix() call
into dos_xxxx() calls. This makes it explicit when a pathname
translation is being done, and when it is not.
Now, all sys_xxx() calls are meant to be wrappers to mask
OS differences, and not silently converting filenames on
the fly.
Jeremy.
(This used to be commit
28aa182dbffaa4ffd86047e608400de4b26e80eb)
Andrew Tridgell [Tue, 1 Sep 1998 07:10:44 +0000 (07:10 +0000)]
Matthew is no longer wokring on SWAT
(This used to be commit
8bd2cf0eb7533c3ec2d5767163ffdaf20b01bbff)
Andrew Tridgell [Tue, 1 Sep 1998 06:03:52 +0000 (06:03 +0000)]
need to istall new files
(This used to be commit
c53ead308e941baa4524b9ec62d74290ce91503f)
Andrew Tridgell [Tue, 1 Sep 1998 06:03:03 +0000 (06:03 +0000)]
spruced up SWAT a bit - it now uses the new Samba logo at the top and
a table to give it a little border
(This used to be commit
d35c6e80988d96049d4624b47ae9ea015edafc59)
Andrew Tridgell [Tue, 1 Sep 1998 06:01:19 +0000 (06:01 +0000)]
fixed a bug in the base64 hanlding that led to auth failures for some
passwords with SWAT
(This used to be commit
edcde70108ab643a29f3e0e0cc97609287da6e87)
Andrew Tridgell [Tue, 1 Sep 1998 01:10:01 +0000 (01:10 +0000)]
check that a valid pipe is passed before doing a pipe close.
I made this change after getting a segv in reply_pipe_close(). The
funny thing was that pipes_open was 1 and Pipes was NULL. That "can't
happen" and suggests that we have a wild pointer somewhere.
I suspect the rpc code, as I was playing with long share names (a
share called "averylongusername") at the time and the logs show lots
of srvsvc operations. I bet there is a buffer in the rpc code
somewhere that is overflowing and trashing bits of the data segment.
(This used to be commit
9fee8c2eb7bd05431cd9bcfbed3804c8ca1ee593)
Jeremy Allison [Mon, 31 Aug 1998 20:20:54 +0000 (20:20 +0000)]
configure.in, configure: include/config.h.in: Added stropts and poll.
include/smb.h: Moved old typedefs of uint8 etc. into include/includes.h where
all the other defines live (changed them from typedefs to
defines).
Other changes : changed from using uint32 to SMB_DEV_T and SMB_INO_T
in preparation for moving to size independed (ie. 64 bit clean) device
and inode access. Stat call wrapper comes next :-).
Jeremy.
(This used to be commit
3d9ec96de5e04e83abafe9c5d980bd39eee856ea)
Christopher R. Hertel [Mon, 31 Aug 1998 14:46:19 +0000 (14:46 +0000)]
I added notes about the changes I've made to 2.0.0. I put the change to
nmbd default behavior (appending to logs instead of overwriting them) into
the "Major Changes" section, but added a "Minor Changes" section for the
things that wouldn't affect the running of Samba itself (eg., the splay
tree for WINS and the change to DEBUG output).
Chris -)-----
(This used to be commit
d4b714a6be9ccf8a66d7abe0d6d14a810a5f182a)
Andrew Tridgell [Mon, 31 Aug 1998 09:38:50 +0000 (09:38 +0000)]
I looked at the refresh issue a bit more and discovered that Samba
also doesn't switch to a registration if a refresh fails, instead the
name is removed! This makes it even more imortant that a Samba WINS
server accepts refresh requests as registration requests if the name
is not registered. I've gone ahead and implemented this.
(This used to be commit
07f825fc9491bb5adac047854e67c63f7757143b)
Andrew Tridgell [Mon, 31 Aug 1998 07:23:11 +0000 (07:23 +0000)]
minor fixes to the DMB<->DMB sync code. We now get the dmb name from
the local_master name on the unicast subnet if it is unknown.
(This used to be commit
222b6d90e09288091028f5e0435f1d4a74153f66)
Andrew Tridgell [Mon, 31 Aug 1998 07:21:54 +0000 (07:21 +0000)]
if an address is ipzero in cli_connect() then do a name query
(This used to be commit
0a5718b0aef29706be81a50f2ac2c5eb4c6fbb32)
Andrew Tridgell [Mon, 31 Aug 1998 06:59:23 +0000 (06:59 +0000)]
I realised that my DMB<->DMB sync code has the property that the
amount of network traffic grows as the square of the number of
workgroups. It probably wouldn't have caused problems but to be safe I
changed the code to use random() to decrease the probability of a
DMB<->DMB sync in proportion to the number of known workgroups. This
keeps the nice browse connectivity while making the traffic rise only
linearly with the number of workgroups.
(This used to be commit
685f4ef2e1f83ab39e91229cf53a61eecb6181eb)
Samba Release Account [Mon, 31 Aug 1998 05:26:18 +0000 (05:26 +0000)]
preparing for release of 2.0.0 alpha 1
(This used to be commit
d7e50f0111f6c65b9d6f8654684e7fc5a1e7ea32)
Samba Release Account [Mon, 31 Aug 1998 05:23:33 +0000 (05:23 +0000)]
preparing for release of 2.0.0 alpha
(This used to be commit
70b8c9f05e96a3b3107e66ca32d532133bec8082)
Andrew Tridgell [Mon, 31 Aug 1998 05:21:39 +0000 (05:21 +0000)]
fixed a comment
(This used to be commit
560ed560f46e69255b6437e50ba0865b642c38b1)
Andrew Tridgell [Mon, 31 Aug 1998 05:21:09 +0000 (05:21 +0000)]
updated the WHATSNEW in preparation for an alpha release
(This used to be commit
2f09b68e52a3af712d86732ed674e1e616768d65)
Andrew Tridgell [Mon, 31 Aug 1998 04:19:31 +0000 (04:19 +0000)]
set a maximum name refresh time of 20 minutes.
The previous code was strictly correct, but not very practical. self
names were only refreshed every 3 days. I hit a situation where the
Samba WINS server was restarted after deleting wins.dat and didn't
notice some remote subnets (also running Samba). I realised that the
complete database wouldn't have been rebuilt for 3 days, which is way
too long. In order to recover from WINS restarts we need a much
shorter maximum refresh time.
(This used to be commit
1d23dd0912e81ff72695bd043e8e2aee32da18a8)
Andrew Tridgell [Mon, 31 Aug 1998 03:13:20 +0000 (03:13 +0000)]
cast the qsort to prevent warnings
(This used to be commit
55333edd2eed33961ced4eb4b6898f5ca9ca1820)
Andrew Tridgell [Mon, 31 Aug 1998 03:11:42 +0000 (03:11 +0000)]
bounds check next_token() to prevent possible buffer overflows
(This used to be commit
3eade55dc7c842bdc50205c330802d211fae54d3)
Andrew Tridgell [Sun, 30 Aug 1998 17:04:24 +0000 (17:04 +0000)]
added a dest_port parameter to send_mailslot() so we send replies to
the correct port in environments like ip masq.
(This used to be commit
7d455ee637b6ff70c95845f89d71573ca07b83f3)
Andrew Tridgell [Sun, 30 Aug 1998 16:33:48 +0000 (16:33 +0000)]
a couple of debug lines
(This used to be commit
03d343ddf5ef672afb3cf1fa65f86eb2c0a48772)
Andrew Tridgell [Sun, 30 Aug 1998 15:58:17 +0000 (15:58 +0000)]
finished the asynchronous browse synchronisation code. It even seems
to work (not a lot of testing yet though).
Now we just need to deal with people worried about having more than
two nmbd processes sometimes. (the async processes are created on
demand for browse sync, so you'll only see more than 2 occasionally)
(This used to be commit
a350a54680e4170e2adf571b010ea508e7291780)
Andrew Tridgell [Sun, 30 Aug 1998 12:32:45 +0000 (12:32 +0000)]
This should fix the zombie problem that luke noticed.
(This used to be commit
425ccf9271ea44879d0940b9d95ae9b8f95aa092)
Andrew Tridgell [Sun, 30 Aug 1998 09:50:45 +0000 (09:50 +0000)]
we we have successfully done a query on *<1b> from a wins server and
then obtained a node status response we need to remember the server
name of the master browser so that other browse clients asking us for
a workgroup list will get a entry for the master of that workgroup.
(This used to be commit
601f995ffbfa0ee477ea628d92b9660d6bdd8cbc)
Andrew Tridgell [Sun, 30 Aug 1998 08:45:23 +0000 (08:45 +0000)]
changed the way that name query records are sorted in replies. They
are now sorted by the number of common leading bits in the IP address
with the address of the querying host.
(This used to be commit
4460a1bc6aa7666d1c71d32ba73855d6ed32320a)
Andrew Tridgell [Sun, 30 Aug 1998 06:49:14 +0000 (06:49 +0000)]
include our netbios names list and our workgroup in the wins.dat hash
(This used to be commit
f555a76df696a0625acc16fa365dc048e0c2447d)
Andrew Tridgell [Sun, 30 Aug 1998 05:57:21 +0000 (05:57 +0000)]
don't put two spaces at the start of lines if logging to stdout
or not timestamping.
(This used to be commit
70ed0ec202c50655e3ba99535b06ad918409051e)
Andrew Tridgell [Sun, 30 Aug 1998 05:43:59 +0000 (05:43 +0000)]
changed the format of the wins.dat file slightly.
It now has a line like this:
VERSION 1 251152
the first number is a version #define in nmbd_winsserver.c and will be
used if we ever have to change the format again.
The second number is a hash of the current interfaces setting. It is
used to detect the case where nmbd is restarted on a machine after the
IP of the machine has changed (or the interfaces list has changed in
any way). When that happens we need to discard the old wins.dat cache
or you end up with chaos. This has bitten quite a few people, they
find that when they move a machine it continues using the old IP for
some things for the next week until the wins entries time out!
I've checked, and the old nmbd can handle the new format, although it
does spit out a spurious error message about the VERSION line. So
users can safely run 2.0alpha then switch back to 1.9.18 without
problems.
(This used to be commit
c4a8cdc60a5b01894ab2456e77b6d89d4c16a088)
Andrew Tridgell [Sun, 30 Aug 1998 04:37:07 +0000 (04:37 +0000)]
allow smbclient to connect to IPC$ as an IPC service
(This used to be commit
275679db29f2630a16cd5e9f4b5346ac834a484f)
Andrew Tridgell [Sun, 30 Aug 1998 04:35:54 +0000 (04:35 +0000)]
- zero shared memory before freeing it
- changed the hash size to 13 (much smaller than before). This should
make for more efficient shared memory usage as it will lead to less
fragmentation.
(This used to be commit
9c1e4c2dae6323c9a1bd74148d0b45aac61e7c0a)
Andrew Tridgell [Sun, 30 Aug 1998 04:31:55 +0000 (04:31 +0000)]
added a function zero_free(void *, int size) that zeros an area of
memory then frees it. Useful for catching bugs.
(This used to be commit
99782754f79f3795f81cbf57caeb0925f6a66c10)
Andrew Tridgell [Sun, 30 Aug 1998 04:30:57 +0000 (04:30 +0000)]
changed the size of a char array in the userdata_struct from 1 to 16
to account for padding/alignment issues. Eventually I'd like to find a
way to get rid of this construct altogether as it is a bit error
prone and hard to debug.
also added a new macro:
ZERO_STRUCTP() that takes a pointer to a structure and zeros the
structure. Used in nmbd to zero allocated structures before freeing
them to try to catch bugs a bit faster.
(This used to be commit
d3dda65d5177154e2128f50ca3dd34e8e13b6b08)
Andrew Tridgell [Sun, 30 Aug 1998 04:27:26 +0000 (04:27 +0000)]
added some defensive programming to nmbd. This mostly means zeroing
areas of memory before freeing them.
While doing this I also found a couple of real bugs. In two places we
were freeing some memory that came from the stack, which leads to
a certain core dump on many sytems.
(This used to be commit
c5e5c25c854e54f59291057ba47c4701b5910ebe)
Andrew Tridgell [Sat, 29 Aug 1998 14:08:17 +0000 (14:08 +0000)]
got rid of calls to update_protected_database(). It was causing core
dumps. It is gone until someone can tell us why its needed and what it
does. (It was only used on OSF1 and core dumped there anyway!)
(This used to be commit
a564e4662711d384069757ce3ee5adcadc1b061d)
Andrew Tridgell [Sat, 29 Aug 1998 03:10:39 +0000 (03:10 +0000)]
don't exit on a SIGPIPE
(This used to be commit
f18b4e95bffb25fa016dd6e7f9a128a9fc69466f)
Jeremy Allison [Fri, 28 Aug 1998 21:46:29 +0000 (21:46 +0000)]
This checking fixes the statcache bug that stopped NetBench from running
correctly. Added new parameter "stat cache size" - set to 50 by default.
I now declare the statcache code officially "open" for business :-).
It gets a hit rate of 97% with a NetBench run and seems to make
using a case insensitive run as efficient as a case sensitive run.
Also tidied up our sys_select usage - added a maxfd parameter and
also added an implementation of select in terms of poll(), for systems
where poll() is much faster. This is disabled by default.
Jeremy.
(This used to be commit
779b924ec1f6c81ff578d22295b20fece698d1fc)
Andrew Tridgell [Fri, 28 Aug 1998 14:35:24 +0000 (14:35 +0000)]
nmbd would core dump if a large number of netbios aliases is set. The
problem was a buffer overflow in process_node_status_request().
this really points out a general problem is allocating MAX_DGRAM_SIZE
packets on the stack in nmbd. There must be a better way.
(This used to be commit
7db45f169c33e0f3a67ba2260049226992de8bdf)
Jeremy Allison [Thu, 27 Aug 1998 20:51:12 +0000 (20:51 +0000)]
Fixed stat cache statistics calculation. Oops.
Jeremy.
(This used to be commit
d6a9087e7e626e6e07503dba38854b136fe70c23)
Jeremy Allison [Thu, 27 Aug 1998 20:38:53 +0000 (20:38 +0000)]
This is the stat cache code - seems to work fine (needs heavy
NetBench testing though.... :-). Attempts to efficiently reduce
the number of stat() calls Samba does.
Jeremy.
(This used to be commit
d0e48a2d8072c3e77a57ac6a2fb5044c05f03b41)
Luke Leighton [Wed, 26 Aug 1998 14:05:23 +0000 (14:05 +0000)]
oops - added /usr/include/rpc includes.
(This used to be commit
cdc38c276d8344127c9edf35f24754c098a90754)
Andrew Tridgell [Wed, 26 Aug 1998 03:06:48 +0000 (03:06 +0000)]
use a separate ZERO_ARRAY() macro instead of ZERO_STRUCT() for
arrays. This prevents (harmless) warnings from some compilers
(This used to be commit
c2da46d1d0820a86e7f77506563cfe7f67b08fee)
Andrew Tridgell [Wed, 26 Aug 1998 02:36:27 +0000 (02:36 +0000)]
get includes right for systems that use getpwanam()
(This used to be commit
afe98165a261a740cd0ee88bf041d69721ec72e6)
Andrew Tridgell [Wed, 26 Aug 1998 02:02:55 +0000 (02:02 +0000)]
took all the rpc includes back out until we can work out _why_ freebsd
needs them and what should really be there.
(This used to be commit
c2bf18fb8d2fea5af86ba8cf5d92b1dc076dd7d5)
Andrew Tridgell [Wed, 26 Aug 1998 01:57:17 +0000 (01:57 +0000)]
added a warning when loading a parameter that is deprecated
(This used to be commit
c8b0041570a1fb0be0318f511c6ba746c733cda9)
Christopher R. Hertel [Tue, 25 Aug 1998 15:53:49 +0000 (15:53 +0000)]
Finally got around to updating the man pages for nmbd and smbd to reflect
the changes made re: -a and -o options.
Chris -)-----
(This used to be commit
e162819054d0241e92978b6b630be8cccc886caf)
Luke Leighton [Tue, 25 Aug 1998 13:17:04 +0000 (13:17 +0000)]
added loads of pointless rpcsvc/ and rpc/ include files, all because
rpcsvc/ypclnt.h wants a struct dom_binding. knock-on include effect under
freebsd 2.1.
(This used to be commit
d1005b5692e41660a2a7230231b0591aa0773485)
Andrew Tridgell [Tue, 25 Aug 1998 07:19:34 +0000 (07:19 +0000)]
note that "alternate permissions" is deprecated in man page
(This used to be commit
2af95650174ae02a9768fbbbf7c206e15bf18f79)
Andrew Tridgell [Tue, 25 Aug 1998 06:52:26 +0000 (06:52 +0000)]
Andrew Tridgell [Tue, 25 Aug 1998 06:42:09 +0000 (06:42 +0000)]
some smbtorture hacks (random IPC calls)
(This used to be commit
b32a346a1c50ba40224b8165e08e78867be2d376)
Andrew Tridgell [Tue, 25 Aug 1998 06:40:42 +0000 (06:40 +0000)]
changed the default permissions code to do this:
if ((sbuf->st_mode & S_IWUSR) == 0)
result |= aRONLY;
rather than the very complex user/group permissions checks we do
currently. This is equivalent ot setting "alternate permissions = yes"
in the old code. The change is motivated by three main reasons:
1) it's basically impossible to second guess whether a file is
writeable without trying to open it for writing. ACLs, root squash etc
just make it too hard.
2) setting it not RONLY if the owner can write is closer to what NT
does (eg. look at a cdrom - files are not marked read only).
3) it prevents the silly problem of copying files from a read only
share to a writeable share and then finding you can't write to them as
windows preserves the RONLY flag. Lots of people get bitten by this
when they drag a folder from a Samba drive. It also hurts some install
programs.
I have also added a new flag type for loadparm.c called
FLAG_DEPRECATED which I've set for "alternate permissions". I'll soon
add code to testparm to give a warning about deprecated options.
(This used to be commit
c4363a12fdc0be329ca2bfeb1d7b89bfe90031dc)
Jeremy Allison [Tue, 25 Aug 1998 02:29:17 +0000 (02:29 +0000)]
Added code to (correctly) ignore TRANSACT2_SETFILEINFO with SMB_SET_FILE_ALLOCATION_INFO.
Office 97 expects this call to succeed when you tell it you do NT SMB calls.
Jeremy.
(This used to be commit
260e7e27401d863e9f580d4748c577334d9fc9d0)
Jeremy Allison [Mon, 24 Aug 1998 21:49:10 +0000 (21:49 +0000)]
Changed ASSERT macros to SMB_ASSERT macros as some systems already
have an ASSERT macro defined.
Jeremy.
(This used to be commit
dbe6ad014a8b5dcbf17d7cd9865650c2e040d666)
Luke Leighton [Mon, 24 Aug 1998 18:53:37 +0000 (18:53 +0000)]
resource.h on FreeBSD 2.1 requires sys/time.h to come first.
(This used to be commit
e94ab03a4f97ff7ee7bb938245cf054a00f950fd)
Andrew Tridgell [Sat, 22 Aug 1998 02:54:21 +0000 (02:54 +0000)]
added ASSERT() and ASSERT_ARRAY() macros and sprinkled them liberally
in the rpc code.
(This used to be commit
e6ce1c5b5a9f29d8fcbbd23019186ff5c600e795)
Andrew Tridgell [Sat, 22 Aug 1998 02:52:25 +0000 (02:52 +0000)]
expanded MAX_LOOKUP_SIDS to 30 (I saw 21 in a packet)
(This used to be commit
bd9290c36c9993a994e485da0a81df926f8662e4)
Christopher R. Hertel [Fri, 21 Aug 1998 19:57:59 +0000 (19:57 +0000)]
Just tweaking.
If the output line is longer than the format buffer could manage, I was
simply ignoring the additional output (that is, *not* copying it to the
format buffer--thus avoiding a buffer overrun). Instead, I now output
the current content followed by " +>\n", and then reset the format buffer.
I have never seen a debug line that exceeds the size of a pstring, but I
might as well handle the situation...just in case.
Chris -)-----
(This used to be commit
8a11d04b7796b256953bf92b2f2ccab763215bc4)
Christopher R. Hertel [Fri, 21 Aug 1998 17:21:55 +0000 (17:21 +0000)]
nmbd and smbd had different behavior with respect to log files. nmbd would
default to overwrite and smbd would default to append. Also, the -a option
(actually a toggle, such that "-a -a" would set the default) was documented
as append mode for nmbd, and *overwrite mode* for smbd.
nmbd now defaults to append mode, to match smbd. The -a option now always
means append, and I've added the -o option to both, meaning overwrite.
Note that the change to nmbd's default behavior may confuse some people.
I've not seen anything about 2.0.0 changes in the WHATSNEW.txt file.
Where would I document a change like this?
Chris -)-----
(This used to be commit
b1d374fb14b1fb92a84260f1dcc59a39a4b99a3d)
Andrew Tridgell [Fri, 21 Aug 1998 14:31:43 +0000 (14:31 +0000)]
don't attempt to answer QFILEINFO/SMB_QUERY_FILE_STREAM_INFO queries -
if we do then NTws gets a BSOD.
I checked and NT server refuses these queries too :)
(This used to be commit
d2fb7ee8f55dd1ff25fca46e18b02a05bc2b71ae)
John Terpstra [Fri, 21 Aug 1998 14:20:38 +0000 (14:20 +0000)]
Adding first cut of the new Red Hat Linux packaging tools.
Note: It is intended to extend this so that the release
process produces all the packaging scripts, templates, etc.
that may be needed.
(This used to be commit
6e196841c618044d33da45d3de5371004a58e4c6)
Andrew Tridgell [Fri, 21 Aug 1998 11:37:40 +0000 (11:37 +0000)]
added new smb.conf option "panic action". see my samba-technical
explanation.
(This used to be commit
c6899df44c34088a4d2bf1edc840320b0ba7e32e)
Andrew Tridgell [Fri, 21 Aug 1998 09:44:30 +0000 (09:44 +0000)]
use ZERO_STRUCT() to initialise lots of structures.
Luke, you need to do something similar in the rest of the rpc code.
Have fun!
(This used to be commit
bdd8aaa544780898e20189195d4019b9beb4445c)
Andrew Tridgell [Fri, 21 Aug 1998 09:43:21 +0000 (09:43 +0000)]
added a macro ZERO_STRUCT() which is useful for initialising
structures declared on the stack.
(This used to be commit
f323af8fce54cd5d51c848aa7ea7be4dd3538f2e)
Richard Sharpe [Fri, 21 Aug 1998 09:01:30 +0000 (09:01 +0000)]
Submitting the smbtar changes to the main branch as well.
Regards
Richard Sharpe
(This used to be commit
749ec1e0a79c5836bba0fc0213576ed79ef761d5)
John Terpstra [Fri, 21 Aug 1998 08:21:08 +0000 (08:21 +0000)]
Fix "make clean" to also delete SPROGS.
(This used to be commit
268cbede0fd909da1cb5bbc964244456f32006a6)
Andrew Tridgell [Fri, 21 Aug 1998 07:29:42 +0000 (07:29 +0000)]
and get the message right ...
(This used to be commit
0d641d0cebfbd8cc6015d2361e088ce0410c5d20)
Andrew Tridgell [Fri, 21 Aug 1998 07:25:57 +0000 (07:25 +0000)]
silly me.
perms on lock dir should be 755 not 644.
(This used to be commit
930a4292e95947d20696b7ce08bbb936442fe327)
Andrew Tridgell [Fri, 21 Aug 1998 05:58:57 +0000 (05:58 +0000)]
fixed a bug in trans2_qfilepathinfo() where we used the length of the
basename of a file but the whole file name. silly error.
(This used to be commit
6e00de7a1d3d5f9fa9bcc40db119fcb8602165c9)
Jeremy Allison [Fri, 21 Aug 1998 01:30:29 +0000 (01:30 +0000)]
Fixes for the problem in blocking locks with file_fsp returning the
chain_fsp on close (if you don't know what this means, consider yourself
lucky - this one took a day to track down :-).
Jeremy.
(This used to be commit
193cb5382464173e99a538867a266d793f0ceab5)
Jeremy Allison [Thu, 20 Aug 1998 19:28:37 +0000 (19:28 +0000)]
Turning on blocking locking code. NB. Blocking lock requests that are not
the head of an SMB request (ie. are part of a chain) will not be queued -
this will be fixed when we move to the new chain code. In practice, this
doesn't seem to cause much of a problem (in my admittedly limited testing)
bug a debug level zero message will be placed in the log when this
happens to help determine how real the problem is.
smbd/locking.c: New debug messages.
smbd/blocking.c: New blocking code - handles SMBlock, SMBlockread and SMBlockingX
smbd/chgpasswd.c: Fix for master fd leak.
smbd/files.c: Tidyup comment.
smbd/nttrans.c: Added fnum to debug message.
smbd/process.c: Made chain_reply() use construct_reply_common(). Added blocking
lock queue processing into idle loop.
smbd/reply.c: Added queue pushes for SMBlock, SMBlockread and SMBlockingX.
Jeremy.
(This used to be commit
e1dd03ecda0bc6d7eaa31070c83774bb5679fd1b)
Andrew Tridgell [Thu, 20 Aug 1998 03:11:46 +0000 (03:11 +0000)]
testparm now prints a warning if the lock directory doesn't have 0644
permissions.
(This used to be commit
10303a78d4b12a03166db89202759cd745c516c5)
Andrew Tridgell [Wed, 19 Aug 1998 15:01:03 +0000 (15:01 +0000)]
added a test for a working setresuid
(This used to be commit
dbe333b590ef004ccbd31a14ad161d73139b2486)
Jeremy Allison [Wed, 19 Aug 1998 01:49:57 +0000 (01:49 +0000)]
Blocking lock code split out...
Jeremy.
(This used to be commit
9cdb148ef56dc8f74891f5c6e9cae10142bd4c6e)
Jeremy Allison [Wed, 19 Aug 1998 01:49:34 +0000 (01:49 +0000)]
Makefile.in: Moved blocking lock code into smbd/blocking.c for link purposes.
include/includes.h: Added nterr.h.
locking/locking.c: Moved blocking lock code into smbd/blocking.c for link purposes.
smbd/close.c: Added blocking lock removal to file close.
smbd/filename.c: Tidied up unix_convert() so I could read it (:-) in preparation
for the stat_cache code.
smbd/nttrans.c: Added WRITE_ATTRIBUTES check.
smbd/reply.c: Fixed multibyte char problem in wildcard mask.
Jeremy.
(This used to be commit
148eaba3dadb1d0bd3ac3ef53da3d9811636e89a)
Jeremy Allison [Mon, 17 Aug 1998 23:39:59 +0000 (23:39 +0000)]
smbd/nttrans.c: Fixed bug in split off pipe code.
locking/locking.c: More blocking lock changes.
Jeremy.
(This used to be commit
2ca4fc95a4227645f1009a057d46b58508846a92)
Jeremy Allison [Mon, 17 Aug 1998 22:59:53 +0000 (22:59 +0000)]
Fixed bug introduced by the recent changes where the chain_fnum
could be overwritten in oplock processing code.
Jeremy.
(This used to be commit
908a583b48e37c5e869216f4dc92d4a587ff1238)
Andrew Tridgell [Mon, 17 Aug 1998 14:11:44 +0000 (14:11 +0000)]
removed some of the rough edges from the splitup
(This used to be commit
722312c326d54849e2552327fcd88ac77257ad2c)
Andrew Tridgell [Mon, 17 Aug 1998 13:44:05 +0000 (13:44 +0000)]
move soem variables from server.c that don't belong there.
(This used to be commit
f92475aa3cb3ade576c39c02c7996c949c42082a)
Andrew Tridgell [Mon, 17 Aug 1998 13:11:34 +0000 (13:11 +0000)]
this completes the splitup of server.c.
the splitup was done with an axe, not a scalpel, so there are some
rough edges. I mostly wanted to get the general form right with fine
tuning of what goes where to come later. Still, this is better than
what we had before where server.c was a general repository for
anything that didn't fit elsewhere.
(This used to be commit
a6d194886a4a5f7507fa37289ff96c1be56f14a6)
Andrew Tridgell [Mon, 17 Aug 1998 07:40:06 +0000 (07:40 +0000)]
more splitting of server.c
created dosmode.c and filename.c
(This used to be commit
534a90ca44641417c21f6ed6d4b94b1de60f808d)
Andrew Tridgell [Mon, 17 Aug 1998 07:15:54 +0000 (07:15 +0000)]
now that we have no global arrays we can start to split up the monster
server.c without breaking things.
this splits off netprot.c and fileio.c for negprot and read/write/seek
handling respectively.
(This used to be commit
b3d7014643ec9f2eef6e6f598f5b9db1fe2f930d)
Andrew Tridgell [Mon, 17 Aug 1998 06:47:53 +0000 (06:47 +0000)]
added some optimisation for the case where the number of open files is
very large. files.c now promotes a files_struct to the top of the list
if it is used when it is more than 10 elements from the top.
also moved common linked list code for the 5 sets of linked lists that
I've created over the past few days into dlinklist.h (I've explained
to Chris why I didn't use the ubiqx code)
(This used to be commit
1eb9ae2996b5a243a147f485e7e353d54f820852)
Andrew Tridgell [Mon, 17 Aug 1998 06:14:52 +0000 (06:14 +0000)]
reduced the memory footprint a bit by changing some large static int
arrays to uchar
(This used to be commit
01b642a3793a1bea0517370a9a64945fd86ddf02)
Andrew Tridgell [Mon, 17 Aug 1998 06:13:32 +0000 (06:13 +0000)]
moved connection_struct handling code into smbd/conn.c and changed it
to a linked list with bitmap format.
(This used to be commit
b7aaab1b6b2d2f72b2bb7c11f5c7bf081a6093d9)
Andrew Tridgell [Mon, 17 Aug 1998 04:54:06 +0000 (04:54 +0000)]
converted the policy code to use a linked list and bitmap. This saves
us a bit of memory.
(This used to be commit
27da84b90df1f32e0d07acad04c72065b2005470)