12 years agor22042: Try and clean up my own mess using the API Volker
Jeremy Allison [Mon, 2 Apr 2007 19:04:57 +0000 (19:04 +0000)]
r22042: Try and clean up my own mess using the API Volker
suggested. I now use :

BOOL is_offset_safe(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_str_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
int get_safe_SVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)
int get_safe_IVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)

Volker, please criticize and comment. Thanks,

(This used to be commit d47af7c9263f519e7307859b6a696d854c5dfca3)

12 years agor22039: fix compiler warnings
Stefan Metzmacher [Mon, 2 Apr 2007 18:42:56 +0000 (18:42 +0000)]
r22039: fix compiler warnings

(This used to be commit 91402d7a42d9930e8e67bc67423b8b79db27f12d)

12 years agor22033: remove useless line
Stefan Metzmacher [Mon, 2 Apr 2007 17:16:14 +0000 (17:16 +0000)]
r22033: remove useless line

(This used to be commit cb6d90d7963d8fc650b46355d7e6590d1e0654ad)

12 years agor22026: Missed in my last commit, another case where we need to copy, not reference.
Andrew Bartlett [Mon, 2 Apr 2007 12:52:08 +0000 (12:52 +0000)]
r22026: Missed in my last commit, another case where we need to copy, not reference.

Andrew Bartlett
(This used to be commit 635b83a21683068eb3908506d5ee1191e55381d1)

12 years agor22024: Don't leak, actually use the provided memory context...
Andrew Bartlett [Mon, 2 Apr 2007 06:57:37 +0000 (06:57 +0000)]
r22024: Don't leak, actually use the provided memory context...
(This used to be commit 46ff4e599e79f47254e05c7e4db75db9a19934bc)

12 years agor22023: I don't like this cache, but I think Jeremy is right, the consequences
Andrew Bartlett [Mon, 2 Apr 2007 06:26:16 +0000 (06:26 +0000)]
r22023: I don't like this cache, but I think Jeremy is right, the consequences
of the talloc heirarchy created are too subtle, particularly with
callers picking out individual members.

This might fix the faults on the build farm.

Andrew Bartlett
(This used to be commit 82667bc75e63292c61f73c1f7cde809cc3dd55b0)

12 years agor22022: - Clarify the comments
Andrew Bartlett [Mon, 2 Apr 2007 05:53:34 +0000 (05:53 +0000)]
r22022: - Clarify the comments

- make sure never to free an uninitialised variable

- ensure to free result on getpwnam_alloc failure

Andrew Bartlett
(This used to be commit 5fe3328e66661371182cc1c3b6e239797c3b4f93)

12 years agor22020: Make it more clear that both the vuser struct and it's contents are
Andrew Bartlett [Mon, 2 Apr 2007 03:46:13 +0000 (03:46 +0000)]
r22020: Make it more clear that both the vuser struct and it's contents are
talloc_free()'ed at the end of a session.

Rework the passwd cache code to use talloc_unlink and
talloc_reference, to more carefully manage the cache.

Andrew Bartlett
(This used to be commit e3e0ec25e67308de314aa61852905ee42aa2c8fe)

12 years agor22019: Jeremy, this hopefully fixes the build farm currently. But I think we need
Volker Lendecke [Sun, 1 Apr 2007 13:50:02 +0000 (13:50 +0000)]
r22019: Jeremy, this hopefully fixes the build farm currently. But I think we need
another get_safe_offset call that also includes the required buffer size.

(This used to be commit 6138be7e4a5eb57af4a024d749cb68168b8589fb)

12 years agor22018: fix compile error
Herb Lewis [Sat, 31 Mar 2007 03:11:02 +0000 (03:11 +0000)]
r22018: fix compile error
(This used to be commit a4c1c770a227390f745c9db07efe468bdcd31339)

12 years agor22017: After changing 2000 lines of this I think this is needed :-).
Jeremy Allison [Sat, 31 Mar 2007 01:14:00 +0000 (01:14 +0000)]
r22017: After changing 2000 lines of this I think this is needed :-).
(This used to be commit 99092e8841edea468fa1e59a8c725f3467b58966)

12 years agor22016: Try and fix the build - move things out of proto.h
Jeremy Allison [Fri, 30 Mar 2007 23:23:45 +0000 (23:23 +0000)]
r22016: Try and fix the build - move things out of proto.h
(This used to be commit 29933600cff458f6599e4604f9e861cd20fc8e38)

12 years agor22015: Fix for memory leak from Steven Danneman <>
Jeremy Allison [Fri, 30 Mar 2007 22:35:35 +0000 (22:35 +0000)]
r22015: Fix for memory leak from Steven Danneman <>
(This used to be commit 61a1574f50d35435a55de62fa6f1d281eed90a25)

12 years agor22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,
Jeremy Allison [Fri, 30 Mar 2007 22:25:08 +0000 (22:25 +0000)]
r22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,
but I've no option.
(This used to be commit c3a565081d70b209a4f9e6e8f1859bf7194a5f74)

12 years agor22013: Move to SSPI framing (sig first in NTLM).
Jeremy Allison [Fri, 30 Mar 2007 22:19:51 +0000 (22:19 +0000)]
r22013: Move to SSPI framing (sig first in NTLM).
(This used to be commit 22eaed76f01ea9d0184dcaf57adca23abc6330b9)

12 years agor22012: Ensure we use the same technique to pull the share mode
Jeremy Allison [Thu, 29 Mar 2007 22:12:28 +0000 (22:12 +0000)]
r22012: Ensure we use the same technique to pull the share mode
data out that locking/locking.c does.
(This used to be commit 1fec4da6d6267289bf93f930de4cb5e21c450e15)

12 years agor22011: As Metze suggested, use 0xFF 'E' <enc ctx> instead
Jeremy Allison [Thu, 29 Mar 2007 19:46:34 +0000 (19:46 +0000)]
r22011: As Metze suggested, use 0xFF 'E' <enc ctx> instead
of 0xFF 'S' <enc ctx>.
(This used to be commit d8cd4fc91b324c9ab8d2f66ee264093763018f76)

12 years agor22010: Now I'm looking at mangling again, make sure
Jeremy Allison [Thu, 29 Mar 2007 19:40:59 +0000 (19:40 +0000)]
r22010: Now I'm looking at mangling again, make sure
that we mangle any illegal names before doing
any wildcard matches. That way lies least
suprises. Don't merge this for 3.0.25, too
dangerous. Thanks.
(This used to be commit 8e15ef476cada7a900ff17c7ba70c729d56718bd)

12 years agor22009: change TDB_DATA from char * to unsigned char *
Stefan Metzmacher [Thu, 29 Mar 2007 09:35:51 +0000 (09:35 +0000)]
r22009: change TDB_DATA from char * to unsigned char *

and fix all compiler warnings in the users

(This used to be commit 3a28443079c141a6ce8182c65b56ca210e34f37f)

12 years agor22008: use string_term_tdb_data()
Stefan Metzmacher [Thu, 29 Mar 2007 08:24:15 +0000 (08:24 +0000)]
r22008: use string_term_tdb_data()

(This used to be commit 1f047d7e31252481c4ed905e0dfdb791c704adca)

12 years agor22007: make string_tdb_data(NULL) possible...
Stefan Metzmacher [Thu, 29 Mar 2007 08:08:52 +0000 (08:08 +0000)]
r22007: make string_tdb_data(NULL) possible...

(This used to be commit d03094708378bde088bf6e90efe54deb83d3952e)

12 years agor22006: use string_term_tdb_data()...
Stefan Metzmacher [Thu, 29 Mar 2007 07:30:22 +0000 (07:30 +0000)]
r22006: use string_term_tdb_data()...

(This used to be commit 136914502ff129b90f10794ed6474dca558c75a0)

12 years agor22003: Fix from Jiri.Sasek@Sun.COM to wrap our krb5_locate_kdc
Jeremy Allison [Wed, 28 Mar 2007 19:47:59 +0000 (19:47 +0000)]
r22003: Fix from Jiri.Sasek@Sun.COM to wrap our krb5_locate_kdc
call as smb_krb5_locate_kdc to prevent incorrect linking
and crashes on Solaris.
(This used to be commit 7d30737c8d851505e81a60443baf9a8c7e523472)

12 years agor22002: Fix bug #3974, there are still open issues with -N behavior (doc fix next)
Simo Sorce [Wed, 28 Mar 2007 14:16:34 +0000 (14:16 +0000)]
r22002: Fix bug #3974, there are still open issues with -N behavior (doc fix next)
and -T argument parsing behavior (which is just insane but a separate bug)
(This used to be commit 1a3980f1fcb6431aa6bce83f7c34338436b4e962)

12 years agor22001: change prototype of dump_data(), so that it takes unsigned char * now,
Stefan Metzmacher [Wed, 28 Mar 2007 13:34:59 +0000 (13:34 +0000)]
r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.

also fix all the callers to prevent compiler warnings

(This used to be commit fa322f0cc9c26a9537ba3f0a7d4e4a25941317e7)

12 years agor22000: remove useless casts
Stefan Metzmacher [Wed, 28 Mar 2007 13:31:52 +0000 (13:31 +0000)]
r22000: remove useless casts

(This used to be commit 8f55fe4e4614d73c2534ca87745972f7550875ee)

12 years agor21999: remove useless casts
Stefan Metzmacher [Wed, 28 Mar 2007 13:26:43 +0000 (13:26 +0000)]
r21999: remove useless casts

(This used to be commit f948005ca69c50b07fdbcf7801975676d19d1486)

12 years agor21998: Fix tdb keynames in netsamlogon_clear_cached_user().
Günther Deschner [Wed, 28 Mar 2007 10:00:42 +0000 (10:00 +0000)]
r21998: Fix tdb keynames in netsamlogon_clear_cached_user().

No point in deleting U/DOMAIN/RID and UG/DOMAIN/RID keys if we only store U/SID
and UG/SID keys :-)

Next we need to verify the need of calling netsamlogon_clear_cached_user() at all.

(This used to be commit 78d13f14672b65c2d4798ce94322e945334eea62)

12 years agor21997: Implement the server side of gss seal negotiate.
Jeremy Allison [Wed, 28 Mar 2007 01:11:27 +0000 (01:11 +0000)]
r21997: Implement the server side of gss seal negotiate.
(This used to be commit 6b923acfee59e39eea69e9e9a00f1f6118ed4270)

12 years agor21994: Ignore keepalives in the correct buffer (out not in :-).
Jeremy Allison [Tue, 27 Mar 2007 22:37:42 +0000 (22:37 +0000)]
r21994: Ignore keepalives in the correct buffer (out not in :-).
(This used to be commit 9785528ddf26c4943e8bdfcf7694314a52218520)

12 years agor21993: Don't let keepalives interferece with sign or seal
Jeremy Allison [Tue, 27 Mar 2007 22:27:06 +0000 (22:27 +0000)]
r21993: Don't let keepalives interferece with sign or seal
in the client code.
(This used to be commit 3e901389feedadd64c6ba712ab09cdfb497a9e0a)

12 years agor21992: Fix keepalive processing when encryption turned on.
Jeremy Allison [Tue, 27 Mar 2007 21:55:43 +0000 (21:55 +0000)]
r21992: Fix keepalive processing when encryption turned on.
(This used to be commit 8f113ad1918dcd2746ec527ceb79a2a7baa1d415)

12 years agor21991: I hate Steve French :-). Add support for encryption
Jeremy Allison [Tue, 27 Mar 2007 21:13:31 +0000 (21:13 +0000)]
r21991: I hate Steve French :-). Add support for encryption
(This used to be commit ae8f3649f773b8a8dcb55921536d038d3475322e)

12 years agor21990: Stop messing with the signing engine just because
Jeremy Allison [Tue, 27 Mar 2007 18:04:36 +0000 (18:04 +0000)]
r21990: Stop messing with the signing engine just because
we're encrypted. This will make further changes and
spec much more clear.
(This used to be commit ffa3a5c508a494d22e8ee3ada424a6517ddf8923)

12 years agor21989: make use of tdb_*_bystring() and string_term_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 11:22:07 +0000 (11:22 +0000)]
r21989: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 1897da9efcfe58ff3c190450731f33bef3ac2ebd)

12 years agor21988: make use of string_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 11:20:55 +0000 (11:20 +0000)]
r21988: make use of string_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 2f52df71039befff8646aa67c1123df7be3591d2)

12 years agor21987: split tdb_prs_*() functions in version which take a keystr and a TDB_DATA key
Stefan Metzmacher [Tue, 27 Mar 2007 11:15:59 +0000 (11:15 +0000)]
r21987: split tdb_prs_*() functions in version which take a keystr and a TDB_DATA key

(This used to be commit 724c6fa337bb535e1b97d0452c2489f58339a3bf)

12 years agor21986: make use of tdb_*_bystring() and string_term_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 11:01:37 +0000 (11:01 +0000)]
r21986: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 08d23a1c4f136427ee6f72fc02fb030a13056495)

12 years agor21985: make use of string_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 10:59:03 +0000 (10:59 +0000)]
r21985: make use of string_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit a8bc20d67f481a790524cad24e253436227af721)

12 years agor21984: make use of tdb_*_bystring() and string_term_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 10:50:32 +0000 (10:50 +0000)]
r21984: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 91301f73476f17cc582c12e1fc201eb571d007af)

12 years agor21983: make use of tdb_*_bystring() and string_term_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 10:46:20 +0000 (10:46 +0000)]
r21983: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 5a5579d8429e6f76805a093133ba29c7f8321512)

12 years agor21982: make use of tdb_*_bystring() and string_term_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 10:43:32 +0000 (10:43 +0000)]
r21982: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 9ebaa4c573ea5784a8c9cd9d29561b760d62bb18)

12 years agor21981: as we use tdb_trans_store(), we should also use tdb_trans_delete()
Stefan Metzmacher [Tue, 27 Mar 2007 10:41:30 +0000 (10:41 +0000)]
r21981: as we use tdb_trans_store(), we should also use tdb_trans_delete()

(This used to be commit 2d2f8099684c4516ed685e5bb2a21541d53645ac)

12 years agor21980: make use of tdb_*_bystring() and string_term_tdb_data() in smbd/
Stefan Metzmacher [Tue, 27 Mar 2007 10:20:50 +0000 (10:20 +0000)]
r21980: make use of tdb_*_bystring() and string_term_tdb_data() in smbd/
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 09b477ed85e46bc780ce3c1461472883a6b952f9)

12 years agor21979: make use of string_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 10:15:45 +0000 (10:15 +0000)]
r21979: make use of string_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

note: we can't use the tdb_*_bystring functions here, as the key isn't
null-terminated here...

(This used to be commit 29b42ea89cbdd9f2c12fa448b116c49669467faf)

12 years agor21978: make use of tdb_*_bystring()
Stefan Metzmacher [Tue, 27 Mar 2007 10:13:53 +0000 (10:13 +0000)]
r21978: make use of tdb_*_bystring()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 1a0599d7aadef651e4d5b88b59c95e8a118dfa5e)

12 years agor21977: little cosmetic change to remove a local var that's not really needed
Stefan Metzmacher [Tue, 27 Mar 2007 10:05:20 +0000 (10:05 +0000)]
r21977: little cosmetic change to remove a local var that's not really needed

(This used to be commit 71c3880e8924c57dcd60573d628b8eb29cee6055)

12 years agor21976: make use of tdb_*_bystring() and string_term_tdb_data() in lib/
Stefan Metzmacher [Tue, 27 Mar 2007 09:59:32 +0000 (09:59 +0000)]
r21976: make use of tdb_*_bystring() and string_term_tdb_data() in lib/
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit c22b86595a502eb48c9d0038faee8a9ee41b8438)

12 years agor21975: if we use the _bystring() version when storing, we should use it on fetch...
Stefan Metzmacher [Tue, 27 Mar 2007 09:30:40 +0000 (09:30 +0000)]
r21975: if we use the _bystring() version when storing, we should use it on fetch too...

(This used to be commit d105723f063d617ef9f8394e7921749b21f1d755)

12 years agor21974: make use of tdb_*_bystring() and string_term_tdb_data() in groupdb/
Stefan Metzmacher [Tue, 27 Mar 2007 09:17:31 +0000 (09:17 +0000)]
r21974: make use of tdb_*_bystring() and string_term_tdb_data() in groupdb/
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 2f2e9a7083b176412cd897119a49520a55a897a7)

12 years agor21973: make use of tdb_*_bystring() and string_term_tdb_data()
Stefan Metzmacher [Tue, 27 Mar 2007 09:12:47 +0000 (09:12 +0000)]
r21973: make use of tdb_*_bystring() and string_term_tdb_data()
to avoid creating the TDB_DATA struct from strings "by hand"

(This used to be commit 9756b7ea084139e74061e98416716acd9d1aedfa)

12 years agor21972: - add string_term_tdb_data() it creates a null-terminates tdb key from a...
Stefan Metzmacher [Tue, 27 Mar 2007 08:41:45 +0000 (08:41 +0000)]
r21972: - add string_term_tdb_data() it creates a null-terminates tdb key from a string
  (the current string_tdb_data() creates a non-terminates tdb key from a string!)
- pass TDB_DATA instead of const char *, size_t len to some functions

(This used to be commit 815ef8acdc7f89d30f3fd1812b12bd0e2dc62473)

12 years agor21969: Start working on the gss-side of the server negotiation.
Jeremy Allison [Tue, 27 Mar 2007 00:50:53 +0000 (00:50 +0000)]
r21969: Start working on the gss-side of the server negotiation.
(This used to be commit fbc569b530104679e47fe743963eb0c4384de6ae)

12 years agor21968: Don't use gss-types in proto headers.
Jeremy Allison [Tue, 27 Mar 2007 00:29:46 +0000 (00:29 +0000)]
r21968: Don't use gss-types in proto headers.
(This used to be commit 829580414d89ff4aa0f45906e455849c55f508b1)

12 years agor21967: Add conversion from gss errors to nt status.
Jeremy Allison [Tue, 27 Mar 2007 00:00:50 +0000 (00:00 +0000)]
r21967: Add conversion from gss errors to nt status.
(This used to be commit 8ba138efd097b08dcfe98f99b67c77579babf250)

12 years agor21965: fix compiler warning
Stefan Metzmacher [Mon, 26 Mar 2007 16:40:29 +0000 (16:40 +0000)]
r21965: fix compiler warning

(This used to be commit cde58ee97ff0de1eb37f62fbf2d52134419dcb5f)

12 years agor21964: Add tdbtorture target to main makefile -- Thanks to Karolin Seeger
Volker Lendecke [Mon, 26 Mar 2007 10:57:48 +0000 (10:57 +0000)]
r21964: Add tdbtorture target to main makefile -- Thanks to Karolin Seeger
(This used to be commit 6265b1ee9612affc80252e3f9c1f2da267733b96)

12 years agor21963: Fix another uninitialized buffer used in test write - valgrind
Jeremy Allison [Sun, 25 Mar 2007 02:17:05 +0000 (02:17 +0000)]
r21963: Fix another uninitialized buffer used in test write - valgrind
(This used to be commit 0119d2c18348a9e0fcc79e247a9014d929af0ce7)

12 years agor21962: Make pdbedit use the configfile specified by -s
Volker Lendecke [Sat, 24 Mar 2007 21:29:53 +0000 (21:29 +0000)]
r21962: Make pdbedit use the configfile specified by -s
(This used to be commit f540c18b2bbf1d3138aea6938c5313ca2e100215)

12 years agor21961: Repair bug introduced by rev. 21960.
Jeremy Allison [Sat, 24 Mar 2007 18:22:20 +0000 (18:22 +0000)]
r21961: Repair bug introduced by rev. 21960.
We need to do the initial strtok to set up the internal state.
(This used to be commit 8c7042b4192cb33988c1bbccdd4a80bb99fd0118)

12 years agor21960: Fix bugs 4463,4464,4465,4466. Thanks Jason :-)
Volker Lendecke [Sat, 24 Mar 2007 18:14:46 +0000 (18:14 +0000)]
r21960: Fix bugs 4463,4464,4465,4466. Thanks Jason :-)
(This used to be commit a2e27c443101a59ef3429a55e049af3ebd5ec1f2)

12 years agor21959: Merge a comment fix from Michael Adam -- more to come :-)
Volker Lendecke [Sat, 24 Mar 2007 18:01:39 +0000 (18:01 +0000)]
r21959: Merge a comment fix from Michael Adam -- more to come :-)
(This used to be commit 06a4d2ce5d4d5d637f19c7444a6510a1bbad7a9f)

12 years agor21958: Fix Coverity ID 343 (dead code)
Volker Lendecke [Sat, 24 Mar 2007 10:32:34 +0000 (10:32 +0000)]
r21958: Fix Coverity ID 343 (dead code)
(This used to be commit 6d093043ed437c1de6f9a50013d9bd84c75cf3ff)

12 years agor21957: minor formatting fix
Herb Lewis [Fri, 23 Mar 2007 23:10:46 +0000 (23:10 +0000)]
r21957: minor formatting fix
(This used to be commit 99b9570ebe5aa9f57db65a04cfc5835b382cb4dd)

12 years agor21956: Fix bug reported by for platforms
Jeremy Allison [Fri, 23 Mar 2007 22:23:09 +0000 (22:23 +0000)]
r21956: Fix bug reported by for platforms
without utimes() call (only utime()).
(This used to be commit 63b061a2ea2ee1eb06d9b568743b2356c107ec66)

12 years agor21954: Someone misused a '!' instead of a '~' for a binary NOT
Jeremy Allison [Fri, 23 Mar 2007 22:11:26 +0000 (22:11 +0000)]
r21954: Someone misused a '!' instead of a '~' for a binary NOT
command. Jerry, Simo, please check.
(This used to be commit 8ff76a9cb860b7fd451829f6d814ea1c6804f5af)

12 years agor21953: One format fix, clarify a condition that the IBM
Jeremy Allison [Fri, 23 Mar 2007 21:50:44 +0000 (21:50 +0000)]
r21953: One format fix, clarify a condition that the IBM
checker was worried about.
(This used to be commit 70eec7b8ae6a4992b43df853dffc21dd91498390)

12 years agor21952: Fix critical (!) error found by IBM checker.
Jeremy Allison [Fri, 23 Mar 2007 21:11:08 +0000 (21:11 +0000)]
r21952: Fix critical (!) error found by IBM checker.
Missing break statements meant that no info
levels would ever be returned correctly from
POSIX open/mkdir.
(This used to be commit ae5761ccc66b35b66ca4fa90aef02d8be1564737)

12 years agor21950: After discussion with the Apple and Linux client maintainers,
James Peach [Fri, 23 Mar 2007 19:31:11 +0000 (19:31 +0000)]
r21950: After discussion with the Apple and Linux client maintainers,
changing the FindFirst response for the UNIX_INFO2 level to include
a length field before the name. The name is not required to be null
terminated. The length field does not count any null.

Also add call to chflags(2) in the default VFS module so that this
will work be default on BSD-derived platform. Add UNIX-INFO2 test
to the build farm to get some non-BSD coverage.

Jeremy and Jerry, please review for inclusion in 3.0.25.
(This used to be commit e7b21b1ef3f79c0df2bae5f15c345ef74292c404)

12 years agor21948: Fix valgrind error in build farm samba3 smbtorture. We were
Jeremy Allison [Fri, 23 Mar 2007 19:12:08 +0000 (19:12 +0000)]
r21948: Fix valgrind error in build farm samba3 smbtorture. We were
using an uninitialized buffer for read/write tests.
(This used to be commit e27d094620178f316bf79540164bbfe6ff3a3851)

12 years agor21947: Fix the equivalent of memcpy(x, x, 16). Found
Jeremy Allison [Fri, 23 Mar 2007 17:00:00 +0000 (17:00 +0000)]
r21947: Fix the equivalent of memcpy(x, x, 16). Found
by valgrind on the build farm.
(This used to be commit 6eed92dfd4da1f9979831bec8e0dcdee33fb53b4)

12 years agor21944: move acl header checks to the correct place only
Stefan Metzmacher [Fri, 23 Mar 2007 10:30:51 +0000 (10:30 +0000)]
r21944: move acl header checks to the correct place only

jeremy: please merge this to 3.0.25:-)

(This used to be commit 874164e365b77947d5c514b2a77c6aae0f42599e)

12 years agor21942: Hoist by our own petard :-). Older smbclient binaries
Jeremy Allison [Thu, 22 Mar 2007 22:15:35 +0000 (22:15 +0000)]
r21942: Hoist by our own petard :-). Older smbclient binaries
were not able to connect to the rewritten dfs code as
they set the dfs flag bit but then send local paths.

Now that our dfs code is a *lot* more robust in
detecting this sort of braindamage we can just
call into it directly on getting a DFS flag
and let the parser sort it out without having
to check it's actually connecting to a dfs
enabled share (I'm proud of this code :-).

(This used to be commit 8c4d929c76ba56d59f651c57d1feb37d2916a436)

12 years agor21941: Attempt to fix bug 4460
Volker Lendecke [Thu, 22 Mar 2007 22:00:48 +0000 (22:00 +0000)]
r21941: Attempt to fix bug 4460
(This used to be commit d1b8f00c122414e532cdb3da78f84d55698cbc10)

12 years agor21940: Sorry Volker, I have to revert your revert in r21935.
Gerald Carter [Thu, 22 Mar 2007 21:41:36 +0000 (21:41 +0000)]
r21940: Sorry Volker,  I have to revert your revert in r21935.
We can talk about this later if you still feel that strongly
but I need to fix the build for now.
(This used to be commit c7df0cad8257333c6a8dfd98818269a783ba7a26)

12 years agor21939: Fix missing initialization that
Jeremy Allison [Thu, 22 Mar 2007 19:41:17 +0000 (19:41 +0000)]
r21939: Fix missing initialization that
broke the build farm. Thanks to
Metze for the heads up.
(This used to be commit bb3623be3f2b0686b2b2e671e3e7bd9978f6ed9b)

12 years agor21935: Revert obviously not sufficiently tested code -- sorry for the pain. I am...
Volker Lendecke [Thu, 22 Mar 2007 18:36:09 +0000 (18:36 +0000)]
r21935: Revert obviously not sufficiently tested code -- sorry for the pain. I am afraid I was basically off the net for the day
(This used to be commit 08c29abc03267b0dfb41cec3734653a536027a10)

12 years agor21934: fix the build sorry
Stefan Metzmacher [Thu, 22 Mar 2007 18:16:36 +0000 (18:16 +0000)]
r21934: fix the build sorry

(This used to be commit 184c4619773f786c5299499e121e485b7545764f)

12 years agor21933: Change the write_sock() call in pam_winbind_request()
Gerald Carter [Thu, 22 Mar 2007 18:09:21 +0000 (18:09 +0000)]
r21933: Change the write_sock() call in pam_winbind_request()
to not request a privileged pipe operation for everything
as this cannot be done from a process running under the
context of a user (e.g. screensaver).

Thanks to Danilo Almeida <> for the help
in pointing out the change to write_sock().
(This used to be commit 80790f935abc8905542338b08f54d61ebacf2ff1)

12 years agor21932: fix compiler warning.
Stefan Metzmacher [Thu, 22 Mar 2007 17:37:01 +0000 (17:37 +0000)]
r21932: fix compiler warning.

maybe also for 3.0.25

(This used to be commit 844dac912cb549b0524571df80fbaa7f2d9c36c2)

12 years agor21931: include acl/libacl.h is present
Stefan Metzmacher [Thu, 22 Mar 2007 17:35:34 +0000 (17:35 +0000)]
r21931: include acl/libacl.h is present

I'm not sure if this should go into 3.0.25... it fixes a compiler warning about
a missing acl_get_perm() prototype

(This used to be commit 4b67f94c6a148d6fecaa90d66ce6893b5feb370a)

12 years agor21927: Removed unused variable.
Jeremy Allison [Thu, 22 Mar 2007 02:25:16 +0000 (02:25 +0000)]
r21927: Removed unused variable.
(This used to be commit 2d951c91a5ac9779dcb124190e3e7f86cee9efdf)

12 years agor21926: Fix missing enum specifier pointed out by Don McCall @ HP.
Jeremy Allison [Thu, 22 Mar 2007 02:24:12 +0000 (02:24 +0000)]
r21926: Fix missing enum specifier pointed out by Don McCall @ HP.
Thanks Don !
(This used to be commit 662344d1ec3593689de7602afa518ed98e10dc37)

12 years agor21925: Start to code up the gss acquire creds calls.
Jeremy Allison [Thu, 22 Mar 2007 01:14:55 +0000 (01:14 +0000)]
r21925: Start to code up the gss acquire creds calls.
(This used to be commit 4a7fbc88520e8f5dfe53a7c5da68040271149da3)

12 years agor21923: Add in the gss decrypt.
Jeremy Allison [Thu, 22 Mar 2007 00:08:22 +0000 (00:08 +0000)]
r21923: Add in the gss decrypt.
(This used to be commit 00f58951b4cace06e51e7eb404605c7f3d366f38)

12 years agor21922: Fixed the build by rather horrid means. I really need
Jeremy Allison [Wed, 21 Mar 2007 23:49:57 +0000 (23:49 +0000)]
r21922: Fixed the build by rather horrid means. I really need
to restructure libsmb/smb_signing.c so it isn't in
the base libs path but lives in libsmb instead (like
smb_seal.c does).
(This used to be commit 1b828f051d0782201f697de15ff973bd6b097d5b)

12 years agor21919: now that the local passdb abd BUILTIN have been blacklisted and they always
Simo Sorce [Wed, 21 Mar 2007 21:10:59 +0000 (21:10 +0000)]
r21919: now that the local passdb abd BUILTIN have been blacklisted and they always
point to the passdb module, remove this comment and move the explanation in
the dimap_ad man page.

(This used to be commit 58d2ec00d241f0ea8f9e165518b29bd35d2dc199)

12 years agor21918: Reverting this change as it is now causing aborts() in
Gerald Carter [Wed, 21 Mar 2007 21:08:15 +0000 (21:08 +0000)]
r21918: Reverting this change as it is now causing aborts() in
find_builtin_domain().    This all needs more testing
before anyone starts changing these lookup routines again.
(This used to be commit add225e1c8fef1d3ddb7fd43c1744858df45ecfd)

12 years agor21917: Start to do the gss versions of sign+seal.
Jeremy Allison [Wed, 21 Mar 2007 19:15:14 +0000 (19:15 +0000)]
r21917: Start to do the gss versions of sign+seal.
(This used to be commit a226645353a40047b72de1b96c3a7676a2bf1034)

12 years agor21916: Fix couple of "return" calls on void functions.
Jeremy Allison [Wed, 21 Mar 2007 18:33:13 +0000 (18:33 +0000)]
r21916: Fix couple of "return" calls on void functions.
Ensure we ignore reqests to free keepalive buffers
as we only copied these.
(This used to be commit a184bdbe3c7bf0c44a8141898bfcb9971a332312)

12 years agor21913: fix one bug in build 717: correctly check the return from sid_peek_check_rid...
Gerald Carter [Wed, 21 Mar 2007 17:43:49 +0000 (17:43 +0000)]
r21913: fix one bug in build 717: correctly check the return from sid_peek_check_rid() when trying to find a matching domain
(This used to be commit c63bc300376e5be10585366013449a359b0778c1)

12 years agor21912: There's no point checksumming the packet length
Jeremy Allison [Wed, 21 Mar 2007 17:13:35 +0000 (17:13 +0000)]
r21912: There's no point checksumming the packet length
this already has to be right. This makes the
signed+sealed area the same as it will be with
gss calls. Now to go implement them.
(This used to be commit 80810af7d1137b3ddd3073581d5ec99fadaa81a5)

12 years agor21908: update with the 3.0.25 packaging
Gerald Carter [Wed, 21 Mar 2007 15:55:45 +0000 (15:55 +0000)]
r21908: update with the 3.0.25 packaging
(This used to be commit 3c2c0bb293c35fc6bf8e545768d366b42900e53b)

12 years agor21905: Rename
Gerald Carter [Wed, 21 Mar 2007 15:21:28 +0000 (15:21 +0000)]
r21905: Rename
  idmap expire time  -> idmap cache time
  idmap negative time -> idmap negative cache time
(This used to be commit aac2d0af5e870190e99317e8e88b22a9562485b4)

12 years agor21904: Fix HP build -- thanks, Don
Volker Lendecke [Wed, 21 Mar 2007 14:13:42 +0000 (14:13 +0000)]
r21904: Fix HP build -- thanks, Don
(This used to be commit 57efba97b634728ae75901cb76b904a5d82986a4)

12 years agor21903: Get the length calculations right (I always forget
Jeremy Allison [Wed, 21 Mar 2007 02:02:09 +0000 (02:02 +0000)]
r21903: Get the length calculations right (I always forget
the 4 byte length isn't included in the length :-).
We now have working NTLMSSP transport encryption
with sign+seal. W00t!
(This used to be commit d34584cb5c53c194693ce7236020ab83f60cd235)

12 years agor21902: Don't free the thing you're trying to set in the cli state.
Jeremy Allison [Wed, 21 Mar 2007 01:32:01 +0000 (01:32 +0000)]
r21902: Don't free the thing you're trying to set in the cli state.
(This used to be commit 1639366561bd63d7023c54f811e2f87dcbbd0a31)

12 years agor21901: Don't use fstrcat when you mean fstrcpy. Doh !
Jeremy Allison [Wed, 21 Mar 2007 01:21:16 +0000 (01:21 +0000)]
r21901: Don't use fstrcat when you mean fstrcpy. Doh !
(This used to be commit c7153411f1840e41470311db00d728e1461c56f6)

12 years agor21900: Token exchange now seems to work, now why does the
Jeremy Allison [Wed, 21 Mar 2007 01:04:56 +0000 (01:04 +0000)]
r21900: Token exchange now seems to work, now why does the
client encrypt fail ?
(This used to be commit 6bd7c05290909ef9f5f377dd141a64ed0d654134)

12 years agor21899: At least we're getting to stage 2 of the blob
Jeremy Allison [Wed, 21 Mar 2007 00:56:40 +0000 (00:56 +0000)]
r21899: At least we're getting to stage 2 of the blob
exchange. Still not working but closer.
(This used to be commit 2fde5c703d2390bc6685f34713dc996e69732f1a)