13 years agoMerge branch 'v3-2-test' of ssh:// into v3-2-test
Alexander Bokovoy [Thu, 13 Dec 2007 09:57:24 +0000 (12:57 +0300)]
Merge branch 'v3-2-test' of ssh:// into v3-2-test
(This used to be commit 45636efa39cbcc2ecf7af4dfd1ac6a90f197ba01)

13 years agoFix pam_smbpass build
Alexander Bokovoy [Thu, 13 Dec 2007 09:55:32 +0000 (12:55 +0300)]
Fix pam_smbpass build
(This used to be commit fbc510f1717fe82338262c18c252d18987c55b5c)

13 years agoAdd flags for correctly implementing lsa_lookup_name levels.
Michael Adam [Wed, 28 Nov 2007 01:15:37 +0000 (02:15 +0100)]
Add flags for correctly implementing lsa_lookup_name levels.

(Prepare fix for Bug #4801.)

(This used to be commit 537b12647e25adcb7da3581f18d2e9feca1caf0c)

13 years agoMake cm_connect_sam() try harder to connect autheticated.
Michael Adam [Tue, 11 Dec 2007 15:34:39 +0000 (16:34 +0100)]
Make cm_connect_sam() try harder to connect autheticated.

Even if the session setup was anonymous, try and collect
trust creds with get_trust_creds() and use these before
falling back to schannel.

This is the first attempt to fix interdomain trusts.
(get password policy and stuff)

(This used to be commit e180bbd45452435e981192028a0ad90078c04236)

13 years agoRefactor out assembling of trust creds (pw, account name, principal).
Michael Adam [Tue, 11 Dec 2007 15:32:38 +0000 (16:32 +0100)]
Refactor out assembling of trust creds (pw, account name, principal).

(This used to be commit 481f18b20d6d5ee12c62120a3559bb16cc98e465)

13 years agoStreamline and fix logic of cm_prepare_connection().
Michael Adam [Tue, 11 Dec 2007 14:39:36 +0000 (15:39 +0100)]
Streamline and fix logic of cm_prepare_connection().

Do not attempt to do a session setup when in a trusted domain

Use get_trust_pw_clear to get machine trust account.
Only call this when the results is really used.
Use the proper domain and account name for session setup.

(This used to be commit 18c66a364e0ddc4960769871ca190944f7fe5c44)

13 years agoRefactoring out get_schannel_session_key logic.
Michael Adam [Tue, 11 Dec 2007 13:36:11 +0000 (14:36 +0100)]
Refactoring out get_schannel_session_key logic.

Refactor the actual retrieval of the session key through the
established netlogon pipe out of get_schannel_session_key()
and get_schannel_session_key_auth_ntlmssp() into a new
function get_schannel_session_key_common().
(To avoid code duplication.)

(This used to be commit e77c4022cfbb868e608edcb06b676658b0e201ad)

13 years agoPass NULL instead of unneeded &sid: pdb_get_trusteddom_pw() checks.
Michael Adam [Tue, 11 Dec 2007 13:12:49 +0000 (14:12 +0100)]
Pass NULL instead of unneeded &sid: pdb_get_trusteddom_pw() checks.

(This used to be commit b2e12365b56f24586a7dfcb845f4de51f0b0e7d5)

13 years agoRename get_trust_pw() to get_trust_pw_hash().
Michael Adam [Tue, 11 Dec 2007 13:07:32 +0000 (14:07 +0100)]
Rename get_trust_pw() to get_trust_pw_hash().

(This used to be commit 0cde7ac9cb39a0026a38ccf66dbecefc12931074)

13 years agoExport logic of get_trust_pw() to new function get_trust_pw_clear().
Michael Adam [Tue, 11 Dec 2007 12:59:54 +0000 (13:59 +0100)]
Export logic of get_trust_pw() to new function get_trust_pw_clear().

get_trust_pw() just now computes the md4 hash of the result of
get_trust_pw_clear() if that was successful. As a last resort,
in the non-trusted-domain-situation, get_trust_pw() now tries to
directly obtain the hashed version of the password out of secrets.tdb.

(This used to be commit 4562342eb84e6fdcec15d8b7ae83aa146aabe2b7)

13 years agoRefactor the lagacy part of secrets_fetch_trust_account_password() out
Michael Adam [Tue, 11 Dec 2007 13:02:45 +0000 (14:02 +0100)]
Refactor the lagacy part of secrets_fetch_trust_account_password() out

into a new function secrets_fetch_trust_account_password_legacy() that
does only try to obtain the hashed version of the machine password directly
from secrets.tdb.

(This used to be commit 91da12b751b3168dc40049f3e90c10d840393efc)

13 years agoLet get_trust_pw() determine the machine_account_name to use.
Michael Adam [Tue, 11 Dec 2007 12:05:44 +0000 (13:05 +0100)]
Let get_trust_pw() determine the machine_account_name to use.

Up to now each caller used its own logic.

This eliminates code paths where there was a special treatment
of the following situation: the domain given is not our workgroup
(i.e. our own domain) and we are not a DC (i.e. it is not a typical
trusted domain situation). In situation the given domain name was
previously used as the machine account name, resulting in an account
name of DOMAIN\\DOMAIN$, which does not seem very reasonable to me.
get_trust_pw would not have obtained a password in this situation

I hope I have not missed an important point here!

(This used to be commit 6ced4a7f88798dc449a667d63bc29bf6c569291f)

13 years agoStreamline logic in cm_connect_netlogon()
Michael Adam [Tue, 11 Dec 2007 11:47:28 +0000 (12:47 +0100)]
Streamline logic in cm_connect_netlogon()

by retrieving trust password only, when it will be used.

(This used to be commit cdc60d8ae8c0ef804206b20b451e9557f97d4439)

13 years agoIn cm_prepare_connection(), only get auth user creds if we need to.
Michael Adam [Tue, 11 Dec 2007 07:52:20 +0000 (08:52 +0100)]
In cm_prepare_connection(), only get auth user creds if we need to.

(This used to be commit 164bfb25d7b5cfeffeb4d81958b7629a11ca5d5e)

13 years agoRemove two unneeded functions.
Michael Adam [Mon, 10 Dec 2007 22:53:55 +0000 (23:53 +0100)]
Remove two unneeded functions.

secrets_store_trust_account_password() and trust_password_delete()
are the write access functions to the SECRETS/$MACHINE.ACC/domain keys
in secrets.tdb, the md4 hashed machine passwords. These are not used
any more: Current code always writes the clear text password.

(This used to be commit 4788fe392427901f6b1c505e3a743136ac8a91ca)

13 years agoFix for bug #4801: Correctly implement lsa lookup levels for lookupnames.
Michael Adam [Wed, 12 Dec 2007 17:03:20 +0000 (18:03 +0100)]
Fix for bug #4801: Correctly implement lsa lookup levels for lookupnames.

This is a first patch aimed at fixing bug #4801.
It is still incomplete in that winbindd does not walk
the the trusted domains to lookup unqualified names here.
Apart from that this fix should be pretty much complete.

(This used to be commit dd320c0924ce393a89b1cab020fd5cffc5b80380)

13 years agoFix typo.
James Peach [Thu, 13 Dec 2007 06:12:10 +0000 (22:12 -0800)]
Fix typo.
(This used to be commit c8468a1bb49535f0467e1a83b4c8bc5c8dce834e)

13 years agoAutoconf support for detecting DNS Service Discovery support.
James Peach [Sat, 13 Oct 2007 05:16:22 +0000 (22:16 -0700)]
Autoconf support for detecting DNS Service Discovery support.

Patch from Rishi Srivatsavai <>, with some
(This used to be commit 2dfe9525b9e6e7dcbac191c1fb6288e166d171e5)

13 years agoMissed one strcpy call.
Jeremy Allison [Thu, 13 Dec 2007 03:12:18 +0000 (19:12 -0800)]
Missed one strcpy call.
(This used to be commit b215fb1ad0d5bb3fa7084c2773845ce1dffb2173)

13 years agoAdd a portable version of strlcpy and strlcat and convert
Jeremy Allison [Thu, 13 Dec 2007 03:06:04 +0000 (19:06 -0800)]
Add a portable version of strlcpy and strlcat and convert
all strncpy/strcat calls to them.
Convert all sprintf calls to snprintf. Safety first !
(This used to be commit eff2b368e891d523de38b43ced95798b74ae101e)

13 years agoFix bug #4784. Patch from Steve Langasek <>.
Jeremy Allison [Thu, 13 Dec 2007 02:45:13 +0000 (18:45 -0800)]
Fix bug #4784. Patch from Steve Langasek <>.
(This used to be commit 4f503ea8912eb787209c8df364bfdb161dbb212c)

13 years agoDeveloper doesn't cut it - need #define test for NSS_WRAPPER.
Jeremy Allison [Thu, 13 Dec 2007 02:38:52 +0000 (18:38 -0800)]
Developer doesn't cut it - need #define test for NSS_WRAPPER.
Hopefully this should fix the buildfarm.
(This used to be commit 087489b7f2a8cd5868b54dbed3f3eed5d0709ba7)

13 years agoOnly add the non-root escape on !developer.
Jeremy Allison [Thu, 13 Dec 2007 02:07:02 +0000 (18:07 -0800)]
Only add the non-root escape on !developer.
(This used to be commit a50c2d159c754c6ff88649ed859f2b3f9c24f6a1)

13 years agoFix the buildfarm until I figure out how to allow
Jeremy Allison [Thu, 13 Dec 2007 01:56:28 +0000 (17:56 -0800)]
Fix the buildfarm until I figure out how to allow
smbpasswd -L for non-root on the buildfarm only.
(This used to be commit 1bb5ce824f800d967e2a92e946dd6ce7c4580b93)

13 years agoFix bug #3727 with patch from Steve Langasek <>
Jeremy Allison [Thu, 13 Dec 2007 01:26:49 +0000 (17:26 -0800)]
Fix bug #3727 with patch from Steve Langasek <>
(This used to be commit 0723760ba47a465d2ff5a22a680f1b5196eca7d8)

13 years agoMake heimdal and MIT happy when iterating through auth data.
Günther Deschner [Wed, 12 Dec 2007 17:57:45 +0000 (18:57 +0100)]
Make heimdal and MIT happy when iterating through auth data.

(This used to be commit 507247dcbf0ef02825a6c5c5f313813714df2d99)

13 years agoVista SP1-rc1 appears to break against Samba-3.0.27a
Guenther Deschner [Wed, 12 Dec 2007 12:38:28 +0000 (13:38 +0100)]
Vista SP1-rc1 appears to break against Samba-3.0.27a

Hash: SHA1

Hi Jason,

Jason Haar wrote:
> Patched 3.0.28, compiled, installed and here's the log file.
> Hope it helps. BTW I don't think it matters, but this is on 32bit
> CentOS4.5 systems.

yes, it helps. Thanks for that.

Very interesting, there are two auth data structures where the first one
is a PAC and the second something unknown (yet).

Can you please try the attached fix ? It should make it work again.

- --
Günther Deschner                    GPG-ID: 8EE11688
Red Hat               
Samba Team                    
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora -

(This used to be commit c9adc07ca2a3bb1e0ea98e3b4f68e1a87e5c0196)

13 years agoFix logic and prevent segfaults in secrets trustdom tdb pack code.
Michael Adam [Wed, 12 Dec 2007 12:50:48 +0000 (13:50 +0100)]
Fix logic and prevent segfaults in secrets trustdom tdb pack code.

New size calculation logic in tdb_trusted_dom_pass_pack()
and tdb_sid_pack() used accumulated sizes as successive offsets
to buffer pointer.

(This used to be commit 9c24713b402978e74dc8691be5cab71d8666eb41)

13 years agoFix secrets_store_trusted_domain_password() after pstring removal.
Michael Adam [Wed, 12 Dec 2007 12:37:46 +0000 (13:37 +0100)]
Fix secrets_store_trusted_domain_password() after pstring removal.

Jeremy, this small "&" sign has given me a headache... :-)

(This used to be commit 7590b12a994cc3c5f299ce7f3299c76adad1c599)

13 years agoAllow cliconnect to loop through multiple ip addresses
Jeremy Allison [Wed, 12 Dec 2007 17:42:58 +0000 (09:42 -0800)]
Allow cliconnect to loop through multiple ip addresses
for a server. We should have been doing this for a while,
but it's more critical with IPv6.
Original patch fixed up by James.
(This used to be commit 5c7f7629a97ef0929e00e52f1fae4386c984000b)

13 years agoDon't restart winbind if a corrupted tdb is found during initialization.
Andreas Schneider [Fri, 23 Nov 2007 09:54:48 +0000 (10:54 +0100)]
Don't restart winbind if a corrupted tdb is found during initialization.

The tdb is validated before it gets initialized. Since then sighandlers changed
a restart isn't needed anymore.
(This used to be commit aabe9b33fcaed8af98b1ed6b736253e196d87d48)

13 years agowinbindd: remove unused WINBINDD_DUMP_MAPS support
Stefan Metzmacher [Wed, 12 Dec 2007 08:51:56 +0000 (09:51 +0100)]
winbindd: remove unused WINBINDD_DUMP_MAPS support

Also the design of this function was really bad,
instead do the dump into a file, the client should get
back the list of mappings.

(This used to be commit ce7fe8acf41e90553431c7cda6823700701835c7)

13 years agowinbindd: remove unused WINBINDD_DUAL_NAME2*ID and WINBINDD_DUAL_*ID2NAME calls
Stefan Metzmacher [Wed, 12 Dec 2007 08:02:23 +0000 (09:02 +0100)]
winbindd: remove unused WINBINDD_DUAL_NAME2*ID and WINBINDD_DUAL_*ID2NAME calls


(This used to be commit fd4499ee438e4947990200db529363d51bd2c956)

13 years agoAdd lp_include_registry_globals().
Günther Deschner [Tue, 11 Dec 2007 16:40:52 +0000 (17:40 +0100)]
Add lp_include_registry_globals().

(This used to be commit d30b945e99390761e405492e40c90e84da4fe482)

13 years agoSome cleanups for "net dom join".
Günther Deschner [Tue, 11 Dec 2007 20:22:04 +0000 (21:22 +0100)]
Some cleanups for "net dom join".

(This used to be commit 3f426f394f3b1454c52d92331c14f41dd1474516)

13 years agoAdd split_domain_user() (not to mix with winbind variants).
Günther Deschner [Tue, 11 Dec 2007 23:42:22 +0000 (00:42 +0100)]
Add split_domain_user() (not to mix with winbind variants).

(This used to be commit bd5308e5f63e4f692761557d0ecdee7226b66a15)

13 years agoMake decode_wkssvc_join_password_buffer() return WERRORs.
Günther Deschner [Tue, 11 Dec 2007 23:44:10 +0000 (00:44 +0100)]
Make decode_wkssvc_join_password_buffer() return WERRORs.

(This used to be commit 88e9da2f14b41a62bdb478f9ffc2de66643bbf14)

13 years agoFix warning message about data type always true.
Jeremy Allison [Tue, 11 Dec 2007 23:10:37 +0000 (15:10 -0800)]
Fix warning message about data type always true.
(This used to be commit 0a3be0aad7220eb97fe39460e20f36c8ae9ce474)

13 years agoAdd patches for bug #4866 from jiri sasek - Sun Microsystems - Prague Czech Republic...
Jeremy Allison [Tue, 11 Dec 2007 21:16:35 +0000 (13:16 -0800)]
Add patches for bug #4866 from jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM>
- slightly modified - Jiri please check !  to allow Solaris to get passwords > 8 chars.
(This used to be commit 657bf8c3479d6192f269e3daef1517e77a9fa9cb)

13 years agowinbindd: pass const char *logfile to winbindd_dump_maps_async()
Stefan Metzmacher [Tue, 11 Dec 2007 14:08:18 +0000 (15:08 +0100)]
winbindd: pass const char *logfile to winbindd_dump_maps_async()

(This used to be commit a52237e3a10aa4ac15cd9e7b859a54c46bfa9cdf)

13 years agoConvert the posix_pending_close_db to dbwrap_rbt
Volker Lendecke [Mon, 10 Dec 2007 20:36:28 +0000 (21:36 +0100)]
Convert the posix_pending_close_db to dbwrap_rbt
(This used to be commit 841f4ccbfb5f79ac4f447342e9dd6ef73cacbc65)

13 years agoseparate out create_file_unixpath()
Volker Lendecke [Tue, 11 Dec 2007 10:14:30 +0000 (11:14 +0100)]
separate out create_file_unixpath()
(This used to be commit deaacf971e0fbffd0e5fe24f225ebf645a77e133)

13 years agoMove more stuff out of the way
Volker Lendecke [Tue, 11 Dec 2007 09:49:26 +0000 (10:49 +0100)]
Move more stuff out of the way
(This used to be commit ae422fce01cd7520d6dd72e08719a5cd003cb640)

13 years agoMove INTERNAL_OPEN_ONLY calculation out of the way
Volker Lendecke [Tue, 11 Dec 2007 09:36:59 +0000 (10:36 +0100)]
Move INTERNAL_OPEN_ONLY calculation out of the way
(This used to be commit 0e96549b56e288c596ed8772197f97ffa5ade300)

13 years agoWhen building nsswitch, make sure to also build smbcontrol.
Günther Deschner [Tue, 11 Dec 2007 13:57:30 +0000 (14:57 +0100)]
When building nsswitch, make sure to also build smbcontrol.

(This used to be commit 3954313d4e3d3a782f0ba41afa5d81b7cc5adac9)

13 years agoReplace "unknown" with access_mask when calling samr_CreateUser2().
Günther Deschner [Tue, 11 Dec 2007 11:28:10 +0000 (12:28 +0100)]
Replace "unknown" with access_mask when calling samr_CreateUser2().

(This used to be commit cfc6e7a2e657ee55364b739d9fe0093e4f7c8b27)

13 years agowinbindd: rename child table struct elements
Stefan Metzmacher [Fri, 7 Dec 2007 15:00:45 +0000 (16:00 +0100)]
winbindd: rename child table struct elements

Add struct_ prefix to struct based protocol specific
elemetens struct winbindd_child_dispatch_table.

(This used to be commit 4ab9a8aab72a8406659a72e87b2d2a1ec2a2eabf)

13 years agoidmap: add a const to idmap_dump_maps()
Stefan Metzmacher [Mon, 10 Dec 2007 18:19:54 +0000 (19:19 +0100)]
idmap: add a const to idmap_dump_maps()

(This used to be commit de31913f0a4fd407d935ec4e27a6123ab7847ab5)

13 years agovlp: Build vlp (virtual line printer) against current git on make
Kai Blin [Mon, 10 Dec 2007 21:30:24 +0000 (22:30 +0100)]
vlp: Build vlp (virtual line printer) against current git on make
(This used to be commit 212ab58a3a7f03bb97c6ad3430e2776f9faba7c9)

13 years agoDon't need an fstring here, we can talloc.
Jeremy Allison [Mon, 10 Dec 2007 23:31:05 +0000 (15:31 -0800)]
Don't need an fstring here, we can talloc.
(This used to be commit 3f6cc826378729c9157ea68e7cf5c7b584bbb585)

13 years agoEnsure we have a non-null flags. Pointed out by Andreas Schneider <anschneider@suse...
Jeremy Allison [Mon, 10 Dec 2007 23:06:31 +0000 (15:06 -0800)]
Ensure we have a non-null flags. Pointed out by Andreas Schneider <>.
(This used to be commit cafde6c37259de587d3775a2d229abd253d2376d)

13 years agoFix errors from next_token conversion. Spotted by
Jeremy Allison [Mon, 10 Dec 2007 22:21:28 +0000 (14:21 -0800)]
Fix errors from next_token conversion. Spotted by
Andreas Schneider <>.
(This used to be commit b40efc2fe63a3420b62fbf1ea8936112c5a24bdc)

13 years agoFix bug leftover from pstring conversion noticed by ceez
Jeremy Allison [Mon, 10 Dec 2007 21:43:12 +0000 (13:43 -0800)]
Fix bug leftover from pstring conversion noticed by ceez
on irc.
(This used to be commit 70950b419a57465c38bb36722644b95b1d14f76d)

13 years agoRemove two completely unnecessary globals
Volker Lendecke [Sun, 9 Dec 2007 16:40:48 +0000 (17:40 +0100)]
Remove two completely unnecessary globals

Can someone look over this? To me it looks as if bufr was only made static to
save a malloc during an included smb.conf file. I think that's pretty much
(This used to be commit 068e8de72ceb49ef2e02cca1913b6d2197bab5e0)

13 years agoFix return values for invalid printers. Found by kblin
Jeremy Allison [Mon, 10 Dec 2007 20:11:45 +0000 (12:11 -0800)]
Fix return values for invalid printers. Found by kblin
spoolss test.
(This used to be commit bb8c044d425cf62b76e487103c8fb0b6cd4c83c2)

13 years agoForgot build options was generated... fix.
Jeremy Allison [Mon, 10 Dec 2007 19:37:20 +0000 (11:37 -0800)]
Forgot build options was generated... fix.
(This used to be commit d78e081043124bbd80cf56d4a991ddf24ff46ef6)

13 years agoRemove the char[1024] strings from dynconfig. Replace
Jeremy Allison [Mon, 10 Dec 2007 19:30:37 +0000 (11:30 -0800)]
Remove the char[1024] strings from dynconfig. Replace
them with malloc'ing accessor functions. Should save a
lot of static space :-).
(This used to be commit 52dc5eaef2106015b3a8b659e818bdb15ad94b05)

13 years agouse dbwrap_rbt in loadparm.c
Volker Lendecke [Sat, 24 Nov 2007 20:42:46 +0000 (21:42 +0100)]
use dbwrap_rbt in loadparm.c
(This used to be commit e81629339589e2e7f464b3dca55730ff2d0877e4)

13 years agoConvert ServiceHash to dbwrap
Volker Lendecke [Sat, 24 Nov 2007 18:56:41 +0000 (19:56 +0100)]
Convert ServiceHash to dbwrap
(This used to be commit 66bd6837b593a7127bd5098afc990d3fb7a5a35a)

13 years agodbwrap_rbt
Volker Lendecke [Fri, 9 Nov 2007 22:43:24 +0000 (23:43 +0100)]

This is meant as a replacement for the internal tdb. To me it seems a bit silly
that for in-memory structures we do our own memory management. With this rbt
based approach we can make use of the system-supplied malloc.
(This used to be commit 54e5d4404619443caed32e2acff8921cdbff9ed1)

13 years agoMake the Linux rbtrees compile within Samba
Volker Lendecke [Mon, 10 Dec 2007 12:20:24 +0000 (13:20 +0100)]
Make the Linux rbtrees compile within Samba
(This used to be commit c871fd802f3c0c5ef1f63b2d01a636c885f22b23)

13 years agoAdd rbtree.[ch] from the Linux kernel
Volker Lendecke [Mon, 10 Dec 2007 12:11:51 +0000 (13:11 +0100)]
Add rbtree.[ch] from the Linux kernel

These are copies taken from 94545baded0bfbabdc30a3a4cb48b3db479dd6ef from Linus' kernel tree
(This used to be commit 8a3289f913fc0432211b0e9937da1d71d4e18893)

13 years agoAdd db_tdb_fetch
Volker Lendecke [Sat, 24 Nov 2007 19:21:19 +0000 (20:21 +0100)]
Add db_tdb_fetch
(This used to be commit efa8764c21edfbd09f535900ba37359d72903bf8)

13 years agoAdd dbwrap bystring service routines
Volker Lendecke [Sat, 24 Nov 2007 18:56:16 +0000 (19:56 +0100)]
Add dbwrap bystring service routines
(This used to be commit 1e214b536b0628db299d701839e62a4ac52727c9)

13 years agoCorrectly unbecome_root() on error
Volker Lendecke [Mon, 10 Dec 2007 10:47:17 +0000 (11:47 +0100)]
Correctly unbecome_root() on error
(This used to be commit aec5f1512660953168a2c55b2890cd6c076b8a92)

13 years agoSimplify add_session_user
Volker Lendecke [Sun, 9 Dec 2007 18:03:49 +0000 (19:03 +0100)]
Simplify add_session_user
(This used to be commit f98082ccf048a2de6fea8d922264879305b3d2c8)

13 years agoIncrease debug level
Volker Lendecke [Fri, 7 Dec 2007 09:45:33 +0000 (10:45 +0100)]
Increase debug level
(This used to be commit 4e6df5547167fc235971498cb296a5f74dec8b8b)

13 years agoMove stuff from data to text
Volker Lendecke [Wed, 5 Dec 2007 20:09:57 +0000 (21:09 +0100)]
Move stuff from data to text
(This used to be commit 49f06a2fa70e469bcb5fe17852af011dac32994b)

13 years agoint->bool
Volker Lendecke [Wed, 5 Dec 2007 19:58:25 +0000 (20:58 +0100)]
(This used to be commit 874258195278bc8c6bb3011c153c5d646fff9e75)

13 years agoTiny simplifications
Volker Lendecke [Wed, 5 Dec 2007 19:53:22 +0000 (20:53 +0100)]
Tiny simplifications

locking.c:open_read_only was unused

don't export the silly boolean flag locking_init(bool read_only)
(This used to be commit 2f3c865707010bc7c463a02782dbee3dc2479da1)

13 years agoRemove a static
Volker Lendecke [Wed, 5 Dec 2007 19:41:24 +0000 (20:41 +0100)]
Remove a static
(This used to be commit 1f317f471af72f8bbc6c9fdd3e79a27c59e6fb6e)

13 years agoRemove two statics
Volker Lendecke [Wed, 5 Dec 2007 19:30:53 +0000 (20:30 +0100)]
Remove two statics
(This used to be commit 8ee502e1e59960fd8db037f0adf1171b2a18cec5)

13 years agoremove a static
Volker Lendecke [Wed, 5 Dec 2007 17:46:53 +0000 (18:46 +0100)]
remove a static
(This used to be commit 0006b14d38b80562458b37f616c9b68a3168fe64)

13 years agoMany systems don't have sa_len as part of struct sockaddr.
Jeremy Allison [Sun, 9 Dec 2007 22:59:07 +0000 (14:59 -0800)]
Many systems don't have sa_len as part of struct sockaddr.
Revert 5c347cb46d85d04bbba7c99dca7ff9628f977d84
"Choose a better default for sockaddr length.".
(This used to be commit 677ac6adc38b0747f825ee597e0502277a8f74b1)

13 years agoSupport fetching very long server lists with RAP_NetServerEnum3.
James Peach [Sun, 9 Dec 2007 22:18:54 +0000 (14:18 -0800)]
Support fetching very long server lists with RAP_NetServerEnum3.

Use the RAP_NetServerEnum3 server list continuation API for retrieving
server lists that are too long to fit in a single reply.

Patch from George Colley <>.
(This used to be commit 40c26d55736ae08934e18c27168fff10dd15442f)

13 years agoChoose a better default for sockaddr length.
James Peach [Sun, 9 Dec 2007 22:02:23 +0000 (14:02 -0800)]
Choose a better default for sockaddr length.
(This used to be commit 5c347cb46d85d04bbba7c99dca7ff9628f977d84)

13 years agoSpecifically ask for IP4 addresses if we don't have IP6 support.
James Peach [Sun, 9 Dec 2007 22:01:57 +0000 (14:01 -0800)]
Specifically ask for IP4 addresses if we don't have IP6 support.
(This used to be commit 4786654992e3cb2280b77406f9217fcec981602c)

13 years agoMake sure NULL is defined to the IPv6 test doesn't spuriously fail.
James Peach [Sun, 9 Dec 2007 22:00:25 +0000 (14:00 -0800)]
Make sure NULL is defined to the IPv6 test doesn't spuriously fail.
(This used to be commit 87c302e250aacc4d5d6a3cce3f134dd13fa457bf)

13 years agoFix connect(2) callers to use correct sockaddr size.
James Peach [Sun, 9 Dec 2007 21:28:00 +0000 (13:28 -0800)]
Fix connect(2) callers to use correct sockaddr size.

Some systems (eg Mac OSX 10.5) require the length passed to match
the socket address family. This introduces sys_connect() that does
the right thing, and replaces all uses oc connect(2) with sys_connect().

Note that there are some LGPL callers that still call connect(2)
(This used to be commit e1bfdc17c49da582cdf907e260301ab1946b2ed3)

13 years agoMove load_case_tables() to after logging is set up. This can log
James Peach [Sun, 9 Dec 2007 21:22:19 +0000 (13:22 -0800)]
Move load_case_tables() to after logging is set up. This can log
(This used to be commit ffee51586cfc32a7e394f606e5021ee8fd198559)

13 years agoDon't copy the rpc function pointers
Volker Lendecke [Sun, 9 Dec 2007 18:46:06 +0000 (19:46 +0100)]
Don't copy the rpc function pointers

This actually shows up in a valgrind massif run with 4.1% of allocated memory.
I don't see why we would have to make a copy here.

(This used to be commit 616d6b97e594a846e9b3ac4cbe48538d649462e9)

13 years agoC++ warning
Volker Lendecke [Sat, 8 Dec 2007 10:25:05 +0000 (11:25 +0100)]
C++ warning
(This used to be commit 85a7f800b6ff8a21d234cee1a24123fb48bafa13)

13 years agoGet rid of the msgbuf[1600]
Volker Lendecke [Sun, 9 Dec 2007 12:45:10 +0000 (13:45 +0100)]
Get rid of the msgbuf[1600]
(This used to be commit af228007915cc8bb65fa7968da25a1a36004bc22)

13 years agoFix C++ warnings
Volker Lendecke [Sat, 8 Dec 2007 10:21:08 +0000 (11:21 +0100)]
Fix C++ warnings
(This used to be commit 01a5c3ea4bf18d99ca1c35e8c38367046e4c867b)

13 years agoFix two incompatible pointer warnings
Volker Lendecke [Sat, 8 Dec 2007 10:20:53 +0000 (11:20 +0100)]
Fix two incompatible pointer warnings

Jeremy, please check
(This used to be commit 60500fac30911500eade7c2a9aa13569dcab0911)

13 years agoAdd define guards around FSTRING_LEN.
Jeremy Allison [Sat, 8 Dec 2007 01:44:42 +0000 (17:44 -0800)]
Add define guards around FSTRING_LEN.
(This used to be commit ea8633689d43cc2fe15aedb430b4cac38fa73d14)

13 years agoRemove next_token - all uses must now be next_token_talloc.
Jeremy Allison [Sat, 8 Dec 2007 01:32:32 +0000 (17:32 -0800)]
Remove next_token - all uses must now be next_token_talloc.
No more temptations to use static length strings.
(This used to be commit ec003f39369910dee852b7cafb883ddaa321c2de)

13 years agoA requiem for pstring.
Jeremy Allison [Fri, 7 Dec 2007 22:54:38 +0000 (14:54 -0800)]
A requiem for pstring.

                 /              \
                /      REST      \
               /        IN        \
              /       PEACE        \
             /                      \
             | The infamous pstring |
             |                      |
             |                      |
             |      7 December      |
             |                      |
             |         2007         |
            *|     *  *  *          | *

(This used to be commit bca371bff8e1dd5099eda1774e5bb0fdbd6a1a77)

13 years agoMore null deref fixes.
Jeremy Allison [Fri, 7 Dec 2007 22:43:31 +0000 (14:43 -0800)]
More null deref fixes.
(This used to be commit efaebdb141a841ec083f20f8905ae0294b81d0d6)

13 years agoMore null deref fixes.
Jeremy Allison [Fri, 7 Dec 2007 22:37:00 +0000 (14:37 -0800)]
More null deref fixes.
(This used to be commit 78c98796d9328723b7c46012adf5393134a4fea3)

13 years agoDon't deref null pointers.
Jeremy Allison [Fri, 7 Dec 2007 22:35:04 +0000 (14:35 -0800)]
Don't deref null pointers.
(This used to be commit 686e4e5efe23e074b661e876b6b118c03ff0058d)

13 years agoAfter conversations with Jerry, remove smbctool until it's
Jeremy Allison [Fri, 7 Dec 2007 20:46:55 +0000 (12:46 -0800)]
After conversations with Jerry, remove smbctool until it's
maintained. Now I don't have to fix the pstrings in it :-).
(This used to be commit 9da4f408433759b7d86d1954e2e7c1365d590389)

13 years agoWe don't need P_GSTRING or P_UGSTRING anymore.
Jeremy Allison [Fri, 7 Dec 2007 20:43:10 +0000 (12:43 -0800)]
We don't need P_GSTRING or P_UGSTRING anymore.
(This used to be commit 78dc75600099b5b3b5a8ecffec747a227ff51d70)

13 years agoDon't build rpctorture anymore - not maintained. Just remove.
Jeremy Allison [Fri, 7 Dec 2007 20:26:32 +0000 (12:26 -0800)]
Don't build rpctorture anymore - not maintained. Just remove.
Remove all vestiges of pstring (except for smbctool as noted
in previous commit).
(This used to be commit 4c32a22ac50ada3275d2ffba3c1aa08bee7d1549)

13 years agoFix call to clistr_pull_talloc.
Jeremy Allison [Fri, 7 Dec 2007 20:08:55 +0000 (12:08 -0800)]
Fix call to clistr_pull_talloc.
(This used to be commit 86700b7e2e79e634b41c272632e42b2e64f58ba3)

13 years agoDon't double define fstring.
Jeremy Allison [Fri, 7 Dec 2007 20:04:40 +0000 (12:04 -0800)]
Don't double define fstring.
(This used to be commit 822b2ead9b0ee28d7ae147fc1ef67da099699cf8)

13 years agoRemove pstrings completely except for smbctool (what does this do ?).
Jeremy Allison [Fri, 7 Dec 2007 20:02:44 +0000 (12:02 -0800)]
Remove pstrings completely except for smbctool (what does this do ?).
Don't build this for now.
(This used to be commit 46b67fd82c795d1a34a1efca9e409c0f3fa4f3a2)

13 years agoRemove pstring from clitar.c
Jeremy Allison [Fri, 7 Dec 2007 19:28:16 +0000 (11:28 -0800)]
Remove pstring from clitar.c
(This used to be commit 1d5fee5038413c90b367434f9066d947849bdaed)

13 years agoMerge branch 'v3-2-test' of ssh:// into v3-2-test
Jeremy Allison [Fri, 7 Dec 2007 17:57:19 +0000 (09:57 -0800)]
Merge branch 'v3-2-test' of ssh:// into v3-2-test
(This used to be commit 0c21c5fa84e18d78801ab79abd726e5588902476)

13 years agoAdd NT_STATUS_DOWNGRADE_DETECTED (thanks to Magnus Mertens).
Günther Deschner [Fri, 7 Dec 2007 15:19:34 +0000 (16:19 +0100)]
Add NT_STATUS_DOWNGRADE_DETECTED (thanks to Magnus Mertens).

(This used to be commit 970daaa0a620d8e47475909cd7b5e54869602530)