Volker Lendecke [Wed, 26 Mar 2008 17:39:11 +0000 (18:39 +0100)]
Make some fns static
Volker Lendecke [Wed, 26 Mar 2008 17:33:38 +0000 (18:33 +0100)]
printclose has only 1 vwv
Günther Deschner [Fri, 28 Mar 2008 12:37:25 +0000 (13:37 +0100)]
Remove unneeded pack_dsdcinfo/unpack_dsdcinfo.
Guenther
Günther Deschner [Fri, 28 Mar 2008 12:36:31 +0000 (13:36 +0100)]
Use NDR for netr_DsRGetDCNameInfo un-/marshalling in dsgetdcname.
Guenther
Günther Deschner [Fri, 28 Mar 2008 12:31:40 +0000 (13:31 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Fri, 28 Mar 2008 12:30:13 +0000 (13:30 +0100)]
Make netr_DsRGetDCNameInfo public.
Guenther
Günther Deschner [Fri, 28 Mar 2008 08:56:21 +0000 (09:56 +0100)]
Fix blob used in pull_netr_AcctLockStr().
Thanks metze.
Guenther
Günther Deschner [Fri, 28 Mar 2008 08:55:18 +0000 (09:55 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Fri, 28 Mar 2008 08:53:37 +0000 (09:53 +0100)]
Rename string to array in lsa_BinaryString.
Guenther
Jeremy Allison [Thu, 27 Mar 2008 23:48:44 +0000 (16:48 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 27 Mar 2008 23:08:39 +0000 (16:08 -0700)]
Fix up the comments on security=share to explain we're
ignoring passwords.
Jeremy.
Günther Deschner [Thu, 27 Mar 2008 21:55:20 +0000 (22:55 +0100)]
Make sure to zero the returned handle in _svcctl_CloseServiceHandle().
Guenther
Jeremy Allison [Thu, 27 Mar 2008 21:23:20 +0000 (14:23 -0700)]
Fix for termination problems when no interfaces found - bug #5267.
Jeremy.
Günther Deschner [Thu, 27 Mar 2008 21:18:04 +0000 (22:18 +0100)]
Remove last reference to rpc_netlogon.h.
Guenther
Günther Deschner [Thu, 27 Mar 2008 20:58:11 +0000 (21:58 +0100)]
Remove unused marshalling for Netlogon Lockout String.
Guenther
Günther Deschner [Thu, 27 Mar 2008 20:55:42 +0000 (21:55 +0100)]
Re-add support for display and vampire of account policies in "net".
Guenther
Günther Deschner [Thu, 27 Mar 2008 20:04:31 +0000 (21:04 +0100)]
Minor fix for net rpc samdump.
Guenther
Günther Deschner [Thu, 27 Mar 2008 17:48:28 +0000 (18:48 +0100)]
re-run make idl.
Guenther
Günther Deschner [Thu, 27 Mar 2008 17:43:58 +0000 (18:43 +0100)]
Fill in netr_AcctLockStr and use lsa_BinaryString in netlogon delta.
Guenther
Günther Deschner [Thu, 27 Mar 2008 17:40:17 +0000 (18:40 +0100)]
Add lsa_BinaryString.
Guenther
Michael Adam [Thu, 27 Mar 2008 17:01:43 +0000 (18:01 +0100)]
regdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete|store]()
Michael
Michael Adam [Thu, 27 Mar 2008 17:00:25 +0000 (18:00 +0100)]
dbwrap: fix dbwrap_trans_[delete|store]() to stop when transaction_start() failed.
Michael
Michael Adam [Thu, 27 Mar 2008 16:44:36 +0000 (17:44 +0100)]
regdb: use != 0 instead of == -1 check for transaction_[commit|cancel]
Michael
Stefan Metzmacher [Thu, 27 Mar 2008 15:57:10 +0000 (16:57 +0100)]
pdb_tdb: use db_open_trans()
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 27 Mar 2008 15:55:35 +0000 (16:55 +0100)]
pdb_tdb: use db_sam->transaction_start(db_sam) != 0 consistent
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 27 Mar 2008 15:57:30 +0000 (16:57 +0100)]
passdb/secrets: use db_open_trans()
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 20 Mar 2008 13:26:46 +0000 (14:26 +0100)]
passdb/secrets: it's enough to use traverse_read() in secrets_trusted_domains()
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 27 Mar 2008 15:57:51 +0000 (16:57 +0100)]
regdb: use db_open_trans()
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 27 Mar 2008 15:56:38 +0000 (16:56 +0100)]
regdb: use regdb->transaction_start(regdb) != 0 consistent
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 26 Mar 2008 20:24:17 +0000 (21:24 +0100)]
regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Wed, 26 Mar 2008 20:25:06 +0000 (21:25 +0100)]
regdb: use dbwrap_trans_store_int32
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 27 Mar 2008 15:08:21 +0000 (16:08 +0100)]
dbwrap: add db_open_trans()
This should be used when transactions are wanted.
For now it's just a wrapper of db_open(), but this
will change.
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 27 Mar 2008 14:59:58 +0000 (15:59 +0100)]
dbwrap: add dbwrap_trans_store_int32()
metze
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Thu, 27 Mar 2008 17:05:02 +0000 (18:05 +0100)]
Fix typo.
Guenther
Günther Deschner [Thu, 27 Mar 2008 15:44:37 +0000 (16:44 +0100)]
Ndr pull and push errors are worth to be logged with 1 at least.
Guenther
Gerald W. Carter [Thu, 27 Mar 2008 16:57:26 +0000 (11:57 -0500)]
Only add WBFLAG_PAM_CONTACT_TRUSTDOM when performing a krb5 auth request.
NTLM logons must go against our DC.
Gerald W. Carter [Thu, 27 Mar 2008 16:56:29 +0000 (11:56 -0500)]
Don't fill password policy structure for any domain other than our own.
The samr connects will fail. This is not independent of the CONTACT_TRUSTDOM
flag neede by krb5 logins.
Volker Lendecke [Thu, 27 Mar 2008 12:00:23 +0000 (13:00 +0100)]
Fix wbinfo -a trusted\\user%password on a Samba DC with trusts
Winbind can't be allowed to connect to the local smbd.
Günther Deschner [Thu, 27 Mar 2008 11:05:01 +0000 (12:05 +0100)]
Remove unused DS_DOMAIN_CONTROLLER_INFO struct.
Guenther
Günther Deschner [Thu, 27 Mar 2008 12:03:12 +0000 (13:03 +0100)]
Fix samlogon rpc client & server.
Guenther
Günther Deschner [Thu, 27 Mar 2008 11:57:03 +0000 (12:57 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Thu, 27 Mar 2008 11:03:20 +0000 (12:03 +0100)]
Move netr_LogonLevel flags to IDL, rename old one to netr_LogonInfo.
Guenther
Günther Deschner [Thu, 27 Mar 2008 11:04:22 +0000 (12:04 +0100)]
Move DSGETDC_VALID_FLAGS to IDL.
Guenther
Günther Deschner [Thu, 27 Mar 2008 11:02:18 +0000 (12:02 +0100)]
Move LOGON_KRB5_FAIL_CLOCK_SKEW to winbindd_pam.
Guenther
Günther Deschner [Thu, 27 Mar 2008 11:01:13 +0000 (12:01 +0100)]
Move the known NETLOGON_CONTROL reply flags to IDL.
Guenther
Günther Deschner [Thu, 27 Mar 2008 10:58:19 +0000 (11:58 +0100)]
Move inline comment about MSV1_0 flags to IDL.
Guenther
Michael Adam [Thu, 27 Mar 2008 10:51:31 +0000 (11:51 +0100)]
libwbclient: fix Coverity ID 536 remove duplicate error path (dead code).
I leave the more explicit error path in the "if (cmd == 0)" block.
Michael
Michael Adam [Thu, 27 Mar 2008 10:26:33 +0000 (11:26 +0100)]
libreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c
This is not a proper bug but the code is clearer now
and we are tracking failure of open separate from that of close.
Michael
Günther Deschner [Thu, 27 Mar 2008 10:04:01 +0000 (11:04 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Thu, 27 Mar 2008 10:01:55 +0000 (11:01 +0100)]
Use netr_LogonControlCode in netr_LogonControl2().
Guenther
Michael Adam [Thu, 27 Mar 2008 09:09:24 +0000 (10:09 +0100)]
posix_acls: clarify loop condition code, removing unneeded counter variable.
Coverity ID 545 falsely classified this as a NULL dereferencing bug.
By putting the loop of walking the list of aces more naturely not using
additional counters, it becomes much more obvious that it is not entered
when dir_ace == NULL.
The same modifications are done for the file_ace loop.
Michael
Günther Deschner [Wed, 26 Mar 2008 21:25:51 +0000 (22:25 +0100)]
Fix typo.
Guenther
Michael Adam [Wed, 26 Mar 2008 23:32:00 +0000 (00:32 +0100)]
net_conf: fix non-testmode import function.
Michael
Michael Adam [Wed, 26 Mar 2008 22:58:52 +0000 (23:58 +0100)]
libsmbconf: text - pass the cache instead of all private data to pm_process.
Michael
Michael Adam [Wed, 26 Mar 2008 22:58:01 +0000 (23:58 +0100)]
libsmbconf: text - change the cache to be talloced
instead of having it directly as a member in the private data struct.
This makes it easier to flush and initialize the cache.
Michael
Michael Adam [Wed, 26 Mar 2008 22:11:04 +0000 (23:11 +0100)]
libsmbconf: in text backend, put flushing of the cache into a helper function.
And use it also in the close operation.
Michael
Gerald W. Carter [Wed, 26 Mar 2008 21:58:27 +0000 (16:58 -0500)]
Fix a bug in the output from print_canonical_sockaddr() fix from
36f8bafbd3dee66a8....
Make sure that IPv4 addresses are not enclised in []'s.
Günther Deschner [Wed, 26 Mar 2008 20:08:53 +0000 (21:08 +0100)]
Fix winbind NETLOGON cred chain on a samba dc for w2k8 trusts.
Guenther
Günther Deschner [Wed, 26 Mar 2008 18:27:18 +0000 (19:27 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Wed, 26 Mar 2008 18:25:54 +0000 (19:25 +0100)]
Fix IDL for netr_NETLOGON_INFO_2.
W2k8 generated NT_STATUS_ARRAY_BOUNDS_EXCEEDED errors while validating trusts.
Guenther
Günther Deschner [Wed, 26 Mar 2008 18:18:08 +0000 (19:18 +0100)]
Fix _netr_LogonControl2(). Return talloced dcname.
Guenther
Günther Deschner [Mon, 18 Feb 2008 01:40:55 +0000 (02:40 +0100)]
Add ntsvcs_getdevregprop command to rpcclient.
Guenther
Michael Adam [Wed, 26 Mar 2008 13:46:43 +0000 (14:46 +0100)]
net_conf: reformat - re-indent one function call.
Michael
Michael Adam [Wed, 26 Mar 2008 13:45:34 +0000 (14:45 +0100)]
net_conf: add casts to avoid compiler warnings.
Michael
Michael Adam [Wed, 26 Mar 2008 13:39:02 +0000 (14:39 +0100)]
net_conf: rename "ctx" to "mem_ctx" for clarity.
There are also smbconf contexts arount...
Michael
Michael Adam [Wed, 26 Mar 2008 13:34:21 +0000 (14:34 +0100)]
net_conf: use talloc_stackframe() instead of talloc_init().
Michael
Michael Adam [Wed, 26 Mar 2008 13:33:22 +0000 (14:33 +0100)]
net_conf: fix import function by using the new text backend of smbconf.
Originally, lp_load() was used to import files to registry.
This had several bugs. Most notably, options explicitly set to
default values were silently dropped, and all parametric options
were ignored.
This new implementation reads config from the text backend and
stuffs everything verbatim in to the registry backend.
Michael
Michael Adam [Wed, 26 Mar 2008 13:30:36 +0000 (14:30 +0100)]
libsmbconf: add a text backend to libsmbconf based on the params.c parser.
This is a simple implementation of text backend for libsmbconf.
It is read only. It uses the parser from params.c. It loads the
given config file and holds the parsed lists of strings in memory.
Config is only re-read if the time stamp of the config file has changed.
Brilliant performance on large files is not to be expected since the
string lists are not hashed. This might be added in the future.
Michael
Michael Adam [Tue, 25 Mar 2008 21:53:47 +0000 (22:53 +0100)]
loadparm: add userdata parameter to do_section() and do_parameter().
The userdata is currently unused. It can be used in the future for
passing a context like in samba4 code.
Michael
Karolin Seeger [Wed, 26 Mar 2008 13:02:48 +0000 (14:02 +0100)]
WHATSNEW: Start to add changes since 3.2.0pre2.
Karolin
Günther Deschner [Wed, 26 Mar 2008 10:45:28 +0000 (11:45 +0100)]
Strip whitespace in ntsvcs rpc server.
Guenther
Günther Deschner [Wed, 26 Mar 2008 10:35:44 +0000 (11:35 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Mon, 18 Feb 2008 01:37:26 +0000 (02:37 +0100)]
Fill in IDL for PNP_GetDeviceRegProp.
Guenther
Günther Deschner [Wed, 26 Mar 2008 10:32:12 +0000 (11:32 +0100)]
Comment out some svcctl headers which are now defined in IDL.
Guenther
Günther Deschner [Wed, 26 Mar 2008 10:36:41 +0000 (11:36 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Tue, 25 Mar 2008 18:07:48 +0000 (19:07 +0100)]
Add svcctl_MgrAccessMask and svcctl_ServiceAccessMask.
Guenther
Michael Adam [Wed, 26 Mar 2008 09:55:26 +0000 (10:55 +0100)]
smbconf: reformat - fix intentation.
This time this won't make me stumble, since there is no
magic in indented function headers here - no automatic
prototype generation... :-)
Michael
Michael Adam [Wed, 26 Mar 2008 10:13:47 +0000 (11:13 +0100)]
util_tdb: remove trivial and unused tdb_wipe().
It has been replaced by tdb_wipe_all().
Michael
Michael Adam [Wed, 26 Mar 2008 09:50:08 +0000 (10:50 +0100)]
use tdb_wipe_all() instead of tdb_wipe() - it is faster...
Michael
Michael Adam [Wed, 26 Mar 2008 09:45:53 +0000 (10:45 +0100)]
util_tdb: make the _byblob fetch/store functions public again.
Users of these are currently being written...
Michael
Günther Deschner [Wed, 26 Mar 2008 00:27:36 +0000 (01:27 +0100)]
Fix wbcAuthenticateUserEx().
Guenther
Günther Deschner [Wed, 26 Mar 2008 00:25:57 +0000 (01:25 +0100)]
Add debug statement in auth_winbind to display wbcAuthenticateUserEx error code.
Guenther
Volker Lendecke [Tue, 25 Mar 2008 21:35:20 +0000 (22:35 +0100)]
Fix a valgrind error
In winbind, we're using the info3 struct to send it to the winbind client after
netsamlogon_cache_store. Without this info3->base.account_name.string was
prematurely freed.
Volker Lendecke [Tue, 25 Mar 2008 21:21:50 +0000 (22:21 +0100)]
Fix a segfault
When we get a NT_STATUS_WRONG_PASSWORD for example, my_info3 is not initialized
at all. So first check that we have NT_STATUS_IS_OK(status) before we
dereference my_info3.
Volker Lendecke [Tue, 25 Mar 2008 20:35:41 +0000 (21:35 +0100)]
Fix typo
Günther Deschner [Tue, 25 Mar 2008 16:52:33 +0000 (17:52 +0100)]
Re-run make idl (after pidl change for adding header info to cli_ functions).
Guenther
Michael Adam [Tue, 25 Mar 2008 14:55:03 +0000 (15:55 +0100)]
util_tdb: add my (C) for the tdb validation code
Michael
Michael Adam [Tue, 25 Mar 2008 13:18:08 +0000 (14:18 +0100)]
util_tdb: add a wrapper tdb_wipe() for traverse with tdb_traverse_delete_fn().
Replace all callers of traverse with this tdb_traverse_delete_fn() and
don't export tdb_traverse_delete_fn() anymore.
Michael
Michael Adam [Tue, 25 Mar 2008 12:53:31 +0000 (13:53 +0100)]
util_tdb: add the tdb_pack_append() prototype to util_tdb.h
This function is currently not used but seems useful.
Michael
Michael Adam [Tue, 25 Mar 2008 12:52:32 +0000 (13:52 +0100)]
util_tdb: make the _byblob functions static - not currently used elsewhere.
Michael
Michael Adam [Tue, 25 Mar 2008 12:41:51 +0000 (13:41 +0100)]
util_tdb: group prototypes in util_tdb.h thematically
Michael
Michael Adam [Tue, 25 Mar 2008 11:54:14 +0000 (12:54 +0100)]
build: don't autogenerate prototypes for util_tdb and dbwrap anymore.
Stick to hand-written headers (that are there anyways).
Add some missing prototypes to util_tdb.h and dbwrap.h.
I did not bother to add a header for each single dbwrap backend
open function but put the prototypes for the open functions into
the central dbwrap.h.
Michael
Karolin Seeger [Tue, 25 Mar 2008 11:00:42 +0000 (12:00 +0100)]
Fix usage message for 'net idmap dump'.
Karolin
Günther Deschner [Tue, 25 Mar 2008 09:11:47 +0000 (10:11 +0100)]
Fix _winreg_QueryValue().
Guenther
Günther Deschner [Mon, 24 Mar 2008 10:48:16 +0000 (11:48 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Mon, 24 Mar 2008 10:46:51 +0000 (11:46 +0100)]
Fix IDL for winreg_QueryValue.
Guenther
Gerald (Jerry) Carter [Mon, 24 Mar 2008 19:48:29 +0000 (14:48 -0500)]
Ignore port when pulling IP addr from struct sockaddr_storage.
Linux man page states that getaddinfo() will leave the port
uninitialized when passing in NULL for the service name. So we
can't really trust that anymore. I doubt non-default KDC ports
are an issues so just drop the port from the generated krb5.conf.
AIX exhibits this bug the most.
Gerald (Jerry) Carter [Mon, 24 Mar 2008 19:27:01 +0000 (14:27 -0500)]
Fix libtdb some to move back towards allowing out of tree builds
Remaining problem is that not all *.syms linker scripts are generated
so the LD command needs to look in a single place. Out of tree
builds now work but report write access to the source tree in order
to create the $(srcdir)/expotrs/libtdb.sysms file.
Eric Cronin [Mon, 24 Mar 2008 19:33:04 +0000 (12:33 -0700)]
Missing HAVE_UPDWTMPX check before using updwtmpx().
In 10.5 Mac OS X added enough utmpx support to make it past the
first two preprocessor checks around line 390 of src/smbd/utmp.c
and on to the utmpx block which uses updwtmpx(). Unfortunately,
as ./configure correctly surmised, 10.5 doesn't have that.
https://bugzilla.samba.org/show_bug.cgi?id=5184
Volker Lendecke [Sun, 23 Mar 2008 18:43:36 +0000 (19:43 +0100)]
Fix Coverity ID 514
Not exactly an uninitialized variable, but having Coverity figure out that
we're only UNMARSHALLING here is probably asking for a bit too much.