samba.git
17 years agoClobber strings with 0xf1f1f1f1 before writing to them to check buffer
Martin Pool [Mon, 10 Mar 2003 01:10:45 +0000 (01:10 +0000)]
Clobber strings with 0xf1f1f1f1 before writing to them to check buffer
lengths are correct.  Attempts to pstrcpy into an fstring or allocated
string should fail in developer builds.

This builds on abartlet's earlier overflow probe for safe_strcpy, but
by clobbering the whole string with a nonzero value is more likely to
find overflows on the stack.

This is only used in -DDEVELOPER mode.

Reviewed by abartlet, tpot.
(This used to be commit 8d915e266cd8ccc8b27e9c7ea8e9d003d05f8182)

17 years agoInclude valgrind.h if present on the system.
Martin Pool [Mon, 10 Mar 2003 00:45:28 +0000 (00:45 +0000)]
Include valgrind.h if present on the system.
(This used to be commit 65ba78c6bd4c5ab7ec9bf4d15e4410482e82588d)

17 years agoCheck for valgrind.h
Martin Pool [Mon, 10 Mar 2003 00:37:25 +0000 (00:37 +0000)]
Check for valgrind.h
(This used to be commit 0ece70d631bf095bf9c8819180b6c59990159cd0)

17 years agoTry not to clobber the session request.
Andrew Bartlett [Sun, 9 Mar 2003 21:09:28 +0000 (21:09 +0000)]
Try not to clobber the session request.
(This used to be commit 05cffbee56f0556f550b4d14f3111bd7db972621)

17 years agoAdd Ronan Waide's info about the setdriver call.
Jelmer Vernooij [Sun, 9 Mar 2003 16:39:34 +0000 (16:39 +0000)]
Add Ronan Waide's info about the setdriver call.
(This used to be commit ef6cb3ec1aa943d4e52ea08e7b43a47d781d3273)

17 years agoAdd some printing question & answers
Jelmer Vernooij [Sun, 9 Mar 2003 12:08:36 +0000 (12:08 +0000)]
Add some printing question & answers
(This used to be commit 998537ca398100974075d11e28d5199997424f15)

17 years agoChange the way we sign SMB packets, to a function pointer interface.
Andrew Bartlett [Sun, 9 Mar 2003 09:23:09 +0000 (09:23 +0000)]
Change the way we sign SMB packets, to a function pointer interface.

The intention is to allow for NTLMSSP and kerberos signing of packets, but
for now it's just what I call 'simple' signing. (aka SMB signing per the SNIA
spec)

Andrew Bartlett
(This used to be commit b9cf95c3dc04a45de71fb16e85c1bfbae50e6d8f)

17 years agoDon't fault on error returns (ptr == 0) for this LSA query.
Andrew Bartlett [Sun, 9 Mar 2003 01:13:41 +0000 (01:13 +0000)]
Don't fault on error returns (ptr == 0) for this LSA query.

(for example, query to non-dc)

Andrew Bartlett
(This used to be commit d1dde5f684652f86e63ac6cfa34ff42a680693de)

17 years agoThis is C, not C++
Andrew Bartlett [Sat, 8 Mar 2003 23:39:44 +0000 (23:39 +0000)]
This is C, not C++
(This used to be commit 25d210b90b6c0377046d89a1dce7a32f94fd7859)

17 years agomore on idmap
Simo Sorce [Sat, 8 Mar 2003 17:29:40 +0000 (17:29 +0000)]
more on idmap
two layers structure with
- local tdb cache
- remote idmap repository

compiles
(This used to be commit 8fb4e210bc7564ed491d121c20d598ba0bfbddff)

17 years agoAdd Q&A for people having trouble trying to log in without a proper
Jelmer Vernooij [Sat, 8 Mar 2003 17:29:00 +0000 (17:29 +0000)]
Add Q&A for people having trouble trying to log in without a proper
samba user database.
(This used to be commit 957c11e40e0aedc24d2dce2aaae9888673d68e01)

17 years agoAdd notes on increasing performance on AIX, based on an email from William Jojo
Jelmer Vernooij [Sat, 8 Mar 2003 15:27:54 +0000 (15:27 +0000)]
Add notes on increasing performance on AIX, based on an email from William Jojo
(This used to be commit 7dc2b10215c2b015a36e78c3b9b8f13cecfdfeba)

17 years agoTestparm needs the extra arg to set_local_machine_name() too.
Andrew Bartlett [Sat, 8 Mar 2003 10:24:48 +0000 (10:24 +0000)]
Testparm needs the extra arg to set_local_machine_name() too.
(This used to be commit 30ba31e6355b5dfb902e42d2b5edc71630db2923)

17 years agoMake sure that the 'remote' machine name can only be set once. For some weird
Andrew Bartlett [Sat, 8 Mar 2003 10:22:50 +0000 (10:22 +0000)]
Make sure that the 'remote' machine name can only be set once.  For some weird
reason, during a Win2003 installation, when you select 'domain join' it sends
one machine name in the name exchange, and litraly 'machinename' during the
NTLMSSP login.

Also fix up winbindd's logfile handling, so that it matches smbd and nmbd.

(This helps me, by seperating the logs by pid).

Andrew Bartlett
(This used to be commit afe5a3832f79131fb74461577f1db0e5e8bf4b6d)

17 years agoMake it clear that this is a fstrcpy().
Andrew Bartlett [Sat, 8 Mar 2003 05:18:08 +0000 (05:18 +0000)]
Make it clear that this is a fstrcpy().
(This used to be commit c2a266b7b661d319e13982bfdbc3a86e8502b8a4)

17 years agoFix typo in earlier fix, caught by Ranjit @ HP.
Jeremy Allison [Sat, 8 Mar 2003 01:16:30 +0000 (01:16 +0000)]
Fix typo in earlier fix, caught by Ranjit @ HP.
Jeremy.
(This used to be commit 13ab94fa73dbaf54da0169bbcf4d027d5c07d207)

17 years agosome more code
Simo Sorce [Sat, 8 Mar 2003 00:49:18 +0000 (00:49 +0000)]
some more code
(not tested yet)
(This used to be commit 0d6cec90c13731827abcbc61974efc993e794003)

17 years agoinitial work for the new idmpa interface
Simo Sorce [Fri, 7 Mar 2003 23:47:59 +0000 (23:47 +0000)]
initial work for the new idmpa interface
(This used to be commit 8338e74ac4e5f31150c96f459a67e52090dc6013)

17 years agoUse ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.
Jeremy Allison [Fri, 7 Mar 2003 23:34:55 +0000 (23:34 +0000)]
Use ERROR_NT, not ERROR_DOS as Andrew Bartlett pointed out.
Jeremy.
(This used to be commit c0930e6d15eb68f06453d9b67142ccd7fb1370a0)

17 years agoAdd early prototype of cifs mount helper for Linux
Steve French [Fri, 7 Mar 2003 22:29:14 +0000 (22:29 +0000)]
Add early prototype of cifs mount helper for Linux
(This used to be commit b20bcf8d336b4b2079eb42342a96d1fe714709de)

17 years agoMissed parentheses around complex logic.
Jeremy Allison [Fri, 7 Mar 2003 19:46:51 +0000 (19:46 +0000)]
Missed parentheses around complex logic.
Jeremy.
(This used to be commit e81427c2d69be166afad94bc083e750e8f48fba7)

17 years agoPatch from Michael Steffens. In his own words :
Jeremy Allison [Fri, 7 Mar 2003 19:37:27 +0000 (19:37 +0000)]
Patch from Michael Steffens. In his own words :
-------------------------------------------------------------------------
I think there are basically two problem:

  1. Windows clients do not always send ACEs for SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ,
     and SMB_ACL_OTHER.
     The function ensure_canon_entry_valid() is prepared for that, but tries
     to "guess" values from group or other permissions, respectively, otherwise
     falling back to minimum r-- for the owner. Even if the owner had full
     permissions before setting ACL. This is the problem with W2k clients.

  2. Function set_nt_acl() always chowns *before* attempting to set POSIX ACLs.
     This is ok in a take-ownership situation, but must fail if the file is
     to be given away. This is the problem with XP clients, trying to transfer
     ownership of the original file to the temp file.

The problem with NT4 clients (no ACEs are transferred to the temp file, thus
are lost after moving the temp file to the original name) is a client problem.
It simply doesn't attempt to.

I have played around with that using posic_acls.c from 3.0 merged into 2.2.
As a result I can now present two patches, one for each branch. They
basically modify:

  1. Interpret missing SMB_ACL_USER_OBJ, SMB_ACL_GROUP_OBJ, or SMB_ACL_OTHER
     as "preserve current value" instead of attempting to build one ourself.
     The original code is still in, but only as fallback in case current values
     can't be retrieved.

  2. Rearrange set_nt_acl() such that chown is only done before setting
     ACLs if there is either no change of owning user, or change of owning
     user is towards the current user. Otherwise chown is done after setting
     ACLs.

It now seems to produce reasonable results. (Well, as far as it can. If
NT4 doesn't even try to transfer ACEs, only deliberate use of named default
ACEs and/or "force group" or the crystal ball can help :)
-------------------------------------------------------------------------
Jeremy.
(This used to be commit 8ec20cbae7ca7e685b1a4186d8482c7405915dc3)

17 years agoSome progress towards gums and tdbsam2
Simo Sorce [Fri, 7 Mar 2003 18:26:24 +0000 (18:26 +0000)]
Some progress towards gums and tdbsam2
genparser works fine, and it is a marvelous tool to store objects in tdb :)
(This used to be commit 4c6d461a8572f03cd33cba95500cc837638b732c)

17 years agoLimit the number of SIDs that may be looked up, in line with existing code
Andrew Bartlett [Fri, 7 Mar 2003 09:29:56 +0000 (09:29 +0000)]
Limit the number of SIDs that may be looked up, in line with existing code
for name->sid.
(This used to be commit 0ebccc0dbeecc10d423529909a2563fbc3bf9857)

17 years agosafe_strcpy() -> fstrcpy() fix, and a cleanup to how rpcclient calls the
Andrew Bartlett [Fri, 7 Mar 2003 09:25:48 +0000 (09:25 +0000)]
safe_strcpy() -> fstrcpy() fix, and a cleanup to how rpcclient calls the
IP address resolving code.
(This used to be commit 1f605fe77c56ee2a7838c9f87eedf4bb91ebf688)

17 years agoFix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.
Jeremy Allison [Fri, 7 Mar 2003 00:34:43 +0000 (00:34 +0000)]
Fix noticed by Corny.Bondad@hp.com. Ensure we free up memory on error exit.
Jeremy.
(This used to be commit 1cbd53dc3cd2d56f5e62d42fed5d589efcecb8f8)

17 years agoFound at Connectathon, .NET RC1 arranges trans/trans2/nttrans parameters
Jeremy Allison [Fri, 7 Mar 2003 00:30:29 +0000 (00:30 +0000)]
Found at Connectathon, .NET RC1 arranges trans/trans2/nttrans parameters
differently to W2K, cope with this.
Jeremy.
(This used to be commit 172f415c9eaa4d310a52794e3dc1a6bc92206ce4)

17 years agoAdd documentation on line returned by 'add printer command' script
Jelmer Vernooij [Thu, 6 Mar 2003 17:09:07 +0000 (17:09 +0000)]
Add documentation on line returned by 'add printer command' script
(This used to be commit d41dbe568ec77e4860678e5ee4fe2ab2f2da507b)

17 years agoRedirect to printer docs for removed options
Jelmer Vernooij [Thu, 6 Mar 2003 17:05:33 +0000 (17:05 +0000)]
Redirect to printer docs for removed options
(This used to be commit 401a522d88abdb6d6f01707f51b658d4e0497d3d)

17 years agoadd #define for the max device name length in a DEVICEMODE
Gerald Carter [Thu, 6 Mar 2003 16:06:12 +0000 (16:06 +0000)]
add #define for the max device name length in a DEVICEMODE
(This used to be commit 21ec2b6ba3ddba6964f6ddb53f8494e4a8b48a83)

17 years agoMake smbtorture use the same cli_full_connection() framework as the rest of
Andrew Bartlett [Thu, 6 Mar 2003 10:37:51 +0000 (10:37 +0000)]
Make smbtorture use the same cli_full_connection() framework as the rest of
Samba.  This fixes things like not doing *SMBSERVER etc.

Andrew Bartlett
(This used to be commit 8863ff863c1da42aa6b8718f315c608d9d9067c6)

17 years agomore off-by-one safe_strcpy()
Andrew Bartlett [Thu, 6 Mar 2003 08:24:39 +0000 (08:24 +0000)]
more off-by-one safe_strcpy()
(This used to be commit d8d2d5e75503ae2b6532a25e4c9bbcdf20cc60af)

17 years agoMore safe_strcpy() off-by-one bug fixes. (mostly moves to pstrcpy()/fstrcpy())
Andrew Bartlett [Thu, 6 Mar 2003 07:55:48 +0000 (07:55 +0000)]
More safe_strcpy() off-by-one bug fixes. (mostly moves to pstrcpy()/fstrcpy())

Andrew Bartlett
(This used to be commit 42b5514404bc7e33306c11344c6c934a1f83d295)

17 years agoFIXME about crash on failure case.
Martin Pool [Thu, 6 Mar 2003 07:36:08 +0000 (07:36 +0000)]
FIXME about crash on failure case.
(This used to be commit a387c4209735f8e4c826cad7cb10c5349b2041ec)

17 years agoAdd *SMBSERVER fallback code to smbtorture ...
Richard Sharpe [Wed, 5 Mar 2003 23:55:11 +0000 (23:55 +0000)]
Add *SMBSERVER fallback code to smbtorture ...
(This used to be commit 460339db2246b0213252ee34f507eb8e55ecbecb)

17 years agoAdd code to allow us to specify the port to connect on when performing
Richard Sharpe [Wed, 5 Mar 2003 23:29:36 +0000 (23:29 +0000)]
Add code to allow us to specify the port to connect on when performing
a test ...
(This used to be commit 1128a2fb4c16681e669efe605ff7d7161a2f7acd)

17 years agoUse new configure test to turn on this automated test for correct string
Andrew Bartlett [Wed, 5 Mar 2003 09:40:08 +0000 (09:40 +0000)]
Use new configure test to turn on this automated test for correct string
function usage.

Andrew Bartlett
(This used to be commit cdc6139a9646b267a9921fc11fa532640a2e4c7f)

17 years agoA couple more fixes for fstrcpy() into a malloced region. In this case it's
Andrew Bartlett [Wed, 5 Mar 2003 09:36:41 +0000 (09:36 +0000)]
A couple more fixes for fstrcpy() into a malloced region.  In this case it's
all perfectly legit - the region is an fstring in length, but might not
always be, and it is the last peice of code to fail my automated test.

Andrew Bartlett
(This used to be commit 762d61b37d053568b6346e249ba7ef594320153a)

17 years agoAdd a test for a useful property of the compiler - we can get link-time
Andrew Bartlett [Wed, 5 Mar 2003 09:33:43 +0000 (09:33 +0000)]
Add a test for a useful property of the compiler - we can get link-time
failures for some compile-time properties this way.

Andrew Bartlett
(This used to be commit ce618624b7df797e228f8ef0f19820b318c62ae9)

17 years agoalso ignore the autom4te-2.53.cache
Andrew Bartlett [Wed, 5 Mar 2003 08:49:56 +0000 (08:49 +0000)]
also ignore the autom4te-2.53.cache
(This used to be commit 243c9c37a53501b96df6286517e03eb09efcc620)

17 years agoThis file has not been maintained for a while - if we really want this
Andrew Bartlett [Wed, 5 Mar 2003 08:48:08 +0000 (08:48 +0000)]
This file has not been maintained for a while - if we really want this
behaviour we should seperate -g from --enable-developer, and allow developers
to also select --enable-debug if they want.

Andrew Bartlett
(This used to be commit 96d1449c42597ea22c538a004960b26925c641fc)

17 years agolp_string: Add note about dodgy StrnCpy use.
Martin Pool [Wed, 5 Mar 2003 05:19:35 +0000 (05:19 +0000)]
lp_string: Add note about dodgy StrnCpy use.
(This used to be commit b32ae2d83fd0b4dd2c313cd0727bd276564cec0c)

17 years agoUse PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinter
Tim Potter [Wed, 5 Mar 2003 05:14:19 +0000 (05:14 +0000)]
Use PRINTER_ALL_ACCESS instead of MAXIMUM_ALLOWED_ACCESS in setprinter
command.  From Ronan Waide <waider@waider.ie>.
(This used to be commit 992b5eb4e05fbf99d91d7235b9a002957533f95b)

17 years agoMore const fixes.
Jeremy Allison [Wed, 5 Mar 2003 01:34:37 +0000 (01:34 +0000)]
More const fixes.
Jeremy.
(This used to be commit 7b945e10a6c636c0b0aabc841803bf44405cb2ae)

17 years agoWritable string const fixes.
Jeremy Allison [Wed, 5 Mar 2003 01:30:26 +0000 (01:30 +0000)]
Writable string const fixes.
Jeremy.
(This used to be commit 60b0cfc8a5b6275d3460ebc6bf17d0f08e25b67e)

17 years agoConnectathon fix. W2K -> W2K over port 445 doing a tconX does the full
Jeremy Allison [Wed, 5 Mar 2003 00:54:07 +0000 (00:54 +0000)]
Connectathon fix. W2K -> W2K over port 445 doing a tconX does the full
\\server\share syntax, not just a "share" tconX syntax. This broke interop
with a vendor.
Jeremy.
(This used to be commit 9d7ea5585c873156ede4b56e43a0d4d75077283a)

17 years agoFix another 'off by one' bug with safe_strcpy(). It is unclear if the intent
Andrew Bartlett [Tue, 4 Mar 2003 09:33:34 +0000 (09:33 +0000)]
Fix another 'off by one' bug with safe_strcpy().  It is unclear if the intent
was to limit the string to 31 or 32 characters (excluding the null term), so
I've assumed for now that 32 is fine, as this matches current behaviour (well, current behaviour would crash, but anyway...)

Jerry:  Can you look at this for me?

Andrew Bartlett
(This used to be commit 6c43327ea2b50820ea4f623c889dc4525d58baa3)

17 years agoAnother pstrcpy() into malloc()ed buffer fix.
Andrew Bartlett [Mon, 3 Mar 2003 23:53:35 +0000 (23:53 +0000)]
Another pstrcpy() into malloc()ed buffer fix.

Andrew Bartlett
(This used to be commit bd0c84d60b703e89081838a7cfa1eb1b4f45ad0a)

17 years agoConst warning fixes.
Jeremy Allison [Mon, 3 Mar 2003 20:12:07 +0000 (20:12 +0000)]
Const warning fixes.
Jeremy.
(This used to be commit 3ad62ebe26d8c6b82f8618eea11d104b3ab0ec18)

17 years agodlsym takes a const char *.
Jeremy Allison [Mon, 3 Mar 2003 19:53:04 +0000 (19:53 +0000)]
dlsym takes a const char *.
Jeremy.
(This used to be commit ff3827a62b37342b13fd8b4eafd256d91428c02b)

17 years agoFix "might be used uninitialised" warnings.
Jeremy Allison [Mon, 3 Mar 2003 19:36:16 +0000 (19:36 +0000)]
Fix "might be used uninitialised" warnings.
Jeremy.
(This used to be commit a670b57c563b220c2ede1dac4ce1e9c71c866498)

17 years agoDo my janitorial duties to encourage others to do so.
Richard Sharpe [Mon, 3 Mar 2003 17:43:33 +0000 (17:43 +0000)]
Do my janitorial duties to encourage others to do so.
Fix lingering large offset problems in smbtar etc.
(This used to be commit c416eec2f2a38eebfcda5868999d474628037f1e)

17 years ago* always report ourselves as a Windows 2000 print server (even
Gerald Carter [Mon, 3 Mar 2003 17:33:57 +0000 (17:33 +0000)]
* always report ourselves as a Windows 2000 print server (even
  without ADS support)
* add "MinorVersion" print server data key and comment on "OSVersion"
(This used to be commit 342734e3de71c7dc8e3d24fd66dae58cf647a569)

17 years ago* CR1868: only send a change notify message if we have something
Gerald Carter [Mon, 3 Mar 2003 16:34:19 +0000 (16:34 +0000)]
* CR1868: only send a change notify message if we have something
  that changed that the client is monitoring.

* couple of comments abnout how we need to validate driver names
  on SetPrinter() and AddPrinter()

* up the debug level on some overly verbose dev mode parsing messages
(This used to be commit 7377d671e8a95ac2ab0452f564b18b2a098699cb)

17 years agoTry the PASSWD environment variable if we don't have one from the command line.
Andrew Bartlett [Mon, 3 Mar 2003 09:16:21 +0000 (09:16 +0000)]
Try the PASSWD environment variable if we don't have one from the command line.
(This used to be commit 14d7d8b22993ca7f1c273a7baaccb09c8fa04ef9)

17 years agoFixes to the vfs_fake_perms modules - we only need to specify the VFS
Andrew Bartlett [Mon, 3 Mar 2003 09:12:40 +0000 (09:12 +0000)]
Fixes to the vfs_fake_perms modules - we only need to specify the VFS
functions that we actually modify.

Also a better implementation of the stat() and fstat() functions.

Andrew Bartlett
(This used to be commit 03e74be11cf76167ed211398016274cbaba5847b)

17 years agoAdd const
Andrew Bartlett [Mon, 3 Mar 2003 08:35:49 +0000 (08:35 +0000)]
Add const
(This used to be commit 251b91f46988053eccc53f814a23ed5ca787c852)

17 years agoi forgot to commit the privilege db init call
Andrew Tridgell [Sat, 1 Mar 2003 10:47:38 +0000 (10:47 +0000)]
i forgot to commit the privilege db init call
(This used to be commit e8ec2b118071ce1d8cbfbcebce3781ac753c5c22)

17 years agoAdded limit to number of jobs enumerated. Set to 0 (means no limit).
Jeremy Allison [Sat, 1 Mar 2003 02:39:14 +0000 (02:39 +0000)]
Added limit to number of jobs enumerated. Set to 0 (means no limit).
Yes I will add the docs....
Jeremy.
(This used to be commit 4a739d914bb87a3c8d071dfd0f275a9aab1cf90a)

17 years agothe new DEVELOPER checks for string overflows have (as expected)
Andrew Tridgell [Sat, 1 Mar 2003 01:07:18 +0000 (01:07 +0000)]
the new DEVELOPER checks for string overflows have (as expected)
broken a lot of stuff. These two macros are meant to make life easier
when fixing these bugs. I'm guessing we will see more macros like
this (eg. fstrcpy_base)
(This used to be commit 50389c0cb2504d7941ec691af21d6a20ae5c5de7)

17 years agoEnsure added jobs increment total_jobs.
Jeremy Allison [Sat, 1 Mar 2003 00:48:09 +0000 (00:48 +0000)]
Ensure added jobs increment total_jobs.
Jeremy.
(This used to be commit d29c6853dd0c43825b3775020076f34faa5cd329)

17 years agoFix HTTP error codes (patch by Vance Lankhaar)
Jelmer Vernooij [Fri, 28 Feb 2003 08:47:22 +0000 (08:47 +0000)]
Fix HTTP error codes (patch by Vance Lankhaar)
(This used to be commit 3780d127313ad9f4411751d34fd6e1d96b1422cf)

17 years agofixed a crash bug in the new winbindd 'sids rule!' code
Andrew Tridgell [Fri, 28 Feb 2003 06:03:35 +0000 (06:03 +0000)]
fixed a crash bug in the new winbindd 'sids rule!' code
(This used to be commit 7dfd59963dba921907893b9d1bffe797e9d8b4ad)

17 years agoDoxygen janitor: add note that strequal is in fact case-insensitive.
Martin Pool [Fri, 28 Feb 2003 05:34:19 +0000 (05:34 +0000)]
Doxygen janitor: add note that strequal is in fact case-insensitive.
(This used to be commit a4b9c5c2576c80a5f60d47d178b9b8c50d348893)

17 years ago- added help on -P option
Andrew Tridgell [Fri, 28 Feb 2003 04:36:08 +0000 (04:36 +0000)]
- added help on -P option
- added general options to 'net -h' help
(This used to be commit ee8a7fdab7f5aa6f4a64f2eea90f0d44ae0f388a)

17 years agoDoxygen janitor
Martin Pool [Fri, 28 Feb 2003 04:21:55 +0000 (04:21 +0000)]
Doxygen janitor
(This used to be commit 9af07173152c5e861d13b33a8d4aee8167a50b66)

17 years agoDoxygen janitor: fix parameter names, grammar, tag names.
Martin Pool [Fri, 28 Feb 2003 04:17:30 +0000 (04:17 +0000)]
Doxygen janitor: fix parameter names, grammar, tag names.
(This used to be commit 42d9ec28cd55dbcfda546c84fb842938aeda544d)

17 years agoDoxygen janitor: rpc_resolve_dc parameter is spelled "trust_passwd"
Martin Pool [Fri, 28 Feb 2003 04:11:28 +0000 (04:11 +0000)]
Doxygen janitor: rpc_resolve_dc parameter is spelled "trust_passwd"
(This used to be commit 9dbc3dcfe0bccf1f76930ae86970b48ba5ed1e91)

17 years agoDoxygen janitor: check_domain_match parameter is spelled
Martin Pool [Fri, 28 Feb 2003 04:09:58 +0000 (04:09 +0000)]
Doxygen janitor: check_domain_match parameter is spelled
"auth_context".
(This used to be commit 571c3ce19344276aac1af56d2f69fcc5523f36eb)

17 years agoFix comment typo
Martin Pool [Fri, 28 Feb 2003 04:06:56 +0000 (04:06 +0000)]
Fix comment typo
(This used to be commit d2fd52c1b50f2d1abad84668911b04c72fdc4b8d)

17 years agoRemove reference to "mainpage.dox" and CodingStandards, which have
Martin Pool [Fri, 28 Feb 2003 03:59:47 +0000 (03:59 +0000)]
Remove reference to "mainpage.dox" and CodingStandards, which have
been removed.

Put subdirectory names in file list, so we get lib/util_chr.c, not
just util_chr.c.
(This used to be commit aa2efaab1ffc77bec051cd206000951c72adeccc)

17 years agoAdd a comment about the meaning of samba's internal character set and
Martin Pool [Fri, 28 Feb 2003 03:51:25 +0000 (03:51 +0000)]
Add a comment about the meaning of samba's internal character set and
how this interacts with it.
(This used to be commit eb876ee9cf24eda04e0856899b232d060c669c0c)

17 years agoAdd simple test harness that exposes StrCaseCmp for testing.
Martin Pool [Fri, 28 Feb 2003 03:34:18 +0000 (03:34 +0000)]
Add simple test harness that exposes StrCaseCmp for testing.
(This used to be commit ab77beca041595bc3bd70de3a6e1b49159a4964b)

17 years agocleanup some compiler warnings
Jim McDonough [Fri, 28 Feb 2003 03:29:03 +0000 (03:29 +0000)]
cleanup some compiler warnings
(This used to be commit 87cebe797f06fab4a5d0077fd78b2183ff7333a5)

17 years agoImprove net ads lookup:
Jim McDonough [Fri, 28 Feb 2003 03:21:22 +0000 (03:21 +0000)]
Improve net ads lookup:
- More info is printed
- (grand)child domains handled properly

Thanks to Anthony Liguori (aliguori@us.ibm.com)
(This used to be commit 3dbcb4d93f7c192eb2ccea5941a3843b5de1190e)

17 years ago*Excellent* patch from Michael Steffens <michael_steffens@hp.com> to limit
Jeremy Allison [Fri, 28 Feb 2003 00:26:20 +0000 (00:26 +0000)]
*Excellent* patch from Michael Steffens <michael_steffens@hp.com> to limit
the unix domain sockets used by winbindd (also solves FD_SETSIZE problem
in winbindd to boot !). Adds a "last_access" field to winbindd connections,
and will close the oldest idle connection once the number of open connections
goes over WINBINDD_MAX_SIMULTANEOUS_CLIENTS (defined in local.h as 200
currently).
Jeremy.
(This used to be commit a82caefda49396641e8650db8a7ef51752ba6c41)

17 years ago don't forget the NULL
Gerald Carter [Thu, 27 Feb 2003 23:52:37 +0000 (23:52 +0000)]
 don't forget the NULL
(This used to be commit f80610120483c929afbec83d2b8649cb3e5111b0)

17 years agoand the winner of "i should have just written it in assembly
Gerald Carter [Thu, 27 Feb 2003 23:24:26 +0000 (23:24 +0000)]
and the winner of "i should have just written it in assembly
is..."

don't use pstrcpy() when you are not dealing with pstrings.
(This used to be commit 7d547f50f914747291acc71fd3544ad92ce91f0e)

17 years agodon't pass NULL pointers to strcmp()
Gerald Carter [Thu, 27 Feb 2003 21:37:54 +0000 (21:37 +0000)]
don't pass NULL pointers to strcmp()
(This used to be commit 6631984b12a3f74b93f7031c433dd81d6586a5df)

17 years agoadditional fix for CR 601
Gerald Carter [Thu, 27 Feb 2003 21:21:02 +0000 (21:21 +0000)]
additional fix for CR 601
  * distinguish WinXP from Win2k
  * add a 1/3 of a second delay in OpenPrinter
    in order to trigger a LAN/WAN optimization in
    2k clients.
(This used to be commit 96570699d1b715f47c35aa211da6ec18f6fc4109)

17 years agoDoxygen janitor
Martin Pool [Thu, 27 Feb 2003 05:53:25 +0000 (05:53 +0000)]
Doxygen janitor
(This used to be commit 67bf36c69d19463c28066b276d74ac4784b26bed)

17 years agoRemove documentation for obsolete parameters, but add a note in 'upgrading-to-3.0'
Jelmer Vernooij [Thu, 27 Feb 2003 02:28:26 +0000 (02:28 +0000)]
Remove documentation for obsolete parameters, but add a note in 'upgrading-to-3.0'
(This used to be commit e37b69f33410844b55bcca07e95d0a76aa48a7de)

17 years agoWe now use <anchor/> instead of just <anchor> (strict XML syntax)
Jelmer Vernooij [Thu, 27 Feb 2003 02:17:54 +0000 (02:17 +0000)]
We now use <anchor/> instead of just <anchor> (strict XML syntax)
(This used to be commit 7c00fff475e15a9e9d5c3d2c8394a2cdc1b90cac)

17 years ago- Rename 'modules = ' to 'preload modules = '
Jelmer Vernooij [Thu, 27 Feb 2003 01:54:41 +0000 (01:54 +0000)]
- Rename 'modules = ' to 'preload modules = '
- Add smb_probe_module()
- Add init_modules()
- Call these functions
(This used to be commit f8f21653225792c0001d183c6efe8b7d89a0785d)

17 years agoFix possible memory leak on failure.
Andrew Bartlett [Thu, 27 Feb 2003 01:05:12 +0000 (01:05 +0000)]
Fix possible memory leak on failure.
(This used to be commit 052ebc44cde8d31571ed1edb602794349825be11)

17 years agoFix to allow blocking lock notification to be done rapidly (no wait
Jeremy Allison [Thu, 27 Feb 2003 00:43:23 +0000 (00:43 +0000)]
Fix to allow blocking lock notification to be done rapidly (no wait
for smb -> smb lock release). Adds new PENDING_LOCK type to lockdb
(does not interfere with existing locks).
Jeremy.
(This used to be commit 22fc0d48ff2052b4274c65f85050c58b235bf4e4)

17 years agoAdd -Wwrite-strings to our --enable-developer settings.
Andrew Bartlett [Wed, 26 Feb 2003 12:31:17 +0000 (12:31 +0000)]
Add -Wwrite-strings to our --enable-developer settings.

We have compiled relitivly 'clean' with this setting since I did a massive
cleanup last month.  This should help us stay that way.

Andrew Bartlett
(This used to be commit 284479bf388f5e39d9be78eeb1ac6cdd001fb8df)

17 years agoNetlogon-unigroup changes needed for the winbind RID-to-SID conversion.
Andrew Bartlett [Wed, 26 Feb 2003 12:23:03 +0000 (12:23 +0000)]
Netlogon-unigroup changes needed for the winbind RID-to-SID conversion.

This changes the cache format, which will simply invalidate existing entries,
leaving them dead in the cache.

Andrew Bartlett
(This used to be commit 3fc179362ea849db23490b971a9f64f943e7f7f8)

17 years agoKill RID-only and domain+RID madness from winbind.
Andrew Bartlett [Wed, 26 Feb 2003 12:21:01 +0000 (12:21 +0000)]
Kill RID-only and domain+RID madness from winbind.

Now we deal with SIDs in almost all of winbind (a couple of limited exceptions
remain, but I'm looking into them - they use non-winbind structs ATM).

This has particular benifits in returning out-of-domain SIDs for group
membership (Need to look into this a bit more) as well as general code quality.

This also removes much of the complexity from the idmap interface, which now
only deals with mapping IDs, not with SID->domain translations.

Breifly tested, but needs more.  Fixes some valgrind-found bugs from my
previous commit.

Winbind cache chagned to using SID strings in some places, as I could not
follow exactly how to save and restore multiple packed sids properly.

Andrew Bartlett
(This used to be commit 9247cf08c40f016a924d600ac906cfc6a7016777)

17 years agoinit_valid_table: Fix a memory leak that would lose the
Martin Pool [Wed, 26 Feb 2003 06:19:16 +0000 (06:19 +0000)]
init_valid_table: Fix a memory leak that would lose the
dynamically-created valid table every time the configuration was
reloaded.
(This used to be commit e42b237d980461caf2dd2a8f82c17bf674facb7d)

17 years agoMerge from appliance:
Tim Potter [Wed, 26 Feb 2003 00:52:41 +0000 (00:52 +0000)]
Merge from appliance:

>Another hopeful fix for CR#1168.  Change the RPC used in querying
>domain users from QueryDispInfo to EnumDomainUsers.  Hopefully this
>will fix the random dropouts that keep occuring when listing large
>domains.
>
>My thought is that since QueryDispInfo is only used in the NT user
>manager it may have a bug with large domains.  A more commonly used
>RPC may not have such problems.
(This used to be commit 0501b7d0b12fa8063ffe6a9d4ecc3391d0c2f45d)

17 years agoFix compiler warning.
Tim Potter [Tue, 25 Feb 2003 23:35:25 +0000 (23:35 +0000)]
Fix compiler warning.
(This used to be commit 0308f24ad209a28799b36d041be2dc2be2b2dac8)

17 years agoMore const fixes and flow on fixes from yesterday's const-fest.
Tim Potter [Tue, 25 Feb 2003 23:34:57 +0000 (23:34 +0000)]
More const fixes and flow on fixes from yesterday's const-fest.
(This used to be commit 018733eedd7897e6811e8461c07e3acf418c0e09)

17 years agoFix unused variable warning when ENCTYPE_ARCFOUR_HMAC is not defined.
Tim Potter [Tue, 25 Feb 2003 23:30:46 +0000 (23:30 +0000)]
Fix unused variable warning when ENCTYPE_ARCFOUR_HMAC is not defined.
(This used to be commit 92abafa62894a125c5a09fc92f5056e4d8b51089)

17 years agoFix breakage done by myself yesterday.
Tim Potter [Tue, 25 Feb 2003 23:28:28 +0000 (23:28 +0000)]
Fix breakage done by myself yesterday.
(This used to be commit f4492de2d668082df6ae06933d12a3cfe120d403)

17 years agoProgress on CR 601
Gerald Carter [Tue, 25 Feb 2003 20:51:23 +0000 (20:51 +0000)]
Progress on CR 601

cache the printer_info_2 with the open printer handle.
cache is invalidated on a mod_a_printer() call **on that smbd**.

Yes, this means that the window for admins to step on each other
from different clients just got larger, but since handles a generally
short lived this is probably ok.
(This used to be commit 33c7b7522504fb15989f32add8e9a087c8d9d0fa)

17 years agoFixed up some const related compiler warnings.
Tim Potter [Tue, 25 Feb 2003 06:24:13 +0000 (06:24 +0000)]
Fixed up some const related compiler warnings.
(This used to be commit 923425e497112c5d1e2e569da6c13dcd02b6a8af)

17 years agoAfter some comments from tridge, clean the new usergroups code into a helper
Andrew Bartlett [Tue, 25 Feb 2003 05:49:24 +0000 (05:49 +0000)]
After some comments from tridge, clean the new usergroups code into a helper
function.

Andrew Bartlett
(This used to be commit 212a52b3d2ca39fcea2990f9293754b08e9b68e4)

17 years agoFor some reason some attributes in ADS do not appear (and are not available)
Andrew Bartlett [Tue, 25 Feb 2003 03:30:39 +0000 (03:30 +0000)]
For some reason some attributes in ADS do not appear (and are not available)
in general searches, but only if searching for the DN only.

In my case, it was the tokenGroups attribute that caused me trouble, hence
this patch.

Andrew Bartlett
(This used to be commit 8a0cc4c2beb5d6ad7e44bf47bf0f9ec4a3ffdb96)

17 years agotokenGroups are SIDs, so dump them as such.
Andrew Bartlett [Tue, 25 Feb 2003 02:23:19 +0000 (02:23 +0000)]
tokenGroups are SIDs, so dump them as such.
(This used to be commit 43f07e9de70ad9993265e28a54239caba0121ab6)