samba.git
12 years agos3-printing: move os2 related functions to printing/nt_printing_os2.c.
Günther Deschner [Mon, 4 Jul 2011 23:24:48 +0000 (01:24 +0200)]
s3-printing: move os2 related functions to printing/nt_printing_os2.c.

Guenther

Pair-Programmed-With: David Disseldorp <ddiss@suse.de>

12 years agos3: Remove a use of cli_errstr
Volker Lendecke [Thu, 7 Jul 2011 13:42:33 +0000 (15:42 +0200)]
s3: Remove a use of cli_errstr

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul  7 18:04:26 CEST 2011 on sn-devel-104

12 years agos3-waf: Fix linking bugs causing segfaults.
Andreas Schneider [Thu, 7 Jul 2011 12:59:51 +0000 (14:59 +0200)]
s3-waf: Fix linking bugs causing segfaults.

As auth_util.c is linked several times the static variables have
different address on different calls. This leads to segfaults.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Jul  7 16:50:05 CEST 2011 on sn-devel-104

12 years agos3:testparm: avoid spurious warnings about dos mode mapping and create mask if store...
Gregor Beck [Wed, 6 Jul 2011 13:10:27 +0000 (15:10 +0200)]
s3:testparm: avoid spurious warnings about dos mode mapping and create mask if store dos attributes is set

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Jul  7 12:49:01 CEST 2011 on sn-devel-104

12 years agos4 provision: Add some of the AD-specific DNS records to the directory
Kai Blin [Mon, 27 Jun 2011 09:25:39 +0000 (11:25 +0200)]
s4 provision: Add some of the AD-specific DNS records to the directory

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Thu Jul  7 02:29:53 CEST 2011 on sn-devel-104

12 years agos4 provision: split up DNS provisioning into generic and samba-specific ldifs
Kai Blin [Sat, 25 Jun 2011 22:36:25 +0000 (00:36 +0200)]
s4 provision: split up DNS provisioning into generic and samba-specific ldifs

Signed-off-by: Kai Blin <kai@samba.org>
12 years agos4:torture/smb2: s/smb2cli_unlock/test_smb2_unlock
Stefan Metzmacher [Wed, 6 Jul 2011 15:52:33 +0000 (17:52 +0200)]
s4:torture/smb2: s/smb2cli_unlock/test_smb2_unlock

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 19:07:42 CEST 2011 on sn-devel-104

12 years agos4:torture/smb2: s/smb2cli_lock/test_smb2_lock
Stefan Metzmacher [Wed, 6 Jul 2011 15:52:33 +0000 (17:52 +0200)]
s4:torture/smb2: s/smb2cli_lock/test_smb2_lock

metze

12 years agos3:libsmb: use clistr_pull_talloc() in cli_qfilename()
Stefan Metzmacher [Wed, 6 Jul 2011 12:35:13 +0000 (14:35 +0200)]
s3:libsmb: use clistr_pull_talloc() in cli_qfilename()

metze

12 years agos3:libsmb: let cli_qfileinfo[_recv]() return recv_flags2
Stefan Metzmacher [Wed, 6 Jul 2011 12:04:15 +0000 (14:04 +0200)]
s3:libsmb: let cli_qfileinfo[_recv]() return recv_flags2

metze

12 years agos3:libsmb: use clistr_pull_talloc() in cli_get_fs_volume_info()
Stefan Metzmacher [Wed, 6 Jul 2011 11:57:20 +0000 (13:57 +0200)]
s3:libsmb: use clistr_pull_talloc() in cli_get_fs_volume_info()

metze

12 years agos3:libsmb: the SMB_QUERY_FS_VOLUME_INFO response needs at least 18 data bytes
Stefan Metzmacher [Wed, 6 Jul 2011 11:21:41 +0000 (13:21 +0200)]
s3:libsmb: the SMB_QUERY_FS_VOLUME_INFO response needs at least 18 data bytes

metze

12 years agos3:libsmb: don't use cli->inbuf in cli_dfs_get_referral()
Stefan Metzmacher [Wed, 6 Jul 2011 11:04:26 +0000 (13:04 +0200)]
s3:libsmb: don't use cli->inbuf in cli_dfs_get_referral()

The rdata buffer returned by cli_trans() doesn't belong to
cli->inbuf, so don't use it.

metze

12 years agos3:libsmb: fix error handling in cli_dfs_get_referral()
Stefan Metzmacher [Wed, 6 Jul 2011 13:57:22 +0000 (15:57 +0200)]
s3:libsmb: fix error handling in cli_dfs_get_referral()

We should not return NT_STATUS_OK on error.

metze

12 years agos3:sharesec: return an error if get_share_security() returns NULL
Stefan Metzmacher [Wed, 6 Jul 2011 10:31:41 +0000 (12:31 +0200)]
s3:sharesec: return an error if get_share_security() returns NULL

This indicates an error, as it uses get_share_security_default()
if no security descriptor is configured.

Jeremy, please check.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 15:40:23 CEST 2011 on sn-devel-104

12 years agos3:test: catch more errors in test_access_check() in the smbclient_s3 test
Michael Adam [Wed, 6 Jul 2011 10:24:13 +0000 (12:24 +0200)]
s3:test: catch more errors in test_access_check() in the smbclient_s3 test

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Jul  6 14:07:13 CEST 2011 on sn-devel-104

12 years agos3:registry: update copyright for the registry db implementation
Michael Adam [Wed, 6 Jul 2011 10:09:52 +0000 (12:09 +0200)]
s3:registry: update copyright for the registry db implementation

12 years agoexamples/VFS: try to fix the build on openbsd, adding alternative spellings of autoco...
Michael Adam [Wed, 6 Jul 2011 08:37:40 +0000 (10:37 +0200)]
examples/VFS: try to fix the build on openbsd, adding alternative spellings of autoconf/header

The host "samba-amd64" on the build farm running openbsd 4.8 broke.
Taking over the additional spellings of autoconf and autoheader from
the source3/autogen.sh script should fix it.

12 years agos3:sharesec: also initialize pgranted if get_share_security() returns NULL
Stefan Metzmacher [Tue, 5 Jul 2011 14:59:41 +0000 (16:59 +0200)]
s3:sharesec: also initialize pgranted if get_share_security() returns NULL

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jul  6 12:54:30 CEST 2011 on sn-devel-104

12 years agos3: Follow the TALLOC_FREE convention in source3
Volker Lendecke [Wed, 6 Jul 2011 07:39:08 +0000 (09:39 +0200)]
s3: Follow the TALLOC_FREE convention in source3

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 11:01:05 CEST 2011 on sn-devel-104

12 years agos3: Fix Coverity ID 2586 -- NO_EFFECT
Volker Lendecke [Wed, 6 Jul 2011 07:37:04 +0000 (09:37 +0200)]
s3: Fix Coverity ID 2586 -- NO_EFFECT

tsocket_address_bsd_sockaddr returns ssize_t, and on some systems socklen_t is
unsigned. So (len < 0) could never have turned true.

Volker

12 years agos3: Remove cli_errstr from cmd_posix_open
Volker Lendecke [Tue, 5 Jul 2011 17:55:25 +0000 (19:55 +0200)]
s3: Remove cli_errstr from cmd_posix_open

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jul  6 09:45:11 CEST 2011 on sn-devel-104

12 years agos3: Fix error logic in posix_open
Volker Lendecke [Tue, 5 Jul 2011 17:51:09 +0000 (19:51 +0200)]
s3: Fix error logic in posix_open

12 years agos3: Remove a few uses of cli_errstr
Volker Lendecke [Tue, 5 Jul 2011 17:42:46 +0000 (19:42 +0200)]
s3: Remove a few uses of cli_errstr

12 years agos3: make cli_resolve_path return NTSTATUS
Volker Lendecke [Sun, 3 Jul 2011 18:53:55 +0000 (20:53 +0200)]
s3: make cli_resolve_path return NTSTATUS

This looks larger than it is. No parameters needed changing.

12 years agoccan/tally: don't use SIZE_MAX.
Rusty Russell [Wed, 6 Jul 2011 05:17:44 +0000 (14:47 +0930)]
ccan/tally: don't use SIZE_MAX.

Michael Adam points out this broke the build farm (ie. OSF1 axp V5.1 2650 alpha)
so fixed in CCAN and imported from af7a902d74a7926693f55da9e21a67dde46931d4:

    Turns out it's not standard (thanks Samba build farm!)
    And the previous test had a hole in it anyway.  This one is more conservative.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Wed Jul  6 08:34:05 CEST 2011 on sn-devel-104

12 years agobuild: we no longer put #if _SAMBA_BUILD_ == 4 in public headers
Andrew Bartlett [Wed, 6 Jul 2011 03:09:17 +0000 (13:09 +1000)]
build: we no longer put #if _SAMBA_BUILD_ == 4 in public headers

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jul  6 06:46:50 CEST 2011 on sn-devel-104

12 years agos3-build We no longer require to redefine _SAMBA_BUILD_
Andrew Bartlett [Wed, 6 Jul 2011 02:49:11 +0000 (12:49 +1000)]
s3-build We no longer require to redefine _SAMBA_BUILD_

12 years agolibcli/smb move FILE_TYPE constants in common
Andrew Bartlett [Wed, 6 Jul 2011 03:06:14 +0000 (13:06 +1000)]
libcli/smb move FILE_TYPE constants in common

This allows us to remove another _SAMBA_BUILD_ conditional

Andrew Bartlett

12 years agolibcli/smb move enum protocol_types to a common header
Andrew Bartlett [Wed, 6 Jul 2011 03:05:45 +0000 (13:05 +1000)]
libcli/smb move enum protocol_types to a common header

12 years agobuild: Remove _SAMBA_BUILD == 4 from libgpo
Andrew Bartlett [Wed, 6 Jul 2011 02:39:34 +0000 (12:39 +1000)]
build: Remove _SAMBA_BUILD == 4 from libgpo

This code has no hope of building against the samba4 libs (it has been
disabled for a very long time, and files referenced don't exist etc),
and with the common build there simply is no need.

Andrew Bartlett

12 years agolibrpc/ndr remove _SAMBA_BUILD_ conditionals
Andrew Bartlett [Wed, 6 Jul 2011 02:08:52 +0000 (12:08 +1000)]
librpc/ndr remove _SAMBA_BUILD_ conditionals

12 years agobuild: Re-enable the -Wl,--as-needed flag
Andrew Bartlett [Wed, 6 Jul 2011 01:58:10 +0000 (11:58 +1000)]
build: Re-enable the -Wl,--as-needed flag

12 years agos3:smbd fix a compile warning on AIX 5.3
Christian Ambach [Tue, 5 Jul 2011 22:06:27 +0000 (17:06 -0500)]
s3:smbd fix a compile warning on AIX 5.3

use the correct alias instead of FD directly

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue Jul  5 19:51:42 CEST 2011 on sn-devel-104

12 years agos3:build fix autoconf build on AIX 5.3
Christian Ambach [Tue, 5 Jul 2011 22:04:15 +0000 (17:04 -0500)]
s3:build fix autoconf build on AIX 5.3

using ZLIB_LIBS as dependency made AIX make fail trying to
find -lz as build target

12 years ago.gitignore: add AIX WINBIND nss module
Christian Ambach [Tue, 5 Jul 2011 22:02:23 +0000 (17:02 -0500)]
.gitignore: add AIX WINBIND nss module

this cleans up git status on AIX after building source3

12 years agos3:lib fix non-empty blank lines
Christian Ambach [Tue, 28 Jun 2011 16:01:22 +0000 (18:01 +0200)]
s3:lib fix non-empty blank lines

12 years agos3:modules fix non-empty blank lines
Christian Ambach [Tue, 28 Jun 2011 12:59:18 +0000 (14:59 +0200)]
s3:modules fix non-empty blank lines

12 years agos3: Remove some unused variables
Volker Lendecke [Tue, 5 Jul 2011 15:26:04 +0000 (17:26 +0200)]
s3: Remove some unused variables

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Jul  5 18:40:11 CEST 2011 on sn-devel-104

12 years agos3: Fix bug 8102
Volker Lendecke [Tue, 5 Jul 2011 09:13:07 +0000 (11:13 +0200)]
s3: Fix bug 8102

We can't allow open with access that has been denied via the share
security descriptor

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Jul  5 16:21:54 CEST 2011 on sn-devel-104

12 years agos3: Calculate&store the maximum share access mask
Volker Lendecke [Mon, 4 Jul 2011 16:35:21 +0000 (18:35 +0200)]
s3: Calculate&store the maximum share access mask

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agos3: Return "granted" from share_access_check
Volker Lendecke [Mon, 4 Jul 2011 15:02:34 +0000 (17:02 +0200)]
s3: Return "granted" from share_access_check

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agoldb: set -Wl,-no-undefined only on standalone build
Andrew Bartlett [Tue, 5 Jul 2011 05:55:25 +0000 (15:55 +1000)]
ldb: set -Wl,-no-undefined only on standalone build

This ensures that the flag is not propogated to other projects, such
as Samba's source3 waf build.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jul  5 10:37:30 CEST 2011 on sn-devel-104

12 years agoldb: make ldb a top level library for Samba 4.0
Andrew Bartlett [Tue, 5 Jul 2011 00:01:32 +0000 (10:01 +1000)]
ldb: make ldb a top level library for Samba 4.0

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agos4-dbcheck: support the 'none' option for prompts
Andrew Tridgell [Tue, 5 Jul 2011 03:03:18 +0000 (13:03 +1000)]
s4-dbcheck: support the 'none' option for prompts

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Jul  5 08:22:40 CEST 2011 on sn-devel-104

12 years agos4-pycommon: support 'none' as an option in confirm
Andrew Tridgell [Tue, 5 Jul 2011 03:02:48 +0000 (13:02 +1000)]
s4-pycommon: support 'none' as an option in confirm

this allows the user to ask for none of the changes of this type

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

12 years agodbcheck: only use a paged search when checking a ldap database
Andrew Tridgell [Tue, 5 Jul 2011 02:44:07 +0000 (12:44 +1000)]
dbcheck: only use a paged search when checking a ldap database

paged searches don't work against a local database (they return only
the first N objects)

12 years agodbcheck: check for unknown attributes and offer to remove them
Andrew Tridgell [Tue, 5 Jul 2011 02:42:53 +0000 (12:42 +1000)]
dbcheck: check for unknown attributes and offer to remove them

this asks the user if they want to remove an unknown attribute. You
can also choose 'all' which will auto-confirm all questions about
removing unknown attributes.

12 years agos4-pycommon: allow an optional 'all' choice for confirm dialogs
Andrew Tridgell [Tue, 5 Jul 2011 02:38:31 +0000 (12:38 +1000)]
s4-pycommon: allow an optional 'all' choice for confirm dialogs

when asking the user to confirm an action, allow for an 'all'
choice, which will be used to allow the user to confirm all future
requests of the same type

12 years agos4-dsdb: allow removal of unknown attributes if RELAX set
Andrew Tridgell [Tue, 5 Jul 2011 02:36:16 +0000 (12:36 +1000)]
s4-dsdb: allow removal of unknown attributes if RELAX set

this allows attributes not known in the schema to be removed if the
caller has set the RELAX control. This will be used by dbcheck to
allow cleaning of bad attributes from the database

12 years agoccan: fix configure tests for __builtin_clz etc.
Rusty Russell [Tue, 5 Jul 2011 03:38:09 +0000 (13:08 +0930)]
ccan: fix configure tests for __builtin_clz etc.

It's not enough to compile-test them: Michael Adam points out that nonexistant
functions merely cause a warning.  We have to try to link them.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue Jul  5 07:08:55 CEST 2011 on sn-devel-104

12 years agobuild: remove mktowscript
Andrew Bartlett [Mon, 4 Jul 2011 23:47:25 +0000 (09:47 +1000)]
build: remove mktowscript

We finished the conversion a long time ago

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jul  5 05:56:06 CEST 2011 on sn-devel-104

12 years agobuild: Add missing depencency on NDR_NBT
Andrew Bartlett [Tue, 5 Jul 2011 02:33:27 +0000 (04:33 +0200)]
build: Add missing depencency on NDR_NBT

12 years agobuild: Add missing dep on UTIL_TEVENT
Andrew Bartlett [Tue, 5 Jul 2011 02:22:16 +0000 (04:22 +0200)]
build: Add missing dep on UTIL_TEVENT

12 years agos3:registry: remove unused function regdb_key_is_base_key()
Michael Adam [Mon, 4 Jul 2011 15:45:30 +0000 (17:45 +0200)]
s3:registry: remove unused function regdb_key_is_base_key()

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Jul  4 21:11:32 CEST 2011 on sn-devel-104

12 years agos3:registry: replace use of deprecated talloc_destroy by talloc_free.
Michael Adam [Mon, 4 Jul 2011 15:22:01 +0000 (17:22 +0200)]
s3:registry: replace use of deprecated talloc_destroy by talloc_free.

12 years agos3:registry: remove superfluous check for success of talloc_stackframe()
Michael Adam [Mon, 4 Jul 2011 15:21:23 +0000 (17:21 +0200)]
s3:registry: remove superfluous check for success of talloc_stackframe()

12 years agos3:registry: add debug-level-10 verbosity to regdb_upgrade_v2_v3_fn()
Michael Adam [Mon, 4 Jul 2011 15:20:28 +0000 (17:20 +0200)]
s3:registry: add debug-level-10 verbosity to regdb_upgrade_v2_v3_fn()

12 years agos3:registry: adapt a debug message to be more systematic
Michael Adam [Mon, 4 Jul 2011 15:13:58 +0000 (17:13 +0200)]
s3:registry: adapt a debug message to be more systematic

12 years agos3:registry: set registry version to 3 and add upgrade code
Michael Adam [Mon, 4 Jul 2011 14:23:08 +0000 (16:23 +0200)]
s3:registry: set registry version to 3 and add upgrade code

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: add db_context argument to regdb_upgrade_v1_to_v2()
Michael Adam [Mon, 4 Jul 2011 14:21:26 +0000 (16:21 +0200)]
s3:registry: add db_context argument to regdb_upgrade_v1_to_v2()

12 years agos3:registry: wrap the whole db upgrade in one transaction
Michael Adam [Mon, 4 Jul 2011 14:15:11 +0000 (16:15 +0200)]
s3:registry: wrap the whole db upgrade in one transaction

The purpose of this is to prepare for multiple upgrade steps
to be performed in a single transaction, so that no change
at all is made to that database if one step fails.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: change regdb_store_regdb_version() to take db_context argument.
Michael Adam [Mon, 4 Jul 2011 14:09:33 +0000 (16:09 +0200)]
s3:registry: change regdb_store_regdb_version() to take db_context argument.

12 years agos3:registry: fix a comment typo
Michael Adam [Mon, 4 Jul 2011 13:23:39 +0000 (15:23 +0200)]
s3:registry: fix a comment typo

12 years agos3:registry: remove unused regdb_delete_sorted_subkeys()
Michael Adam [Fri, 1 Jul 2011 11:49:12 +0000 (13:49 +0200)]
s3:registry: remove unused regdb_delete_sorted_subkeys()

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: don't delete the unused subkeys cache record any more
Michael Adam [Fri, 1 Jul 2011 11:48:16 +0000 (13:48 +0200)]
s3:registry: don't delete the unused subkeys cache record any more

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: remove the code to create and search the sorted subkeys cache records
Michael Adam [Fri, 1 Jul 2011 11:37:41 +0000 (13:37 +0200)]
s3:registry: remove the code to create and search the sorted subkeys cache records

This is not needed any more.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: adapt the comment explaining the definition of the existence of a key.
Michael Adam [Fri, 1 Jul 2011 11:33:44 +0000 (13:33 +0200)]
s3:registry: adapt the comment explaining the definition of the existence of a key.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: regdb_key_exists now checks only for the list-of-subkeys-record
Michael Adam [Fri, 1 Jul 2011 11:18:51 +0000 (13:18 +0200)]
s3:registry: regdb_key_exists now checks only for the list-of-subkeys-record

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: rewrite init_registry_key_internal
Michael Adam [Mon, 4 Jul 2011 11:19:13 +0000 (13:19 +0200)]
s3:registry: rewrite init_registry_key_internal

This rewrites init_registry_key_internal() to correctly also create
base keys. It makes use of the existing create functions instead of
duplicating the code.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: add regdb_create_basekey()
Michael Adam [Mon, 4 Jul 2011 11:14:43 +0000 (13:14 +0200)]
s3:registry: add regdb_create_basekey()

Function to create a base key in the registry db, i.e. one that
has no parent key.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: add regdb_create_subkey_internal() taking additional db context argument
Michael Adam [Mon, 4 Jul 2011 11:09:31 +0000 (13:09 +0200)]
s3:registry: add regdb_create_subkey_internal() taking additional db context argument

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: add new mode to regdb_store_subkey_list() for handing in NULL parent key
Michael Adam [Mon, 4 Jul 2011 11:06:20 +0000 (13:06 +0200)]
s3:registry: add new mode to regdb_store_subkey_list() for handing in NULL parent key

Standard behaviour is to concatenate parent and key path (parent\key).
This new mode allows for storing subkey lists for base keys using a NULL
parent argument.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: create the empty list of subkeys of the new key in regdb_create_subkey
Michael Adam [Fri, 1 Jul 2011 13:50:05 +0000 (15:50 +0200)]
s3:registry: create the empty list of subkeys of the new key in regdb_create_subkey

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: refactor creation of subkey list out into regdb_store_subkey_list()
Michael Adam [Fri, 1 Jul 2011 13:47:50 +0000 (15:47 +0200)]
s3:registry: refactor creation of subkey list out into regdb_store_subkey_list()

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: remove redundant write of zero-lentgh subkey list record
Michael Adam [Fri, 1 Jul 2011 13:18:12 +0000 (15:18 +0200)]
s3:registry: remove redundant write of zero-lentgh subkey list record

In this case, the zero-lenght list has already been written in step #2.

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: don't update the sorted subkeys cache any more in regdb_store_keys_inter...
Michael Adam [Fri, 1 Jul 2011 12:34:08 +0000 (14:34 +0200)]
s3:registry: don't update the sorted subkeys cache any more in regdb_store_keys_internal2()

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: don't skip base key in existence check in regdb_store_keys_internal()
Michael Adam [Fri, 1 Jul 2011 12:23:19 +0000 (14:23 +0200)]
s3:registry: don't skip base key in existence check in regdb_store_keys_internal()

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: don't skip base keys from existence check in regdb_create_subkey()
Michael Adam [Fri, 1 Jul 2011 11:58:45 +0000 (13:58 +0200)]
s3:registry: don't skip base keys from existence check in regdb_create_subkey()

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agos3:registry: don't skip base keys from existence check in regdb_delete_subkey()
Michael Adam [Fri, 1 Jul 2011 11:57:19 +0000 (13:57 +0200)]
s3:registry: don't skip base keys from existence check in regdb_delete_subkey()

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

12 years agoselftest: remove invalid use of the globbing operator <>
Michael Adam [Mon, 4 Jul 2011 15:01:29 +0000 (17:01 +0200)]
selftest: remove invalid use of the globbing operator <>

12 years agoselftest: eliminate perl warnings (my $cmd masks earlier definition...)
Michael Adam [Mon, 4 Jul 2011 08:28:43 +0000 (10:28 +0200)]
selftest: eliminate perl warnings (my $cmd masks earlier definition...)

12 years agoselftest: eliminate a perl warning
Michael Adam [Mon, 4 Jul 2011 08:24:19 +0000 (10:24 +0200)]
selftest: eliminate a perl warning

In perl, %binary_mapping should be initialized as a hash, not a hash reference.

12 years agos3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)
Christian Ambach [Mon, 4 Jul 2011 15:55:54 +0000 (17:55 +0200)]
s3:smb2 fix smbd crash on premature end of smb2 conn (Bug 8286)

when smbd tries to clean up locks after a premature end of a smb2
connection, lock_db has already been freed and so it crashes

this patch changes the order in which items are freed so that
lock_db is still around when it is needed

Jeremy, Metze, please check

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Mon Jul  4 20:00:26 CEST 2011 on sn-devel-104

12 years agos3: Fix an enum/int mixup
Volker Lendecke [Mon, 4 Jul 2011 14:27:23 +0000 (16:27 +0200)]
s3: Fix an enum/int mixup

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jul  4 18:47:59 CEST 2011 on sn-devel-104

12 years agos3:smb2_server: there's no reason to check the session id twice on a smb2_tcon request
Stefan Metzmacher [Mon, 4 Jul 2011 13:57:20 +0000 (15:57 +0200)]
s3:smb2_server: there's no reason to check the session id twice on a smb2_tcon request

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jul  4 17:34:13 CEST 2011 on sn-devel-104

12 years agos3:smb2_create: call 'return' after smbd_server_connection_terminate()
Stefan Metzmacher [Mon, 4 Jul 2011 13:50:56 +0000 (15:50 +0200)]
s3:smb2_create: call 'return' after smbd_server_connection_terminate()

This is not strictly needed in the fork process model, but we hopefully
support other models in future.

metze

12 years agos3-build add tevent depencency on libsmb
Andrew Bartlett [Mon, 4 Jul 2011 12:08:37 +0000 (22:08 +1000)]
s3-build add tevent depencency on libsmb

This may assist the build on FreeBSD 8.2

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jul  4 16:19:10 CEST 2011 on sn-devel-104

12 years agos3-printing: open up a winreg pipe handle for the migration code.
Günther Deschner [Fri, 1 Jul 2011 13:39:11 +0000 (15:39 +0200)]
s3-printing: open up a winreg pipe handle for the migration code.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jul  4 15:06:41 CEST 2011 on sn-devel-104

12 years agos3-build link passdb modules against libpassdb
Andrew Bartlett [Mon, 4 Jul 2011 09:07:40 +0000 (19:07 +1000)]
s3-build link passdb modules against libpassdb

This ensures that they don't include a duplicate copy of
pdb_interface.c functions, because they will instead link the library.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Jul  4 12:24:50 CEST 2011 on sn-devel-104

12 years agos3-build allow_undefined_symbols=False is the default now
Andrew Bartlett [Mon, 4 Jul 2011 09:03:52 +0000 (19:03 +1000)]
s3-build allow_undefined_symbols=False is the default now

12 years agos3-auth libauth no longer requires undefined symbols
Andrew Bartlett [Mon, 4 Jul 2011 08:30:25 +0000 (18:30 +1000)]
s3-auth libauth no longer requires undefined symbols

12 years agos3-lib Move event_add_idle() to source3/lib/events.c
Andrew Bartlett [Mon, 4 Jul 2011 08:52:47 +0000 (18:52 +1000)]
s3-lib Move event_add_idle() to source3/lib/events.c

This allows libauth not to depend on smbd_base.

Andrew Bartlett

12 years agos3-samr Send IP address only to PAM remote hostname hook on password set
Andrew Bartlett [Mon, 4 Jul 2011 08:09:38 +0000 (18:09 +1000)]
s3-samr Send IP address only to PAM remote hostname hook on password set

The previous behaviour was to attempt to do a reverse hostname lookup,
where enabled.  This new behaviour matches the new behaviour in the
modules called by auth stack.

Andrew Bartlett

12 years agos3: RIP 'struct client_address'.
Andreas Schneider [Thu, 16 Jun 2011 14:13:01 +0000 (16:13 +0200)]
s3: RIP 'struct client_address'.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-rpc_server: Remove client_id and server_id from pipes struct.
Andreas Schneider [Thu, 16 Jun 2011 14:12:07 +0000 (16:12 +0200)]
s3-rpc_server: Remove client_id and server_id from pipes struct.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-smbd: Remove client_address from smbd_server_connection struct.
Andreas Schneider [Thu, 16 Jun 2011 14:09:07 +0000 (16:09 +0200)]
s3-smbd: Remove client_address from smbd_server_connection struct.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-smbd: Remove obsolete smbd_set_server_fd().
Andreas Schneider [Thu, 16 Jun 2011 14:08:09 +0000 (16:08 +0200)]
s3-smbd: Remove obsolete smbd_set_server_fd().

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-vfs: Replace client_id in exand msdfs.
Andreas Schneider [Thu, 16 Jun 2011 12:23:54 +0000 (14:23 +0200)]
s3-vfs: Replace client_id in exand msdfs.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
12 years agos3-vfs: Replace client_id in smbta.
Andreas Schneider [Thu, 16 Jun 2011 12:20:21 +0000 (14:20 +0200)]
s3-vfs: Replace client_id in smbta.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>