samba.git
13 years agobuild-docs: Change to the right directory before calling 'make clean'.
Karolin Seeger [Tue, 9 Dec 2008 21:08:13 +0000 (22:08 +0100)]
build-docs: Change to the right directory before calling 'make clean'.
This fixes build-docs if it's called from the create-tarball script.

Karolin

13 years agobuild-docs: Use 'git clean' instead of 'git-clean'.
Karolin Seeger [Wed, 19 Nov 2008 12:16:38 +0000 (13:16 +0100)]
build-docs: Use 'git clean' instead of 'git-clean'.

Karolin
(cherry picked from commit 12e72140b944f844e7f44f21a087ab4a4ecc51a7)

13 years agoWHATSNEW: Update changes.
Karolin Seeger [Tue, 9 Dec 2008 16:39:03 +0000 (17:39 +0100)]
WHATSNEW: Update changes.

Karolin

13 years agoWHATSNEW: Fix entry.
Karolin Seeger [Tue, 9 Dec 2008 16:35:49 +0000 (17:35 +0100)]
WHATSNEW: Fix entry.

Karolin

13 years agos3-ldapsam: Fix Bug 5957: do not abort rename process on valid rename script.
Günther Deschner [Tue, 9 Dec 2008 16:28:15 +0000 (17:28 +0100)]
s3-ldapsam: Fix Bug 5957: do not abort rename process on valid rename script.

Guenther

13 years agoVERSION: Raise version number up to 3.2.6.
Karolin Seeger [Tue, 9 Dec 2008 16:18:35 +0000 (17:18 +0100)]
VERSION: Raise version number up to 3.2.6.

Karolin

13 years agoWHATSNEW: Update changes for 3.2.6.
Karolin Seeger [Tue, 9 Dec 2008 16:17:50 +0000 (17:17 +0100)]
WHATSNEW: Update changes for 3.2.6.

Karolin

13 years agoWHATSNEW: Update WHATSNEW for 3.2.5.
Karolin Seeger [Tue, 18 Nov 2008 15:17:17 +0000 (16:17 +0100)]
WHATSNEW: Update WHATSNEW for 3.2.5.

Karolin

13 years agoFix bug #5953 - smbclient crashes: cli_list_new segmentation fault.
Jeremy Allison [Mon, 8 Dec 2008 22:02:59 +0000 (14:02 -0800)]
Fix bug #5953 - smbclient crashes: cli_list_new segmentation fault.
Karolin: must be in 3.2-stable. Thanks,
Jeremy.

13 years agoFix logging to syslog
Dan Sledz [Sat, 6 Dec 2008 01:29:38 +0000 (17:29 -0800)]
Fix logging to syslog

13 years agoFix bug #5928 - Option --version in testparm does not work.
Tomasz Krasuski [Sat, 6 Dec 2008 00:30:55 +0000 (16:30 -0800)]
Fix bug #5928 - Option --version in testparm does not work.

13 years agoFix bug #5944 - nmbd does not boot if socket adress = "" is defined in smb.conf
Yasuma Takeda [Fri, 5 Dec 2008 21:38:06 +0000 (13:38 -0800)]
Fix bug #5944 - nmbd does not boot if socket adress = "" is defined in smb.conf

13 years agoFix for crash bug freeing a non-malloc'ed buffer if the client sends a non-encrypted...
Volker Lendecke [Fri, 5 Dec 2008 21:21:19 +0000 (13:21 -0800)]
Fix for crash bug freeing a non-malloc'ed buffer if the client sends a non-encrypted packet with the crypto state set.

13 years agoFix bug #5937 - filenames with "*" char hide other files
Jeremy Allison [Thu, 4 Dec 2008 23:33:27 +0000 (15:33 -0800)]
Fix bug #5937 - filenames with "*" char hide other files
Jeremy.

13 years agoFix bug #5929 - vfs_prealloc does not build with option --with-cluster-support and...
Henning Henkel [Thu, 4 Dec 2008 21:43:59 +0000 (13:43 -0800)]
Fix bug #5929 - vfs_prealloc does not build with option --with-cluster-support and GPFS

13 years agoFix bug #1254 - write list not working under share-level security
Jeremy Allison [Thu, 4 Dec 2008 18:23:06 +0000 (10:23 -0800)]
Fix bug #1254 - write list not working under share-level security
Jeremy.

13 years agowinbindd: fix more horrible brace mis-indentations in winbindd_group
Michael Adam [Thu, 4 Dec 2008 14:01:46 +0000 (15:01 +0100)]
winbindd: fix more horrible brace mis-indentations in winbindd_group

Sorry, but I can't bear this.

And while my vim is smart enough to cope with this,
it confuses _me_, and I have seen an emacs confused as well.
(Which comes as no surprise, almost human as it is...)

Michael

13 years agowinbindd: fix more misindentations of top level braces in winbindd_group
Michael Adam [Thu, 4 Dec 2008 13:30:52 +0000 (14:30 +0100)]
winbindd: fix more misindentations of top level braces in winbindd_group

Michael

13 years agowinbindd: fix horrible mis-indentation of toplvl braces in getgrsid_sid2gid_recv
Michael Adam [Thu, 4 Dec 2008 13:29:01 +0000 (14:29 +0100)]
winbindd: fix horrible mis-indentation of toplvl braces in getgrsid_sid2gid_recv

to make code more readable

Michael

13 years agowinbindd: don't open a new dc connection in winbindd_getpwnam (main winbindd)
Michael Adam [Wed, 3 Dec 2008 15:38:55 +0000 (16:38 +0100)]
winbindd: don't open a new dc connection in winbindd_getpwnam (main winbindd)

This is just to find the corresponding domain struct.
Actual connection is handled by the domain child.

Michael

13 years agowinbindd: don't open a new dc connection in winbindd_getgrnam (main winbindd)
Michael Adam [Wed, 3 Dec 2008 14:59:17 +0000 (15:59 +0100)]
winbindd: don't open a new dc connection in winbindd_getgrnam (main winbindd)

This is just to find the corresponding domain struct.
Actual connection is handled by the domain child.

Michael

13 years agos3:net: fix password set of 'net rpc trustdom add'
Stefan Metzmacher [Thu, 4 Dec 2008 11:26:03 +0000 (12:26 +0100)]
s3:net: fix password set of 'net rpc trustdom add'

metze
(cherry-picked from commit 2b8f3e253d3a56aac996287f5ce265d0c915b3c8)
(cherry picked from commit e1e76f19cf9c72abe4086965846b2d438cfbdd00)

13 years agoChange sockaddr util function names for consistency and to eliminate name conflicts
Tim Prouty [Wed, 3 Dec 2008 18:37:03 +0000 (10:37 -0800)]
Change sockaddr util function names for consistency and to eliminate name conflicts

13 years agolibwbclient: avoid usage talloc_init() in library code
Stefan Metzmacher [Wed, 3 Dec 2008 08:07:00 +0000 (09:07 +0100)]
libwbclient: avoid usage talloc_init() in library code

talloc_init() is a compat function for the old samba3
non-hierachical talloc implementation. It enables
the talloc null tracking which should never be done
by library code.

metze
(cherry picked from commit afa0d6b0b14e0ef2293bd8468ffc1d6330abdb5b)
(cherry picked from commit 37a92ed0eb2c8cf7f3eac1d90ba5300cbce45186)

13 years agodocs: Add default value for "writeable" to man smb.conf.
Karolin Seeger [Tue, 2 Dec 2008 19:50:02 +0000 (20:50 +0100)]
docs: Add default value for "writeable" to man smb.conf.

Karolin
(cherry picked from commit c09e04ac83365333605b7b1db3d07ccfd451a667)
(cherry picked from commit 70c581586ea02fbff4c5dde0ec002b22d472dfc5)

13 years agos3:selftest: test the streams_depot module as it passes make test
Stefan Metzmacher [Mon, 1 Dec 2008 22:36:57 +0000 (14:36 -0800)]
s3:selftest: test the streams_depot module as it passes make test

The streams_xattr module only passes sometimes on my laptop.

metze

13 years agos3:smbd: close the low level fd of the base_fsp, if the file was created
Stefan Metzmacher [Mon, 1 Dec 2008 22:28:13 +0000 (14:28 -0800)]
s3:smbd: close the low level fd of the base_fsp, if the file was created

metze

13 years agos3:streams_xattr: fstat should do a stat on the base file
Stefan Metzmacher [Mon, 1 Dec 2008 22:26:36 +0000 (14:26 -0800)]
s3:streams_xattr: fstat should do a stat on the base file

The behavior of stat and fstat should be the same.

metze

13 years agos3:streams_xattr: recheck fsp->fsp_name after a rename
Stefan Metzmacher [Mon, 1 Dec 2008 22:25:04 +0000 (14:25 -0800)]
s3:streams_xattr: recheck fsp->fsp_name after a rename

metze

13 years agos3:smbd: give the correct error when trying to replace a stream
Stefan Metzmacher [Mon, 1 Dec 2008 22:23:16 +0000 (14:23 -0800)]
s3:smbd: give the correct error when trying to replace a stream

metze

13 years agos3:vfs: fix FCHMOD_ACL macros
Stefan Metzmacher [Mon, 1 Dec 2008 22:21:43 +0000 (14:21 -0800)]
s3:vfs: fix FCHMOD_ACL macros

metze

13 years agos3:streams_depot: add an option to disable the xattr checks
Stefan Metzmacher [Mon, 1 Dec 2008 22:19:55 +0000 (14:19 -0800)]
s3:streams_depot: add an option to disable the xattr checks

streams_depot:check_valid=no is useful when the filesystem
has no xattr support and files are only published via samba.

metze

13 years agos3:streams_depot: fix valgrind bug lp_parm_const_string() doesn't talloc the default...
Stefan Metzmacher [Mon, 1 Dec 2008 22:11:17 +0000 (14:11 -0800)]
s3:streams_depot: fix valgrind bug lp_parm_const_string() doesn't talloc the default value

metze

13 years agos3:streams_depot: add support for stream renames
Stefan Metzmacher [Mon, 1 Dec 2008 22:09:45 +0000 (14:09 -0800)]
s3:streams_depot: add support for stream renames

metze

13 years agos3:streams_depot: map 'file::$DATA' to just 'file'
Stefan Metzmacher [Mon, 1 Dec 2008 21:58:14 +0000 (13:58 -0800)]
s3:streams_depot: map 'file::$DATA' to just 'file'

metze

13 years agos3:streams_xattr: add support for renaming streams
Stefan Metzmacher [Mon, 1 Dec 2008 21:54:19 +0000 (13:54 -0800)]
s3:streams_xattr: add support for renaming streams

metze

13 years agos3:smbd: only try and fallback to open a directory if it's not a stream open
Stefan Metzmacher [Mon, 1 Dec 2008 21:51:59 +0000 (13:51 -0800)]
s3:smbd: only try and fallback to open a directory if it's not a stream open

metze

13 years agos3:smbd: write times should be set on the base file instead of the stream name
Stefan Metzmacher [Mon, 1 Dec 2008 21:44:43 +0000 (13:44 -0800)]
s3:smbd: write times should be set on the base file instead of the stream name

metze

13 years agos3:smbd: return DELETE_PENDING on path based operations on streams, when the main...
Stefan Metzmacher [Mon, 1 Dec 2008 21:34:38 +0000 (13:34 -0800)]
s3:smbd: return DELETE_PENDING on path based operations on streams, when the main file was deleted.

metze

13 years agos3:smbd: construct the correct newname for stream renames
Stefan Metzmacher [Mon, 1 Dec 2008 21:31:06 +0000 (13:31 -0800)]
s3:smbd: construct the correct newname for stream renames

The Windows Explorer creates temporary streams and renames
them later via SFILEINFO_RENAME_INFO. The newname comes
in as ":Stream:$DATA".

metze

13 years agos3:smbd: wildcard characters are allowed in stream names
Stefan Metzmacher [Mon, 1 Dec 2008 21:27:30 +0000 (13:27 -0800)]
s3:smbd: wildcard characters are allowed in stream names

We only check the filename of the basefile now.

metze

13 years agos3:smbd: correctly verify stream names to pass RAW-STREAMS
Stefan Metzmacher [Mon, 1 Dec 2008 21:20:56 +0000 (13:20 -0800)]
s3:smbd: correctly verify stream names to pass RAW-STREAMS

metze

13 years agos3:smbd: '|' isn't allowed in windows filenames
Stefan Metzmacher [Mon, 1 Dec 2008 20:59:25 +0000 (12:59 -0800)]
s3:smbd: '|' isn't allowed in windows filenames

metze

13 years agoFix a debug message, append the correct \n
Volker Lendecke [Mon, 1 Dec 2008 16:35:19 +0000 (17:35 +0100)]
Fix a debug message, append the correct \n
(cherry picked from commit 263c1ca96bd68dced4577a2504073e1140fa26a1)

13 years agovfs_tsmsm: fix potential segfault (freeing uninitialized buffer)
Michael Adam [Mon, 1 Dec 2008 05:17:43 +0000 (06:17 +0100)]
vfs_tsmsm: fix potential segfault (freeing uninitialized buffer)

Michael

13 years agoFix the offset checks in the trans routines
Volker Lendecke [Sat, 8 Nov 2008 16:14:06 +0000 (17:14 +0100)]
Fix the offset checks in the trans routines

This fixes a potential crash bug, a client can make us read memory we
should not read. Luckily I got the disp checks right...

Volker
(cherry picked from commit 64a1d80851da5b05e70ec6c96f6e9bd473748369)

13 years agoFix circular dependency error with autoconf 2.6.3.
Andreas Schneider [Wed, 26 Nov 2008 21:19:03 +0000 (13:19 -0800)]
Fix circular dependency error with autoconf 2.6.3.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
13 years agoFix bug #5914 - Build failure: redefinition of struct name_list
Jeremy Allison [Tue, 25 Nov 2008 23:55:46 +0000 (15:55 -0800)]
Fix bug #5914 - Build failure: redefinition of struct name_list
Jeremy.

13 years agos3-samr: fix _samr_LookupNames return code.
Günther Deschner [Tue, 25 Nov 2008 11:19:35 +0000 (12:19 +0100)]
s3-samr: fix _samr_LookupNames return code.

Guenther
(cherry picked from commit dc7c2d63b3ce142959aa863f000fa9140de99eb0)

13 years agozfsacl: return is not a function.
Michael Adam [Tue, 25 Nov 2008 14:23:31 +0000 (15:23 +0100)]
zfsacl: return is not a function.

Michael

13 years agozfsacl: Prevent calling POSIX ACL vfs methods on zfs share.
Nils Goroll [Mon, 17 Nov 2008 00:06:28 +0000 (01:06 +0100)]
zfsacl: Prevent calling POSIX ACL vfs methods on zfs share.

This is a proposed fix for Bugs #5135 and #5446.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years ago[PATCH] Allow SYSLOG_FACILITY to be modified with a new configure option called ...
Dan Sledz [Mon, 17 Nov 2008 01:40:03 +0000 (17:40 -0800)]
[PATCH] Allow SYSLOG_FACILITY to be modified with a new configure option called --with-syslog-facility

13 years agoFix bug #5873 - ACL inheritance cannot be broken. This regresses #4308, but that...
Jeremy Allison [Mon, 24 Nov 2008 23:29:17 +0000 (15:29 -0800)]
Fix bug #5873 - ACL inheritance cannot be broken. This regresses #4308, but that will have to
be fixed another way.
Jeremy.

13 years agoSearch for gpfs functions in both libgpfs_gpl.so an libgpfs.so
Mathias Dietz [Wed, 12 Nov 2008 13:32:45 +0000 (14:32 +0100)]
Search for gpfs functions in both libgpfs_gpl.so an libgpfs.so

As of GPFS 3.2.1 PTF8 libgpfs will be available as GPL, so we don't need the
special libgpfs_gpl lib anymore. For backwards compatibility with pre-PTF8 GPFS
installations, still look there.
(cherry picked from commit 61468186cece7370576a2d13992f9a523067e4be)

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibads/ldap.c: return an error instead of crashing when no realm is given
Stefan Metzmacher [Mon, 24 Nov 2008 14:07:56 +0000 (15:07 +0100)]
libads/ldap.c: return an error instead of crashing when no realm is given

The bug was triggered by "net ads info -S 127.8.7.6" (where 127.8.7.6 doesn't exist)
and "disable netbios = yes".

metze

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit e2a60d2e1fd7455f08e73f8d1c513ca240c0f0af)

13 years agoRevert c76e4791d3ae4f180fba209c29bd3774c00858cf - "Fix the logic bug that caused...
Jeremy Allison [Sat, 22 Nov 2008 06:44:23 +0000 (22:44 -0800)]
Revert c76e4791d3ae4f180fba209c29bd3774c00858cf - "Fix the logic bug that caused us to run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks." as it broke make test.
Jeremy.

13 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Sat, 22 Nov 2008 02:21:34 +0000 (18:21 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

13 years agoFix the logic bug that caused us to run into kernel oplocks on an open for a stream...
Jeremy Allison [Sat, 22 Nov 2008 02:19:13 +0000 (18:19 -0800)]
Fix the logic bug that caused us to run into kernel oplocks on an open for a stream inside a file with stream_xattr module. On opening the base_fsp we must break existing oplocks.
Jeremy.

13 years ago[PATCH] FreeBSD configure check for backtrace_symbols
Dan Sledz [Sat, 15 Nov 2008 02:41:17 +0000 (18:41 -0800)]
[PATCH] FreeBSD configure check for backtrace_symbols

On FreeBSD backtrace_symbols is defined in libexecinfo.so.1.  Look for it
there as well.

13 years agoUse fxattr calls whenever possible (trying to work around the strange Linux kernel...
Jeremy Allison [Sat, 22 Nov 2008 00:04:31 +0000 (16:04 -0800)]
Use fxattr calls whenever possible (trying to work around the strange Linux kernel oplock bug).
Jeremy.

13 years agowinbindd_group: don't list the domain twice when expanding internal aliases
Michael Adam [Sun, 21 Sep 2008 00:07:43 +0000 (02:07 +0200)]
winbindd_group: don't list the domain twice when expanding internal aliases

Before this, "getent group builtin\\administrators" expanded
domain group members in the form DOMAIN\domain\user.

Michael

13 years agowinbindd_group: sanely handle NULL domain in add_member().
Michael Adam [Sun, 21 Sep 2008 00:06:44 +0000 (02:06 +0200)]
winbindd_group: sanely handle NULL domain in add_member().

Michael

13 years agowinbindd_ads: honour "winbind use default domain" in lookup_groupmem().
Michael Adam [Mon, 22 Sep 2008 08:39:37 +0000 (10:39 +0200)]
winbindd_ads: honour "winbind use default domain" in lookup_groupmem().

This fixes the output of "getent group" when "winbind use default domain = yes"
with security = ads.

Michael

13 years agowinbindd_rpc: add domain prefix to username in lookup_groupmem().
Michael Adam [Sat, 20 Sep 2008 23:20:32 +0000 (01:20 +0200)]
winbindd_rpc: add domain prefix to username in lookup_groupmem().

This makes the output of "getent group" of a domain group show the
domain prefix with "security = domain".

Michael

13 years agowinbindd_util: add fill_domain_username_talloc().
Michael Adam [Mon, 22 Sep 2008 08:37:11 +0000 (10:37 +0200)]
winbindd_util: add fill_domain_username_talloc().

A talloc version of fill_domain_username().

Michael

13 years agowinbindd: fix a comment typo
Michael Adam [Mon, 22 Sep 2008 12:51:51 +0000 (14:51 +0200)]
winbindd: fix a comment typo

Michael

13 years agowinbind_util: fix an implicit cast compile warning.
Michael Adam [Mon, 22 Sep 2008 08:34:57 +0000 (10:34 +0200)]
winbind_util: fix an implicit cast compile warning.

Michael

13 years agowinbindd: make all winbind rpc-methods static.
Michael Adam [Fri, 21 Nov 2008 22:28:08 +0000 (23:28 +0100)]
winbindd: make all winbind rpc-methods static.

Now that the methods are no longer needed in winbindd_ads,
we can make them static again.

Michael

13 years agowinbindd_ads: use the reconnect methods instead of the rpc methods directly
Michael Adam [Fri, 21 Nov 2008 01:24:06 +0000 (02:24 +0100)]
winbindd_ads: use the reconnect methods instead of the rpc methods directly

Some of the ads methods just point to the rpc methods.
This makes winbindd_ads use the reconnect methods instead of
calling the rpc methods directly in order to prevent
negative cache entries for e.g. name_to_sid, when the dc
has closed the connection without sending a reset.

Michael

13 years agowinbindd_ads: prevent negative GM/ cache entries due to broken connections
Michael Adam [Thu, 20 Nov 2008 22:26:35 +0000 (23:26 +0100)]
winbindd_ads: prevent negative GM/ cache entries due to broken connections

The ads lookup_groupmem() function calls lda_lookupsids to resolve sids
to names. This is tried only once. So in case the connection was broken,
e.g. closed by the server (without a reset packet), there will be an empty
GM/ cache entry for the requested group which will prevent proper working
of access checks among other checks for the expiry period.

This patch works around this problem by retrying once if the lsa_lookupsids
call fails, re-establishing the dc-connection, as we already do in many other
places (e.g. the winbindd retry methods for the rpc layer).

Michael

13 years agoSecond part of the fix for bug #5903 - vfs_streams_xattr breaks contents of the file
Jeremy Allison [Fri, 21 Nov 2008 20:32:11 +0000 (12:32 -0800)]
Second part of the fix for bug #5903 - vfs_streams_xattr breaks contents of the file
Jeremy.

13 years agoEnsure we always reply in reply_printopen().
Jeremy Allison [Fri, 21 Nov 2008 19:06:33 +0000 (11:06 -0800)]
Ensure we always reply in reply_printopen().
Jeremy.

13 years agoFirst part of fix for bug #5903 - vfs_streams_xattr breaks contents of the file.
Jeremy Allison [Fri, 21 Nov 2008 18:46:31 +0000 (10:46 -0800)]
First part of fix for bug #5903 - vfs_streams_xattr breaks contents of the file.
Restructures parts of open code so that fsp must be allocated before calling
open_file_ntcreate(_internal). Also fix up file ref-counting inside files.c.
Jeremy.

13 years agoFix bug #5909 - MS-DFS does not work on Vista, if link name includes multibyte character.
Yasuma Takeda [Thu, 20 Nov 2008 19:36:51 +0000 (11:36 -0800)]
Fix bug #5909 - MS-DFS does not work on Vista, if link name includes multibyte character.

13 years agoSecond part of fix for bug #5891 - smbd crashed when viewing the eventlog exported...
Jeremy Allison [Thu, 20 Nov 2008 18:55:23 +0000 (10:55 -0800)]
Second part of fix for bug #5891 - smbd crashed when viewing the eventlog exported by "eventlog list". Don't leak memory on error paths.
Jeremy.

13 years agoeventlog: don't crash in sync_eventlog_params().
Michael Adam [Thu, 20 Nov 2008 15:31:44 +0000 (16:31 +0100)]
eventlog: don't crash in sync_eventlog_params().

When freeing the talloc ctx at the end of the routine,
it must be a talloc ctx created inside. talloc_tos() needs
to be valid after the function finishes, since callers
(may) have data attached to it.

Michael

Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit 113c5d28edabdd17a2507e68aad612aa21c758f3)

13 years agoThis code mixes up int and uint32 when pulling out of a TDB. This is very bad. Fixing...
Jeremy Allison [Thu, 20 Nov 2008 00:48:53 +0000 (16:48 -0800)]
This code mixes up int and uint32 when pulling out of a TDB. This is very bad. Fixing... May fix bug #5891, not sure.
Jeremy.

13 years agoFix error in commit for bugfix "Fix bug #5904 - libnss_wins causes SIGABRT while...
Jeremy Allison [Wed, 19 Nov 2008 19:31:05 +0000 (11:31 -0800)]
Fix error in commit for bugfix "Fix bug #5904 - libnss_wins causes SIGABRT while servicing getaddrinfo() request."
Jeremy.

13 years agoFix bug #5904 - libnss_wins causes SIGABRT while servicing getaddrinfo() request.
Jeremy Allison [Wed, 19 Nov 2008 19:23:11 +0000 (11:23 -0800)]
Fix bug #5904 - libnss_wins causes SIGABRT while servicing getaddrinfo() request.
Jeremy.

13 years agoFix extended DN parse error when AD object does not have a SID.
Steven Danneman [Sat, 15 Nov 2008 21:07:15 +0000 (13:07 -0800)]
Fix extended DN parse error when AD object does not have a SID.

Some AD objects, like Exchange Public Folders, can be members of Security
Groups but do not have a SID attribute.  This patch adds more granular return
errors to ads_get_sid_from_extended_dn().  Callers can now determine if a parse
error occured because of bad input, or the DN was valid but contained no SID.

I updated all callers to ignore SIDless objects when appropriate.

Also did some cleanup to the out paths of lookup_usergroups_memberof()

13 years agoWhitespace and >80 column cleanups.
Steven Danneman [Sat, 15 Nov 2008 03:16:12 +0000 (19:16 -0800)]
Whitespace and >80 column cleanups.

13 years agoFix Bug #5898. ("net rpc shutdown" fails).
Günther Deschner [Tue, 18 Nov 2008 22:10:22 +0000 (23:10 +0100)]
Fix Bug #5898. ("net rpc shutdown" fails).

Guenther

13 years agoFix bug #5908 - Samba 3.0.32 - internal change notify on share directory fails"
Dina Fine [Tue, 18 Nov 2008 20:44:19 +0000 (12:44 -0800)]
Fix bug #5908 - Samba 3.0.32 - internal change notify on share directory fails"

13 years agolibsmb: Fix up pointer passed to cli_send_trans in cli_link_internal
Kai Blin [Tue, 18 Nov 2008 15:31:34 +0000 (16:31 +0100)]
libsmb: Fix up pointer passed to cli_send_trans in cli_link_internal

Seems like this one fell victim to the pstring removal. The other callers seem
to be fine, even though removing the casts would make the code less confusing.

13 years agoRe-structure Volker's patch to "Fix trans2findfirst for the large directory optimizat...
Jeremy Allison [Tue, 18 Nov 2008 18:58:48 +0000 (10:58 -0800)]
Re-structure Volker's patch to "Fix trans2findfirst for the large directory optimization". Makes the change clearer.
Jeremy.

13 years agoFix trans2findfirst for the large directory optimization
Volker Lendecke [Tue, 18 Nov 2008 16:03:38 +0000 (17:03 +0100)]
Fix trans2findfirst for the large directory optimization

With

case sensitive = yes
preserve case = no
short preserve case = no
default case = upper

a "dir FOO.txt" would not find "FOO.TXT" because FOO.txt ends up unconverted in
the mask for mask_match.

Jeremy, please check!

Volker
(cherry picked from commit 0dbcc308e30b121268cdfcdd70c50c4ed38ab433)

13 years agoFix bug #5906 when running winbindd on a Samba PDC. Winbindd crash on 'getent group'.
Davide Sfriso [Mon, 17 Nov 2008 23:40:43 +0000 (15:40 -0800)]
Fix bug #5906 when running winbindd on a Samba PDC. Winbindd crash on 'getent group'.

13 years agoWhen clearing out vuid cache remember to set entries = 0.
Jeremy Allison [Mon, 17 Nov 2008 22:05:55 +0000 (14:05 -0800)]
When clearing out vuid cache remember to set entries = 0.
Jeremy.

13 years agoFix bug #5900 reported by monyo@samba.gr.jp - vfs_readonly.so does not work.
Jeremy Allison [Mon, 17 Nov 2008 21:46:35 +0000 (13:46 -0800)]
Fix bug #5900 reported by monyo@samba.gr.jp - vfs_readonly.so does not work.
Jeremy.

13 years agos3 create-tarball.sh: Remove dashes in git commands.
Karolin Seeger [Mon, 17 Nov 2008 14:23:34 +0000 (15:23 +0100)]
s3 create-tarball.sh: Remove dashes in git commands.

Newer git versions (e.g. 1.6.0.2) do not provide the 'git-' commands
any longer.

Karolin
(cherry picked from commit 0cba859f12177aaf3ef2d96663f0a51f61c24d56)
(cherry picked from commit 3d64e67de2b50f7b781aa3f5ad13ec8e866d4333)
(cherry picked from commit aa41a80969bd413d5922c602c7309bd8c05f3181)

13 years agonet: Fix documentation of net rap printq info
Carsten Dumke [Thu, 13 Nov 2008 18:05:00 +0000 (12:05 -0600)]
net: Fix documentation of net rap printq info

The man-page (see net(8)) and the usage-info (call "net help rap printq") of
'net rap printq' do contain an option "list" but in net_rap.c
the option is named "info".

Rename the option "list" in the documentation (man-pages + usage) to "info" to
match the code.

Signed-off-by: Kai Blin <kai@samba.org>
13 years agoFix bug 5901: Default for streams_depot location
TAKAHASHI Motonobu [Sun, 16 Nov 2008 12:17:16 +0000 (13:17 +0100)]
Fix bug 5901: Default for streams_depot location

13 years agofix build warning.
Günther Deschner [Tue, 15 Jul 2008 21:05:13 +0000 (23:05 +0200)]
fix build warning.

Guenther
(This used to be commit 507660706901a79544d436046127947e4baa7e52)
(cherry picked from commit 1939177582867fb54a416f3ea979ebd8d4335885)

13 years agoMake memcache_add_talloc NULL out the source pointer
Volker Lendecke [Fri, 14 Nov 2008 12:42:54 +0000 (13:42 +0100)]
Make memcache_add_talloc NULL out the source pointer

This is an orthogonality measure to make clear this pointer now belongs to the
cache.

13 years agoActually finish memcache_add_talloc
Volker Lendecke [Thu, 13 Nov 2008 22:50:19 +0000 (23:50 +0100)]
Actually finish memcache_add_talloc

This fixes a memleak found by Martin Zielinski <mz@seh.de>. Thanks for
looking closely!

Volker

13 years agoUse the correct cups-devel test for HAVE_IPRINT also
Volker Lendecke [Sat, 14 Jun 2008 08:59:11 +0000 (10:59 +0200)]
Use the correct cups-devel test for HAVE_IPRINT also
(cherry picked from commit a42d7e1146e7469062ead2c8f22f549a48154e03)

13 years agoCorrectly check for presence of cups-devel
Volker Lendecke [Sat, 14 Jun 2008 08:31:11 +0000 (10:31 +0200)]
Correctly check for presence of cups-devel

On SuSE at least cups-config belongs to cups-libs which does not contain the
headers which are in cups-devel.
(cherry picked from commit 2408d2493f7c6e0beee58febd547516bbeb0929d)

13 years agowinbind: fix build warning.
Günther Deschner [Fri, 14 Nov 2008 18:49:11 +0000 (19:49 +0100)]
winbind: fix build warning.

Guenther

13 years agomake some more parts of security.idl public and re-run make idl.
Günther Deschner [Fri, 14 Nov 2008 16:53:29 +0000 (17:53 +0100)]
make some more parts of security.idl public and re-run make idl.

Guenther

13 years agore-run make idl.
Günther Deschner [Fri, 14 Nov 2008 15:12:34 +0000 (16:12 +0100)]
re-run make idl.

Guenther
(cherry picked from commit 19568f4e4e94266a7792e6dce8eaa5086f435fc3)