12 years agor11854: Remove unused DOM_SID.
Günther Deschner [Tue, 22 Nov 2005 14:13:56 +0000 (14:13 +0000)]
r11854: Remove unused DOM_SID.

(This used to be commit 8609484ff65aaf075d2f768960246dad398855a4)

12 years agor11853: Add Dsr_GetSiteName (handy for experimenting with GPOs).
Günther Deschner [Tue, 22 Nov 2005 14:10:49 +0000 (14:10 +0000)]
r11853: Add Dsr_GetSiteName (handy for experimenting with GPOs).

(This used to be commit c54430a7b5e40d3bdf8afdc813eb722c0a3b861e)

12 years agor11852: Fill in samr_get_dom_pwinfo based on Samba4.
Günther Deschner [Tue, 22 Nov 2005 13:58:51 +0000 (13:58 +0000)]
r11852: Fill in samr_get_dom_pwinfo based on Samba4.

(This used to be commit a8bc4bc902075cfd009dc92674c4560a44a74277)

12 years agor11851: Display correct error string.
Günther Deschner [Tue, 22 Nov 2005 13:33:44 +0000 (13:33 +0000)]
r11851: Display correct error string.

(This used to be commit 4d681f560e59dd483f580c5fe5299af6242ae7c2)

12 years agor11847: Fix typo.
Günther Deschner [Tue, 22 Nov 2005 12:45:53 +0000 (12:45 +0000)]
r11847: Fix typo.

(This used to be commit 6aefb3aebbbba486ea44ec9ef7bc46e0776eeba8)

12 years agor11846: Destroy the TALLOC_CTX on error in the Kerberos session setup and give a
Günther Deschner [Tue, 22 Nov 2005 10:22:59 +0000 (10:22 +0000)]
r11846: Destroy the TALLOC_CTX on error in the Kerberos session setup and give a
more precise inline comment why PAC verification may fail.

(This used to be commit 43b57715e9b44a0a0c7cc7fe3674a5fd4369e78b)

12 years agor11845: Removed error code list as it isn't correct for Linux.
Jeremy Allison [Tue, 22 Nov 2005 06:07:26 +0000 (06:07 +0000)]
r11845: Removed error code list as it isn't correct for Linux.
(This used to be commit bea6fa293e2c1ee85ae72dcee00db13cb1fe5bb1)

12 years agor11841: Fix #3262 from Timur Bakeyev to improve reporting on FreeBSD DOS
Jeremy Allison [Tue, 22 Nov 2005 06:04:00 +0000 (06:04 +0000)]
r11841: Fix #3262 from Timur Bakeyev to improve reporting on FreeBSD DOS
attribute errors.
(This used to be commit 8f2e472fa35098b1be16083ce9b5c06fdf5dbcd1)

12 years agor11839: Info level 0x101 is really a protocol NT level.
Jeremy Allison [Tue, 22 Nov 2005 05:21:26 +0000 (05:21 +0000)]
r11839: Info level 0x101 is really a protocol NT level.
Fix bug #3274 from Guenter Kukkukk <>
(This used to be commit e4b3b70ef1c0fea3252b73c55ea3e9cad7229afd)

12 years agor11833: fix build issues in smbget with the Sun compiler. Reported by Richard Bollinger
Gerald Carter [Mon, 21 Nov 2005 15:52:10 +0000 (15:52 +0000)]
r11833: fix build issues in smbget with the Sun compiler. Reported by Richard Bollinger
(This used to be commit d381c125b0ffc269fd8671a855c9b899966a2320)

12 years agor11830: patch from Rashid N. Achilov <> to add descriptions for...
Gerald Carter [Mon, 21 Nov 2005 13:00:36 +0000 (13:00 +0000)]
r11830: patch from Rashid N. Achilov <> to add descriptions for some common services
(This used to be commit 69e168197e576bac6d4b29bdca876243eb7caf68)

12 years agor11799: Added OpenSSH fix for "%.*s" format crash. From Darren Tucker
Jeremy Allison [Sat, 19 Nov 2005 01:14:05 +0000 (01:14 +0000)]
r11799: Added OpenSSH fix for "%.*s" format crash. From Darren Tucker
(This used to be commit b7dee71f26b26e2aed4124c7de52fa6771ce40dd)

12 years agor11793: Fix the SAMR cache so it works across completely insane
Jeremy Allison [Fri, 18 Nov 2005 23:15:47 +0000 (23:15 +0000)]
r11793: Fix the SAMR cache so it works across completely insane
client behaviour (ie.:
open pipe/open SAMR handle/enumerate 0 - 1024
close SAMR handle, close pipe.
open pipe/open SAMR handle/enumerate 1024 - 2048...
close SAMR handle, close pipe.
And on ad-nausium. Amazing.... probably object-oriented
client side programming in action yet again.
This change should *massively* improve performance when
enumerating users from an LDAP database.
(This used to be commit 8ce705d9cc1b6a79d710a10ff38f72a0f1006dda)

12 years agor11790: Avoid infinite retry to gather a connection.
Günther Deschner [Fri, 18 Nov 2005 14:33:12 +0000 (14:33 +0000)]
r11790: Avoid infinite retry to gather a connection.

(This used to be commit 7b6195b421b6c572d82d00b9a11bcf8579456c21)

12 years agor11784: Fix minor glitch found by Rainer Weikusat <> --...
Volker Lendecke [Fri, 18 Nov 2005 13:02:19 +0000 (13:02 +0000)]
r11784: Fix minor glitch found by Rainer Weikusat <> -- Thanks
(This used to be commit 1128d054dd8d387e529bf92dad3a3db5e251d61d)

12 years agor11770: BUG 2718: don't use qpathinfo_basic() call when remote server is Win9x or...
Gerald Carter [Fri, 18 Nov 2005 03:18:54 +0000 (03:18 +0000)]
r11770: BUG 2718: don't use qpathinfo_basic() call when remote server is Win9x or the do_cd() call will fail
(This used to be commit be31c2a105ae2b6e655530190c939caae1b41294)

12 years agor11769: Looking at a performance problem enumerating accounts, wondered
Jeremy Allison [Thu, 17 Nov 2005 22:40:10 +0000 (22:40 +0000)]
r11769: Looking at a performance problem enumerating accounts, wondered
if changing to support samr_connect5 might help so quickly coded
it up. No it doesn't :-(. Don't merge this for 3.0.21 please.
(This used to be commit bff1df678a8948d382f4555e83a1df23146a4b12)

12 years agor11767: Doesn't need to be exported.
Jeremy Allison [Thu, 17 Nov 2005 22:39:00 +0000 (22:39 +0000)]
r11767: Doesn't need to be exported.
(This used to be commit 52b6f0db2e4a209641187255bd8815c8d03a5315)

12 years agor11764: Doesn't need to be exported from here.
Jeremy Allison [Thu, 17 Nov 2005 21:57:38 +0000 (21:57 +0000)]
r11764: Doesn't need to be exported from here.
(This used to be commit 95665dfd77ac9959d1d538770157127a425b4b4e)

12 years agor11763: fix more build breakage
Gerald Carter [Thu, 17 Nov 2005 21:07:24 +0000 (21:07 +0000)]
r11763: fix more build breakage
(This used to be commit 5ab76ec8f88da6d6f372b44b7533ca2cb6c2ba0b)

12 years agor11762: fix my build breakage
Gerald Carter [Thu, 17 Nov 2005 21:03:22 +0000 (21:03 +0000)]
r11762: fix my build breakage
(This used to be commit 9ee851630ec3443f27a61de6eaf222c74d2d064a)

12 years agor11761: * fix clearing of event logs by truncating the tdb.
Gerald Carter [Thu, 17 Nov 2005 20:08:59 +0000 (20:08 +0000)]
r11761: * fix clearing of event logs by truncating the tdb.
  This feature got broken in some of the other updates.
  Now each open handle stores an pointer to an open tdb
  data structure (not the tdb pointer itself).
  Clearing can be done with a simple elog_close_tdb( elog, True )
  to force a close and then calling elog_open_tdb( logname, True )
  to force an tdb truncate.  Permissions on existing tdbs are
  maintained which is important.

* We don't currently handle backup.  Haven't looked at the
  format of a backuped up eventlog to know what the deal is.
(This used to be commit 2df34c9403446d12f1ceeac38cbda5d3ba805b02)

12 years agor11760: fix sequential reads in the eventlog; event viewer is behaving better now...
Gerald Carter [Thu, 17 Nov 2005 17:41:02 +0000 (17:41 +0000)]
r11760: fix sequential reads in the eventlog; event viewer is behaving better now as well but needs more testing
(This used to be commit ba2f94aeae1f8e69d53fc360785adf222a8c9c6e)

12 years agor11739: As per Jeremy's request, add a panic action for developers. Now
Volker Lendecke [Wed, 16 Nov 2005 06:54:39 +0000 (06:54 +0000)]
r11739: As per Jeremy's request, add a panic action for developers. Now
needs something along the lines of

if [ $LOGNAME == "jht" ]

But that goes a bit far I think.... :-)))

(This used to be commit 99d76042e962405fcaeb974a55db563207e0f92a)

12 years agor11734: Remove unused variable
Volker Lendecke [Tue, 15 Nov 2005 20:15:46 +0000 (20:15 +0000)]
r11734: Remove unused variable
(This used to be commit 5b882acafbacce6246b8f729eb8e347039ee16bd)

12 years agor11732: Remember to return early if -1 returned from *BSD EA call.
Jeremy Allison [Tue, 15 Nov 2005 18:54:33 +0000 (18:54 +0000)]
r11732: Remember to return early if -1 returned from *BSD EA call.
Pointed out by
(This used to be commit 081e458801b626d6f9e58ba16a25c1b99b83eb55)

12 years agor11729: Remove space from DYNEXP flags declaration for HPUX. Fixes bugzilla
Tim Potter [Mon, 14 Nov 2005 23:09:46 +0000 (23:09 +0000)]
r11729: Remove space from DYNEXP flags declaration for HPUX.  Fixes bugzilla
(This used to be commit 78ddbb1dd4fd90ef5e3aee1fe42fdc0e3105c800)

12 years agor11728: Ensure to check for the config.log in ${SRCDIR}.
Lars Müller [Mon, 14 Nov 2005 21:18:09 +0000 (21:18 +0000)]
r11728: Ensure to check for the config.log in ${SRCDIR}.

Revert jerry's revert from 11685. :)

At the moment I don't see a way to check if there is an empty
${SMBWRAPPER} or none.  If there is a way to check if ${SMBWRAPPER}
isn't set at all we could make the installman script even work if
config.log does not exist.
(This used to be commit 3e3113a1fab282c0f652340d1027bb614ef93ec3)

12 years agor11725: build smbget by default
Gerald Carter [Mon, 14 Nov 2005 14:17:24 +0000 (14:17 +0000)]
r11725: build smbget by default
(This used to be commit 715bd97708fd826e3f8f1f344f7d0749d855c972)

12 years agor11719: Remove silly #define of close -> close_fn as this borks
Jeremy Allison [Mon, 14 Nov 2005 06:42:44 +0000 (06:42 +0000)]
r11719: Remove silly #define of close -> close_fn as this borks
any code that includes libsmbclient.h that also calls the
system close() fn. Doh ! Thanks to John Terpstra for
reporting this.
(This used to be commit 6e1cb7047aae80523a53d5552a4f704cd6e62997)

12 years agor11718: Filter stored DOS attributes by SAMBA_ATTRIBUTES_MASK (0x7f).
Jeremy Allison [Mon, 14 Nov 2005 06:29:48 +0000 (06:29 +0000)]
r11718: Filter stored DOS attributes by SAMBA_ATTRIBUTES_MASK (0x7f).
(This used to be commit 61444049e1543b364eea2ee79743287c75d37db5)

12 years agor11707: alt_names[i] might be NULL for i>0 also...
Volker Lendecke [Sun, 13 Nov 2005 11:53:18 +0000 (11:53 +0000)]
r11707: alt_names[i] might be NULL for i>0 also...

(This used to be commit c8b67c2448b09b3386a5b35ed279c134d7a3ba32)

12 years agor11706: Implement dsr_getdcname client code. It's handy: It not only gives you the IP
Volker Lendecke [Sun, 13 Nov 2005 11:38:17 +0000 (11:38 +0000)]
r11706: Implement dsr_getdcname client code. It's handy: It not only gives you the IP
address but also the fqdn of the remote dc and site info.

(This used to be commit 62d01ce7e6c14971084c208ab61f379cb172cb22)

12 years agor11704: methods->alternate_name is not used anymore -- remove it
Volker Lendecke [Sat, 12 Nov 2005 18:22:12 +0000 (18:22 +0000)]
r11704: methods->alternate_name is not used anymore -- remove it
(This used to be commit 4a4f85f0ef8545b7062e9a49392d4488aa108036)

12 years agor11685: reverting Lar's change to nistallman from r11224 since it breaks 'make instal...
Gerald Carter [Fri, 11 Nov 2005 21:11:33 +0000 (21:11 +0000)]
r11685: reverting Lar's change to nistallman from r11224 since it breaks 'make installman' outside the source tree; will fix up after the rc1 release
(This used to be commit 61e7366e0f545e8ef1aad45a3ab3f6aac1ca6049)

12 years agor11667: Fix a debug message
Volker Lendecke [Fri, 11 Nov 2005 07:03:17 +0000 (07:03 +0000)]
r11667: Fix a debug message
(This used to be commit d1f506fa1353cd1b9ddba923dc17a884f7560be6)

12 years agor11661: Store the INFO3 in the PAC data into the netsamlogon_cache.
Gerald Carter [Fri, 11 Nov 2005 03:03:41 +0000 (03:03 +0000)]
r11661: Store the INFO3 in the PAC data into the netsamlogon_cache.
Also remove the mem_ctx from the netsamlogon_cache_store() API.

Guenther, what should we be doing with the other fields in
(This used to be commit 8bead2d2825015fe41ba7d7401a12c06c29ea7f7)

12 years agor11658: Someone broke the initialization of the static modules by adding a 'NTSTATUS'
Jeremy Allison [Fri, 11 Nov 2005 00:16:43 +0000 (00:16 +0000)]
r11658: Someone broke the initialization of the static modules by adding a 'NTSTATUS'
declaration before their call.
The compiler sees : { NTSTATUS fn_foo(); NT_STATUS fn_bar(); }
as *definitions: They need to be : { fn_foo(); fn_bar(); }
(This used to be commit 1c5a3c51e36d228442b74d9221d3ed8a13a1c513)

12 years agor11657: Tiny improvement to debug error message in dir_check_ftype.
Paul Green [Thu, 10 Nov 2005 21:34:25 +0000 (21:34 +0000)]
r11657: Tiny improvement to debug error message in dir_check_ftype.
(This used to be commit 46674ca21d9c257bc48af97e313b49118c7b478d)

12 years agor11655: Two small fixes
Gerald Carter [Thu, 10 Nov 2005 21:10:24 +0000 (21:10 +0000)]
r11655: Two small fixes

* remove redundant call to sub_set_smb_name() in session setup code.
* Fix lockup when running 'wbinfo -t' on a Samba PDC.  Cause
  was new authenticated session setup from winbindd which
  resulted in a mangled username (machine_) that was not found
  in the local files and so was queiued up to nss_winbindd.
  So now make sure to keep the trailing '$' for machine account
  names when calling sub_set_smb_name().
(This used to be commit b0a2d43b603c2e230da6ada73587696605102e8f)

12 years agor11653: Declare the correct return value for the static initialization functions.
Paul Green [Thu, 10 Nov 2005 20:32:00 +0000 (20:32 +0000)]
r11653: Declare the correct return value for the static initialization functions.
Some compilers (guess whose) have ABIs that return int values using a
different method than returning struct values.
(This used to be commit 6bf4d88ab584315312934c9866128fb47f8b41e6)

12 years agor11652: Reinstate the netsamlogon_cache in order to work
Gerald Carter [Thu, 10 Nov 2005 20:28:23 +0000 (20:28 +0000)]
r11652: Reinstate the netsamlogon_cache in order to work
around failed query_user calls.  This fixes
logons to a member of a Samba domain as a user from a
trusted AD domain.

As per comments on samba-technical, I still need to add

(a) cache the PAC info as werll as NTLM net_user_info_3
(b) expire the cache when the SMB session goes away

Both Jeremy and Guenther have signed off on the idea.
(This used to be commit 0c2bb5ba7b92d9210e7fa9f7b70aa67dfe9faaf4)

12 years agor11651: After talking to Jeremy, commit my winbindd "Do the Right Thing" patch.
Gerald Carter [Thu, 10 Nov 2005 19:50:09 +0000 (19:50 +0000)]
r11651: After talking to Jeremy, commit my winbindd "Do the Right Thing" patch.
Still needs some more testing ni domains with multiple DCs. Coming next....
(This used to be commit aaed605206a8549cec575dab31e56bf6d32f26a6)

12 years agor11645: mklogon updates from Ricky Nance
Gerald Carter [Thu, 10 Nov 2005 14:30:39 +0000 (14:30 +0000)]
r11645: mklogon updates from Ricky Nance
(This used to be commit 5bfa88225c085238954909fb9aedb34b1b760977)

12 years agor11617: fix typo
Gerald Carter [Wed, 9 Nov 2005 19:37:13 +0000 (19:37 +0000)]
r11617: fix typo
(This used to be commit 37d2bf02f37f6d1b5bac9523f085c00625722761)

12 years agor11614: Replace old crc32 code with one from the FreeBSD tree.
Jeremy Allison [Wed, 9 Nov 2005 19:35:23 +0000 (19:35 +0000)]
r11614: Replace old crc32 code with one from the FreeBSD tree.
 *  COPYRIGHT (C) 1986 Gary S. Brown.  You may use this program, or
 *  code or tables extracted from it, as desired without restriction.
(This used to be commit 11c6b8ecd601ff2f6eaf184efeed8e39f54fdcf1)

12 years agor11613: fixing versions
Gerald Carter [Wed, 9 Nov 2005 18:33:37 +0000 (18:33 +0000)]
r11613: fixing versions
(This used to be commit b50a264f01c5af2d6cb0eed68b5292818ee06a59)

12 years agor11591: bumping version 3.0.22pre1
Gerald Carter [Wed, 9 Nov 2005 02:13:53 +0000 (02:13 +0000)]
r11591: bumping version 3.0.22pre1
(This used to be commit c1a4329833de01456e0df4abbe7c43e97578ae6a)

12 years agor11585: Implement the possibility to have AFS users as SIDs in pts.
Volker Lendecke [Tue, 8 Nov 2005 20:13:26 +0000 (20:13 +0000)]
r11585: Implement the possibility to have AFS users as SIDs in pts.

(This used to be commit 5b1b72ce7b944c7515a605369cb55a2f0171fe6f)

12 years agor11583: r10556@cabra: derrell | 2005-11-08 13:20:56 -0500
Derrell Lipman [Tue, 8 Nov 2005 18:23:51 +0000 (18:23 +0000)]
r11583:  r10556@cabra:  derrell | 2005-11-08 13:20:56 -0500
 fix copy/paste error
(This used to be commit 07dd45af840d8336937d1004ff8bdbd97db8d0b7)

12 years agor11582: r10193@cabra: derrell | 2005-11-08 13:12:39 -0500
Derrell Lipman [Tue, 8 Nov 2005 18:23:47 +0000 (18:23 +0000)]
r11582:  r10193@cabra:  derrell | 2005-11-08 13:12:39 -0500
 Fixed "clean" target -- bin/libmsrpc.a was not being deleted.

 Jerry, the shared version of libmsrpc is not using a version number.  For consistency, I added LIBMSRPC_MAJOR and LIBMSRPC_MINOR definitions but they are not
 currently being used.  I don't know if the non-use of version is intentional
 or not.
(This used to be commit b4871a552540169d615d2582a8d059296ad9085b)

12 years agor11580: fix an uninitialized variable that was causing winbindd to die in winbindd_du...
Gerald Carter [Tue, 8 Nov 2005 18:22:32 +0000 (18:22 +0000)]
r11580: fix an uninitialized variable that was causing winbindd to die in winbindd_dual_getsidaliases()
(This used to be commit c0c181826ea535adcbffb8790ad31356f7e9fc04)

12 years agor11579: syncing up perf counter code cfrom trunk
Gerald Carter [Tue, 8 Nov 2005 16:33:45 +0000 (16:33 +0000)]
r11579: syncing up perf counter code cfrom trunk
(This used to be commit 59c00924b67aa3d37a933731a56d03963ec7f1b5)

12 years agor11577: adding perl interpreter she-bang to top of script
Gerald Carter [Tue, 8 Nov 2005 16:29:15 +0000 (16:29 +0000)]
r11577: adding perl interpreter she-bang to top of script
(This used to be commit db4eb72142a23224ea93d2a2519b6d8cd7dc8643)

12 years agor11573: Adding Andrew Bartlett's patch to make machine account
Jeremy Allison [Tue, 8 Nov 2005 06:19:34 +0000 (06:19 +0000)]
r11573: Adding Andrew Bartlett's patch to make machine account
logons work if the client gives the MSV1_0_ALLOW_SERVER_TRUST_ACCOUNT
the auth module interface to 2 (from 1). The effect of this is
that clients can access resources as a machine account if they
set these flags. This is the same as Windows (think of a VPN
where the vpn client authenticates itself to a VPN server
using machine account credentials - the vpn server checks
that the machine password was valid by performing a machine
account check with the PDC in the same was as it would a
user account check. I may add in a restriction (parameter)
to allow this behaviour to be turned off (as it was previously).
That may be on by default.
Andrew Bartlett please review this change carefully.
(This used to be commit d1caef866326346fb191f8129d13d98379f18cd8)

12 years agor11566: From metze. Use "interpret_addr(lp_socket_address())" for port 138.
Jeremy Allison [Mon, 7 Nov 2005 23:28:42 +0000 (23:28 +0000)]
r11566: From metze. Use "interpret_addr(lp_socket_address())" for port 138.
(This used to be commit d398a1aeb48422a89cee59d5760a87bbb2d50b03)

12 years agor11560: Fix core dump if setmntent returns NULL.
Jeremy Allison [Mon, 7 Nov 2005 19:18:00 +0000 (19:18 +0000)]
r11560: Fix core dump if setmntent returns NULL.
Pointed out by Jay Fanlason @ Red Hat.
(This used to be commit e8136ae746b5be51b252d900aa732c8106fefcaf)

12 years agor11556: Fix "make everything"
Volker Lendecke [Mon, 7 Nov 2005 16:00:35 +0000 (16:00 +0000)]
r11556: Fix "make everything"
(This used to be commit bff03f0cd484c04d5ab6d6b66f30191bef368b68)

12 years agor11551: Add a few more initialize_krb5_error_table
Volker Lendecke [Mon, 7 Nov 2005 14:16:50 +0000 (14:16 +0000)]
r11551: Add a few more initialize_krb5_error_table
(This used to be commit d92c83aa42fe64a0e996094d1a983f0279c7c707)

12 years agor11549: fixing GPL notices
Gerald Carter [Mon, 7 Nov 2005 13:45:28 +0000 (13:45 +0000)]
r11549: fixing GPL notices
(This used to be commit 26e9c1c1fae8f2fe402374f7cf1d87de48852fa6)

12 years agor11548: adding simple script to tail syslog and write to eventlog tdb
Gerald Carter [Mon, 7 Nov 2005 13:43:06 +0000 (13:43 +0000)]
r11548: adding simple script to tail syslog and write to eventlog tdb
(This used to be commit 9337a286c9169e1e0247b5923942eeeb4467d95a)

12 years agor11530: Add the "time offset" parameter back in for people who
Jeremy Allison [Sun, 6 Nov 2005 01:55:09 +0000 (01:55 +0000)]
r11530: Add the "time offset" parameter back in for people who
might use it.
(This used to be commit b745114423a482ea8cd1ea4f80ec3fc2a9caa971)

12 years agor11511: A classic "friday night check-in" :-). This moves much
Jeremy Allison [Sat, 5 Nov 2005 04:21:55 +0000 (04:21 +0000)]
r11511: A classic "friday night check-in" :-). This moves much
of the Samba4 timezone handling code back into Samba3.
Gets rid of "kludge-gmt" and removes the effectiveness
of the parameter "time offset" (I can add this back
in very easily if needed) - it's no longer being
looked at. I'm hoping this will fix the problems people
have been having with DST transitions. I'll start comprehensive
testing tomorrow, but for now all modifications are done.
Splits time get/set functions into srv_XXX and cli_XXX
as they need to look at different timezone offsets.
Get rid of much of the "efficiency" cruft that was
added to Samba back in the day when the C library
timezone handling functions were slow.
(This used to be commit 414303bc0272f207046b471a0364fa296b67c1f8)

12 years agor11508: Removed incorrect patch hunk. Thanks to Andrew
Jeremy Allison [Sat, 5 Nov 2005 00:02:01 +0000 (00:02 +0000)]
r11508: Removed incorrect patch hunk. Thanks to Andrew
Bartlett for pointing this out.
(This used to be commit c93a08be4a29854354a16c6e8f984477e19f41c0)

12 years agor11506: Added description of ACL in usage message.
Jeremy Allison [Fri, 4 Nov 2005 17:40:35 +0000 (17:40 +0000)]
r11506: Added description of ACL in usage message.
(This used to be commit 7795fce24e1e6dfe55360bb62617b922973f5f95)

12 years agor11504: Added Andrew Bartletts removal of another NTLMSSP implementation
Jeremy Allison [Fri, 4 Nov 2005 17:39:42 +0000 (17:39 +0000)]
r11504: Added Andrew Bartletts removal of another NTLMSSP implementation
(This used to be commit 4591984176fd32ba25155fbc6889a1c637019a08)

12 years agor11494: Finally fix #3192 - remember iDiskfreeCacheTime is
Jeremy Allison [Fri, 4 Nov 2005 01:21:46 +0000 (01:21 +0000)]
r11494: Finally fix #3192 - remember iDiskfreeCacheTime is
an *integer*, not a pointer. Doh !
(This used to be commit f1e0c863637f11f5857663d1980ba7f40fce7357)

12 years agor11492: Fix bug #3224 (I hope). Correctly use machine_account_name
Jeremy Allison [Fri, 4 Nov 2005 00:03:55 +0000 (00:03 +0000)]
r11492: Fix bug #3224 (I hope). Correctly use machine_account_name
and client_name when doing netlogon credential setup.
(This used to be commit 37e6ef9389041f58eada167239fd022f01c5fecb)

12 years agor11491: If we get a reject ensure we're printing out the server/domain/machine
Jeremy Allison [Thu, 3 Nov 2005 20:26:24 +0000 (20:26 +0000)]
r11491: If we get a reject ensure we're printing out the server/domain/machine
a/c we were asking for.
(This used to be commit 3ba5d02cff61d64dbab1fef28f74ea6509f4f8e9)

12 years agor11482: Arrg. Can't believe this code was in this state. If you
Jeremy Allison [Wed, 2 Nov 2005 20:32:11 +0000 (20:32 +0000)]
r11482: Arrg. Can't believe this code was in this state. If you
don't initialize the mask then setting "special" access
gets set to *random* permissions !
(This used to be commit f1616911a858886da0a635a2f9b95d471215e84c)

12 years agor11464: Allow smbcacls to modify a SD on W2K3. This may fix several
Jeremy Allison [Wed, 2 Nov 2005 02:35:48 +0000 (02:35 +0000)]
r11464: Allow smbcacls to modify a SD on W2K3. This may fix several
bugzilla bugs - I need to go through and check. I also
need to test against WNT/W2K and WXP.
(This used to be commit 881dd7dbf6de0e11a3703afd2a1ba286ff0d62ad)

12 years agor11460: Improve error messages in parsing security descriptors.
Jeremy Allison [Wed, 2 Nov 2005 02:13:08 +0000 (02:13 +0000)]
r11460: Improve error messages in parsing security descriptors.
(This used to be commit 385f128de716b62bdfc82627a403fe6dd69bd39d)

12 years agor11454: Last 2 uninitialized warnings.
Jeremy Allison [Wed, 2 Nov 2005 00:37:35 +0000 (00:37 +0000)]
r11454: Last 2 uninitialized warnings.
(This used to be commit 5f10368ff0f5eae646533280a444dc091d732c0d)

12 years agor11451: Fix -O1 "might be using uninitialized" errors.
Jeremy Allison [Wed, 2 Nov 2005 00:19:26 +0000 (00:19 +0000)]
r11451: Fix -O1 "might be using uninitialized" errors.
(This used to be commit cab76c3c33883aad444eefb6562ab1b27d9ca88a)

12 years agor11448: Move decl before code.
Jeremy Allison [Tue, 1 Nov 2005 23:49:40 +0000 (23:49 +0000)]
r11448: Move decl before code.
(This used to be commit f22822790cdbbe7d5a237421c1eda73a504e488d)

12 years agor11446: Remove unused fn. Remove unneeded strncpy use.
Jeremy Allison [Tue, 1 Nov 2005 23:29:02 +0000 (23:29 +0000)]
r11446: Remove unused fn. Remove unneeded strncpy use.
(This used to be commit d202aae3c821f3d78ff063d867bac1f84dca3548)

12 years agor11443: Fix error code returns on client spoolss code. Fix them
Jeremy Allison [Tue, 1 Nov 2005 19:24:55 +0000 (19:24 +0000)]
r11443: Fix error code returns on client spoolss code. Fix them
up a *lot*.
(This used to be commit 762fff4ddb505b90ada1ea54348dba1a8b9af631)

12 years agor11435: Allow the hash size of the tdb open (locking) database
Jeremy Allison [Tue, 1 Nov 2005 02:07:26 +0000 (02:07 +0000)]
r11435: Allow the hash size of the tdb open (locking) database
to be set in local.h. Change from the default (131) to
another prime (1049). Should this be an smb.conf tunable parameter
based on the number of open file descriptors available ?
If so what scaling factor ? More tests to follow.
(This used to be commit 6a902ec49ffea5d0ca0308d5ff51584cece41043)

12 years agor11433: Fix for bug #3223 - ensure we're root before doing
Jeremy Allison [Mon, 31 Oct 2005 23:47:57 +0000 (23:47 +0000)]
r11433: Fix for bug #3223 - ensure we're root before doing
any potential lib/smbldap.c calls.
(This used to be commit 915cfb48f08b3748e22e68ed028eaca6d558cbad)

12 years agor11428: Fix bug #3192 by actually hooking up the dfree caching
Jeremy Allison [Mon, 31 Oct 2005 22:30:05 +0000 (22:30 +0000)]
r11428: Fix bug #3192 by actually hooking up the dfree caching
function. Oops.
(This used to be commit 7edb26e7657fc01710abe563b941779749409ef2)

12 years agor11420: Fix issue pointed out by Dina Fine <>. We can
Jeremy Allison [Mon, 31 Oct 2005 20:11:58 +0000 (20:11 +0000)]
r11420: Fix issue pointed out by Dina Fine <>. We can
only tell at parse time from the wire if an incoming name
has wildcards or not. If it's a mangled name and we demangle
the demangled name may contain wildcard characters. Ensure
these are ignored.
(This used to be commit 4cd8e2a96b98ff711905e8c6f416b22440c16062)

12 years agor11398: Keep s3 in sync with trunk
Simo Sorce [Sat, 29 Oct 2005 13:31:57 +0000 (13:31 +0000)]
r11398: Keep s3 in sync with trunk
(This used to be commit 7fc05b79643c93eaf0ef028a7337889ed21c52ba)

12 years agor11395: Update the Debian packaging.
Simo Sorce [Sat, 29 Oct 2005 13:19:27 +0000 (13:19 +0000)]
r11395: Update the Debian packaging.
Move form stable to stable distribution names based hives.
(This used to be commit bb13b3482047b6ab6d84ba9e2839cf8a0fac71aa)

12 years agor11389: Attempt to fix bug #3212 - ignore bogus OS/2 EA set values on
Jeremy Allison [Sat, 29 Oct 2005 00:27:16 +0000 (00:27 +0000)]
r11389: Attempt to fix bug #3212 - ignore bogus OS/2 EA set values on
(This used to be commit 71c037dfbb0b51e750f2e14533b03d9932778cb0)

12 years agor11383: Patch from Alex Masterov <> to fix
Jeremy Allison [Fri, 28 Oct 2005 22:22:23 +0000 (22:22 +0000)]
r11383: Patch from Alex Masterov <> to fix
XATTR calls on *BSD systems (bug #3218).
(This used to be commit 3d8faf42e854a720aca5c2e0a4682c85a3dfd365)

12 years agor11381: Correctly connect to 445 and 139 after a successful getdcname.
Volker Lendecke [Fri, 28 Oct 2005 21:08:31 +0000 (21:08 +0000)]
r11381: Correctly connect to 445 and 139 after a successful getdcname.

(This used to be commit 440e7b3342e6b7b12208b789853962de72a9cac2)

12 years agor11379: Remove external dependencies from sharemodes library.
Jeremy Allison [Fri, 28 Oct 2005 20:36:21 +0000 (20:36 +0000)]
r11379: Remove external dependencies from sharemodes library.
(This used to be commit 7fb05872612c9e1816ac24d25a020073e3b41950)

12 years agor11375: Update to the latest config.guess and config.sub files.
Paul Green [Fri, 28 Oct 2005 16:17:46 +0000 (16:17 +0000)]
r11375: Update to the latest config.guess and config.sub files.
(This used to be commit eee397ea15d0804d541be9707158a5240996aeae)

12 years agor11368: Remove a memleak that just cost me half an hour: If we terminate inside a
Volker Lendecke [Fri, 28 Oct 2005 09:15:27 +0000 (09:15 +0000)]
r11368: Remove a memleak that just cost me half an hour: If we terminate inside a
message handler, the list of messages from retrieve_all_messages is not
properly freed. Not important, just confusing :-)

(This used to be commit d20388750dcfe7e0680246f7e3e6beb3a6d51a4a)

12 years agor11346: Fix for bug found by Dina Fine. If in case sensitive mode then
Jeremy Allison [Fri, 28 Oct 2005 01:42:03 +0000 (01:42 +0000)]
r11346: Fix for bug found by Dina Fine. If in case sensitive mode then
the mangle cache is no good (3 letter extension could be wrong
case - so don't demangle in this case - leave as mangled and
allow the mangling of the directory entry read (which is done
case insensitively) to match instead. This will lead to more
false positive matches but we fail completely without it.
(This used to be commit 238b35d2e6e21d0e07d500d446f08ec128ea7720)

12 years agor11344: I don't think share mode conflicts occur on deleting
Jeremy Allison [Thu, 27 Oct 2005 23:30:25 +0000 (23:30 +0000)]
r11344: I don't think share mode conflicts occur on deleting
a directory when you've got permissions. Need to write
a smbtorture test for this.
(This used to be commit e959a5be393eb59b8987eb6967a2ee5d11978f41)

12 years agor11341: Put directory opens into the share mode db so we
Jeremy Allison [Thu, 27 Oct 2005 22:35:08 +0000 (22:35 +0000)]
r11341: Put directory opens into the share mode db so we
can treat them similarly to file opens (delete on
close, share mode violations etc.). This fixes bug
#3216 I will up the default hash size on the locking
db in a later commit as this means more entries.
(This used to be commit 1134abbbb3fd8e8b88e1a5817aae106476a4c126)

12 years agor11338: Move knowledge of \\ needed into rpc_client/cli_netlogon
Jeremy Allison [Thu, 27 Oct 2005 18:25:41 +0000 (18:25 +0000)]
r11338: Move knowledge of \\ needed into rpc_client/cli_netlogon
(this is the way it's been done in other functions). Instead
of moving this into the IDL, I think the best solution would
be to write a wrapper function around any call that needs
this (this is what we already do for many of the calls).
(This used to be commit aeca4efa11728be53b81967bb5442b5b09d1a975)

12 years agor11336: Start to get my control back :-). Volker, I think
Jeremy Allison [Thu, 27 Oct 2005 18:06:29 +0000 (18:06 +0000)]
r11336: Start to get my control back :-). Volker, I think
Andrew Bartlett is right - making lsa code do it the
netlogon way, not vica-versa.
(This used to be commit f313757e36215cb3dd956e4a73de6d30258a6974)

12 years agor11332: eventlog API uses NTSTATUS, not WERROR for return codes
Gerald Carter [Thu, 27 Oct 2005 13:30:23 +0000 (13:30 +0000)]
r11332: eventlog API uses NTSTATUS, not WERROR for return codes
(This used to be commit f5f40633bc3f641a0fef4934375d0d829899b0d7)

12 years agor11328: Actually verify that the bind on a pipe succeeded with a samr_connect or
Volker Lendecke [Thu, 27 Oct 2005 12:51:24 +0000 (12:51 +0000)]
r11328: Actually verify that the bind on a pipe succeeded with a samr_connect or
lsa_openpolicy and fall back appropriately. In particular an ntlmssp bind
failure can not be detected before the first real rpc request, at least
according to abartlet :-)

Works for me against w2k3, w2k and nt4. Sooner or later I should test against
samba4 ... :-)

(This used to be commit 48a9e35208ae7b6271508085f59833e5def640e8)

12 years agor11327: Make user domain settable by pdbedit
Volker Lendecke [Thu, 27 Oct 2005 12:47:06 +0000 (12:47 +0000)]
r11327: Make user domain settable by pdbedit
(This used to be commit 37267d5ab018bb6df9e297ea68e57deb9a908f28)

12 years agor11326: Fix alignment in getdc response
Volker Lendecke [Thu, 27 Oct 2005 12:45:10 +0000 (12:45 +0000)]
r11326: Fix alignment in getdc response
(This used to be commit 9741818d2c54240ef1f38762396828adceb92b2a)

12 years agor11324: Re-formatting before I can get a very *narrow* focus on the bugs in here...
Volker Lendecke [Thu, 27 Oct 2005 11:16:36 +0000 (11:16 +0000)]
r11324: Re-formatting before I can get a very *narrow* focus on the bugs in here. ;-)

We can only tell if the bind succeeded on the first real RPC call. So we have
to decide according to success of samrconnect whether we have to fall
back. Similarly for lsaopenpolicy.

(This used to be commit 0603e1c8456ee87b87b051e0303a35fdbfbcf7ca)

12 years agor11323: Fix usage of rpccli_netlogon_getdcname. Add some debug messages.
Volker Lendecke [Thu, 27 Oct 2005 11:01:29 +0000 (11:01 +0000)]
r11323: Fix usage of rpccli_netlogon_getdcname. Add some debug messages.

(This used to be commit 770ad2a8a72ae7bfcdc1b86b72142e11f662d975)