samba.git
16 years agor15005: Fix printf args to remove warnings.
Jeremy Allison [Sun, 9 Apr 2006 01:20:26 +0000 (01:20 +0000)]
r15005: Fix printf args to remove warnings.
Jeremy.
(This used to be commit 68d100830c5a6fa24b863071e8ca77ab264175a0)

16 years agor15003: patch based on code from Arkady Glabek <aglabek@centeris.com> to ensure that...
Gerald Carter [Sat, 8 Apr 2006 17:25:31 +0000 (17:25 +0000)]
r15003: patch based on code from Arkady Glabek <aglabek@centeris.com> to ensure that global memory is freed when unloading pam_winbind.so (needs more testing on non-linux platforms)
(This used to be commit 1e0b79e591d70352a96e0a0487d8f394dc7b36ba)

16 years agor14989: Fix from Mathias Dietz <MDIETZ@de.ibm.com>. EPERM can be
Jeremy Allison [Sat, 8 Apr 2006 05:09:12 +0000 (05:09 +0000)]
r14989: Fix from Mathias Dietz <MDIETZ@de.ibm.com>. EPERM can be
a valid return from getting an xattr. Don't disable if
we get it.
Jeremy.
(This used to be commit 7769b678f22d8ab4aa8aef55966813355bf2ce6d)

16 years agor14986: Fix OS/2 directory delete bug found by kukks.
Jeremy Allison [Sat, 8 Apr 2006 05:00:04 +0000 (05:00 +0000)]
r14986: Fix OS/2 directory delete bug found by kukks.
(Thanks a lot for all your hard work on this).
We were caching the results of *all* directory
scans, not just the results that match the
client wildcard. This actually made no sense,
as only matches on the client wildcard can be
returned to the client and so might need to
be searched for in the cache. This fixes the
directory cache to only cache entries that we
return to the client.
Jeremy.
(This used to be commit c88af597d042390ff11b26fe802b0b10d0faa6ce)

16 years agor14954: Fix #3569 based on William Jojo's work. AIX also
Jeremy Allison [Thu, 6 Apr 2006 22:31:45 +0000 (22:31 +0000)]
r14954: Fix #3569 based on William Jojo's work. AIX also
has the linear posix locking issue which causes
CLEAR_IF_FIRST to cause performance problems.
As we know we're in a daemon architecture with
long-lived parent we can avoid this in the Samba
case. Add a comment explaining this.
Jeremy.
(This used to be commit 3cd5c3df0d1b98dfa90663973ab13b5d3dbf737e)

16 years agor14940: Remove pam_winbind's ability to create home directories on it's own.
Günther Deschner [Thu, 6 Apr 2006 09:23:34 +0000 (09:23 +0000)]
r14940: Remove pam_winbind's ability to create home directories on it's own.

Guenther
(This used to be commit 87293802f3e0666c9a50eb3ca63bb1a7dccc50dc)

16 years agor14931: Fix #1374: can't join an OU with name that contains '#'
Jim McDonough [Thu, 6 Apr 2006 01:46:01 +0000 (01:46 +0000)]
r14931: Fix #1374: can't join an OU with name that contains '#'

I had to eliminate "\" as an OU path separator, because it is the escape
char in LDAP.  We still accept "/", but using the escape char is just
not a good choice.
(This used to be commit 1953f63903e64e0a33eb981c51b8ca4beb673af2)

16 years agor14923: Return False in the case a parametrical option is not configured in
Lars Müller [Wed, 5 Apr 2006 07:44:14 +0000 (07:44 +0000)]
r14923: Return False in the case a parametrical option is not configured in
the config file.

For a "somesettings: foo = " we still return an empty line.
(This used to be commit 59175ee522c5b4f9554ee734c008d8048eb1eadb)

16 years agor14922: Use BOOL for the returned value.
Lars Müller [Wed, 5 Apr 2006 07:29:22 +0000 (07:29 +0000)]
r14922: Use BOOL for the returned value.
(This used to be commit b228474be0ced2637272a7b614b92e412a118993)

16 years agor14900: Separate words in error message.
James Peach [Tue, 4 Apr 2006 01:07:28 +0000 (01:07 +0000)]
r14900: Separate words in error message.
(This used to be commit ffe1a2e23ffb2edf2274c20ece0a66a9c649d50f)

16 years agor14899: Add missing semi-colon.
James Peach [Tue, 4 Apr 2006 00:59:50 +0000 (00:59 +0000)]
r14899: Add missing semi-colon.
(This used to be commit 5f4f4cbe6fe069570a921468034005d364f63206)

16 years agor14898: This change is an attempt to improve the quality of the information that
James Peach [Tue, 4 Apr 2006 00:27:50 +0000 (00:27 +0000)]
r14898: This change is an attempt to improve the quality of the information that
is produced when a process exits abnormally.

First, we coalesce the core dumping code so that we greatly improve our
odds of being able to produce a core file, even in the case of a memory
fault. I've removed duplicates of dump_core() and split it in two to
reduce the amount of work needed to actually do the dump.

Second, we refactor the exit_server code path to always log an explanation
and a stack trace. My goal is to always produce enough log information
for us to be able to explain any server exit, though there is a risk
that this could produce too much log information on a flaky network.

Finally, smbcontrol has gained a smbd fault injection operation to test
the changes above. This is only enabled for developer builds.
(This used to be commit 56bc02d64498eb3faf89f0c5452b9299daea8e95)

16 years agor14896: Remove unused files
Volker Lendecke [Mon, 3 Apr 2006 19:14:12 +0000 (19:14 +0000)]
r14896: Remove unused files
(This used to be commit cc1bdbbc41bd6626ee53abf3f2ab35c454e036b7)

16 years agor14895: Merge the 3.0.22 change
Volker Lendecke [Mon, 3 Apr 2006 19:08:23 +0000 (19:08 +0000)]
r14895: Merge the 3.0.22 change
(This used to be commit 62d60a04cd85dc521e7d63726b856f38287466ad)

16 years agor14892: allow:
Stefan Metzmacher [Mon, 3 Apr 2006 14:57:48 +0000 (14:57 +0000)]
r14892: allow:
CC_CHECKER=mycheker make

metze
(This used to be commit b562459fbfdbfa25c774d631b48f1187fc3e15eb)

16 years agor14889: Fix smbwrapper compile
Volker Lendecke [Mon, 3 Apr 2006 13:53:57 +0000 (13:53 +0000)]
r14889: Fix smbwrapper compile
(This used to be commit 0f087fd40ad502513c3775587c07c86fc53bf718)

16 years agor14886: reenable BASE-DENY2 and BASE-DENY3
Stefan Metzmacher [Mon, 3 Apr 2006 11:34:17 +0000 (11:34 +0000)]
r14886: reenable BASE-DENY2 and BASE-DENY3

metze
(This used to be commit 69f489bde07d4c66bdf4dd3a2411d40ed868d144)

16 years agor14884: this doesn't work and causes processes to be left when using ctrl-c (SIGINT)
Stefan Metzmacher [Mon, 3 Apr 2006 11:32:57 +0000 (11:32 +0000)]
r14884: this doesn't work and causes processes to be left when using ctrl-c (SIGINT)

metze
(This used to be commit 1ac5351646b18f28b1f9ed477b6e6046e1bdf783)

16 years agor14883: add 'smbd:sharedelay' option, so that we can speed up BASE-DENY2 in make...
Stefan Metzmacher [Mon, 3 Apr 2006 10:43:34 +0000 (10:43 +0000)]
r14883: add 'smbd:sharedelay' option, so that we can speed up BASE-DENY2 in make test
as done in samba4

metze
(This used to be commit b98dd258a74a1e1b4e967e6176a5a92986d03123)

16 years agor14869: Allow to dump a paramatrical option.
Lars Müller [Sun, 2 Apr 2006 21:12:23 +0000 (21:12 +0000)]
r14869: Allow to dump a paramatrical option.

Flaw: We print an empty line if the paramatrical option is not defined
in the requested section.
(This used to be commit a0d84ccc02e19d22d827e7d052fab6d471f0a1b3)

16 years agor14868: I will not write code when changing to Daylight Savings Time.
Gerald Carter [Sun, 2 Apr 2006 19:45:42 +0000 (19:45 +0000)]
r14868: I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.

...

Fix my brain dead inverted logic for turning winbindd on and off
when run on a DC or when calling pdb functions from within winbindd.
(This used to be commit 021b3dc2db9fb422ede4657a1f27ef7ef2d22cee)

16 years agor14865: - enforce timelimits for the tests
Stefan Metzmacher [Sun, 2 Apr 2006 12:52:59 +0000 (12:52 +0000)]
r14865: - enforce timelimits for the tests
- and skip some long tests for now

metze
(This used to be commit 1d52ae786d400441d9f5b30b4fa9e4e8ff64f7e4)

16 years agor14863: try to make the generation of bin/timelimit more portable
Stefan Metzmacher [Sun, 2 Apr 2006 12:29:13 +0000 (12:29 +0000)]
r14863: try to make the generation of bin/timelimit more portable

jerry: can you test that please

metze
(This used to be commit aa76c2edee17a023ee49f9b960a79df402f785ea)

16 years agor14855: Various fixes:
Gerald Carter [Sun, 2 Apr 2006 06:25:11 +0000 (06:25 +0000)]
r14855: Various fixes:

* depreacte 'acl group control' after discussion with Jeremy
  and implement functionality as part of 'dos filemode'
* fix winbindd on a non-member server to expand local groups
* prevent code previously only used by smbd from blindly
  turning _NO_WINBINDD back on
(This used to be commit 4ab372f4cab22225716b5c9a9a08f0c1dbc9928d)

16 years agor14849: Fix >= that should be >. Too strict condition
Jeremy Allison [Sat, 1 Apr 2006 18:22:31 +0000 (18:22 +0000)]
r14849: Fix >= that should be >. Too strict condition
checked by Volker.
Jeremy.
(This used to be commit 9a763da07385bf9af437cab8dd680f2e13fca3c3)

16 years agor14847: Tell static checkers that exit_server() doesn't
Jeremy Allison [Sat, 1 Apr 2006 05:41:34 +0000 (05:41 +0000)]
r14847: Tell static checkers that exit_server() doesn't
return.
Jeremy.
(This used to be commit 9c5e26a56aaaf1143b43e61d208ddaeb96f2ffcb)

16 years agor14841: Fix IRIX build --with-pam.
Günther Deschner [Fri, 31 Mar 2006 11:48:01 +0000 (11:48 +0000)]
r14841: Fix IRIX build --with-pam.

Guenther
(This used to be commit 99158406b47dc07961c4f6536181da868cf276ca)

16 years agor14833: Fix resource leak on error code path. Coverity #280.
Jeremy Allison [Fri, 31 Mar 2006 00:50:09 +0000 (00:50 +0000)]
r14833: Fix resource leak on error code path. Coverity #280.
Jeremy.
(This used to be commit b985bdcb87eeb70725f2d625a4ea5ec39bda1b94)

16 years agor14831: Fix possible null deref. Coverity #279.
Jeremy Allison [Fri, 31 Mar 2006 00:47:08 +0000 (00:47 +0000)]
r14831: Fix possible null deref. Coverity #279.
Jeremy.
(This used to be commit 75be5c17bc74c86219c7cac749b52b7d43abb780)

16 years agor14829: Fix reversed test in coverity fixes.
Jeremy Allison [Fri, 31 Mar 2006 00:44:24 +0000 (00:44 +0000)]
r14829: Fix reversed test in coverity fixes.
Jeremy.
(This used to be commit f1b4e870a52cbd7bb780b206e943987648523060)

16 years agor14825: add support for max connections parameter
Gerald Carter [Thu, 30 Mar 2006 14:28:33 +0000 (14:28 +0000)]
r14825: add support for max connections parameter
(This used to be commit 63efbdf005f410c4a9843809207ea27f4c1ac756)

16 years agor14820: sync test_posix_p3.sh with test_posix.sh from samba4
Stefan Metzmacher [Thu, 30 Mar 2006 13:11:08 +0000 (13:11 +0000)]
r14820: sync test_posix_p3.sh with test_posix.sh from samba4
but only run the BASE-* tests and ignore some more than in samba4

metze
(This used to be commit 6f37658f927c103a71e918ab5ac78d61cd570c36)

16 years agor14809: - add my email address
Stefan Metzmacher [Thu, 30 Mar 2006 09:34:02 +0000 (09:34 +0000)]
r14809: - add my email address
- fix usage()
- remove unused var

metze
(This used to be commit 20782719d9eda7609788c132356db7107b7fe04a)

16 years agor14790: Fix possible null deref. Coverity #277.
Jeremy Allison [Wed, 29 Mar 2006 23:45:08 +0000 (23:45 +0000)]
r14790: Fix possible null deref. Coverity #277.
Jeremy.
(This used to be commit 2454af392a71989ecddb2dbb17a9217658102523)

16 years agor14788: Fix coverity bug #276. null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:42:03 +0000 (23:42 +0000)]
r14788: Fix coverity bug #276. null deref.
Jeremy.
(This used to be commit 0217f7d7bf4c8b5b7de2433485fb6f78b62ac817)

16 years agor14786: Fix coverity #275. null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:35:16 +0000 (23:35 +0000)]
r14786: Fix coverity #275. null deref.
Jeremy.
(This used to be commit 363d31c9ec2d2a4429ab4d26b3d7c78b76f60626)

16 years agor14784: Fix coverity bug #274. Null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:32:40 +0000 (23:32 +0000)]
r14784: Fix coverity bug #274. Null deref.
Jeremy.
(This used to be commit f88f2d93686ba6bd317b7bc935888e75b7999c83)

16 years agor14782: Fix coverity bug #273, null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:25:04 +0000 (23:25 +0000)]
r14782: Fix coverity bug #273, null deref.
Jeremy.
(This used to be commit c2636c10262e8045f701143dee22b10b2d0c0344)

16 years agor14780: Fix coverity bug #272, null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:22:57 +0000 (23:22 +0000)]
r14780: Fix coverity bug #272, null deref.
Jeremy.
(This used to be commit 1588ce8efe7fafd89561b55a98c498f947f4ada9)

16 years agor14778: Fix coverity null deref bugs #268 - #271.
Jeremy Allison [Wed, 29 Mar 2006 23:18:58 +0000 (23:18 +0000)]
r14778: Fix coverity null deref bugs #268 - #271.
Jeremy.
(This used to be commit 0a1ccfefcf27c5970b82bf8a451bcdaa4fee1bd0)

16 years agor14776: Fix coverity #263 - #267. No one was checking talloc
Jeremy Allison [Wed, 29 Mar 2006 23:13:27 +0000 (23:13 +0000)]
r14776: Fix coverity #263 - #267. No one was checking talloc
returns. Doh !
Jeremy.
(This used to be commit 68097e0fbb8f232573a2f7eae3da3a0c9873fbc5)

16 years agor14774: Fix null deref coverity bugs #260, #261, #262.
Jeremy Allison [Wed, 29 Mar 2006 23:03:34 +0000 (23:03 +0000)]
r14774: Fix null deref coverity bugs #260, #261, #262.
Jeremy.
(This used to be commit 46e575af17cefb0ce7a1fdfacf29f90ae36fa72e)

16 years agor14772: Fix coverity bug #258. Seems coverity has discovered talloc :-).
Jeremy Allison [Wed, 29 Mar 2006 22:59:33 +0000 (22:59 +0000)]
r14772: Fix coverity bug #258. Seems coverity has discovered talloc :-).
Jeremy.
(This used to be commit 488b7725168971e6e59f3a2a7476ce82df43579b)

16 years agor14770: Fix coverity bug #257. Possible null deref.
Jeremy Allison [Wed, 29 Mar 2006 22:56:05 +0000 (22:56 +0000)]
r14770: Fix coverity bug #257. Possible null deref.
Jeremy.
(This used to be commit 4c126ef65dd07352ab936fff774c7435723f5395)

16 years agor14768: Fix potential null deref coverity bugs #255, #256.
Jeremy Allison [Wed, 29 Mar 2006 22:51:23 +0000 (22:51 +0000)]
r14768: Fix potential null deref coverity bugs #255, #256.
Jeremy.
(This used to be commit a40c7a0cd888dcee3cac1a41602863f54c51ef17)

16 years agor14766: Fix possible NULL deref. Coverity #254.
Jeremy Allison [Wed, 29 Mar 2006 22:45:52 +0000 (22:45 +0000)]
r14766: Fix possible NULL deref. Coverity #254.
Jeremy.
(This used to be commit e2e2d8b939dd425a97b36102c6a541e3cf6236ad)

16 years agor14764: Fix possible null pointer deref. Coverity #253.
Jeremy Allison [Wed, 29 Mar 2006 22:41:24 +0000 (22:41 +0000)]
r14764: Fix possible null pointer deref. Coverity #253.
Jeremy.
(This used to be commit 7a18f38947385b8a5fb27a42610320003689e9e1)

16 years agor14763: Add a new tuning parameter, open files database hash size,
Jeremy Allison [Wed, 29 Mar 2006 22:19:01 +0000 (22:19 +0000)]
r14763: Add a new tuning parameter, open files database hash size,
this allows us to experiment with ensuring the tdb hash
size for our open files and locking db are appropriately
sized. Make the hash size larger by default (10007 instead
of 1049) and make the locking db hash size the same as the
open file db hash size.
Jeremy.
(This used to be commit e7225f7e813423c3e2a94af6a9d7ce8a1b50a166)

16 years agor14760: Fix #3642, ensure we don't call FD_SET on read with fd == -1.
Jeremy Allison [Wed, 29 Mar 2006 18:55:39 +0000 (18:55 +0000)]
r14760: Fix #3642, ensure we don't call FD_SET on read with fd == -1.
Jeremy.
(This used to be commit 6ae15544ccfc3ff5d97565ad41ba7f57c7d29b0f)

16 years agor14758: Fix broken LDAP search filter.
Günther Deschner [Wed, 29 Mar 2006 18:24:34 +0000 (18:24 +0000)]
r14758: Fix broken LDAP search filter.

Guenther
(This used to be commit 25970a54298f2888b5c3cd64496dbd0c9d627a05)

16 years agor14757: Make sure we only send out a CLDAP request to an connected AD server.
Günther Deschner [Wed, 29 Mar 2006 15:30:26 +0000 (15:30 +0000)]
r14757: Make sure we only send out a CLDAP request to an connected AD server.

Guenther
(This used to be commit d17712f9761589115e976e2240498396f36838ee)

16 years agor14756: Make smbpasswd -a root work for eDirectory where there is no "account"
Günther Deschner [Wed, 29 Mar 2006 14:52:03 +0000 (14:52 +0000)]
r14756: Make smbpasswd -a root work for eDirectory where there is no "account"
structural objectclass.

Guenther
(This used to be commit 7eefeaad352597b6f97160b1abc0dc032c0b46b2)

16 years agor14753: Fix the kerberized pam_auth: As we could have created a new credential
Günther Deschner [Wed, 29 Mar 2006 09:40:42 +0000 (09:40 +0000)]
r14753: Fix the kerberized pam_auth: As we could have created a new credential
cache with a valid TGT in it but we werent able to get or verify the
service ticket for this local host afterwards and therefor didn't get
the PAC, we need to remove that ccache entirely.

Also remove an ugly pair of (not needed) seteuid calls around the ticket
destroy wrapper.

Guenther
(This used to be commit 25a2fb3896596380d9eecac80defbf247a35e6bb)

16 years agor14751: Use the noreturn attribute to try and tell coverity that
Jeremy Allison [Tue, 28 Mar 2006 15:50:13 +0000 (15:50 +0000)]
r14751: Use the noreturn attribute to try and tell coverity that
smb_panic can't return.
Jeremy.
(This used to be commit ba9c98983efbf4871e1ec07df37590d97ec52fba)

16 years agor14748: store the name/ip address combination when we doa reverse look up in case...
Gerald Carter [Tue, 28 Mar 2006 13:34:13 +0000 (13:34 +0000)]
r14748: store the name/ip address combination when we doa reverse look up in case future forward lookups would fail
(This used to be commit d56ed46faec46dad74b469d25ff99c9002792c78)

16 years agor14746: Add the Samba4 replacements for opendir/readdir etc. to
Jeremy Allison [Mon, 27 Mar 2006 19:50:45 +0000 (19:50 +0000)]
r14746: Add the Samba4 replacements for opendir/readdir etc. to
Samba3 - with some 64-bit macro madness. Attempt to fix
the broken directory handling in the *BSD-of-the-month
club.
Jeremy.
(This used to be commit fd98427f64f4206c01f16f82fadf24f5863878db)

16 years agor14744: allow ./timelimit 5 ./timelimit 20 ./ignore_all_signals
Stefan Metzmacher [Mon, 27 Mar 2006 12:32:42 +0000 (12:32 +0000)]
r14744: allow ./timelimit 5 ./timelimit 20 ./ignore_all_signals
to work,

this is needed when we enable samba3's make test
in the build-farm

metze
(This used to be commit b120c21669a91a097f044530a1f7c59043465841)

16 years agor14743: Fix coverity bug #227. Possible deref of null pointer
Jeremy Allison [Mon, 27 Mar 2006 02:51:25 +0000 (02:51 +0000)]
r14743: Fix coverity bug #227. Possible deref of null pointer
in error code path.
Jeremy.
(This used to be commit 9117713c5ee220331106d291425703aec4d7dd2c)

16 years agor14703: Clarify the return codes for the POSIX locking case. This
Jeremy Allison [Sat, 25 Mar 2006 01:35:43 +0000 (01:35 +0000)]
r14703: Clarify the return codes for the POSIX locking case. This
was confusing.
Jeremy.
(This used to be commit bc1a605a39e58a7dbdcd4d132345e957e3ed9d5e)

16 years agor14699: allow 'net sam addmem' to accept a SID for the member
Gerald Carter [Fri, 24 Mar 2006 23:54:08 +0000 (23:54 +0000)]
r14699: allow 'net sam addmem' to accept a SID for the member
(This used to be commit 08d201806f53f51fbed4a02a54cb0656f8287b12)

16 years agor14698: Make sure we expand our own local groups and not
Gerald Carter [Fri, 24 Mar 2006 22:04:16 +0000 (22:04 +0000)]
r14698: Make sure we expand our own local groups and not
just the BUILTIN group when calling winbindd_getgroups.

$ id foo
uid=502(foo) gid=100(users) groups=100(users),10007(RHEL4\staff),
10001(BUILTIN\users)
(This used to be commit 603b4b501a759510d2ec66cbe5ab1e9f5dc5dbc1)

16 years agor14696: make pdb_find_backend_entry public (for use by an external "multi" pdb backend)
Jelmer Vernooij [Fri, 24 Mar 2006 19:12:04 +0000 (19:12 +0000)]
r14696: make pdb_find_backend_entry public (for use by an external "multi" pdb backend)
(This used to be commit c149421ef7aca8763e21e6c7d467e94944c30e8b)

16 years agor14695: Patch from Björn Jacke:
Volker Lendecke [Fri, 24 Mar 2006 18:40:28 +0000 (18:40 +0000)]
r14695: Patch from Björn Jacke:

- add DMAPI/XDSM support for AIX
- find JFS DMAPI libs on Linux when only they are available

Volker
(This used to be commit b6b72f8c6a03001ae75457c9e7a78e189bea5a3f)

16 years agor14684: Remove obsolete file (belonged to pdb_xml)
Jelmer Vernooij [Thu, 23 Mar 2006 20:19:05 +0000 (20:19 +0000)]
r14684: Remove obsolete file (belonged to pdb_xml)
(This used to be commit 15c36233fb2e5164ea0fbb2389a066e34838dd20)

16 years agor14683: Get rid of hardcoded output file. With no arg, print to stdout,
Jim McDonough [Thu, 23 Mar 2006 18:35:15 +0000 (18:35 +0000)]
r14683: Get rid of hardcoded output file.  With no arg, print to stdout,
otherwise append to output file specified.
(This used to be commit b4ec93f5a26442d30ba2b8c91d03f3190975efd0)

16 years agor14682: Small cleanup in ads_verify_ticket.
Günther Deschner [Thu, 23 Mar 2006 17:32:21 +0000 (17:32 +0000)]
r14682: Small cleanup in ads_verify_ticket.

Guenther
(This used to be commit 90df68634b508b0a58f0a15ab62e9cead85765b6)

16 years agor14681: Get rid of hardcoded /tmp/add.ldif and /tmp/mod.ldif files. Is there a
Jim McDonough [Thu, 23 Mar 2006 16:39:37 +0000 (16:39 +0000)]
r14681: Get rid of hardcoded /tmp/add.ldif and /tmp/mod.ldif files.  Is there a
different directory the temp files should be in, or is /tmp ok?

Still have to get rid of the output file hardcoding, but that is to
come, because I need to cleanup stdout.
(This used to be commit 0d4bd93a5ca4025bbdeb507f4a2d6217cfb39c79)

16 years agor14678: - we need to use 127.0.0.2/8 as interface for the server
Stefan Metzmacher [Thu, 23 Mar 2006 14:55:38 +0000 (14:55 +0000)]
r14678: - we need to use 127.0.0.2/8 as interface for the server
  as nmbd skip interfaces with address 127.0.0.1
- add samba3 smbclient -L tests
- add samba3 smbtorture tests

metze
(This used to be commit 835f8f4339f41619ec890e38569b745c5ef5d44e)

16 years agor14676: add make valgrindtest and remove old 'make check' and old 'make test'
Stefan Metzmacher [Thu, 23 Mar 2006 14:53:10 +0000 (14:53 +0000)]
r14676: add make valgrindtest and remove old 'make check' and old 'make test'

metze
(This used to be commit 789694d12e53ccd327c4a3e4755ef5004503cb4e)

16 years agor14675: Protect against null sids and rids in the cached credentials functions.
Günther Deschner [Thu, 23 Mar 2006 13:22:54 +0000 (13:22 +0000)]
r14675: Protect against null sids and rids in the cached credentials functions.

Guenther
(This used to be commit e162253a32119a31dd652b00f942d4c1a16fab83)

16 years agor14674: Further cleanup for cached logins, only dump hashes with DEBUG_PASSWORD.
Günther Deschner [Thu, 23 Mar 2006 12:50:25 +0000 (12:50 +0000)]
r14674: Further cleanup for cached logins, only dump hashes with DEBUG_PASSWORD.

Guenther
(This used to be commit 24afdda2ae7626b8c0b378d158ede391924d1274)

16 years agor14669: Remove duplicate source caused by running patch(1) once too often.
James Peach [Thu, 23 Mar 2006 00:12:37 +0000 (00:12 +0000)]
r14669: Remove duplicate source caused by running patch(1) once too often.
(This used to be commit 0ebbfc867c71002eaf921f4f4d8aa7d7b78973a7)

16 years agor14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-based
James Peach [Wed, 22 Mar 2006 23:49:09 +0000 (23:49 +0000)]
r14668: Set the FILE_STATUS_OFFLINE bit by observing the events a DMAPI-based
HSM is interested in. Tested on both IRIX and SLES9.
(This used to be commit 514a767c57f8194547e5b708ad2573ab9a0719c6)

16 years agor14664: r13868@cabra: derrell | 2006-03-22 17:04:30 -0500
Derrell Lipman [Wed, 22 Mar 2006 22:05:19 +0000 (22:05 +0000)]
r14664:  r13868@cabra:  derrell | 2006-03-22 17:04:30 -0500
 Implement enhancement request 3505.  Two additional features are added here.
 There is now a method of saving an opaque user data handle in the smbc_
 context, and there is now a way to request that the context be passed to the
 authentication function.  See examples/libsmbclient/testbrowse.c for an example
 of using these features.
(This used to be commit 203b4911c16bd7e10198a6f0e63960f2813025ef)

16 years agor14659: Fix installpammodules for shells where a
Lars Müller [Wed, 22 Mar 2006 20:16:50 +0000 (20:16 +0000)]
r14659: Fix installpammodules for shells where a

   for module in ; do ... ; done

leads to an error (true64, solaris 8).

We now use {,UN}INSTALL_PAM_MODULES to get replaced by configure.
Therfore we don't run into the {,un}installpammodules rule if no PAM
module is requested.

Thanks to Björn Jacke for pointing to this issue.
(This used to be commit 07a70f8f861235ba4037aacb9cc835b6d18f51c3)

16 years agor14646: Adding samr querygroup infolevels 2 & 5.
Günther Deschner [Wed, 22 Mar 2006 15:00:42 +0000 (15:00 +0000)]
r14646: Adding samr querygroup infolevels 2 & 5.

Guenther
(This used to be commit 6c4fe819c69f281915ad0f4c3bde4dfb194aa33a)

16 years agor14645: No idea how this happened, fixing the build.
Günther Deschner [Wed, 22 Mar 2006 14:58:54 +0000 (14:58 +0000)]
r14645: No idea how this happened, fixing the build.

Guenther
(This used to be commit d45b9abb0ec7d943e9fb374d64385d6c540fffe2)

16 years agor14643: Merge dcerpc_errstr from Samba 4.
Günther Deschner [Wed, 22 Mar 2006 14:41:07 +0000 (14:41 +0000)]
r14643: Merge dcerpc_errstr from Samba 4.

Might need to rework prs_dcerpc_status().

Guenther
(This used to be commit 38b18f428ba941f4d9a14fa2de45cb0cd793a754)

16 years agor14634: Many bug fixes thanks to train rides and overnight stays in airports
Gerald Carter [Wed, 22 Mar 2006 08:04:13 +0000 (08:04 +0000)]
r14634: Many bug fixes thanks to train rides and overnight stays in airports

* Finally fix parsing idmap uid/gid ranges not to break with spaces
  surrounding the '-'
* Allow local groups to renamed by adding info level 2 to
  _samr_set_aliasinfo()
* Fix parsing bug in _samr_del_dom_alias() reply
* Prevent root from being deleted via Samba
* Prevent builting groups from being renamed or deleted
* Fix bug in pdb_tdb that broke renaming user accounts
* Make sure winbindd is running when trying to create the Administrators
  and Users BUILTIN groups automatically from smbd (and not just check the
  winbind nexted groups parameter value).
* Have the top level rid allocator verify that the RID it is about to
  grant is not already assigned in our own SAM (retries up to 250 times).
  This fixes passdb with existing SIDs assigned to users from the RID algorithm
  but not monotonically allocating the RIDs from passdb.
(This used to be commit db1162241f79c2af8afb7d8c26e8ed1c4a4b476f)

16 years agor14632: add basic 'make test' using samba4's smbtorture
Stefan Metzmacher [Tue, 21 Mar 2006 22:16:44 +0000 (22:16 +0000)]
r14632: add basic 'make test' using samba4's smbtorture

I'll try to add some tests using samba3's smbtorture and smbclient
later.

can someone check if this would be save to run on the build-farm
without leaking child processes...

metze
(This used to be commit 899fd6808ebd04d039caf7199c60d34a4987b43a)

16 years agor14631: Add {,un}installpammodules rule and add it to the install rule.
Lars Müller [Tue, 21 Mar 2006 21:54:53 +0000 (21:54 +0000)]
r14631: Add {,un}installpammodules rule and add it to the install rule.

Nothing happens if PAM_MODULES is empty which is our default.

The default destination dir is "${LIBDIR}/security".  It's possible to
overwrite the default with --with-pammodulesdir while calling configure.
(This used to be commit 7163c6860549378fa63907048c4eb34fe81835cc)

16 years agor14628: sync timelimit.c with the version from the build-farm repository
Stefan Metzmacher [Tue, 21 Mar 2006 21:25:29 +0000 (21:25 +0000)]
r14628: sync timelimit.c with the version from the build-farm repository

metze
(This used to be commit 1b6a64378553008127a85131fa4139842de4128b)

16 years agor14627: Adapt the linkage text from pam_smbpass to pam_winbind.
Lars Müller [Tue, 21 Mar 2006 19:50:28 +0000 (19:50 +0000)]
r14627: Adapt the linkage text from pam_smbpass to pam_winbind.
(This used to be commit 160626195bf44b94109ddb7a15da703344d8163f)

16 years agor14626: Only set libdir and mandir to the defaults if we haven't used --libdir
Lars Müller [Tue, 21 Mar 2006 16:18:34 +0000 (16:18 +0000)]
r14626: Only set libdir and mandir to the defaults if we haven't used --libdir
or --mandir to set them already.  Till now we overwrrote a setting made
with --libdir or --mandir.
(This used to be commit 94980a15be5eae2820c340d3d33b6c9df7053b24)

16 years agor14624: - add timelimit.c
Stefan Metzmacher [Tue, 21 Mar 2006 15:33:14 +0000 (15:33 +0000)]
r14624: - add timelimit.c
- add configure tests --with-selftest-prefix=/tmp/samba-test
  this is needed because the path name of unix socket can only be 108 chars long
- add configure test --with-smbtorture4-path=/home/foo/prefix/samba4/bin/smbtorture
  this will be used to run samba4's smbtorture inside samba3's make test later

metze
(This used to be commit d9df1853b947c70f747ea30a353162f2985ef250)

16 years agor14618: add --no-process-group to all server programms
Stefan Metzmacher [Tue, 21 Mar 2006 13:16:50 +0000 (13:16 +0000)]
r14618: add --no-process-group to all server programms
to make the following possible:

timelimit 20000 bin/nmbd -F -S --no-process-group
timelimit 20000 bin/smbd -F -S --no-process-group

this is needed to 'make test' working without losing child processes

metze
(This used to be commit c3a9f30e2a12cc852c9fa3a7d161f5c6ee0694ce)

16 years agor14617: Fix typo in comment.
Lars Müller [Tue, 21 Mar 2006 12:32:12 +0000 (12:32 +0000)]
r14617: Fix typo in comment.
(This used to be commit df6d69e78fb0f604a7bfc34fc9ac8f391252520d)

16 years agor14611: Fix init_creds_opts issue jerry discovered when using MIT krb5 1.3:
Günther Deschner [Tue, 21 Mar 2006 11:14:29 +0000 (11:14 +0000)]
r14611: Fix init_creds_opts issue jerry discovered when using MIT krb5 1.3:

We were using a far too short renewable_time in the request; newer MIT
releases take care interally that the renewable time is never shorter
then the default ticket lifetime.

Guenther
(This used to be commit bde4a4018e26bc9aab4b928ec9811c05b21574f3)

16 years agor14602: Fix another logic bug in new oplock handling. Just
Jeremy Allison [Tue, 21 Mar 2006 06:53:49 +0000 (06:53 +0000)]
r14602: Fix another logic bug in new oplock handling. Just
because lck->num_share_modes != 0 doesn't mean that
there *are* other valid share modes. They may be
all marked "UNUSED" or be deferred open entries.
In that case don't downgrade the granted oplock to
level2 needlessly - a client can have an exclusive
oplock in this case. The original code handled this
correctly in the lck->num_share_modes == 0 case but
not in the case where there were no valid share modes
but lck->num_share_modes != 0. I'll clean up my
Samba4 torture tester for this and commit it tomorrow.
Jeremy.
(This used to be commit 306061c93d9181262298516fefd83444f5a65ce5)

16 years agor14600: Refactor capability interface from being IRIX-specific to using only
James Peach [Tue, 21 Mar 2006 02:56:49 +0000 (02:56 +0000)]
r14600: Refactor capability interface from being IRIX-specific to using only
the POSIX interface. Note that this removes support for inherited
capabilities. This wasn't used, and probably should not be.
(This used to be commit 763f4c01488a96aec000c18bca313da37ed1df1b)

16 years agor14597: Merge DCERPC_FAULT constants from Samba 4.
Günther Deschner [Tue, 21 Mar 2006 00:04:05 +0000 (00:04 +0000)]
r14597: Merge DCERPC_FAULT constants from Samba 4.

Guenther
(This used to be commit 3f195f8248c88ec8bf8ceb195575ce6bb49d7fc4)

16 years agor14596: Fix a logic bug with multiple oplock contention.
Jeremy Allison [Mon, 20 Mar 2006 23:40:43 +0000 (23:40 +0000)]
r14596: Fix a logic bug with multiple oplock contention.
The sad thing is the core of this bug fix is just
removing a paranoia "exit_server" call, as the
rest of the logic was already correct :-).

Lots of comments to explain the logic added.

I will look at adding tests to exercise this,
might be possible.

Jeremy.
(This used to be commit c2488db727e1a00f112be7b169de9e6208e311f3)

16 years agor14585: Tighten argument list of kerberos_kinit_password again,
Günther Deschner [Mon, 20 Mar 2006 19:05:44 +0000 (19:05 +0000)]
r14585: Tighten argument list of kerberos_kinit_password again,
kerberos_kinit_password_ext provides access to more options.

Guenther
(This used to be commit afc519530f94b420b305fc28f83c16db671d0d7f)

16 years agor14584: Really follow with roosbindir by defaulr the setting we use for sbindir.
Lars Müller [Mon, 20 Mar 2006 16:40:42 +0000 (16:40 +0000)]
r14584: Really follow with roosbindir by defaulr the setting we use for sbindir.
(This used to be commit 1829d22720612b0e61cec7e66d7cba46c04160b9)

16 years agor14580: add 'net sam createbuiltingroup' to map BUILTIN local groups to a gid
Gerald Carter [Mon, 20 Mar 2006 12:14:07 +0000 (12:14 +0000)]
r14580: add 'net sam createbuiltingroup' to map BUILTIN local groups to a gid
(This used to be commit 3137fe5068e4b0c1724b92f49ca8e1d254324801)

16 years agor14579: Add REJECT_REASON_OTHER in the rpcclient chgpasswd3.
Günther Deschner [Mon, 20 Mar 2006 11:32:08 +0000 (11:32 +0000)]
r14579: Add REJECT_REASON_OTHER in the rpcclient chgpasswd3.

Guenther
(This used to be commit 9de3e9e6b26bebc580b771f9020fc7934e44d51c)

16 years agor14578: fix incorrect comment in fill_sam_account(). This function is called from...
Gerald Carter [Mon, 20 Mar 2006 10:55:48 +0000 (10:55 +0000)]
r14578: fix incorrect comment in fill_sam_account().  This function is called from multiple places now (krb5, winbindd auth and domain_client_validate()
(This used to be commit ddad66ec58d09f89105ceb822b7bea534dafd9e6)

16 years agor14577: BUG Fixes:
Gerald Carter [Mon, 20 Mar 2006 10:18:23 +0000 (10:18 +0000)]
r14577: BUG Fixes:

* Add back in the import/export support to pdbedit
* Fix segv in pam_smbpass
* Cleanup some error paths in pdb_tdb and pdb_interface
(This used to be commit df53d64910fbb96eb810102e986b3c337d54c463)

16 years agor14576: Skip remaining keytab entries when we have a clear indication that
Günther Deschner [Mon, 20 Mar 2006 10:05:51 +0000 (10:05 +0000)]
r14576: Skip remaining keytab entries when we have a clear indication that
krb5_rd_req could decrypt the ticket but that ticket is just not valid
at the moment (either not yet valid or already expired). (This also
prevents an MIT kerberos related crash)

Guenther
(This used to be commit 8a0c1933d3f354a8aff67482b8c7d0d1083e0c8f)

16 years agor14574: Allow use of sendfile as long as the write cache has not been enabled
James Peach [Sun, 19 Mar 2006 23:32:50 +0000 (23:32 +0000)]
r14574: Allow use of sendfile as long as the write cache has not been enabled
on the particular file we are performing I/O on, irrespective of whether
the write cache is globally enabled
(This used to be commit 0809e2cb1dfff1cd0e8631b23b415cb2d8a67312)