samba.git
16 years agor20271: Fix the build
Volker Lendecke [Wed, 20 Dec 2006 07:38:58 +0000 (07:38 +0000)]
r20271: Fix the build
(This used to be commit c703d2ae1f891d35115bb6da0399387a9db2d917)

16 years agor20270: Even with the dual daemon mode the parent winbindd
Jeremy Allison [Wed, 20 Dec 2006 04:50:46 +0000 (04:50 +0000)]
r20270: Even with the dual daemon mode the parent winbindd
still needs to contact the DC's for non async requests
like enumerate users/groups etc. Now that online
DC detection is tied to async events we must enable
the processing of events in the main loop of winbindd.
Finally got rid of the last hard coded domain->initialized = 1
code in init_child_recv() - now all domain->initialized = True
gets done only in the connection manager code when either
we're online and have spoken to the DC or are offline and
we know we can't talk to the DC.
Jeremy.
(This used to be commit b3c98057fbad182f6c05c5daec6cd258dd491064)

16 years agor20269: merge -r20264:20267 from SAMBA_3_0_24
Herb Lewis [Wed, 20 Dec 2006 01:10:04 +0000 (01:10 +0000)]
r20269: merge -r20264:20267 from SAMBA_3_0_24
more no previous prototype warnings
(This used to be commit 41be182f78762372ae13759ede5d2bd40a71d7f5)

16 years agor20268: merge -r 20261:20263 from samba_3_0_24
Herb Lewis [Wed, 20 Dec 2006 01:07:21 +0000 (01:07 +0000)]
r20268: merge -r 20261:20263 from samba_3_0_24
get rid of previous prototype warnings
(This used to be commit 90265c83ff1c7f11672694ff005d8ecc5d4a867f)

16 years agor20264: Two lines above this we just checked if (fsp->is_directory) ...
Volker Lendecke [Tue, 19 Dec 2006 22:13:10 +0000 (22:13 +0000)]
r20264: Two lines above this we just checked if (fsp->is_directory) ...
(This used to be commit 88ab54b3b7ec6c0ac1958fca435880e29eeefd69)

16 years agor20261: merge 20260 from samba_3_0_24
Herb Lewis [Tue, 19 Dec 2006 20:16:52 +0000 (20:16 +0000)]
r20261: merge 20260 from samba_3_0_24
clean up a bunch of no previous prototype warnings
(This used to be commit c60687db112405262adf26dbf267804b04074e67)

16 years agor20257: Hey, change_owner_to_parent is now static :-)
Volker Lendecke [Tue, 19 Dec 2006 18:08:51 +0000 (18:08 +0000)]
r20257: Hey, change_owner_to_parent is now static :-)
(This used to be commit 4090bc4bca77edafcafa52ecb7dc75ead2779cb5)

16 years agor20255: Activate BASE-SAMBA3ERROR in the build farm
Volker Lendecke [Tue, 19 Dec 2006 18:02:24 +0000 (18:02 +0000)]
r20255: Activate BASE-SAMBA3ERROR in the build farm
(This used to be commit 7e0005c14b6852be756dbdacd1412077f2cf57f5)

16 years agor20254: The pam_chauthtok needs to go through the async interface as well.
Günther Deschner [Tue, 19 Dec 2006 17:35:47 +0000 (17:35 +0000)]
r20254: The pam_chauthtok needs to go through the async interface as well.
This fixes pam password changes in the online case.

Guenther
(This used to be commit 2d2de1ac27180756df095c586211fe2e7694b94e)

16 years agor20253: Reduce some code duplication, make reply_mkdir go through the same code paths
Volker Lendecke [Tue, 19 Dec 2006 16:36:54 +0000 (16:36 +0000)]
r20253: Reduce some code duplication, make reply_mkdir go through the same code paths
ncreate does. This is a bit slower (about 10-20%), because it goes touches the
share mode db, but I think not having to call change_owner_to_parent and
friends in fewer places outweighs this. And, mkdir is not the way current
Windows boxes create directories, they do it via the ncreate call.

Volker
(This used to be commit ddae494fbe36e4a74776f71c212b00cce61fbf81)

16 years agor20252: Revert back to const, but I have a fleble feeling we should go the ther way.
Simo Sorce [Tue, 19 Dec 2006 14:01:05 +0000 (14:01 +0000)]
r20252: Revert back to const, but I have a fleble feeling we should go the ther way.
(This used to be commit 2048d491507cef1ac87da4fd2fedc458aae5a97d)

16 years agor20250: If we've come from being globally offline we
Jeremy Allison [Tue, 19 Dec 2006 00:48:39 +0000 (00:48 +0000)]
r20250: If we've come from being globally offline we
don't have a check online event handler set.
We need to add one once we're been asked to
go back online as this is the only way to actually
go into the online state. Doh ! :-).
Jeremy.
(This used to be commit 5d36c4e0313c2d735242dfdd57343372be59c6e1)

16 years agor20249: Fail when parsing invalid options in _pam_parse.
Günther Deschner [Mon, 18 Dec 2006 22:10:09 +0000 (22:10 +0000)]
r20249: Fail when parsing invalid options in _pam_parse.

Guenther
(This used to be commit f6c9421abdf5731e894cd2ccc1b7431a3c368bbf)

16 years agor20248: merge 20247 from samba_3_0_24
Herb Lewis [Mon, 18 Dec 2006 22:01:39 +0000 (22:01 +0000)]
r20248: merge 20247 from samba_3_0_24
get rid of warning: value computed is not used
(This used to be commit ebe16589cb6c45524b90abe5f9be5e4affa1598e)

16 years agor20245: merge 20244 from samba_3_0_24
Herb Lewis [Mon, 18 Dec 2006 20:37:26 +0000 (20:37 +0000)]
r20245: merge 20244 from samba_3_0_24
get rid of more nested extern declarations warnings
(This used to be commit e9df051f5201843e3428ddbed7a719553c2e799a)

16 years agor20243: Make lookup_name resolve both the mapped and the real unix group name
Simo Sorce [Mon, 18 Dec 2006 20:05:50 +0000 (20:05 +0000)]
r20243: Make lookup_name resolve both the mapped and the real unix group name
(This used to be commit 7167e7b26ac6a742cc82f4edacfc8579f80338d9)

16 years agor20242: these are not really const as we set them in the function
Simo Sorce [Mon, 18 Dec 2006 20:04:54 +0000 (20:04 +0000)]
r20242: these are not really const as we set them in the function
(This used to be commit 6a0260fb04f4f9066cbc9eea495141ab3f515b47)

16 years agor20241: Slightly improve readability of the pam_vsyslog replacement function.
Günther Deschner [Mon, 18 Dec 2006 15:35:52 +0000 (15:35 +0000)]
r20241: Slightly improve readability of the pam_vsyslog replacement function.

Guenther
(This used to be commit 222320373f8a251fc2cf3ff8c3fec93a7a48f9df)

16 years agor20240: Be a little more verbose about the credential flags when the debug flag
Günther Deschner [Mon, 18 Dec 2006 15:33:57 +0000 (15:33 +0000)]
r20240: Be a little more verbose about the credential flags when the debug flag
is set.

Guenther
(This used to be commit ecbab58826a51ace2a0d1181a41391f5d170ff06)

16 years agor20239: Parse the configfile for pam_sm_setcred as well
Günther Deschner [Mon, 18 Dec 2006 15:29:05 +0000 (15:29 +0000)]
r20239: Parse the configfile for pam_sm_setcred as well
(e.g. to get the debug flag)

Guenther
(This used to be commit 2c549f71f15b066ac1f415544848b582558abd5d)

16 years agor20237: Replace exit_server with exit_server_cleanly where appropriate. All
James Peach [Mon, 18 Dec 2006 04:25:21 +0000 (04:25 +0000)]
r20237: Replace exit_server with exit_server_cleanly where appropriate. All
send_smb failures should be clean exits. All times when we exit as
a matter of policy should also be clean exits.
(This used to be commit d6382092e72120a3c89ffe81975e8898d454bf06)

16 years agor20235: Don't use realloc directly.
James Peach [Mon, 18 Dec 2006 01:59:42 +0000 (01:59 +0000)]
r20235: Don't use realloc directly.
(This used to be commit 91e90f3bc4954e3d405589d947c8fe122d90e6db)

16 years agor20229: Avoid a silly function call in mkdir_internal. None of the callers look at
Volker Lendecke [Sun, 17 Dec 2006 18:41:44 +0000 (18:41 +0000)]
r20229: Avoid a silly function call in mkdir_internal. None of the callers look at
errno, all go straight to ERROR_NT(status).

Volker
(This used to be commit 9d8b48c0ef0af5792b879565915832ee141c853c)

16 years agor20228: Bring the calling conventions of inherit_access_acl and change_owner_to_parent
Volker Lendecke [Sun, 17 Dec 2006 18:30:44 +0000 (18:30 +0000)]
r20228: Bring the calling conventions of inherit_access_acl and change_owner_to_parent
a bit closer together: Move the lp_inherit_perms() check into the callers.

Volker
(This used to be commit 0874093e5fff480d8ec442072318525079add633)

16 years agor20227: Simplify logic in vfs_MkDir() a bit
Volker Lendecke [Sun, 17 Dec 2006 18:10:15 +0000 (18:10 +0000)]
r20227: Simplify logic in vfs_MkDir() a bit
(This used to be commit b24cf79e9ec914ac33f1a20524e5ffa7fe1cba5e)

16 years agor20218: Same fix as r20217 -- can we consolidate that duplicated code a bit?
Volker Lendecke [Sat, 16 Dec 2006 18:41:22 +0000 (18:41 +0000)]
r20218: Same fix as r20217 -- can we consolidate that duplicated code a bit?
(This used to be commit fdb310f57932ac3b3fd09721e6b6494b30ad57af)

16 years agor20217: uid_t and gid_t are not necessarily 32 bit. In assignments we get an automatic
Volker Lendecke [Sat, 16 Dec 2006 18:37:33 +0000 (18:37 +0000)]
r20217: uid_t and gid_t are not necessarily 32 bit. In assignments we get an automatic
conversion, but not when we pass pointers down to other functions.

Simo, please check.

Volker
(This used to be commit 04845f600b2ac9a129b3ecdb1e9060a5d8502830)

16 years agor20216: Fix fallback code.
Simo Sorce [Sat, 16 Dec 2006 18:13:12 +0000 (18:13 +0000)]
r20216: Fix fallback code.
A reversed check made it impossile to fallback to the Unix Domain mapping code.
Also fix a potential use of a freed array.

Jerry,
my tests shows that this code now correctly handle the fallback to Unix Domain
when our Domain member is asked for a mapped group that has a unix name different
from the Windows name against a Samba DC and we do not use winbindd but share
users/groups by other means (ldap / sync of passwd and group files)

Immediate Fix would be to discuss if we should answer back when DOMAIN\unixgroup -> SID
is asked for, in the case the unixgroup name is mapped to a different name.
IE: DOMAIN\Domain Admins -> ntadmins

Currently if we are asked for "DOMAIN\Domain Admins" we return the dom admins SID
If we are asked for "DOMAIN\ntadmins we return "not found", but we may consider to
return the Domain admins SID in this case too.

Comments are welcome on this point!

Long term fix I think is the unixinfo pipe and of course an idmap_unixinfo moudle.

Simo.
(This used to be commit 07bdbb4c215461a721f9b608bd375387b96ababb)

16 years agor20215: Next step trying to fix the Solaris build.
Volker Lendecke [Sat, 16 Dec 2006 17:54:16 +0000 (17:54 +0000)]
r20215: Next step trying to fix the Solaris build.

I think "anonimous" is correctly spelled "anonymous". The Solaris compile is
referring to this as "anonymous" in line 814 of smbldap.c. Simo, please check.

Thanks,

Volker
(This used to be commit a77d8fa08e5a7c9c0c7c415ce3b7848b265b4b95)

16 years agor20214: Fix a type-punned warning. Simo, Jerry, please check
Volker Lendecke [Sat, 16 Dec 2006 17:47:22 +0000 (17:47 +0000)]
r20214: Fix a type-punned warning. Simo, Jerry, please check
(This used to be commit b459096a151c482d387ec14c965aee43c850e46a)

16 years agor20212: Attempt to fix the Solaris build
Volker Lendecke [Sat, 16 Dec 2006 11:15:03 +0000 (11:15 +0000)]
r20212: Attempt to fix the Solaris build
(This used to be commit 902d81becbd5eac7251e88457be7efc5e951614f)

16 years agor20211: send_nt_replies does not need the inbuf arg
Volker Lendecke [Sat, 16 Dec 2006 10:36:25 +0000 (10:36 +0000)]
r20211: send_nt_replies does not need the inbuf arg
(This used to be commit ab45c50da36be316773f9332925dee7dc3eec025)

16 years agor20210: registry_fetch_values is not needed anymore, fix typo
Volker Lendecke [Sat, 16 Dec 2006 09:36:10 +0000 (09:36 +0000)]
r20210: registry_fetch_values is not needed anymore, fix typo
(This used to be commit 77e556f4a358fec0d754e50417097bf5a874c500)

16 years agor20209: Fix two memleaks
Volker Lendecke [Sat, 16 Dec 2006 09:33:17 +0000 (09:33 +0000)]
r20209: Fix two memleaks
(This used to be commit 92bc870768a2ff839b3b10897a4f09a3ece92704)

16 years agor20208: Change sprintf_append() never to use malloc,
Jeremy Allison [Sat, 16 Dec 2006 05:02:21 +0000 (05:02 +0000)]
r20208: Change sprintf_append() never to use malloc,
but always use a talloc context.
Thanks to simo for pointing this out.
Jeremy.
(This used to be commit 437cb7c88833d7eab0e3c3dcf175860df74a7a38)

16 years agor20207: Fix a couple more places where extra_data was
Jeremy Allison [Sat, 16 Dec 2006 01:52:06 +0000 (01:52 +0000)]
r20207: Fix a couple more places where extra_data was
being talloc'ed off the NULL context instead
of being malloced.
Jeremy.
(This used to be commit 47bdeb4efeaa5a441ad2d39bb3b94d72263e66e4)

16 years agor20206: Start cleaning up the talloc_ctx mess.
Jeremy Allison [Sat, 16 Dec 2006 01:32:57 +0000 (01:32 +0000)]
r20206: Start cleaning up the talloc_ctx mess.
child->mem_ctx isn't actually used for
anything, so remove it.
Jeremy.
(This used to be commit a7f294b59238826c11e579a7b1a4dca7284bb89d)

16 years agor20202: fix make clean
Herb Lewis [Sat, 16 Dec 2006 00:51:15 +0000 (00:51 +0000)]
r20202: fix make clean
(This used to be commit 339c029521fad391370b99b3b956214608777f32)

16 years agor20201: merge makefile changes from 3_0_24
Herb Lewis [Sat, 16 Dec 2006 00:25:34 +0000 (00:25 +0000)]
r20201: merge makefile changes from 3_0_24
(This used to be commit 3f8587fc6deb42b5289b5340a6735b1b50b471de)

16 years agor20197: merge talloc fixes from samba4:
Stefan Metzmacher [Fri, 15 Dec 2006 22:58:06 +0000 (22:58 +0000)]
r20197: merge talloc fixes from samba4:

- make most static functions inline
- handle NULL pointers in talloc_parent_chunk()
- use talloc_parent_chunk() in talloc_parent_name()
  to fix a bug found by the IBM checker

metze
(This used to be commit c718eb7a7c3cdc4acb25f303a73a3ca478c27af0)

16 years agor20186: Fix winbind crash bug in WINBIND_GETGROUPS.
Günther Deschner [Fri, 15 Dec 2006 16:45:39 +0000 (16:45 +0000)]
r20186: Fix winbind crash bug in WINBIND_GETGROUPS.

response_extra_sent() expects to free a malloced
extra_data.data while the add_XX_to_array functions all return talloced
memory now. Jeremy, please check.

Guenther
(This used to be commit 9f34c9f3695757819d728a17a1497247ea479ebf)

16 years agor20183: Fix the build.
Günther Deschner [Fri, 15 Dec 2006 12:35:20 +0000 (12:35 +0000)]
r20183: Fix the build.

Guenther
(This used to be commit fe3ed63d29e7a68413bffc11d634b61a664ed1a2)

16 years agor20181: Improve NT status to pam error mapping.
Jeremy Allison [Fri, 15 Dec 2006 06:44:16 +0000 (06:44 +0000)]
r20181: Improve NT status to pam error mapping.
Jeremy.
(This used to be commit 794ebd8a84115a636d8fa4a9f859f8a999135e5e)

16 years agor20180: Ensure that pam returns the correct error messages
Jeremy Allison [Fri, 15 Dec 2006 06:06:15 +0000 (06:06 +0000)]
r20180: Ensure that pam returns the correct error messages
when offline and or doing password changes.
Jeremy.
(This used to be commit 4a74c553845c960a355ddb86abaadfe0d550271f)

16 years agor20179: Sync up with Samba4 - remove blank lines at the
Jeremy Allison [Fri, 15 Dec 2006 01:50:04 +0000 (01:50 +0000)]
r20179: Sync up with Samba4 - remove blank lines at the
end parsing a file.
Jeremy.
(This used to be commit ea8215935e5f3952a4480c1f7dafafa9458f66a9)

16 years agor20178: Ensure we allocate the intermediate trans structs
Jeremy Allison [Fri, 15 Dec 2006 00:49:12 +0000 (00:49 +0000)]
r20178: Ensure we allocate the intermediate trans structs
off conn->mem_ctx, not the null context so we can
safefy free everything on conn close. Should fix
possible memleak.
Jeremy.
(This used to be commit b33bde7b39953e171f05cdb53b6345ee3a9ec6e7)

16 years agor20174: If we're only going to call one handler per message
Jeremy Allison [Thu, 14 Dec 2006 22:11:17 +0000 (22:11 +0000)]
r20174: If we're only going to call one handler per message
then terminate the traversal once we've done that.
Jeremy.
(This used to be commit da3d0b62340b545950ea2081f30c252fd4609981)

16 years agor20173: DNS update fixes:
Gerald Carter [Thu, 14 Dec 2006 17:00:10 +0000 (17:00 +0000)]
r20173: DNS update fixes:

* Fix DNS updates for multi-homed hosts
* Child domains often don't have an NS record in
  DNS so we have to fall back to looking up the the NS
  records for the forest root.
* Fix compile warning caused by mismatched 'struct in_addr'
  and 'in_addr_t' parameters called to DoDNSUpdate()
(This used to be commit 3486acd3c3ebefae8f98dcc72d1c3d6b06fffcc7)

16 years agor20171: Don't delete the krb5 credential if others still reference to it.
Günther Deschner [Thu, 14 Dec 2006 16:34:24 +0000 (16:34 +0000)]
r20171: Don't delete the krb5 credential if others still reference to it.

Guenther
(This used to be commit a1378979be4fe5ac5148b0a7830859aebb97838c)

16 years agor20170: Fix secure DNS updates to work against
Gerald Carter [Thu, 14 Dec 2006 16:27:45 +0000 (16:27 +0000)]
r20170: Fix secure DNS updates to work against
Wnidows 2000 DNS which expects the TKEY payload to
be in the answer section and not in the additional
set of records (like Windows 2003 and the RFC).
(This used to be commit a3b6734fdad5fd92dbec075ebcd8d7044aac45c2)

16 years agor20169: Support for fallback to legacy mapping code was not completely tested.
Simo Sorce [Thu, 14 Dec 2006 15:30:54 +0000 (15:30 +0000)]
r20169: Support for fallback to legacy mapping code was not completely tested.
Add necessary fixes.
(This used to be commit 4a81ee9608d45f95eaaccc78a080e717cb7d4682)

16 years agor20165: Change messaging subsystem to only allow one message
Jeremy Allison [Thu, 14 Dec 2006 01:00:16 +0000 (01:00 +0000)]
r20165: Change messaging subsystem to only allow one message
per type - this is all we use right now and makes
re-entrancy problems with deleting handlers with
a message dispatch loop go away.
Jeremy.
(This used to be commit 2e9b6faeae1474d65a5c12f5a19b0ae045d47c2e)

16 years agor20160: Fix long-standing (ie. from initial code I think) bug
Jeremy Allison [Wed, 13 Dec 2006 22:19:10 +0000 (22:19 +0000)]
r20160: Fix long-standing (ie. from initial code I think) bug
in tdb message processing. If we're inside a dispatch
function and we delete our own handler we'd walk onto
the next pointer from a deleted memory block. Fixes
crash bug in winbindd (and goodness knows where else).
Jeremy.
(This used to be commit 27a4c1121404e346432d90b97b518861e038e9f2)

16 years agor20155: revert, I misread
Simo Sorce [Wed, 13 Dec 2006 21:05:47 +0000 (21:05 +0000)]
r20155: revert, I misread
(This used to be commit 20aa6322efe617f928c5cf2224a7660ca6525297)

16 years agor20154: Fix nasty typo, hunting another bug
Simo Sorce [Wed, 13 Dec 2006 21:03:38 +0000 (21:03 +0000)]
r20154: Fix nasty typo, hunting another bug
(This used to be commit bf8dc44cc2892a784ec3a118abc0abb1018fbde4)

16 years agor20151: remove meaningless checks
Simo Sorce [Wed, 13 Dec 2006 18:29:00 +0000 (18:29 +0000)]
r20151: remove meaningless checks
(This used to be commit 33a55f0cfc0c5eb3f3cfa8276fa258349ad42f8d)

16 years agor20150: better memory handling for some functions, make sure we don't
Simo Sorce [Wed, 13 Dec 2006 16:39:50 +0000 (16:39 +0000)]
r20150: better memory handling for some functions, make sure we don't
leak memory by using the wrong(long lived)  mem context
(This used to be commit a28cdd6e742cb72a728bd337546ee95fd4160ed8)

16 years agor20148: Forgot to merge. Ensure open_any_socket_out()
Jeremy Allison [Wed, 13 Dec 2006 05:54:39 +0000 (05:54 +0000)]
r20148: Forgot to merge. Ensure open_any_socket_out()
is safe from signals.
Jeremy.
(This used to be commit c264a0aa4a83a3d47db33446b16a8766bc14824f)

16 years agor20146: Now online checks are fully async we can do them
Jeremy Allison [Wed, 13 Dec 2006 01:11:29 +0000 (01:11 +0000)]
r20146: Now online checks are fully async we can do them
every cache timeout times.
Jeremy.
(This used to be commit 5d364bc5ccc45b8d7bf3e484d16b37ac9e06b5cf)

16 years agor20140: Make online/offline detection completely asynchronous.
Jeremy Allison [Tue, 12 Dec 2006 22:41:42 +0000 (22:41 +0000)]
r20140: Make online/offline detection completely asynchronous.
Now I've done this I might be able to reduce the probe
timeout and reduce the backoff algorithm, going back
to checking every cache time seconds (5 mins by default),
as the parent or forked domain child will never block.
Jeremy.
(This used to be commit d0add5f946cf63ea43067e8e935876b5346d11de)

16 years agor20136: Fix #4290. Properly compute time to password expiration in message from
Jim McDonough [Tue, 12 Dec 2006 22:05:48 +0000 (22:05 +0000)]
r20136: Fix #4290.  Properly compute time to password expiration in message from
pam_winbind.  Thanks to Andrew Benham <andrew.benham@thus.net>
(This used to be commit 0d03f5137936546253a8b3334995f536f3621d57)

16 years agor20133: get rid of defined but not used warning - static function only used
Herb Lewis [Tue, 12 Dec 2006 20:30:31 +0000 (20:30 +0000)]
r20133: get rid of defined but not used warning - static function only used
inside the #ifdef HAVE_NATIVE_ICONV
(This used to be commit 43ab1d2ba5eb24fc22f8d53c650bf39e95fb133b)

16 years agor20132: get rid of defined but not used warning - static function only used
Herb Lewis [Tue, 12 Dec 2006 20:27:01 +0000 (20:27 +0000)]
r20132: get rid of defined but not used warning - static function only used
inside the #ifdef HAVE_KRB5
(This used to be commit c6cdf76c5809b4a4b145acb7dd4a695aaf7fcd28)

16 years agor20131: get rid of a few no previous prototype warnings
Herb Lewis [Tue, 12 Dec 2006 20:15:47 +0000 (20:15 +0000)]
r20131: get rid of a few no previous prototype warnings
(This used to be commit e710a7d39a662a1a339f3f71c4b051fde1bb5a16)

16 years agor20124: clean up nested extern declaration warnings
Herb Lewis [Tue, 12 Dec 2006 17:38:42 +0000 (17:38 +0000)]
r20124: clean up nested extern declaration warnings
(This used to be commit ac3eb7813e33b9a2e78c9158433f7ed62c3b62bb)

16 years agor20119: Update help info indicating how to use separators (forward slash only)
Jim McDonough [Tue, 12 Dec 2006 16:40:57 +0000 (16:40 +0000)]
r20119: Update help info indicating how to use separators (forward slash only)
and properly use backslashes in "net ads join computername="
(This used to be commit cc26e2f9a155529b8ac2122bd2bec401bb516264)

16 years agor20118: Fix some more warnings
Simo Sorce [Tue, 12 Dec 2006 15:16:26 +0000 (15:16 +0000)]
r20118: Fix some more warnings
(This used to be commit b6db21ff65139f45a1789105241e4018b61ca472)

16 years agor20117: 1st Error in the merge
Simo Sorce [Tue, 12 Dec 2006 15:14:27 +0000 (15:14 +0000)]
r20117: 1st Error in the merge
(This used to be commit 5e46c43a2e4b9a3ee8f1f219c96a6b132bb09322)

16 years agor20116: Start merging in the work done to create the new idmap subsystem.
Simo Sorce [Tue, 12 Dec 2006 14:52:13 +0000 (14:52 +0000)]
r20116: Start merging in the work done to create the new idmap subsystem.

Simo.
(This used to be commit 50cd8bffeeed2cac755f75fc3d76fe41c451976b)

16 years agor20110: Fix interaction between paranoid malloc checker
Jeremy Allison [Mon, 11 Dec 2006 18:56:36 +0000 (18:56 +0000)]
r20110: Fix interaction between paranoid malloc checker
and lib/replace. Found by Herb - thanks !
Jeremy.
(This used to be commit 67c4d5e73fe066910f7b1ca4624541a9bbbf7750)

16 years agor20098: Properly fix issues with create_token_from_username()
Jeremy Allison [Sun, 10 Dec 2006 05:23:47 +0000 (05:23 +0000)]
r20098: Properly fix issues with create_token_from_username()
reported by James. Ensure that this function allocates
everything on the temporary context except the return
memory. Never call this with a null mem context, and
now use conn->mem_ctx instead in smbd/service.c.
Remove separate free functions for conn->ngroups
and conn->nt_user_token as they are now always
talloc'ed off the conn->mem_ctx. Future optimization
will be to remove conn->mem_ctx and make all objects
pointed to in the conn struct talloc'ed off conn itself.
Easy to free then :-).
Jeremy.
(This used to be commit f83b6de44f1058811ff94ac72a8a71bd8e49e4e8)

16 years agor20097: Ensure found_username is freed correctly when
Jeremy Allison [Sat, 9 Dec 2006 23:55:20 +0000 (23:55 +0000)]
r20097: Ensure found_username is freed correctly when
talloced on the null context.
Jeremy.
(This used to be commit 2c59c4dddceb9cb12848d7ee48257c5e93ea2667)

16 years agor20090: Fix a class of bugs found by James Peach. Ensure
Jeremy Allison [Sat, 9 Dec 2006 02:58:18 +0000 (02:58 +0000)]
r20090: Fix a class of bugs found by James Peach. Ensure
we never mix malloc and talloc'ed contexts in the
add_XX_to_array() and add_XX_to_array_unique()
calls. Ensure that these calls always return
False on out of memory, True otherwise and always
check them. Ensure that the relevent parts of
the conn struct and the nt_user_tokens are
TALLOC_DESTROYED not SAFE_FREE'd.
James - this should fix your crash bug in both
branches.
Jeremy.
(This used to be commit 0ffca7559e07500bd09a64b775e230d448ce5c24)

16 years agor20089: Put gpfs acl function into vfs_gpfs module. Thanks to Gomati Mohanan
Jim McDonough [Fri, 8 Dec 2006 18:56:01 +0000 (18:56 +0000)]
r20089: Put gpfs acl function into vfs_gpfs module.  Thanks to Gomati Mohanan
<gomati.mohanan@in.ibm.com>.

Also fix fields for sec_desc differences between 3.0 and 3.0.24 in
nfs4_acls.c.
(This used to be commit 3d6f387783467bbd7ea88d6a853b41572badf1ef)

16 years agor20087: Ensure we clean up any random pending events we
Jeremy Allison [Fri, 8 Dec 2006 18:40:13 +0000 (18:40 +0000)]
r20087: Ensure we clean up any random pending events we
may have inherited from our parent in the winbindd
forked child.
Jeremy.
(This used to be commit 0a1352f440a9d9b974ad8d571b2e48a43a15b6cc)

16 years agor20082: When fork_domain_child is forked when we're offline
Jeremy Allison [Fri, 8 Dec 2006 18:07:44 +0000 (18:07 +0000)]
r20082: When fork_domain_child is forked when we're offline
the child inherits *all* active check_online timout handlers.
This is bad when it's not our domain (ie. BUILTIN).
Jeremy.
(This used to be commit 8d815ec4c103a83ef7cea0ae5fc64681f6bcb48a)

16 years agor20069: Fix logic bug I introduced
Volker Lendecke [Thu, 7 Dec 2006 19:21:37 +0000 (19:21 +0000)]
r20069: Fix logic bug I introduced
(This used to be commit d935ecec98747dfd9f35ab81760ef95a0d983ed7)

16 years agor20063: Fix a missing protoype warning in freelistcheck.c
Volker Lendecke [Thu, 7 Dec 2006 10:49:17 +0000 (10:49 +0000)]
r20063: Fix a missing protoype warning in freelistcheck.c
(This used to be commit 2fdfc54e7eebc68c81ad5f3fa8d0607bd3b579c5)

16 years agor20060: Fix the timout calculation.
Jeremy Allison [Thu, 7 Dec 2006 05:48:01 +0000 (05:48 +0000)]
r20060: Fix the timout calculation.
Jeremy.
(This used to be commit 017be792f3c41aba2cbda10b53d80aad91c5d666)

16 years agor20058: Ensure we actually do the increasing time
Jeremy Allison [Thu, 7 Dec 2006 00:08:10 +0000 (00:08 +0000)]
r20058: Ensure we actually do the increasing time
calculation when in offline mode.
Jeremy.
(This used to be commit b7dc67ab2a78aba8dc8324430798ef56325d3cd6)

16 years agor20057: Attempt to fix connect timeouts when connected on
Jeremy Allison [Wed, 6 Dec 2006 23:14:15 +0000 (23:14 +0000)]
r20057: Attempt to fix connect timeouts when connected on
a network but not one on which any home DC's can
be found (hotel network problem). Still testing
but this is getting close.
Jeremy.
(This used to be commit 369c9e4138b93f7cfb6680f0beb541f58554e856)

16 years agor20054: Revert my changes, Simo promised to work on it :-)
Volker Lendecke [Wed, 6 Dec 2006 14:40:47 +0000 (14:40 +0000)]
r20054: Revert my changes, Simo promised to work on it :-)
(This used to be commit 4b5cf0c9cffe9903c86ac7e8b41c303fdbde5bac)

16 years agor20050: Remove a bogus NULL check, LTDB_OBJECTCLASS is a static string
Volker Lendecke [Wed, 6 Dec 2006 11:45:33 +0000 (11:45 +0000)]
r20050: Remove a bogus NULL check, LTDB_OBJECTCLASS is a static string
(This used to be commit f64866a43fbc21666e919cafdf3002a8e43c60af)

16 years agor20049: Reformatting
Volker Lendecke [Wed, 6 Dec 2006 11:01:27 +0000 (11:01 +0000)]
r20049: Reformatting
(This used to be commit 75555ae1c8039b7bbca796dd16609de08230265a)

16 years agor20048: Fix vfs_full_audit after Jims kernel_flock addition
Volker Lendecke [Wed, 6 Dec 2006 10:21:20 +0000 (10:21 +0000)]
r20048: Fix vfs_full_audit after Jims kernel_flock addition
(This used to be commit 4fe19e741fcb384f0cec59d3ec742d5bd173d41f)

16 years agor20046: Add ldb_search_exp_fmt and port comment to 4
Volker Lendecke [Tue, 5 Dec 2006 16:20:39 +0000 (16:20 +0000)]
r20046: Add ldb_search_exp_fmt and port comment to 4
(This used to be commit 1fe41c96f53b0d83e8779050e2149a5e70b5dad0)

16 years agor20037: Reduce code size slightly by shuffling stuff around
Volker Lendecke [Tue, 5 Dec 2006 07:36:14 +0000 (07:36 +0000)]
r20037: Reduce code size slightly by shuffling stuff around
(This used to be commit 0742faaacd496f9cc4581a1fad74217024383661)

16 years agor20036: Merge ldb_search_exp_fmt -- Thanks simo
Volker Lendecke [Tue, 5 Dec 2006 06:25:12 +0000 (06:25 +0000)]
r20036: Merge ldb_search_exp_fmt -- Thanks simo
(This used to be commit fa6fa1268b33334d17869d0f096cf7600e88f993)

16 years agor20035: Fix obvious horrible bug in falling back to MS-RPC
Jeremy Allison [Tue, 5 Dec 2006 06:15:23 +0000 (06:15 +0000)]
r20035: Fix obvious horrible bug in falling back to MS-RPC
methods.
Jeremy.
(This used to be commit 7ac4ae4b517a18e97673e95d862a5b18175252c1)

16 years agor20020: Arglll... eventlogadm links against reg_db but not the rest of the registry
Volker Lendecke [Sun, 3 Dec 2006 17:34:11 +0000 (17:34 +0000)]
r20020: Arglll... eventlogadm links against reg_db but not the rest of the registry
stuff. Revert the last change.

This needs better fixing.

Volker
(This used to be commit ad1e00430bf5c4130023d30e9c8266ecdc640d2b)

16 years agor20019: Replace one set of tricky code by calls to another set of tricky code:
Volker Lendecke [Sun, 3 Dec 2006 17:16:45 +0000 (17:16 +0000)]
r20019: Replace one set of tricky code by calls to another set of tricky code:
Initializing the reg_db now uses reg_createkey and reg_setvalue.

Volker
(This used to be commit cab5ccbbe484795f13531726d68b978073262e33)

16 years agor20018: Fix a memleak in reg_createkey
Volker Lendecke [Sun, 3 Dec 2006 16:51:31 +0000 (16:51 +0000)]
r20018: Fix a memleak in reg_createkey
(This used to be commit 281640823bfe25f513f44f6c6d7022a11b957fa5)

16 years agor20017: Make srvsvc_NetShareAdd & friends take care of registry shares
Volker Lendecke [Sun, 3 Dec 2006 16:19:29 +0000 (16:19 +0000)]
r20017: Make srvsvc_NetShareAdd & friends take care of registry shares
(This used to be commit fc29a283cc9c2458375aa4fe2ecef82e6a3847df)

16 years agor20016: Add two utility functions for easy opening/creating registry keys
Volker Lendecke [Sun, 3 Dec 2006 16:19:15 +0000 (16:19 +0000)]
r20016: Add two utility functions for easy opening/creating registry keys
(This used to be commit ad22a467185e871d893e8133741b525889c2aa6f)

16 years agor20015: We have to zero out handle on key_close, otherwise the NT4 regedit will re...
Volker Lendecke [Sun, 3 Dec 2006 16:18:31 +0000 (16:18 +0000)]
r20015: We have to zero out handle on key_close, otherwise the NT4 regedit will re-use the handle
(This used to be commit 0afd696f88ed04f562ef64201ac2e58cef372a90)

16 years agor20014: Ouch.... "res" is not a flag here, it is the service number...
Volker Lendecke [Sun, 3 Dec 2006 15:34:52 +0000 (15:34 +0000)]
r20014: Ouch.... "res" is not a flag here, it is the service number...
(This used to be commit a4862f48d085d1f518389f86a410722e91449755)

16 years agor20013: Fix segfaults: parm_error is a unique in/out ptr
Volker Lendecke [Sun, 3 Dec 2006 10:09:37 +0000 (10:09 +0000)]
r20013: Fix segfaults: parm_error is a unique in/out ptr
(This used to be commit 0104371dd648204c9e8102cdc399539857be4a63)

16 years agor20012: Reformatting
Volker Lendecke [Sat, 2 Dec 2006 23:01:34 +0000 (23:01 +0000)]
r20012: Reformatting
(This used to be commit b32c65cb6243f939247bcfb0f14e4e49dc5ee13e)

16 years agor20007: Fix a const warning just introduced
Volker Lendecke [Sat, 2 Dec 2006 11:18:19 +0000 (11:18 +0000)]
r20007: Fix a const warning just introduced
(This used to be commit 3da37287cadfe251491bcefea4ca9d407048868b)

16 years agor20006: Convert the registry shares to use the new API
Volker Lendecke [Sat, 2 Dec 2006 10:53:00 +0000 (10:53 +0000)]
r20006: Convert the registry shares to use the new API
(This used to be commit 66e889bbabde6dfd05df46937635a6d3e606cb27)