samba.git
13 years agor4244: add more calls to pvfs_xattr_unlink_hook() on file/dir create, to try to beat...
Andrew Tridgell [Fri, 17 Dec 2004 05:03:57 +0000 (05:03 +0000)]
r4244: add more calls to pvfs_xattr_unlink_hook() on file/dir create, to try to beat race
conditions in the tdb xattr backend
(This used to be commit 3ac840159881ce6eeac27ff0dc324e4d6ac0a70a)

13 years agor4243: a sniff from kukks showed that the ea_set interface in trans2 setfileinfo...
Andrew Tridgell [Fri, 17 Dec 2004 04:51:23 +0000 (04:51 +0000)]
r4243: a sniff from kukks showed that the ea_set interface in trans2 setfileinfo allows
for multiple EAs to be set at once. This fixes all the ea code to allow for that.
(This used to be commit b26828bef5d55e5eef0e34a164e76292df45e207)

13 years agor4242: added support for storing xattrs in a tdb. This allows all advanced NT
Andrew Tridgell [Fri, 17 Dec 2004 03:39:29 +0000 (03:39 +0000)]
r4242: added support for storing xattrs in a tdb. This allows all advanced NT
attributes (streams, EAs, NT ACLs, timestamps etc) to be used on
filesystems that don't support xattrs. It also allows for large
streams, although they are very inefficient.

I won't enable this by default, as I really wrote it as a way of
testing large stream support while still using ext3, but perhaps with
a bit more work this could be generally usable.

To enable this use:

   posix:eadb = /home/test/myeas.tdb
(This used to be commit 0c927d912cb65754351189d3a0442004a14aa5c6)

13 years agor4232: added server support for multi-part SMBtrans requests, while
Andrew Tridgell [Thu, 16 Dec 2004 12:31:34 +0000 (12:31 +0000)]
r4232: added server support for multi-part SMBtrans requests, while
maintaining the async nature of the server. This is done with a
SMBtrans request queue for partially completed requests.

The smb signing issues with this get a little tricky, but it now seems
to work fine
(This used to be commit bc0209058b76a947ad27673aeb096d11a168996b)

13 years agor4230: now that we set the FLAGS2_EXTENDED_ATTRIBUTES flag, we should mark
Andrew Tridgell [Thu, 16 Dec 2004 12:29:47 +0000 (12:29 +0000)]
r4230: now that we set the FLAGS2_EXTENDED_ATTRIBUTES flag, we should mark
empty EAs as being of size 4, not size 0
(This used to be commit 76bd6476785e4145437768caa702c01a7801590e)

13 years agor4229: - added support for multi-part SMBtrans and SMBtrans2 requests in the
Andrew Tridgell [Thu, 16 Dec 2004 12:29:04 +0000 (12:29 +0000)]
r4229: - added support for multi-part SMBtrans and SMBtrans2 requests in the
  client code. This was essential to test the multi-part server code
  (which I will commit soon)

- when the request state is an error, ensure that req->status is not NT_STATUS_OK
(This used to be commit ef502c403044b68ccdff15b1a94d447d0f53473d)

13 years agor4228: make sure the caller knows the packet is in error when a signing error occurs
Andrew Tridgell [Thu, 16 Dec 2004 12:25:23 +0000 (12:25 +0000)]
r4228: make sure the caller knows the packet is in error when a signing error occurs
(This used to be commit 5e13571e6b9f5eb35f710c2c8bd85b5569665613)

13 years agor4227: index the privilege attribute to make lsa privilege calls efficient
Andrew Tridgell [Thu, 16 Dec 2004 12:24:25 +0000 (12:24 +0000)]
r4227: index the privilege attribute to make lsa privilege calls efficient
(This used to be commit e9e603208d79dc69c75420a8e085f8ad6c8a7095)

13 years agor4214: possibly fix the "no-EAs" bug from OS/2
Andrew Tridgell [Wed, 15 Dec 2004 03:53:05 +0000 (03:53 +0000)]
r4214: possibly fix the "no-EAs" bug from OS/2
(This used to be commit c9871253485b1a663fc79649742d3a89e81eb6d4)

13 years agor4213: Store REG_SZ in UTF16, not the unix charset..
Jelmer Vernooij [Wed, 15 Dec 2004 02:27:22 +0000 (02:27 +0000)]
r4213: Store REG_SZ in UTF16, not the unix charset..

It is now possible to use the "Add..." button in the Security
tab of the File Properties Dialog box.
(This used to be commit 9fa25260d3f18dd0dd041477c48571b53d86f3c4)

13 years agor4210: Add simple example of a registry hive LDIF file
Jelmer Vernooij [Wed, 15 Dec 2004 00:39:39 +0000 (00:39 +0000)]
r4210: Add simple example of a registry hive LDIF file
(This used to be commit cd9572b72e8d282ec47d2d67f6daa00ff1aa621c)

13 years agor4209: Fix several smaller bugs
Jelmer Vernooij [Wed, 15 Dec 2004 00:16:54 +0000 (00:16 +0000)]
r4209: Fix several smaller bugs
Add "predef" and "set" commands in regshell

Some of the remote calls from a Windows box work now.
(This used to be commit f3e05782804fe4b4942fa966f1b9650c64bc234d)

13 years agor4207: remove "lookupname" and "lookupsid", and instead have a single "lookup" comman...
Andrew Tridgell [Tue, 14 Dec 2004 22:24:56 +0000 (22:24 +0000)]
r4207: remove "lookupname" and "lookupsid", and instead have a single "lookup" command that
takes a name or sid.

I think in general its better to make smbclient automatically work out the type from
the format (I did the same with the privileges commands)
(This used to be commit bbf482e13ab973a67e9b2c0e0e40c2afff073c63)

13 years agor4206: fixed a status code check in lsa_LookupNames2 that could cause a segv
Andrew Tridgell [Tue, 14 Dec 2004 22:18:33 +0000 (22:18 +0000)]
r4206: fixed a status code check in lsa_LookupNames2 that could cause a segv
(This used to be commit 31ab04f790ff4349dbc8a24c07fa35e10b831baf)

13 years agor4205: fixed the default acl mapping from posix permissions to use the mapped
Andrew Tridgell [Tue, 14 Dec 2004 22:17:41 +0000 (22:17 +0000)]
r4205: fixed the default acl mapping from posix permissions to use the mapped
uid->sid and gid->sid
(This used to be commit 590e1a91bfc719c2d84a9a066fb4e0308b6d9803)

13 years agor4204: Arguments to reg_del_key more like the RPC for more efficient usage
Jelmer Vernooij [Tue, 14 Dec 2004 20:49:18 +0000 (20:49 +0000)]
r4204: Arguments to reg_del_key more like the RPC for more efficient usage
Fix small bug in regpatch
Fix segfault in regshell cmdline completion
Implement set_value and del_value in ldb backend
(This used to be commit 8e2aa58abeafa78afe7dafb9723f5f365e756527)

13 years agor4203: the bind_info blob isn't a const.
Stefan Metzmacher [Tue, 14 Dec 2004 07:18:58 +0000 (07:18 +0000)]
r4203: the bind_info blob isn't a const.
here's the idl to parse it, because we don't want the
callers to manually de/encode this

metze
(This used to be commit 983f74c3651759991378b0d7b13b0952d77b3544)

13 years agor4202: added smbclient commands "addprivileges" and "delprivileges" for
Andrew Tridgell [Tue, 14 Dec 2004 06:31:20 +0000 (06:31 +0000)]
r4202: added smbclient commands "addprivileges" and "delprivileges" for
easily adding/removing privileges from users
(This used to be commit 8764909c05c4829d1e4f7eaf8c18e8ef1e53645f)

13 years agor4201: Remove duplicate const.
Tim Potter [Tue, 14 Dec 2004 06:25:19 +0000 (06:25 +0000)]
r4201: Remove duplicate const.
(This used to be commit 1d96717843a9b60a757548a24967bbb553775fa3)

13 years agor4200: Fix some more warnings.
Tim Potter [Tue, 14 Dec 2004 06:23:01 +0000 (06:23 +0000)]
r4200: Fix some more warnings.
(This used to be commit 0359bc408f8b3a9f743553f98d0fa1f57021701c)

13 years agor4199: - added server side code for lsa_RemoveAccountRights (sharing code
Andrew Tridgell [Tue, 14 Dec 2004 06:17:33 +0000 (06:17 +0000)]
r4199: - added server side code for lsa_RemoveAccountRights (sharing code
  with lsa_AddAccountRights)
(This used to be commit 9bd806b7a29afe9db98048be0f8035c75bf8e1c7)

13 years agor4198: - added server side code for lsa_AddAccountRights
Andrew Tridgell [Tue, 14 Dec 2004 06:10:45 +0000 (06:10 +0000)]
r4198: - added server side code for lsa_AddAccountRights
(This used to be commit ba87142586672a1082200048e7d1ae865d266d6c)

13 years agor4197: Remove silly extra const.
Tim Potter [Tue, 14 Dec 2004 06:09:04 +0000 (06:09 +0000)]
r4197: Remove silly extra const.
(This used to be commit fcbfa888defe4f904e0c4b4f723d53a03422ad80)

13 years agor4196: - added server side code for lsa_LookupPrivDisplayName
Andrew Tridgell [Tue, 14 Dec 2004 05:51:01 +0000 (05:51 +0000)]
r4196: - added server side code for lsa_LookupPrivDisplayName

- added english descriptions of privileges. We should add other
  languages in the future.
(This used to be commit 3eee8b7c13de3ffe7c5a87d6f1ebdcc66ff391eb)

13 years agor4195: added IDL, test suite and server side code for lsa_LookupPrivValue
Andrew Tridgell [Tue, 14 Dec 2004 05:32:51 +0000 (05:32 +0000)]
r4195: added IDL, test suite and server side code for lsa_LookupPrivValue
(This used to be commit 7bddd4740332017bb5f4bddcc9ba0234d05378bd)

13 years agor4194: added server side implementation of lsa_EnumPrivs
Andrew Tridgell [Tue, 14 Dec 2004 05:20:38 +0000 (05:20 +0000)]
r4194: added server side implementation of lsa_EnumPrivs
(This used to be commit 710732033261f6355893b94b43e6c532baa105e0)

13 years agor4193: added server side implementation of lsa_EnumAccountsWithUserRight
Andrew Tridgell [Tue, 14 Dec 2004 05:07:29 +0000 (05:07 +0000)]
r4193: added server side implementation of lsa_EnumAccountsWithUserRight
(This used to be commit 5088a6cbf70fe6eff94f07e2f5874525539c46fa)

13 years agor4192: added server side implementation of lsa_EnumAccountRights
Andrew Tridgell [Tue, 14 Dec 2004 04:45:00 +0000 (04:45 +0000)]
r4192: added server side implementation of lsa_EnumAccountRights

the "privilege" command in smbclient now works against Samba4
(This used to be commit 8a3f2650500e11d1d38d76421f8373e5088d2dc5)

13 years agor4183: expanded the RAW-MKDIR torture test to test creation of EA lists
Andrew Tridgell [Mon, 13 Dec 2004 23:58:39 +0000 (23:58 +0000)]
r4183: expanded the RAW-MKDIR torture test to test creation of EA lists
(This used to be commit 0134d8e9cc5634441b1aa6841bcd332c5afcc0f3)

13 years agor4182: fixed trans2 mkdir, allowing mkdir with an initial EA list
Andrew Tridgell [Mon, 13 Dec 2004 23:57:59 +0000 (23:57 +0000)]
r4182: fixed trans2 mkdir, allowing mkdir with an initial EA list
(This used to be commit 7d981c29c28391813c7f93245f64b3ee108378a4)

13 years agor4181: use int32 for level
Stefan Metzmacher [Mon, 13 Dec 2004 12:34:43 +0000 (12:34 +0000)]
r4181: use int32 for level

metze
(This used to be commit 3a6047bc47671bfab14272dfa81f80f4457b209c)

13 years agor4180: use the same syntax as the other torture tests
Stefan Metzmacher [Mon, 13 Dec 2004 12:28:47 +0000 (12:28 +0000)]
r4180: use the same syntax as the other torture tests

metze
(This used to be commit 00395ffcc3cc94216619ca827ff6a09b0cc28de1)

13 years agor4179: - nicer code layout
Stefan Metzmacher [Mon, 13 Dec 2004 12:24:57 +0000 (12:24 +0000)]
r4179: - nicer code layout

- and disable DsReplicaSync by default it kill lsass.exe
  on my w2k box

metze
(This used to be commit 8373b2d4c7decd49a361637e03b24b311aed302c)

13 years agor4178: the level is mostly singed not unsigned
Stefan Metzmacher [Mon, 13 Dec 2004 12:01:43 +0000 (12:01 +0000)]
r4178: the level is mostly singed not unsigned

metze
(This used to be commit 6411c00b3c2c4e11da2b41bfa53e0d42368e3e76)

13 years agor4177: add some more error codes
Stefan Metzmacher [Mon, 13 Dec 2004 11:37:47 +0000 (11:37 +0000)]
r4177: add some more error codes

metze
(This used to be commit e624bb52886db80a3600b79494ad1150592efebe)

13 years agor4176: I just remeber that I have already implement STR_CONFORMANT
Stefan Metzmacher [Mon, 13 Dec 2004 11:34:57 +0000 (11:34 +0000)]
r4176: I just remeber that I have already implement STR_CONFORMANT

so use it in DsReplicaSync()

metze
(This used to be commit ca610da1fc3c059d35e17238e8cac5e5b38790c3)

13 years agor4175: InitiateSystemShutdownEx IDL and torture test
Jelmer Vernooij [Mon, 13 Dec 2004 11:00:24 +0000 (11:00 +0000)]
r4175: InitiateSystemShutdownEx IDL and torture test
(This used to be commit 3538130bf5d656ed4b0e2c84294e995814860e34)

13 years agor4174: nicer debug output
Stefan Metzmacher [Mon, 13 Dec 2004 10:48:35 +0000 (10:48 +0000)]
r4174: nicer debug output

metze
(This used to be commit 79bdcabcc57da9f7d01b09d3b33fe22770c6e7e8)

13 years agor4173: - new t2open code, that can cope with "create with EAs". Many thanks
Andrew Tridgell [Mon, 13 Dec 2004 10:48:21 +0000 (10:48 +0000)]
r4173: - new t2open code, that can cope with "create with EAs". Many thanks
  to kukks on #samba-technical for the sniffs that allowed me to work
  this out

- much simpler ntvfs open generic mapping code

- added t2open create with EA torture test to RAW-OPEN test
(This used to be commit a56d95ad89b4f32a05974c4fe9a816d67aa369e3)

13 years agor4172: commit a DsReplicaSync() torture test
Stefan Metzmacher [Mon, 13 Dec 2004 10:29:44 +0000 (10:29 +0000)]
r4172: commit a DsReplicaSync() torture test
this not make much sense as we don't send the correct nc_name
but it shows that doesn't get a NDR_FAULT anymore,
we just need handle the conformant strings in pidl

metze
(This used to be commit be449f628faf85a163852d18bc724984d3afefd2)

13 years agor4171: an attempt at better IDL for DsReplicaSync
Andrew Tridgell [Mon, 13 Dec 2004 09:32:57 +0000 (09:32 +0000)]
r4171: an attempt at better IDL for DsReplicaSync
(This used to be commit a4ebef4f53d0eb5aef1bc4ae76ac9ad66bf3b528)

13 years agor4170: don't check array size for conformant arrays (they are checked separately)
Andrew Tridgell [Mon, 13 Dec 2004 09:32:02 +0000 (09:32 +0000)]
r4170: don't check array size for conformant arrays (they are checked separately)
(This used to be commit e399834ae1aa9731d5d29c04d5b7b90e356dad6f)

13 years agor4169: add descriptions about binding and unc strings to the
Stefan Metzmacher [Mon, 13 Dec 2004 09:26:13 +0000 (09:26 +0000)]
r4169: add descriptions about binding and unc strings to the
smbtorture --usage --help output

metze
(This used to be commit 26a7f4cf5ec4e3697a715f4880468c7f30ba5948)

13 years agor4168: Implement QueryValue in the server
Jelmer Vernooij [Mon, 13 Dec 2004 02:04:34 +0000 (02:04 +0000)]
r4168: Implement QueryValue in the server
IDL for NotifyChangeKeyValue
(This used to be commit a40214243136ed5208a1bec494ad1fbf821524ba)

13 years agor4167: Fix CreateKey
Jelmer Vernooij [Mon, 13 Dec 2004 01:37:18 +0000 (01:37 +0000)]
r4167: Fix CreateKey
Support CreateKey in the RPC registry backend
(This used to be commit ad8d9e6f73619332d93c38a1879233e199e8ba25)

13 years agor4166: More small API fixes, keep registry structs as small as possible.
Jelmer Vernooij [Mon, 13 Dec 2004 00:45:29 +0000 (00:45 +0000)]
r4166: More small API fixes, keep registry structs as small as possible.
Implement DelValue in the RPC server
(This used to be commit f6b9ec89af934e837069fb26c0e3491fc78ebc12)

13 years agor4165: added a 100 element name cache to cope with some amount of seeking
Andrew Tridgell [Sun, 12 Dec 2004 11:30:30 +0000 (11:30 +0000)]
r4165: added a 100 element name cache to cope with some amount of seeking
back to filenames that have been deleted. This fixes the new os/2
delete test.
(This used to be commit 6d471db13ab132655a07e11533a559446e56fc00)

13 years agor4164: added a test that simulates a OS/2 file delete. This includes seek by
Andrew Tridgell [Sun, 12 Dec 2004 11:29:35 +0000 (11:29 +0000)]
r4164: added a test that simulates a OS/2 file delete. This includes seek by
name back into a directory for files that no longer exist.
(This used to be commit 57204a1533687c5f7f2ee169f42584aea914154f)

13 years agor4163: 2nd attempt at fixing the OS/2 "del *" problem
Andrew Tridgell [Sun, 12 Dec 2004 09:11:39 +0000 (09:11 +0000)]
r4163: 2nd attempt at fixing the OS/2 "del *" problem
(This used to be commit ae14905d9522dbdc1709ef110b9933adcb740a26)

13 years agor4162: this should fix the delete/findnext problem from OS/2 clients. Thanks
Andrew Tridgell [Sun, 12 Dec 2004 09:02:18 +0000 (09:02 +0000)]
r4162: this should fix the delete/findnext problem from OS/2 clients. Thanks
again to kukks for the excellent and detailed bug report
(This used to be commit 7dfffe4ac0d6858ae6848708df1baa11a6819680)

13 years agor4161: two more fixes for NT4 clients. Bugs found by kukks.
Andrew Tridgell [Sun, 12 Dec 2004 08:35:11 +0000 (08:35 +0000)]
r4161: two more fixes for NT4 clients. Bugs found by kukks.

 - nt4 doesn't setup the pfc flags correctly for rpc packet types
   other than normal requests, so don't check for fragmented packets
   unless they are of type request

 - ensure we give STATUS_BUFFER_OVERFLOW when we return a partial
   fragment in SMBtrans requests on ncacn_np
(This used to be commit 83ebffec3215c58c5cebf1a7c9a58904854203c8)

13 years agor4160: fixed the file_type in ntcreatex reply on a named pipe. NT4 requires this...
Andrew Tridgell [Sun, 12 Dec 2004 08:33:08 +0000 (08:33 +0000)]
r4160: fixed the file_type in ntcreatex reply on a named pipe. NT4 requires this to be right.
(This used to be commit e22de9734f66bee3c9eaf8191fcae9fb06a0034f)

13 years agor4159: fixed error return for writebraw
Andrew Tridgell [Sun, 12 Dec 2004 07:22:59 +0000 (07:22 +0000)]
r4159: fixed error return for writebraw
(This used to be commit 13c7794e02b0d5c83baa5efbe93e46defd38c8e1)

13 years agor4158: Fix IDL for InitiateShutdown and AbortShutdown and run both only
Jelmer Vernooij [Sun, 12 Dec 2004 00:35:50 +0000 (00:35 +0000)]
r4158: Fix IDL for InitiateShutdown and AbortShutdown and run both only
when dangerous tests are enabled.
(This used to be commit a763bd838558bdd7bcab3ca7ee91c1846d7a950f)

13 years agor4157: QueryMultipleValues IDL and torture test
Jelmer Vernooij [Sun, 12 Dec 2004 00:22:30 +0000 (00:22 +0000)]
r4157: QueryMultipleValues IDL and torture test
Initialisation data pointer in QueryValue torture test
(This used to be commit 72618dfe95c785d3a3a71cc4a70b59696f2d418e)

13 years agor4156: GetKeySecurity() IDL and torture test
Jelmer Vernooij [Sat, 11 Dec 2004 23:28:48 +0000 (23:28 +0000)]
r4156: GetKeySecurity() IDL and torture test
(This used to be commit 1c49de51aeb6041a3b53b8da7dc8e2bcf089bfe0)

13 years agor4155: More destinction between hives and predefined keys
Jelmer Vernooij [Sat, 11 Dec 2004 20:06:40 +0000 (20:06 +0000)]
r4155: More destinction between hives and predefined keys
(This used to be commit c37d6f3c581673d74e7ec6a644ab6a7d13a55535)

13 years agor4154: Add definitions for HKEY_PERFORMANCE_TEXT and HKEY_PERFORMANCE_NLSTEXT
Jelmer Vernooij [Sat, 11 Dec 2004 17:12:16 +0000 (17:12 +0000)]
r4154: Add definitions for HKEY_PERFORMANCE_TEXT and HKEY_PERFORMANCE_NLSTEXT
Hives and predefined keys (HKEY_*) are not necessarily the same thing.
(This used to be commit 217e4e5841cfedb2b18dce3f89dd88ea4a36fe8f)

13 years agor4151: added privilege attribute handling on samdb.
Andrew Tridgell [Sat, 11 Dec 2004 13:19:41 +0000 (13:19 +0000)]
r4151: added privilege attribute handling on samdb.

pvfs will now honor some privileges on ACLs, and it will be quite easy
to add the checks for more privileges in the necessary places, by
making calls to sec_privilege_check().
(This used to be commit 3549039d0fbc54f87ae679e7288b82b28713e487)

13 years agor4150: - add fns for manipulating the privilege_mask in a security_token
Andrew Tridgell [Sat, 11 Dec 2004 12:01:20 +0000 (12:01 +0000)]
r4150: - add fns for manipulating the privilege_mask in a security_token

- add the hooks in access_check that check the privilege bitmasks for
  SEC_STD_DELETE and SEC_FLAG_SYSTEM_SECURITY
(This used to be commit 0fa3764edcabffe8f7d5e40f0097f97d0c4519c4)

13 years agor4148: add a default set of privileges to the core builtin accounts in the
Andrew Tridgell [Sat, 11 Dec 2004 05:43:03 +0000 (05:43 +0000)]
r4148: add a default set of privileges to the core builtin accounts in the
sam. I decided to do it the simple way of making the privileges user
attributes. w2k doesn't expose the privileges via LDAP, so we are free
to store them in any way we like without breaking compatibility.
(This used to be commit 5f29f4c3079be2fa54b94e08c829dadccc4d14c4)

13 years agor4147: converted from NT_USER_TOKEN to struct security_token
Andrew Tridgell [Sat, 11 Dec 2004 05:41:19 +0000 (05:41 +0000)]
r4147: converted from NT_USER_TOKEN to struct security_token

this is mostly just a tidyup, but also adds the privilege_mask, which
I will be using shortly in ACL checking.

note that I had to move the definition of struct security_token out of
security.idl as pidl doesn't yet handle arrays of pointers, and the
usual workaround (to use a intermediate structure) would make things
too cumbersome for this structure, especially given we never encode it
to NDR.
(This used to be commit 7b446af09b8050746bfc2c50e9d56aa94397cc1a)

13 years agor4146: an attempted fix for a OS/2 rename problem found by kukks - seems OS/2
Andrew Tridgell [Sat, 11 Dec 2004 04:11:26 +0000 (04:11 +0000)]
r4146: an attempted fix for a OS/2 rename problem found by kukks - seems OS/2
is v senstive to SMB flags2 bits
(This used to be commit c232e21218e81ac9189b651478415e9fbd67bf78)

13 years agor4145: make sure we don't set the 32-bit error codes flag unless the client
Andrew Tridgell [Sat, 11 Dec 2004 03:39:09 +0000 (03:39 +0000)]
r4145: make sure we don't set the 32-bit error codes flag unless the client
can handle it, even for success packets (this bug was harmless, but
can be confusing in ethereal with old clients)
(This used to be commit 71e0c7b2ebbb01d64453c59e20911dc5008b9798)

13 years agor4142: Check result value of OpenHKU and OpenHKCR
Jelmer Vernooij [Fri, 10 Dec 2004 23:20:24 +0000 (23:20 +0000)]
r4142: Check result value of OpenHKU and OpenHKCR
(This used to be commit bba4e878b4a93e67e02b8f1332b0889947ec1a11)

13 years agor4141: Fix crash bug in ldb backend
Jelmer Vernooij [Fri, 10 Dec 2004 23:13:17 +0000 (23:13 +0000)]
r4141: Fix crash bug in ldb backend
(This used to be commit 5f64a60374486b9fc3d75786c3035a9017dd4d33)

13 years agor4140: Get rid of close_hive (replace it with talloc destructors).
Jelmer Vernooij [Fri, 10 Dec 2004 22:57:43 +0000 (22:57 +0000)]
r4140: Get rid of close_hive (replace it with talloc destructors).
(This used to be commit bcbfce7b0119538bab06801c97aa9c7d4bf3a6c6)

13 years agor4139: 2nd attempt at fixing the null ptr in size_is() problem.
Andrew Tridgell [Fri, 10 Dec 2004 22:36:46 +0000 (22:36 +0000)]
r4139: 2nd attempt at fixing the null ptr in size_is() problem.
(This used to be commit 3040cd65151dbcc54404f9be9d1fbcf539c7b635)

13 years agor4138: initialise 'type' in RPC-WINREG EnumValue test
Andrew Tridgell [Fri, 10 Dec 2004 22:35:35 +0000 (22:35 +0000)]
r4138: initialise 'type' in RPC-WINREG EnumValue test
(This used to be commit 952a26c561846def21d3d2f4d36cbe79a54f9eff)

13 years agor4137: Make *_open_key take a registry_key instead of a hive (more efficient
Jelmer Vernooij [Fri, 10 Dec 2004 22:28:49 +0000 (22:28 +0000)]
r4137: Make *_open_key take a registry_key instead of a hive (more efficient
in some cases)
(This used to be commit ddf7a331c58976f2c0b4a00390118f1acf60e3eb)

13 years agor4136: when we have a size or switch variable that is a pointer we need to check...
Andrew Tridgell [Fri, 10 Dec 2004 22:16:35 +0000 (22:16 +0000)]
r4136: when we have a size or switch variable that is a pointer we need to check that the server
hasn't given us a null pointer, otherwise we can segv when we dereference it. For example:

  [size_is(*size)] *x;
  uint32 *size;

if a broken server gave us x != NULL and size == NULL then we would crash. I've added
a check_null_pointer() call in pidl to catch this.
(This used to be commit 8cbd3f47a95367e861c6b99c44416a9ccef3c9ca)

13 years agor4135: improve a debug message
Andrew Tridgell [Fri, 10 Dec 2004 21:31:32 +0000 (21:31 +0000)]
r4135: improve a debug message
(This used to be commit 4b45d3d2e86122dbe5bd258fc96ad674aba0d417)

13 years agor4133: Cache results of subkey and value queries
Jelmer Vernooij [Fri, 10 Dec 2004 20:50:49 +0000 (20:50 +0000)]
r4133: Cache results of subkey and value queries
(This used to be commit 1e12971137f50077e04a0432572275baf4fde35e)

13 years agor4132: - Bunch of rather large fixes in the registry
Jelmer Vernooij [Fri, 10 Dec 2004 20:07:04 +0000 (20:07 +0000)]
r4132: - Bunch of rather large fixes in the registry
- Added some README files

Not everything works yet, e.g. the EnumValue test appears to be broken.
(This used to be commit c169e86c1f52763b83e77e509f89cb91f9b69071)

13 years agor4124: include locale.h to get LC_ALL in include/system/iconv.h
Andrew Tridgell [Fri, 10 Dec 2004 04:41:56 +0000 (04:41 +0000)]
r4124: include locale.h to get LC_ALL in include/system/iconv.h
(This used to be commit 573230ea99136bd66d00bac18effd28b1e5ba76f)

13 years agor4123: set locale to C to ensure ascii string functions work
Andrew Tridgell [Fri, 10 Dec 2004 03:41:54 +0000 (03:41 +0000)]
r4123: set locale to C to ensure ascii string functions work

thanks to Bjoern JACKE <samba@j3e.de> for pointing this out
(This used to be commit 53c4d0a7d83181afbe01bbbb0840cb2a086b45da)

13 years agor4118: don't assume that "unsigned int" is the same type as uint32_t
Andrew Tridgell [Thu, 9 Dec 2004 12:54:01 +0000 (12:54 +0000)]
r4118: don't assume that "unsigned int" is the same type as uint32_t
(This used to be commit 1ddab01d2ac0a51278cbd13d6d9369973c7a5b3a)

13 years agor4117: fixed EnumValue in winreg server
Andrew Tridgell [Thu, 9 Dec 2004 12:50:50 +0000 (12:50 +0000)]
r4117: fixed EnumValue in winreg server
(This used to be commit f2f21033b65b82251b5ea0b2475ceb1bb3657fb3)

13 years agor4116: fixed compilation of EnumValue code in winreg rpc backend
Andrew Tridgell [Thu, 9 Dec 2004 12:42:29 +0000 (12:42 +0000)]
r4116: fixed compilation of EnumValue code in winreg rpc backend

thanks to volker for pointing this out
(This used to be commit 2b67f18bdb58164697efd428391d4cbc46398464)

13 years agor4115: check for gensec errors before calling memcpy on a set of credentials,
Andrew Tridgell [Thu, 9 Dec 2004 10:33:21 +0000 (10:33 +0000)]
r4115: check for gensec errors before calling memcpy on a set of credentials,
otherwise the creds structure might be invalid
(This used to be commit 76285b3390f20366d53c7b2509ac07e1f88f7309)

13 years agor4114: added have_features bits to gensec schannel code. This fixes our
Andrew Tridgell [Thu, 9 Dec 2004 10:32:43 +0000 (10:32 +0000)]
r4114: added have_features bits to gensec schannel code. This fixes our
schannel code.

I would also like to give a gentle reminder to everyone to please run
the appropriate test scripts when you change a subsystem. It's a shame
to have this test code and not use it, and it takes much longer for
another developer to track down a bug in your new code than it would
take for you fix to it at the time you first add it.

 - for rpc changes run test_rpc.sh
 - for CIFS changes run test_posix.sh
 - for ldb changes run test-tdb in lib/ldb/
(This used to be commit 0c58b254cabd236911021aff87c73183356fa8e3)

13 years agor4113: modified EnumValue in winreg to take advantage of the new pidl handling
Andrew Tridgell [Thu, 9 Dec 2004 07:52:00 +0000 (07:52 +0000)]
r4113: modified EnumValue in winreg to take advantage of the new pidl handling
of arrays.
(This used to be commit b47e203a054e26d5d0c133a3c3b8d9502bd6ac69)

13 years agor4112: when a pointer is NULL on the wire ensure it is null in the structure
Andrew Tridgell [Thu, 9 Dec 2004 07:51:20 +0000 (07:51 +0000)]
r4112: when a pointer is NULL on the wire ensure it is null in the structure
(This used to be commit 83221a0da07bf7c45757e737782f2f4ee541ad88)

13 years agor4111: fixed winreg to use much simpler (and I believe correct) IDL for QueryValue
Andrew Tridgell [Thu, 9 Dec 2004 07:05:47 +0000 (07:05 +0000)]
r4111: fixed winreg to use much simpler (and I believe correct) IDL for QueryValue
(This used to be commit 659d0295314c6a070698fc81223044f4d7366993)

13 years agor4110: fixed pidl to allow arrays to have size_is() and length_is() elements
Andrew Tridgell [Thu, 9 Dec 2004 07:05:00 +0000 (07:05 +0000)]
r4110: fixed pidl to allow arrays to have size_is() and length_is() elements
that depend on variables that come after the array in the structure or function.

This has been something that has been problematic for a while, but the
winreg QueryValue problem finally prompted me to fix it properly. We
should now go back and fix up all the ugly workarounds we have used to
avoid this problem in other calls.

Unfortunately the solution is fairly complex, and involves the use of
the internal ndr token lists (similar to the solution for relative
pointers). I wonder if anyone else will be able to follow the logic if
I get run over by a bus :-)
(This used to be commit e839b19ec5581f669f2a7705b1fb80845313251c)

13 years agor4109: fixed an uninitialised socket write found by kukks
Andrew Tridgell [Thu, 9 Dec 2004 04:40:57 +0000 (04:40 +0000)]
r4109: fixed an uninitialised socket write found by kukks
(This used to be commit 30c58b046d65164da37f705de105662f806e1331)

13 years agor4106: Add full name of two more hives
Jelmer Vernooij [Wed, 8 Dec 2004 22:13:28 +0000 (22:13 +0000)]
r4106: Add full name of two more hives
(This used to be commit c1023db5e8336e495c06acae1773a28d7fc90658)

13 years agor4105: Fix IDL for QueryValue() and add a torture test for it.
Jelmer Vernooij [Wed, 8 Dec 2004 22:02:49 +0000 (22:02 +0000)]
r4105: Fix IDL for QueryValue() and add a torture test for it.
Thanks to Michael Allen for some hints on what was wrong with the previous IDL.
(This used to be commit 0fa6d847433eb281eaff15b8be4a26f898689f0a)

13 years agor4102: more uint64 vs HYPER_T fixes
Stefan Metzmacher [Wed, 8 Dec 2004 11:30:26 +0000 (11:30 +0000)]
r4102: more uint64 vs HYPER_T fixes

NOTE:
 [u]int64 uses 4 Byte alignment
 and HYPER_T uses 8 Byte alignment

metze
(This used to be commit 717454eb2fd2bf90e67074acefdae5304cd7433f)

13 years agor4101: ignore secondary session requests to cope with a OS/2 bug reported by
Andrew Tridgell [Wed, 8 Dec 2004 11:02:47 +0000 (11:02 +0000)]
r4101: ignore secondary session requests to cope with a OS/2 bug reported by
Guenter Kukkukk
(This used to be commit 49c8df5648eae1e8222c0dd2859fd2ff62ef34ce)

13 years agor4100: fix drsuapi_DsReplicaObjMetaData2() idl
Stefan Metzmacher [Wed, 8 Dec 2004 10:54:09 +0000 (10:54 +0000)]
r4100: fix drsuapi_DsReplicaObjMetaData2() idl

(many thanks to tridge for telling me that HYPER_T isn't the same as uint64!)

metze
(This used to be commit 74b9ef4de5263953aa2e03401a271f2830163efe)

13 years agor4099: Spelling fixes.
Tim Potter [Wed, 8 Dec 2004 10:36:14 +0000 (10:36 +0000)]
r4099: Spelling fixes.
(This used to be commit 24d9f97bd6059d90eeead23900225e286047a862)

13 years agor4098: catch null guid string so RPC-DRSUAPI works against my server
Andrew Tridgell [Wed, 8 Dec 2004 10:24:10 +0000 (10:24 +0000)]
r4098: catch null guid string so RPC-DRSUAPI works against my server
(This used to be commit c4c83f04f55d206716380330d2a4d2b31f893346)

13 years agor4097: add missing file from last commit
Stefan Metzmacher [Wed, 8 Dec 2004 10:13:45 +0000 (10:13 +0000)]
r4097: add missing file from last commit

sorry!:-)

metze
(This used to be commit c2495d60a11febb2715d0dbf3f6598d8edccfb11)

13 years agor4096: move the samdb code to source/dsdb/
Stefan Metzmacher [Wed, 8 Dec 2004 08:21:35 +0000 (08:21 +0000)]
r4096: move the samdb code to source/dsdb/

the idea is to have a directory service db layer
which will be used by the ldap server, samr server, drsuapi server
authentification...

I plan to make different implementations of this interface possible
- current default will be the current samdb code with sam.ldb
- a compat implementation for samba3 (if someone wants to write one)
- a new dsdb implementation which:
  - understands naming contexts (directory parrtitions)
  - do schema and acl checking checking
  - maintain objectGUID, timestamps and USN number,
    maybe linked attributes ('member' and 'memberOf' attributes)
  - store metadata on a attribute=value combination...

metze
(This used to be commit 893a8b8bca2f020fbbe6f469aaa8dd4478249eb8)

13 years agor4095: smbsrv_terminate_connection() doesn't exit() in single processor mode, so...
Andrew Tridgell [Wed, 8 Dec 2004 08:09:42 +0000 (08:09 +0000)]
r4095: smbsrv_terminate_connection() doesn't exit() in single processor mode, so after we
call it we need to return, and not continue processing packets
(This used to be commit 33e4cee17dbfbb79e5ae68fda893a4d313865eb5)

13 years agor4087: - add idl and torture tests for drsuapi_DsReplicaGetInfo()
Stefan Metzmacher [Tue, 7 Dec 2004 12:20:28 +0000 (12:20 +0000)]
r4087: - add idl and torture tests for drsuapi_DsReplicaGetInfo()

(NOTE: that the drsuapi_DsReplicaObjMetaData2 struct is not corrently parsed yet
 and there're some unknown fields left in someother infotypes)

metze
(This used to be commit 4fd57d5e7cff085a8c003ea82f282e26dc1346d9)

13 years agor4086: - make dcerpc_ndr_request_table_send() the default and rename it to just
Stefan Metzmacher [Tue, 7 Dec 2004 09:26:00 +0000 (09:26 +0000)]
r4086: - make dcerpc_ndr_request_table_send() the default and rename it to just
  dcerpc_ndr_request_send()
- this allows us to call dcerpc_log_packet() when we receive a packet we
  can't parse correctly

metze
(This used to be commit a7a6cea112a180a28188997ca99f30d8dd286bb8)

13 years agor4085: print out dcerpc_fault's as names
Stefan Metzmacher [Tue, 7 Dec 2004 09:21:13 +0000 (09:21 +0000)]
r4085: print out dcerpc_fault's as names

metze
(This used to be commit 979c453c4dedf0006997dfc9994331e49643b741)

13 years agor4084: add some more error codes
Stefan Metzmacher [Tue, 7 Dec 2004 09:18:56 +0000 (09:18 +0000)]
r4084: add some more error codes

metze
(This used to be commit e5db58526825476fd6d8d80c8ee6c3bca0e23c84)