samba.git
11 years agodssync: allow replications of a single obj with net rpc vampire keytab.
Michael Adam [Thu, 17 Jul 2008 22:18:40 +0000 (00:18 +0200)]
dssync: allow replications of a single obj with net rpc vampire keytab.

This is triggered by setting the new "single" flag in the dssync_context
and filling the "object_dn" member with the dn of the object to be
fetched.

This call is accomplished by specifying the DRSUAPI_EXOP_REPL_OBJ
extended operation in the DsGetNCCHanges request. This variant does
honor an up-to-date-ness vectore passed in, but the answer does not
return a new up-to-dateness vector.

Call this operation as "net rpc vampire keytab /path/keytab object_dn" .

Michael
(This used to be commit f4a01178a3d8d71f416a3b67ce6b872420f211c0)

11 years agodssync: pass uptodateness vector into and out of DsGetNCChanges request.
Michael Adam [Wed, 16 Jul 2008 23:05:06 +0000 (01:05 +0200)]
dssync: pass uptodateness vector into and out of DsGetNCChanges request.

Also store the new uptodateness vector in the backend after completion
and retrieve the old vector before sending the DsGetNCChanges request.

This effectively accomplishes differential replication.

Michael
(This used to be commit a2a88808df16d153f45337b740391d419d87e87a)

11 years agodssync: skip analysis of the msDS_KeyVersionNumber attribute:
Michael Adam [Thu, 17 Jul 2008 11:32:19 +0000 (13:32 +0200)]
dssync: skip analysis of the msDS_KeyVersionNumber attribute:

It is a calculated attribute that won't get distributed via replication.

Michael
(This used to be commit d75b7a2052f1e447f2b3b63fdb054abef4403edf)

11 years agodssync: either use the req5 or the req8 request, depending on the supported_extenstion
Michael Adam [Thu, 17 Jul 2008 11:05:43 +0000 (13:05 +0200)]
dssync: either use the req5 or the req8 request, depending on the supported_extenstion

that have been recorded in the remote_info28 in the dssync_context.

Michael
(This used to be commit 3a2a69137e69c4bd0faa6af22d17e11dac022049)

11 years agodssync: record the bind info in the new remote_info28 in libnet_dssync_bind().
Michael Adam [Thu, 17 Jul 2008 11:04:04 +0000 (13:04 +0200)]
dssync: record the bind info in the new remote_info28 in libnet_dssync_bind().

This extracts the info24 data in case this is what was returned (instead of info28).
E.g. windows 2000 returns info24.

Michael
(This used to be commit 61b41aa615d5d46305653845584df7b1803f07ec)

11 years agodssync: add a drsuapi_DsBindInfo28 struct to the dssync_context struct
Michael Adam [Thu, 17 Jul 2008 11:02:31 +0000 (13:02 +0200)]
dssync: add a drsuapi_DsBindInfo28 struct to the dssync_context struct

to keep track of what the server told us upon DsBind.

Michael
(This used to be commit bf17d6af6104d20019a43e5486257085b9786793)

11 years agodssync keytab: wrap printing of the uptodate vector in DEBUGLEVEL >= 10 checks
Michael Adam [Thu, 17 Jul 2008 09:54:32 +0000 (11:54 +0200)]
dssync keytab: wrap printing of the uptodate vector in DEBUGLEVEL >= 10 checks

Michael
(This used to be commit 7fabe2567d0bd12fe3ade1d00b94b6c403fe79b5)

11 years agodssync keytab: add support for keeping track of the up-to-date-ness vector.
Michael Adam [Wed, 16 Jul 2008 22:54:35 +0000 (00:54 +0200)]
dssync keytab: add support for keeping track of the up-to-date-ness vector.

The startup operation should get the old up-to-date-ness vector from the backend
and the finish operation should store the new vector to the backend after replication.

This adds the change of the signatures of the operations ot the dssync_ops struct
and the implementation for the keytab ops. The up-to-date-ness vector is stored
under the principal constructed as UTDV/$naming_context_dn@$dns_domain_name.

The vector is still uninterpreted in libnet_dssync_process().
This will be the next step...

This code is essentially by Metze.

Michael
(This used to be commit 01318fb27a1aa9e5fed0d4dd882a123ab568ac37)

11 years agolibnet_keytab: add a libnet_keytab_search() function
Michael Adam [Wed, 16 Jul 2008 22:53:13 +0000 (00:53 +0200)]
libnet_keytab: add a libnet_keytab_search() function

that searches and fetches an entry from a keytab file by principal and kvno.

This code is by metze.

Michael
(This used to be commit a51a60066b6703fc4e5db3536903abf1cdaca885)

11 years agodssync keytab: use add_to_keytab_entries() for pwd history in parse_object().
Michael Adam [Wed, 23 Jul 2008 22:30:07 +0000 (00:30 +0200)]
dssync keytab: use add_to_keytab_entries() for pwd history in parse_object().

Michael
(This used to be commit 61f071de92a7011c70f72dc31fef4430ffb1515a)

11 years agodssync keytab: add prefix parameter to add_to_keytab_entries() for flexibility.
Michael Adam [Wed, 16 Jul 2008 21:12:31 +0000 (23:12 +0200)]
dssync keytab: add prefix parameter to add_to_keytab_entries() for flexibility.

This will allow to construct principals of the form PREFIX/name@domain

Michael
(This used to be commit 7dd32b56a65574db95f4a0e136f54bd73862c59f)

11 years agodssync keytab: add check for success of ADD_TO_ARRAY().
Michael Adam [Wed, 16 Jul 2008 21:10:20 +0000 (23:10 +0200)]
dssync keytab: add check for success of ADD_TO_ARRAY().

Michael
(This used to be commit e6f6e61da46f02bb2676c705974adc26bdfa2623)

11 years agodssync keytab: refactor adding entry to keytab_context out into new function
Michael Adam [Wed, 16 Jul 2008 21:08:40 +0000 (23:08 +0200)]
dssync keytab: refactor adding entry to keytab_context out into new function

add_to_keytab_entries()

Michael
(This used to be commit 79151db6eae234a1f9e5131b7776689a4f03a0ef)

11 years agodssync: replace the processing_fn by startup/process/finish ops.
Michael Adam [Wed, 16 Jul 2008 15:12:04 +0000 (17:12 +0200)]
dssync: replace the processing_fn by startup/process/finish ops.

This remove static a variable for the keytab context in the keytab
processing function and simplifies the signature. The keytab context
is instead in the new private data member of the dssync_context struct.

This is in preparation of adding support for keeping track of the
up-to-date-ness vector, in order to be able to sync diffs instead
of the whole database.

Michael
(This used to be commit c51c3339f35e3bd921080d2e226e2422fc23e1e6)

11 years agoSamba3 HowTo: Fix duplicate chapter id.
Karolin Seeger [Fri, 1 Aug 2008 12:10:28 +0000 (14:10 +0200)]
Samba3 HowTo: Fix duplicate chapter id.

Karolin
(This used to be commit f67b6fd97e177a527e896861f337c2e70541f697)

11 years agonetapi: when using NetApi functions forward net's kerberos setting.
Günther Deschner [Thu, 31 Jul 2008 13:14:14 +0000 (15:14 +0200)]
netapi: when using NetApi functions forward net's kerberos setting.

Guenther
(This used to be commit d46f648d2e25ad712138f02e5060288278f4c1b1)

11 years agonet: Use NetLocalGroupAdd() for adding aliases.
Günther Deschner [Thu, 31 Jul 2008 13:12:09 +0000 (15:12 +0200)]
net: Use NetLocalGroupAdd() for adding aliases.

Guenther
(This used to be commit 2ed4ce0bf1723e35a6c5dfa7f8fa58fb9c7ab469)

11 years agonetapi: in NetLocalGroupAdd_r() only set description if necessary.
Günther Deschner [Thu, 31 Jul 2008 13:11:20 +0000 (15:11 +0200)]
netapi: in NetLocalGroupAdd_r() only set description if necessary.

Guenther
(This used to be commit 7e9fa2c5396d3663e83ffbf90475473fdb509871)

11 years agolibnetunjoin: add use_kerberos flag.
Günther Deschner [Thu, 31 Jul 2008 12:23:23 +0000 (14:23 +0200)]
libnetunjoin: add use_kerberos flag.

Guenther
(This used to be commit 2b262ca20de2a41833f68a88646a8df4d9507782)

11 years agonet: add "-k" switch for kerberos authentication (in preparation for #5416).
Günther Deschner [Wed, 30 Jul 2008 19:37:09 +0000 (21:37 +0200)]
net: add "-k" switch for kerberos authentication (in preparation for #5416).

Guenther
(This used to be commit 4cce94d464b16d29b638da3a581d98a237959b63)

11 years agolibnetjoin: add use_kerberos flag.
Günther Deschner [Wed, 30 Jul 2008 19:36:28 +0000 (21:36 +0200)]
libnetjoin: add use_kerberos flag.

Guenther
(This used to be commit 956c949dc739a8b3e9de3bb6f1af8e0e8b18dc98)

11 years agorpc_client: use init_samr_CryptPassword(Ex) in client tools.
Günther Deschner [Wed, 30 Jul 2008 17:52:56 +0000 (19:52 +0200)]
rpc_client: use init_samr_CryptPassword(Ex) in client tools.

Guenther
(This used to be commit 97f7f9f21f17e8414de15953cf4eaa9959dc6f75)

11 years agoFix uninitialized variables.
Jeremy Allison [Wed, 30 Jul 2008 23:06:30 +0000 (16:06 -0700)]
Fix uninitialized variables.
Jeremy.
(This used to be commit 1db7e00a5400863fd5dbb81c1a4c6ea6092d0495)

11 years agoFix duplicate gloabl warning.
Jeremy Allison [Wed, 30 Jul 2008 22:01:33 +0000 (15:01 -0700)]
Fix duplicate gloabl warning.
Jeremy.
(This used to be commit 6da33797b0549a2da7dc0fa7ee21dc5e8a6b1459)

11 years agoRemoved redundant logging from create_builtin_users and create_builtin_administrators
Tim Prouty [Wed, 30 Jul 2008 16:35:13 +0000 (09:35 -0700)]
Removed redundant logging from create_builtin_users and create_builtin_administrators

The Debug messages in create_builtin_users and create_builtin_users have now
been encapsulated in add_sid_to_builtin.
(This used to be commit ca153139b1dced07c196aac93dbc9d9428d98124)

11 years agoEnabled domain groups to be added to builtin groups at domain join time
Tim Prouty [Thu, 24 Jul 2008 03:50:21 +0000 (20:50 -0700)]
Enabled domain groups to be added to builtin groups at domain join time

Previously this was done at token creation time if the Administrators and Users
builtins hadn't been created yet.  A major drawback to this approach is that if
a customer is joined to a domain and decides they want to join a different
domain, the domain groups from this new domain will not be added to the
builtins.

It would be ideal if these groups could be added exclusively at domain join
time, but we can't rely solely on that because there are cases where winbindd
must be running to allocate new gids for the builtins.  In the future if there
is a way to allocate gids for builtins without running winbindd, this code
can be removed from create_local_nt_token.

- Made create_builtin_users and create_builtin_administrators non-static so
they can be called from libnet
- Added a new function to libnet_join that will make a best effort to add
domain administrators and domain users to BUILTIN\Administrators and
BUILTIN\Users, respectively.  If the builtins don't exist yet, winbindd must be
running to allocate new gids, but if the builtins already exist, the domain
groups will be added even if winbindd is not running.  In the case of a
failure the error will be logged, but the join will not be failed.
- Plumbed libnet_join_add_dom_rids_to_builtins into the join post processing.
(This used to be commit e92faf5996cadac480deb60a4f6232eea90b00f6)

11 years agoRefactored the code that adds Domain Admins to BUILTIN\Administrators to use the...
Tim Prouty [Thu, 24 Jul 2008 03:42:32 +0000 (20:42 -0700)]
Refactored the code that adds Domain Admins to BUILTIN\Administrators to use the new helper functions.

- Modified create_builtin_administrators and add_builtin_administrators to take
in the domain sid to reduce the number of times it needs to be looked up.
- Changed create_builtin_administrators to call the new helper functions.
- Changed create_local_nt_token to call the new version of
create_builtin_administrators and handle the new error that can be returned.
- Made it more explicit that add_builtin_administrators is only called when
winbindd can't be pinged.
(This used to be commit f6411ccb4a1530034e481e1c63b6114a93317b29)

11 years agoRefactored the code that adds Domain Users to BUILTIN\Users to use the new helper...
Tim Prouty [Thu, 24 Jul 2008 03:33:15 +0000 (20:33 -0700)]
Refactored the code that adds Domain Users to BUILTIN\Users to use the new helper functions.

- Modified create_builtin_users to take in the domain sid to reduce the number
of times it needs to be looked up.
- Changed create_builtin_users to call the new helper functions.
- Changed create_local_nt_token to call the new version of create_builtin_users
and handle the new error that can be returned.
(This used to be commit 8d75d40b9f6d22bae7430211f8a1fe99051b756c)

11 years agoHelper functions to enable domain groups to be added to builtin groups at domain...
Tim Prouty [Thu, 24 Jul 2008 03:24:39 +0000 (20:24 -0700)]
Helper functions to enable domain groups to be added to builtin groups at domain join time

Added two new helper functions which wrap the raw pdb alias functions so they
can be more conveniently called while adding domain groups to builtin groups.
(This used to be commit 668ef314559df40f1b8aa0991539adcd8d35ffe3)

11 years agorpc_client: Bug 5616 - fix session keys also in rpccli_netr_LogonSamLogonEx wrapper.
Günther Deschner [Wed, 30 Jul 2008 17:03:13 +0000 (19:03 +0200)]
rpc_client: Bug 5616 - fix session keys also in rpccli_netr_LogonSamLogonEx wrapper.

Guenther
(This used to be commit fef58091408cce0d7870c86f28f78cf9400cf2b6)

11 years agobuild: fix some no previous prototype warnings.
Günther Deschner [Wed, 30 Jul 2008 15:47:40 +0000 (17:47 +0200)]
build: fix some no previous prototype warnings.

Guenther
(This used to be commit 51062534fd58d7a914a6bbac2e52bb44e71363b7)

11 years agowinbindd: handle trusted domains without sid.
Günther Deschner [Tue, 29 Jul 2008 10:08:47 +0000 (12:08 +0200)]
winbindd: handle trusted domains without sid.

Guenther
(This used to be commit 0c1efc6c89b1a51a94d10971bf0fc515416709b3)

11 years agolibwbclient: let wbcStringToSid handle the global NULL sid.
Günther Deschner [Wed, 30 Jul 2008 14:59:11 +0000 (16:59 +0200)]
libwbclient: let wbcStringToSid handle the global NULL sid.

Guenther
(This used to be commit 09fed085bea9dae5bb8aacd986deed3d458e3574)

11 years agonetapi: add NetGroupGetUsers example code.
Günther Deschner [Fri, 18 Jul 2008 22:10:58 +0000 (00:10 +0200)]
netapi: add NetGroupGetUsers example code.

Guenther
(This used to be commit 0298f7fe9e273a94d14b5b6ce3dbd5e6deee9ecb)

11 years agonetapi: add NetGroupGetUsers to public header.
Günther Deschner [Fri, 18 Jul 2008 21:43:33 +0000 (23:43 +0200)]
netapi: add NetGroupGetUsers to public header.

Guenther
(This used to be commit d31f822b79ed5344ec3c6795d66ceefd024b7d30)

11 years agonetapi: add NetGroupGetUsers skeleton.
Günther Deschner [Fri, 18 Jul 2008 21:40:33 +0000 (23:40 +0200)]
netapi: add NetGroupGetUsers skeleton.

GUenther
(This used to be commit 0b4e2687ae8fb48faacceb4078d61f9fd2acea9d)

11 years agore-run make idl.
Günther Deschner [Fri, 18 Jul 2008 21:38:17 +0000 (23:38 +0200)]
re-run make idl.

Guenther
(This used to be commit 93ff6548977cb3e1c84fcb659475664de54e31b5)

11 years agonetapi: add NetGroupGetUsers to IDL.
Günther Deschner [Fri, 18 Jul 2008 21:37:31 +0000 (23:37 +0200)]
netapi: add NetGroupGetUsers to IDL.

Guenther
(This used to be commit 81be6207e51924a7632dfc0ec16ca3e570d417aa)

11 years agore-run make idl.
Günther Deschner [Fri, 18 Jul 2008 21:36:50 +0000 (23:36 +0200)]
re-run make idl.

Guenther
(This used to be commit ec2a56b5e726400f171d641587cbd0a4b99beec0)

11 years agonetapi: add some more USER_INFO structs to IDL.
Günther Deschner [Fri, 18 Jul 2008 21:36:26 +0000 (23:36 +0200)]
netapi: add some more USER_INFO structs to IDL.

Guenther
(This used to be commit 49ea8984e95618ff8dc8f1d5d757aec997899fd7)

11 years agonetapi: fix libnetapi_samr_lookup_user_map_USER_INFO.
Günther Deschner [Fri, 18 Jul 2008 21:35:33 +0000 (23:35 +0200)]
netapi: fix libnetapi_samr_lookup_user_map_USER_INFO.

Guenther
(This used to be commit 52218506d6ad51c4f340206d035f79272ba15e3b)

11 years agonetapi: use "buffer" in libnetapi.
Günther Deschner [Fri, 18 Jul 2008 21:33:08 +0000 (23:33 +0200)]
netapi: use "buffer" in libnetapi.

Guenther
(This used to be commit 80957bc1bc1462a2478b3eea64f5cb7a84d08677)

11 years agore-run make idl.
Günther Deschner [Fri, 18 Jul 2008 21:31:17 +0000 (23:31 +0200)]
re-run make idl.

Guenther
(This used to be commit c4131c995d8b36c01b68160e0277b7c3610e9619)

11 years agonetapi: cosmetics, use "buffer" everywhere.
Günther Deschner [Fri, 18 Jul 2008 21:30:36 +0000 (23:30 +0200)]
netapi: cosmetics, use "buffer" everywhere.

Guenther
(This used to be commit 25522f0de081e819d661728f7f6767037e514094)

11 years agonetapi: use init_samr_CryptPasswordEx and init_samr_CryptPassword.
Günther Deschner [Fri, 18 Jul 2008 18:43:14 +0000 (20:43 +0200)]
netapi: use init_samr_CryptPasswordEx and init_samr_CryptPassword.

Guenther
(This used to be commit 97106199f1a2add886a14523aa7b402667d2cd89)

11 years agorpc_client: add init_samr_CryptPasswordEx and init_samr_CryptPassword.
Günther Deschner [Fri, 18 Jul 2008 18:42:55 +0000 (20:42 +0200)]
rpc_client: add init_samr_CryptPasswordEx and init_samr_CryptPassword.

Guenther
(This used to be commit 87b6aac13598a2ac28054de5ab90d63bef65f1fe)

11 years agonetapi: implement NetUserSetInfo_r() for at least level 1007.
Günther Deschner [Fri, 18 Jul 2008 18:12:45 +0000 (20:12 +0200)]
netapi: implement NetUserSetInfo_r() for at least level 1007.

Guenther
(This used to be commit ff9bcd57738aa04c5e18e0e21dd0e788127317c4)

11 years agonetapi: add convert_USER_INFO_X_to_samr_user_info21 fn and use it NetUserAdd.
Günther Deschner [Fri, 18 Jul 2008 18:12:13 +0000 (20:12 +0200)]
netapi: add convert_USER_INFO_X_to_samr_user_info21 fn and use it NetUserAdd.

Guenther
(This used to be commit c3e4c7cb5f2728a8219789aeb2344bff368713d5)

11 years agore-run make idl.
Günther Deschner [Fri, 18 Jul 2008 17:40:26 +0000 (19:40 +0200)]
re-run make idl.

Guenther
(This used to be commit 244ad49e6a993a0e3c56c5a19d38918be9deca3b)

11 years agonetapi: add USER_INFO_X to IDL.
Günther Deschner [Fri, 18 Jul 2008 17:40:13 +0000 (19:40 +0200)]
netapi: add USER_INFO_X to IDL.

Guenther
(This used to be commit 6c8ee639ecc789ea9052e999b6e998ac53ac521a)

11 years agonetapi: add netapi testsuite.
Günther Deschner [Fri, 18 Jul 2008 17:12:42 +0000 (19:12 +0200)]
netapi: add netapi testsuite.

Guenther
(This used to be commit 8b3149b4a663f59b504c1458cd7ecafe0c0e0322)

11 years agonetapi: fix NetLocalGroupAdd.
Günther Deschner [Fri, 18 Jul 2008 18:10:37 +0000 (20:10 +0200)]
netapi: fix NetLocalGroupAdd.

Guenther
(This used to be commit d4594a7a03381fb251c9f8caf4c70e1ed97674b6)

11 years agotestparm: Display warning if invalid values are used.
Michael Adam [Wed, 30 Jul 2008 14:24:20 +0000 (16:24 +0200)]
testparm: Display warning if invalid values are used.

This one came up while using "csc policy = disabled" instead of
"disable"... ;-)
(This used to be commit d01da44de77abbf724389bce924771f2975867f4)

11 years agopdb_interface: Fix typo in debug message.
Karolin Seeger [Tue, 29 Jul 2008 10:05:40 +0000 (12:05 +0200)]
pdb_interface: Fix typo in debug message.

Karolin
(This used to be commit e04da654c0db6b0fb2e2ce9754e5eba80751c14c)

11 years agoman pages: Fix typos in man smbclient.
Karolin Seeger [Tue, 29 Jul 2008 10:03:08 +0000 (12:03 +0200)]
man pages: Fix typos in man smbclient.

Karolin
(This used to be commit db843d2faafb3487e3c7df4a3a52d6c71f369e1d)

11 years agoAttempt to fix bug 5616
Volker Lendecke [Mon, 28 Jul 2008 15:52:35 +0000 (17:52 +0200)]
Attempt to fix bug 5616

We were calculating the session key but did not return it to the caller...
(cherry picked from commit 8ab79b1d009d53e414b90e4a0ab8fc7a4889b6df)
(This used to be commit b63a6a1fd6a96bbafd88cacb9493bfea9944d404)

11 years agorun "make idl" after idl change to unify Primary:Kerberos* structs (e8ae49f)
Michael Adam [Mon, 28 Jul 2008 12:17:11 +0000 (14:17 +0200)]
run "make idl" after idl change to unify Primary:Kerberos* structs (e8ae49f)

Michael
(This used to be commit 6dd1582e3583ed3c0766db552a368ddb30af5f7d)

11 years agodrsblobs.idl: unify the Primary:Kerberos and Primary:Kerberos-Newer-Keys structs
Stefan Metzmacher [Thu, 24 Jul 2008 06:20:06 +0000 (08:20 +0200)]
drsblobs.idl: unify the Primary:Kerberos and Primary:Kerberos-Newer-Keys structs

metze
(cherry picked from commit 4b79a7678571ac2f7d5f827913fdcb419f5d2e20)
(This used to be commit e8ae49fc2aadfeee696ad7fde1fee643e167537c)

11 years agorun "make idl" after idl change "give some unknowns a meaning" (67de745)
Michael Adam [Mon, 28 Jul 2008 12:15:27 +0000 (14:15 +0200)]
run "make idl" after idl change "give some unknowns a meaning" (67de745)

Michael
(This used to be commit e5d95c4f41c2fe25920b0b707f637a562cb23ed8)

11 years agodrsblobs.idl: give some unknowns a meaning
Stefan Metzmacher [Thu, 24 Jul 2008 05:53:55 +0000 (07:53 +0200)]
drsblobs.idl: give some unknowns a meaning

metze
(cherry picked from commit 231e6f5ab2dc8a3e991a9872be252cffff6f14c6)
(This used to be commit 67de7455b66b6c6c959e5e4ca1b8d97e2f4cf71d)

11 years agorpcclient: Set the pid filed of the outgoing DsBindInfo to 0.
Michael Adam [Mon, 28 Jul 2008 12:08:34 +0000 (14:08 +0200)]
rpcclient: Set the pid filed of the outgoing DsBindInfo to 0.

This is for debugging and informational purposes only.
The assignment is implementation specific.
(WSPP docs, sec. 5.35).

Michael
(This used to be commit 18ea033909a5363c92530ed2a06a2b89be5e7c79)

11 years agoFix a debug message
Volker Lendecke [Sun, 27 Jul 2008 16:41:19 +0000 (18:41 +0200)]
Fix a debug message
(This used to be commit 1970eed1b79a5d9dc45eb96098d653ad62a20871)

11 years agoRemove a pointless CONST_DISCARD
Volker Lendecke [Sun, 27 Jul 2008 16:37:00 +0000 (18:37 +0200)]
Remove a pointless CONST_DISCARD
(This used to be commit c63cb78b4c8a283c0eebe37ff2f60ddbfbfaac4a)

11 years agoFix srvsvc_Net[Get|Set]FileSecurity
Volker Lendecke [Sun, 27 Jul 2008 15:59:15 +0000 (17:59 +0200)]
Fix srvsvc_Net[Get|Set]FileSecurity

There were two bugs in those routines: They did not send INTERNAL_OPEN_ONLY to
open_file_ntcreate() and they did not chdir, so the file could never be found.

While there I decided to remove the become_root() calls and call create_file()
instead of the lower-level routines.
(This used to be commit 669771738422776f8c81086ffea4924b62d72957)

11 years agoMake create_conn_struct() public
Volker Lendecke [Sun, 27 Jul 2008 15:56:48 +0000 (17:56 +0200)]
Make create_conn_struct() public
(This used to be commit e115e2582256c34e6905afc8c2929efd6ea61088)

11 years agoRemove unused extern struct current_user from substitute.c
Volker Lendecke [Sat, 26 Jul 2008 22:20:37 +0000 (00:20 +0200)]
Remove unused extern struct current_user from substitute.c

A bit hard to believe, but substitute.c does not use current_user anymore.
(This used to be commit de5d27d70abcad996af91b4e93879fc415f2b38d)

11 years agoSave 128 byte (32-bit platform) or 256 byte (64-bit) per connection_struct
Volker Lendecke [Sat, 26 Jul 2008 14:51:00 +0000 (16:51 +0200)]
Save 128 byte (32-bit platform) or 256 byte (64-bit) per connection_struct

This was just too easy not to use :-)
(This used to be commit a9922a2a3661a6cff7351ea6b3558f091bb45feb)

11 years agomake read/write to internal pipes available externally
Volker Lendecke [Sat, 12 Jul 2008 10:56:00 +0000 (12:56 +0200)]
make read/write to internal pipes available externally
(This used to be commit e11b5cb1e061caf4c3793fb402ca6bee95a8f26c)

11 years agoRefactoring: Make close_internal_rpc_pipe_hnd a talloc destructor
Volker Lendecke [Sat, 12 Jul 2008 10:25:42 +0000 (12:25 +0200)]
Refactoring: Make close_internal_rpc_pipe_hnd a talloc destructor
(This used to be commit 10b47a0c2cfd62489428518112da82f73a52b7bc)

11 years agoRefactor make_internal_rpc_pipe_p: connection_struct is not needed
Volker Lendecke [Sat, 12 Jul 2008 10:20:08 +0000 (12:20 +0200)]
Refactor make_internal_rpc_pipe_p: connection_struct is not needed
(This used to be commit defcf0eecfb8eb035d9ca80530720b9e6873f6c7)

11 years agoCreate doxygen comments for async_req.[ch]
Volker Lendecke [Sat, 28 Jun 2008 21:13:05 +0000 (23:13 +0200)]
Create doxygen comments for async_req.[ch]
(This used to be commit 1dab45b16a23b1126fbf29890747a2b256f08968)

11 years agoMake api_rpcTNP static to srv_pipe.c
Volker Lendecke [Sat, 26 Jul 2008 09:25:24 +0000 (11:25 +0200)]
Make api_rpcTNP static to srv_pipe.c
(This used to be commit 256c93a8b3d4d9a4e52a656c91b89a043a087066)

11 years agoFix an incompatible pointer warning
Volker Lendecke [Fri, 25 Jul 2008 21:30:53 +0000 (23:30 +0200)]
Fix an incompatible pointer warning
(cherry picked from commit 3282f7289b7b33beeaa1ca649651cca6537a69af)
(This used to be commit fc8641443951dc852dc9cf1e73626df452b815f7)

11 years agoFix bug creating files using DOS clients with mixed
Jeremy Allison [Fri, 25 Jul 2008 20:16:18 +0000 (13:16 -0700)]
Fix bug creating files using DOS clients with mixed
case files. Reported by Daniel Johnson <Progman2000@usa.net>.
The smb_set_file_time() call to set the filetimes is failing
because it's using the unmodified name passed in by the
client, not the modified name (matching case on the
disk) that comes out from create_file().
Jeremy.
(This used to be commit 1706a33e78347d14a8b09fd21b87d57bad543bcd)

11 years agoFix a race condition in winbind leading to a crash
Volker Lendecke [Fri, 25 Jul 2008 10:08:03 +0000 (12:08 +0200)]
Fix a race condition in winbind leading to a crash

When SIGCHLD handling is delayed for some reason, sending a request to a child
can fail early because the child has died already. In this case
async_main_request_sent() directly called the continuation function without
properly removing the malfunctioning child process and the requests in the
queue. The next request would then crash in the DLIST_ADD_END() in
async_request() because the request pending for the child had been
talloc_free()'ed and yet still was referenced in the list.

This one is *old*...

Volker
(cherry picked from commit 8691709626b0d461de91b8fc9d10c730d1f183dd)
(This used to be commit c70e2b6476d2d99c79624e15a4a3cfcdc850fc7c)

11 years agotalloc_string_sub2: Don't return NULL if src is empty.
Karolin Seeger [Wed, 23 Jul 2008 15:07:56 +0000 (17:07 +0200)]
talloc_string_sub2: Don't return NULL if src is empty.

This fixes BUG #5635.

Finished print jobs were not removed from the $PRINTER.tdb file if
"printing=cups".

In print_queue_update, talloc_string_sub2 is used to assemble the
"lprm command". In the case of using "printing=cups", the default
"lprm command" is an empty string. talloc_string_sub2 is called with
this empty string and returns NULL which leads to exiting
print_queue_update without doing the actual print queue update.

Signed-off by Michael Adam <obnox@samba.org>
(This used to be commit 03d66554d1bbd9d6c72a3dd5203e5305343c76b8)

11 years agoIf we're not allowing streams on this conn ptr,
Jeremy Allison [Fri, 25 Jul 2008 01:12:12 +0000 (18:12 -0700)]
If we're not allowing streams on this conn ptr,
then don't allow create_file() to call down to
create_file_unixpath() with a stream name.
Jeremy.
(This used to be commit 167d611b525db6d103a7f83fd5a19792be4e7745)

11 years agoRemove trailing withespace from wbinfo -m which breaks gdm auth.
Andreas Schneider [Mon, 21 Jul 2008 09:52:10 +0000 (11:52 +0200)]
Remove trailing withespace from wbinfo -m which breaks gdm auth.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
(This used to be commit 12848e8eb91bf60551ada78e3430ee25142e366b)

11 years agoAdd casts to uint32_t to match prototype for sid_append_rid().
Jeremy Allison [Thu, 24 Jul 2008 19:01:46 +0000 (12:01 -0700)]
Add casts to uint32_t to match prototype for sid_append_rid().
Jeremy.
(This used to be commit 15004019676a5d860f9d5fbfbecbd31fcec8bf5b)

11 years agoUse sys_getgrnam not getgrnam. Pointed out by Herb.
Jeremy Allison [Thu, 24 Jul 2008 18:56:49 +0000 (11:56 -0700)]
Use sys_getgrnam not getgrnam. Pointed out by Herb.
Jeremy.
(This used to be commit 43eec6517023e7865618791c231e54cc1b800ceb)

11 years agoMerge branch 'v3-3-test' of git+ssh://sfrench@git.samba.org/data/git/samba into v33
Steve French [Thu, 24 Jul 2008 14:35:20 +0000 (09:35 -0500)]
Merge branch 'v3-3-test' of git+ssh://sfrench@git.samba.org/data/git/samba into v33
(This used to be commit 22afe367fef35d4262d960973933023a0a5ce77d)

11 years agocifs.upcall was not recognizing the newer name "dns_resolver" key type
Steve French [Thu, 24 Jul 2008 14:32:53 +0000 (09:32 -0500)]
cifs.upcall was not recognizing the newer name "dns_resolver" key type
(as a synonym for the older "cifs.resolver" name) when resolving host
names to ip addresses for the kernel.

Acked-by: Jeff Layton
(This used to be commit 22c36b27c60193102b3153e073216865adb1b6c1)

11 years agoRemove unused request_finished_cont()
Volker Lendecke [Thu, 24 Jul 2008 12:58:21 +0000 (14:58 +0200)]
Remove unused request_finished_cont()
(This used to be commit 865ea6fcbc089a03e453709fa54ff2a39c0c168e)

11 years agoMake use of TALLOC_FREE when freeing the per-winbindrequest memory context
Volker Lendecke [Thu, 24 Jul 2008 12:46:43 +0000 (14:46 +0200)]
Make use of TALLOC_FREE when freeing the per-winbindrequest memory context
(This used to be commit 9e49d390f79c6afc8b0efd9664e60602aebaa4f2)

11 years agopdb_ldap: Raise level for debug message to avoid log file flooding.
John H Terpstra [Thu, 24 Jul 2008 07:45:02 +0000 (09:45 +0200)]
pdb_ldap: Raise level for debug message to avoid log file flooding.
(This used to be commit 9b863a10da8762f715c16f147d6cd1e79422d248)

11 years agore-run "make idl" after adding idl for idl for Primary:Kerberos-Newer-Keys
Michael Adam [Wed, 23 Jul 2008 21:10:34 +0000 (23:10 +0200)]
re-run "make idl" after adding idl for idl for Primary:Kerberos-Newer-Keys

Michael
(This used to be commit d78667c88515aa4fffc49b44c00f470f7d25bd4d)

11 years agodrsblobs.idl: add idl for Primary:Kerberos-Newer-Keys blob in supplementalCredentials
Stefan Metzmacher [Tue, 22 Jul 2008 10:28:07 +0000 (12:28 +0200)]
drsblobs.idl: add idl for Primary:Kerberos-Newer-Keys blob in supplementalCredentials

metze
(cherry picked from commit 97b7901afbccc9647ad2958d4cf12300de2655d1)
(This used to be commit 5db983d1538453f0ba35d67a099396a18c7ab736)

11 years agore-run "make idl" after fixing unknowns in package_PrimaryKerberos (drsblobs.idl)
Michael Adam [Wed, 23 Jul 2008 21:06:30 +0000 (23:06 +0200)]
re-run "make idl" after fixing unknowns in package_PrimaryKerberos (drsblobs.idl)

Michael
(This used to be commit a5de166833631dbc8450277d180c69086deacd4b)

11 years agodrsblobs.idl: fix unknowns in package_PrimaryKerberos idl
Stefan Metzmacher [Wed, 23 Jul 2008 06:53:34 +0000 (08:53 +0200)]
drsblobs.idl: fix unknowns in package_PrimaryKerberos idl

metze
(cherry picked from commit da9ceb2bf17f964334d9317829d40483e2c04b10)
(This used to be commit 5459745369092a4d48fee18fb1be53f195405370)

11 years agore-run "make idl" after fixing idl for supplementalCredentialsSubBlob.
Michael Adam [Wed, 23 Jul 2008 21:02:09 +0000 (23:02 +0200)]
re-run "make idl" after fixing idl for supplementalCredentialsSubBlob.

Michael
(This used to be commit e33af40ad41816531c3189ef146f192a902d3229)

11 years agodrsblobs.idl: fix idl for supplementalCredentialsSubBlob
Stefan Metzmacher [Wed, 23 Jul 2008 11:06:32 +0000 (13:06 +0200)]
drsblobs.idl: fix idl for supplementalCredentialsSubBlob

metze
(cherry picked from commit 24c5b10136f6e640832193aaf9e6d7e865c288bc)
(This used to be commit 38aca9c11783daf30e19b4951451ec9a6b85cd30)

11 years agore-run "make idl" after changing unknown1->reserved in drsblobs.idl
Michael Adam [Wed, 23 Jul 2008 20:42:18 +0000 (22:42 +0200)]
re-run "make idl" after changing unknown1->reserved in drsblobs.idl

Michael
(This used to be commit 398702a818a0c292ab5b4f76be95168de83ffa25)

11 years agodrsblobs.idl: rename unknown1 -> reserved
Stefan Metzmacher [Wed, 23 Jul 2008 11:53:03 +0000 (13:53 +0200)]
drsblobs.idl: rename unknown1 -> reserved

metze
(This used to be commit fb0379aede4665987679c2e1b5ae943f124804b6)

11 years agocifs.upcall: fix compile warning
Steve French [Wed, 23 Jul 2008 19:25:17 +0000 (14:25 -0500)]
cifs.upcall: fix compile warning

Steve French noticed these warnings when building cifs.upcall:

   Compiling client/cifs.upcall.c
   client/cifs.upcall.c: In function 'usage':
   client/cifs.upcall.c:204: warning: declaration of 'prog' shadows a global declaration
   client/cifs.upcall.c:33: warning: shadowed declaration is here

Change the usage function to not take and arg and have it just use the global
"prog" variable. Fix a typo in the log message generated when an unknown
option is specified. Also getopt() always returns '?' when it sees an unknown
option so there's no point in printing it out.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
(This used to be commit 4b8362f9777debd21c47154e786b7017fbf847f7)

11 years agorpc_parse: Unify spoolss debug messages.
Karolin Seeger [Tue, 22 Jul 2008 19:43:43 +0000 (21:43 +0200)]
rpc_parse: Unify spoolss debug messages.

Karolin
(This used to be commit 5ab391d466ce9ddea31f6f6bf467aa6c5f3a7efb)

11 years agoChange occurrences of the u1 member of DsBindInfo* to pid after idl change.
Michael Adam [Tue, 22 Jul 2008 14:18:03 +0000 (16:18 +0200)]
Change occurrences of the u1 member of DsBindInfo* to pid after idl change.

Michael
(This used to be commit 42f3d681cac4a443347d1ed253848d45f8746f89)

11 years agore-run "make idl" after changing u1 member to pid in DsBindInfo*.
Michael Adam [Tue, 22 Jul 2008 14:15:15 +0000 (16:15 +0200)]
re-run "make idl" after changing u1 member to pid in DsBindInfo*.

Michael
(This used to be commit d08e8c4738cfd7785d3b9a2c828c27cc8bc0c6f7)

11 years agodrsuapi.idl: change the u1 field in DsBindInfo* to "pid".
Michael Adam [Tue, 22 Jul 2008 13:33:26 +0000 (15:33 +0200)]
drsuapi.idl: change the u1 field in DsBindInfo* to "pid".

According to the WSPP docs, section 5.35,
this is the "process identifyer" of the client.
It is meant for informational and debugging purposes
only and its assignment is implementation specific.

Michael
(This used to be commit 5c2119ba63a5a119e1b8f055779e5c398333f177)

11 years agoCheck for f_frsize when using statvfs
Zach Loafman [Thu, 3 Jul 2008 18:52:53 +0000 (11:52 -0700)]
Check for f_frsize when using statvfs

Add a configure test for the availability of f_frsize in struct statvfs
(for broken platforms that define statvfs but still have
f_bsize/f_iosize). Also add sys/types.h to the other struct statvfs test
(again, some platforms need it).
(This used to be commit 591bf1d15ff3b93db908cc3a4b6e10d09e5b74b6)

11 years agoMake DSO_EXPORTS_CMD regexp more POSIX compliant
Zach Loafman [Wed, 9 Jul 2008 07:05:50 +0000 (00:05 -0700)]
Make DSO_EXPORTS_CMD regexp more POSIX compliant

The FreeBSD sed command doesn't understand \? without passing -E to turn
on extended regexps. This patch changes the DSO_EXPORTS_CMD regexp to a
POSIX compliant RE by switching the \+ to a \{1,\} bound and the \? to a
\{0,1\} bound.
(This used to be commit 0acc888ca91a7401c5e54388c58272e263f73069)