samba.git
16 years agor15094: Replace ; by # where we have a comment and remove superfluous spaces at
Lars Müller [Sat, 15 Apr 2006 21:24:32 +0000 (21:24 +0000)]
r15094: Replace ; by # where we have a comment and remove superfluous spaces at
the end of lines.
(This used to be commit 27044d23ffbb2de0405e85b8ae184d12aa1e1f32)

16 years agor15093: Align to the last winbind changes.
Lars Müller [Sat, 15 Apr 2006 13:45:27 +0000 (13:45 +0000)]
r15093: Align to the last winbind changes.
(This used to be commit 74fa3a2554b769382b2b3b43adfbc0cfbca3cd10)

16 years agor15088: Remove all time() and gettimeofday() calls out of the mainline
Jeremy Allison [Sat, 15 Apr 2006 04:07:10 +0000 (04:07 +0000)]
r15088: Remove all time() and gettimeofday() calls out of the mainline
packet processing code. Only do these when needed (ie. in the
idle timeout code). We drop an unneccessary global here too.
Jeremy.
(This used to be commit 8272a5ab0605fcf95527143c4f909aa1008e5b94)

16 years agor15086: Get defensive about creating user accounts when winbindd
Gerald Carter [Fri, 14 Apr 2006 19:36:36 +0000 (19:36 +0000)]
r15086: Get defensive about creating user accounts when winbindd
fails (but is present).
(This used to be commit 77fb19c45dcb07f5b675831979fbd74a99e30638)

16 years agor15084: Try and squeeze more out of the non-read/write code path.
Jeremy Allison [Fri, 14 Apr 2006 03:55:42 +0000 (03:55 +0000)]
r15084: Try and squeeze more out of the non-read/write code path.
Jeremy.
(This used to be commit 23dcff4d50d1d35b7ddee0d0cb79c16a312f179c)

16 years agor15083: Using talloc with destructors is nice and all, but in this
Jeremy Allison [Thu, 13 Apr 2006 22:22:54 +0000 (22:22 +0000)]
r15083: Using talloc with destructors is nice and all, but in this
case it's in a performace critical path and it *hurts* us.
Go back to plain malloc/free with an explicit destructor
call.
Jeremy.
(This used to be commit 1c99aed563c29e1b3d70939878af747a0660bfec)

16 years agor15080: As discussed with Jerry, remove the CAP_LIBS again (we don't need that
Günther Deschner [Thu, 13 Apr 2006 15:53:51 +0000 (15:53 +0000)]
r15080: As discussed with Jerry, remove the CAP_LIBS again (we don't need that
handling anymore when we remove $(LIBS) from pam_winbind again.

Also make sure to build our own copy of iniparser with -fPIC.

Guenther
(This used to be commit e32c4f6f6e090ca5babe9f131bbcb9babedcec05)

16 years agor15074: Remove -lcap from pam_winbind (not needed)
Gerald Carter [Thu, 13 Apr 2006 12:06:01 +0000 (12:06 +0000)]
r15074: Remove -lcap from pam_winbind (not needed)
Temporary linking fix for --with-included-iniparser
(gd will do a proper fix later).
(This used to be commit 7d5adcf3a7237d130efea6cc9f6e5d28e65e2e51)

16 years agor15072: Last bit of 32/64 bit portabilities fixes for winbind
Gerald Carter [Thu, 13 Apr 2006 12:03:12 +0000 (12:03 +0000)]
r15072: Last bit of 32/64 bit portabilities fixes for winbind
clients and aservers.  Strange compiler-fu on 64-bit
SLES9 says sizeof(time_t) == 4 but the memory alignment
is on 8 bytes.  Change time_t to uint32 to fix alignment.
Remove 'char **gr_mem' from struct winbindd_gr since
it was not being used.
(This used to be commit b68e66d5c4f7348e674b8a009656ebfbbc06e288)

16 years agor15068: Fix a shadowed variable warning
Volker Lendecke [Thu, 13 Apr 2006 10:14:07 +0000 (10:14 +0000)]
r15068: Fix a shadowed variable warning
(This used to be commit 066f69fe88b360b856f3dc49089f8c21b721cce9)

16 years agor15060: The brlock code gets called a lot. Ensure we keep the
Jeremy Allison [Wed, 12 Apr 2006 23:00:58 +0000 (23:00 +0000)]
r15060: The brlock code gets called a lot. Ensure we keep the
key around while we're using it - saves many calls to
locking_key() (now deleted).
Jeremy.
(This used to be commit 2f8b527dcf4a36fbb933ce79c720c0425de76b4a)

16 years agor15058: Add sample pam_winbind.conf file.
Günther Deschner [Wed, 12 Apr 2006 17:36:13 +0000 (17:36 +0000)]
r15058: Add sample pam_winbind.conf file.

Guenther
(This used to be commit 01e46b8c6e386e5009288db488e908dc6e75c805)

16 years agor15053: fix portabilities issues between 32-bit winbind clients and a 64-bit winbindd...
Gerald Carter [Wed, 12 Apr 2006 14:10:39 +0000 (14:10 +0000)]
r15053: fix portabilities issues between 32-bit winbind clients and a 64-bit winbindd server
(This used to be commit a95d11345e76948b147bbc1f29a05c978d99a47a)

16 years agor15047: Add support for using libunwind to generate a backtrace. This is
James Peach [Wed, 12 Apr 2006 00:07:40 +0000 (00:07 +0000)]
r15047: Add support for using libunwind to generate a backtrace. This is
primarily intended for ia64 systems where libunwind knows more about
the different ways of walking the stack that just about anything else.
(This used to be commit 256a19d722f360dac3c8e83f5bfac453fa70db96)

16 years agor15046: Fix bug #3490 reported by Jason Mader. Do not continue to check for LDAP
James Peach [Tue, 11 Apr 2006 23:32:04 +0000 (23:32 +0000)]
r15046: Fix bug #3490 reported by Jason Mader. Do not continue to check for LDAP
and AD requirements if --without-ldap and --without-ads have been given
to configure.
(This used to be commit 1d5e4830d33906da433655ecaf87300ed874b06f)

16 years agor15044: Fix the build. (void returning non-void).
Günther Deschner [Tue, 11 Apr 2006 17:00:08 +0000 (17:00 +0000)]
r15044: Fix the build. (void returning non-void).

Guenther
(This used to be commit 3ff278b852b4085461127bc7ccb2c5dba81fb3c8)

16 years agor15043: Only build our copy of iniparser when the system doesn't have one.
Günther Deschner [Tue, 11 Apr 2006 16:57:16 +0000 (16:57 +0000)]
r15043: Only build our copy of iniparser when the system doesn't have one.

Guenther
(This used to be commit 5ae22cf46b1077b8892a2941a2891fe7412f1b9f)

16 years agor15041: Adding rpc client calls to manipulate auditing policies on remote CIFS
Günther Deschner [Tue, 11 Apr 2006 15:47:24 +0000 (15:47 +0000)]
r15041: Adding rpc client calls to manipulate auditing policies on remote CIFS
servers. Also add a new "net rpc audit" tool. The lsa query infolevels
were taken from samb4 IDL, the lsa policy flags and categories are
partly documented on msdn. I need to cleanup the double
lsa_query_info_policy{2}{_new} calls next.

Guenther
(This used to be commit 0fed66926f4b72444abfc8ffb8c46cca8d0600aa)

16 years agor15040: Stripping the parametric options in pam_winbind and use
Günther Deschner [Tue, 11 Apr 2006 15:18:46 +0000 (15:18 +0000)]
r15040: Stripping the parametric options in pam_winbind and use
/etc/security/pam_winbind.conf as config file for the PAM module by
default.

Guenther
(This used to be commit 41b79ee80c7b0f4836ded51d42c7dc91cba75ccd)

16 years agor15039: Fix an uninitialized variable. I _think_ this should default to
Volker Lendecke [Tue, 11 Apr 2006 15:11:27 +0000 (15:11 +0000)]
r15039: Fix an uninitialized variable. I _think_ this should default to
PAM_SUCCESS. Günther, could you take a look?

Thanks,

Volker
(This used to be commit fc6effcd9c2bb2d15b7e8fba85cc3193d2d7ce1f)

16 years agor15038: Replace all code in pam_winbind that relied on access to samba
Günther Deschner [Tue, 11 Apr 2006 14:40:53 +0000 (14:40 +0000)]
r15038: Replace all code in pam_winbind that relied on access to samba
internals, mostly with the code that was in pam_winbind before.

Also switch from using loadparm to use iniParser to read the new
pam_winbind options from a configuration file. That still uses the old
(parametric) option names which will be replaced next (as iniParser does
not support parametric options).

Guenther
(This used to be commit 6f668ce67318f17bba79cd98b5d169cd19eafcd4)

16 years agor15037: Adding iniParser (http://ndevilla.free.fr/iniparser/), a free inifile
Günther Deschner [Tue, 11 Apr 2006 14:34:40 +0000 (14:34 +0000)]
r15037: Adding iniParser (ndevilla.free.fr/iniparser/), a free inifile
parsing library under the MIT licence.

This is required to have a configuration ini-file for pam_winbind
without using loadparm in the next step.

Guenther
(This used to be commit 6658e0a9886ee5a361361bc9b26c136ec91aea72)

16 years agor15035: It seems that many preprocessors do not like comments in macro args..
Volker Lendecke [Tue, 11 Apr 2006 06:39:51 +0000 (06:39 +0000)]
r15035: It seems that many preprocessors do not like comments in macro args..
(This used to be commit efc833dcba052e52c46eeba71a1ebe248be9cb05)

16 years agor15034: Attempt to make the build farm happy
Volker Lendecke [Tue, 11 Apr 2006 06:35:36 +0000 (06:35 +0000)]
r15034: Attempt to make the build farm happy
(This used to be commit 8b3e87184a3cc831fe0314c3b26b6d753cf74e4c)

16 years agor15030: On a performace hunt... Remove as many extraneous
Jeremy Allison [Tue, 11 Apr 2006 01:43:13 +0000 (01:43 +0000)]
r15030: On a performace hunt... Remove as many extraneous
memset's as possible.
Jeremy.
(This used to be commit 1217ed392b75aa8bfefa9c3f1ec5fa3bba841ee0)

16 years agor15028: Fix logic error checking valid args to POSIX lock
Jeremy Allison [Mon, 10 Apr 2006 23:32:05 +0000 (23:32 +0000)]
r15028: Fix logic error checking valid args to POSIX lock
call.
Jeremy.
(This used to be commit 44b0d856ae867d1c407507dcf7940dd39f4f963a)

16 years agor15026: Fix warning until POSIX locking finished.
Jeremy Allison [Mon, 10 Apr 2006 23:29:47 +0000 (23:29 +0000)]
r15026: Fix warning until POSIX locking finished.
Jeremy.
(This used to be commit 15f39a4c720e9645f941742310b6c6d7d7fc96d5)

16 years agor15025: Fix exit_server_cleanly call.
Jeremy Allison [Mon, 10 Apr 2006 22:57:12 +0000 (22:57 +0000)]
r15025: Fix exit_server_cleanly call.
Jeremy.
(This used to be commit a64976b94482ef4397d5b791a0e266edba5a3d0c)

16 years agor15022: Fix core dumps on normal server exit.
Jeremy Allison [Mon, 10 Apr 2006 22:47:09 +0000 (22:47 +0000)]
r15022: Fix core dumps on normal server exit.
Jeremy.
(This used to be commit 13c3abf03187f84874b5754b54de5d3fe2dea188)

16 years agor15020: Fix issue with samba4 netbench torture tester,
Jeremy Allison [Mon, 10 Apr 2006 18:44:27 +0000 (18:44 +0000)]
r15020: Fix issue with samba4 netbench torture tester,
it sends break replies to "break to none from level2"
requests and it shouldn't. Just don't log a debug
level zero message.
Jeremy.
(This used to be commit dc6a13da33a031d0c2374b692737dbe9215f0f74)

16 years agor15018: Merge Volker's ipc/trans2/nttrans changes over
Jeremy Allison [Mon, 10 Apr 2006 15:33:04 +0000 (15:33 +0000)]
r15018: Merge Volker's ipc/trans2/nttrans changes over
into 3.0. Also merge the new POSIX lock code - this
is not enabled unless -DDEVELOPER is defined.
This doesn't yet map onto underlying system POSIX
locks. Updates vfs to allow lock queries.
Jeremy.
(This used to be commit 08e52ead03304ff04229e1bfe544ff40e2564fc7)

16 years agor15012: Fix bug #2715. Fix suggested by ISHIKAWA Tomonori <toishika@fsi.co.jp>
Jeremy Allison [Sun, 9 Apr 2006 19:39:38 +0000 (19:39 +0000)]
r15012: Fix bug #2715. Fix suggested by ISHIKAWA Tomonori <toishika@fsi.co.jp>
No need to null terminate early, pull_ascii_fstring will do this.
Jeremy.
(This used to be commit b1bbe568313001f4b4e49382742e4b819c0a2b03)

16 years agor15011: Fix bug # 2413. net rpc info can't reliably work anonymously anymore.
Volker Lendecke [Sun, 9 Apr 2006 17:01:59 +0000 (17:01 +0000)]
r15011: Fix bug # 2413. net rpc info can't reliably work anonymously anymore.

Volker
(This used to be commit ba41c62b8b4d0c791035d63fb59496c0f655887f)

16 years agor15009: Add a check for NULL
Volker Lendecke [Sun, 9 Apr 2006 10:17:43 +0000 (10:17 +0000)]
r15009: Add a check for NULL
(This used to be commit 0a7d4f1ab109f57f5b5f4c1e83ad346b13b50778)

16 years agor15007: fixed usage of cli_list() in smbwrapper so it compiles. This doesn't get...
Andrew Tridgell [Sun, 9 Apr 2006 08:51:35 +0000 (08:51 +0000)]
r15007: fixed usage of cli_list() in smbwrapper so it compiles. This doesn't get smbwrapper really working again, but at least it will help Timur Bakeyev in his question to make it work
(This used to be commit e73ee08c84801f315f556d204007f053fda56dbf)

16 years agor15005: Fix printf args to remove warnings.
Jeremy Allison [Sun, 9 Apr 2006 01:20:26 +0000 (01:20 +0000)]
r15005: Fix printf args to remove warnings.
Jeremy.
(This used to be commit 68d100830c5a6fa24b863071e8ca77ab264175a0)

16 years agor15003: patch based on code from Arkady Glabek <aglabek@centeris.com> to ensure that...
Gerald Carter [Sat, 8 Apr 2006 17:25:31 +0000 (17:25 +0000)]
r15003: patch based on code from Arkady Glabek <aglabek@centeris.com> to ensure that global memory is freed when unloading pam_winbind.so (needs more testing on non-linux platforms)
(This used to be commit 1e0b79e591d70352a96e0a0487d8f394dc7b36ba)

16 years agor14989: Fix from Mathias Dietz <MDIETZ@de.ibm.com>. EPERM can be
Jeremy Allison [Sat, 8 Apr 2006 05:09:12 +0000 (05:09 +0000)]
r14989: Fix from Mathias Dietz <MDIETZ@de.ibm.com>. EPERM can be
a valid return from getting an xattr. Don't disable if
we get it.
Jeremy.
(This used to be commit 7769b678f22d8ab4aa8aef55966813355bf2ce6d)

16 years agor14986: Fix OS/2 directory delete bug found by kukks.
Jeremy Allison [Sat, 8 Apr 2006 05:00:04 +0000 (05:00 +0000)]
r14986: Fix OS/2 directory delete bug found by kukks.
(Thanks a lot for all your hard work on this).
We were caching the results of *all* directory
scans, not just the results that match the
client wildcard. This actually made no sense,
as only matches on the client wildcard can be
returned to the client and so might need to
be searched for in the cache. This fixes the
directory cache to only cache entries that we
return to the client.
Jeremy.
(This used to be commit c88af597d042390ff11b26fe802b0b10d0faa6ce)

16 years agor14954: Fix #3569 based on William Jojo's work. AIX also
Jeremy Allison [Thu, 6 Apr 2006 22:31:45 +0000 (22:31 +0000)]
r14954: Fix #3569 based on William Jojo's work. AIX also
has the linear posix locking issue which causes
CLEAR_IF_FIRST to cause performance problems.
As we know we're in a daemon architecture with
long-lived parent we can avoid this in the Samba
case. Add a comment explaining this.
Jeremy.
(This used to be commit 3cd5c3df0d1b98dfa90663973ab13b5d3dbf737e)

16 years agor14940: Remove pam_winbind's ability to create home directories on it's own.
Günther Deschner [Thu, 6 Apr 2006 09:23:34 +0000 (09:23 +0000)]
r14940: Remove pam_winbind's ability to create home directories on it's own.

Guenther
(This used to be commit 87293802f3e0666c9a50eb3ca63bb1a7dccc50dc)

16 years agor14931: Fix #1374: can't join an OU with name that contains '#'
Jim McDonough [Thu, 6 Apr 2006 01:46:01 +0000 (01:46 +0000)]
r14931: Fix #1374: can't join an OU with name that contains '#'

I had to eliminate "\" as an OU path separator, because it is the escape
char in LDAP.  We still accept "/", but using the escape char is just
not a good choice.
(This used to be commit 1953f63903e64e0a33eb981c51b8ca4beb673af2)

16 years agor14923: Return False in the case a parametrical option is not configured in
Lars Müller [Wed, 5 Apr 2006 07:44:14 +0000 (07:44 +0000)]
r14923: Return False in the case a parametrical option is not configured in
the config file.

For a "somesettings: foo = " we still return an empty line.
(This used to be commit 59175ee522c5b4f9554ee734c008d8048eb1eadb)

16 years agor14922: Use BOOL for the returned value.
Lars Müller [Wed, 5 Apr 2006 07:29:22 +0000 (07:29 +0000)]
r14922: Use BOOL for the returned value.
(This used to be commit b228474be0ced2637272a7b614b92e412a118993)

16 years agor14900: Separate words in error message.
James Peach [Tue, 4 Apr 2006 01:07:28 +0000 (01:07 +0000)]
r14900: Separate words in error message.
(This used to be commit ffe1a2e23ffb2edf2274c20ece0a66a9c649d50f)

16 years agor14899: Add missing semi-colon.
James Peach [Tue, 4 Apr 2006 00:59:50 +0000 (00:59 +0000)]
r14899: Add missing semi-colon.
(This used to be commit 5f4f4cbe6fe069570a921468034005d364f63206)

16 years agor14898: This change is an attempt to improve the quality of the information that
James Peach [Tue, 4 Apr 2006 00:27:50 +0000 (00:27 +0000)]
r14898: This change is an attempt to improve the quality of the information that
is produced when a process exits abnormally.

First, we coalesce the core dumping code so that we greatly improve our
odds of being able to produce a core file, even in the case of a memory
fault. I've removed duplicates of dump_core() and split it in two to
reduce the amount of work needed to actually do the dump.

Second, we refactor the exit_server code path to always log an explanation
and a stack trace. My goal is to always produce enough log information
for us to be able to explain any server exit, though there is a risk
that this could produce too much log information on a flaky network.

Finally, smbcontrol has gained a smbd fault injection operation to test
the changes above. This is only enabled for developer builds.
(This used to be commit 56bc02d64498eb3faf89f0c5452b9299daea8e95)

16 years agor14896: Remove unused files
Volker Lendecke [Mon, 3 Apr 2006 19:14:12 +0000 (19:14 +0000)]
r14896: Remove unused files
(This used to be commit cc1bdbbc41bd6626ee53abf3f2ab35c454e036b7)

16 years agor14895: Merge the 3.0.22 change
Volker Lendecke [Mon, 3 Apr 2006 19:08:23 +0000 (19:08 +0000)]
r14895: Merge the 3.0.22 change
(This used to be commit 62d60a04cd85dc521e7d63726b856f38287466ad)

16 years agor14892: allow:
Stefan Metzmacher [Mon, 3 Apr 2006 14:57:48 +0000 (14:57 +0000)]
r14892: allow:
CC_CHECKER=mycheker make

metze
(This used to be commit b562459fbfdbfa25c774d631b48f1187fc3e15eb)

16 years agor14889: Fix smbwrapper compile
Volker Lendecke [Mon, 3 Apr 2006 13:53:57 +0000 (13:53 +0000)]
r14889: Fix smbwrapper compile
(This used to be commit 0f087fd40ad502513c3775587c07c86fc53bf718)

16 years agor14886: reenable BASE-DENY2 and BASE-DENY3
Stefan Metzmacher [Mon, 3 Apr 2006 11:34:17 +0000 (11:34 +0000)]
r14886: reenable BASE-DENY2 and BASE-DENY3

metze
(This used to be commit 69f489bde07d4c66bdf4dd3a2411d40ed868d144)

16 years agor14884: this doesn't work and causes processes to be left when using ctrl-c (SIGINT)
Stefan Metzmacher [Mon, 3 Apr 2006 11:32:57 +0000 (11:32 +0000)]
r14884: this doesn't work and causes processes to be left when using ctrl-c (SIGINT)

metze
(This used to be commit 1ac5351646b18f28b1f9ed477b6e6046e1bdf783)

16 years agor14883: add 'smbd:sharedelay' option, so that we can speed up BASE-DENY2 in make...
Stefan Metzmacher [Mon, 3 Apr 2006 10:43:34 +0000 (10:43 +0000)]
r14883: add 'smbd:sharedelay' option, so that we can speed up BASE-DENY2 in make test
as done in samba4

metze
(This used to be commit b98dd258a74a1e1b4e967e6176a5a92986d03123)

16 years agor14869: Allow to dump a paramatrical option.
Lars Müller [Sun, 2 Apr 2006 21:12:23 +0000 (21:12 +0000)]
r14869: Allow to dump a paramatrical option.

Flaw: We print an empty line if the paramatrical option is not defined
in the requested section.
(This used to be commit a0d84ccc02e19d22d827e7d052fab6d471f0a1b3)

16 years agor14868: I will not write code when changing to Daylight Savings Time.
Gerald Carter [Sun, 2 Apr 2006 19:45:42 +0000 (19:45 +0000)]
r14868: I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.
I will not write code when changing to Daylight Savings Time.

...

Fix my brain dead inverted logic for turning winbindd on and off
when run on a DC or when calling pdb functions from within winbindd.
(This used to be commit 021b3dc2db9fb422ede4657a1f27ef7ef2d22cee)

16 years agor14865: - enforce timelimits for the tests
Stefan Metzmacher [Sun, 2 Apr 2006 12:52:59 +0000 (12:52 +0000)]
r14865: - enforce timelimits for the tests
- and skip some long tests for now

metze
(This used to be commit 1d52ae786d400441d9f5b30b4fa9e4e8ff64f7e4)

16 years agor14863: try to make the generation of bin/timelimit more portable
Stefan Metzmacher [Sun, 2 Apr 2006 12:29:13 +0000 (12:29 +0000)]
r14863: try to make the generation of bin/timelimit more portable

jerry: can you test that please

metze
(This used to be commit aa76c2edee17a023ee49f9b960a79df402f785ea)

16 years agor14855: Various fixes:
Gerald Carter [Sun, 2 Apr 2006 06:25:11 +0000 (06:25 +0000)]
r14855: Various fixes:

* depreacte 'acl group control' after discussion with Jeremy
  and implement functionality as part of 'dos filemode'
* fix winbindd on a non-member server to expand local groups
* prevent code previously only used by smbd from blindly
  turning _NO_WINBINDD back on
(This used to be commit 4ab372f4cab22225716b5c9a9a08f0c1dbc9928d)

16 years agor14849: Fix >= that should be >. Too strict condition
Jeremy Allison [Sat, 1 Apr 2006 18:22:31 +0000 (18:22 +0000)]
r14849: Fix >= that should be >. Too strict condition
checked by Volker.
Jeremy.
(This used to be commit 9a763da07385bf9af437cab8dd680f2e13fca3c3)

16 years agor14847: Tell static checkers that exit_server() doesn't
Jeremy Allison [Sat, 1 Apr 2006 05:41:34 +0000 (05:41 +0000)]
r14847: Tell static checkers that exit_server() doesn't
return.
Jeremy.
(This used to be commit 9c5e26a56aaaf1143b43e61d208ddaeb96f2ffcb)

16 years agor14841: Fix IRIX build --with-pam.
Günther Deschner [Fri, 31 Mar 2006 11:48:01 +0000 (11:48 +0000)]
r14841: Fix IRIX build --with-pam.

Guenther
(This used to be commit 99158406b47dc07961c4f6536181da868cf276ca)

16 years agor14833: Fix resource leak on error code path. Coverity #280.
Jeremy Allison [Fri, 31 Mar 2006 00:50:09 +0000 (00:50 +0000)]
r14833: Fix resource leak on error code path. Coverity #280.
Jeremy.
(This used to be commit b985bdcb87eeb70725f2d625a4ea5ec39bda1b94)

16 years agor14831: Fix possible null deref. Coverity #279.
Jeremy Allison [Fri, 31 Mar 2006 00:47:08 +0000 (00:47 +0000)]
r14831: Fix possible null deref. Coverity #279.
Jeremy.
(This used to be commit 75be5c17bc74c86219c7cac749b52b7d43abb780)

16 years agor14829: Fix reversed test in coverity fixes.
Jeremy Allison [Fri, 31 Mar 2006 00:44:24 +0000 (00:44 +0000)]
r14829: Fix reversed test in coverity fixes.
Jeremy.
(This used to be commit f1b4e870a52cbd7bb780b206e943987648523060)

16 years agor14825: add support for max connections parameter
Gerald Carter [Thu, 30 Mar 2006 14:28:33 +0000 (14:28 +0000)]
r14825: add support for max connections parameter
(This used to be commit 63efbdf005f410c4a9843809207ea27f4c1ac756)

16 years agor14820: sync test_posix_p3.sh with test_posix.sh from samba4
Stefan Metzmacher [Thu, 30 Mar 2006 13:11:08 +0000 (13:11 +0000)]
r14820: sync test_posix_p3.sh with test_posix.sh from samba4
but only run the BASE-* tests and ignore some more than in samba4

metze
(This used to be commit 6f37658f927c103a71e918ab5ac78d61cd570c36)

16 years agor14809: - add my email address
Stefan Metzmacher [Thu, 30 Mar 2006 09:34:02 +0000 (09:34 +0000)]
r14809: - add my email address
- fix usage()
- remove unused var

metze
(This used to be commit 20782719d9eda7609788c132356db7107b7fe04a)

16 years agor14790: Fix possible null deref. Coverity #277.
Jeremy Allison [Wed, 29 Mar 2006 23:45:08 +0000 (23:45 +0000)]
r14790: Fix possible null deref. Coverity #277.
Jeremy.
(This used to be commit 2454af392a71989ecddb2dbb17a9217658102523)

16 years agor14788: Fix coverity bug #276. null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:42:03 +0000 (23:42 +0000)]
r14788: Fix coverity bug #276. null deref.
Jeremy.
(This used to be commit 0217f7d7bf4c8b5b7de2433485fb6f78b62ac817)

16 years agor14786: Fix coverity #275. null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:35:16 +0000 (23:35 +0000)]
r14786: Fix coverity #275. null deref.
Jeremy.
(This used to be commit 363d31c9ec2d2a4429ab4d26b3d7c78b76f60626)

16 years agor14784: Fix coverity bug #274. Null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:32:40 +0000 (23:32 +0000)]
r14784: Fix coverity bug #274. Null deref.
Jeremy.
(This used to be commit f88f2d93686ba6bd317b7bc935888e75b7999c83)

16 years agor14782: Fix coverity bug #273, null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:25:04 +0000 (23:25 +0000)]
r14782: Fix coverity bug #273, null deref.
Jeremy.
(This used to be commit c2636c10262e8045f701143dee22b10b2d0c0344)

16 years agor14780: Fix coverity bug #272, null deref.
Jeremy Allison [Wed, 29 Mar 2006 23:22:57 +0000 (23:22 +0000)]
r14780: Fix coverity bug #272, null deref.
Jeremy.
(This used to be commit 1588ce8efe7fafd89561b55a98c498f947f4ada9)

16 years agor14778: Fix coverity null deref bugs #268 - #271.
Jeremy Allison [Wed, 29 Mar 2006 23:18:58 +0000 (23:18 +0000)]
r14778: Fix coverity null deref bugs #268 - #271.
Jeremy.
(This used to be commit 0a1ccfefcf27c5970b82bf8a451bcdaa4fee1bd0)

16 years agor14776: Fix coverity #263 - #267. No one was checking talloc
Jeremy Allison [Wed, 29 Mar 2006 23:13:27 +0000 (23:13 +0000)]
r14776: Fix coverity #263 - #267. No one was checking talloc
returns. Doh !
Jeremy.
(This used to be commit 68097e0fbb8f232573a2f7eae3da3a0c9873fbc5)

16 years agor14774: Fix null deref coverity bugs #260, #261, #262.
Jeremy Allison [Wed, 29 Mar 2006 23:03:34 +0000 (23:03 +0000)]
r14774: Fix null deref coverity bugs #260, #261, #262.
Jeremy.
(This used to be commit 46e575af17cefb0ce7a1fdfacf29f90ae36fa72e)

16 years agor14772: Fix coverity bug #258. Seems coverity has discovered talloc :-).
Jeremy Allison [Wed, 29 Mar 2006 22:59:33 +0000 (22:59 +0000)]
r14772: Fix coverity bug #258. Seems coverity has discovered talloc :-).
Jeremy.
(This used to be commit 488b7725168971e6e59f3a2a7476ce82df43579b)

16 years agor14770: Fix coverity bug #257. Possible null deref.
Jeremy Allison [Wed, 29 Mar 2006 22:56:05 +0000 (22:56 +0000)]
r14770: Fix coverity bug #257. Possible null deref.
Jeremy.
(This used to be commit 4c126ef65dd07352ab936fff774c7435723f5395)

16 years agor14768: Fix potential null deref coverity bugs #255, #256.
Jeremy Allison [Wed, 29 Mar 2006 22:51:23 +0000 (22:51 +0000)]
r14768: Fix potential null deref coverity bugs #255, #256.
Jeremy.
(This used to be commit a40c7a0cd888dcee3cac1a41602863f54c51ef17)

16 years agor14766: Fix possible NULL deref. Coverity #254.
Jeremy Allison [Wed, 29 Mar 2006 22:45:52 +0000 (22:45 +0000)]
r14766: Fix possible NULL deref. Coverity #254.
Jeremy.
(This used to be commit e2e2d8b939dd425a97b36102c6a541e3cf6236ad)

16 years agor14764: Fix possible null pointer deref. Coverity #253.
Jeremy Allison [Wed, 29 Mar 2006 22:41:24 +0000 (22:41 +0000)]
r14764: Fix possible null pointer deref. Coverity #253.
Jeremy.
(This used to be commit 7a18f38947385b8a5fb27a42610320003689e9e1)

16 years agor14763: Add a new tuning parameter, open files database hash size,
Jeremy Allison [Wed, 29 Mar 2006 22:19:01 +0000 (22:19 +0000)]
r14763: Add a new tuning parameter, open files database hash size,
this allows us to experiment with ensuring the tdb hash
size for our open files and locking db are appropriately
sized. Make the hash size larger by default (10007 instead
of 1049) and make the locking db hash size the same as the
open file db hash size.
Jeremy.
(This used to be commit e7225f7e813423c3e2a94af6a9d7ce8a1b50a166)

16 years agor14760: Fix #3642, ensure we don't call FD_SET on read with fd == -1.
Jeremy Allison [Wed, 29 Mar 2006 18:55:39 +0000 (18:55 +0000)]
r14760: Fix #3642, ensure we don't call FD_SET on read with fd == -1.
Jeremy.
(This used to be commit 6ae15544ccfc3ff5d97565ad41ba7f57c7d29b0f)

16 years agor14758: Fix broken LDAP search filter.
Günther Deschner [Wed, 29 Mar 2006 18:24:34 +0000 (18:24 +0000)]
r14758: Fix broken LDAP search filter.

Guenther
(This used to be commit 25970a54298f2888b5c3cd64496dbd0c9d627a05)

16 years agor14757: Make sure we only send out a CLDAP request to an connected AD server.
Günther Deschner [Wed, 29 Mar 2006 15:30:26 +0000 (15:30 +0000)]
r14757: Make sure we only send out a CLDAP request to an connected AD server.

Guenther
(This used to be commit d17712f9761589115e976e2240498396f36838ee)

16 years agor14756: Make smbpasswd -a root work for eDirectory where there is no "account"
Günther Deschner [Wed, 29 Mar 2006 14:52:03 +0000 (14:52 +0000)]
r14756: Make smbpasswd -a root work for eDirectory where there is no "account"
structural objectclass.

Guenther
(This used to be commit 7eefeaad352597b6f97160b1abc0dc032c0b46b2)

16 years agor14753: Fix the kerberized pam_auth: As we could have created a new credential
Günther Deschner [Wed, 29 Mar 2006 09:40:42 +0000 (09:40 +0000)]
r14753: Fix the kerberized pam_auth: As we could have created a new credential
cache with a valid TGT in it but we werent able to get or verify the
service ticket for this local host afterwards and therefor didn't get
the PAC, we need to remove that ccache entirely.

Also remove an ugly pair of (not needed) seteuid calls around the ticket
destroy wrapper.

Guenther
(This used to be commit 25a2fb3896596380d9eecac80defbf247a35e6bb)

16 years agor14751: Use the noreturn attribute to try and tell coverity that
Jeremy Allison [Tue, 28 Mar 2006 15:50:13 +0000 (15:50 +0000)]
r14751: Use the noreturn attribute to try and tell coverity that
smb_panic can't return.
Jeremy.
(This used to be commit ba9c98983efbf4871e1ec07df37590d97ec52fba)

16 years agor14748: store the name/ip address combination when we doa reverse look up in case...
Gerald Carter [Tue, 28 Mar 2006 13:34:13 +0000 (13:34 +0000)]
r14748: store the name/ip address combination when we doa reverse look up in case future forward lookups would fail
(This used to be commit d56ed46faec46dad74b469d25ff99c9002792c78)

16 years agor14746: Add the Samba4 replacements for opendir/readdir etc. to
Jeremy Allison [Mon, 27 Mar 2006 19:50:45 +0000 (19:50 +0000)]
r14746: Add the Samba4 replacements for opendir/readdir etc. to
Samba3 - with some 64-bit macro madness. Attempt to fix
the broken directory handling in the *BSD-of-the-month
club.
Jeremy.
(This used to be commit fd98427f64f4206c01f16f82fadf24f5863878db)

16 years agor14744: allow ./timelimit 5 ./timelimit 20 ./ignore_all_signals
Stefan Metzmacher [Mon, 27 Mar 2006 12:32:42 +0000 (12:32 +0000)]
r14744: allow ./timelimit 5 ./timelimit 20 ./ignore_all_signals
to work,

this is needed when we enable samba3's make test
in the build-farm

metze
(This used to be commit b120c21669a91a097f044530a1f7c59043465841)

16 years agor14743: Fix coverity bug #227. Possible deref of null pointer
Jeremy Allison [Mon, 27 Mar 2006 02:51:25 +0000 (02:51 +0000)]
r14743: Fix coverity bug #227. Possible deref of null pointer
in error code path.
Jeremy.
(This used to be commit 9117713c5ee220331106d291425703aec4d7dd2c)

16 years agor14703: Clarify the return codes for the POSIX locking case. This
Jeremy Allison [Sat, 25 Mar 2006 01:35:43 +0000 (01:35 +0000)]
r14703: Clarify the return codes for the POSIX locking case. This
was confusing.
Jeremy.
(This used to be commit bc1a605a39e58a7dbdcd4d132345e957e3ed9d5e)

16 years agor14699: allow 'net sam addmem' to accept a SID for the member
Gerald Carter [Fri, 24 Mar 2006 23:54:08 +0000 (23:54 +0000)]
r14699: allow 'net sam addmem' to accept a SID for the member
(This used to be commit 08d201806f53f51fbed4a02a54cb0656f8287b12)

16 years agor14698: Make sure we expand our own local groups and not
Gerald Carter [Fri, 24 Mar 2006 22:04:16 +0000 (22:04 +0000)]
r14698: Make sure we expand our own local groups and not
just the BUILTIN group when calling winbindd_getgroups.

$ id foo
uid=502(foo) gid=100(users) groups=100(users),10007(RHEL4\staff),
10001(BUILTIN\users)
(This used to be commit 603b4b501a759510d2ec66cbe5ab1e9f5dc5dbc1)

16 years agor14696: make pdb_find_backend_entry public (for use by an external "multi" pdb backend)
Jelmer Vernooij [Fri, 24 Mar 2006 19:12:04 +0000 (19:12 +0000)]
r14696: make pdb_find_backend_entry public (for use by an external "multi" pdb backend)
(This used to be commit c149421ef7aca8763e21e6c7d467e94944c30e8b)

16 years agor14695: Patch from Björn Jacke:
Volker Lendecke [Fri, 24 Mar 2006 18:40:28 +0000 (18:40 +0000)]
r14695: Patch from Björn Jacke:

- add DMAPI/XDSM support for AIX
- find JFS DMAPI libs on Linux when only they are available

Volker
(This used to be commit b6b72f8c6a03001ae75457c9e7a78e189bea5a3f)

16 years agor14684: Remove obsolete file (belonged to pdb_xml)
Jelmer Vernooij [Thu, 23 Mar 2006 20:19:05 +0000 (20:19 +0000)]
r14684: Remove obsolete file (belonged to pdb_xml)
(This used to be commit 15c36233fb2e5164ea0fbb2389a066e34838dd20)

16 years agor14683: Get rid of hardcoded output file. With no arg, print to stdout,
Jim McDonough [Thu, 23 Mar 2006 18:35:15 +0000 (18:35 +0000)]
r14683: Get rid of hardcoded output file.  With no arg, print to stdout,
otherwise append to output file specified.
(This used to be commit b4ec93f5a26442d30ba2b8c91d03f3190975efd0)