Noel Power [Fri, 3 Aug 2018 11:43:26 +0000 (12:43 +0100)]
PY3: iterkeys -> keys
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 3 Aug 2018 13:49:59 +0000 (14:49 +0100)]
PY3: dict has no iterkeys method
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Tue, 31 Jul 2018 17:04:30 +0000 (18:04 +0100)]
PY3: fix iteritems usage, not supported in python3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 27 Jul 2018 13:35:16 +0000 (14:35 +0100)]
PY3: fix some octal literals
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Tue, 19 Jun 2018 12:15:47 +0000 (13:15 +0100)]
s4/selftest: enable samba.tests.ntlmdisabled for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Sep 15 18:10:42 CEST 2018 on sn-devel-144
Noel Power [Wed, 12 Sep 2018 11:46:21 +0000 (12:46 +0100)]
selftest/knownfail: Add PY3 entries for samba.tests.ntlmdisabled
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Tue, 19 Jun 2018 11:28:07 +0000 (12:28 +0100)]
s4/selftest: enable samba.tests.netlogonsvc for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Tue, 19 Jun 2018 11:13:41 +0000 (12:13 +0100)]
s4/selftest: enable samba.tests.kcc.kcc_utils for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Tue, 19 Jun 2018 10:24:16 +0000 (11:24 +0100)]
s4/selftest: enable samba.tests.kcc for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Mon, 18 Jun 2018 18:04:34 +0000 (19:04 +0100)]
s4/selftetst: enable samba4.drs.cracknames for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Mon, 18 Jun 2018 17:45:15 +0000 (18:45 +0100)]
s4/selftest: enable samba.tests.join for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Mon, 18 Jun 2018 10:55:31 +0000 (11:55 +0100)]
python/samba/tests: py_gensec_update takes bytes as param
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 16:56:13 +0000 (17:56 +0100)]
s4/selftest: enable samba4.drs.repl_rodc for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 16:55:46 +0000 (17:55 +0100)]
s4/torture/drs/python: py2/py3 compat changes for samba4.drs.repl_rodc
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 15:46:55 +0000 (16:46 +0100)]
s4/selftest: enable samba4.drs.getncchanges for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Tue, 11 Sep 2018 19:58:12 +0000 (20:58 +0100)]
selftest/knownfail.d: PY3 entry fro getncchanges
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 15:46:12 +0000 (16:46 +0100)]
s4/torture/drs/python: py2/py3 porting needed for samba4.drs.getncchanges
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 15:27:18 +0000 (16:27 +0100)]
s4/selftest: enable samba4.drs.repl_schema for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 14:55:59 +0000 (15:55 +0100)]
s4/selftest: enable samba4.drs.link_conflicts for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 14:55:15 +0000 (15:55 +0100)]
s4/torture/drs: py2/py3 compat porting for samba4.drs.link_conflicts
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 14:20:54 +0000 (15:20 +0100)]
s4/selftest: enable samba4.drs.getnc_unpriv for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 14:14:58 +0000 (15:14 +0100)]
s4/selftest: enable samba4.drs.getnc_exop for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 09:39:09 +0000 (10:39 +0100)]
s4/torture/drs/python: ndr_unpack needs bytes samba4.drs.getnc_exop
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 09:37:12 +0000 (10:37 +0100)]
s4/selftest: enable samba4.drs.repl_move for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 09:12:26 +0000 (10:12 +0100)]
s4/torture/drs: py2/py3 compat for test samba4.drs.repl_move
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 08:02:26 +0000 (09:02 +0100)]
s4/selftest: enable samba4.drs.fsmo for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 15 Jun 2018 07:58:59 +0000 (08:58 +0100)]
s4/torture/drs: py2/py3 compat changes for test samba4.drs.fsmo
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Thu, 14 Jun 2018 16:12:54 +0000 (17:12 +0100)]
s4/selftest: enable test samba4.drs.delete_object for py2/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Thu, 14 Jun 2018 16:12:30 +0000 (17:12 +0100)]
s4/torture/drs: port samba4.drs.delete_object test for py2/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Thu, 14 Jun 2018 15:49:52 +0000 (16:49 +0100)]
s4/selftest: enable samba.tests.samba_tool.schema for py2/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Wed, 13 Jun 2018 16:21:13 +0000 (17:21 +0100)]
s4/selftest: enable samba.tests.samba_tool.forest for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 8 Jun 2018 09:36:02 +0000 (10:36 +0100)]
s4/selftest: samba4.drs.replica_sync.python enable for python3.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 8 Jun 2018 08:50:45 +0000 (09:50 +0100)]
s4/selftest: enable samba4.drs.samba_tool_drs_showrepl py2/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Mon, 10 Sep 2018 17:12:04 +0000 (18:12 +0100)]
selftest/knownfail.d: PY3 rule for replica_sync
Noel Power [Tue, 11 Sep 2018 12:21:18 +0000 (13:21 +0100)]
s4/torture/drs: PY3 fix error with test_samba_tool_showrepl_json
some versions of json.loads appear to need to be passed string.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 8 Jun 2018 09:35:13 +0000 (10:35 +0100)]
s4/torture/drs/python: make test code run in py2/py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Mon, 10 Sep 2018 12:40:15 +0000 (13:40 +0100)]
s4/torture/drs: PY3 port for test samba_tool_drs_showrepl
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 18 May 2018 15:15:01 +0000 (16:15 +0100)]
s4/selftest: enable samba4.drs.samba_tool_drs for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 18 May 2018 15:14:39 +0000 (16:14 +0100)]
s4/torture/drs: port samba4.drs.samba_tool_drs for py2/py3 compat
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 18 May 2018 11:43:22 +0000 (12:43 +0100)]
s4/selftest: enable samba4.ldap.password_settings for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 7 Sep 2018 15:30:28 +0000 (16:30 +0100)]
selftest/knownfail.d: add PY3 entry for samba4.ldap.password_settings
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 18 May 2018 11:35:21 +0000 (12:35 +0100)]
s4/selftest: enable samba.tests.net_join for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Thu, 17 May 2018 15:06:19 +0000 (16:06 +0100)]
s4/selftest: enable samba.tests.net_join_no_spnego for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Thu, 17 May 2018 14:57:38 +0000 (15:57 +0100)]
s4/selftest/tests.py enable samba.tests.getdcname for py3
Noel Power [Fri, 7 Sep 2018 13:38:54 +0000 (14:38 +0100)]
python/samba: extra ndr_unpack needs bytes function
Noel Power [Thu, 17 May 2018 13:51:40 +0000 (14:51 +0100)]
s4/selftest: enable samba.tests.samba_tool.passwordsetting for Py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Thu, 31 May 2018 13:30:43 +0000 (14:30 +0100)]
python/samba/netcmd: PY3 fix test samba.tests.samba_tool.passwordsettings
Noel Power [Tue, 15 May 2018 14:33:22 +0000 (15:33 +0100)]
s4/selftest: enable samba4.drs.ridalloc_exop for python3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 7 Sep 2018 11:42:19 +0000 (12:42 +0100)]
python/samba: PY3 port for ridalloc_exop test to work
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 7 Sep 2018 11:07:46 +0000 (12:07 +0100)]
python/samba: ndr_unpack has to take bytes not string
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Mon, 14 May 2018 19:03:59 +0000 (20:03 +0100)]
s4/param: py2/p3 compat override_prefixmap should be string/bytes
Noel Power [Thu, 17 May 2018 12:34:00 +0000 (13:34 +0100)]
fallout from py_dsdb_DsReplicaAttribute to -> bytes
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Mon, 14 May 2018 19:05:30 +0000 (20:05 +0100)]
s4/dsdb: py_dsdb_DsReplicaAttribute should deal with bytes in py3
Seems the underlying c code expects binary blob, so.. we should
handle str for py2 and byte for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 11 May 2018 15:41:44 +0000 (16:41 +0100)]
s4/selftest: enable samba.tests.samba_tool.rodc for PY3
Noel Power [Fri, 11 May 2018 15:39:06 +0000 (16:39 +0100)]
s4/selftest: enable samba.tests.upgradeprovisionneeddc for py3
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Noel Power [Fri, 7 Sep 2018 09:10:56 +0000 (10:10 +0100)]
python/samba/provision: PY3 port to run samba.tests.upgradeprovisionneeddc
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Christof Schmitt [Sat, 15 Sep 2018 00:00:26 +0000 (17:00 -0700)]
torture: Remove unnecesssary #include <fcntl.h>
This is now provided through system/filesys.h.
Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Volker Lendecke [Fri, 3 Aug 2018 10:45:59 +0000 (12:45 +0200)]
mdssvc: Move a variable declaration closer to its use
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Sep 14 10:48:47 CEST 2018 on sn-devel-144
Volker Lendecke [Fri, 3 Aug 2018 10:44:31 +0000 (12:44 +0200)]
mdssvc: Move a variable declaration closer to its use
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Fri, 3 Aug 2018 10:43:37 +0000 (12:43 +0200)]
mdssvc: Move a variable declaration closer to its use
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Fri, 3 Aug 2018 10:38:47 +0000 (12:38 +0200)]
mdssvc: Simplify sl_unpack_loop
Move a variable declaration closer to its use, avoid a redundant
?true:false;
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Wed, 8 Aug 2018 12:20:58 +0000 (14:20 +0200)]
streams_xattr: Make error handling more obvious
Do the NULL check right after the alloc call
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Wed, 8 Aug 2018 12:20:58 +0000 (14:20 +0200)]
streams_xattr: Make error handling more obvious
Do the NULL check right after the alloc call
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Mon, 10 Sep 2018 13:14:00 +0000 (15:14 +0200)]
smbd: Simplify parse_share_modes
Since
823bc4c07ad pidl initializes the [skip] entries
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Mon, 10 Sep 2018 12:50:40 +0000 (14:50 +0200)]
smbd: Simplify share_mode_lock.c
"the_lock_id" is not required here. The share mode data carry the file
id, so use that.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Mon, 10 Sep 2018 10:20:10 +0000 (12:20 +0200)]
smbd: Fix a false comment
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Sat, 22 Oct 2016 11:59:12 +0000 (13:59 +0200)]
tevent: Fix a docu typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Thu, 13 Sep 2018 04:21:37 +0000 (06:21 +0200)]
smbd: Remove "file_sync_all" function
Replace with a call to files_forall. Why? I just came across this
function that only has one pretty obscure user. This does not justify
a full library function, IMHO at least.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Mon, 10 Sep 2018 10:55:48 +0000 (12:55 +0200)]
smbd: Avoid casts in DEBUG statements
Some indentation changed, best viewed with "git show -w"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Thu, 13 Sep 2018 17:36:47 +0000 (19:36 +0200)]
smbd: Avoid casts in DEBUG statements
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Thu, 13 Sep 2018 16:56:54 +0000 (18:56 +0200)]
smbd: Add a paranoia check for leases
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Thu, 16 Aug 2018 11:18:14 +0000 (13:18 +0200)]
dbwrap_tdb: Avoid double-call to talloc_get_type_abort
We've already retrieved "ctx" in the callers of db_tdb_fetch_locked_internal().
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Volker Lendecke [Mon, 10 Sep 2018 12:53:37 +0000 (14:53 +0200)]
smbd: Add some structure protection for durable reconnect
We should consume all data, and the ndr_pull function fills in all
fields. Thus the ZERO_STRUCT(cookie) is not required.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Martin Schwenke [Thu, 13 Sep 2018 00:54:48 +0000 (10:54 +1000)]
wafsamba: Only use $DESTDIR in INSTALL_DIR() if it is set
Otherwise the leading '/' is stripped and directories are created
relative to the current directory.
This fixes a regression introduced in recent commit
26ea0f58daace4adef7c5bb17f19476083bf3b7b.
Reported-by: Ralph Böhme <slow@samba.org>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Thu Sep 13 09:37:23 CEST 2018 on sn-devel-144
Ralph Boehme [Mon, 10 Sep 2018 10:50:01 +0000 (12:50 +0200)]
dbwrap_ctdb: return correct record count for a persistent db read-only traverse
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 13 01:34:30 CEST 2018 on sn-devel-144
Ralph Boehme [Sun, 9 Sep 2018 16:51:43 +0000 (18:51 +0200)]
dbwrap_ctdb: increment record count in traverse_callback()
state->count wasn't incremented and is returned at the end of a
dbwrap_traverse().
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sun, 9 Sep 2018 16:50:14 +0000 (18:50 +0200)]
dbwrap_ctdb: use struct initializer in db_ctdb_traverse()
This ensures all struct members are implicitly initialized.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sun, 9 Sep 2018 16:48:13 +0000 (18:48 +0200)]
dbwrap_ctdb: use struct initializer in db_ctdb_traverse_read()
This ensures all struct members are implicitly initialized.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sun, 9 Sep 2018 16:35:26 +0000 (18:35 +0200)]
dbwrap_ctdb: README.Coding fixes in traverse_callback()
NULL initialize pointers, check function return values, explicit
variable check against NULL.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Tue, 4 Sep 2018 10:47:42 +0000 (12:47 +0200)]
dbwrap_ctdb: simplify if condition
This just moves the talloc_memdup() out of the if condition as per
README.Coding.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sun, 4 Mar 2018 22:39:05 +0000 (23:39 +0100)]
dbwrap_ctdb: add error checking to ctdbd_dbpath()
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sat, 18 Aug 2018 06:35:27 +0000 (08:35 +0200)]
dbwrap_tdb: use struct initializer
This ensures all struct members are implicitly initialized.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sat, 18 Aug 2018 07:12:21 +0000 (09:12 +0200)]
dbwrap_tdb: move a function call out of an if condition
At least for me this improves readability somewhat. No change in
behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sat, 18 Nov 2017 11:13:15 +0000 (12:13 +0100)]
dbwrap: early return, removes an indentation level
No change in behaviour.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Boehme [Sat, 18 Nov 2017 07:56:09 +0000 (08:56 +0100)]
dbwrap: move sockname variable and call to lp_ctdbd_socket into context
sockname is only needed in a cluster.
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Ralph Wuerthner [Tue, 11 Sep 2018 08:00:52 +0000 (10:00 +0200)]
ctdb-doc: Remove PIDFILE option from ctdbd_wrapper man page
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13610
Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Wed Sep 12 21:50:57 CEST 2018 on sn-devel-144
Björn Baumbach [Wed, 5 Sep 2018 14:54:01 +0000 (16:54 +0200)]
samba_dnsupdate: honor 'dns zone scavenging' option, only update if needed
Since scavenging is implemented the samba_dnsupdate command always updates all
dns records required by the dc. This is not needed if dns zone scavenging
is not enabled.
This avoids the repeating TSIG error messages:
# samba_dnsupdate --option='dns zone scavenging = yes' 2>&1 | uniq -c
29 ; TSIG error with server: tsig verify failure
1 Failed update of 29 entries
# echo ${PIPESTATUS[0]}
29
# samba_dnsupdate --option='dns zone scavenging = no' 2>&1 | uniq -c
# echo ${PIPESTATUS[0]}
0
Note that this results in about 60 lines in the log file,
which triggered every 10 minutes ("dnsupdate:name interval=600" is the default).
This restores the behavior before
8ef42d4dab4dfaf5ad225b33f7748914f14dcd8c,
if "dns zone scavenging" is not switched on (which is still the default).
Avoiding the message from happening at all is subject for more debugging,
most likely they are caused by bugs in 'nsupdate -g' (from the bind package).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13605
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Björn Baumbach <bb@sernet.de>
Autobuild-Date(master): Wed Sep 12 18:03:10 CEST 2018 on sn-devel-144
Martin Schwenke [Sat, 8 Sep 2018 22:11:33 +0000 (08:11 +1000)]
ctdb-build: Fix version handling when building tarball
Split get_version() into 2 functions, so that .distversion file can be
created.
Pair-programmed-with: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Sep 12 05:50:46 CEST 2018 on sn-devel-144
Michael Adam [Mon, 20 Aug 2018 10:04:20 +0000 (12:04 +0200)]
smbd:vfs: fix mis-spellings of hierarchy in comments
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 12 02:05:47 CEST 2018 on sn-devel-144
Jeremy Allison [Wed, 22 Aug 2018 20:37:04 +0000 (13:37 -0700)]
s3: smbd: Ensure dirpath is set to ".", not "\0" so it is always a valid path.
Cleanup of the internals of unix_convert().
Ensure check_parent_exists() returns this in the non-optimization
case. Ensure unix_convert() initializes dirpath to ".".
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Wed, 22 Aug 2018 16:15:12 +0000 (09:15 -0700)]
s3: smbd: Restructure check_parent_exists() to ensure all non-optimization returns go to one place.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Jeremy Allison [Wed, 22 Aug 2018 16:09:27 +0000 (09:09 -0700)]
s3: smbd: Initialization cleanup.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Tue, 11 Sep 2018 12:56:54 +0000 (14:56 +0200)]
s3:libsmbclient: Fix a typo
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 11 21:43:28 CEST 2018 on sn-devel-144
Jeremy Allison [Mon, 10 Sep 2018 22:35:03 +0000 (15:35 -0700)]
s4: torture: Fix "flakey" notify test on slow cloud filesystems.
Ensure we keep asking for change notifies until we get them all
(or the request times out).
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Sat, 8 Sep 2018 16:05:57 +0000 (18:05 +0200)]
smbd: Use has_other_nonposix_opens in smb_posix_unlink
Almost the same code as in close.c. has_other_nonposix_opens() is a bit
more general, but the purpose is the same.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sat, 8 Sep 2018 14:58:36 +0000 (16:58 +0200)]
smbd: Factor out "has_other_nonposix_opens"
This is exactly the same in both file and directory cases
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sat, 8 Sep 2018 11:50:46 +0000 (13:50 +0200)]
smbd: Remove an unneeded #include
ndr_open_files already includes open_files.h
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sat, 8 Sep 2018 11:44:30 +0000 (13:44 +0200)]
smbd: Simplify close_directory()
Same patch as in
8541829a9ab20c7fa8c
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sat, 8 Sep 2018 10:45:54 +0000 (12:45 +0200)]
smbd: Remove an unneeded #include
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Martin Schwenke [Tue, 11 Sep 2018 04:35:38 +0000 (14:35 +1000)]
wafsamba: Drop unused, broken install_dir()
This is broken because it doesn't respect $DESTDIR.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Tue Sep 11 10:00:05 CEST 2018 on sn-devel-144
git.samba.org / samba.git / log