24 years agoAfter generating some discussion, listening to the opinions, and thinking
Christopher R. Hertel [Fri, 10 Oct 1997 14:12:22 +0000 (14:12 +0000)]
After generating some discussion, listening to the opinions, and thinking
it over, I've decided to move the tree & list code into a subdirectory.
(This used to be commit d8d063d29b52697070efb182d573d519e13c2e53)

24 years agocorrected paragraph giving the impression that samba can be a domain master
Luke Leighton [Fri, 10 Oct 1997 11:52:09 +0000 (11:52 +0000)]
corrected paragraph giving the impression that samba can be a domain master
for multiple workgroups.
(This used to be commit 37a8a5c4c69f051fa1b60f85db1f0ea6360bbba2)

24 years agofixed the log wrapping bug.
Andrew Tridgell [Fri, 10 Oct 1997 02:32:01 +0000 (02:32 +0000)]
fixed the log wrapping bug.

This is a very nasty bug that I think explains quite a few
intermittent problems people have been having with Samba.

It may be worth checking on other cases where errno can be overwritten
by seemingly innocuous things (in this case a DEBUG() line)
(This used to be commit 1448f528b60402170257c1cdf6831cc40b4c86c9)

24 years agonmblookup.c: Added -A ability to do status on ip address.
Jeremy Allison [Fri, 10 Oct 1997 01:32:26 +0000 (01:32 +0000)]
nmblookup.c: Added -A ability to do status on ip address.
smb.h: Added defines we will need for NT SMB calls.
trans2.c: Fixed SMB_QUERY_FILE_ALT_NAME_INFO return - this is only
for short name returns (and only used when you negotiate NT SMB calls
to boot !).
Jeremy (
(This used to be commit 53915bd160eda8c099482ddcef74d1d7606e752b)

24 years agoAdded in oplock info.
Jeremy Allison [Thu, 9 Oct 1997 20:30:29 +0000 (20:30 +0000)]
Added in oplock info.
Jeremy (
(This used to be commit 229b6c409240a8dca9172702b8fefb31aa3b13a1)

24 years agoAdded definition of oplocks parameter.
Jeremy Allison [Thu, 9 Oct 1997 18:48:12 +0000 (18:48 +0000)]
Added definition of oplocks parameter.
Jeremy (
(This used to be commit f9df5ac008e368af86addee058f75c7e79ca74ce)

24 years agolocal.h: Fix spelling mistake :-).
Jeremy Allison [Thu, 9 Oct 1997 18:40:52 +0000 (18:40 +0000)]
local.h: Fix spelling mistake :-).
namedbsubnet.c: Stop registering 1x name unless we can be a local master.
reply.c: Remove ERRbaddirectory code.
server.c: Remove abort() - use exit_server() instead.
trans2.c: Remove ERRbaddirectory code.
Jeremy (
(This used to be commit 76247228896d39312ba896fa229076be3271e2e4)

24 years agoadded #ifdef NTDOMAIN. added call to api_ntLsarpc instead of api_Lsarpc
Luke Leighton [Thu, 9 Oct 1997 16:14:53 +0000 (16:14 +0000)]
added #ifdef NTDOMAIN.  added call to api_ntLsarpc instead of api_Lsarpc
in ipc.c iff NTDOMAIN is defined.
(This used to be commit 7bc4c4c27bf18ce3f632d230dc919ea341b5abb0)

24 years agomoved the array macros outside of the CAREFUL_ALIGNMENT define.
Luke Leighton [Thu, 9 Oct 1997 15:51:43 +0000 (15:51 +0000)]
moved the array macros outside of the CAREFUL_ALIGNMENT define.
(This used to be commit d9fcf11aa04ff04dcbccd628322240f8324ae51d)

24 years agopipes.c:
Luke Leighton [Thu, 9 Oct 1997 15:48:40 +0000 (15:48 +0000)]

added api_ntlsarpcTNP() function.  hooray!


added LSA #defines needed by above function.
(This used to be commit 5437f666987918516032cf8a5dada107e5d14d25)

24 years agocredentials.c:
Luke Leighton [Thu, 9 Oct 1997 14:40:46 +0000 (14:40 +0000)]

use UTIME structure (defined and commented in smb.h to be time, secs,
                         since 01jan1970)


another sub-function.


added char *unistr2(uint16 *buff) function.  same as unistr except
    it takes uint16* instead of char*.

smbparse.c smb.h:

more structure sorting.


the usual.
(This used to be commit 72a86f514f0c92b69499718e63f5dd73ebece56e)

24 years agoJHT ===> Added smbadduser contributed by Mike Zakharoff.
John Terpstra [Thu, 9 Oct 1997 11:24:39 +0000 (11:24 +0000)]
JHT ===> Added smbadduser contributed by Mike Zakharoff.
(This used to be commit 135d054e831cd0f5962acc05d03b38360b73827e)

24 years agoan implementation of the NT domain credentials protocol
Andrew Tridgell [Thu, 9 Oct 1997 10:01:12 +0000 (10:01 +0000)]
an implementation of the NT domain credentials protocol
(This used to be commit dd6ac9b1eea3b0ace27fbd014b5ad4625c1fdf94)

24 years agobracket some macros
Andrew Tridgell [Thu, 9 Oct 1997 06:36:04 +0000 (06:36 +0000)]
bracket some macros

change MAX_PASSWORD_LENGTH to MAX_PASS_LEN to prevent conflict on some

add #ifdef around soft link dependent code (for systems that don't
have soft links)
(This used to be commit e10ba4b97a219e87b62d32834bf15ed2e323ed2e)

24 years agoThis is my library of lists and trees. My hope is to replace all of the
Christopher R. Hertel [Thu, 9 Oct 1997 04:09:56 +0000 (04:09 +0000)]
This is my library of lists and trees.  My hope is to replace all of the
hard coded linked lists that are currently used in Samba with calls to
these modules.  This should make the code simpler, smaller, and (I hope)
faster.  The tree code, in particular, should speed up processing where
large lists are involved.

Chris -)-----
(This used to be commit e789179dfda669bd768720cb3732cf56a49027b5)

24 years agoPut in fix for read-prediction extending files bug. Hard to test, can't
Jeremy Allison [Wed, 8 Oct 1997 22:23:47 +0000 (22:23 +0000)]
Put in fix for read-prediction extending files bug. Hard to test, can't
get read-prediction to happen :-).
Jeremy (
(This used to be commit fa69b3dda47d56e0c3ce1f4f284eac89d4b4bf56)

24 years agoadded a dummy function (space in front so make proto doesn't pick it up)
Luke Leighton [Wed, 8 Oct 1997 21:36:42 +0000 (21:36 +0000)]
added a dummy function (space in front so make proto doesn't pick it up)
to call the unused static functions in pipes.c.  avoids need to move
#if UNDEFINED_NTDOMAIN about, to stop compiler warnings while code is
being developed, but might be released as-is.
(This used to be commit d7f41e3815babce58fa9901f076c2918666abaf9)

24 years agoMakefile: Split definitions for SGI4,5,6.
Jeremy Allison [Wed, 8 Oct 1997 20:34:13 +0000 (20:34 +0000)]
Makefile: Split definitions for SGI4,5,6.
includes.h: Split definitions for SGI4,5,6.
pipes.c: Moved Luke's #ifdef to remove warnings.
quotas.c: Two changes for FreeBSD and SGI.
server.c: Quota changes for large filesystems.
Jeremy (
(This used to be commit b8ff5543b9fa45095caa9f24aeb22a1dcc1cd308)

24 years agoadded api_lsa_lookup_sids() function
Luke Leighton [Wed, 8 Oct 1997 18:36:34 +0000 (18:36 +0000)]
added api_lsa_lookup_sids() function
(This used to be commit 35dd48740d8f733e7725813322b094b4679b31c5)

24 years agoloadparm.c proto.h:
Luke Leighton [Wed, 8 Oct 1997 17:12:07 +0000 (17:12 +0000)]
loadparm.c proto.h:

added lp_domainsid()

lsaparse.c smb.h:

debugging structures and parsing functions


finally got to the functions that will go into the RPC switch statement.
(This used to be commit d15aed8a9c58a7cc90befaee2d5a2752708f9327)

24 years agoupdating lsaparse.c and smbparse.c in line with changes to pipes.c and smb.h
Luke Leighton [Wed, 8 Oct 1997 11:47:46 +0000 (11:47 +0000)]
updating lsaparse.c and smbparse.c in line with changes to pipes.c and smb.h
from yesterday.
(This used to be commit 0b7049fae25957851a7f33d2bd500d8ecefc1ad5)

24 years agoipc.c: Added ERROR_MORE_DATA error if client buffer too small.
Jeremy Allison [Wed, 8 Oct 1997 00:21:39 +0000 (00:21 +0000)]
ipc.c: Added ERROR_MORE_DATA error if client buffer too small.
server.c: Allow admin_user on read only shares. I think this is
safe but it needs looking at.
Jeremy (
(This used to be commit cc50955a2760f1de7e80b91408a7c0806f6eb44c)

24 years agoI rewrote the name_mangle() and name_len().
Christopher R. Hertel [Tue, 7 Oct 1997 22:04:05 +0000 (22:04 +0000)]
I rewrote the name_mangle() and name_len().
The interface is the same, but I've simplified the code a bit and added
a few comments.  I tested the changes and the output is the same as that
produced by the original (at least, it was in all of my tests).  CRH
(This used to be commit 707d0ec388c0045938f367e1d17919bfc8637fea)

24 years agolocking.c: Added fix for race condition in slow share mode code.
Jeremy Allison [Tue, 7 Oct 1997 18:46:19 +0000 (18:46 +0000)]
locking.c: Added fix for race condition in slow share mode code.
lsaparse.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
pipes.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
server.c: Fixed last known oplock race condition.
smb.h: Re-removed USE_OPLOCK defines - someone checked in an old version.
smbparse.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
Jeremy (
(This used to be commit 1e1366ddc5542283a37debdf830ca139bbade1b0)

24 years agopipes.c:
Luke Leighton [Tue, 7 Oct 1997 18:18:10 +0000 (18:18 +0000)]

more static unused functions in pipes.c for the LSA RPC stream.


corrections and altercations over the documentation


reflecting alterations in LSA structures...
(This used to be commit bef12478d212a950578843d6d4dece1f153bfd25)

24 years agoJHT ==> Fixing blocksize argument. Patch by: Llyod Whiteman
John Terpstra [Tue, 7 Oct 1997 16:01:08 +0000 (16:01 +0000)]
JHT ==> Fixing blocksize argument. Patch by: Llyod Whiteman
(This used to be commit 67c1e87e8fda724da6dd3663641639167dd33a16)

24 years agopipes.c:
Luke Leighton [Tue, 7 Oct 1997 14:58:07 +0000 (14:58 +0000)]

some routines to create LSA RPC packets.  none of them are used.


more tidy-up.
(This used to be commit b37e21273e81b875876e8e8ddf6804714044ffd8)

24 years agoincrease the debug level in the "added interface" debug line
Andrew Tridgell [Tue, 7 Oct 1997 14:36:22 +0000 (14:36 +0000)]
increase the debug level in the "added interface" debug line
(This used to be commit b12b3626fd9ccc9cdf2111937b3ee344da361b1f)

24 years agoget rid of SIGCLD_IGNORE for HPUX. A user reported it causing lots
Andrew Tridgell [Tue, 7 Oct 1997 11:14:27 +0000 (11:14 +0000)]
get rid of SIGCLD_IGNORE for HPUX. A user reported it causing lots
of defunct smbd processes.

(This used to be commit bf1f8b1567cb46e3e73ae8dbb26f6228cf519c1f)

24 years agoMore references to samba.canberra
Samba Release Account [Tue, 7 Oct 1997 04:56:02 +0000 (04:56 +0000)]
More references to samba.canberra
Mental note: always commit from root directory. :^o
(This used to be commit 5a38eaac75a6bede2d946f69cf664d7ca3989b55)

24 years agoOops forgot to run the sgml converters that one last time.
Samba Release Account [Tue, 7 Oct 1997 04:50:53 +0000 (04:50 +0000)]
Oops forgot to run the sgml converters that one last time.
All done.
(This used to be commit 9a81cb171c178a85ecd045afafbce7d4b481344e)

24 years agoRemoved samba.faq from the docs directory, it was out of date. All FAQs in
Samba Release Account [Tue, 7 Oct 1997 04:47:23 +0000 (04:47 +0000)]
Removed samba.faq from the docs directory, it was out of date. All FAQs in

Replaced all reference to

Replaced references to

Added 3 new mirrors, Greece, Poland, Romania
(This used to be commit d808df8191cdf21b011e773e6e99b0c65524253c)

24 years agoFinally ! Found & fixed crash bug with logging message when deleting
Jeremy Allison [Mon, 6 Oct 1997 19:50:51 +0000 (19:50 +0000)]
Finally ! Found & fixed crash bug with logging message when deleting
invalid share mode entries. Thanks to (Dietmar Berg)
for the stack backtrace.
Jeremy (
(This used to be commit db4c2cb50e11d252ff3ba0e0973767e909dd33bd)

24 years agoclient.c: Changed shadowed variable.
Jeremy Allison [Mon, 6 Oct 1997 17:52:25 +0000 (17:52 +0000)]
client.c: Changed shadowed variable.
locking.c: Removed USE_OPLOCKS - now the default.
params.c: Removed unused variable.
proto.h: Updated.
reply.c: Removed USE_OPLOCKS - now the default.
server.c: Removed USE_OPLOCKS - now the default.
smb.h: Removed USE_OPLOCKS - now the default.
smbparse.c: Changed shadowed variable.
status.c: Removed USE_OPLOCKS - now the default.
util.c: Removed USE_OPLOCKS - now the default.
Jeremy (
(This used to be commit b93509846d6291771787af457500eec8984ee6bd)

24 years agolsaparse.c smb.h: added 32 bit "return status" to the response structures.
Luke Leighton [Mon, 6 Oct 1997 14:52:26 +0000 (14:52 +0000)]
lsaparse.c smb.h: added 32 bit "return status" to the response structures.
(This used to be commit 5bc75c6c626251dc8ba04ff4a83e81b92d93d2d6)

24 years agoMakefile: added lsaparse.c and smbparse.c
Luke Leighton [Mon, 6 Oct 1997 13:30:54 +0000 (13:30 +0000)]
Makefile:                      added lsaparse.c and smbparse.c
lsaparse.c, smbparse.c, smb.h: more functions / structures.
proto.h:                       the usual.
(This used to be commit a1c718728c46ebf8916af8985b4dae4d099f4ec2)

24 years agoupdating lsa and smb parsing routines and structures.
Luke Leighton [Sun, 5 Oct 1997 14:17:53 +0000 (14:17 +0000)]
updating lsa and smb parsing routines and structures.
(This used to be commit 2f722fe289051558dbe77aeb0a830bb3ded10a83)

24 years agoprocesses LSA queries and responses to/from RPC data stream into structures.
Luke Leighton [Sun, 5 Oct 1997 12:39:51 +0000 (12:39 +0000)]
processes LSA queries and responses to/from RPC data stream into structures.
(This used to be commit 369f7d41d6ff6d2b9b8c1e0cac99d0f0d03410b0)

24 years agosmb.h:
Luke Leighton [Sun, 5 Oct 1997 11:56:08 +0000 (11:56 +0000)]

added more structures, this time for the use in the query and response
of the LSA_XXXX functions.  next target: the NTLOGON mailslots (10 minutes


tidying.  adding some more sub-structure functions.
(This used to be commit 095edfca783a6f99eb7897d4c925ce8bc1ea0a3e)

24 years agoproto.h:
Luke Leighton [Sat, 4 Oct 1997 16:51:43 +0000 (16:51 +0000)]

- recreated, as usual.


- added RPC_HDR structure - the 18 byte MSRPC header


- added smb_io_rpc_hdr() function to read/write the RPC_HDR structure.


- added align2, align4, align_offset functions.
- added skip_unicode_string, unistrcpy, unistrncpy functions.
- modified unistrcpy and unistrncpy to return the number of unicode
  characters returned, effectively making skip_unicode_string redundant.
(This used to be commit b0ad811cda3dcffed5b24104229813cdb17b014f)

24 years agoadded some RW_XXXX wrapper macros with an extra i/o argument, to call XXXX
Luke Leighton [Sat, 4 Oct 1997 16:42:09 +0000 (16:42 +0000)]
added some RW_XXXX wrapper macros with an extra i/o argument, to call XXXX
or SXXXX as appropriate.

added some for-loop pointer macros that will do a batch of data into a
(fixed length) buffer.  no length validation is done in the macro itself.

note: there are some CAREFUL_ALIGNMENT macros missing.  i think.
(This used to be commit b0ffd75acfd3660512cccecdf50a183c3abccfcb)

24 years agoadded structures readable and writeable by smbparse.c routines into and out
Luke Leighton [Sat, 4 Oct 1997 16:26:02 +0000 (16:26 +0000)]
added structures readable and writeable by smbparse.c routines into and out
of SMB or Mailslot packets.
(This used to be commit 4b3f9b281b3b1c1064992d19fef1d782dc6f1ff1)

24 years agopacket parsing routines. for use in SMB and Mailslots
Luke Leighton [Sat, 4 Oct 1997 16:10:21 +0000 (16:10 +0000)]
packet parsing routines.  for use in SMB and Mailslots
(This used to be commit 297d5ef46ccba99596610c4c6a09399af665f2cf)

24 years agofix some "shadows global" errors.
Andrew Tridgell [Sat, 4 Oct 1997 05:24:02 +0000 (05:24 +0000)]
fix some "shadows global" errors.
(This used to be commit 25b7ada3587d1fe68164a2339d7f0fbcecf18e53)

24 years agoa bit of bounds checking
Andrew Tridgell [Sat, 4 Oct 1997 05:21:47 +0000 (05:21 +0000)]
a bit of bounds checking
(This used to be commit d40199f4fe1344058267859820cb36b77a20442a)

24 years agoa little hack to smbclient to support extracting NT error codes
Andrew Tridgell [Sat, 4 Oct 1997 05:21:14 +0000 (05:21 +0000)]
a little hack to smbclient to support extracting NT error codes
(This used to be commit 0eb9a590430c328e6ebc46ff8ab05f181921769a)

24 years agoThis is all the NT error codes less than 1000. I extracted them using
Andrew Tridgell [Sat, 4 Oct 1997 05:19:24 +0000 (05:19 +0000)]
This is all the NT error codes less than 1000. I extracted them using

If we want to start supporting NT error codes in Samba (which may be
forced upon us by buggy apps) then this is a good start.
(This used to be commit 20bfde40b20f43cf8c6714ab9fb5a3fd17bc1575)

24 years agoJHT ===> Added Sun Solaris binary package building spec files contributed
John Terpstra [Sat, 4 Oct 1997 02:57:14 +0000 (02:57 +0000)]
JHT ===> Added Sun Solaris binary package building spec files contributed
         by Tim Towers <>. Note: Not yet checked.
(This used to be commit 332f78bbc945c327069e9c9e29c7137c8cbd5c02)

24 years agonmblookup.c:
Christopher R. Hertel [Sat, 4 Oct 1997 01:07:47 +0000 (01:07 +0000)]
  I've added a -r option.  When specified, nmblookup will attempt to bind
  to port 137.  In order for this to work, the user must be root and the
  port must be available (i.e., nmbd not running).  If either condition is
  not met, nmblookup will default to normal behavior; it will try to bind
  to a free port above 7999.  I also removed an artifact.  The -p <port>
  option was being accepted but falling through to the default, which was
  the usage message.  I removed "p:" from the getopt() list.

  Rewritten.  The scanning is much more linear, and I found and fixed a
  few bugs.  I don't like the way that the scratch buffer is handled,
  but I believe that it is an improvement over the previous version.

Chris -)-----
(This used to be commit 09dc951f2acd67da9d895e8e00c01e7abbbe0960)

24 years agoRace condition with multiple oplock break requests happens
Jeremy Allison [Sat, 4 Oct 1997 00:23:57 +0000 (00:23 +0000)]
Race condition with multiple oplock break requests happens
more often than you might think (reproduced here with 4 clients
and netbench :-).
Raising debug log level for report from 1 to 3.
Jeremy (
(This used to be commit 23eeab7aa2e9c935e1f48ce3449544c03c1c899f)

24 years agoMaking it harder for share_mode_entries to be left with
Jeremy Allison [Fri, 3 Oct 1997 23:45:34 +0000 (23:45 +0000)]
Making it harder for share_mode_entries to be left with
non-zero op_type fields. Paranoia code really.
Jeremy (
(This used to be commit 21ecb46f56ac0f341803d0552c981e517d0322cb)

24 years agolocking.c: Fixed incorrect parameter count in debug statements. May explain
Jeremy Allison [Fri, 3 Oct 1997 20:36:06 +0000 (20:36 +0000)]
locking.c: Fixed incorrect parameter count in debug statements. May explain
           solaris crashes.
reply.c: Added NT specific error code. Put oplock break code in correct place
         in reply_lockingX.
server.c: Removed unneeded error mapping stuff.
          Fixed race condition in oplock code.
trans2.c: Added NT specific error code.
util.c: Added paranoia check in interpret_addr. Some core dumps
        reported here. Upped fcntl debug levels.

Andrew. Please check the NT specific error code handling (search
for the string "/* Ugly - NT specific hack - but needed (JRA) */",
this makes NT and 95 clients behave correctly here - please check
your Visual Basic apps with this code.

Jeremy (
(This used to be commit 97ee4a5f69bd9cfbbc8710a1a04d80db0ee40104)

24 years agoadd "static" to a couple of functions that are only used locally.
Andrew Tridgell [Fri, 3 Oct 1997 03:34:19 +0000 (03:34 +0000)]
add "static" to a couple of functions that are only used locally.

set granted_oplock=False at the start of open_file(). This is
(This used to be commit c7f09ffd4a00ef7266e3f54536ee6aaca9335fb8)

24 years agoproto.h: Updated.
Jeremy Allison [Fri, 3 Oct 1997 03:15:24 +0000 (03:15 +0000)]
proto.h: Updated.
server.c: Updated after netbench observation. Oplocks must be
broken *before* share modes are checked, not after. Netbench seems
to be working now.
smb.h: Added offsets for oplock break time fields.
trans2.c: Upped debug messages.
util.c: Upped debug messages.
Jeremy (
(This used to be commit bc4b70c566ed5fa926441fb64a0f756a6137d8d0)

24 years agochange a debug level in reply.c
Andrew Tridgell [Thu, 2 Oct 1997 14:11:34 +0000 (14:11 +0000)]
change a debug level in reply.c

change from ERRbaddirectory to ERRbadpath for ENOTDIR errors. This
reverts to the old Samba code. I've done quite a bit of testing
against NT4 and have yet to get it to produce the ERRbaddirectory
error code. Producing ERRbaddirectory made a visual basic application
that was sent to me not run. This might explain some of the "it
doesn't work any more" complaints we've got about 1.9.17.

Jeremy, can you remember how you got NT to produce ERRbaddirectory?
There might be some specific circumstances we need to cover.
(This used to be commit 1ed901ddffef48cdce87017bab0fd613e6ca8637)

24 years agoAdded debug message for oplock_break().
Jeremy Allison [Thu, 2 Oct 1997 03:26:07 +0000 (03:26 +0000)]
Added debug message for oplock_break().
Jeremy (
(This used to be commit 4f29dfbc791f1f08c8c44a6fbdd0bc31892455dd)

24 years agochange the semantics of hosts allow/hosts deny so that a global
Andrew Tridgell [Thu, 2 Oct 1997 03:14:32 +0000 (03:14 +0000)]
change the semantics of hosts allow/hosts deny so that a global
setting applies to all shares regardless of any settings on other
shares. This allows us to immediately drop a connection if it does not
come from a allowed host, without even parsing the first SMB
packet. The next time we get a nasty security hole we can offer people
the option of just setting their hosts allow line.

If we drop a connection in this way we generate a "Not listening for
calling name" response and then exit.

add a per share "oplocks" option in smb.conf. I think its important to
be able to disable oplocks on a per-share basis as there are occasions
then they are definately not wanted, for example when sharing data
between a windows box and a unix application. This also allows us to
tell people "try disabling oplocks" when diagnosing problems.

fix a bug in process_smb(). It was taking the length of the packet
from outbuf, not inbuf (this bug was introduced with the oplocks
code). Jeremy, I assume this wasn't deliberate?
(This used to be commit 44bc9f239aa0b3cdf6cf9ad8d3911e397eba7335)

24 years agoModified some debug messages, moved from 5 -> 8.
Jeremy Allison [Thu, 2 Oct 1997 02:36:11 +0000 (02:36 +0000)]
Modified some debug messages, moved from 5 -> 8.
Jeremy (
(This used to be commit cb83c74a6ccfc44721af65b75625a949782c758a)

24 years agoFixed problem with oplock_type being set with no port.
Jeremy Allison [Thu, 2 Oct 1997 00:57:59 +0000 (00:57 +0000)]
Fixed problem with oplock_type being set with no port.
Jeremy (
(This used to be commit 90484db0bfe25a096def627f94be24f3fa243375)

24 years agoOPLOCK CHECK-IN - oplocks are now *OPERATIONAL* !!!!
Jeremy Allison [Wed, 1 Oct 1997 23:32:22 +0000 (23:32 +0000)]
OPLOCK CHECK-IN - oplocks are now *OPERATIONAL* !!!!
Yipeee. At least as far as I can check in a short time :-).

local.h: Changed OPLOCK_BREAK_TIMEOUT to 30 seconds.
locking.c: Big changes to delete oplocks on a share mode entry.
proto.h: updated.
reply.c: Added oplock break code in lockingX reply & readbraw reply.
server.c: Add batch oplock code. Force server shutdown if client fails
          to respond to oplock break.
smb.h: Fix silly slow share mode oplock define bug.
status.c: Add oplock status info.

Jeremy (
(This used to be commit 4c83d37239f15f855fc10f01d7b4bf4217fb9eda)

24 years agoChanged consultant list.
Jeremy Allison [Tue, 30 Sep 1997 16:58:52 +0000 (16:58 +0000)]
Changed consultant list.
Jeremy (
(This used to be commit 6dbe5ad80ff368efdd81ec92d71d7567595157f1)

24 years agodir.c: more pstrcpys.
Jeremy Allison [Tue, 30 Sep 1997 02:38:19 +0000 (02:38 +0000)]
dir.c: more pstrcpys.
password.c: Fix for paranoia password server security bug.
proto.h: Updated.
reply.c: Oplock changes.
server.c: Massive oplock changes - nearly there....
smb.h: oplock definitions.
util.c: Add local message processing queues for oplocks.
Jeremy (
(This used to be commit 92f1553db2cdf6f32881eb984a87050cf3e4760b)

24 years agoFixed you're -> your text that some pedant complained about :-).
Jeremy Allison [Fri, 26 Sep 1997 19:40:12 +0000 (19:40 +0000)]
Fixed you're -> your text that some pedant complained about :-).
Jeremy (
(This used to be commit b11833f1bdecf1c3c3e5bc7494741605cba92a1e)

24 years agoSyncing up current oplock work in progress. #ifdef'ed out
Jeremy Allison [Fri, 26 Sep 1997 19:26:56 +0000 (19:26 +0000)]
Syncing up current oplock work in progress. #ifdef'ed out
so should have no effect on other work.
Jeremy (
(This used to be commit 7e3d4c8b21f63a06d32605d230129e36883ad08c)

24 years agoCorrectly rolled back interface.c (I was working on an older
Jeremy Allison [Fri, 26 Sep 1997 19:23:26 +0000 (19:23 +0000)]
Correctly rolled back interface.c (I was working on an older
revision). This will now be the current revision.
Jeremy (
(This used to be commit eb55ddd5bff1c6f95292215a8c53acb6bfdadeb2)

24 years agoAdding Andrews buffer overflow fixes into the main branch.
Jeremy Allison [Fri, 26 Sep 1997 18:55:29 +0000 (18:55 +0000)]
Adding Andrews buffer overflow fixes into the main branch.
Jeremy (
(This used to be commit e7eb1f044d3101679dc7a118820ea5efe0cd837c)

24 years agoadd error string reporting to clitar
Andrew Tridgell [Fri, 26 Sep 1997 09:06:51 +0000 (09:06 +0000)]
add error string reporting to clitar
(This used to be commit 2c5587a6fe425b1cc57cf28e92e77ba84f08ce33)

24 years agoAdded missing slow share mode offset defines. Somehow
Jeremy Allison [Thu, 25 Sep 1997 17:36:21 +0000 (17:36 +0000)]
Added missing slow share mode offset defines. Somehow
they got lost.
Jeremy (
(This used to be commit ce9cdc2f6175e4a6195f8875360cd945ae60052c)

24 years agoMakefile: Removed earlier errors.
Jeremy Allison [Thu, 25 Sep 1997 00:25:44 +0000 (00:25 +0000)]
Makefile: Removed earlier errors.
includes.h: Added INADDR_LOOPBACK define.
locking.c: More code to support oplocks.
proto.h: Updated.
server.c: More code to support oplocks. Moved processing of an SMB out of
process() into a separate function so it is easier to call from an oplock
smb.h: Added oplock fields.
Jeremy (
(This used to be commit f46dbaf08eb8e06a7545d2c19dce9e2dda9dcc78)

24 years agoCheckin to sync up oplock development code so that NT
Jeremy Allison [Tue, 23 Sep 1997 19:19:06 +0000 (19:19 +0000)]
Checkin to sync up oplock development code so that NT
domain development code won't diverge.

Makefile: Fixed make proto (again). Added GLIBC2 fixes for Linux.
includes.h: Added GLIBC2 fixes for Linux.
proto.h: Much tidier.
quotas.c: OSF/1 quota fix.
reply.c: Fix from Ray Frush <> for zero NT timestamps.
server.c util.c: First oplock checkin - nowhere near finished so bracketed
with #ifdef USE_OPLOCKS. Done to make sync with NT domain code easier.
Jeremy (
(This used to be commit 7dce7d84473beb5663b14a8ab32781970819c19d)

24 years agoadded code from Philip A Prindeville <> which expands
Luke Leighton [Tue, 23 Sep 1997 16:09:12 +0000 (16:09 +0000)]
added code from Philip A Prindeville <> which expands
the interfaces option to this:

"interfaces = le0 le1" or "interfaces = all".

it uses SIOCGIFxxxx ioctl calls.
(This used to be commit 39071415ba6f8a00e2909e443261d0059fe27e82)

24 years agosmbclient.1: Added documentation of the username%password environment code.
Jeremy Allison [Fri, 19 Sep 1997 17:40:11 +0000 (17:40 +0000)]
smbclient.1: Added documentation of the username%password environment code.
smb.conf.5: Added 'username level' docs.
Jeremy (
(This used to be commit b588615b201fda404c09637b344e9823443ce396)

24 years agoMakefile: Changed proto: target to not include c files not used currently.
Jeremy Allison [Fri, 19 Sep 1997 17:12:08 +0000 (17:12 +0000)]
Makefile: Changed proto: target to not include c files not used currently.
          Caused proto.h to be from a sorted list of C files.
arcfour.h: Added prototypes.
client.c: Added username%password in environment patch from John Blair <>
loadparm.c: Added username manipulation code from Peter McCool []
username.c: Added username manipulation code from Peter McCool []
mkproto.awk: Added arc4_key type.
proto.h: Updated & sorted.
Jeremy (
(This used to be commit 97ed4fea67095dfb83227e7b5fffc236ff277e02)

24 years agoAnother South American consultant.
Jeremy Allison [Fri, 19 Sep 1997 00:36:01 +0000 (00:36 +0000)]
Another South American consultant.
(This used to be commit eeb0e883536954adb090269a520a913b1676d59c)

24 years agoAdded arcfour code needed for SMB password changing.
Jeremy Allison [Thu, 18 Sep 1997 19:56:57 +0000 (19:56 +0000)]
Added arcfour code needed for SMB password changing.
Jeremy (
(This used to be commit 8bc3d13b3d66fc533d5bc6abf3fc9d5c67d0f286)

24 years agoadded timestamp to "Denied connection" message.
Luke Leighton [Thu, 18 Sep 1997 12:47:55 +0000 (12:47 +0000)]
added timestamp to "Denied connection" message.
(This used to be commit f28b14a86c22c3bad187ca57f03e13da795d4136)

24 years agoadded some debug stuff
Andrew Tridgell [Thu, 18 Sep 1997 07:05:43 +0000 (07:05 +0000)]
added some debug stuff
(This used to be commit 95184fd1ecdf5eea9c42d748db848210b7e863d3)

24 years agoJohn asked the other day about using the tar feature in smbclient to
Andrew Tridgell [Thu, 18 Sep 1997 06:52:49 +0000 (06:52 +0000)]
John asked the other day about using the tar feature in smbclient to
handle file paths longer than 100 characters (the limit of the normal
tar format).

This patch adds support for producing GNU tar files (which have no
real limit on the path length) in smbclient.

Note that I have only added support for producing GNU tar files, I
haven't added support for accepting them when restoring. I thought I'd
leave that up to John :-)
(This used to be commit d5daf85162e844c9e953cc4dfbb3f1d800747130)

24 years agoJHT ===> More hacks!
John Terpstra [Wed, 17 Sep 1997 14:54:35 +0000 (14:54 +0000)]
JHT ===> More hacks!
(This used to be commit 0b859fdfac07322f021dbb74791914e22f6b9884)

24 years agoJHT ===> Changed behaviour of logon script processing so that all macros
John Terpstra [Wed, 17 Sep 1997 13:53:59 +0000 (13:53 +0000)]
JHT ===> Changed behaviour of logon script processing so that all macros
         can be used in the logon script parameter definition in the smb.conf
         Globals section. This fixes a problem reported by Jacco de Leeuw
         where OS/2 does not see the %u variable. Jacco suggested using %U
         but we really do want the user for the netlogon share session.
         If this does not do the trick - well we eat our hat! Yeh!
(This used to be commit a7716b2e70606e447094509116455ea53fe8bf64)

24 years agoAdded documentation for the 'delete veto files' parameter.
Jeremy Allison [Wed, 17 Sep 1997 01:33:33 +0000 (01:33 +0000)]
Added documentation for the 'delete veto files' parameter.
Jeremy (
(This used to be commit c6e736283ec7558f8d5108c141e346cf0cc5742a)

24 years agoAdded 'delete veto files' paremeter. Ugly - but the only
Jeremy Allison [Wed, 17 Sep 1997 01:29:53 +0000 (01:29 +0000)]
Added 'delete veto files' paremeter. Ugly - but the only
way to allow Samba client users to delete directories
containing Mac metafile information (.AppleDouble directories).

Needed for clean integration with netatalk.

Jeremy (
(This used to be commit 29c6c037dc62e44784e9d127d1e7ef3dd1506733)

24 years agoFixing assumtions that malloced memory is zero filled - making
Jeremy Allison [Tue, 16 Sep 1997 17:40:17 +0000 (17:40 +0000)]
Fixing assumtions that malloced memory is zero filled - making
sure it is.
Jeremy (
(This used to be commit 59ee0d0c7ea166a3bf58ceb4c939217d6ff74498)

24 years agochange the encryption instructions to reflect the fact that the code
Andrew Tridgell [Tue, 16 Sep 1997 08:31:01 +0000 (08:31 +0000)]
change the encryption instructions to reflect the fact that the code
is now built in
(This used to be commit 82cfa6bb7cd5e5c7ad327787fb4cc72204118335)

24 years agoadd a cast
Andrew Tridgell [Tue, 16 Sep 1997 08:26:33 +0000 (08:26 +0000)]
add a cast
(This used to be commit e712c6ed61abeae5ec2acf99f109ad81e7a19978)

24 years ago- change generate_challenge() to use md4 instead of des
Andrew Tridgell [Tue, 16 Sep 1997 04:41:16 +0000 (04:41 +0000)]
- change generate_challenge() to use md4 instead of des

- move routines about a bit between smbencrypt.c and smbdes.c. Ensure
that there is no entry point for normal DES operation

- add the following comment:

   This code is NOT a complete DES implementation. It implements only
   the minimum necessary for SMB authentication, as used by all SMB
   products (including every copy of Microsoft Windows95 ever sold)

   In particular, it can only do a unchained forward DES pass. This
   means it is not possible to use this code for encryption/decryption
   of data, instead it is only useful as a "hash" algorithm.

   There is no entry point into this code that allows normal DES operation.

   I believe this means that this code does not come under ITAR
   regulations but this is NOT a legal opinion. If you are concerned
   about the applicability of ITAR regulations to this code then you
   should confirm it for yourself (and maybe let me know if you come
   up with a different answer to the one above)
(This used to be commit 35b92e725f351c9a9f2846a6b55f71c234f187c7)

24 years agobug fix in the new des code.
Andrew Tridgell [Tue, 16 Sep 1997 03:53:54 +0000 (03:53 +0000)]
bug fix in the new des code.

I had one of the sbox[] constants wrong, which interestingly gave a
20% chance of the whole algorithm failing.
(This used to be commit 9a42f88a0963d006e8bf091775a3f55f6c6b4f77)

24 years ago2 more consultants.
Jeremy Allison [Mon, 15 Sep 1997 20:01:35 +0000 (20:01 +0000)]
2 more consultants.
(This used to be commit e9f460ef0da6ca72a0b61d1b15115ffb0cb4bb42)

24 years agounbecome_domain_master and unbecome_logon_master were announcing
Luke Leighton [Mon, 15 Sep 1997 12:13:16 +0000 (12:13 +0000)]
unbecome_domain_master and unbecome_logon_master were announcing
as "dead".  removed this.
(This used to be commit d1f298cd529188c0cddb18e3a1bf8abb093b3c3b)

24 years ago- if the user already exists then ignore the -add command
Andrew Tridgell [Mon, 15 Sep 1997 06:36:55 +0000 (06:36 +0000)]
- if the user already exists then ignore the -add command

- change the way the smbpasswd file is auto-created if it doesn't
exist. It didn't work under IRIX for some unknown reason

The smbpasswd.c code is really a bit of a mess. We should probably
rewrite it sometime.
(This used to be commit 6e3697ad1218264c85c6c1f4b1521960e21e2a67)

24 years ago- change a lot of occurances of errno to use strerror(errno). We can't
Andrew Tridgell [Mon, 15 Sep 1997 05:43:37 +0000 (05:43 +0000)]
- change a lot of occurances of errno to use strerror(errno). We can't
assume all our users are programmers :-)

- automatically create the smbpasswd file if it doesn't exist when
running smbpasswd.
(This used to be commit 1d2361bd2dec35bce029699f54c6a61fa739fa4b)

24 years agorewrote md4.c from scratch. This implementation should be portable and
Andrew Tridgell [Mon, 15 Sep 1997 02:49:38 +0000 (02:49 +0000)]
rewrote md4.c from scratch. This implementation should be portable and
doesn't have any worries about RSA copyright.
(This used to be commit a1569971663f01c245c145b18290d9dba965dc36)

24 years agono longer needed
Andrew Tridgell [Mon, 15 Sep 1997 02:47:59 +0000 (02:47 +0000)]
no longer needed
(This used to be commit b04bc7f75e90a8150f7372d15f4f17fb0bb50ab9)

24 years agoThis commit does 3 main things:
Andrew Tridgell [Sun, 14 Sep 1997 16:37:18 +0000 (16:37 +0000)]
This commit does 3 main things:

1) put the encryption code in by default, with no #ifdef. It is still
disabled by default so you need to add "encrypt passwords = yes" in
smb.conf but at least all binaries will have it.

2) cleanup the kanji code so it compiles with no warnings

3) get rid of lots of uses of ugly non-portable C code. The main
offender being things like "register" but also remove uses of the
"const" keyword as there are compilers out there that don't support it
and even those that do often complain about its usage. Users don't
like warnings :-(

There is still some work to do. We need to replace the md4 code with
our own implementation. The current code (from rfc1186) is PD but is
not very portable. The new RFC (rfc1320) is more portable but adds
copyright restrictions. I'll do a from-scratch MD4 soon.

We also need to test that what I've implemented is portable. It should
be, but I'm too tired right now to test it on anything other than
intel linux.
(This used to be commit db917c62c14315afe6f0745a8097c1bca25cbf07)

24 years agoThis is a written from scratch DES implementation. I couldn't find a
Andrew Tridgell [Sun, 14 Sep 1997 16:19:49 +0000 (16:19 +0000)]
This is a written from scratch DES implementation. I couldn't find a
GPLd implementation so I decided to write one.

This version only does DES ecb encryption and isn't very general, so
it may in fact be exempt from ITAR regulations. ITAR regulations do
not prohibit the distribution of code that can be used for
authentication purposes only. This code has no decrypt function so it
would be useless for a normal encryption application and thus may be
ITAR exempt.

It is also very slow, but we don't need it to be fast. It is a literal
implementation from the standard and treats each bit as one byte to
make the code easy to write.
(This used to be commit c2bc073a878179dd56db97c66dc957d42fe0b81b)

24 years agoAdded fix that means if connecting user sends guest account
Jeremy Allison [Fri, 12 Sep 1997 16:29:36 +0000 (16:29 +0000)]
Added fix that means if connecting user sends guest account
with no password they are seen as guest. Previous patch
broke this.

Jeremy (
(This used to be commit 9a55c49626f65627b26417795891260bb2afcc27)

24 years agocharcnv.c client.c clitar.c kanji.c kanji.h loadparm.c
Jeremy Allison [Thu, 11 Sep 1997 20:17:32 +0000 (20:17 +0000)]
charcnv.c client.c clitar.c kanji.c kanji.h loadparm.c
mangle.c smb.h util.c:

  Big merge to allow KANJI support to be in the main
binary without explicitly compiling with it.

locking.c: Fix for smbstatus not being able to read files.
namepacket.c: Removed unneccesary debug statement.
trans2.c: Added Luke's proposed fix (ifdefed out until further testing).
nmblookup.c: Fixed bug where query fails and status is done on bogus IP.

Jeremy (
(This used to be commit 9196255022ae8c51b527412747b324819bea2c13)

24 years agofix a couple of "declaration shadows previous local" warnings.
Andrew Tridgell [Thu, 11 Sep 1997 02:30:00 +0000 (02:30 +0000)]
fix a couple of "declaration shadows previous local" warnings.
(This used to be commit c30f6a74d0e6c256b1d46b28c1f31f1c1f3dd856)

24 years agoprototype updates for new functions
Andrew Tridgell [Thu, 11 Sep 1997 02:19:35 +0000 (02:19 +0000)]
prototype updates for new functions
(This used to be commit dbf662436031759b205f0140223da6a1d08c16df)

24 years agoadd the stdout parameter to lp_dump()
Andrew Tridgell [Thu, 11 Sep 1997 02:19:23 +0000 (02:19 +0000)]
add the stdout parameter to lp_dump()
(This used to be commit 77f5bc87058dfb5c1b14e7cd8c6097a6bcb2c0cc)