Jeremy Allison [Wed, 30 Mar 2011 20:08:31 +0000 (13:08 -0700)]
Fix convert_string() to take a *converted_size arg. and return a bool.
Makes these interfaces much harder to misuse and easier to ensure error
checking.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 30 23:59:37 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 20:24:42 +0000 (22:24 +0200)]
s3-build: make it a little easier to build smbtorture4.
Only configure with --enable-socket-wrapper --enable-nss-wrapper
--enable-uid-wrapper, not --enable-developer which turns on at least one -Werror
switch.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 23:12:42 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 20:24:18 +0000 (22:24 +0200)]
s3-vfs: try to fix build of aio_fork module.
Guenther
Jeremy Allison [Wed, 30 Mar 2011 17:27:04 +0000 (10:27 -0700)]
Change convert_string_internal() and convert_string_error() to bool return.
Move closer to makeing all convert_string_XXX functions return bool.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Mar 30 20:58:10 CEST 2011 on sn-devel-104
Jeremy Allison [Wed, 30 Mar 2011 17:13:01 +0000 (10:13 -0700)]
Fix the nstring calls to use the correct sizes.
Jeremy Allison [Wed, 30 Mar 2011 16:58:22 +0000 (09:58 -0700)]
This doesn't look like it has anything to do with character set conversion, but it does :-).
Turns out one of the *really* significant differences between
convert_string() in source4 and source3, is that the one in
source3 will return 0 for byte length converted when called
with dest_len = 0 whereas the one in source4 returns (size_t)-1
and sets errno to E2BIG.
Allow the ndr_string code to cope with the (arguably correct)
way that the source4 implementation works. This code only gets
excercised in the print spooler tests, which aren't run in source4,
which is why this bug has lasted for so long.
You don't want to know how long it took me to find this :-).
Jeremy.
Volker Lendecke [Wed, 30 Mar 2011 14:38:31 +0000 (16:38 +0200)]
s3: Fix g_lock_lock after the select/poll conversion
Without clustering we don't have an fd to listen on, and sys_poll
needs one element of space
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 18:36:50 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 14:18:38 +0000 (16:18 +0200)]
s3-smbd: try to fix the irix build.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 17:17:58 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 13:14:05 +0000 (15:14 +0200)]
s3-vfs acl modules: more non-linux build fixes.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 16:00:02 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 13:09:10 +0000 (15:09 +0200)]
s3-passdb: move LOOKUP_NAME_ flags to passdb where they belong to.
Guenther
Günther Deschner [Wed, 30 Mar 2011 12:49:37 +0000 (14:49 +0200)]
s3-passdb: move some passdb defines to passdb.h
Guenther
Günther Deschner [Wed, 30 Mar 2011 12:48:18 +0000 (14:48 +0200)]
s3-proto: pure cosmetics, remove some generated comments.
Guenther
Günther Deschner [Wed, 30 Mar 2011 12:03:13 +0000 (14:03 +0200)]
s3-winbind: try to fix the build on hosts w/o winbind support.
Guenther
Günther Deschner [Wed, 30 Mar 2011 11:46:59 +0000 (13:46 +0200)]
s3-vfs_solarisacl: try to fix the solaris build.
Guenther
Volker Lendecke [Wed, 30 Mar 2011 11:19:46 +0000 (13:19 +0200)]
s3: Use cli_ntcreate to when listing snapshots
This works for directories as well
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 14:37:02 CEST 2011 on sn-devel-104
Günther Deschner [Wed, 30 Mar 2011 10:39:36 +0000 (12:39 +0200)]
s3: Fix Coverity ID 2041, "UNUSED_VALUE"
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 13:49:35 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 30 Mar 2011 06:49:30 +0000 (17:49 +1100)]
lib/util/charset Add tests for convert_string_talloc_handle()
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Mar 30 13:02:47 CEST 2011 on sn-devel-104
Andrew Bartlett [Wed, 30 Mar 2011 06:49:01 +0000 (17:49 +1100)]
lib/util Move base64 functions into lib/util/base64.c
Andrew Bartlett
Andrew Bartlett [Tue, 29 Mar 2011 02:21:52 +0000 (13:21 +1100)]
s3:lib make lazy_initialize_conv() static
Andrew Bartlett [Mon, 28 Mar 2011 22:45:22 +0000 (09:45 +1100)]
lib/util/charset Remove pointless static bool initialised
Günther Deschner [Wed, 30 Mar 2011 08:50:10 +0000 (10:50 +0200)]
s3: try to fix the build on some non-linux buildfarm machines.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 11:39:31 CEST 2011 on sn-devel-104
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2217: RESOURCE_LEAK
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 30 10:45:44 CEST 2011 on sn-devel-104
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2220: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2221: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 05:06:18 +0000 (07:06 +0200)]
s3: Fix Coverity ID 2222: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 05:04:47 +0000 (07:04 +0200)]
s3: Fix Coverity ID 2223: RESOURCE_LEAK
Volker Lendecke [Wed, 30 Mar 2011 04:57:05 +0000 (06:57 +0200)]
s3: Fix Coverity ID 2236: REVERSE_INULL
We have already dereferenced "b", and the other calls in this loop can only
have worked with a valid handle
Volker Lendecke [Wed, 30 Mar 2011 04:41:18 +0000 (06:41 +0200)]
s3: Fix Coverity ID 2332: MISSING_BREAK
Volker Lendecke [Wed, 30 Mar 2011 04:53:15 +0000 (06:53 +0200)]
s3: Fix Coverity ID 2237: REVERSE_INULL
Volker Lendecke [Wed, 30 Mar 2011 04:51:40 +0000 (06:51 +0200)]
tdb: Fix Coverity ID 2238: SECURE_CODING
Volker Lendecke [Wed, 30 Mar 2011 04:45:04 +0000 (06:45 +0200)]
s3: Fix Coverity ID 2304: FORWARD_NULL
Matthias Dieter Wallnöfer [Sun, 27 Mar 2011 20:14:56 +0000 (22:14 +0200)]
s4:lib/policy/gp_ldap.c - make more use of LDB result constants
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Mar 30 09:33:38 CEST 2011 on sn-devel-104
Matthias Dieter Wallnöfer [Fri, 25 Mar 2011 19:03:42 +0000 (20:03 +0100)]
s4:lib/registry/registry.h - align a copyright line in header comment
Matthias Dieter Wallnöfer [Thu, 24 Mar 2011 08:41:19 +0000 (09:41 +0100)]
talloc - improve doxygen comment of "talloc_move"
Express better that this should be a pointer of a pointer.
Reviewed-by: Tridge
Matthias Dieter Wallnöfer [Thu, 24 Mar 2011 09:28:10 +0000 (10:28 +0100)]
s4:smb_server/smb/trans2.c - "talloc_move" isn't strictly necessary here
Since the "set" will be free'd afterwards "talloc_steal" is enough.
Reviewed-by: Tridge
Günther Deschner [Mon, 28 Mar 2011 10:27:21 +0000 (12:27 +0200)]
s3-ctdb_wrap: remove unused variable from db_ctdb_fetch_persistent().
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Mar 30 02:00:50 CEST 2011 on sn-devel-104
Günther Deschner [Fri, 25 Mar 2011 13:12:59 +0000 (14:12 +0100)]
s3-rpc_server: move access check functions out of samr server.
Guenther
Günther Deschner [Fri, 25 Mar 2011 12:42:42 +0000 (13:42 +0100)]
s3: only include ntioctl.h where needed.
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:56:52 +0000 (11:56 +0100)]
s3: only include lib/privileges.h where needed.
This finally removes the global lsa.h inclusion.
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:56:10 +0000 (11:56 +0100)]
s3: include ../librpc/gen_ndr/lsa.h where needed.
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:40:00 +0000 (11:40 +0100)]
s3-passdb: move lsa_dom_info and lsa_name_info out of smb.h into passdb.
Guenther
Günther Deschner [Thu, 24 Mar 2011 21:33:07 +0000 (22:33 +0100)]
s3-includes: only include ntdomain.h where needed.
Guenther
Günther Deschner [Thu, 24 Mar 2011 21:32:17 +0000 (22:32 +0100)]
pidl: add an include for "ntdomain.h" for s3 server stubs.
Guenther
Günther Deschner [Thu, 24 Mar 2011 14:56:32 +0000 (15:56 +0100)]
s3-messages: make ndr_messaging.h part of messages.h.
Guenther
Günther Deschner [Thu, 24 Mar 2011 14:31:06 +0000 (15:31 +0100)]
s3-messages: only include messages.h where needed.
Guenther
Günther Deschner [Thu, 24 Mar 2011 13:16:28 +0000 (14:16 +0100)]
s3-prototyes: user_in_netgroup and user_in_list moved to auth, out of smbd.
Guenther
Günther Deschner [Fri, 25 Mar 2011 01:28:17 +0000 (02:28 +0100)]
s3-includes: finally remove global include of auth.h.
Guenther
Günther Deschner [Thu, 24 Mar 2011 13:15:54 +0000 (14:15 +0100)]
s3-auth: vfs modules need auth.h
Guenther
Günther Deschner [Thu, 24 Mar 2011 13:12:42 +0000 (14:12 +0100)]
s3-auth: printing needs auth.h
Guenther
Günther Deschner [Thu, 24 Mar 2011 12:46:20 +0000 (13:46 +0100)]
s3-auth: smbd needs auth.h
Guenther
Günther Deschner [Thu, 24 Mar 2011 11:08:15 +0000 (12:08 +0100)]
s3-auth: rpc_server needs auth.h
Guenther
Günther Deschner [Fri, 25 Mar 2011 01:28:05 +0000 (02:28 +0100)]
s3-auth: use auth.h where needed.
Guenther
Günther Deschner [Fri, 25 Mar 2011 01:27:24 +0000 (02:27 +0100)]
s3-auth: move auth prototypes to auth/proto.h.
Guenther
Günther Deschner [Wed, 23 Mar 2011 13:18:59 +0000 (14:18 +0100)]
s3-libsmb: put namequery headers to nmblib.h
We might find a better name for it and merge other namequery related things as
well here...
Guenther
Günther Deschner [Wed, 23 Mar 2011 11:43:17 +0000 (12:43 +0100)]
s3-locking: move locking prototypes out of proto.h.
Will later become part of locking.h
Guenther
Günther Deschner [Fri, 25 Mar 2011 10:15:55 +0000 (11:15 +0100)]
s3: finally remove global include of smbd prototypes.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:49:33 +0000 (23:49 +0100)]
s3: rpc_server needs parts of smbd.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:49:17 +0000 (23:49 +0100)]
s3: printing needs parts of smbd.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:49:03 +0000 (23:49 +0100)]
s3: auth also needs parts of smbd.
Guenther
Günther Deschner [Tue, 22 Mar 2011 21:34:22 +0000 (22:34 +0100)]
s3-vfs: include smbd/smbd.h in vfs modules.
Guenther
Günther Deschner [Tue, 22 Mar 2011 15:57:01 +0000 (16:57 +0100)]
s3: include smbd/smbd.h where needed.
Guenther
Günther Deschner [Fri, 18 Mar 2011 23:47:12 +0000 (00:47 +0100)]
s3-smbd: add smbd.h and move smbd prototypes to smbd/proto.h.
Guenther
Günther Deschner [Tue, 22 Mar 2011 20:45:44 +0000 (21:45 +0100)]
s3: move filename_util.c out of source3/smbd to source3/lib.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:58:21 +0000 (23:58 +0100)]
s3-build: only include intl protos where needed.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:32:56 +0000 (23:32 +0100)]
s3-passdb: finally stop including passdb.h globaly.
Guenther
Günther Deschner [Tue, 22 Mar 2011 15:50:02 +0000 (16:50 +0100)]
s3-passdb: use passdb headers where needed.
Guenther
Günther Deschner [Wed, 23 Mar 2011 13:57:08 +0000 (14:57 +0100)]
s3-passdb: move util_builtin.c out of passdb.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:23:17 +0000 (23:23 +0100)]
s3-passdb: move util_unixsids.c out of passdb.
Guenther
Günther Deschner [Tue, 22 Mar 2011 22:20:49 +0000 (23:20 +0100)]
s3-passdb: move util_wellknown.c out of passdb.
Guenther
Günther Deschner [Tue, 22 Mar 2011 16:43:39 +0000 (17:43 +0100)]
s3-winbindd: copy acct_info to wb_acct_info so we dont need passdb for it.
Guenther
Günther Deschner [Tue, 22 Mar 2011 15:48:05 +0000 (16:48 +0100)]
s3-passdb: add machine_sid.h and lookup_sid.h
Guenther
Günther Deschner [Fri, 18 Mar 2011 23:46:41 +0000 (00:46 +0100)]
s3-proto: add some forward declarations.
Guenther
Günther Deschner [Fri, 18 Mar 2011 17:58:37 +0000 (18:58 +0100)]
s3-passdb: add passdb.h where needed.
Guenther
Günther Deschner [Fri, 18 Mar 2011 15:22:14 +0000 (16:22 +0100)]
s3-passdb: move mapping.h into passdb.h, its needed here.
Guenther
Günther Deschner [Fri, 18 Mar 2011 15:05:55 +0000 (16:05 +0100)]
s3-passdb: move passdb headers to passdb/proto.h.
Guenther
Günther Deschner [Fri, 18 Mar 2011 15:05:26 +0000 (16:05 +0100)]
s3-groupdb: move groupdb headers to groupdb/proto.h.
Guenther
Günther Deschner [Thu, 24 Mar 2011 12:16:20 +0000 (13:16 +0100)]
s3: create_builtin_users/administrators belongs to passdb not auth.
Guenther
Günther Deschner [Fri, 25 Feb 2011 23:56:46 +0000 (00:56 +0100)]
s3-build: only include transfer_file.h where needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 23:28:15 +0000 (00:28 +0100)]
registry: create and use shared libcli/registry/util_reg.h header.
Guenther
Günther Deschner [Fri, 25 Feb 2011 22:34:23 +0000 (23:34 +0100)]
s3-includes: no point in including all security headers globally.
Guenther
Günther Deschner [Fri, 25 Feb 2011 22:36:14 +0000 (23:36 +0100)]
s3-includes: remove EILSEQ check, this is handled by
../lib/replace/system/iconv.h already.
Guenther
Günther Deschner [Fri, 25 Feb 2011 22:20:06 +0000 (23:20 +0100)]
s3-includes: only include system/filesys.h when needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 22:05:22 +0000 (23:05 +0100)]
s3-includes: remove global include of "system/network.h"
Guenther
Günther Deschner [Fri, 25 Feb 2011 16:14:22 +0000 (17:14 +0100)]
s3-includes: only include system/passwd.h when needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 16:03:27 +0000 (17:03 +0100)]
s3-includes: only include system/shmem.h when needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 15:52:51 +0000 (16:52 +0100)]
s3-includes: remove global include of "system/select.h".
Guenther
Günther Deschner [Fri, 25 Feb 2011 15:48:10 +0000 (16:48 +0100)]
s3-includes: only include system/terminal.h when needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 15:39:14 +0000 (16:39 +0100)]
s3-includes: only include system/capability.h when needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 15:34:46 +0000 (16:34 +0100)]
s3-includes: only include system/glob.h when needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 15:29:14 +0000 (16:29 +0100)]
s3-includes: only include system/iconv.h when needed.
Guenther
Günther Deschner [Fri, 25 Feb 2011 15:19:10 +0000 (16:19 +0100)]
s3-includes: only include system/syslog.h when needed.
Guenther
Günther Deschner [Thu, 24 Feb 2011 23:03:01 +0000 (00:03 +0100)]
s3-trans2: only include trans2.h where needed.
Guenther
Günther Deschner [Thu, 24 Feb 2011 21:30:16 +0000 (22:30 +0100)]
s3-winbind: remove global inclusion of libwbclient.
Guenther
Günther Deschner [Wed, 2 Mar 2011 15:11:00 +0000 (16:11 +0100)]
lib/util/util_pw: share more code between lib/util/util_pw.c and source3/lib/username.c
Guenther
Günther Deschner [Wed, 2 Mar 2011 15:06:32 +0000 (16:06 +0100)]
lib/util/util_pw: share sys_get{pw,gr} group of calls.
Guenther
Günther Deschner [Wed, 2 Mar 2011 15:31:01 +0000 (16:31 +0100)]
lib/util/util_pw: temporary rename of getpwnam_alloc and getpwuid_alloc.
Guenther
Jeremy Allison [Tue, 29 Mar 2011 18:16:26 +0000 (11:16 -0700)]
Ensure convert_string_XXX is always called with a valid converted_size pointer.
Preparation for cleaning up this API.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 29 21:01:49 CEST 2011 on sn-devel-104
Volker Lendecke [Tue, 29 Mar 2011 16:22:18 +0000 (18:22 +0200)]
charconv: Fix the slow-path character conversions
This reverts a part of
0189087e257f. That one might have fixed the fast path,
but it broke the slow path. convert_string_internal returns 0/-1 despite the
size_t result type and the misleading comment. If you follow the path to
smb_iconv and for example iconv_copy(), you will see that this routine returns
0 even after it copied something.
How to check: Use German locale, and do an smbclient "allinfo" on a file
modified in march (März in German). Notice the "ä". Before
0189087 this printed
correctly, after
0189087 it cut off the fields after the M for März.
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 29 19:17:41 CEST 2011 on sn-devel-104
Günther Deschner [Tue, 29 Mar 2011 10:50:38 +0000 (12:50 +0200)]
s3-libsmb: remove duplicate NTSTATUS variable.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 29 17:00:26 CEST 2011 on sn-devel-104
Günther Deschner [Mon, 28 Mar 2011 14:42:21 +0000 (16:42 +0200)]
s3-waf: fix spoolssd compile.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>