samba.git
8 years agos3-waf: add check for TIME_T_MAX.
Günther Deschner [Tue, 22 Feb 2011 10:49:52 +0000 (11:49 +0100)]
s3-waf: add check for TIME_T_MAX.

Guenther

8 years agos3-waf: add check for /proc/sys/kernel/core_pattern.
Günther Deschner [Tue, 22 Feb 2011 10:41:06 +0000 (11:41 +0100)]
s3-waf: add check for /proc/sys/kernel/core_pattern.

Guenther

8 years agos4-descriptor: Fixed a typo in a comment and clarified it a bit.
Nadezhda Ivanova [Tue, 22 Feb 2011 04:30:53 +0000 (06:30 +0200)]
s4-descriptor: Fixed a typo in a comment and clarified it a bit.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Tue Feb 22 12:39:23 CET 2011 on sn-devel-104

8 years agos4-descriptor: Fixed some missing curly braces.
Nadezhda Ivanova [Tue, 22 Feb 2011 04:28:19 +0000 (06:28 +0200)]
s4-descriptor: Fixed some missing curly braces.

8 years agos4:torture/rpc/netlogon.c - fix two build warnings by casts
Matthias Dieter Wallnöfer [Tue, 22 Feb 2011 09:26:04 +0000 (10:26 +0100)]
s4:torture/rpc/netlogon.c - fix two build warnings by casts

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Feb 22 11:45:49 CET 2011 on sn-devel-104

8 years agoselftest the raw.mux test is flaky:
Andrew Bartlett [Tue, 22 Feb 2011 02:37:06 +0000 (13:37 +1100)]
selftest the raw.mux test is flaky:

TESTING MULTIPLEXED LOCK/LOCK/UNLOCK
establishing a lock
the second lock will conflict with the first
this will too, but we'll unlock while waiting
unlock the first range
recv the async reply
async lock took 265.40 msec
failed to trigger early lock retry
UNEXPECTED(error): samba3.posix_s3.raw.mux.mux

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Feb 22 07:09:07 CET 2011 on sn-devel-104

8 years agos4-auth Move libcli/security/session.c to the top level
Andrew Bartlett [Thu, 10 Feb 2011 09:21:11 +0000 (20:21 +1100)]
s4-auth Move libcli/security/session.c to the top level

This code is now useful in common, as the elements of the
auth_session_info structure have now been defined in common IDL.

Andrew Bartlett

8 years agos3:auth: change num_groups to from size_t to uint32_t
Stefan Metzmacher [Mon, 21 Feb 2011 09:30:28 +0000 (10:30 +0100)]
s3:auth: change num_groups to from size_t to uint32_t

This will help with the change from UNIX_USER_TOKEN to security_unix_token

metze

8 years agos3-auth Rename auth_serversupplied_info varaiables: server_info -> session_info
Andrew Bartlett [Mon, 21 Feb 2011 09:25:52 +0000 (10:25 +0100)]
s3-auth Rename auth_serversupplied_info varaiables: server_info -> session_info

These variables, of type struct auth_serversupplied_info were poorly
named when added into 2001, and in good consistant practice, this has
extended all over the codebase in the years since.

The structure is also not ideal for it's current purpose.  Originally
intended to convey the results of the authentication modules, it
really describes all the essential attributes of a session.  This
rename will reduce the volume of a future patch to replaced these with
a struct auth_session_info, with auth_serversupplied_info confined to
the lower levels of the auth subsystem, and then eliminated.

(The new structure will be the output of create_local_token(), and the
change in struct definition will ensure that this is always run, populating
local groups and privileges).

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agoselftest: Improve gdb_backtrace to run in batch mode
Andrew Bartlett [Tue, 22 Feb 2011 01:28:33 +0000 (12:28 +1100)]
selftest: Improve gdb_backtrace to run in batch mode

Following Tridge's advice, we need to have no input (/dev/null) and
-batch for reliable opeation on big backtraces.

We should also use --pid, and let gdb find the binary

Andrew Bartlett

8 years agoselftest pass in srcdir into Samba3 target module
Andrew Bartlett [Tue, 22 Feb 2011 00:56:18 +0000 (11:56 +1100)]
selftest pass in srcdir into Samba3 target module

8 years agosmbtorture Remove random file name before we start RW2
Andrew Bartlett [Tue, 22 Feb 2011 00:21:53 +0000 (11:21 +1100)]
smbtorture Remove random file name before we start RW2

8 years agos3-selftest convert tests.sh to python
Andrew Bartlett [Mon, 21 Feb 2011 05:01:44 +0000 (16:01 +1100)]
s3-selftest convert tests.sh to python

This should allow us a much better chance of invoking the subunit
wrappers in the right way, at the right level.

Andrew Bartlett

8 years agoselftest split $PERL into multiple arguments for Test::More check
Andrew Bartlett [Mon, 21 Feb 2011 22:17:05 +0000 (09:17 +1100)]
selftest split $PERL into multiple arguments for Test::More check

8 years agoselftest move selftesthelpers to a top level helper script
Andrew Bartlett [Mon, 21 Feb 2011 00:16:03 +0000 (11:16 +1100)]
selftest move selftesthelpers to a top level helper script

8 years agos3-tests use $PREFIX to ensure tests don't work outside the test area
Andrew Bartlett [Sun, 20 Feb 2011 22:10:33 +0000 (09:10 +1100)]
s3-tests use $PREFIX to ensure tests don't work outside the test area

Andrew Bartlett

8 years agoAdd tests for various s3 auth modes
Andrew Bartlett [Fri, 18 Feb 2011 07:52:00 +0000 (18:52 +1100)]
Add tests for various s3 auth modes

8 years agobuild: added WHYNEEDED=TARGET:DEPENDENCY
Andrew Tridgell [Mon, 21 Feb 2011 23:59:44 +0000 (10:59 +1100)]
build: added WHYNEEDED=TARGET:DEPENDENCY

you can now do:

  make WHYNEEDED=smbd/smbd:gensec

and it will print:

 Checking why smbd/smbd needs to link to gensec
 target 'smbd/smbd' uses symbols set(['open_schannel_session_store']) from 'gensec'

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Feb 22 03:35:58 CET 2011 on sn-devel-104

8 years agobuild: enhanced the symbolcheck code
Andrew Tridgell [Mon, 21 Feb 2011 23:47:27 +0000 (10:47 +1100)]
build: enhanced the symbolcheck code

we can now work out why a binary needs a library, and we can find all
the duplicate symbols (we currently have 1087 symbols defined in more
than one place in Samba).

8 years agopython: use os.environ[] instead of os.putenv()
Andrew Tridgell [Mon, 21 Feb 2011 05:46:58 +0000 (16:46 +1100)]
python: use os.environ[] instead of os.putenv()

using os.putenv() causes too much confusion, as it doesn't update
os.getenv()

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-waf: fixed make test for toplevel
Andrew Tridgell [Mon, 21 Feb 2011 05:45:53 +0000 (16:45 +1100)]
s4-waf: fixed make test for toplevel

amazingly, os.putenv() is broken. If you do os.putenv('FOO', '1') and
then do os.getenv('FOO') you don't get '1'

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-waf: added --enable-s3build configure option
Andrew Tridgell [Mon, 21 Feb 2011 04:50:51 +0000 (15:50 +1100)]
s4-waf: added --enable-s3build configure option

this enables the build of the s3 binaries in the toplevel build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: build bin/smbclient3 for top level build
Andrew Tridgell [Mon, 21 Feb 2011 04:23:08 +0000 (15:23 +1100)]
s3-waf: build bin/smbclient3 for top level build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agobuild: we don't need the special case for s3build any more
Andrew Tridgell [Mon, 21 Feb 2011 04:10:36 +0000 (15:10 +1100)]
build: we don't need the special case for s3build any more

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: no need to add suffix3 to smbpasswd
Andrew Tridgell [Mon, 21 Feb 2011 04:05:54 +0000 (15:05 +1100)]
s3-waf: no need to add suffix3 to smbpasswd

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-waf: rename smbpasswd library to smbpasswdparser
Andrew Tridgell [Mon, 21 Feb 2011 04:05:28 +0000 (15:05 +1100)]
s4-waf: rename smbpasswd library to smbpasswdparser

this removes a conflict with the s3 smbpasswd binary

8 years agos3-waf: convert some subsystems into private libraries
Andrew Tridgell [Mon, 21 Feb 2011 03:45:37 +0000 (14:45 +1100)]
s3-waf: convert some subsystems into private libraries

put some commonly used subsystems into private libraries to reduce the
install size

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-waf: rename 'param' to 'pyparam'
Andrew Tridgell [Mon, 21 Feb 2011 03:42:34 +0000 (14:42 +1100)]
s4-waf: rename 'param' to 'pyparam'

we will use 'param' for the s3 libparam.so

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: work around broken cups-config --libs output
Andrew Tridgell [Mon, 21 Feb 2011 02:58:13 +0000 (13:58 +1100)]
s3-waf: work around broken cups-config --libs output

"cups-config --libs" returns -lgssapi_krb5, which ties it to the
system krb5 library. It should get this via the indirect dependency of
libcups.so instead.

Work around this by using 'cups' as the library and avoid using --libs
in the cups-config command

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3build: use source3/wscript for s3 configure rules
Andrew Tridgell [Mon, 21 Feb 2011 01:17:49 +0000 (12:17 +1100)]
s3build: use source3/wscript for s3 configure rules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: added support for in-tree heimdal in source3 waf build
Andrew Tridgell [Mon, 21 Feb 2011 01:16:46 +0000 (12:16 +1100)]
s3-waf: added support for in-tree heimdal in source3 waf build

this sets up the right defines for a in-tree heimdal build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: use Logs.warn() not print for configure warnings
Andrew Tridgell [Mon, 21 Feb 2011 01:16:03 +0000 (12:16 +1100)]
s3-waf: use Logs.warn() not print for configure warnings

this highlights the warning for the user

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: make pieces of the source3 waf wscript depends on toplevel_build
Andrew Tridgell [Mon, 21 Feb 2011 01:14:38 +0000 (12:14 +1100)]
s3-waf: make pieces of the source3 waf wscript depends on toplevel_build

this will allow the toplevel build to use source3/wscript for
configure options

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3build: recurse into source3/
Andrew Tridgell [Mon, 21 Feb 2011 00:18:21 +0000 (11:18 +1100)]
s3build: recurse into source3/

we can now use common build rules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: cope with both toplevel and source3 build
Andrew Tridgell [Mon, 21 Feb 2011 00:16:43 +0000 (11:16 +1100)]
s3-waf: cope with both toplevel and source3 build

this fixes the remaining subsystem differences for the two builds

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: find swat files for both toplevel and source3 build
Andrew Tridgell [Mon, 21 Feb 2011 00:14:49 +0000 (11:14 +1100)]
s3-waf: find swat files for both toplevel and source3 build

this finds the right swat files in both cases

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: rename CHARSET to CHARSET3
Andrew Tridgell [Mon, 21 Feb 2011 00:14:13 +0000 (11:14 +1100)]
s3-waf: rename CHARSET to CHARSET3

and add an alias CHARSET when not using a toplevel build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: use bld.env.suffix3 for differentiating toplevel build
Andrew Tridgell [Mon, 21 Feb 2011 00:12:22 +0000 (11:12 +1100)]
s3-waf: use bld.env.suffix3 for differentiating toplevel build

this uses bld.env.suffix3 to mean "3" for a toplevel build, and blank
otherwise. This allows us to change the overlapping binaries to have a
'3' suffix

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: LIBADS depends on krb5
Andrew Tridgell [Mon, 21 Feb 2011 00:11:44 +0000 (11:11 +1100)]
s3-waf: LIBADS depends on krb5

needed for krb5.h when using an in-tree heimdal

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: make version and build directory conditional
Andrew Tridgell [Mon, 21 Feb 2011 00:10:35 +0000 (11:10 +1100)]
s3-waf: make version and build directory conditional

we don't need these when doing a toplevel build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: cope with location of include.h for toplevel build
Andrew Tridgell [Mon, 21 Feb 2011 00:09:56 +0000 (11:09 +1100)]
s3-waf: cope with location of include.h for toplevel build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: added some more krb5 dependencies
Andrew Tridgell [Sun, 20 Feb 2011 23:40:35 +0000 (10:40 +1100)]
s3-waf: added some more krb5 dependencies

this is needed when not using a system krb5, for finding krb5.h

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: renamed samba-util to samba-util3
Andrew Tridgell [Sun, 20 Feb 2011 23:36:11 +0000 (10:36 +1100)]
s3-waf: renamed samba-util to samba-util3

also added alias samba-util when not using a toplevel build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: use common libcli/nbt build rules
Andrew Tridgell [Sun, 20 Feb 2011 23:14:54 +0000 (10:14 +1100)]
s3-waf: use common libcli/nbt build rules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: rename 'errors' to 'errors3'
Andrew Tridgell [Sun, 20 Feb 2011 23:14:13 +0000 (10:14 +1100)]
s3-waf: rename 'errors' to 'errors3'

and add an alias 'errors' if not doing a toplevel build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: renamed tdb-wrap to tdb-wrap3
Andrew Tridgell [Sun, 20 Feb 2011 23:12:48 +0000 (10:12 +1100)]
s3-waf: renamed tdb-wrap to tdb-wrap3

allow for a common name 'tdb-wrap'

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: rename POPT_SAMBA to POPT_SAMBA3
Andrew Tridgell [Sun, 20 Feb 2011 23:09:21 +0000 (10:09 +1100)]
s3-waf: rename POPT_SAMBA to POPT_SAMBA3

This renames the POPT_SAMBA subsystem to POPT_SAMBA3. It also adds an
alias 'POPT_SAMBA' if we are not doing a toplevel build.

This allows us to use the common dependency 'POPT_SAMBA' in other waf
rules.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: added a krb5 dependency
Andrew Tridgell [Sun, 20 Feb 2011 23:02:05 +0000 (10:02 +1100)]
s3-waf: added a krb5 dependency

LIBMSRPC depends on krb5.h

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agolibcli/nbt: allow use of the waf build for nbt in source3
Andrew Tridgell [Sun, 20 Feb 2011 23:00:49 +0000 (10:00 +1100)]
libcli/nbt: allow use of the waf build for nbt in source3

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-ndr: added NDR_WBINT to ndr_tables
Andrew Tridgell [Tue, 15 Feb 2011 05:28:37 +0000 (16:28 +1100)]
s4-ndr: added NDR_WBINT to ndr_tables

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-rpc_server: Let enpoint mapper listen on port 135.
Andreas Schneider [Mon, 21 Feb 2011 08:58:26 +0000 (09:58 +0100)]
s3-rpc_server: Let enpoint mapper listen on port 135.

*** This is my commit #500 ***

Endpoint Mapper is disabled by default. The next steps are to setup a
tcpip and ncalrpc listener for each service and register it at epm.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue Feb 22 00:07:45 CET 2011 on sn-devel-104

8 years agos3-rpc_server: Added event and msg ctx to _rpc_ep_register.
Andreas Schneider [Mon, 21 Feb 2011 15:28:38 +0000 (16:28 +0100)]
s3-rpc_server: Added event and msg ctx to _rpc_ep_register.

8 years agos3-rpc_server: Added port option to _rpc_ep_register.
Andreas Schneider [Mon, 21 Feb 2011 08:08:47 +0000 (09:08 +0100)]
s3-rpc_server: Added port option to _rpc_ep_register.

8 years agos3-rpc_server: Added function to setup tcpip listener!
Andreas Schneider [Mon, 14 Feb 2011 09:29:14 +0000 (10:29 +0100)]
s3-rpc_server: Added function to setup tcpip listener!

8 years agos3-rpc_server: Rename srv_rpc_register.c.
Andreas Schneider [Thu, 17 Feb 2011 11:24:41 +0000 (12:24 +0100)]
s3-rpc_server: Rename srv_rpc_register.c.

8 years agos3-rpc_server: Rename srv_rpc_register.
Andreas Schneider [Thu, 17 Feb 2011 11:21:09 +0000 (12:21 +0100)]
s3-rpc_server: Rename srv_rpc_register.

8 years agos3-rpc_server: Pass tevent_context to dcerpc endpoints.
Andreas Schneider [Thu, 17 Feb 2011 11:18:45 +0000 (12:18 +0100)]
s3-rpc_server: Pass tevent_context to dcerpc endpoints.

8 years agos3-rpc_server: Create a common ncacn listen state.
Andreas Schneider [Tue, 15 Feb 2011 11:57:26 +0000 (12:57 +0100)]
s3-rpc_server: Create a common ncacn listen state.

8 years agos3-rpc_server: Rename named_pipe_read_packet().
Andreas Schneider [Mon, 14 Feb 2011 14:58:14 +0000 (15:58 +0100)]
s3-rpc_server: Rename named_pipe_read_packet().

This is not named pipe specific.

8 years agos3-librpc: Only register NCACN_NP.
Andreas Schneider [Mon, 21 Feb 2011 16:55:52 +0000 (17:55 +0100)]
s3-librpc: Only register NCACN_NP.

This is the only transport we support at the moment.

8 years agos3-lsa: fix some uninitialized variables in our lsa server.
Günther Deschner [Mon, 21 Feb 2011 16:35:45 +0000 (17:35 +0100)]
s3-lsa: fix some uninitialized variables in our lsa server.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Feb 21 18:47:30 CET 2011 on sn-devel-104

8 years agos3-pdb_ipa: remove uninitialized (and unused) status code.
Günther Deschner [Mon, 21 Feb 2011 16:32:48 +0000 (17:32 +0100)]
s3-pdb_ipa: remove uninitialized (and unused) status code.

Guenther

8 years agos4-descriptor: Fixed some compiler warnings.
Nadezhda Ivanova [Mon, 21 Feb 2011 15:17:12 +0000 (17:17 +0200)]
s4-descriptor: Fixed some compiler warnings.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Mon Feb 21 18:02:21 CET 2011 on sn-devel-104

8 years agos4-descriptor: Removed unnecessary descriptor_change function and unused callbacks.
Nadezhda Ivanova [Mon, 21 Feb 2011 15:14:12 +0000 (17:14 +0200)]
s4-descriptor: Removed unnecessary descriptor_change function and unused callbacks.

8 years agos4-descriptor: Replaced the async descriptor_change with synchronous descriptor_modify.
Nadezhda Ivanova [Mon, 21 Feb 2011 15:08:44 +0000 (17:08 +0200)]
s4-descriptor: Replaced the async descriptor_change with synchronous descriptor_modify.

The purpose is to make descriptor module synchronous. This will simplify reading and debugging, and also will make the
    implementation of SD hierarchy recalculation on modify much easier.

8 years agos4-descriptor: Replaced the synchronous descriptor_change with the synchronous descri...
Nadezhda Ivanova [Mon, 21 Feb 2011 15:04:27 +0000 (17:04 +0200)]
s4-descriptor: Replaced the synchronous descriptor_change with the synchronous descriptor_add.

The purpose is to make descriptor module synchronous. This will simplify reading and debugging, and also will make the
implementation of SD hierarchy recalculation on modify much easier.

8 years agos4-smbtorture: use torture_comment() instead of printf in raw.write test.
Günther Deschner [Mon, 21 Feb 2011 13:03:23 +0000 (14:03 +0100)]
s4-smbtorture: use torture_comment() instead of printf in raw.write test.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Feb 21 15:26:38 CET 2011 on sn-devel-104

8 years agos4-smbtorture: fix some indent in raw.write test.
Günther Deschner [Mon, 21 Feb 2011 13:01:27 +0000 (14:01 +0100)]
s4-smbtorture: fix some indent in raw.write test.

Guenther

8 years agos4-smbtorture: fix trailing whitespace in raw.write test.
Günther Deschner [Mon, 21 Feb 2011 13:00:08 +0000 (14:00 +0100)]
s4-smbtorture: fix trailing whitespace in raw.write test.

Guenther

8 years agos4:scripting/python/modules.[ch] - explicitly say that "py_update_path" takes no...
Matthias Dieter Wallnöfer [Mon, 21 Feb 2011 10:47:17 +0000 (11:47 +0100)]
s4:scripting/python/modules.[ch] - explicitly say that "py_update_path" takes no argument

This quiets some build warnings.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Feb 21 14:42:00 CET 2011 on sn-devel-104

8 years agos3:tests: move the log directory of the smbclient_s3 test to st/
Michael Adam [Mon, 21 Feb 2011 11:48:48 +0000 (12:48 +0100)]
s3:tests: move the log directory of the smbclient_s3 test to st/

And use a proper mktemp call to create a unique name.
The old location under /tmp/ was bad.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 21 13:39:06 CET 2011 on sn-devel-104

8 years agos3:tests: clean up old log directories of the registry.roundtrip test
Michael Adam [Mon, 21 Feb 2011 11:48:15 +0000 (12:48 +0100)]
s3:tests: clean up old log directories of the registry.roundtrip test

8 years agos4:smbtorture do not leave output directory around
Christian Ambach [Fri, 18 Feb 2011 14:02:35 +0000 (15:02 +0100)]
s4:smbtorture do not leave output directory around

calling smbtorture with no or invalid arguments left the temporary
output directory around
this patches removes the dead-end exit from usage and makes the
logic go on until the final cleanup state is reached

output directory will still be left around when test times out
or testcases itself force an exit

also make sure that the directory itself is deleted, not just
the objects in it

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Feb 21 11:35:30 CET 2011 on sn-devel-104

8 years agolibcli/security/security_descriptor.c - fix three wrong counter variables
Matthias Dieter Wallnöfer [Wed, 16 Feb 2011 08:22:43 +0000 (09:22 +0100)]
libcli/security/security_descriptor.c - fix three wrong counter variables

These strictly need to be "uint32_t" since "acl*->num_aces" has been
defined by this type.

This counter patchset has been reviewed by Andrew Bartlett.

8 years agolibcli/security/privileges.c - fix wrong counter type
Matthias Dieter Wallnöfer [Wed, 16 Feb 2011 08:12:17 +0000 (09:12 +0100)]
libcli/security/privileges.c - fix wrong counter type

This strictly needs to be from type "uint32_t" since "privset->count"
is defined with this type.

8 years agolibcli/security/privileges.c - fix the counting of privileges
Matthias Dieter Wallnöfer [Wed, 16 Feb 2011 08:20:11 +0000 (09:20 +0100)]
libcli/security/privileges.c - fix the counting of privileges

Since the privileges are always counted with a signed integer, there is no
reason to specify the upper limit with a "uint32_t".

8 years agolibcli/security/sddl.c - fix wrong counter type
Matthias Dieter Wallnöfer [Wed, 16 Feb 2011 08:12:17 +0000 (09:12 +0100)]
libcli/security/sddl.c - fix wrong counter type

This strictly needs to be from type "uint32_t" since "acl->num_aces" is
defined of this type.

8 years agolibcli/security/display_sec.c - fix wrong counter type
Matthias Dieter Wallnöfer [Wed, 16 Feb 2011 08:12:17 +0000 (09:12 +0100)]
libcli/security/display_sec.c - fix wrong counter type

This strictly needs to be of type "uint32_t" due to
"sec_acl->num_aces" which is of type "uint32_t".

8 years agos4: avoid overwritting the dceprc.h file from toplevel librpc
Matthieu Patou [Sun, 20 Feb 2011 10:23:48 +0000 (13:23 +0300)]
s4: avoid overwritting the dceprc.h file from toplevel librpc

Change back to what was the configuration of header_path before
177ddcb084e8f8608bf2012a7c58f7b1e56d2acd so that dcerpc.h is installed
in ${prefix}/include and not in ${prefix}/include/gen_ndr as the
toplevel librpc wants also to put a dcerpc.h file in this directory.

Add some documentation in order to avoid any new regression.

This change should fix problems for openchange team.

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Mon Feb 21 09:47:05 CET 2011 on sn-devel-104

8 years agopyldb: add tests for getting control results
Matthieu Patou [Wed, 9 Feb 2011 09:50:35 +0000 (12:50 +0300)]
pyldb: add tests for getting control results

8 years agopyldb: Add tests for the ldb_result object
Matthieu Patou [Wed, 9 Feb 2011 08:22:46 +0000 (11:22 +0300)]
pyldb: Add tests for the ldb_result object

8 years agopyldb: create LdbResult, return value from ldb.search is now a LdbResult
Matthieu Patou [Mon, 7 Feb 2011 06:50:36 +0000 (09:50 +0300)]
pyldb: create LdbResult, return value from ldb.search is now a LdbResult

8 years agos4-unittests: replace assertEquals(res, []) by assertEquals(len(res), 0)
Matthieu Patou [Wed, 9 Feb 2011 18:51:34 +0000 (21:51 +0300)]
s4-unittests: replace assertEquals(res, []) by assertEquals(len(res), 0)

8 years agoldb: controls marshalling/unmarshalling improvement
Matthieu Patou [Sun, 20 Feb 2011 12:23:27 +0000 (15:23 +0300)]
ldb: controls marshalling/unmarshalling improvement

Add a function to marshall a control to a string
Refactor the code of ldb_control_parse_strings to allow to extract the
core code into ldb_control_parse_from_string so that this function can
be called for just 1 string

8 years agoFix missing dependency on libreplace.
Jelmer Vernooij [Sun, 20 Feb 2011 23:26:12 +0000 (00:26 +0100)]
Fix missing dependency on libreplace.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 21 01:17:33 CET 2011 on sn-devel-104

8 years agos4/drs-tests:Blackbox test to verify DsReplicaSync handling
Kamen Mazdrashki [Sun, 20 Feb 2011 02:21:32 +0000 (04:21 +0200)]
s4/drs-tests:Blackbox test to verify DsReplicaSync handling

DsReplicaSync is indirectly called using 'samba-tool drs options' command
to enable/disable replication and 'samba-tool drs replicate' command
to trigger inbound replication cycle

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sun Feb 20 23:03:03 CET 2011 on sn-devel-104

8 years agos4/samba.tests: Raise BlackboxProcessError exception in case check_output method...
Kamen Mazdrashki [Sun, 20 Feb 2011 02:17:25 +0000 (04:17 +0200)]
s4/samba.tests: Raise BlackboxProcessError exception in case check_output method fails

This way the caller gets the chance to receive STDOUT and STDERR for
a failed process.
We may use this info to check if a process has failed properly,
e.g. with expected output

8 years agos4/samba.tests: Extend CalledProcessError class to store STDOUT and STDERR for a...
Kamen Mazdrashki [Sun, 20 Feb 2011 02:15:08 +0000 (04:15 +0200)]
s4/samba.tests: Extend CalledProcessError class to store STDOUT and STDERR for a failed rocess call

8 years agos4/drs-tests: Allow _net_drs_replicate to force replication and return output from...
Kamen Mazdrashki [Fri, 18 Feb 2011 02:27:19 +0000 (04:27 +0200)]
s4/drs-tests: Allow _net_drs_replicate to force replication and return output from command execution

8 years agos4/drs-tests: Split samba-tool command line generation into separate method
Kamen Mazdrashki [Fri, 18 Feb 2011 02:09:45 +0000 (04:09 +0200)]
s4/drs-tests: Split samba-tool command line generation into separate method

so we can use to exec samba-tool passing different commands

8 years agos4/drs-tests: Inherit DrsReplSchemaTestCase from DrsBaseTestCase
Kamen Mazdrashki [Fri, 18 Feb 2011 01:25:20 +0000 (03:25 +0200)]
s4/drs-tests: Inherit DrsReplSchemaTestCase from DrsBaseTestCase

and remove duplicated functionality

8 years agos4/drs-tests: Inherit DrsFsmoTestCase from DrsBaseTestCase
Kamen Mazdrashki [Fri, 18 Feb 2011 01:25:02 +0000 (03:25 +0200)]
s4/drs-tests: Inherit DrsFsmoTestCase from DrsBaseTestCase

and remove duplicated functionality

8 years agos4/drs-tests: Inherit DrsDeleteObjectTestCase from DrsBaseTestCase
Kamen Mazdrashki [Fri, 18 Feb 2011 01:24:08 +0000 (03:24 +0200)]
s4/drs-tests: Inherit DrsDeleteObjectTestCase from DrsBaseTestCase

and remove duplicated functionality

8 years agos4/drs-tests: Add a base class to hold common functionality for all DRS python tests
Kamen Mazdrashki [Fri, 18 Feb 2011 00:54:50 +0000 (02:54 +0200)]
s4/drs-tests: Add a base class to hold common functionality for all DRS python tests

8 years agos3: Fix pdb_ads_enum_aliasmem for empty aliases
Volker Lendecke [Sun, 20 Feb 2011 18:55:01 +0000 (19:55 +0100)]
s3: Fix pdb_ads_enum_aliasmem for empty aliases

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 20 21:40:40 CET 2011 on sn-devel-104

8 years agos3: Support SetGroupInfo in pdb_ads
Volker Lendecke [Sun, 20 Feb 2011 17:39:30 +0000 (18:39 +0100)]
s3: Support SetGroupInfo in pdb_ads

8 years agos3: Fix a debug message
Volker Lendecke [Sun, 20 Feb 2011 17:39:09 +0000 (18:39 +0100)]
s3: Fix a debug message

8 years agos3: Fix pdb_ads_enum_group_members for empty groups
Volker Lendecke [Sun, 20 Feb 2011 16:53:26 +0000 (17:53 +0100)]
s3: Fix pdb_ads_enum_group_members for empty groups

8 years agos3: Fix error returns in pdb_ads_mod_groupmem
Volker Lendecke [Sun, 20 Feb 2011 16:41:22 +0000 (17:41 +0100)]
s3: Fix error returns in pdb_ads_mod_groupmem

8 years agos4-version: Fix version finding for bzr branches.
Jelmer Vernooij [Sun, 20 Feb 2011 15:28:54 +0000 (16:28 +0100)]
s4-version: Fix version finding for bzr branches.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 20 17:35:45 CET 2011 on sn-devel-104