samba.git
23 years agoMove man page section from (1) to (8) for smbd.
Jeremy Allison [Wed, 28 Oct 1998 18:41:06 +0000 (18:41 +0000)]
Move man page section from (1) to (8) for smbd.
Jeremy.
(This used to be commit 83aa193439253bdd8e5ad7961c1db5c9328f1780)

23 years agoAdded clear-out-structure fix for make_unistr2.
Jeremy Allison [Wed, 28 Oct 1998 18:32:34 +0000 (18:32 +0000)]
Added clear-out-structure fix for make_unistr2.
Jeremy.
(This used to be commit 2bce2cf6d83d9889d8b116f9d2ee254b7ceb4828)

23 years agoFixes to allow this to pass SGI compiler in -fullwarn mode (with one
Jeremy Allison [Wed, 28 Oct 1998 18:26:04 +0000 (18:26 +0000)]
Fixes to allow this to pass SGI compiler in -fullwarn mode (with one
annoying exception I'm still looking at :-).
Jeremy.
(This used to be commit 9cade656e2db743cb6ee67bbb8b0f50e8e4c39f9)

23 years agoQuick fixes to fix the broken tree. Needed for my morning compiles.
Jeremy Allison [Wed, 28 Oct 1998 17:51:49 +0000 (17:51 +0000)]
Quick fixes to fix the broken tree. Needed for my morning compiles.
Chris - feel free to fix these things differently if these fixes don't
work for you.
Jeremy.
(This used to be commit 1f225abfbe6b021b589711c2e4c599a63050c5b2)

23 years agoFix from thwartedefforts@wonky.org (slightly modified) to
Jeremy Allison [Wed, 28 Oct 1998 17:15:28 +0000 (17:15 +0000)]
Fix from thwartedefforts@wonky.org (slightly modified) to
fix username overwriting problem in security=share.
Jeremy.
(This used to be commit 17621964344336c6303386c3c9e8a3e23b9e46e1)

23 years agofixed problem with snprintf.c and mkproto
Andrew Tridgell [Wed, 28 Oct 1998 12:04:34 +0000 (12:04 +0000)]
fixed problem with snprintf.c and mkproto
(This used to be commit 99430ce899c02b95ab3c577afff7f28c6d5c6c45)

23 years agouse abort() instead of exit() in smb_panic()
Andrew Tridgell [Wed, 28 Oct 1998 06:05:34 +0000 (06:05 +0000)]
use abort() instead of exit() in smb_panic()

the reason we don't return() here is that smb_panic() is used not just
for segv but also for detected errors (such as buffer overflows)
(This used to be commit 7a50ca81a5842f7139e67c0ff9de79518599f445)

23 years agofixed handling of %.0f in replacement snprintf.c
Andrew Tridgell [Wed, 28 Oct 1998 04:07:51 +0000 (04:07 +0000)]
fixed handling of %.0f in replacement snprintf.c
(This used to be commit 177b7b6b190c78ab59e19187d3221d23bb280911)

23 years agoNot finished yet - added so I can check it out at home
Jeremy Allison [Wed, 28 Oct 1998 02:35:07 +0000 (02:35 +0000)]
Not finished yet - added so I can check it out at home
and work on it tonight (I hate my life :-( ).
Jeremy.
(This used to be commit 12cb7caa9a1161cb8135d7d8e9f345a5589d2578)

23 years agoFixed a small bug in debug2html. It wasn't properly checking EOF. The
Christopher R. Hertel [Tue, 27 Oct 1998 23:28:29 +0000 (23:28 +0000)]
Fixed a small bug in debug2html.  It wasn't properly checking EOF.  The
current status is "it works".  I need to add some syntax error recovery
and a usage message.  Basic stuff.

I've also modified Makefile.in.  If you want to compile it you'll have to
do a 'make debug2html', as I used smbtorture as a model.  We can decide
later if this tool is useful enough to be compiled always.

BTW, a 'make realclean' fails because the bin directory isn't empty.
That's because it doesn't delete optionally compiled files such as
smbtorture and debug2html (and because of the CVS subdirectory, but I
think that's only a problem for developers).

Chris -)-----
(This used to be commit e86fd87a3806f4c161a8f887bbdd4d400ae56ac2)

23 years agoAdded info about parsing debug messages.
Christopher R. Hertel [Tue, 27 Oct 1998 21:07:52 +0000 (21:07 +0000)]
Added info about parsing debug messages.

Chris -)-----
(This used to be commit 26fcdfd082e84df675ad06c7ba8c0cdbf07eed98)

23 years agoFixed a few doc bugs in make_smbcodepage.1.yo samba.7.yo
Jeremy Allison [Tue, 27 Oct 1998 19:33:20 +0000 (19:33 +0000)]
Fixed a few doc bugs in make_smbcodepage.1.yo samba.7.yo
Added smbd.8.yo.
Jeremy.
(This used to be commit 695b31d0664f2c52704c49b49e56223b793dfc00)

23 years agodebug string with no %s parameter. oops
Luke Leighton [Tue, 27 Oct 1998 15:08:02 +0000 (15:08 +0000)]
debug string with no %s parameter.  oops
(This used to be commit 22721b027139ffb7ff2625741b68701ba15fbb98)

23 years agoamazing. the improvements to NT continue, evidence for which shows up
Luke Leighton [Tue, 27 Oct 1998 15:03:47 +0000 (15:03 +0000)]
amazing.  the improvements to NT continue, evidence for which shows up
now as "RPC fault" if the UNIHDR structure lengths do not exactly
match up to the length of the data stream.

so, all versions of samba prior to this one have an off-by-one bug
in unicode string lengths.

all versions of NT prior to NT 5 beta 2 could possibly have buffer
problems when receiving badly formatted UNICODE strings.
(This used to be commit 161eb6f511e161b63c1fa90a08c562fcf208344a)

23 years agoYODL conversion of make_smbcodepage.1
Jeremy Allison [Tue, 27 Oct 1998 01:54:33 +0000 (01:54 +0000)]
YODL conversion of make_smbcodepage.1
Jeremy.
(This used to be commit 7ad30c43ba3108631ac1fb98a96a0d5d66fca36c)

23 years agoadd ifdef for "long double"
Andrew Tridgell [Tue, 27 Oct 1998 00:07:06 +0000 (00:07 +0000)]
add ifdef for "long double"
(This used to be commit ae1888529b00f1a98d2b76fec7f19684efca90c7)

23 years agoadded a vsnprintf() implementation from cvslock. See the notes on the
Andrew Tridgell [Mon, 26 Oct 1998 23:40:33 +0000 (23:40 +0000)]
added a vsnprintf() implementation from cvslock. See the notes on the
license at the top of lib/snprintf.c

I've always been slightly uneasy about our half-baked vslprintf()
implementation and the risks on platforms that don't have vsnprintf()
so when I saw this code in another GPLd package I wanted it for Samba.
(This used to be commit e2cb50af45be6683d02ab48a6648816ee3d52ab1)

23 years agoHere is the simple debug parser and the debug2html converter. Still to do:
Christopher R. Hertel [Mon, 26 Oct 1998 23:21:37 +0000 (23:21 +0000)]
Here is the simple debug parser and the debug2html converter.  Still to do:

  * Debug message filtering.
  * I need to add all this to Makefile.in
    (If it looks at all strange I'll ask for help.)

If you want to compile debug2html, you'll need to do it by hand until I
make the changes to Makefile.in.  Sorry.

Chris -)-----
(This used to be commit fae161b9051c3ea8aa129bdb3df11d215007723d)

23 years agoFirst part of YODL converted documentation.
Jeremy Allison [Mon, 26 Oct 1998 20:08:31 +0000 (20:08 +0000)]
First part of YODL converted documentation.
Jeremy.
(This used to be commit c4fbf36ff7da29e001dc93829d4bc74d26aeec06)

23 years agoAdded new German consultant.
Jeremy Allison [Mon, 26 Oct 1998 20:01:14 +0000 (20:01 +0000)]
Added new German consultant.
Jeremy.
(This used to be commit 91b4f547eb0239b521bed57e840e34ccc65cfefc)

23 years agoFixed a couple of issues with the SMB_QUERY_FILE_ALL_INFO query.
Jeremy Allison [Mon, 26 Oct 1998 18:44:01 +0000 (18:44 +0000)]
Fixed a couple of issues with the SMB_QUERY_FILE_ALL_INFO query.
Ensured offset was being reported correctly for 64 bit file access,
ensured delete on close bit was being reported correctly.
Jeremy.
(This used to be commit 4332bc06c6604a3e14007eda4f40e6183a1f8526)

23 years agoreport ourselves as HTTP/1.0 not HTTP/1.1
Andrew Tridgell [Mon, 26 Oct 1998 10:55:29 +0000 (10:55 +0000)]
report ourselves as HTTP/1.0 not HTTP/1.1
(This used to be commit b2210614e810c8e84c9a14a8e32e05f95d92479b)

23 years agoadded a couple more error codes to cli_error()
Andrew Tridgell [Mon, 26 Oct 1998 03:31:00 +0000 (03:31 +0000)]
added a couple more error codes to cli_error()
(This used to be commit b2a7f85d597d4d2a71fd38d76aac0464d53df626)

23 years agoA little more tweaking and sqeaking. Now, will it work? Argh!
John Terpstra [Sun, 25 Oct 1998 12:08:49 +0000 (12:08 +0000)]
A little more tweaking and sqeaking. Now, will it work? Argh!
(This used to be commit d42b641acba95f45ad204e64e80e30d5d96490e8)

23 years agoWelcome to Pacific HiTech TurboLinux support.
John Terpstra [Sun, 25 Oct 1998 09:12:42 +0000 (09:12 +0000)]
Welcome to Pacific HiTech TurboLinux support.
(This used to be commit 230c42ab64aafb69313d5a8f9773bbd2bc6d47f9)

23 years agoPackaging mods - make sure we always keep our config files and NEVER mv them to ...
John Terpstra [Sun, 25 Oct 1998 09:08:22 +0000 (09:08 +0000)]
Packaging mods - make sure we always keep our config files and NEVER mv them to *.rpmsave
(This used to be commit af36d39434eaf39817f9916be79dcf2817897ee2)

23 years agofix for John.
Andrew Tridgell [Sat, 24 Oct 1998 08:24:11 +0000 (08:24 +0000)]
fix for John.

don't seek unless absolutely necessary on files in do_put()
(This used to be commit 9d33d405cdbd9ae61fb68b6f5ce5f56f86cc54bb)

23 years agohandle the case of an intermediate binary not loading smbwrapper.so
Andrew Tridgell [Sat, 24 Oct 1998 08:14:17 +0000 (08:14 +0000)]
handle the case of an intermediate binary not loading smbwrapper.so
(for example /usr/bin/man because it is setgid).
(This used to be commit 85f639ab2ba72dda5a00cf11c8ee705f5a51ec54)

23 years agovolker was concerned about unique inode numbers and smbsh. This set of
Andrew Tridgell [Sat, 24 Oct 1998 08:08:05 +0000 (08:08 +0000)]
volker was concerned about unique inode numbers and smbsh. This set of
changes uses the unique index number from a SMB_QUERY_FILE_ALL_INFO to
try to provide inode numbers. If it is 0 then use the hash of the
filename as before.
(This used to be commit 2565ccf9de9d5e80fdb5bcadbc7130faba386d95)

23 years agomake sure that apps can't close one of the internal smbw file
Andrew Tridgell [Sat, 24 Oct 1998 06:36:22 +0000 (06:36 +0000)]
make sure that apps can't close one of the internal smbw file
descriptors by catching close attempts on those fds and returning
EBADF.
(This used to be commit 9d863fb1681a5b03696552e1d93fe339b4bae455)

23 years agoFix for -fpic rules (.c.po and .c.po32) when using --enable-maintainer-mode.
Tim Potter [Sat, 24 Oct 1998 06:23:02 +0000 (06:23 +0000)]
Fix for -fpic rules (.c.po and .c.po32) when using --enable-maintainer-mode.
(This used to be commit 552175fdcb78c79833464648b5ccdc91b935e69c)

23 years agoUnlink zero length files that did NOT exist at the point of origin on a do_get()...
John Terpstra [Sat, 24 Oct 1998 02:49:09 +0000 (02:49 +0000)]
Unlink zero length files that did NOT exist at the point of origin on a do_get() call.
(This used to be commit 98ba0b3a0a5074cf2b7adba407c5fd46f63c3f27)

23 years agoadded domain and local group structures. names may have to be 256 chars
Luke Leighton [Fri, 23 Oct 1998 21:45:16 +0000 (21:45 +0000)]
added domain and local group structures.  names may have to be 256 chars
long not 128 (fstring) length.
(This used to be commit 1e96e14e790e733bbd182a828b0db8727fead2a2)

23 years agoHandle the case where multiple smbd have the file open, some of whom
Jeremy Allison [Fri, 23 Oct 1998 17:25:14 +0000 (17:25 +0000)]
Handle the case where multiple smbd have the file open, some of whom
don't have the ALLOW_DELETE_ON_CLOSE share flag enabled. Told you
this was fiddly code :-).
Jeremy.
(This used to be commit 222d686a6cdbc2947e7201636ae80ef4c650a65d)

23 years agoset netlogon negotiation flags to 0x1ff, not to what the client requests.
Luke Leighton [Fri, 23 Oct 1998 17:22:21 +0000 (17:22 +0000)]
set netlogon negotiation flags to 0x1ff, not to what the client requests.
this is 0x4000 01ff on NT4 SP4, and 0x0000 01ff on pre-NT4 SP4.
(This used to be commit 59cf9c00d91f9706d58c3d3000842eccb9d272fc)

23 years agopossible bug in change oem password code: replaced E_P16 and E_md4hash
Luke Leighton [Fri, 23 Oct 1998 15:21:37 +0000 (15:21 +0000)]
possible bug in change oem password code: replaced E_P16 and E_md4hash
with a call to nt_lm_owf_gen.  if this still doesn't get the NT hash
generated correctly then there may instead be a bug in mod_smbpwd_entry().
(This used to be commit 1c8c644210870fef7ea3eddf411b01a98f991fcc)

23 years agoUpdated paths.
John Terpstra [Fri, 23 Oct 1998 14:21:55 +0000 (14:21 +0000)]
Updated paths.
(This used to be commit 21e56ce707963507fe301b4feaad62964196aa46)

23 years agoMake the new code conditional on lp_share_modes() just like the code in open_file_sha...
Jeremy Allison [Fri, 23 Oct 1998 03:52:28 +0000 (03:52 +0000)]
Make the new code conditional on lp_share_modes() just like the code in open_file_shared().
Jeremy.
(This used to be commit 8de02620ea8f45f6a700617911947467e7be46e1)

23 years agoFixed debug reporting in the changed code.
Jeremy Allison [Fri, 23 Oct 1998 03:44:57 +0000 (03:44 +0000)]
Fixed debug reporting in the changed code.
Jeremy.
(This used to be commit d815e2d7a65c95ae71372b4fc8fe82f0202386dc)

23 years agoFixed bug in previous commit where I was overwriting share_mode from
Jeremy Allison [Fri, 23 Oct 1998 03:41:11 +0000 (03:41 +0000)]
Fixed bug in previous commit where I was overwriting share_mode from
one fsp with that of another. Not good :-).
Jeremy.
(This used to be commit 269bca2b3bbf5cae9fdf05d0405bfd80272da5d1)

23 years agoReasonably large change to give us *exactly* correct NT delete on close semantics.
Jeremy Allison [Fri, 23 Oct 1998 03:34:50 +0000 (03:34 +0000)]
Reasonably large change to give us *exactly* correct NT delete on close semantics.
This was trickier than it looks :-). Check out the new DELETE_ON_CLOSE
flag in the share modes and the new code that iterates through all open
files on the same device and inode in files.c and trans2.c

Also changed the code that modifies share mode entries to take
generic function pointers rather than doing a specific thing so
this sort of change should be easier in the future.

Jeremy.
(This used to be commit 5e6a7cd99d29d1cf068fc517272559c1cf47ea3a)

23 years agodon't enable smbsh/smbwrapper on systems where we can't work out how
Andrew Tridgell [Fri, 23 Oct 1998 01:51:31 +0000 (01:51 +0000)]
don't enable smbsh/smbwrapper on systems where we can't work out how
to generate PIC code
(This used to be commit a66c56d70e7e663f3a19cbfcc2e704653d8fc9b2)

23 years agodon't use SMBW_PWD_ENV any more
Andrew Tridgell [Fri, 23 Oct 1998 01:29:38 +0000 (01:29 +0000)]
don't use SMBW_PWD_ENV any more
(This used to be commit 252fe1e7014b2bf79a3abfa52fb77db9129074c7)

23 years agofixed problems with PWD - we no longer use the PWD env variable
Andrew Tridgell [Fri, 23 Oct 1998 01:27:23 +0000 (01:27 +0000)]
fixed problems with PWD - we no longer use the PWD env variable
instead the shared variable area is used.

this fixes problems with /bin/sh under solaris
(This used to be commit 4eb7b5c6a81447755dfa1be27479027333ed6f26)

23 years agomake the shared variable stuff slightly more sophisticated
Andrew Tridgell [Fri, 23 Oct 1998 01:26:46 +0000 (01:26 +0000)]
make the shared variable stuff slightly more sophisticated
(This used to be commit 636182f18346af457f905cd784e68ae5d4f75d0e)

23 years agoinclude/smb.h: Added #defines for lots of things - makes our code a *lot* easier...
Jeremy Allison [Fri, 23 Oct 1998 00:58:28 +0000 (00:58 +0000)]
include/smb.h: Added #defines for lots of things - makes our code a *lot* easier to read.
lib/util.c: Fixed Luke's set_first_token() function - should return void.
smbd/close.c: Move delete_on_close into file_fd_struct structure.
smbd/ipc.c: Changed local_machine back to fstring.
smbd/nttrans.c: Use defines for mapping share modes.
smbd/open.c: Move delete_on_close into file_fd_struct structure, added code for ALLOW_SHARE_DELETE.
smbd/reply.c: Use defines for mapping share modes.
smbd/trans2.c: Move delete_on_close into file_fd_struct structure.
Jeremy.
(This used to be commit 8e1ce307bd6a9056b4a95fe6f52ff42dc6e03a08)

23 years agotorture debug.
Luke Leighton [Thu, 22 Oct 1998 23:05:55 +0000 (23:05 +0000)]
torture debug.
(This used to be commit 97609596647dea39c061bdf972411a86f7294521)

23 years agoenumeration tests (files, sessions, shares, connections).
Luke Leighton [Thu, 22 Oct 1998 22:54:00 +0000 (22:54 +0000)]
enumeration tests (files, sessions, shares, connections).
hey, you can see how many connections succeed while the rpctorture
command is running!
(This used to be commit c1bf8f109932a3387fa7b8b4265a3eda52d3e0a3)

23 years agoOkay, this is really silly but removing one space from one debug statement
Christopher R. Hertel [Thu, 22 Oct 1998 22:51:45 +0000 (22:51 +0000)]
Okay, this is really silly but removing one space from one debug statement
meant that one hex dump would fit within 80 characters in lynx after HTML
conversion.
(This used to be commit c391f076f29cff917fd51d58598e1ad11048e824)

23 years agorpctorture command
Luke Leighton [Thu, 22 Oct 1998 22:19:08 +0000 (22:19 +0000)]
rpctorture command
(This used to be commit b4ae65e2d0582274d67d02ea190f6d3d83b48594)

23 years agoRemoved previously #ifdef 0 'ed code.
Jeremy Allison [Thu, 22 Oct 1998 19:15:24 +0000 (19:15 +0000)]
Removed previously #ifdef 0 'ed code.
Jeremy.
(This used to be commit 7feaa13d02f84760d6857115ed253570f41911bb)

23 years agoTidied up Support.txt to be up to date with latest consultant
Jeremy Allison [Thu, 22 Oct 1998 19:09:50 +0000 (19:09 +0000)]
Tidied up Support.txt to be up to date with latest consultant
change requests. Start of the big docs update .....

Jeremy.
(This used to be commit 246cd46c4ed0c6918d6179411476b61eba48eede)

23 years agoserver/srv_samr.c smbd/ipc.c: Changed global_myworkgroup back to fstring
Jeremy Allison [Thu, 22 Oct 1998 18:51:16 +0000 (18:51 +0000)]
server/srv_samr.c smbd/ipc.c: Changed global_myworkgroup back to fstring
                              (as it is everywhere else).
smbwrapper/smbsh.c: For IRIX n32 binaries, set _RLDN32_LIST not _RLD32_LIST.
                    Exec users preferred shell is SHELL environment variable is set.
tests/fcntl_lock.c: Added sys/types.h for systems that need this.
Jeremy.
(This used to be commit 50413d0d819d4f13e760ca8439c5bdde0898d63e)

23 years agobug fix in lsa_trans_names.
Luke Leighton [Thu, 22 Oct 1998 18:15:23 +0000 (18:15 +0000)]
bug fix in lsa_trans_names.

well-known aliases S-1-5-20 is actually S-1-5-0x20 but sid_to_string does
decimal not hexadecimal oops.
(This used to be commit 4d830e243650729344a2d1b238075e787802ff8b)

23 years agoMinor change.
Christopher R. Hertel [Thu, 22 Oct 1998 18:07:39 +0000 (18:07 +0000)]
Minor change.

The debug_browse_data() function does a hex dump of a browser packet.  The
last line is often not a full 16 bytes, which would miss-align the hex
output.  I've added the padding needed to align the hex output.

Chris -)-----
(This used to be commit 9f9b30abab118f0a2e007beddd79de38a2d5ea29)

23 years agoextern fstring global_myworkgroup should be a pstring
Luke Leighton [Thu, 22 Oct 1998 17:26:44 +0000 (17:26 +0000)]
extern fstring global_myworkgroup should be a pstring
(This used to be commit 89f6e05ce4cc21fd2e3c0e416e49383f7b56d1ea)

23 years agolibsmb/smbdes.c: #ifdef'ed out code prior to removal.
Jeremy Allison [Thu, 22 Oct 1998 16:55:03 +0000 (16:55 +0000)]
libsmb/smbdes.c: #ifdef'ed out code prior to removal.
rpc_client/cli_pipe.c: Inlined code removed from smbdes.c
rpc_server/srv_samr.c: Fixed unused variable warning.
rpc_server/srv_util.c: Inlined code removed from smbdes.c

Luke - the above changes are the first part of the changes
you and I discussed as being neccessary at the CIFS conference.
*PLEASE REVIEW THESE CHANGES* - make sure I haven't broken
any of the authenticated DCE/RPC code.

smbd/nttrans.c: Fixed to allow NT5.0beta2 to use Samba shares
                with NT SMB support.
smbd/open.c: Fixed mkdir when called from nttrans calls.
smbd/server.c: Set correct size for strcpy of global_myworkgroup.

Jeremy.
(This used to be commit d891421d16ff80998dee429227bd391455f9d1a1)

23 years agoAnother cosmetic change.
Christopher R. Hertel [Thu, 22 Oct 1998 00:30:41 +0000 (00:30 +0000)]
Another cosmetic change.

When dumping the wins.dat, this module will also write the database
contents to the log file (don't do this if you have a large wins.dat!).
The output was in a sort of tabular format, except that the asctime()
function was used and it always terminates its output with a newline.

I did a bit of fussing, removed the '\n' character, and did my best to
line up the other columns.  If the output format of asctime() is
different on different systems, then the columns won't line up, but
the output will still look better than it did before.

Chris -)-----
(This used to be commit 57295113feefcde77b429c661878444cd078b21f)

23 years agodomain aliases added a bit better: does local aliases if you query
Luke Leighton [Wed, 21 Oct 1998 22:36:26 +0000 (22:36 +0000)]
domain aliases added a bit better: does local aliases if you query
for sid S-1-5-20 and does (nothing at the moment) if you query for
your own sid.
(This used to be commit da40f26f4b2f7ce286076b4e39dffd76aa2ef8e6)

23 years agothe next dialog: user-groups. it's not very sensible what appears, but hey:
Luke Leighton [Wed, 21 Oct 1998 21:11:16 +0000 (21:11 +0000)]
the next dialog: user-groups.  it's not very sensible what appears, but hey:
it appears!
(This used to be commit 399035098f212e976cc0000a215e0705ebe78c05)

23 years agoI received a bug report from Massimo Campostrini in Pisa. There are a pair
Christopher R. Hertel [Wed, 21 Oct 1998 19:00:44 +0000 (19:00 +0000)]
I received a bug report from Massimo Campostrini in Pisa.  There are a pair
of "front-end" functions with the same bug each.

Fixed.
(This used to be commit 487a2e13b7913e512fa01e736daaccc3858eb689)

23 years agoadded "start index" skipping into querydispinfo.
Luke Leighton [Wed, 21 Oct 1998 18:06:46 +0000 (18:06 +0000)]
added "start index" skipping into querydispinfo.
(This used to be commit 3e6519da22628ea41025711718ec23b082ef02d0)

23 years agoChanged the debug calls to use the newer debug macros. This allowed me to
Christopher R. Hertel [Wed, 21 Oct 1998 17:26:54 +0000 (17:26 +0000)]
Changed the debug calls to use the newer debug macros.  This allowed me to
break up some very long lines in both the code and the output.  The change
is mostly cosmetic, but should improve log file readability.
(This used to be commit fc4e0148ebf8ea45e4410224218c0c987965d36c)

23 years agoFixed mainly signed/unsigned issues found by SGI cc in -fullwarn mode.
Jeremy Allison [Wed, 21 Oct 1998 16:58:34 +0000 (16:58 +0000)]
Fixed mainly signed/unsigned issues found by SGI cc in -fullwarn mode.
smbd/chgpasswd.c: Fixed (my) stupid bug where I was returning stack based variables. Doh !
smbd/trans2.c: Allows SETFILEINFO as well as QFILEINFO on directory handles.
Jeremy.
(This used to be commit 0b44d27d0b5cc3948a6c2d78370ccddf1a84cd80)

23 years agooops!
Luke Leighton [Wed, 21 Oct 1998 16:54:23 +0000 (16:54 +0000)]
oops!
(This used to be commit 500e5536bee8ea8e58d5991bfab2cff923068926)

23 years agosigned / unsigned issues
Luke Leighton [Wed, 21 Oct 1998 16:28:44 +0000 (16:28 +0000)]
signed / unsigned issues
(This used to be commit bd2fc6bb85739cb8e7ed2254e2a553486daed054)

23 years agofixing smbd encrypted rpcs (data lens, alloc hints, sequence nums argh).
Luke Leighton [Wed, 21 Oct 1998 01:35:01 +0000 (01:35 +0000)]
fixing smbd encrypted rpcs (data lens, alloc hints, sequence nums argh).

put unicode strings after SAMLOGON query regardless of whether it's
an NT mailslot or a non-NT mailslot, after having observed this behaviour
out of NT machines.
(This used to be commit c101113ec20ed0ba633e78e4ee45596cdccaf1b5)

23 years agoat the interop Isaac (at least I _think_ it was Isaac) said that if a
Andrew Tridgell [Wed, 21 Oct 1998 00:31:14 +0000 (00:31 +0000)]
at the interop Isaac (at least I _think_ it was Isaac) said that if a
MS client doesn't respond to a oplock break request then we might try
resending the request.

This morning Sues Win95 machine had this problem (thus forcing me to
do something about it!). When starting winword her box refused to
answer an oplock break request. I have added code to resend the oplock
break request up to 3 times at 10 second intervals before killing the
socket.

of course, as soon as I did this her box started to behave again so I
haven't been able to tell if this fix actually works, but it can't be
worse than dropping the socket immediately.
(This used to be commit a1c4d8351b9171416693e6d7a9045bdce9217edb)

23 years agosigned / unsigned warnings (found by herb).
Luke Leighton [Tue, 20 Oct 1998 22:37:44 +0000 (22:37 +0000)]
signed / unsigned warnings (found by herb).
how do i switch on these warnings in gcc?????
(This used to be commit 39db385a0c47c11adb6bf3bac89c4bb76f675049)

23 years agodce/rpc. bug-fix in ipc.c (introduced today :)
Luke Leighton [Tue, 20 Oct 1998 22:25:52 +0000 (22:25 +0000)]
dce/rpc.  bug-fix in ipc.c (introduced today :)
(This used to be commit 48ff3e2429964404c8bf33ef625791147913a3c0)

23 years agoFixed bug found by John Blair where trim_string wasn't
Jeremy Allison [Tue, 20 Oct 1998 20:08:35 +0000 (20:08 +0000)]
Fixed bug found by John Blair where trim_string wasn't
correctly trimming trailing multibyte code page strings.
Jeremy.
(This used to be commit dbdbce29f56d03f6abf1ee3d96ca2032e688dcbc)

23 years agosome quite important bug-fixes i missed because i transferred the wrong
Luke Leighton [Tue, 20 Oct 1998 18:27:49 +0000 (18:27 +0000)]
some quite important bug-fixes i missed because i transferred the wrong
smb.tgz file from my portable.

particularly the call to mem_data followed by a realloc of that data in
cli_pipe.c's rpc_read() function.

smbd responses now use p->rdata_i which is a faked-up pointer into
p->rdata's response data.  rdata can be very long; rdata_i is limited
to point to no more than max_tsize - 0x18 in length.  this will make
it an almost trivial task to add the encrypted rpc headers after
rdata_i, and mem_buf_copy will cope admirably with rhdr chained to
rdata_i chained to auth_verifier etc etc...
(This used to be commit 05a297e3a98c14360782af4ad0d851638fb5da9a)

23 years agocalls to prs_grow() on array structures so that data construction doesn't
Luke Leighton [Tue, 20 Oct 1998 16:24:57 +0000 (16:24 +0000)]
calls to prs_grow() on array structures so that data construction doesn't
over-run buffers
(This used to be commit 06cc6eaa50fa4b673d527e91740f9d2d2b16d367)

23 years agooops, I ot the return type of putenv() wrong
Andrew Tridgell [Tue, 20 Oct 1998 06:52:39 +0000 (06:52 +0000)]
oops, I ot the return type of putenv() wrong
(This used to be commit 5b7b24d3f9a74b241f7e767de4a2bae601adf88a)

23 years agouse putenv() more portably
Andrew Tridgell [Tue, 20 Oct 1998 06:51:21 +0000 (06:51 +0000)]
use putenv() more portably
(This used to be commit dc08f1a5c92e86c41dc03f6a4d10d5779f3d9c34)

23 years agofixed a connection bug in torture test
Andrew Tridgell [Tue, 20 Oct 1998 06:46:25 +0000 (06:46 +0000)]
fixed a connection bug in torture test
(This used to be commit 2b892130dfc1938e93e69e490a8a9e9ed57a1971)

23 years agoremoved setenv(), replaced with smbw_setenv()
Andrew Tridgell [Tue, 20 Oct 1998 06:45:18 +0000 (06:45 +0000)]
removed setenv(), replaced with smbw_setenv()
(This used to be commit 72bce217ef474f056d8f6675667ec78d1772ff37)

23 years agonew prorotypes
Andrew Tridgell [Tue, 20 Oct 1998 06:43:59 +0000 (06:43 +0000)]
new prorotypes
(This used to be commit facd8d74e0cd0998ca5347ac5be14a6027460699)

23 years agofixes for solaris
Andrew Tridgell [Tue, 20 Oct 1998 06:43:36 +0000 (06:43 +0000)]
fixes for solaris
(This used to be commit 235a8463b56107d97ee5523eed41967e8ccf27b6)

23 years agosmbd/nttrans.c smbd/trans2.c: First fixes for NT5.0beta2. That redirector
Jeremy Allison [Tue, 20 Oct 1998 03:17:43 +0000 (03:17 +0000)]
smbd/nttrans.c smbd/trans2.c: First fixes for NT5.0beta2. That redirector
                              has some *horrible* bugs !
smbwrapper/shared.c smbwrapper/smbsh.c smbwrapper/smbw.c: Fixed gcc warnings.
Jeremy.
(This used to be commit 76448d1d82a78520953c662afee0886122ce134b)

23 years agoadd -Bshareable for *bsd*
Andrew Tridgell [Tue, 20 Oct 1998 03:10:58 +0000 (03:10 +0000)]
add -Bshareable for *bsd*
(This used to be commit c511a619750152db03897ea682713bbc98f71c6b)

23 years agoremoved my badly-done attempt at handling compilers that don't handle
Andrew Tridgell [Tue, 20 Oct 1998 03:10:29 +0000 (03:10 +0000)]
removed my badly-done attempt at handling compilers that don't handle
-c and -o at the same time.

my shell script code wasn't portable
(This used to be commit 759c72822b9b1e8c50b378378f3a45f1e7604ade)

23 years agooops
Luke Leighton [Mon, 19 Oct 1998 20:10:33 +0000 (20:10 +0000)]
oops
(This used to be commit 7f8dfedfc0933713ab7d6de0763f8776e5805e27)

23 years agooutput password change messages instead of debug message.
Luke Leighton [Mon, 19 Oct 1998 17:50:19 +0000 (17:50 +0000)]
output password change messages instead of debug message.
(This used to be commit b9e728a97be323e9221889a63ffa02cff5c99403)

23 years ago- dce/rpc code
Luke Leighton [Mon, 19 Oct 1998 17:32:10 +0000 (17:32 +0000)]
- dce/rpc code

- removed debug info in struni2 and unistr2 (security risk)

- rpc_pipe function was getting pointer to data then calling realloc *dur*

- password check function, the start of "credential checking",
  user, wks, domain, pass as the credentials (not just user,pass which
  is incorrect in a domain context)

- cli_write needs to return ssize_t not size_t, because total can be -1
  if the write fails.

- fixed signed / unsigned warnings (how come i don't get those any more
  when i compile with gcc???)

- nt password change added in smbd.  yes, jeremy, i verified that the
  SMBtrans2 version still works.
(This used to be commit fcfb40d2b0fc565ee4f66b3a3761c246366a2ef3)

23 years agoadded command line options to smbsh
Andrew Tridgell [Mon, 19 Oct 1998 02:49:48 +0000 (02:49 +0000)]
added command line options to smbsh
(This used to be commit 9b249c075e53e6cf75399d60a6371648c03104fa)

23 years agoimproved session reestablishment
Andrew Tridgell [Mon, 19 Oct 1998 02:48:57 +0000 (02:48 +0000)]
improved session reestablishment
(This used to be commit 5f96328d32e76785474ffd5cd73f8ddefc46d4f5)

23 years agoprototype new functions
Andrew Tridgell [Mon, 19 Oct 1998 01:05:49 +0000 (01:05 +0000)]
prototype new functions
(This used to be commit ae6e3d8f3820ee09988948ec0c1fa2214acd9b62)

23 years agoreturn the resolved IP on a cli_connect() call so it can be cached
Andrew Tridgell [Mon, 19 Oct 1998 01:05:11 +0000 (01:05 +0000)]
return the resolved IP on a cli_connect() call so it can be cached
(This used to be commit 4e3f8ef41b8de25dec4c01d5532dca1b567be55a)

23 years agoremoved an incorrect comment
Andrew Tridgell [Mon, 19 Oct 1998 01:03:52 +0000 (01:03 +0000)]
removed an incorrect comment
(This used to be commit 5abdb70e2a5cda2df444dfe5a9cdcb751be75ca8)

23 years ago- don't use env variables for passwords and usernames (yeah!)
Andrew Tridgell [Mon, 19 Oct 1998 01:03:00 +0000 (01:03 +0000)]
- don't use env variables for passwords and usernames (yeah!)
- added a shared variable area based on a unlinked open file, and
  implement a general get/set interface to it
- cache hostname lookups and master ip lookups in shared variable area
(This used to be commit 279cbe69efd75450113d2da0da5e67b29f3702b1)

23 years ago- added smbrapper/shared.o
Andrew Tridgell [Mon, 19 Oct 1998 01:00:33 +0000 (01:00 +0000)]
- added smbrapper/shared.o
- added suport for C compilers that don't handle -c and -o at once
(This used to be commit f1672d055716f4b701e22801cbf5cf5573081685)

23 years agoFixed sys_lseek and seek_file calls so all returns
Jeremy Allison [Sun, 18 Oct 1998 22:06:35 +0000 (22:06 +0000)]
Fixed sys_lseek and seek_file calls so all returns
are *checked* :-).
Jeremy.
(This used to be commit b8b781191dd7d28944d87eec5fa0fbef798e289b)

23 years agoredid proto.h
Andrew Tridgell [Sun, 18 Oct 1998 19:45:05 +0000 (19:45 +0000)]
redid proto.h
(This used to be commit 20880966aafb2dbcdfbf979505a2d64a269dd9a8)

23 years agocheck for lp_nt_pipe_support() in open calls
Andrew Tridgell [Sun, 18 Oct 1998 19:30:26 +0000 (19:30 +0000)]
check for lp_nt_pipe_support() in open calls
(This used to be commit 44d901b3e040a520c4ad9089e68c566c78acacca)

23 years agoadd an option to enable/disable nt pipes
Andrew Tridgell [Sun, 18 Oct 1998 19:29:19 +0000 (19:29 +0000)]
add an option to enable/disable nt pipes
(This used to be commit c161b2f850f124ac5f24968e7865a7d0eb68e23e)

23 years agoSmall tidyups for gcc in 'preen' mode....
Jeremy Allison [Sat, 17 Oct 1998 17:41:13 +0000 (17:41 +0000)]
Small tidyups for gcc in 'preen' mode....
Jeremy.
(This used to be commit 60dc1a4a00a22088d33369588b0d5eb292cf084a)

23 years agoAdded man page for nmblookup(1)
Eloy Paris [Sat, 17 Oct 1998 03:01:07 +0000 (03:01 +0000)]
Added man page for nmblookup(1)
(This used to be commit 69c7b8e2af225f3711d601a136ad3dbc9aaa476e)

23 years agooops.
Luke Leighton [Fri, 16 Oct 1998 23:42:09 +0000 (23:42 +0000)]
oops.
(This used to be commit fc1b7b9e75b029ffa93263766fe297d043c6d1df)

23 years agodce/rpc
Luke Leighton [Fri, 16 Oct 1998 23:40:59 +0000 (23:40 +0000)]
dce/rpc
(This used to be commit 29434f496c18e816d864060d68f357aea6ef5de8)