samba.git
8 years agos3-groupdb: move groupdb headers to groupdb/proto.h.
Günther Deschner [Fri, 18 Mar 2011 15:05:26 +0000 (16:05 +0100)]
s3-groupdb: move groupdb headers to groupdb/proto.h.

Guenther

8 years agos3: create_builtin_users/administrators belongs to passdb not auth.
Günther Deschner [Thu, 24 Mar 2011 12:16:20 +0000 (13:16 +0100)]
s3: create_builtin_users/administrators belongs to passdb not auth.

Guenther

8 years agos3-build: only include transfer_file.h where needed.
Günther Deschner [Fri, 25 Feb 2011 23:56:46 +0000 (00:56 +0100)]
s3-build: only include transfer_file.h where needed.

Guenther

8 years agoregistry: create and use shared libcli/registry/util_reg.h header.
Günther Deschner [Fri, 25 Feb 2011 23:28:15 +0000 (00:28 +0100)]
registry: create and use shared libcli/registry/util_reg.h header.

Guenther

8 years agos3-includes: no point in including all security headers globally.
Günther Deschner [Fri, 25 Feb 2011 22:34:23 +0000 (23:34 +0100)]
s3-includes: no point in including all security headers globally.

Guenther

8 years agos3-includes: remove EILSEQ check, this is handled by
Günther Deschner [Fri, 25 Feb 2011 22:36:14 +0000 (23:36 +0100)]
s3-includes: remove EILSEQ check, this is handled by
../lib/replace/system/iconv.h already.

Guenther

8 years agos3-includes: only include system/filesys.h when needed.
Günther Deschner [Fri, 25 Feb 2011 22:20:06 +0000 (23:20 +0100)]
s3-includes: only include system/filesys.h when needed.

Guenther

8 years agos3-includes: remove global include of "system/network.h"
Günther Deschner [Fri, 25 Feb 2011 22:05:22 +0000 (23:05 +0100)]
s3-includes: remove global include of "system/network.h"

Guenther

8 years agos3-includes: only include system/passwd.h when needed.
Günther Deschner [Fri, 25 Feb 2011 16:14:22 +0000 (17:14 +0100)]
s3-includes: only include system/passwd.h when needed.

Guenther

8 years agos3-includes: only include system/shmem.h when needed.
Günther Deschner [Fri, 25 Feb 2011 16:03:27 +0000 (17:03 +0100)]
s3-includes: only include system/shmem.h when needed.

Guenther

8 years agos3-includes: remove global include of "system/select.h".
Günther Deschner [Fri, 25 Feb 2011 15:52:51 +0000 (16:52 +0100)]
s3-includes: remove global include of "system/select.h".

Guenther

8 years agos3-includes: only include system/terminal.h when needed.
Günther Deschner [Fri, 25 Feb 2011 15:48:10 +0000 (16:48 +0100)]
s3-includes: only include system/terminal.h when needed.

Guenther

8 years agos3-includes: only include system/capability.h when needed.
Günther Deschner [Fri, 25 Feb 2011 15:39:14 +0000 (16:39 +0100)]
s3-includes: only include system/capability.h when needed.

Guenther

8 years agos3-includes: only include system/glob.h when needed.
Günther Deschner [Fri, 25 Feb 2011 15:34:46 +0000 (16:34 +0100)]
s3-includes: only include system/glob.h when needed.

Guenther

8 years agos3-includes: only include system/iconv.h when needed.
Günther Deschner [Fri, 25 Feb 2011 15:29:14 +0000 (16:29 +0100)]
s3-includes: only include system/iconv.h when needed.

Guenther

8 years agos3-includes: only include system/syslog.h when needed.
Günther Deschner [Fri, 25 Feb 2011 15:19:10 +0000 (16:19 +0100)]
s3-includes: only include system/syslog.h when needed.

Guenther

8 years agos3-trans2: only include trans2.h where needed.
Günther Deschner [Thu, 24 Feb 2011 23:03:01 +0000 (00:03 +0100)]
s3-trans2: only include trans2.h where needed.

Guenther

8 years agos3-winbind: remove global inclusion of libwbclient.
Günther Deschner [Thu, 24 Feb 2011 21:30:16 +0000 (22:30 +0100)]
s3-winbind: remove global inclusion of libwbclient.

Guenther

8 years agolib/util/util_pw: share more code between lib/util/util_pw.c and source3/lib/username.c
Günther Deschner [Wed, 2 Mar 2011 15:11:00 +0000 (16:11 +0100)]
lib/util/util_pw: share more code between lib/util/util_pw.c and source3/lib/username.c

Guenther

8 years agolib/util/util_pw: share sys_get{pw,gr} group of calls.
Günther Deschner [Wed, 2 Mar 2011 15:06:32 +0000 (16:06 +0100)]
lib/util/util_pw: share sys_get{pw,gr} group of calls.

Guenther

8 years agolib/util/util_pw: temporary rename of getpwnam_alloc and getpwuid_alloc.
Günther Deschner [Wed, 2 Mar 2011 15:31:01 +0000 (16:31 +0100)]
lib/util/util_pw: temporary rename of getpwnam_alloc and getpwuid_alloc.

Guenther

8 years agoEnsure convert_string_XXX is always called with a valid converted_size pointer.
Jeremy Allison [Tue, 29 Mar 2011 18:16:26 +0000 (11:16 -0700)]
Ensure convert_string_XXX is always called with a valid converted_size pointer.

Preparation for cleaning up this API.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 29 21:01:49 CEST 2011 on sn-devel-104

8 years agocharconv: Fix the slow-path character conversions
Volker Lendecke [Tue, 29 Mar 2011 16:22:18 +0000 (18:22 +0200)]
charconv: Fix the slow-path character conversions

This reverts a part of 0189087e257f. That one might have fixed the fast path,
but it broke the slow path. convert_string_internal returns 0/-1 despite the
size_t result type and the misleading comment. If you follow the path to
smb_iconv and for example iconv_copy(), you will see that this routine returns
0 even after it copied something.

How to check: Use German locale, and do an smbclient "allinfo" on a file
modified in march (März in German). Notice the "ä". Before 0189087 this printed
correctly, after 0189087 it cut off the fields after the M for März.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Mar 29 19:17:41 CEST 2011 on sn-devel-104

8 years agos3-libsmb: remove duplicate NTSTATUS variable.
Günther Deschner [Tue, 29 Mar 2011 10:50:38 +0000 (12:50 +0200)]
s3-libsmb: remove duplicate NTSTATUS variable.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Mar 29 17:00:26 CEST 2011 on sn-devel-104

8 years agos3-waf: fix spoolssd compile.
Günther Deschner [Mon, 28 Mar 2011 14:42:21 +0000 (16:42 +0200)]
s3-waf: fix spoolssd compile.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-rpc_server: Fixed rpc_pipe_open_internal documentation.
Andreas Schneider [Tue, 29 Mar 2011 10:51:45 +0000 (12:51 +0200)]
s3-rpc_server: Fixed rpc_pipe_open_internal documentation.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-rpc_server: Only allow embedded, daemon and external server type.
Andreas Schneider [Tue, 29 Mar 2011 08:58:05 +0000 (10:58 +0200)]
s3-rpc_server: Only allow embedded, daemon and external server type.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-spoolssd: Start the spoolss service correctly.
Andreas Schneider [Tue, 29 Mar 2011 08:52:32 +0000 (10:52 +0200)]
s3-spoolssd: Start the spoolss service correctly.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-spoolssd: Register spoolssd endpoints.
Andreas Schneider [Mon, 28 Mar 2011 12:18:23 +0000 (14:18 +0200)]
s3-spoolssd: Register spoolssd endpoints.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-epmap: Make rpc_ep_setup_register an internal function.
Andreas Schneider [Mon, 28 Mar 2011 12:18:00 +0000 (14:18 +0200)]
s3-epmap: Make rpc_ep_setup_register an internal function.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-spoolssd: Fixed logfile creation.
Andreas Schneider [Mon, 28 Mar 2011 12:30:29 +0000 (14:30 +0200)]
s3-spoolssd: Fixed logfile creation.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-spoolssd: Added missing include.
Andreas Schneider [Thu, 24 Mar 2011 09:22:57 +0000 (10:22 +0100)]
s3-spoolssd: Added missing include.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-spoolssd: Pass down event and messanging context.
Andreas Schneider [Thu, 20 Jan 2011 17:59:40 +0000 (18:59 +0100)]
s3-spoolssd: Pass down event and messanging context.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3-spoolssd: Fixed reopening of logs.
Andreas Schneider [Wed, 25 Aug 2010 08:15:47 +0000 (10:15 +0200)]
s3-spoolssd: Fixed reopening of logs.

Everytime the log was reopened a .spoolssd has been appended which
resulted in long file names.

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3:spoolssd Start spoolss from smbd
Simo Sorce [Thu, 20 May 2010 12:33:14 +0000 (08:33 -0400)]
s3:spoolssd Start spoolss from smbd

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3:spoolssd Initialize the spoolss rpc interfaces
Simo Sorce [Tue, 15 Jun 2010 22:39:27 +0000 (18:39 -0400)]
s3:spoolssd Initialize the spoolss rpc interfaces

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3:spoolssd Add spoolss own signal handlers
Simo Sorce [Wed, 16 Jun 2010 17:03:32 +0000 (13:03 -0400)]
s3:spoolssd Add spoolss own signal handlers

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3:spoolssd handle smb.conf reloads directly
Simo Sorce [Wed, 16 Jun 2010 19:36:06 +0000 (15:36 -0400)]
s3:spoolssd handle smb.conf reloads directly

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3:spoolssd Create our own log file
Simo Sorce [Tue, 15 Jun 2010 22:38:44 +0000 (18:38 -0400)]
s3:spoolssd Create our own log file

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3:spoolssd Add skeleton for spoolss daemon
Simo Sorce [Thu, 20 May 2010 12:48:18 +0000 (08:48 -0400)]
s3:spoolssd Add skeleton for spoolss daemon

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agos3:printing Make print_queue_receive public
Simo Sorce [Thu, 20 May 2010 12:49:50 +0000 (08:49 -0400)]
s3:printing Make print_queue_receive public

Signed-off-by: Günther Deschner <gd@samba.org>
8 years agoldb: detect eof on ldif files
Andrew Tridgell [Tue, 29 Mar 2011 05:31:17 +0000 (16:31 +1100)]
ldb: detect eof on ldif files

use feof() to detect parsing errors in ldif files

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 29 08:24:04 CEST 2011 on sn-devel-104

8 years agos4-dsdb: allow modification of linked attribute targets with relax
Andrew Tridgell [Tue, 29 Mar 2011 05:14:18 +0000 (16:14 +1100)]
s4-dsdb: allow modification of linked attribute targets with relax

this is used to help recover a corrupt database.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agodebug: ignore debug_set_logfile() with a blank string
Andrew Tridgell [Tue, 29 Mar 2011 03:41:58 +0000 (14:41 +1100)]
debug: ignore debug_set_logfile() with a blank string

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue Mar 29 07:03:58 CEST 2011 on sn-devel-104

8 years agos4-cmdline: moved loadparm init after fault setup
Andrew Tridgell [Tue, 29 Mar 2011 03:30:24 +0000 (14:30 +1100)]
s4-cmdline: moved loadparm init after fault setup

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-param: set a default logfile
Andrew Tridgell [Tue, 29 Mar 2011 03:29:54 +0000 (14:29 +1100)]
s4-param: set a default logfile

setup a logfile for when one is not specified in smb.conf

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agolib: removed a spurios declaration of 'logfile'
Andrew Tridgell [Tue, 29 Mar 2011 03:29:22 +0000 (14:29 +1100)]
lib: removed a spurios declaration of 'logfile'

we don't have a global logfile variable any more

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agoRemove two unused labels.
Jeremy Allison [Mon, 28 Mar 2011 23:07:13 +0000 (16:07 -0700)]
Remove two unused labels.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Mar 29 02:23:02 CEST 2011 on sn-devel-104

8 years ago=?UTF-8?q?alpha=5Fstrcpy()=20is=20a=20utility=20function=20which=20reportedly:
David Disseldorp [Mon, 28 Mar 2011 22:59:32 +0000 (15:59 -0700)]
=?UTF-8?q?alpha=5Fstrcpy()=20is=20a=20utility=20function=20which=20reportedly:

=20Strips=20out=20all=20but=20'a-Z0-9'=20and=20the=20character=20in=20other=5Fsafe=5Fchars=20and
=20replaces=20with=20'=5F'.
=20This=20statement=20does=20not=20currently=20hold=20true=20in=20all=20cases=20(e.g.=20src=20=3D
=20"=D0=A2=D0=90=D0=9D=D0=A6=D0=95=D0=92=D0=90=D0=A2=D0=AC").?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

8 years agos3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2
Michael Adam [Mon, 28 Mar 2011 22:01:40 +0000 (00:01 +0200)]
s3:rpc_client: fix argument order of call to lsa_open_policy2 in rpccli_lsa_open_policy2

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Tue Mar 29 01:34:28 CEST 2011 on sn-devel-104

8 years agos3-selftest Fix test_smbclient_auth.sh
Andrew Bartlett [Mon, 28 Mar 2011 11:06:40 +0000 (22:06 +1100)]
s3-selftest Fix test_smbclient_auth.sh

The -N in the command line meant that all the logins were as the
guest, not as the user specified.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Mar 29 00:47:50 CEST 2011 on sn-devel-104

8 years agos3-selftest Allow LM passwords and turn of NTLMv2 for security=share test
Andrew Bartlett [Mon, 28 Mar 2011 11:20:23 +0000 (22:20 +1100)]
s3-selftest Allow LM passwords and turn of NTLMv2 for security=share test

8 years agos3-selftest Add tests for security=server
Andrew Bartlett [Mon, 28 Mar 2011 09:42:55 +0000 (20:42 +1100)]
s3-selftest Add tests for security=server

Andrew Bartlett

8 years agos3-selftest unconditionaly include subunit.sh
Andrew Bartlett [Mon, 28 Mar 2011 11:05:27 +0000 (22:05 +1100)]
s3-selftest unconditionaly include subunit.sh

we no longer . this file into other shell scripts, so we don't need
this check any more.

Andrew Bartlett

8 years agowintest New snapshot for my wintest VMs
Andrew Bartlett [Mon, 28 Mar 2011 09:44:10 +0000 (20:44 +1100)]
wintest New snapshot for my wintest VMs

8 years agos4-fsmo: say which role is being transferred
Andrew Tridgell [Mon, 28 Mar 2011 05:48:46 +0000 (16:48 +1100)]
s4-fsmo: say which role is being transferred

this is particularly useful for "samba-tool fsmo transfer --role=all"

8 years agos4-fsmo: samba-tool fsmo transfer now gets full error code
Andrew Tridgell [Mon, 28 Mar 2011 05:45:22 +0000 (16:45 +1100)]
s4-fsmo: samba-tool fsmo transfer now gets full error code

We now wait for the transfer to succeed or fail

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-dsdb: perform FSMO transfers asynchronously
Andrew Tridgell [Mon, 28 Mar 2011 05:44:32 +0000 (16:44 +1100)]
s4-dsdb: perform FSMO transfers asynchronously

this gives the administrator a proper error message on the command
line

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-fsmo: make rootDSE modify for FSMO transfer async
Andrew Tridgell [Mon, 28 Mar 2011 05:20:47 +0000 (16:20 +1100)]
s4-fsmo: make rootDSE modify for FSMO transfer async

this gives the ldap client the error code from the transfer

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-fsmo: nicer error messages on failed FSMO transfers
Andrew Tridgell [Mon, 28 Mar 2011 04:32:41 +0000 (15:32 +1100)]
s4-fsmo: nicer error messages on failed FSMO transfers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-drs: default hostname in samba-tool drs command
Andrew Tridgell [Mon, 28 Mar 2011 04:32:15 +0000 (15:32 +1100)]
s4-drs: default hostname in samba-tool drs command

default to our hostname

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-dsdb: only allow administrators to trigger FSMO role transfers
Andrew Tridgell [Mon, 28 Mar 2011 03:41:36 +0000 (14:41 +1100)]
s4-dsdb: only allow administrators to trigger FSMO role transfers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-fsmo: samba-tool fsmo takes a URL, not a hostname
Andrew Tridgell [Mon, 28 Mar 2011 03:17:45 +0000 (14:17 +1100)]
s4-fsmo: samba-tool fsmo takes a URL, not a hostname

better to call the option --url

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowintest: added a "ipconfig /flushdns"
Andrew Tridgell [Mon, 28 Mar 2011 01:50:24 +0000 (12:50 +1100)]
wintest: added a "ipconfig /flushdns"

w2k3 doesn't flush its DNS cache on a dynamic update

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowintest: fixed syntax highlighting with emacs
Andrew Tridgell [Mon, 28 Mar 2011 01:27:33 +0000 (12:27 +1100)]
wintest: fixed syntax highlighting with emacs

8 years agowintest: ensure we startup the w2k3 DC VM
Andrew Tridgell [Mon, 28 Mar 2011 01:27:01 +0000 (12:27 +1100)]
wintest: ensure we startup the w2k3 DC VM

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agoBe a little clearer about when and when not to set this option.
Jeremy Allison [Mon, 28 Mar 2011 21:12:36 +0000 (14:12 -0700)]
Be a little clearer about when and when not to set this option.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Mar 28 23:59:47 CEST 2011 on sn-devel-104

8 years agoFix inspired by work done by David Disseldorp for bug #8040 - smbclient segfaults...
Jeremy Allison [Mon, 28 Mar 2011 20:26:27 +0000 (13:26 -0700)]
Fix inspired by work done by David Disseldorp for bug #8040 - smbclient segfaults when a Cyrillic netbios name or workgroup is configured.

Change msrpc_gen to return NTSTATUS and ensure everywhere this is
used it is correctly checked to return that status.

Jeremy.

8 years agos3: Fix Coverity ID 2143: DEADCODE
Volker Lendecke [Mon, 28 Mar 2011 09:12:32 +0000 (11:12 +0200)]
s3: Fix Coverity ID 2143: DEADCODE

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Mar 28 12:06:19 CEST 2011 on sn-devel-104

8 years agos3: Fix Coverity ID 2143: DEADCODE
Volker Lendecke [Mon, 28 Mar 2011 09:12:32 +0000 (11:12 +0200)]
s3: Fix Coverity ID 2143: DEADCODE

8 years agos3: Fix Coverity ID 2173: FORWARD_NULL
Volker Lendecke [Mon, 28 Mar 2011 08:52:51 +0000 (10:52 +0200)]
s3: Fix Coverity ID 2173: FORWARD_NULL

8 years agoRevert "Change strict allocate to default to true.
Stefan Metzmacher [Mon, 28 Mar 2011 06:11:01 +0000 (08:11 +0200)]
Revert "Change strict allocate to default to true.

This reverts commit ecf48af135e4c1ebc5aafe4b3dad785162f5949a.

This makes Samba unusable on systems without Linux and
a modern Filesystem.

This was discussed with Jeremy on IRC:
http://irclog.samba.org/2011/01/20110126-Wed.log

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Mar 28 09:00:09 CEST 2011 on sn-devel-104

8 years agos3: Fix Coverity ID 2188: MISSING_BREAK
Volker Lendecke [Sun, 27 Mar 2011 20:06:46 +0000 (22:06 +0200)]
s3: Fix Coverity ID 2188: MISSING_BREAK

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 23:11:10 CEST 2011 on sn-devel-104

8 years agos3: Fix Coverity ID 2189: MISSING_BREAK
Volker Lendecke [Sun, 27 Mar 2011 20:06:46 +0000 (22:06 +0200)]
s3: Fix Coverity ID 2189: MISSING_BREAK

8 years agotdb: Fix Coverity ID 2192: NO_EFFECT
Volker Lendecke [Sun, 27 Mar 2011 19:43:53 +0000 (21:43 +0200)]
tdb: Fix Coverity ID 2192: NO_EFFECT

(ret < 0) can never be true

8 years agos3: Fix Coverity ID 2195: NO_EFFECT
Volker Lendecke [Sun, 27 Mar 2011 19:31:44 +0000 (21:31 +0200)]
s3: Fix Coverity ID 2195: NO_EFFECT

level is unsigned

8 years agolibrpc: Add some error checking to dcerpc_floor_pack_rhs_if_version_data
Volker Lendecke [Sun, 27 Mar 2011 19:19:37 +0000 (21:19 +0200)]
librpc: Add some error checking to dcerpc_floor_pack_rhs_if_version_data

8 years agolibrpc: Fix Coverity ID 2198: NULL_RETURNS
Volker Lendecke [Sun, 27 Mar 2011 19:17:53 +0000 (21:17 +0200)]
librpc: Fix Coverity ID 2198: NULL_RETURNS

8 years agos3: Fix Coverity ID 2200: NULL_RETURNS (cut&paste error)
Volker Lendecke [Sun, 27 Mar 2011 18:57:45 +0000 (20:57 +0200)]
s3: Fix Coverity ID 2200: NULL_RETURNS (cut&paste error)

8 years agos3: Fix Coverity ID 2228: RESOURCE_LEAK
Volker Lendecke [Sun, 27 Mar 2011 18:44:01 +0000 (20:44 +0200)]
s3: Fix Coverity ID 2228: RESOURCE_LEAK

Holger, please check!

8 years agos3: Fix Coverity ID 2226: RESOURCE_LEAK
Volker Lendecke [Sun, 27 Mar 2011 18:38:52 +0000 (20:38 +0200)]
s3: Fix Coverity ID 2226: RESOURCE_LEAK

Holger, please check!

8 years agos3: Fix Coverity ID 976: BAD_SIZEOF
Volker Lendecke [Sun, 27 Mar 2011 18:06:19 +0000 (20:06 +0200)]
s3: Fix Coverity ID 976: BAD_SIZEOF

8 years agos3: Fix Coverity ID 958: BAD_SIZEOF
Volker Lendecke [Sun, 27 Mar 2011 18:03:23 +0000 (20:03 +0200)]
s3: Fix Coverity ID 958: BAD_SIZEOF

This is supposed to wipe out the md5 context, not only the first bytes of it.

Others, please check!

8 years agos3: Fix Coverity ID 682: NEGATIVE_RETURNS
Volker Lendecke [Sun, 27 Mar 2011 17:41:34 +0000 (19:41 +0200)]
s3: Fix Coverity ID 682: NEGATIVE_RETURNS

8 years agos3: Fix Coverity ID 590: DEADCODE
Volker Lendecke [Sun, 27 Mar 2011 17:29:42 +0000 (19:29 +0200)]
s3: Fix Coverity ID 590: DEADCODE

8 years agos3: Fix Coverity ID 585: NEGATIVE_RETURNS
Volker Lendecke [Sun, 27 Mar 2011 17:27:26 +0000 (19:27 +0200)]
s3: Fix Coverity ID 585: NEGATIVE_RETURNS

8 years agos3: Fix Coverity ID 513: UNINIT
Volker Lendecke [Sun, 27 Mar 2011 17:11:44 +0000 (19:11 +0200)]
s3: Fix Coverity ID 513: UNINIT

8 years agos3: Fix Coverity ID 83: RESOURCE_LEAK
Volker Lendecke [Sun, 27 Mar 2011 17:08:10 +0000 (19:08 +0200)]
s3: Fix Coverity ID 83: RESOURCE_LEAK

8 years agos3: Convert cli_raw_tcon to cli_smb
Volker Lendecke [Sun, 27 Mar 2011 16:03:24 +0000 (18:03 +0200)]
s3: Convert cli_raw_tcon to cli_smb

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 19:50:21 CEST 2011 on sn-devel-104

8 years agos3: Fix a memleak
Volker Lendecke [Sun, 27 Mar 2011 15:43:11 +0000 (17:43 +0200)]
s3: Fix a memleak

8 years agos3: Replace a use of cli_errstr
Volker Lendecke [Sun, 27 Mar 2011 15:37:24 +0000 (17:37 +0200)]
s3: Replace a use of cli_errstr

8 years agos3: Replace cli_negprot_sendsync() by cli_negprot_send()
Volker Lendecke [Sun, 27 Mar 2011 15:34:36 +0000 (17:34 +0200)]
s3: Replace cli_negprot_sendsync() by cli_negprot_send()

8 years agos3: Remove a pointless static
Volker Lendecke [Sun, 27 Mar 2011 15:20:28 +0000 (17:20 +0200)]
s3: Remove a pointless static

8 years agos3: Remove a use of cli_send_smb
Volker Lendecke [Sun, 27 Mar 2011 15:04:56 +0000 (17:04 +0200)]
s3: Remove a use of cli_send_smb

8 years agos3: Remove two calls to cli_errstr
Volker Lendecke [Sun, 27 Mar 2011 09:50:55 +0000 (11:50 +0200)]
s3: Remove two calls to cli_errstr

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 13:17:47 CEST 2011 on sn-devel-104

8 years agos3: Fix Coverity ID 2296: UNUSED_VALUE
Volker Lendecke [Sun, 27 Mar 2011 09:22:57 +0000 (11:22 +0200)]
s3: Fix Coverity ID 2296: UNUSED_VALUE

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Mar 27 12:12:35 CEST 2011 on sn-devel-104

8 years agos3: Fix Coverity ID 2327: FORWARD_NULL
Volker Lendecke [Sun, 27 Mar 2011 09:11:07 +0000 (11:11 +0200)]
s3: Fix Coverity ID 2327: FORWARD_NULL

Make check_ft_info robust against an invalid type.

Günther, please check!

8 years agos3: Fix Coverity ID 2328: FORWARD_NULL
Volker Lendecke [Sun, 27 Mar 2011 09:06:02 +0000 (11:06 +0200)]
s3: Fix Coverity ID 2328: FORWARD_NULL

Make startsmbfilepwent robust against an invalid open type

8 years agos3: Fix Coverity ID 2329: RESOURCE_LEAK
Volker Lendecke [Sun, 27 Mar 2011 09:00:36 +0000 (11:00 +0200)]
s3: Fix Coverity ID 2329: RESOURCE_LEAK

8 years agos3: Fix Coverity ID 2330: RESOURCE_LEAK
Volker Lendecke [Sun, 27 Mar 2011 08:59:57 +0000 (10:59 +0200)]
s3: Fix Coverity ID 2330: RESOURCE_LEAK