samba.git
20 months agolib/crypto: Update REQUIREMENTS for recent Samba changes
Andrew Bartlett [Wed, 7 Feb 2018 21:49:33 +0000 (10:49 +1300)]
lib/crypto: Update REQUIREMENTS for recent Samba changes

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
20 months agoWHATSNEW: Start release notes for Samba 4.9.
Karolin Seeger [Wed, 7 Feb 2018 09:08:53 +0000 (10:08 +0100)]
WHATSNEW: Start release notes for Samba 4.9.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Feb  7 17:57:39 CET 2018 on sn-devel-144

20 months agodocs-xml: Add 'samba-tool visualize' to man samba-tool.8.
Karolin Seeger [Mon, 5 Feb 2018 08:37:48 +0000 (09:37 +0100)]
docs-xml: Add 'samba-tool visualize' to man samba-tool.8.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13226

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
20 months agoselftest: run "samba.tests.common"
Stefan Metzmacher [Tue, 30 Jan 2018 09:40:36 +0000 (10:40 +0100)]
selftest: run "samba.tests.common"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agolibgpo: Fix the build --without-ads
Volker Lendecke [Sat, 3 Feb 2018 06:07:55 +0000 (07:07 +0100)]
libgpo: Fix the build --without-ads

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Feb  6 15:36:01 CET 2018 on sn-devel-144

20 months agolibads: Fix the build --without-ads
Volker Lendecke [Sat, 3 Feb 2018 06:07:24 +0000 (07:07 +0100)]
libads: Fix the build --without-ads

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Feb  6 02:47:44 CET 2018 on sn-devel-144

20 months agodbcheck: skip find_missing_forward_links_from_backlinks() if the db has the sortedLin...
Stefan Metzmacher [Wed, 31 Jan 2018 08:50:47 +0000 (09:50 +0100)]
dbcheck: skip find_missing_forward_links_from_backlinks() if the db has the sortedLinks feature

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Feb  5 18:32:51 CET 2018 on sn-devel-144

20 months agodbcheck: add support for restoring missing forward links
Ralph Boehme [Thu, 25 Jan 2018 13:48:55 +0000 (14:48 +0100)]
dbcheck: add support for restoring missing forward links

This recovers broken databases with duplicate and missing
forward links.

See commit a25c99c9f1fd1814c56c21848c748cd0e038eed7 for
the fix that prevents to problem from happening.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: add find_missing_forward_links_from_backlinks()
Ralph Boehme [Thu, 25 Jan 2018 13:48:55 +0000 (14:48 +0100)]
dbcheck: add find_missing_forward_links_from_backlinks()

find_missing_forward_links_from_backlinks() finds and returns missing forward-links by
searching all for all objects that link to the object in the backlink attribute.

This will be used in the next commit to restore forward links in a corrupted
forward link attribute by passing the missing backling objects to
err_recover_forward_links().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: make sure we ask for replPropertyMetaData if we need to process any forward...
Stefan Metzmacher [Tue, 30 Jan 2018 11:19:31 +0000 (12:19 +0100)]
dbcheck: make sure we ask for replPropertyMetaData if we need to process any forward link attributes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agodbcheck: make sure we always ask for the objectGUID attribute explicitly
Stefan Metzmacher [Tue, 30 Jan 2018 11:19:31 +0000 (12:19 +0100)]
dbcheck: make sure we always ask for the objectGUID attribute explicitly

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agodbcheck: add a helper function that checks is a value has duplicate links
Ralph Boehme [Wed, 24 Jan 2018 21:24:15 +0000 (22:24 +0100)]
dbcheck: add a helper function that checks is a value has duplicate links

Will be used in a subsequent commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: add a dict where we remember attributes with duplicate links
Ralph Boehme [Thu, 25 Jan 2018 09:34:29 +0000 (10:34 +0100)]
dbcheck: add a dict where we remember attributes with duplicate links

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: split out check_duplicate_links from check_dn
Ralph Boehme [Wed, 24 Jan 2018 19:01:27 +0000 (20:01 +0100)]
dbcheck: split out check_duplicate_links from check_dn

Refactoring, no change in behaviour.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: store fixed forward link attributes with the correct sorting
Stefan Metzmacher [Tue, 30 Jan 2018 08:55:21 +0000 (09:55 +0100)]
dbcheck: store fixed forward link attributes with the correct sorting

The corruption we're trying to fix messed up the sorting,
so there's no point in keeping the current order.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agodbcheck: remove ldb.FLAG_MOD_REPLACE when replacing search results for forward links
Stefan Metzmacher [Tue, 30 Jan 2018 08:39:40 +0000 (09:39 +0100)]
dbcheck: remove ldb.FLAG_MOD_REPLACE when replacing search results for forward links

Search results don't have an ldb.FLAG_MOD_* flags set.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agodbcheck: rename err_duplicate_links() to err_recover_forward_links() and adjust the...
Ralph Boehme [Thu, 25 Jan 2018 13:36:52 +0000 (14:36 +0100)]
dbcheck: rename err_duplicate_links() to err_recover_forward_links() and adjust the output message

It's really a fatal error to have duplicate values as it's very likely that
some forward links got lost.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: add link direction to error message for duplicate links
Ralph Boehme [Thu, 25 Jan 2018 13:41:58 +0000 (14:41 +0100)]
dbcheck: add link direction to error message for duplicate links

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: rename err_duplicate_links arguments
Ralph Boehme [Wed, 24 Jan 2018 18:37:55 +0000 (19:37 +0100)]
dbcheck: rename err_duplicate_links arguments

In preperation of adding more arguments.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: only pass obj_dn to err_orphaned_backlink()
Stefan Metzmacher [Mon, 29 Jan 2018 21:48:42 +0000 (22:48 +0100)]
dbcheck: only pass obj_dn to err_orphaned_backlink()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agodbcheck: add forward_syntax argument to err_orphaned_backlink
Ralph Boehme [Thu, 25 Jan 2018 09:52:35 +0000 (10:52 +0100)]
dbcheck: add forward_syntax argument to err_orphaned_backlink

Will be used in a subsequent commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agodbcheck: rename and reorder err_orphaned_backlink arguments
Ralph Boehme [Wed, 24 Jan 2018 18:31:23 +0000 (19:31 +0100)]
dbcheck: rename and reorder err_orphaned_backlink arguments

In preperation of adding more arguments.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agoselftest/dbcheck: add a test for corrupt forward links restoration
Ralph Boehme [Thu, 25 Jan 2018 20:34:47 +0000 (21:34 +0100)]
selftest/dbcheck: add a test for corrupt forward links restoration

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
20 months agoRevert "dbcheck: disable fixing duplicate linked attributes until we can recover...
Ralph Boehme [Wed, 24 Jan 2018 10:34:43 +0000 (11:34 +0100)]
Revert "dbcheck: disable fixing duplicate linked attributes until we can recover lost forward links"

This reverts commit 43e3f79d54c5aeaea820865d298d4249cf47af99.

The real fix will follow in the next commits.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
20 months agopython/common: add __cmp__ function to dsdb_Dn similar to parsed_dn_compare()
Stefan Metzmacher [Tue, 30 Jan 2018 08:51:20 +0000 (09:51 +0100)]
python/common: add __cmp__ function to dsdb_Dn similar to parsed_dn_compare()

Linked attribute values are sorted by objectGUID of the link target.
For C code we have parsed_dn_compare() to implement the logic,
the same is now available on python dsdb_Dn objects.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agopython:tests: add test_dsdb_Dn_sorted() to "samba.tests.common"
Stefan Metzmacher [Tue, 30 Jan 2018 10:09:55 +0000 (11:09 +0100)]
python:tests: add test_dsdb_Dn_sorted() to "samba.tests.common"

Failing until dsdb_Dn implements the correct __cmp__() function.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agopython:tests: remove test_dsdb_Dn() to test_dsdb_Dn_binary()
Stefan Metzmacher [Tue, 30 Jan 2018 10:09:40 +0000 (11:09 +0100)]
python:tests: remove test_dsdb_Dn() to test_dsdb_Dn_binary()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agopython:tests: use TestCaseInTempDir for "samba.tests.common"
Stefan Metzmacher [Tue, 30 Jan 2018 09:39:30 +0000 (10:39 +0100)]
python:tests: use TestCaseInTempDir for "samba.tests.common"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agopython/netcmd: implement __repr__ for class CommandError
Stefan Metzmacher [Wed, 24 Jan 2018 18:14:53 +0000 (19:14 +0100)]
python/netcmd: implement __repr__ for class CommandError

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agos3/smbd: fix handling of delete-on-close on directories
Ralph Boehme [Thu, 11 Jan 2018 16:52:06 +0000 (17:52 +0100)]
s3/smbd: fix handling of delete-on-close on directories

This implements a check to test the delete-on-close flag of a directory
for requests to create files in this directory.

Windows server implement this check, Samba doesn't as it has performance
implications.

This commit implements the check and a new option to control it. By
default the check is skipped, setting "check parent directory delete on
close = yes" enables it.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Feb  3 23:42:16 CET 2018 on sn-devel-144

20 months agoselftest: run deltest20 against s3 as well
Ralph Boehme [Fri, 12 Jan 2018 16:32:44 +0000 (17:32 +0100)]
selftest: run deltest20 against s3 as well

This marks the test as knownfail, the next commit fixes it.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agoWHATSNEW: Mention new option "apply group policies"
Andrew Bartlett [Tue, 16 Jan 2018 03:25:38 +0000 (16:25 +1300)]
WHATSNEW: Mention new option "apply group policies"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13223

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Feb  1 07:57:54 CET 2018 on sn-devel-144

20 months agogpo: Correct WHATSNEW
David Mulder [Mon, 15 Jan 2018 15:20:08 +0000 (08:20 -0700)]
gpo: Correct WHATSNEW

The WHATSNEW incorrectly explains how to enable gpo.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13223

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
20 months agogpo: Correct documentation
David Mulder [Mon, 15 Jan 2018 18:37:47 +0000 (11:37 -0700)]
gpo: Correct documentation

The doc still contains a reference to env var
policy (which isn't present in this release).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13223

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
20 months agoWHATSNEW: Add section for "samba-tool visualize"
Andrew Bartlett [Tue, 16 Jan 2018 03:23:39 +0000 (16:23 +1300)]
WHATSNEW: Add section for "samba-tool visualize"

(text from the commit message by Douglas adding the feature)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13226

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
20 months agotalloc_zero libnet_context on init
Swen Schillig [Fri, 26 Jan 2018 08:12:12 +0000 (09:12 +0100)]
talloc_zero libnet_context on init

Zero the libnet_context on initialization
preventing an uninitalized cli_credentials struct.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Feb  1 00:33:34 CET 2018 on sn-devel-144

20 months agovfs_virusfilter: Fix CID 1428738 Macro compares unsigned to 0
Volker Lendecke [Tue, 30 Jan 2018 11:37:30 +0000 (12:37 +0100)]
vfs_virusfilter: Fix CID 1428738 Macro compares unsigned to 0

vsnprintf returns "int" and not "size_t"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 31 05:28:48 CET 2018 on sn-devel-144

20 months agovfs_virusfilter: Fix CID 1428740 Macro compares unsigned to 0
Volker Lendecke [Tue, 30 Jan 2018 11:36:14 +0000 (12:36 +0100)]
vfs_virusfilter: Fix CID 1428740 Macro compares unsigned to 0

vsnprintf returns "int" and not "size_t"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agovfs_virusfilter: Fix CID 1428739 Buffer not null terminated
Volker Lendecke [Tue, 30 Jan 2018 11:34:11 +0000 (12:34 +0100)]
vfs_virusfilter: Fix CID 1428739 Buffer not null terminated

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agos3: librpc: Allow client to correctly report etype unsupported by KDC to caller.
Jeremy Allison [Mon, 29 Jan 2018 20:52:14 +0000 (12:52 -0800)]
s3: librpc: Allow client to correctly report etype unsupported by KDC to caller.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13247

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jan 31 00:38:09 CET 2018 on sn-devel-144

20 months agoctdb-common: Optimize sock_queue's memory managament
Swen Schillig [Mon, 8 Jan 2018 13:55:31 +0000 (14:55 +0100)]
ctdb-common: Optimize sock_queue's memory managament

Make use of talloc pools for the sock_queue's memory requirements.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Jan 30 18:12:32 CET 2018 on sn-devel-144

20 months agoctdb-common: Remove sock_queue_destructor
Swen Schillig [Mon, 8 Jan 2018 13:13:46 +0000 (14:13 +0100)]
ctdb-common: Remove sock_queue_destructor

The sock_queue_destructor is not needed.
The performed tasks will be performed automatically.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
20 months agoctdb-common: Return if packet size is zero
Swen Schillig [Mon, 8 Jan 2018 13:10:40 +0000 (14:10 +0100)]
ctdb-common: Return if packet size is zero

Prevent further processing of sock_queue_process
if the received packet size is zero.

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
20 months agolibcli: Remove finddcs_nbt.c
Volker Lendecke [Mon, 29 Jan 2018 11:20:19 +0000 (12:20 +0100)]
libcli: Remove finddcs_nbt.c

This completes commit 06c90cb6f55701effa4cbafaf189a4de8471949b

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jan 30 13:27:51 CET 2018 on sn-devel-144

20 months agos3: ldap: Ensure the ADS_STRUCT pointer doesn't get freed on error, we don't own...
Jeremy Allison [Wed, 24 Jan 2018 22:09:43 +0000 (14:09 -0800)]
s3: ldap: Ensure the ADS_STRUCT pointer doesn't get freed on error, we don't own it here.

Thanks to Isaac Boukris <iboukris@gmail.com> for finding the
issue and testing this fix.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13244

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Jan 26 02:25:20 CET 2018 on sn-devel-144

20 months agoFix wrong condition for error string assignment
Swen Schillig [Thu, 25 Jan 2018 10:02:15 +0000 (11:02 +0100)]
Fix wrong condition for error string assignment

Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Thu Jan 25 17:19:12 CET 2018 on sn-devel-144

20 months agolibnet: Use talloc_zero instead of ZERO_STRUCTP
Volker Lendecke [Thu, 4 Jan 2018 19:37:16 +0000 (20:37 +0100)]
libnet: Use talloc_zero instead of ZERO_STRUCTP

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
20 months agoSamba-VirusFilter: clean up dir check vfs_close and vfs_open
Trever L. Adams [Wed, 24 Jan 2018 18:21:11 +0000 (11:21 -0700)]
Samba-VirusFilter: clean up dir check vfs_close and vfs_open

Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
20 months agoSamba-VirusFilter: fix virusfilter_vfs_close() crash
Trever L. Adams [Wed, 24 Jan 2018 17:42:11 +0000 (10:42 -0700)]
Samba-VirusFilter: fix virusfilter_vfs_close() crash

Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
20 months agolibnmb: Fix CID 1428474 Incorrect expression (COPY_PASTE_ERROR)
Volker Lendecke [Wed, 24 Jan 2018 11:57:43 +0000 (12:57 +0100)]
libnmb: Fix CID 1428474 Incorrect expression (COPY_PASTE_ERROR)

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jan 25 01:53:53 CET 2018 on sn-devel-144

20 months agoSamba-VirusFilter: clamav VFS and man page.
Trever L. Adams [Tue, 18 Oct 2016 19:40:01 +0000 (13:40 -0600)]
Samba-VirusFilter: clamav VFS and man page.

Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jan 24 15:08:59 CET 2018 on sn-devel-144

20 months agoSamba-VirusFilter: F-Secure AntiVirus (fsav) VFS and man page.
Trever L. Adams [Tue, 18 Oct 2016 19:39:20 +0000 (13:39 -0600)]
Samba-VirusFilter: F-Secure AntiVirus (fsav) VFS and man page.

Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agoSamba-VirusFilter: Sophos VFS backend.
Trever L. Adams [Tue, 18 Oct 2016 19:38:14 +0000 (13:38 -0600)]
Samba-VirusFilter: Sophos VFS backend.

Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agoSamba-VirusFilter: common headers and sources.
Trever L. Adams [Tue, 18 Oct 2016 19:34:53 +0000 (13:34 -0600)]
Samba-VirusFilter: common headers and sources.

Samba-VirusFilter Contributors:

SATOH Fumiyasu @ OSS Technology Corp., Japan
Module creator/maintainer

Luke Dixon luke.dixon@zynstra.com
Samba 4 support

Trever L. Adams
Documentation
Code contributions
Samba-master merge work

With many thanks to the Samba Team.

Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Signed-off-by: SATOH Fumiyasu <fumiyas@osstech.co.jp>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agoSamba-VirusFilter: memcache changes.
Trever L. Adams [Tue, 18 Oct 2016 19:37:19 +0000 (13:37 -0600)]
Samba-VirusFilter: memcache changes.

Signed-off-by: Trever L. Adams <trever.adams@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agoctdb-tests: Fix a typo
Martin Schwenke [Tue, 23 Jan 2018 09:18:54 +0000 (20:18 +1100)]
ctdb-tests: Fix a typo

This typo causes the script to be run with the default shell.  If this
is not bash then the shell will fail to parse integration.bash.

This is a regression caused by commit
c607989d91b64d837253aae794b1a3d6013eb3e0.  Clearly nobody has run this
test on Debian for a long time.  :-(

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Jan 24 10:28:52 CET 2018 on sn-devel-144

20 months agoctdb-tests: Add a UNIT pseudo-test-suite
Martin Schwenke [Mon, 22 Jan 2018 08:48:02 +0000 (19:48 +1100)]
ctdb-tests: Add a UNIT pseudo-test-suite

This runs all of the unit tests.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
20 months agoctdb-tests: Only use socket-wrapper for simple, local daemon tests
Martin Schwenke [Mon, 22 Jan 2018 08:14:48 +0000 (19:14 +1100)]
ctdb-tests: Only use socket-wrapper for simple, local daemon tests

The run_tests.sh -S option now takes the path to the socker-wrapper
shared library.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
20 months agoctdb-tests: Add timeout for individual tests, default is 10 minutes
Martin Schwenke [Sat, 20 Jan 2018 06:05:37 +0000 (17:05 +1100)]
ctdb-tests: Add timeout for individual tests, default is 10 minutes

This will cause a hung test to time out and fail rather than letting a
test run hang indefinitely.  Some tests can take 5 minutes to run, so
10 minutes should be plenty.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
20 months agolibnmb: Move "read_packet" to nmbd
Volker Lendecke [Tue, 16 Jan 2018 15:21:08 +0000 (16:21 +0100)]
libnmb: Move "read_packet" to nmbd

It's only used there

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 24 05:48:19 CET 2018 on sn-devel-144

20 months agolibnmb: Make nb_packet_read_recv return a talloc'ed pkt
Volker Lendecke [Tue, 16 Jan 2018 14:50:19 +0000 (15:50 +0100)]
libnmb: Make nb_packet_read_recv return a talloc'ed pkt

This saves a few explicit destructors only doing free_packet()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agolibnmb: Add "parse_packet_talloc"
Volker Lendecke [Tue, 23 Jan 2018 13:39:21 +0000 (14:39 +0100)]
libnmb: Add "parse_packet_talloc"

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agolibcli/resolve: Make functions static
Volker Lendecke [Sat, 13 Jan 2018 16:41:01 +0000 (17:41 +0100)]
libcli/resolve: Make functions static

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 23 06:36:36 CET 2018 on sn-devel-144

20 months agolibcli/resolve: Make functions static
Volker Lendecke [Sat, 13 Jan 2018 16:39:24 +0000 (17:39 +0100)]
libcli/resolve: Make functions static

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agolibcli/resolve: Fix typos
Volker Lendecke [Sat, 13 Jan 2018 16:38:16 +0000 (17:38 +0100)]
libcli/resolve: Fix typos

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agodsgetdcname: Fix a signed/unsigned hickup
Volker Lendecke [Fri, 5 Jan 2018 16:11:43 +0000 (17:11 +0100)]
dsgetdcname: Fix a signed/unsigned hickup

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agolibnmb: Fix two signed/unsigned hickups
Volker Lendecke [Thu, 18 Jan 2018 12:28:30 +0000 (13:28 +0100)]
libnmb: Fix two signed/unsigned hickups

Two warnings less

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agolibnmb: tsocket_address_unix_from_path deals fine with NULL
Volker Lendecke [Tue, 16 Jan 2018 14:04:06 +0000 (15:04 +0100)]
libnmb: tsocket_address_unix_from_path deals fine with NULL

Other callers use NULL instead of "". Streamline it a bit

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agolibnmb: Remove a pointless struct member
Volker Lendecke [Tue, 16 Jan 2018 14:07:47 +0000 (15:07 +0100)]
libnmb: Remove a pointless struct member

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agolibsmb: Give unexpected.c its own header
Volker Lendecke [Mon, 15 Jan 2018 15:12:15 +0000 (16:12 +0100)]
libsmb: Give unexpected.c its own header

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agowaf: Fix NFS quota support with libtirpc
Andreas Schneider [Fri, 19 Jan 2018 13:30:20 +0000 (14:30 +0100)]
waf: Fix NFS quota support with libtirpc

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jan 22 17:26:52 CET 2018 on sn-devel-144

20 months agowafsamba: Allow passing 'lib' to CHECK_STRUCTURE_MEMBER
Andreas Schneider [Fri, 19 Jan 2018 14:34:32 +0000 (15:34 +0100)]
wafsamba: Allow passing 'lib' to CHECK_STRUCTURE_MEMBER

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238

We need to be able to point it to the right header location, so we need
to be able to pass the 'lib' that it gets set.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
20 months agobuild: deal with recent glibc sunrpc header removal
Günther Deschner [Tue, 16 Jan 2018 16:48:10 +0000 (17:48 +0100)]
build: deal with recent glibc sunrpc header removal

We need to rely on libtirpc or libntirpc to be around in that case.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10976

Guenther

Pair-Programmed-With: Andreas Schneider <asn@samba.org>

Signed-off-by: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
20 months agoinclude: Create system/nis.h in libreplace
Andreas Schneider [Fri, 19 Jan 2018 08:33:21 +0000 (09:33 +0100)]
include: Create system/nis.h in libreplace

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238

Pair-Programmed-With: Guenther Deschner <gd@samba.org>

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
20 months agos3:waf: Move HAVE_NETGROUP to wscript
Andreas Schneider [Fri, 19 Jan 2018 08:32:49 +0000 (09:32 +0100)]
s3:waf: Move HAVE_NETGROUP to wscript

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13238

Pair-Programmed-With: Guenther Deschner <gd@samba.org>

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
20 months agodbcheck: disable fixing duplicate linked attributes until we can recover lost forward...
Stefan Metzmacher [Fri, 19 Jan 2018 10:50:55 +0000 (11:50 +0100)]
dbcheck: disable fixing duplicate linked attributes until we can recover lost forward links

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agorepl_meta_data: fix linked attribute corruption on databases with unsorted links...
Stefan Metzmacher [Wed, 17 Jan 2018 07:07:03 +0000 (08:07 +0100)]
repl_meta_data: fix linked attribute corruption on databases with unsorted links on expunge

This is really critical bug, it removes valid linked attributes.

When a DC was provisioned/joined with a Samba version older than 4.7
is upgraded to 4.7 (or later), it can happen that the garbage collection
(dsdb_garbage_collect_tombstones()), triggered periodically by the 'kcc' task
of 'samba' or my 'samba-tool domain tombstones expunge' corrupt the linked attributes.

This is similar to Bug #13095 - Broken linked attribute handling,
but it's not triggered by an originating change.

The bug happens in replmd_modify_la_delete()
were get_parsed_dns_trusted() generates a sorted array of
struct parsed_dn based on the values in old_el->values.

If the database doesn't support the sortedLinks compatibleFeatures
in the @SAMBA_DSDB record, it's very likely that
the array of old_dns is sorted differently than the values
in old_el->values.

The problem is that struct parsed_dn has just a pointer
'struct ldb_val *v' that points to the corresponding
value in old_el->values.

Now if vanish_links is true the damage happens here:

        if (vanish_links) {
                unsigned j = 0;
                for (i = 0; i < old_el->num_values; i++) {
                        if (old_dns[i].v != NULL) {
                                old_el->values[j] = *old_dns[i].v;
                                j++;
                        }
                }
                old_el->num_values = j;
        }

old_el->values[0] = *old_dns[0].v;
can change the value old_dns[1].v is pointing at!
That means that some values can get lost while others
are stored twice, because the LDB_FLAG_INTERNAL_DISABLE_SINGLE_VALUE_CHECK
allows it to be stored.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agotestprogs:blackbox: add regression test for unsorted links in tombstones-expunge.sh
Stefan Metzmacher [Thu, 18 Jan 2018 13:54:04 +0000 (14:54 +0100)]
testprogs:blackbox: add regression test for unsorted links in tombstones-expunge.sh

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13228

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agotalloc: Fix documentation typo
Martin Schwenke [Thu, 18 Jan 2018 05:08:15 +0000 (16:08 +1100)]
talloc: Fix documentation typo

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Jan 22 11:11:38 CET 2018 on sn-devel-144

20 months agoctdb-tests: Avoid race condition in sock_daemon test 5
Amitay Isaacs [Mon, 22 Jan 2018 01:54:49 +0000 (12:54 +1100)]
ctdb-tests: Avoid race condition in sock_daemon test 5

This test fails when it takes more than 10s to run.  This can occur
when the system is loaded and socket-wrapper is used.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
20 months agodocs: Remove prog_guide4.txt
Volker Lendecke [Thu, 18 Jan 2018 09:57:23 +0000 (10:57 +0100)]
docs: Remove prog_guide4.txt

Move the still relevant parts elsewhere

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Sun Jan 21 11:48:01 CET 2018 on sn-devel-144

20 months agovfs_fileid: Fix the 32-bit build
Volker Lendecke [Fri, 19 Jan 2018 12:15:58 +0000 (12:15 +0000)]
vfs_fileid: Fix the 32-bit build

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agoAdded smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient...
Puran Chand [Wed, 10 Jan 2018 07:43:44 +0000 (13:13 +0530)]
Added smbc_SetConfiguration which lets the user set the smb.conf for libsmbclient code

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13229

Signed-off-by: Puran Chand <pchand@vmware.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
20 months agomit-kdb: support MIT Kerberos 1.16 KDB API changes
Alexander Bokovoy [Tue, 24 Oct 2017 09:01:39 +0000 (12:01 +0300)]
mit-kdb: support MIT Kerberos 1.16 KDB API changes

MIT Kerberos 1.16 adds ability to audit local and remote addresses
during AS_REQ processing. As result, audit_as_req callback signature
was changed to include the addresses and KDB API version was increased.

Change mit-kdb code to properly expose audit_as_req signature KDC
expects in 1.16 version. Also update #ifdefs to account for the new
KDB API version.

This commit does not add actual audit of the local and remote IP
addresses, it only makes it possible to compile against MIT Kerberos
1.16.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jan 19 01:36:22 CET 2018 on sn-devel-144

20 months agowinbind: Fix CID 1427626 Uninitialized scalar variable
Volker Lendecke [Wed, 17 Jan 2018 13:45:49 +0000 (14:45 +0100)]
winbind: Fix CID 1427626 Uninitialized scalar variable

Likely a false positive, but Coverity can't follow all the paths leading
to line 1598.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Jan 17 23:58:34 CET 2018 on sn-devel-144

20 months agopdb: Fix CID 1427620 Resource leak
Volker Lendecke [Wed, 17 Jan 2018 13:38:41 +0000 (14:38 +0100)]
pdb: Fix CID 1427620 Resource leak

It's not exactly a resource leak (we only really realloc if we shrink
dramatically), but assigning the result from tdb_realloc looks nicer.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agowinbind: Fix CID 1427626 Uninitialized scalar variable
Volker Lendecke [Wed, 17 Jan 2018 13:42:31 +0000 (14:42 +0100)]
winbind: Fix CID 1427626 Uninitialized scalar variable

Likely a false positive, but Coverity can't follow all the paths leading
to line 2030

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agopdb: Fix CID 1427624 Resource leak
Volker Lendecke [Wed, 17 Jan 2018 13:38:41 +0000 (14:38 +0100)]
pdb: Fix CID 1427624 Resource leak

It's not exactly a resource leak (we only really realloc if we shrink
dramatically), but assigning the result from tdb_realloc looks nicer.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agovfs_glusterfs: Add fallocate support for vfs_glusterfs
Sachin Prabhu [Tue, 14 Nov 2017 10:21:44 +0000 (15:51 +0530)]
vfs_glusterfs: Add fallocate support for vfs_glusterfs

Adds fallocate support to the vfs glusterfs plugin.

v2: Add check for glusterfs-api version.
RHBZ: 1478875
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jan 17 06:09:29 CET 2018 on sn-devel-144

20 months agoRemove file system sharemode before calling unlink
Christof Schmitt [Wed, 10 Jan 2018 22:56:08 +0000 (15:56 -0700)]
Remove file system sharemode before calling unlink

GPFS implements the DENY_DELETE sharemode, which prevents unlink() from
deleting the file.. This causes the problem that deleting a file through
"delete on close" fails, as the code in close.c first calls unlink() and
only later removes the file system sharemode.

Fix this by removing the file system sharemode before calling unlink().

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13217

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Christof Schmitt <cs@samba.org>
Autobuild-Date(master): Wed Jan 17 01:31:53 CET 2018 on sn-devel-144

20 months agopackaging: fix default systemd-dir path.
Günther Deschner [Tue, 16 Jan 2018 15:25:01 +0000 (16:25 +0100)]
packaging: fix default systemd-dir path.

https://bugzilla.samba.org/show_bug.cgi?id=13227

By default we should not end up with a
/usr/usr/lib/systemd/system path.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Tue Jan 16 21:02:28 CET 2018 on sn-devel-144

20 months agopython: fix the build with python3.
Günther Deschner [Mon, 15 Jan 2018 20:56:22 +0000 (21:56 +0100)]
python: fix the build with python3.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13221

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
20 months agoselftest: fix envvars for creation of default user in wait_for_start
Jamie McClymont [Mon, 15 Jan 2018 02:25:10 +0000 (15:25 +1300)]
selftest: fix envvars for creation of default user in wait_for_start

Resolves failure of ad_member to start up under ad_dc (if
the user is determined to be needed).

Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13225

Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Tue Jan 16 07:12:01 CET 2018 on sn-devel-144

20 months agosrcctl3: Improve debug messages
Volker Lendecke [Mon, 15 Jan 2018 10:42:29 +0000 (11:42 +0100)]
srcctl3: Improve debug messages

A customer's syslog was filled with

_svcctl_OpenServiceW: Failed to get a valid security descriptor

messages. This improves the messages to give info about which service failed
with which error code. Also, it makes OpenServiceW fail with the same error
message Windows fails with for unknown services.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jan 16 02:43:03 CET 2018 on sn-devel-144

20 months agorpc_server: Improve a debug message
Volker Lendecke [Mon, 15 Jan 2018 09:47:51 +0000 (10:47 +0100)]
rpc_server: Improve a debug message

A client sending us a bind with an unknown interface should not spam
syslog by default. Also, show what interface the client tried to connect
to.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
20 months agos3:rpc_client: Clenup copy_netr_SamInfo3() code
Andreas Schneider [Thu, 11 Jan 2018 08:06:31 +0000 (09:06 +0100)]
s3:rpc_client: Clenup copy_netr_SamInfo3() code

This gets rid of some strange macro and makes sure we clenaup at the
end.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jan 15 22:16:13 CET 2018 on sn-devel-144

20 months agos3:winbind: Use a stackframe and cleanup when leaving
Andreas Schneider [Thu, 11 Jan 2018 08:37:22 +0000 (09:37 +0100)]
s3:winbind: Use a stackframe and cleanup when leaving

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agos3:winbind: Use a goto for cleaning up at the end
Andreas Schneider [Thu, 11 Jan 2018 08:27:50 +0000 (09:27 +0100)]
s3:winbind: Use a goto for cleaning up at the end

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
20 months agos3:winbindd: Improve logic so it is easier to understand
Andreas Schneider [Thu, 11 Jan 2018 08:23:05 +0000 (09:23 +0100)]
s3:winbindd: Improve logic so it is easier to understand

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13209

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
21 months agoVERSION: Bump version up to 4.9.0pre1...
Karolin Seeger [Thu, 11 Jan 2018 10:11:56 +0000 (11:11 +0100)]
VERSION: Bump version up to 4.9.0pre1...

and re-enable GIT_SNAPSHOT.

Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Jan 15 02:51:51 CET 2018 on sn-devel-144