25 years agomake the initial logfile names consistent. This should mean that smbd
Andrew Tridgell [Thu, 12 Feb 1998 14:57:55 +0000 (14:57 +0000)]
make the initial logfile names consistent. This should mean that smbd
starts with log.smb and nmbd starts with log.nmb. It also gets rid of
the "log." when using the log.%m construct as %m expands to smb before
a client connects.

25 years agoAdded fix for doing pq command (from "James J. Szinger" <>).
Jeremy Allison [Thu, 12 Feb 1998 11:59:55 +0000 (11:59 +0000)]
Added fix for doing pq command (from "James J. Szinger" <>).

25 years agoENCRYPTION.txt: Fixed typo.
Jeremy Allison [Thu, 12 Feb 1998 07:17:07 +0000 (07:17 +0000)]
ENCRYPTION.txt: Fixed typo.
Support.txt: Added consultant.
smb.conf.5: Updated with new parameters.

25 years agoremoved old unused test
Herb Lewis [Wed, 11 Feb 1998 11:38:09 +0000 (11:38 +0000)]
removed old unused test

25 years agofixed typo
Andrew Tridgell [Wed, 11 Feb 1998 11:25:04 +0000 (11:25 +0000)]
fixed typo

25 years agoMakefile: Added AIX 3.2.5.
Jeremy Allison [Wed, 11 Feb 1998 11:07:14 +0000 (11:07 +0000)]
Makefile: Added AIX 3.2.5.
loadparm.c: Added "win95 bug compatibility" parameter.
local.h: Replaced MAX_OPEN_FILES back to 100 from 10 (oops).
reply.c: Fixed ulogoff check against uid - changed to vuid.
server.c: Changed file struct save of uid - changed to vuid.
smb.h: Changed id in struct current_user to vuid.
       Changed file struct uid to vuid.
time.c: Added "win95 bug compatibility" atime -> mtime return.
trans2.c: Added "win95 bug compatibility" fixes.
uid.c: Changed id in struct current_user to vuid - added checks
       to set/reset it.
util.c: Added code to expand environment variables.
version.h : still at 1.9.18 (head branch doesn't matter too much at present).

25 years agoA small raft of changes, I will sync up with 1.9.18 also.
Jeremy Allison [Sat, 7 Feb 1998 12:15:20 +0000 (12:15 +0000)]
A small raft of changes, I will sync up with 1.9.18 also.
chgpasswd.c: Fixed typo in debug message.
includes.h: Fix include for aix.
kanji.c: Added cap_to_sj as inverse of sj_to_cap.
password.c: Added code for "networkstation user login" parameter.
- patch from Rob Nielsen <>.
printing.c: Added further aix printing fixes.
reply.c: Changed access time fetch to a function.
trans2.c: Changed access time fetch to a function.
time.c: Changed access time fetch to a function.
server.c: Made NT redirector workaround final.
util.c: Added debug for write_socket failing.

25 years agoAdded Newcast - UK Consultant to Support.txt
John Terpstra [Tue, 3 Feb 1998 23:43:37 +0000 (23:43 +0000)]
Added Newcast - UK Consultant to Support.txt

25 years agoRemoved Brett Worth from Support.txt as per Bug#3833
John Terpstra [Tue, 3 Feb 1998 23:37:13 +0000 (23:37 +0000)]
Removed Brett Worth from Support.txt as per Bug#3833

25 years agoserver.c: Added fix where, if all the file entries are being
Jeremy Allison [Sat, 31 Jan 1998 14:31:08 +0000 (14:31 +0000)]
server.c: Added fix where, if all the file entries are being
used, smbd tries to break an oplock to make room for another
file entry. This works well with Windows 95 that seems to keep
batch oplocks around for an arbitrarily long time.
Also changed rlimit code to ask for MAX_OPEN_FILES + 10 (if allowed) as
many systems use file descriptors for directory handles also.

25 years agofix bug when using lpstat as printcap file - remove space at start of
Herb Lewis [Fri, 30 Jan 1998 05:22:45 +0000 (05:22 +0000)]
fix bug when using lpstat as printcap file - remove space at start of
printer names generated

25 years agoMakefile: Fix for OSF1 typo.
Jeremy Allison [Thu, 29 Jan 1998 08:25:46 +0000 (08:25 +0000)]
Makefile: Fix for OSF1 typo.
asyncdns.c: Fixes that went into 1.9.18p2 - allow unclocking of sigterm.
chgpasswd.c: char -> unsigned char fixes.
includes.h: AIX fix to get prototype for inet_ntoa.
local.h: Tune size of shared memory based on MAX_OPEN_FILES.
nmbd_mynames.c: Fix for nmbd repeated refresh bug.
nmbd_responserecordsdb.c: Fix for nmbd repeated refresh bug.
nmbd_winsserver.c: Fix for multi-homed registration optimisation.
smb.h: Moved default shared memory size to local.h

25 years agoFix from Charles Hoch ( Whne there is no data
Jeremy Allison [Wed, 28 Jan 1998 13:11:58 +0000 (13:11 +0000)]
Fix from Charles Hoch ( Whne there is no data
to send, setting the data alignment to a 4 byte boundary causes
a few extra bytes to be sent. This seems to cause the NT redirector
to *sometimes* fail.

25 years agoget rid of reference to removed file
Herb Lewis [Wed, 28 Jan 1998 11:45:57 +0000 (11:45 +0000)]
get rid of reference to removed file

25 years ago*** empty log message ***
Volker Lendecke [Mon, 26 Jan 1998 04:53:07 +0000 (04:53 +0000)]
*** empty log message ***

25 years agoalways align both the parameter and data bytes on a 4 byte boundary in
Andrew Tridgell [Sun, 25 Jan 1998 15:36:11 +0000 (15:36 +0000)]
always align both the parameter and data bytes on a 4 byte boundary in
trans2 responses.
I'm not at all convinced this was causing problems, because
observations of Win95 show that it produces totally non-aligned
paramater bytes and 2 byte aligned data bytes. We were previously
always producing 2 byte aligned data and parameter bytes so we already
had "better" alignment than Win95.
lets hope no clients rely on servers producing unaligned data or

25 years agoAdded log message so we can tell when free_service is called.
Jeremy Allison [Sat, 24 Jan 1998 12:34:16 +0000 (12:34 +0000)]
Added log message so we can tell when free_service is called.
Just in case of problems.

25 years agoFix for memory leak in loadparm.c - donated by Branko Cibej <>
Jeremy Allison [Sat, 24 Jan 1998 12:26:17 +0000 (12:26 +0000)]
Fix for memory leak in loadparm.c - donated by Branko Cibej <>
I checked this out and it looks ok - the bzero() in init_service() was
overwriting the pointers pservice->szService and pservice->copymap
that should have been freed in copy_service() the line later. This
fix frees pservice->szService and pservice->copymap inside free_service()
and sets them to zero so they won't be freed again.

25 years agoAdded get_create_time() function to time.c.
Jeremy Allison [Sat, 24 Jan 1998 08:49:21 +0000 (08:49 +0000)]
Added get_create_time() function to time.c.
This gets the minimum timestamp associated with a file.
reply.c and trans2.c then return this as the create
time. Designed to fix problems with VC++ and others.

25 years agoChanged code that truncates salt after 2 characters so that it becomes
Jeremy Allison [Fri, 23 Jan 1998 13:52:17 +0000 (13:52 +0000)]
Changed code that truncates salt after 2 characters so that it becomes
HPUX specific. This fixes a bug with FreeBSD md5 crypt implementation
that needs all of the password characters.
It seems better to make this an HPUX specific thing.

25 years agoFixed warnings with gcc (assignments inside if statements).
Jeremy Allison [Fri, 23 Jan 1998 08:35:15 +0000 (08:35 +0000)]
Fixed warnings with gcc (assignments inside if statements).

25 years agochanges to correctly use some HP printer inf files
Herb Lewis [Fri, 23 Jan 1998 07:59:29 +0000 (07:59 +0000)]
changes to correctly use some HP printer inf files

25 years agosync with changes to 1.9.18 tree
Herb Lewis [Fri, 23 Jan 1998 07:58:45 +0000 (07:58 +0000)]
sync with changes to 1.9.18 tree

25 years agoChanged phone numbers for BitWizard.
Jeremy Allison [Fri, 23 Jan 1998 05:58:59 +0000 (05:58 +0000)]
Changed phone numbers for BitWizard.

25 years agonmbd.c, server.c: Added #ifndef MEM_MAN around code that sets the SIGUSR1
Jeremy Allison [Fri, 23 Jan 1998 05:22:19 +0000 (05:22 +0000)]
nmbd.c, server.c: Added #ifndef MEM_MAN around code that sets the SIGUSR1
and SIGUSR2 signals. This allows the MEM_MAN code to be compiled in and
the memory debug feature to be used with SIGUSR1.

25 years agoThis is *not* a big change (although it looks like one).
Jeremy Allison [Thu, 22 Jan 1998 13:27:43 +0000 (13:27 +0000)]
This is *not* a big change (although it looks like one).
This is merely updating the Copyright statements from 1997 to 1998.
It's a once a year thing :-).

25 years agoprinting.c: Bug fix for lpng reporting.
Jeremy Allison [Thu, 22 Jan 1998 09:25:05 +0000 (09:25 +0000)]
printing.c: Bug fix for lpng reporting.
server.c: Large fix for oplock deadlock bug.
util.c: Fix for oplock deadlock bug.

25 years agoAdded Romanian consultant.
Jeremy Allison [Thu, 22 Jan 1998 07:33:35 +0000 (07:33 +0000)]
Added Romanian consultant.

25 years ago*** empty log message ***
Volker Lendecke [Thu, 22 Jan 1998 03:47:48 +0000 (03:47 +0000)]
*** empty log message ***

25 years agoFixed send_mailslot code where src_type was always being set to zero.
Jeremy Allison [Wed, 21 Jan 1998 12:15:07 +0000 (12:15 +0000)]
Fixed send_mailslot code where src_type was always being set to zero.
Fix found by Bernhard Laeser <>.

25 years agofixed a few typos in the instructions and added a longer explaination for
Herb Lewis [Wed, 21 Jan 1998 09:46:04 +0000 (09:46 +0000)]
fixed a few typos in the instructions and added a longer explaination for
how the printers.def entry is constructed.

25 years agofix problems with using inf files from HP for DesignJet 750C (C3195A)
Herb Lewis [Wed, 21 Jan 1998 09:17:51 +0000 (09:17 +0000)]
fix problems with using inf files from HP for DesignJet 750C (C3195A)

25 years agoFixed bug found by Bernhard Laeser where we are announcing to the wrong
Jeremy Allison [Tue, 20 Jan 1998 04:58:41 +0000 (04:58 +0000)]
Fixed bug found by Bernhard Laeser where we are announcing to the wrong
DMB name.

25 years agoAdded italian consultancy.
Jeremy Allison [Sat, 17 Jan 1998 11:42:51 +0000 (11:42 +0000)]
Added italian consultancy.

25 years agocharcnv.c: Added codepage 866 support onto the file system. Patch
Jeremy Allison [Sat, 17 Jan 1998 07:08:21 +0000 (07:08 +0000)]
charcnv.c: Added codepage 866 support onto the file system. Patch
from Max Khon <>.
chgpasswd.c: Allow old RAP change password to work with encrypted
passwords. Samba can now allow Windows 95/NT clients to securely
change the Lanman password ! (But not the NT hash - that gets lost).
smbpass.c: Support for the above.
server.c: #ifdef'ed out fix for NT redirector bug.
util.c: Fix NIS bug with server name.

25 years agoreply.c:
Jeremy Allison [Fri, 16 Jan 1998 08:58:00 +0000 (08:58 +0000)]
server.c: Test fix for NT worstation SMBmv oplock bug.
smbdes.c: Addition of 'forward' parameter in preparation of allowing
password change.

25 years agoAdding new codepage file.
Jeremy Allison [Fri, 16 Jan 1998 06:31:01 +0000 (06:31 +0000)]
Adding new codepage file.

25 years agoMakefile: Added new codepage - 866.
Jeremy Allison [Fri, 16 Jan 1998 06:29:38 +0000 (06:29 +0000)]
Makefile: Added new codepage - 866.
charset.c: Supporting code for codepage 866.
clientutil.c: Fix compile bug in little-used #define.
includes.h: Supporting code for codepage 866.
make_smbcodepage.c: Supporting code for codepage 866.
pcap.c: Fix bug for lpstat.

25 years agoreply.c: Added timestamp to attack warning.
Jeremy Allison [Thu, 15 Jan 1998 04:57:54 +0000 (04:57 +0000)]
reply.c: Added timestamp to attack warning.
server.c: Fixed security=share problem where the vuid was still being
looked at.

25 years agoREADME describe inst package version number correctly
Herb Lewis [Wed, 14 Jan 1998 07:17:37 +0000 (07:17 +0000)]
README describe inst package version number correctly fix some permission problems with shell scripts
sambalp new script supplied by Alan Stebbens that can run setuid to
properly print banner page for known users.
smb.conf  use new sambalp by default. remove - now handled by sambalp

25 years agofile srv_lsa_hnd.c was initially added on branch BRANCH_NTDOM.
Luke Leighton [Wed, 14 Jan 1998 06:15:10 +0000 (06:15 +0000)]
file srv_lsa_hnd.c was initially added on branch BRANCH_NTDOM.

25 years agoleft out a piece of my last fix for inst package version number
Herb Lewis [Wed, 14 Jan 1998 02:47:36 +0000 (02:47 +0000)]
left out a piece of my last fix for inst package version number

25 years agofix bug in search string
Herb Lewis [Tue, 13 Jan 1998 05:08:08 +0000 (05:08 +0000)]
fix bug in search string

25 years agopropogate my cgi changes to the main branch
Andrew Tridgell [Mon, 12 Jan 1998 00:32:27 +0000 (00:32 +0000)]
propogate my cgi changes to the main branch

25 years ago*** empty log message ***
Andrew Tridgell [Mon, 12 Jan 1998 00:20:10 +0000 (00:20 +0000)]
*** empty log message ***

25 years ago*** empty log message ***
Andrew Tridgell [Sun, 11 Jan 1998 23:59:11 +0000 (23:59 +0000)]
*** empty log message ***

25 years ago*** empty log message ***
Andrew Tridgell [Sun, 11 Jan 1998 23:28:39 +0000 (23:28 +0000)]
*** empty log message ***

25 years agoFollowing discussions with Cristian Gafton (Red Hat) we have decided to make
John Terpstra [Sat, 10 Jan 1998 11:42:29 +0000 (11:42 +0000)]
Following discussions with Cristian Gafton (Red Hat) we have decided to make
PAM silent about it's actions. This reduced error logging for EVERY password
validation request. Refer to password.c PAM section for further info.
Fiels Affected: password.c

25 years agoipc.c: Fixed problem where we were not returning 'buffer too small'
Jeremy Allison [Sat, 10 Jan 1998 08:11:15 +0000 (08:11 +0000)]
ipc.c: Fixed problem where we were not returning 'buffer too small'
when NT sends up a mdrcnt of zero.

25 years agodocs/Support.txt: Removed consultant.
Jeremy Allison [Fri, 9 Jan 1998 05:33:27 +0000 (05:33 +0000)]
docs/Support.txt: Removed consultant.
source/Makefile: Added Volker's comment.
source/nmbd_incomingdgrams.c: Fixed userdata alignment problems.
source/mem_man/mem_man.h: added smb_ prefix to stop namespace collisions.

25 years agofix bug in version numbering scheme
Herb Lewis [Thu, 8 Jan 1998 16:34:09 +0000 (16:34 +0000)]
fix bug in version numbering scheme

25 years agomissing a couple of binary files in the distribution
Herb Lewis [Thu, 8 Jan 1998 10:50:18 +0000 (10:50 +0000)]
missing a couple of binary files in the distribution

25 years agopreparing for release of 1.9.18
Samba Release Account [Thu, 8 Jan 1998 06:15:48 +0000 (06:15 +0000)]
preparing for release of 1.9.18

25 years agoFinal changes - ready for 1.9.18.
Jeremy Allison [Thu, 8 Jan 1998 05:27:30 +0000 (05:27 +0000)]
Final changes - ready for 1.9.18.

25 years agoFixed an apparent typo:
Christopher R. Hertel [Thu, 8 Jan 1998 03:04:55 +0000 (03:04 +0000)]
Fixed an apparent typo:
< #endif /NO_FORK_DEBUG */
> #endif /* NO_FORK_DEBUG */
Chris -)-----

25 years agoUpdated for 1.9.18 - just need a few more changes & it's done.
Jeremy Allison [Wed, 7 Jan 1998 13:36:06 +0000 (13:36 +0000)]
Updated for 1.9.18 - just need a few more changes & it's done.

25 years agoEnsure that if we are in share mode security that the smb_uid
Jeremy Allison [Wed, 7 Jan 1998 08:29:15 +0000 (08:29 +0000)]
Ensure that if we are in share mode security that the smb_uid
field is invalid.

25 years agoincludes.h: Added FreeBSD 3.x fixes. Added HPUX10.x fixes.
Jeremy Allison [Wed, 7 Jan 1998 06:21:56 +0000 (06:21 +0000)]
includes.h: Added FreeBSD 3.x fixes. Added HPUX10.x fixes.
interface.c: Added netmask fix.
nmbd_nameregister.c: Fixed unitialised variable warnings.
nmbd_winsproxy.c: Fixed unitialised variable warnings.
nmbd_winsserver.c: Fixed DEC warnings.
print_svid.c: Fixed DEC warnings.
printing.c: Added LPRng fixes.

25 years agoUpdated french contact address.
Jeremy Allison [Wed, 7 Jan 1998 05:34:07 +0000 (05:34 +0000)]
Updated french contact address.

25 years agoAdded manpages.
Volker Lendecke [Tue, 6 Jan 1998 00:13:44 +0000 (00:13 +0000)]
Added manpages.
Removed obsolete options from smbmount help message.

25 years agothe real source code for the smbfs utilities. Forgot to do
Volker Lendecke [Mon, 5 Jan 1998 22:56:29 +0000 (22:56 +0000)]
the real source code for the smbfs utilities. Forgot to do
cvs add first.

25 years agoAdded 3 commands:
Volker Lendecke [Mon, 5 Jan 1998 22:54:32 +0000 (22:54 +0000)]
Added 3 commands:
smbmount: This is a stripped down smbclient that communicates with
the Linux 2.1.x kernel to supply authenticated smb connections for
smbfs mount points.
smbmnt/smbumount: setuid commands that do the actual smb mount system
call after having done the appropriate security checks

25 years agoFixed type that referred to regedit.exe instead of regedt32.exe.
John Terpstra [Mon, 5 Jan 1998 13:02:03 +0000 (13:02 +0000)]
Fixed type that referred to regedit.exe instead of regedt32.exe.

25 years agofixed type in list of ignored files
Herb Lewis [Sat, 3 Jan 1998 05:26:31 +0000 (05:26 +0000)]
fixed type in list of ignored files

25 years agoadded description of changes I made
Herb Lewis [Sat, 3 Jan 1998 05:22:35 +0000 (05:22 +0000)]
added description of changes I made

25 years agoadded printout of file list to stderr so you know what files you need to
Herb Lewis [Sat, 3 Jan 1998 05:12:10 +0000 (05:12 +0000)]
added printout of file list to stderr so you know what files you need to
copy to your printer$ share

25 years agoadded commented out sections for supporting automatically providing printer
Herb Lewis [Sat, 3 Jan 1998 03:55:52 +0000 (03:55 +0000)]
added commented out sections for supporting automatically providing printer
drivers to Win95 clients.

25 years agoadded timestrings to become and unbecome domain/local master browser
Herb Lewis [Sat, 3 Jan 1998 03:35:13 +0000 (03:35 +0000)]
added timestrings to become and unbecome domain/local master browser

25 years agofix printer driver rpc to prevent core dumps.
Herb Lewis [Fri, 2 Jan 1998 13:33:20 +0000 (13:33 +0000)]
fix printer driver rpc to prevent core dumps.

25 years agofix up perl script so it is a little cleaner and also works with perl 4
Herb Lewis [Fri, 2 Jan 1998 04:26:39 +0000 (04:26 +0000)]
fix up perl script so it is a little cleaner and also works with perl 4

25 years agofixes to make_printerdef.c to generate a correct printers.def file
Herb Lewis [Thu, 1 Jan 1998 13:55:28 +0000 (13:55 +0000)]
fixes to make_printerdef.c to generate a correct printers.def file
changes to ipc.c to use new printers.def file

25 years agoavoid the ~ operator in netmask operations as apparently it causes
Andrew Tridgell [Mon, 29 Dec 1997 18:46:20 +0000 (18:46 +0000)]
avoid the ~ operator in netmask operations as apparently it causes
problems on some systems (eg. freeBSD 2.2.2). I'm surprised by this
but the change looks harmless. Patch from

25 years agoa dummy change to shmem_sysv.c to try and break CVS out of a problem
Andrew Tridgell [Mon, 29 Dec 1997 12:34:16 +0000 (12:34 +0000)]
a dummy change to shmem_sysv.c to try and break CVS out of a problem
with the ntdom branch

25 years agofixed another couple of minor type errors (they could cause incorrect
Andrew Tridgell [Fri, 26 Dec 1997 10:07:05 +0000 (10:07 +0000)]
fixed another couple of minor type errors (they could cause incorrect
output but not a core dump)

25 years agofixed a couple of illegal uses of scanf() in the nmbd wins code. They
Andrew Tridgell [Fri, 26 Dec 1997 10:01:57 +0000 (10:01 +0000)]
fixed a couple of illegal uses of scanf() in the nmbd wins code. They
caused a core dump under IRIX when compiled with -64.
In general you cannot assume things about variable sizes. In
particular sizeof(time_t) may not equal sizeof(long) and
sizeof(uint16) may not equal sizeof(short).
There are probably other bugs like this. We'll need to check all
format statements for use of %ld, %hx etc. In general these should not
be used unless you have an explicit cast to the appropriate type.

25 years agouse _exit to exit a child
Andrew Tridgell [Fri, 26 Dec 1997 09:57:40 +0000 (09:57 +0000)]
use _exit to exit a child

25 years agoThis is actually Jeremy, working as Herb :-).
Herb Lewis [Wed, 24 Dec 1997 15:42:14 +0000 (15:42 +0000)]
This is actually Jeremy, working as Herb :-).
Fixed bug where, when server is shut down it would always
do a lm announce broadcast of shutdown. This could cause other
nmbd's to think that they have seen an lm announce broadcast and
start doing it themselves.
Changed to only send lm announce shutdown if admin configured it
or one was seen on the subnet.

25 years agopreparing for release of 1.9.18alpha14
Samba Release Account [Wed, 24 Dec 1997 10:59:38 +0000 (10:59 +0000)]
preparing for release of 1.9.18alpha14

25 years agoUpdated WHATSNEW.txt for 1.9.18alpha14 release.
Jeremy Allison [Wed, 24 Dec 1997 10:50:43 +0000 (10:50 +0000)]
Updated WHATSNEW.txt for 1.9.18alpha14 release.
Added CVS_ACCESS to tell people how to use cvs
to keep up-to-date.

25 years agoAdded docs for new signal handling functions.
Jeremy Allison [Wed, 24 Dec 1997 09:33:06 +0000 (09:33 +0000)]
Added docs for new signal handling functions.

25 years agoAdded SIGUSR1/SIGUSR2 handling.
Jeremy Allison [Wed, 24 Dec 1997 09:30:56 +0000 (09:30 +0000)]
Added SIGUSR1/SIGUSR2 handling.
Sending nmbd/smbd a SIGUSR1 will raise the debug level by one (capped at 10)
sending a SIGUSR2 will lower it (lower limit at zero).

25 years agonmbd_elections.c: Added new parameter to dump_workgroups call.
Jeremy Allison [Wed, 24 Dec 1997 08:49:44 +0000 (08:49 +0000)]
nmbd_elections.c: Added new parameter to dump_workgroups call.
nmbd_incomingdgrams.c: Deal with announcements with servertype == 0 - these
 are announcements that a machine is shutting down and must be treated differently.
nmbd_serverlistdb.c: Exposed remove_server_from_workgroup as external.
  Added code to dump out workgroups on signal correctly.
nmbd_workgroupdb.c: Added new parameter to dump_workgroups call.

25 years agoFinally added the code Andrew wanted that will allow a Samba domain
Jeremy Allison [Wed, 24 Dec 1997 07:10:04 +0000 (07:10 +0000)]
Finally added the code Andrew wanted that will allow a Samba domain
master browser to use the *<1b> feature of the Samba WINS server to
get a full workgroup list.
nmbd.c: Added timed call to collect_all_workgroup_names_from_wins_server().
nmbd_browsesync.c: Meat of the code to implement collect_all_workgroup_names_from_wins_server().
nmbd_incomingdgrams.c: Fixed comment typo.

25 years agoBugfix from Branko Cibej <>
Jeremy Allison [Wed, 24 Dec 1997 04:32:01 +0000 (04:32 +0000)]
Bugfix from Branko Cibej <>
- client.c had a workaround embedded in it for his
earlier bug in StrnCaseCmp - removed this.

25 years agoBacked out changes that attempted to address a pointer array using -1,0,1.
Christopher R. Hertel [Wed, 24 Dec 1997 02:50:19 +0000 (02:50 +0000)]
Backed out changes that attempted to address a pointer array using -1,0,1.
Jeremy pointed out that there might be problems with this.  Darn shame.

25 years agoFixed nastly little bug where client was sending open_and_X call
Jeremy Allison [Tue, 23 Dec 1997 13:21:36 +0000 (13:21 +0000)]
Fixed nastly little bug where client was sending open_and_X call
with smb_mode (smb_vwv[3]) of 0x20 == DENY_WRITE + read-only-open.
and smb_ofun (smb_vwv[8]) of 0x11 == Create if not exist plus append
on a read-only share.
This was mapped into the strange unix flags of (O_RDONLY|O_CREAT)
- essentially O_CREAT as O_RDONLY == 0.
We were checking the unix flags directly against O_RDONLY instead
of masking off the open mode flag bits before doing the comparison,
so this open was being refused even though it was valid on a
read-only share.
Also ensured that the O_CREAT bit was masked out of the flags
bit if the open was done on a read-only share (as doing a unix
open( filename, O_RDONLY|O_CREAT, xxx) will create a zero length
file if the user had permission to write into the directory - which
should be denied on a read-only share.
Thanks to Mark Peek @ Whistle for giving me this test case.

25 years agoFixed security bug when 'force user' and 'user only' are set.
Jeremy Allison [Tue, 23 Dec 1997 11:30:58 +0000 (11:30 +0000)]
Fixed security bug when 'force user' and 'user only' are set.
Reported by Brian McCauley <>.

25 years agoFixes to compile under OpenBSD from "Todd T. Fries" <>
Jeremy Allison [Tue, 23 Dec 1997 07:15:59 +0000 (07:15 +0000)]
Fixes to compile under OpenBSD from "Todd T. Fries" <>

25 years agoarchitecture.doc: Re-added since I lost it (sorry Dan :-).
Jeremy Allison [Tue, 23 Dec 1997 06:38:36 +0000 (06:38 +0000)]
architecture.doc: Re-added since I lost it (sorry Dan :-).
nmbd.c nmbd_responserecordsdb.c: Spelling mistake fixes.

25 years agoUpdates for 1.9.18
Dan Shearer [Sun, 21 Dec 1997 00:00:25 +0000 (00:00 +0000)]
Updates for 1.9.18

25 years agoPut it in the right directory :~)
Dan Shearer [Sat, 20 Dec 1997 23:44:25 +0000 (23:44 +0000)]
Put it in the right directory :~)

25 years agoChris' smb.conf parsing doco
Dan Shearer [Sat, 20 Dec 1997 23:40:17 +0000 (23:40 +0000)]
Chris' smb.conf parsing doco

25 years agoFixed stupid bug in read_smb_len where I was calling itself - now
Jeremy Allison [Sat, 20 Dec 1997 14:52:48 +0000 (14:52 +0000)]
Fixed stupid bug in read_smb_len where I was calling itself - now
calling the correct fn.

25 years agoclient.c:
Jeremy Allison [Sat, 20 Dec 1997 14:36:11 +0000 (14:36 +0000)]
clitar.c: Changed usage of receive_smb to new function client_receive_smb
          except for one use of receive_smb in client.c. This is the
          receive_smb used to discard packets received whilst in a
          keyboard wait state.
util.c: Created new function client_receive_smb that ignores session
        keepalives just as the old receive_smb used to do. Created
        internal function read_smb_length_return_keepalive that is
        used internally by the changed receive_smb call.
        Changed read_smb_len to not use an internal buffer - it is
        never called with a null buffer so such code is redundant.

25 years agoloadparm.c: Added fix for veto oplock files bug from Charles Hoch <hoch@hplcgh.hpl...
Jeremy Allison [Sat, 20 Dec 1997 10:52:00 +0000 (10:52 +0000)]
loadparm.c: Added fix for veto oplock files bug from Charles Hoch <>
server.c, util.c: Added fix for oplock break requests blocking due to server being
                  blocked in read call. Bug found by Charles Hoch <>.

25 years agoThis may be a waste of time, but I thought if we keep nibbling at this it might
Dan Shearer [Sat, 20 Dec 1997 10:06:07 +0000 (10:06 +0000)]
This may be a waste of time, but I thought if we keep nibbling at this it might
end up being a curent announce for each new release. Then again maybe we should
start from the one Jeremy and I did for 1.9.17. Just doodling really.

25 years agoMinor spelling, wording changes to intro
Dan Shearer [Sat, 20 Dec 1997 09:52:02 +0000 (09:52 +0000)]
Minor spelling, wording changes to intro

25 years agotrans2.c: Forced trans2_findfirst to behave as NT does in error returns.
Jeremy Allison [Sat, 20 Dec 1997 05:25:37 +0000 (05:25 +0000)]
trans2.c: Forced trans2_findfirst to behave as NT does in error returns.
util.c: Applied fix from Branko Cibej <> where
StrnCaseCmp tests one character too many.

25 years agoAdding the cache module.
Christopher R. Hertel [Fri, 19 Dec 1997 09:32:58 +0000 (09:32 +0000)]
Adding the cache module.
I'll be using the cache module to replace the name cache in mangle.c.  The
new one should be much faster and should require less memory.
Another feature is that the cache size can be limited by the amount of
memory used in addition to the number of entries allowed.  With the
current cache, the default is to allocate 12800 bytes representing 50
entries (256 bytes each).  With the same amount of memory, I should be able
to load over around two hundred entries.
Changes to the AVL trees were minor (missing comments).
Chris -)-----

25 years agokanji.h: Fixed problems with re-definitions of strchr and others on AIX.
Jeremy Allison [Thu, 18 Dec 1997 11:05:00 +0000 (11:05 +0000)]
kanji.h: Fixed problems with re-definitions of strchr and others on AIX.
nmbd_nameregister.c: Applied fix found by "Eloy A. Paris" <>
(don't re-use lists after you have freed them :-).