samba.git
7 years agos4-selftest: Avoid running kinit for each new connection
Andrew Bartlett [Sun, 19 Feb 2012 10:24:59 +0000 (21:24 +1100)]
s4-selftest: Avoid running kinit for each new connection

Kerberos is efficient when the credentials cache is set up once and
then reused.

Sadly this test creates a user, does a test and deletes the user, over
and over.

For this, using NTLM saves a little time, but we also stress the rest
of the DB, and should rework the test.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 20 00:49:56 CET 2012 on sn-devel-104

7 years agos3: Remove a pointless else branch
Volker Lendecke [Sat, 18 Feb 2012 15:49:47 +0000 (16:49 +0100)]
s3: Remove a pointless else branch

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 19 23:14:15 CET 2012 on sn-devel-104

7 years agos3: Fix some blank line endings
Volker Lendecke [Sat, 18 Feb 2012 15:07:37 +0000 (16:07 +0100)]
s3: Fix some blank line endings

7 years agos3-vfstest: Initialize some more
Volker Lendecke [Sun, 19 Feb 2012 17:48:15 +0000 (18:48 +0100)]
s3-vfstest: Initialize some more

7 years agowaf: make "update-waf" script work on Darwin too
Dave Abrahams [Sun, 19 Feb 2012 18:47:59 +0000 (19:47 +0100)]
waf: make "update-waf" script work on Darwin too

This fixes bug #8766

Reviewed by: Jelmer
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Feb 19 21:35:06 CET 2012 on sn-devel-104

7 years agos3: get_share_mode_lock_fresh->get_share_mode_lock
Volker Lendecke [Sun, 19 Feb 2012 13:27:49 +0000 (14:27 +0100)]
s3: get_share_mode_lock_fresh->get_share_mode_lock

get_share_mode_lock_fresh is just a confusing name

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 19 19:16:41 CET 2012 on sn-devel-104

7 years agos3: get_share_mode_lock->get_existing_share_mode_lock
Volker Lendecke [Sun, 19 Feb 2012 13:23:56 +0000 (14:23 +0100)]
s3: get_share_mode_lock->get_existing_share_mode_lock

7 years agoRevert 42d4152ed4255f22ff0718d450f181468d7fb827.
Jelmer Vernooij [Sun, 19 Feb 2012 15:06:01 +0000 (16:06 +0100)]
Revert 42d4152ed4255f22ff0718d450f181468d7fb827.

asn1_compile and com_err already depended on LIBREPLACE_HOSTCC; depending on replace too causes waf to break (source lib/replace/replace.c is in more than one subsystem of target 'asn1_compile': ['LIBREPLACE_HOSTCC', 'replace'])

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 19 17:43:06 CET 2012 on sn-devel-104

7 years agowaf: Use libraries when building.
Jelmer Vernooij [Sun, 19 Feb 2012 03:48:27 +0000 (04:48 +0100)]
waf: Use libraries when building.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 19 06:27:55 CET 2012 on sn-devel-104

7 years agoUse uselib in CHECK_HEADER.
Jelmer Vernooij [Sun, 19 Feb 2012 02:58:32 +0000 (03:58 +0100)]
Use uselib in CHECK_HEADER.

7 years agopopt: Use pkg-config file to look for popt.
Jelmer Vernooij [Sun, 19 Feb 2012 02:10:03 +0000 (03:10 +0100)]
popt: Use pkg-config file to look for popt.

7 years agolibrary_flags: Leave setting of CPPPATH to waf too.
Jelmer Vernooij [Sun, 19 Feb 2012 01:16:14 +0000 (02:16 +0100)]
library_flags: Leave setting of CPPPATH to waf too.

7 years agos4-python: Various formatting fixes.
Jelmer Vernooij [Sat, 18 Feb 2012 22:59:48 +0000 (23:59 +0100)]
s4-python: Various formatting fixes.

7 years agosamba.web_server: Fix use of whitespace.
Jelmer Vernooij [Sat, 18 Feb 2012 22:54:38 +0000 (23:54 +0100)]
samba.web_server: Fix use of whitespace.

7 years agopygensec: Fix whitespace.
Jelmer Vernooij [Sat, 18 Feb 2012 22:52:37 +0000 (23:52 +0100)]
pygensec: Fix whitespace.

7 years agowaf: Update to new upstream version.
Jelmer Vernooij [Sat, 18 Feb 2012 22:19:51 +0000 (23:19 +0100)]
waf: Update to new upstream version.

7 years agowafsamba: Fix some whitespace issues.
Jelmer Vernooij [Sat, 18 Feb 2012 22:17:59 +0000 (23:17 +0100)]
wafsamba: Fix some whitespace issues.

7 years agos3-secrets: Remove unused secrets_delete_generic()
Andrew Bartlett [Thu, 9 Feb 2012 04:14:34 +0000 (15:14 +1100)]
s3-secrets: Remove unused secrets_delete_generic()

Found by callcatcher.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Feb 18 09:01:15 CET 2012 on sn-devel-104

7 years agos3-secrets: Remove unused secrets_delete_machine_password()
Andrew Bartlett [Thu, 9 Feb 2012 04:15:56 +0000 (15:15 +1100)]
s3-secrets: Remove unused secrets_delete_machine_password()

Found by callcatcher.

Andrew Bartlett

7 years agos3-build: allow gcov testing by linking timelimit with --coverage
Andrew Bartlett [Sat, 18 Feb 2012 06:10:39 +0000 (17:10 +1100)]
s3-build: allow gcov testing by linking timelimit with --coverage

7 years agoFix a bunch of "unused variable" warnings.
Jeremy Allison [Fri, 17 Feb 2012 22:12:40 +0000 (14:12 -0800)]
Fix a bunch of "unused variable" warnings.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 18 06:22:40 CET 2012 on sn-devel-104

7 years agoauth: Reorder arguments to generate_session_info
Andrew Bartlett [Sat, 4 Feb 2012 06:49:49 +0000 (17:49 +1100)]
auth: Reorder arguments to generate_session_info

This matches check_ntlm_password() and generate_session_info_pac()

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Feb 18 02:19:35 CET 2012 on sn-devel-104

7 years agoselftest: Fix selftest to check ADS functionalty again
Andrew Bartlett [Fri, 17 Feb 2012 23:35:24 +0000 (10:35 +1100)]
selftest: Fix selftest to check ADS functionalty again

This was found by looking over the lcov output on build.samba.org

The new have_ads() check also now dies if it cannot run smbd, to avoid
this in future.

Andrew Bartlett

7 years agos4:lib/tls - include GNUTLS headers consistently using <...>
Matthias Dieter Wallnöfer [Fri, 17 Feb 2012 21:58:07 +0000 (22:58 +0100)]
s4:lib/tls - include GNUTLS headers consistently using <...>

These are system-specific.

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Feb 18 00:43:58 CET 2012 on sn-devel-104

7 years agos4:samba-tool fsmo * - fix missing "takes_optiongroups"
Matthias Dieter Wallnöfer [Fri, 17 Feb 2012 20:24:48 +0000 (21:24 +0100)]
s4:samba-tool fsmo * - fix missing "takes_optiongroups"

This has been reported in bug #8755.

Reviewed-by: Jelmer
7 years agolib/util: Remove unused sys_sendto()
Andrew Bartlett [Thu, 9 Feb 2012 01:58:27 +0000 (12:58 +1100)]
lib/util: Remove unused sys_sendto()

Found by callcatcher.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 17 13:48:05 CET 2012 on sn-devel-104

7 years agolib/util: Remove unused sys_recv()
Andrew Bartlett [Thu, 9 Feb 2012 01:57:21 +0000 (12:57 +1100)]
lib/util: Remove unused sys_recv()

Found by callcatcher.

Andrew Bartlett

7 years agolib/util: Remove unused sys_inet_makeaddr()
Andrew Bartlett [Thu, 9 Feb 2012 01:55:10 +0000 (12:55 +1100)]
lib/util: Remove unused sys_inet_makeaddr()

Found by callcatcher.

Andrew Bartlett

7 years agolib/util: Remove unused sys_gethostbyname()
Andrew Bartlett [Thu, 9 Feb 2012 01:54:24 +0000 (12:54 +1100)]
lib/util: Remove unused sys_gethostbyname()

Found by callcatcher.

Andrew Bartlett

7 years agos3-lib: Remove unused standard_sub_conn()
Andrew Bartlett [Thu, 9 Feb 2012 01:51:22 +0000 (12:51 +1100)]
s3-lib: Remove unused standard_sub_conn()

7 years agos3-lib Remove unused sys_fcntl_long()
Andrew Bartlett [Thu, 9 Feb 2012 01:05:58 +0000 (12:05 +1100)]
s3-lib Remove unused sys_fcntl_long()

7 years agos3-lib Remove unused sys_fseek()
Andrew Bartlett [Thu, 9 Feb 2012 01:04:23 +0000 (12:04 +1100)]
s3-lib Remove unused sys_fseek()

7 years agos3-registry Remove unused dup_registry_value() and free_registry_value()
Andrew Bartlett [Thu, 9 Feb 2012 00:06:13 +0000 (11:06 +1100)]
s3-registry Remove unused dup_registry_value() and free_registry_value()

7 years agoauth: Allow the netbios name and domain to be set from winbindd in ntlm_auth3
Andrew Bartlett [Mon, 6 Feb 2012 07:02:11 +0000 (18:02 +1100)]
auth: Allow the netbios name and domain to be set from winbindd in ntlm_auth3

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Feb 17 12:18:51 CET 2012 on sn-devel-104

7 years agoauth: Make more of the ntlmssp code private or static
Andrew Bartlett [Tue, 31 Jan 2012 10:20:34 +0000 (21:20 +1100)]
auth: Make more of the ntlmssp code private or static

Now that there is only one gensec_ntlmssp server, some of these functions can be static

For the rest, put the implemtnation of the gensec_ntlmssp code into ntlmssp_private.h

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Use common gensec_ntlmssp
Andrew Bartlett [Tue, 31 Jan 2012 05:29:02 +0000 (16:29 +1100)]
s3-auth: Use common gensec_ntlmssp

There is no longer any samba3-specific code left here.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Use common gensec_ntlmssp_server_start
Andrew Bartlett [Tue, 31 Jan 2012 05:19:32 +0000 (16:19 +1100)]
s3-auth: Use common gensec_ntlmssp_server_start

This is now identical code, so there is no need to duplicate it.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Use the gensec-supplied DNS domain name and hostname.
Andrew Bartlett [Tue, 31 Jan 2012 05:17:48 +0000 (16:17 +1100)]
s3-auth: Use the gensec-supplied DNS domain name and hostname.

Also have a reasonable fallback for when it is not set.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agoauth: Provide a way to specify the NTLMSSP server name to GENSEC
Andrew Bartlett [Tue, 31 Jan 2012 05:17:04 +0000 (16:17 +1100)]
auth: Provide a way to specify the NTLMSSP server name to GENSEC

This avoids us needing to assume lp_netbios_name().lp_dnsdomain() if the caller
knows better.  This will allow preservation of current s3 behaviour.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Allow NTLMSSP features to be disabled with smb.conf options for testing
Andrew Bartlett [Tue, 31 Jan 2012 05:01:45 +0000 (16:01 +1100)]
s3-auth: Allow NTLMSSP features to be disabled with smb.conf options for testing

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agoauth: Rearrange ntlmssp code for clarity
Andrew Bartlett [Tue, 31 Jan 2012 04:57:06 +0000 (15:57 +1100)]
auth: Rearrange ntlmssp code for clarity

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Use the lpcfg_ wrapper calls to set some variables
Andrew Bartlett [Tue, 31 Jan 2012 04:52:17 +0000 (15:52 +1100)]
s3-auth: Use the lpcfg_ wrapper calls to set some variables

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Remove a layer of indirection and reorder to match gensec_ntlmssp_server_start()
Andrew Bartlett [Tue, 31 Jan 2012 04:50:15 +0000 (15:50 +1100)]
s3-auth: Remove a layer of indirection and reorder to match gensec_ntlmssp_server_start()

7 years agoauth: Set NTLMSSP_NEGOTIATE_SIGN when session key support is required
Andrew Bartlett [Tue, 31 Jan 2012 04:40:53 +0000 (15:40 +1100)]
auth: Set NTLMSSP_NEGOTIATE_SIGN when session key support is required

This matches the s3 NTLMSSP server.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Only allow LM_KEY cryptography when extra options are set
Andrew Bartlett [Tue, 31 Jan 2012 04:38:02 +0000 (15:38 +1100)]
s3-auth: Only allow LM_KEY cryptography when extra options are set

This crypto is incredibly poor, and can technically be enabled on an otherwise more
secure connection that uses NTLM for the actual authentication leg.  Therefore
disable it by default.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Inline ntlmssp_server_start() into gensec_ntlmssp3_server_start()
Andrew Bartlett [Tue, 31 Jan 2012 04:36:08 +0000 (15:36 +1100)]
s3-auth: Inline ntlmssp_server_start() into gensec_ntlmssp3_server_start()

This will help syncing this rotuine up with gensec_ntlmssp_server_start().

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth Use the common gensec_ntlmssp_update in gensec_ntlmssp3_server
Andrew Bartlett [Tue, 31 Jan 2012 03:43:25 +0000 (14:43 +1100)]
s3-auth Use the common gensec_ntlmssp_update in gensec_ntlmssp3_server

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Use common gensec_ntlmssp server functions for more of gensec_ntlmssp3_server
Andrew Bartlett [Tue, 31 Jan 2012 03:39:34 +0000 (14:39 +1100)]
s3-auth: Use common gensec_ntlmssp server functions for more of gensec_ntlmssp3_server

This is possible because we now supply the auth4_context abstraction that this
code is looking for.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth: Add extra error messages on authentication or authorization failure
Andrew Bartlett [Tue, 31 Jan 2012 01:53:30 +0000 (12:53 +1100)]
s3-auth: Add extra error messages on authentication or authorization failure

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agoauth: Cope with NO_USER_SESSION_KEY from security=server
Andrew Bartlett [Tue, 31 Jan 2012 07:14:19 +0000 (18:14 +1100)]
auth: Cope with NO_USER_SESSION_KEY from security=server

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agoauth: Move the rest of the source4 gensec_ntlmssp code to the top level
Andrew Bartlett [Mon, 30 Jan 2012 11:42:39 +0000 (22:42 +1100)]
auth: Move the rest of the source4 gensec_ntlmssp code to the top level

The ntlmssp_server code will be in common shortly, and aside from a
symbol name or two, moving the client code causes no harm and makes
less mess.  We will also get the client code in common very soon.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-auth Hook checking passwords and generating session_info via the auth4_context
Andrew Bartlett [Mon, 30 Jan 2012 11:11:41 +0000 (22:11 +1100)]
s3-auth Hook checking passwords and generating session_info via the auth4_context

This avoids creating a second auth_context, as it is a private pointer
in the auth4_context that has already been passed in, and makes the
gensec_ntlmssp code agnostic to the type of authentication backend
behind it. This will in turn allow the ntlmssp server code to be
further merged.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-build: Use credentials_ntlm.c in the autoconf build as well
Andrew Bartlett [Tue, 31 Jan 2012 09:50:36 +0000 (20:50 +1100)]
s3-build: Use credentials_ntlm.c in the autoconf build as well

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agobuild: Add exceptions for callcatcher unused function detection
Andrew Bartlett [Fri, 17 Feb 2012 04:42:25 +0000 (15:42 +1100)]
build: Add exceptions for callcatcher unused function detection

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 17 09:12:47 CET 2012 on sn-devel-104

7 years agowintest: Update Win2003 VM
Andrew Bartlett [Fri, 17 Feb 2012 02:43:12 +0000 (13:43 +1100)]
wintest: Update Win2003 VM

7 years agoauth/kerberos: Move gse_get_session_key() to common code and use in gensec_gssapi
Andrew Bartlett [Fri, 17 Feb 2012 02:36:35 +0000 (13:36 +1100)]
auth/kerberos: Move gse_get_session_key() to common code and use in gensec_gssapi

Thie ensures that both code bases use the same logic to determine the use
of NEW_SPNEGO.

Andrew Bartlett

7 years agos3-gse: Allow kerberos key type OID to be optional
Andrew Bartlett [Fri, 17 Feb 2012 01:35:14 +0000 (12:35 +1100)]
s3-gse: Allow kerberos key type OID to be optional

7 years agos3-gse: Fix OID to read for kerberos key type
Andrew Bartlett [Fri, 17 Feb 2012 01:30:55 +0000 (12:30 +1100)]
s3-gse: Fix OID to read for kerberos key type

7 years agos3-librpc: Remove backup declaration of GSS_C_DCE_STYLE
Andrew Bartlett [Fri, 17 Feb 2012 01:04:19 +0000 (12:04 +1100)]
s3-librpc: Remove backup declaration of GSS_C_DCE_STYLE

All our supported krb5 libs provide this.

Andrew Bartlett

7 years agos3-gse: Remove unused OID declaration
Andrew Bartlett [Fri, 17 Feb 2012 01:00:56 +0000 (12:00 +1100)]
s3-gse: Remove unused OID declaration

7 years agowintest: give host longer to register the SRV record
Andrew Bartlett [Fri, 17 Feb 2012 00:27:29 +0000 (11:27 +1100)]
wintest: give host longer to register the SRV record

7 years agowintest: use net rpc to put authenticated users into TelentClients if we need to
Andrew Bartlett [Fri, 17 Feb 2012 00:27:02 +0000 (11:27 +1100)]
wintest: use net rpc to put authenticated users into TelentClients if we need to

7 years agowintest: Allow Windows VM to have no default route
Andrew Bartlett [Fri, 17 Feb 2012 00:26:23 +0000 (11:26 +1100)]
wintest: Allow Windows VM to have no default route

7 years agoReplace smbd_server_connection_loop_once() with tevent_loop_once() directly.
Jeremy Allison [Fri, 17 Feb 2012 00:14:14 +0000 (16:14 -0800)]
Replace smbd_server_connection_loop_once() with tevent_loop_once() directly.

We no longer need to call poll() directly inside smbd !

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 17 02:49:13 CET 2012 on sn-devel-104

7 years agolib/util: Remove sys_poll as it is no longer needed
Andrew Bartlett [Thu, 9 Feb 2012 02:16:55 +0000 (13:16 +1100)]
lib/util: Remove sys_poll as it is no longer needed

sys_poll() is only needed if the signal pipe is set up and used, but as
no signal handler ever writes to the pipe, this can all be removed.

signal based events are now handled via tevent.

Andrew Bartlett

Signed-off-by: Jeremy Allison <jra@samba.org>
7 years agolib/util: Remove unused sys_select_signal()
Andrew Bartlett [Thu, 9 Feb 2012 02:02:14 +0000 (13:02 +1100)]
lib/util: Remove unused sys_select_signal()

Now sys_poll needs to be cleaned up not to refer to the pipe that is now not used.

Andrew Bartlett

Signed-off-by: Jeremy Allison <jra@samba.org>
7 years agos3-librpc: Remove gse_verify_server_auth_flags
Andrew Bartlett [Tue, 7 Feb 2012 11:27:53 +0000 (22:27 +1100)]
s3-librpc: Remove gse_verify_server_auth_flags

gensec_update() ensures that DCE-style and sign/seal are negotiated correctly
for DCE/RPC pipes.  Also, the smb sealing client/server already check for the
gensec_have_feature().

This additional check just keeps causing trouble, and is 'protecting'
an already secure negoitated exchange.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb 16 21:19:44 CET 2012 on sn-devel-104

7 years agodocs-xml: remove docs for "send spnego principal"
Stefan Metzmacher [Mon, 6 Feb 2012 13:06:10 +0000 (14:06 +0100)]
docs-xml: remove docs for "send spnego principal"

metze

7 years agos3-param Remove off-by-default and unused "send spnego principal"
Andrew Bartlett [Fri, 3 Feb 2012 00:57:30 +0000 (11:57 +1100)]
s3-param Remove off-by-default and unused "send spnego principal"

This is not honoured by the common SPNEGO code.

This matches mondern windows versions which do not send this value, as
it would be insecure for a client to rely on it.  (See also the
depricated client use spnego principal directive).

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-smbd Remove unused code now we always have SPNEGO via gensec
Andrew Bartlett [Fri, 3 Feb 2012 00:54:32 +0000 (11:54 +1100)]
s3-smbd Remove unused code now we always have SPNEGO via gensec

This was previously needed because SPNEGO was only available in the AD DC.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-librpc: Use gensec_spnego for DCE/RPC authentication
Andrew Bartlett [Mon, 6 Feb 2012 01:40:38 +0000 (12:40 +1100)]
s3-librpc: Use gensec_spnego for DCE/RPC authentication

This ensures that we use the same SPNEGO code on session setup and on
DCE/RPC binds, and simplfies the calling code as spnego is no longer
a special case in cli_pipe.c

A special case wrapper function remains to avoid changing the
application layer callers in this patch.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-gse: Use the session key type, not the lucid context to set NEW_SPNEGO
Andrew Bartlett [Tue, 14 Feb 2012 07:29:54 +0000 (18:29 +1100)]
s3-gse: Use the session key type, not the lucid context to set NEW_SPNEGO

Using gss_krb5_export_lucid_sec_context() is a problem with MIT krb5, as
it (reasonably, I suppose) invalidates the gssapi context on which it
is called.  Instead, we look to the type of session key which is
negotiated, and see if it not AES (or newer).

If we negotiated AES or newer, then we set GENSEC_FEATURE_NEW_SPENGO
so that we know to generate valid mechListMic values in SPNEGO.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-librpc: Remove unused bool gensec_hook
Andrew Bartlett [Mon, 6 Feb 2012 01:25:41 +0000 (12:25 +1100)]
s3-librpc: Remove unused bool gensec_hook

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:rpc_client: fix comment
Stefan Metzmacher [Mon, 6 Feb 2012 07:14:54 +0000 (08:14 +0100)]
s3:rpc_client: fix comment

metze

7 years agos3-librpc: make gensec result handling more generic
Andrew Bartlett [Mon, 6 Feb 2012 02:37:12 +0000 (13:37 +1100)]
s3-librpc: make gensec result handling more generic

This prepares us for handling SPNEGO via gensec

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agowafsamba: exclude '.brzignore' from "make dist"
Michael Adam [Thu, 16 Feb 2012 11:08:30 +0000 (12:08 +0100)]
wafsamba: exclude '.brzignore' from "make dist"

.bzrignore can cause unwanted effects, if one e.g. maintains
a packaging (like debian) of the generated distribution in bzr.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Feb 16 13:47:52 CET 2012 on sn-devel-104

7 years agowafsamba: exclude '.gitignore' from "make dist"
Michael Adam [Wed, 15 Feb 2012 14:34:58 +0000 (15:34 +0100)]
wafsamba: exclude '.gitignore' from "make dist"

.gitignore can cause unwanted effects, if one e.g. maintains
a packaging (like debian) of the generated distribution in git

7 years agowafsamba: fix blacklist handling in "make dist"
Michael Adam [Wed, 15 Feb 2012 15:07:54 +0000 (16:07 +0100)]
wafsamba: fix blacklist handling in "make dist"

7 years agos4:provision: only print the adminpass if it was generated (not user-provided)
Michael Adam [Thu, 16 Feb 2012 11:06:34 +0000 (12:06 +0100)]
s4:provision: only print the adminpass if it was generated (not user-provided)

7 years agos4:provision: generate the adminpass provision() instead of provision_fill()
Michael Adam [Thu, 16 Feb 2012 10:21:30 +0000 (11:21 +0100)]
s4:provision: generate the adminpass provision() instead of provision_fill()

so that the adminpass can be logged at the end
(otherwise we get "None")

7 years agos4:provision: don't log the ldap admin password - it is internal only
Michael Adam [Wed, 15 Feb 2012 23:51:54 +0000 (00:51 +0100)]
s4:provision: don't log the ldap admin password - it is internal only

7 years agos4-scripting: samba-tool: Fix domain info usage message
Björn Baumbach [Tue, 24 Jan 2012 12:02:13 +0000 (13:02 +0100)]
s4-scripting: samba-tool: Fix domain info usage message

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos4-selftest: fix output of opened connections in torture_holdcon
Björn Baumbach [Tue, 10 Jan 2012 15:43:27 +0000 (16:43 +0100)]
s4-selftest: fix output of opened connections in torture_holdcon

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agoRename obscure defined constants.
Christopher R. Hertel (crh) [Wed, 15 Feb 2012 03:51:35 +0000 (21:51 -0600)]
Rename obscure defined constants.

Replaced the undescriptive SMB_PORT1 and SMB_PORT2 defined constants
with the slightly more descriptive names NBT_SMB_PORT and TCP_SMB_PORT.
Also replaced several hard-coded references to the well-known port
numbers (139 and 445, respectively) as appropriate.

Small changes to clarify some comments regarding the two transport
types.

Signed-off-by: Simo Sorce <idra@samba.org>
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Thu Feb 16 08:29:41 CET 2012 on sn-devel-104

7 years agos3-selftest: Remove .posix_s3 from s3 test names
Andrew Bartlett [Tue, 14 Feb 2012 10:42:16 +0000 (21:42 +1100)]
s3-selftest: Remove .posix_s3 from s3 test names

As far as I can tell, this simply referred to the posix_s3.sh script
that originally ran these tests.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Feb 16 06:57:09 CET 2012 on sn-devel-104

7 years agoselftest: Remove 'if have_ads_support:' from tests.py
Andrew Bartlett [Mon, 13 Feb 2012 22:05:21 +0000 (09:05 +1100)]
selftest: Remove 'if have_ads_support:' from tests.py

The selftest system now skips launching these if the environment is not available.

Andrew Bartlett

7 years agos3-smbd: Avoid starting log lines with the word 'error'
Andrew Bartlett [Mon, 13 Feb 2012 06:44:34 +0000 (17:44 +1100)]
s3-smbd: Avoid starting log lines with the word 'error'

7 years agoselftest: skip plugin_s4_dc if we do not have ADS
Andrew Bartlett [Thu, 16 Feb 2012 04:12:49 +0000 (15:12 +1100)]
selftest: skip plugin_s4_dc if we do not have ADS

7 years agoselftest: Run nsstest against more environments
Andrew Bartlett [Thu, 16 Feb 2012 04:10:00 +0000 (15:10 +1100)]
selftest: Run nsstest against more environments

7 years agoselftest: skip targets that are not compiled in if we do not have ADS
Andrew Bartlett [Mon, 13 Feb 2012 22:04:16 +0000 (09:04 +1100)]
selftest: skip targets that are not compiled in if we do not have ADS

7 years agos3-selftest: Require SMB signing for ktest environment
Andrew Bartlett [Tue, 14 Feb 2012 08:22:14 +0000 (19:22 +1100)]
s3-selftest: Require SMB signing for ktest environment

This will help weed out session key errors in the krb5 code.

Andrew Bartlett

7 years agoselftest: Do not start up an already-running test environment
Andrew Bartlett [Tue, 14 Feb 2012 21:55:05 +0000 (08:55 +1100)]
selftest: Do not start up an already-running test environment

Otherwise we may re-provision the dc just because we started it via s3member or s4member
first.

Andrew Bartlett

7 years agoselftest: Make plugin_s4_dc set the cached environment correctly
Andrew Bartlett [Wed, 15 Feb 2012 05:08:05 +0000 (16:08 +1100)]
selftest: Make plugin_s4_dc set the cached environment correctly

7 years agowintest: update WinXP-1 snapshot
Andrew Bartlett [Thu, 16 Feb 2012 02:51:10 +0000 (13:51 +1100)]
wintest: update WinXP-1 snapshot

7 years agowintest: Change Windows 7 VM
Andrew Bartlett [Thu, 16 Feb 2012 00:34:49 +0000 (11:34 +1100)]
wintest: Change Windows 7 VM

7 years agowintest: Give the Windows VM a little more time to start back up
Andrew Bartlett [Wed, 15 Feb 2012 03:44:24 +0000 (14:44 +1100)]
wintest: Give the Windows VM a little more time to start back up

7 years agowintest: Samba is now all version 4.0
Andrew Bartlett [Tue, 14 Feb 2012 23:08:07 +0000 (10:08 +1100)]
wintest: Samba is now all version 4.0

7 years agowintest: Cope with nc not timing out even when -w 1 is specified
Andrew Bartlett [Tue, 14 Feb 2012 22:29:27 +0000 (09:29 +1100)]
wintest: Cope with nc not timing out even when -w 1 is specified

7 years agowintest: s3 moved smb.conf to /etc
Andrew Bartlett [Tue, 14 Feb 2012 11:43:50 +0000 (22:43 +1100)]
wintest: s3 moved smb.conf to /etc

7 years agowintest: Update VM used for W2K8R2A
Andrew Bartlett [Tue, 14 Feb 2012 10:42:44 +0000 (21:42 +1100)]
wintest: Update VM used for W2K8R2A