17 years ago* BUG 446
Gerald Carter [Thu, 15 Jan 2004 19:03:18 +0000 (19:03 +0000)]
* BUG 446
  - setup_logging() in smbclient to be interactive (remove the timestamps)
  - Fix bad return value in pull_ucs2( needs more testing to make sure this
    didn't break something else) that caused clistr_pull() to always read
    the same string from the buffer (pull_usc2() could return -1 if the original
    source length was given as -1)
  - increment some debugging messages to avoid printing them out so often
(This used to be commit 79fe75dcdf6cc38e18ca1231e4357893db4d4a08)

17 years agoBUG 958; don't use the -N option when invoking smbclient from the smbtar script
Gerald Carter [Thu, 15 Jan 2004 17:18:39 +0000 (17:18 +0000)]
BUG 958; don't use the -N option when invoking smbclient from the smbtar script
(This used to be commit c51eaec4f09d9c191c6b24dadb1d12770b368da0)

17 years agoreply_spnego_kerberos did not set the domain of the user handed to
Volker Lendecke [Thu, 15 Jan 2004 17:17:58 +0000 (17:17 +0000)]
reply_spnego_kerberos did not set the domain of the user handed to
register_vuid correctly. We ended up with the local netbios name in
substitutions for %D later.


P.S: Tridge, I can *really* see why you want to get rid of global variables
(This used to be commit 3d9931fe291559a907c3e172a66fbce1155497a3)

17 years agoDon't substitute stuff in lp_afs_username_map, this is explicitly
Volker Lendecke [Thu, 15 Jan 2004 17:05:08 +0000 (17:05 +0000)]
Don't substitute stuff in lp_afs_username_map, this is explicitly
done later.

(This used to be commit c4a6151f469764444f4dab8bcae04e1a2bdb0b64)

17 years agoAnd another memory corruption in winbind. Arg 3 of safe_strcpy does not
Volker Lendecke [Thu, 15 Jan 2004 15:36:01 +0000 (15:36 +0000)]
And another memory corruption in winbind. Arg 3 of safe_strcpy does not
include the terminating 0.

(This used to be commit 945c7807641e82500c84e833f03f381497f0a2d0)

17 years agoFix a segfault in winbindd. Calling getusersids with a SID that results in 0
Volker Lendecke [Thu, 15 Jan 2004 15:00:44 +0000 (15:00 +0000)]
Fix a segfault in winbindd. Calling getusersids with a SID that results in 0
groups winbind ended up freeing an uninitialised pointer.

(This used to be commit cd89288e21ba13a9e97c548eccc15cef21a98d07)

17 years ago* Fix sys_chown() when no chown() is presend
Stefan Metzmacher [Thu, 15 Jan 2004 09:08:06 +0000 (09:08 +0000)]
* Fix sys_chown() when no chown() is presend

(This used to be commit b0c0d736919079afc4f9bf5a406000048d26fe71)

17 years ago* Fix XFS quotas: XFS_USER_QUOTA -> USRQUOTA
Stefan Metzmacher [Thu, 15 Jan 2004 08:49:30 +0000 (08:49 +0000)]
* Fix disk_free calculation with group quotas.
* Add debug class 'quota' and a lot of DEBUG()'s
  to the quota code.

(This used to be commit e9e5e2036f13ff847aa3ef52e8be657bef7d5774)

17 years agoBUG 936: fix bind credentials for schannel binds in smbd (and add a comment to winbin...
Gerald Carter [Thu, 15 Jan 2004 06:55:10 +0000 (06:55 +0000)]
BUG 936: fix bind credentials for schannel binds in smbd (and add a comment to winbindd_cm about this
(This used to be commit 5134c6bcbc5180431e95a30559c453f3744fd427)

17 years agoFix for bug 905. Remove POBAD_CC as it doesn't seem to be applicable
Tim Potter [Thu, 15 Jan 2004 06:51:20 +0000 (06:51 +0000)]
Fix for bug 905.  Remove POBAD_CC as it doesn't seem to be applicable
(This used to be commit 67d25f3de803f7e599c51cacd51367f124151d6b)

17 years agoBUG 972; check pointer in cli_ds_getprimarydominfo() before trying to copy a structure
Gerald Carter [Thu, 15 Jan 2004 05:16:29 +0000 (05:16 +0000)]
BUG 972; check pointer in cli_ds_getprimarydominfo() before trying to copy a structure
(This used to be commit 1c15bfacb45d42873f3d7e7cb55ba2cbbbe33d26)

17 years agosource/rpc_parse/parse_prs.c ZERO_STRUCTP(ps) not needed as it is done
Herb Lewis [Wed, 14 Jan 2004 22:53:50 +0000 (22:53 +0000)]
source/rpc_parse/parse_prs.c ZERO_STRUCTP(ps) not needed as it is done
in prs_init now

testsuite/printing/psec.c cannot do a prs_mem_free() when tdb_prs_fetch fails
as the prs structure has not been initialized
(This used to be commit a363e5d8c549861329506bd87c11d82ace5520e5)

17 years agoFix initgroups() call nss_winbind on solaris; patch from John Klinger <john.klinger...
Gerald Carter [Wed, 14 Jan 2004 21:22:30 +0000 (21:22 +0000)]
Fix initgroups() call nss_winbind on solaris; patch from John Klinger <>
(This used to be commit 40b7d863dc246ea23ff3d9cdc167f1fb96166e1d)

17 years agobug 770; correct fix this time; Make sure that we send the SMBjobid for unix jobs...
Gerald Carter [Wed, 14 Jan 2004 20:56:26 +0000 (20:56 +0000)]
bug 770; correct fix this time;  Make sure that we send the SMBjobid for unix jobs back to the client.  Allows windows client to remove print jobs submitted from lpr
(This used to be commit 514561118860f982c458930c34763dac9ce0554e)

17 years agobug 660; using byte order safe macros (or tdb_unpack) when reading 2 or 4 byte values...
Gerald Carter [Wed, 14 Jan 2004 19:12:06 +0000 (19:12 +0000)]
bug 660; using byte order safe macros (or tdb_unpack) when reading 2 or 4 byte values from a tdb buffer
(This used to be commit be9f25bea94415af6b631a9c6e7af28d9d6e6565)

17 years agorevert the cracklib changes until post 3.0.2
Gerald Carter [Wed, 14 Jan 2004 17:34:41 +0000 (17:34 +0000)]
revert the cracklib changes until post 3.0.2
(This used to be commit 6202e0fa727a4307f51bf42f5ced401a7c7b8214)

17 years ago* Revert to using rpc for mixed mode AD domains.
Gerald Carter [Wed, 14 Jan 2004 16:25:39 +0000 (16:25 +0000)]
* Revert to using rpc for mixed mode AD domains.
  The reason for this are:
  (a) the set_dc_type_and_flags() cannot tell the different
      between connecting to an NT4 domain and an NT4 BDC
      of a mixed mode domain.
  (b) the connection management for the rpc backend only
      provides on named pipe per cli_state.  So it is possible
      to connect to an NT4 BDC for netlogon and an AD mixed mode
      DC for lsarpc.  RPC is the lowest common demonimator here.
  (c) Issue with the sequence number value between the
      highestCommittedUSN LDAP attribute and the seq_num returned
      via RPC.

We will revisit this later, but the changes need to make this
work right now are too broad and risky.
(This used to be commit 1ed2e521536108229d153c2996f4757d89461166)

17 years agoRemove duplicate extern.
Jeremy Allison [Wed, 14 Jan 2004 06:44:20 +0000 (06:44 +0000)]
Remove duplicate extern.
(This used to be commit fb088b5679f1def054d8b433c5e6c5b855411488)

17 years agoRemove references to 'jn' which gcc-3.4 with precompiled headers
Jeremy Allison [Wed, 14 Jan 2004 06:41:50 +0000 (06:41 +0000)]
Remove references to 'jn' which gcc-3.4 with precompiled headers
doesn't like.
(This used to be commit da51988cfac91e63f6e0213701aad652bc1bd55e)

17 years agofix XFS quotas the macro changed from HAVE_XFS_QUOTA -> HAVE_XFS_QUOTAS
Stefan Metzmacher [Wed, 14 Jan 2004 02:51:41 +0000 (02:51 +0000)]
fix XFS quotas the macro changed from HAVE_XFS_QUOTA -> HAVE_XFS_QUOTAS

(This used to be commit c73e845055163c1d814710fe4d9960c7f3587f12)

17 years agoRemove duplicate comment.
Andrew Bartlett [Wed, 14 Jan 2004 01:17:21 +0000 (01:17 +0000)]
Remove duplicate comment.

Andrew Bartlett
(This used to be commit b0b2010461d8554334b033c4f07d78c308e73e7f)

17 years agoFinish adding cracklib support - this adds the configure test to enable
Andrew Bartlett [Wed, 14 Jan 2004 01:14:22 +0000 (01:14 +0000)]
Finish adding cracklib support - this adds the configure test to enable
it, on machines that actually have a working cracklib, for which we have
the correct path to the dictionary.

Andrew Bartlett
(This used to be commit 17518018c0264d2a8e4afbc712a22ef4a1a00003)

17 years ago* allow dns lookups to be disabled for DOMAIN#1c (and #1b)
Gerald Carter [Tue, 13 Jan 2004 19:42:53 +0000 (19:42 +0000)]
* allow dns lookups to be disabled for DOMAIN#1c (and #1b)
* fix some a mispelled variable name
(This used to be commit bca702c97620ad8f66015d6e4b41abd4adf22076)

17 years agoOn systems without a working cracklib, ensure we don't include the header
Andrew Bartlett [Mon, 12 Jan 2004 21:12:47 +0000 (21:12 +0000)]
On systems without a working cracklib, ensure we don't include the header
(the actual call to crack was already in this #ifdef)

Andrew Bartlett
(This used to be commit 4a01f3dbb4a2e744b48bdb86c4d91ee4692d38e5)

17 years agofixing compile problems due to my recent ads.h changes
Gerald Carter [Mon, 12 Jan 2004 14:26:50 +0000 (14:26 +0000)]
fixing compile problems due to my recent ads.h changes
(This used to be commit d7b6298b9e4e7f83deaa2c6f3d711c390ff9cefd)

17 years agoFirst stab at cracklib support (password quality checking) in Samba 3.0
Andrew Bartlett [Mon, 12 Jan 2004 12:18:11 +0000 (12:18 +0000)]
First stab at cracklib support (password quality checking) in Samba 3.0

This adds a configure test, that tries to find out if we have a working
cracklib installation, and tries to pick up the debian hints on where
the dictionary might be found.  Default is per my Fedora Core 1 system -
I'm not sure how much it changes.

Andrew Bartlett
(This used to be commit bc770edb788f0b6f719011cda683f045b76b7ba5)

17 years agofix formatting
Gerald Carter [Sun, 11 Jan 2004 14:15:12 +0000 (14:15 +0000)]
fix formatting
(This used to be commit acc9022550b20b144f749411ecdadf18adb09350)

17 years agoupdate copyright to -2004
Stefan Metzmacher [Sun, 11 Jan 2004 13:23:50 +0000 (13:23 +0000)]
update copyright to -2004

(This used to be commit 12d6bc3bd0684646e990c2fc6485fe1a92ac98fb)

17 years agoFix swatdir location for --with-fhs
Jelmer Vernooij [Sat, 10 Jan 2004 22:05:38 +0000 (22:05 +0000)]
Fix swatdir location for --with-fhs
(This used to be commit d12b793d9ca10f966da3446982a5b1d987d51814)

17 years agostarting new version of release notes -- post 3.0.2pre1
Gerald Carter [Fri, 9 Jan 2004 16:02:42 +0000 (16:02 +0000)]
starting new version of release notes -- post 3.0.2pre1
(This used to be commit 83150b5733033aed4b3556ea94782a5b6c7b9aeb)

17 years agofix some warnings from the Sun compiler
Gerald Carter [Fri, 9 Jan 2004 14:54:33 +0000 (14:54 +0000)]
fix some warnings from the Sun compiler
(This used to be commit ebabf72a78f0165521268b73e0fcabe1ea7834fd)

17 years agoRomve debugging assertions (oops...)
Andrew Bartlett [Fri, 9 Jan 2004 02:47:35 +0000 (02:47 +0000)]
Romve debugging assertions (oops...)

Andrew Bartlett
(This used to be commit 7e75a6d681fc63cacc7e5caa7a04568c6019367f)

17 years agoAdd a new type of name lookup 'ads'. This seperates this from normal
Andrew Bartlett [Fri, 9 Jan 2004 02:38:58 +0000 (02:38 +0000)]
Add a new type of name lookup 'ads'.  This seperates this from normal
hostname lookups, and ensures that we don't lookup 'short' (ie NetBIOS)
domain names in DNS.

Andrew Bartlett
(This used to be commit 35f6347a73ce7423adb78c7e95492bb6d98f4c40)

17 years agoUse StrCaseCmp, not strcasecmp. Should fix winbind build on IRIX
Jelmer Vernooij [Thu, 8 Jan 2004 22:53:37 +0000 (22:53 +0000)]
Use StrCaseCmp, not strcasecmp. Should fix winbind build on IRIX
(This used to be commit 65b01f67d5725bc54e6bc19b6e84beef38e372f8)

17 years agofix segfault when sid_ptr == 0 in DsEnumDomainTrusts() reply
Gerald Carter [Thu, 8 Jan 2004 22:21:29 +0000 (22:21 +0000)]
fix segfault when sid_ptr == 0 in DsEnumDomainTrusts() reply
(This used to be commit ba9dc0d9fd3e30a7ddf97b6a4df753db7ba12cc1)

17 years agofix a seg fault caused by abartlet's last checkin; there's no way this could have...
Gerald Carter [Thu, 8 Jan 2004 19:56:40 +0000 (19:56 +0000)]
fix a seg fault caused by abartlet's last checkin; there's no way this could have been tested against an NT4 DC
(This used to be commit 8e8a351cabb502f1a93b219fec064fb4eb094856)

17 years agoWe might not have the 'samba' directory in the samba_3_0 build.
Andrew Bartlett [Thu, 8 Jan 2004 08:44:39 +0000 (08:44 +0000)]
We might not have the 'samba' directory in the samba_3_0 build.

Andrew Bartlett
(This used to be commit a5cf5701e25e93e4e837f7cdc30a8603d289e4a9)

17 years agouse SAFE_FREE(), not free().
Andrew Bartlett [Thu, 8 Jan 2004 08:41:26 +0000 (08:41 +0000)]
use SAFE_FREE(), not free().

Andrew Bartlett
(This used to be commit 595dee660742f8bd5770a5f7aaf3a5d1987dbcfa)

17 years agoThis merges in my 'always use ADS' patch. Tested on a mix of NT and ADS
Andrew Bartlett [Thu, 8 Jan 2004 08:19:18 +0000 (08:19 +0000)]
This merges in my 'always use ADS' patch.  Tested on a mix of NT and ADS
domains, this patch ensures that we always use the ADS backend when
security=ADS, and the remote server is capable.

The routines used for this behaviour have been upgraded to modern Samba
codeing standards.

This is a change in behaviour for mixed mode domains, and if the trusted
domain cannot be reached with our current krb5.conf file, we will show
that domain as disconnected.

This is in line with existing behaviour for native mode domains, and for
our primary domain.

As a consequence of testing this patch, I found that our kerberos error
handling was well below par - we would often throw away useful error
values.  These changes move more routines to ADS_STATUS to return
kerberos errors.

Also found when valgrinding the setup, fix a few memory leaks.

While sniffing the resultant connections, I noticed we would query our
list of trusted domains twice - so I have reworked some of the code to
avoid that.

Andrew Bartlett
(This used to be commit 7c34de8096b86d2869e7177420fe129bd0c7541d)

17 years agoIn tdb_allocate(), we would create a new record by writing a local variable
Andrew Bartlett [Thu, 8 Jan 2004 05:37:23 +0000 (05:37 +0000)]
In tdb_allocate(), we would create a new record by writing a local variable
'newrec' into the tdb.

This was not initialised, so valgrind warned about it.

(Note:  valgrind only makes sense on tdbs with 'mmap = no' in your smb.conf)

Andrew Bartlett
(This used to be commit c9f9d6d3171d720b4ec0ba6af8c0c8ab178cd98b)

17 years agoMake it clearer that the domain here is the domain of the user for
Andrew Bartlett [Thu, 8 Jan 2004 02:57:42 +0000 (02:57 +0000)]
Make it clearer that the domain here is the domain of the user for

Andrew Bartlett
(This used to be commit 7e6cc8f0037f9948230a1e1bd380f30cec5d511e)

17 years agoMove more of winbind to use 'find_our_domain()' rather than the dangerous
Andrew Bartlett [Thu, 8 Jan 2004 02:15:46 +0000 (02:15 +0000)]
Move more of winbind to use 'find_our_domain()' rather than the dangerous

(as find_domain_from_name() can change the data in lp_workgroup())

Andrew Bartlett
(This used to be commit 2e6eaad9ce6a0ad6923b5952ef6cf1c3688b7cfa)

17 years agoThe correct test for 'is our primary domain' is domain->primary
Andrew Bartlett [Thu, 8 Jan 2004 00:55:13 +0000 (00:55 +0000)]
The correct test for 'is our primary domain' is domain->primary
(This used to be commit 703f101136b8e9bbc16f57a37cd9d9d739606a84)

17 years agoMachines are people too!
Andrew Bartlett [Wed, 7 Jan 2004 23:46:47 +0000 (23:46 +0000)]
Machines are people too!

While machine accounts cannot use an NTLM login (NT4 style), they are
otherwise full and valid members of the domain, and expect to be able to
use kerberos to connect to CIFS servers.

This means that the LocalSystem account, used by various services, can
perform things like backups, without the admin needing to enter further

This particular issue (bug 722) has started to come up a lot on the lists.

I have only enabled it for winbindd-based systems, as the macros use use
to call the 'add user script' will strip the $ from the username for
security reasons.

Andrew Bartlett
(This used to be commit 6a9bbd1da3bb961d24e74348fa0b68574022855f)

17 years agoFix for bug #922. Fast path not called for strlower_m() and strupper_m().
Jeremy Allison [Wed, 7 Jan 2004 23:21:36 +0000 (23:21 +0000)]
Fix for bug #922. Fast path not called for strlower_m() and strupper_m().
From (Alexander Bokovoy).
(This used to be commit fac9e6d7125fb9edfade3c92a3cd9e1f2c60cefd)

17 years agoTypo fix.
Rafal Szczesniak [Wed, 7 Jan 2004 22:44:28 +0000 (22:44 +0000)]
Typo fix.

(This used to be commit 5d7f81eea2f3d9ba59eb549a45de030b0a277263)

17 years agoDoxygen comment fix.
Rafal Szczesniak [Wed, 7 Jan 2004 22:43:36 +0000 (22:43 +0000)]
Doxygen comment fix.

(This used to be commit b5e492b8eaf7cefe185d44b6c708f96ff61bd27b)

17 years agoFix from Justin Baugh <> for bugid #948 for
Jeremy Allison [Wed, 7 Jan 2004 21:08:42 +0000 (21:08 +0000)]
Fix from Justin Baugh <> for bugid #948 for
FreeBSD winbindd.
(This used to be commit 7c4d52014e4432c9bd430a8885f0c314312002d5)

17 years agocommiting jra's fix for Exchange clear test auth
Gerald Carter [Wed, 7 Jan 2004 19:57:08 +0000 (19:57 +0000)]
commiting jra's fix for Exchange clear test auth
(This used to be commit 344e113368cb46fc4d26107d1cd276e4c76a6a9b)

17 years agoFix from Luke Howard <lukeh@PADL.COM> for incorrect early free().
Jeremy Allison [Wed, 7 Jan 2004 19:55:01 +0000 (19:55 +0000)]
Fix from Luke Howard <lukeh@PADL.COM> for incorrect early free().
(This used to be commit 8e20c06ed31d9ec10ff0155b1624eee3d60cd006)

17 years agoDon't duplicate pulling the 'IPC' username from secrets.tdb, instead
Andrew Bartlett [Wed, 7 Jan 2004 10:11:24 +0000 (10:11 +0000)]
Don't duplicate pulling the 'IPC' username from secrets.tdb, instead
just use one function for both places.

Andrew Bartlett
(This used to be commit 85da181e8a0ade839f6d595fabdf4cea606f82e1)

17 years agoThere is a German translation of swat -- surprise :-)
Volker Lendecke [Wed, 7 Jan 2004 10:02:10 +0000 (10:02 +0000)]
There is a German translation of swat -- surprise :-)

Fix some msgs

(This used to be commit d42953681731d18aef740cd7dd9919e0f4715645)

17 years agoAdd smbget utility, a simple wget-like utility that uses libsmbclient.
Jelmer Vernooij [Wed, 7 Jan 2004 00:43:52 +0000 (00:43 +0000)]
Add smbget utility, a simple wget-like utility that uses libsmbclient.
Supports recursive downloads and resume, progress indication and shows
estimated time remaining.
(This used to be commit 82bd1b45a4205706b57bae42c7b03974f8b44753)

17 years agoFix segfualt caused by incorrect configuration. If lp_realm() was not set,
Andrew Bartlett [Tue, 6 Jan 2004 23:57:12 +0000 (23:57 +0000)]
Fix segfualt caused by incorrect configuration.  If lp_realm() was not set,
but security=ADS, we would attempt to free the principal name that krb5
never allocated.

Also fix the dump_data() of the session key, now that we use a data_blob to
store that.

Andrew Bartlett
(This used to be commit 4ad67f13404ef0118265ad66d8bdfa256c914ad0)

17 years agoPatch penguin. Cleaning out old mbp patch.
Jeremy Allison [Tue, 6 Jan 2004 22:34:06 +0000 (22:34 +0000)]
Patch penguin. Cleaning out old mbp patch.
(This used to be commit d75db0bf1eee9c4341a3ec14c05f82b364a202b3)

17 years agomore commits logged
Gerald Carter [Tue, 6 Jan 2004 20:56:59 +0000 (20:56 +0000)]
more commits logged
(This used to be commit fd357ab4e5d4bc0661bfbdd10053a5664e8d1a01)

17 years agoWrite bug number like in the rest of the file
Jelmer Vernooij [Tue, 6 Jan 2004 20:03:34 +0000 (20:03 +0000)]
Write bug number like in the rest of the file
(This used to be commit 3c936f1cb58fb0f47e64342f65f72e51b5120387)

17 years agoFix -s option to smbcontrol (#908)
Jelmer Vernooij [Tue, 6 Jan 2004 20:01:48 +0000 (20:01 +0000)]
Fix -s option to smbcontrol (#908)
(This used to be commit 7495395c1cc3b09b27d6eeb7dff6f214701d03d6)

17 years agoremove unused seek_file(); don't hardcode '\' when printing the auth-user
Gerald Carter [Tue, 6 Jan 2004 19:57:14 +0000 (19:57 +0000)]
remove unused seek_file(); don't hardcode '\' when printing the auth-user
(This used to be commit fac5e05ca1b56cb6e3ab6537d0848fa373c00831)

17 years agobumping to 3.0.2pre2
Gerald Carter [Tue, 6 Jan 2004 19:14:22 +0000 (19:14 +0000)]
bumping to 3.0.2pre2
(This used to be commit 52480d6d05c1008a25b4a45cbf7682fe227df83a)

17 years agomore commit logs
Gerald Carter [Tue, 6 Jan 2004 19:05:23 +0000 (19:05 +0000)]
more commit logs
(This used to be commit dc51a4c1f99d5727b5219b2c98586415ee58585a)

17 years ago* making sure contributors are listed in alphabetical order
Gerald Carter [Tue, 6 Jan 2004 18:42:09 +0000 (18:42 +0000)]
* making sure contributors are listed in alphabetical order
* adding jra's fix for bug 815
(This used to be commit 4d07f7dff8a60b4bce0e266a6a3b13d35dbff089)

17 years agoisolate ldap debug messages to the common smbldap_XXX() functions
Gerald Carter [Tue, 6 Jan 2004 18:26:18 +0000 (18:26 +0000)]
isolate ldap debug messages to the common smbldap_XXX() functions
(This used to be commit 7d7a262f45182e67daecdca49df85445c2b9700a)

17 years agoXFS quota patch from Stefan Metzmacher <>.
Jeremy Allison [Tue, 6 Jan 2004 18:13:32 +0000 (18:13 +0000)]
XFS quota patch from Stefan Metzmacher <>.
(This used to be commit cae5f158e583572436a2f4c20d919816d763f93d)

17 years agoUpdates for pread/pwrite code.
Jeremy Allison [Tue, 6 Jan 2004 17:53:34 +0000 (17:53 +0000)]
Updates for pread/pwrite code.
(This used to be commit 53e7d1508efc6e7910d052845f718d19ef307794)

17 years agoCorrectly detect AFS headers on SuSE in /usr/include/afs/afs/
Volker Lendecke [Tue, 6 Jan 2004 15:41:32 +0000 (15:41 +0000)]
Correctly detect AFS headers on SuSE in /usr/include/afs/afs/

(This used to be commit 50be537b19dc6a4c63a58b9c73e6ad354b7c0d89)

17 years agofix case in objectclass name (not that it really matters); patch from Darren Chew...
Gerald Carter [Tue, 6 Jan 2004 14:40:35 +0000 (14:40 +0000)]
fix case in objectclass name (not that it really matters); patch from Darren Chew <>
(This used to be commit 86e0015b06eb9590a6a3e64cb4fe5a88a9f156c2)

17 years agoPatch by Stefan Metzmacher <>:
Andrew Bartlett [Tue, 6 Jan 2004 10:22:13 +0000 (10:22 +0000)]
Patch by Stefan Metzmacher <>:

here's a small fix that fixes the new quota system on irix.

I need to reanable XFS quotas on irix for the new quota system
(Jerry do you want to wait for this for the release ?)

But the old system works and is the default on irix!
(This used to be commit 5d43e00a49afc4cf523a531ae6db1a3a8b86c650)

17 years agoFix typo..
Volker Lendecke [Tue, 6 Jan 2004 07:57:35 +0000 (07:57 +0000)]
Fix typo..

(This used to be commit 651f7cd69c4c808f9fbd096d21c852cb83e058a9)

17 years agoPatch based on work from James Peach <> to convert over to
Jeremy Allison [Tue, 6 Jan 2004 01:22:14 +0000 (01:22 +0000)]
Patch based on work from James Peach <> to convert over to
using pread/pwrite. Modified a little to ensure fsp->pos is correct.
Fix for #889.
(This used to be commit 019aaaf0df091c3f67048f591e70d4353a02bb9b)

17 years agoEnsure that for wbinfo --set-auth-user, we actually use the domain.
Andrew Bartlett [Tue, 6 Jan 2004 00:32:24 +0000 (00:32 +0000)]
Ensure that for wbinfo --set-auth-user, we actually use the domain.

Andrew Bartlett
(This used to be commit 93a5d8079a0291be14517e437f8f0c964c21e91d)

17 years agocifs mount helper merge
Steve French [Mon, 5 Jan 2004 22:18:44 +0000 (22:18 +0000)]
cifs mount helper merge
(This used to be commit 865fcdcb85d47eeff854f4df0aba0c0f3452bdd9)

17 years agoworking on new format for relerase notes in 3.0.2pre1
Gerald Carter [Mon, 5 Jan 2004 21:51:01 +0000 (21:51 +0000)]
working on new format for relerase notes in 3.0.2pre1
(This used to be commit 6770f32c0e9fc3974504bf0cb303ea41beff3d29)

17 years agoFix more cases to ensure that as a server, we don't complain to the client
Andrew Bartlett [Mon, 5 Jan 2004 21:24:27 +0000 (21:24 +0000)]
Fix more cases to ensure that as a server, we don't complain to the client
about our server-side lack of session key.

Andrew Bartlett
(This used to be commit ba33f1e0d5fe2aed3e378c9c23511c0b4d6f7d14)

17 years agoAdded last missing file.
Jeremy Allison [Mon, 5 Jan 2004 21:03:12 +0000 (21:03 +0000)]
Added last missing file.
(This used to be commit ffaf9982dcf9e8d8aec1b3edb79ba7c93bfbb9ef)

17 years agoOops. Broke the build. Added missing files.
Jeremy Allison [Mon, 5 Jan 2004 21:02:37 +0000 (21:02 +0000)]
Oops. Broke the build. Added missing files.
(This used to be commit 52eafc131e26ecc2c4ce8df856c380eb7fd8af69)

17 years agoFix from James Flemer <> to make HAVE_ATTR_LIST linked to
Jeremy Allison [Mon, 5 Jan 2004 21:01:08 +0000 (21:01 +0000)]
Fix from James Flemer <> to make HAVE_ATTR_LIST linked to
(This used to be commit 1b1c216122e4dcf40e4ccaea528a7775521fa618)

17 years agofix inverted check using krb5_kt_resolve() and HAVE_MEMORY_KEYTAB; bug 912
Gerald Carter [Mon, 5 Jan 2004 20:23:56 +0000 (20:23 +0000)]
fix inverted check using krb5_kt_resolve() and HAVE_MEMORY_KEYTAB; bug 912
(This used to be commit 134cf1d546cc46c8a907205ee7be7593cbb524b6)

17 years agoPatch from Stefan (metze) Metzmacher <metze at> to revert to 2.2.x quota...
Jeremy Allison [Mon, 5 Jan 2004 19:36:02 +0000 (19:36 +0000)]
Patch from Stefan (metze) Metzmacher <metze at> to revert to 2.2.x quota methods.


"here's a patch which ports the samba 2.2 samba_linux_quota.h stuff to 3_0.

This is needed because of so many broken quota files outthere.

Please, test this with old, new kernels
(strucr dqblk, struct mem_dqblk, and struct if_dqblk)
, quota.user, aquota.user formats

what is when a user is over soft quota and over hard quotas..."

(This used to be commit 4350aa6ce6cfdaf71cdcfd2aebcdc9560fa7efcf)

17 years agoEnsure we set "always sign" flag if set. We don't currently do anything with
Jeremy Allison [Mon, 5 Jan 2004 19:21:06 +0000 (19:21 +0000)]
Ensure we set "always sign" flag if set. We don't currently do anything with
this but we should log the fact it was negotiated.
(This used to be commit 84d34e32be03ec99ce19520f24bb4daaeeddbbc3)

17 years agoFix warning
Volker Lendecke [Mon, 5 Jan 2004 16:58:37 +0000 (16:58 +0000)]
Fix warning

(This used to be commit 541e6998a06ac523ad794b10f4e7a46951a06726)

17 years agoDon't free the encrypted_session_key early - that causes the subsequent
Andrew Bartlett [Mon, 5 Jan 2004 12:36:21 +0000 (12:36 +0000)]
Don't free the encrypted_session_key early - that causes the subsequent
test for a valid length to fail...

This should fix 'security=server' and hosts-equiv failures picked up by
the build farm.

Andrew Bartlett
(This used to be commit 39311495de3bd0a902f730967f30176db97be05a)

17 years agoshorten some more lines.
Andrew Bartlett [Mon, 5 Jan 2004 12:21:04 +0000 (12:21 +0000)]
shorten some more lines.
(This used to be commit 7e5855dfd27ed9ec1fa924986f1ba02632a0d5a0)

17 years agoTry to keep vl happy - shorten some of these lines.
Andrew Bartlett [Mon, 5 Jan 2004 12:20:15 +0000 (12:20 +0000)]
Try to keep vl happy - shorten some of these lines.
(This used to be commit 3a4c56e4c60854bbd291adc7d321d3869e6dedab)

17 years agoGrumble... grumble... fix the build...
Andrew Bartlett [Mon, 5 Jan 2004 05:07:59 +0000 (05:07 +0000)]
Grumble... grumble... fix the build...
(This used to be commit 687aececa66c2c1ba8e5bc3127d8ca79a97436d1)

17 years agoShow the sid type in name->sid translatons in a way that can be easily
Andrew Bartlett [Mon, 5 Jan 2004 04:26:35 +0000 (04:26 +0000)]
Show the sid type in name->sid translatons in a way that can be easily
understood by humans.

Andrew Bartlett
(This used to be commit 3d91b0a0060f18d49b2fdd9f93ef310e2ea7779d)

17 years agoAlways call the auto-init funciton - this avoids tdb segfaulting under
Andrew Bartlett [Mon, 5 Jan 2004 04:15:55 +0000 (04:15 +0000)]
Always call the auto-init funciton - this avoids tdb segfaulting under
us if we failed to open it earlier.

Andrew Bartlett
(This used to be commit 379368b0bec1f57cc5302b274362ce2f1df0fd9d)

17 years agoCorrectly handle per-pipe NTLMSSP inside a NULL session. Previously we
Andrew Bartlett [Mon, 5 Jan 2004 04:12:40 +0000 (04:12 +0000)]
Correctly handle per-pipe NTLMSSP inside a NULL session.  Previously we
would attempt to supply a password to the 'inside' NTLMSSP, which the
remote side naturally rejected.

Andrew Bartlett
(This used to be commit da408e0d5aa29ca1505c2fd96b32deae9ed940c4)

17 years agoChange our Domain controller lookup routines to more carefully seperate
Andrew Bartlett [Mon, 5 Jan 2004 04:10:28 +0000 (04:10 +0000)]
Change our Domain controller lookup routines to more carefully seperate
DNS names (realms) from NetBIOS domain names.

Until now, we would experience delays as we broadcast lookups for DNS names
onto the local network segments.

Now if DNS comes back negative, we fall straight back to looking up the
short name.

Andrew Bartlett
(This used to be commit 32397c8b01f1dec7b05140d210bb32f836a80ca6)

17 years agoFix typo in RW2 torture test. Closes bugzilla bug #924.
Tim Potter [Mon, 5 Jan 2004 02:57:33 +0000 (02:57 +0000)]
Fix typo in RW2 torture test.  Closes bugzilla bug #924.
(This used to be commit d22313998abff680d38b208588824a1981fe2aa7)

17 years agoAdd const.
Andrew Bartlett [Mon, 5 Jan 2004 02:16:51 +0000 (02:16 +0000)]
Add const.
(This used to be commit aacb817e89d17349003159e1b7c28546babc8559)

17 years agoThere is some memory corruption hidden somewhere in our winbind code. If I
Andrew Bartlett [Mon, 5 Jan 2004 02:12:38 +0000 (02:12 +0000)]
There is some memory corruption hidden somewhere in our winbind code.  If I
could reproduce it, I would fix it, but for now just make sure we always
SAFE_FREE() and set our starting pointers to NULL.

Andrew Bartlett
(This used to be commit c279e178bc122e1e2aa519f7a373a3d93672a3ac)

17 years agoChange (unused) structure parameter for cli_ds_enum_domain_trusts() cleanup.
Andrew Bartlett [Mon, 5 Jan 2004 02:05:19 +0000 (02:05 +0000)]
Change (unused) structure parameter for cli_ds_enum_domain_trusts() cleanup.
(This used to be commit 6e5b084c20b59a86e86445bf6d101cada45da602)

17 years agorpc_client/cli_lsarpc.c:
Andrew Bartlett [Mon, 5 Jan 2004 02:04:37 +0000 (02:04 +0000)]
 - Add const

 - Cleanup function for use

 - Use new utility function ads_sid_to_dn
 - Don't search for 'dn=', rather call the ads_search_retry_dn()

 - Fixup braindamage in cli_ds_enum_domain_trusts():
    - This function was returning a UNISTR2 up to the caller, and
      was doing nasty (invalid, per valgrind) things with memcpy()
    - Create a new structure that represents this informaiton in a useful way
      and use talloc.

Andrew Bartlett
(This used to be commit 06c3f15aa166bb567d8be0a8bc4b095b167ab371)

17 years agoFix for bug 707, getent group for huge ads groups (>1500 members)
Andrew Bartlett [Mon, 5 Jan 2004 01:48:21 +0000 (01:48 +0000)]
Fix for bug 707, getent group for huge ads groups (>1500 members)
This introduces range retrieval of ADS attributes.

VL rewrote most of G√ľnther's patch, partly to remove code duplication and
partly to get the retrieval of members in one rush, not interrupted by the
lookups for the DN.

I rewrote that patch, to ensure that we can keep an eye on the USN
(sequence number) of the entry - this allows us to ensure the read was

In particular, the range retrieval is now generic, for strings.  It
could easily be made generic for any attribute type, if need be.

Andrew Bartlett
(This used to be commit 131bb928f19c7b1f582c4ad9ac42e5f3d9dfb622)

17 years agoI'm not quite sure what happened here - but replace the ads_sid_to_dn
Andrew Bartlett [Mon, 5 Jan 2004 01:06:56 +0000 (01:06 +0000)]
I'm not quite sure what happened here - but replace the ads_sid_to_dn
function with one that compiles.

Andrew Bartlett
(This used to be commit 0d5b0345a60741ae50f6770d9cecf698864cd209)

17 years agoWe can't possilby get 'ok' here, as the if statement above just checked for it.
Andrew Bartlett [Mon, 5 Jan 2004 00:15:34 +0000 (00:15 +0000)]
We can't possilby get 'ok' here, as the if statement above just checked for it.
(This used to be commit cf4454969434d3026c57ac11c0528dc4cea9c77a)

17 years agoMake arbitary binary data unsigned char.
Andrew Bartlett [Mon, 5 Jan 2004 00:14:12 +0000 (00:14 +0000)]
Make arbitary binary data unsigned char.
(This used to be commit a78b0205622f10e0acfdf54915df6864608ab928)

17 years agoAdd a utilty function for converting a sid to a DN.
Andrew Bartlett [Mon, 5 Jan 2004 00:13:00 +0000 (00:13 +0000)]
Add a utilty function for converting a sid to a DN.

Andrew Bartlett
(This used to be commit 49a7a3fd17cfeef439e2049a51dbfcbc037f1a93)

17 years agoMake it clear that we cannot sign if we don't have a session key.
Andrew Bartlett [Mon, 5 Jan 2004 00:11:35 +0000 (00:11 +0000)]
Make it clear that we cannot sign if we don't have a session key.
(This used to be commit a2f6dec05b3b30292ec3e42808dc89f1bf5c7ab4)