samba.git
13 years agosmb2: Add missing dependency on NDR_DFSBLOBS.
Jelmer Vernooij [Sun, 10 Oct 2010 17:15:41 +0000 (19:15 +0200)]
smb2: Add missing dependency on NDR_DFSBLOBS.

13 years agolibrpc: Remove unnecessary dependency on libsamba-hostconfig.
Jelmer Vernooij [Sun, 10 Oct 2010 21:00:32 +0000 (23:00 +0200)]
librpc: Remove unnecessary dependency on libsamba-hostconfig.

13 years agodsdb/schema: Move some dsdb_dn functions that are schema-specific.
Jelmer Vernooij [Sun, 10 Oct 2010 19:37:58 +0000 (21:37 +0200)]
dsdb/schema: Move some dsdb_dn functions that are schema-specific.

13 years agontvfs_ipc: add missing dependency on dcerpc_common.
Jelmer Vernooij [Sun, 10 Oct 2010 20:57:40 +0000 (22:57 +0200)]
ntvfs_ipc: add missing dependency on dcerpc_common.

13 years agolibsecurity-common: Add missing dependency on libndr.
Jelmer Vernooij [Sun, 10 Oct 2010 20:56:58 +0000 (22:56 +0200)]
libsecurity-common: Add missing dependency on libndr.

13 years agolibcli-auth: Remove unnecessary dependency on libsamba-hostconfig.
Jelmer Vernooij [Sun, 10 Oct 2010 20:56:38 +0000 (22:56 +0200)]
libcli-auth: Remove unnecessary dependency on libsamba-hostconfig.

13 years agodsdb modules: Split ridalloc out of common helpers, because of dependency loops.
Jelmer Vernooij [Sun, 10 Oct 2010 22:29:18 +0000 (00:29 +0200)]
dsdb modules: Split ridalloc out of common helpers, because of dependency loops.

13 years agorpc_ndr_netlogon: Add missing dependency on tevent.
Jelmer Vernooij [Sun, 10 Oct 2010 22:22:42 +0000 (00:22 +0200)]
rpc_ndr_netlogon: Add missing dependency on tevent.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 10 23:04:13 UTC 2010 on sn-devel-104

13 years agosamdb: Remove dependency on unknown subsystem.
Jelmer Vernooij [Sun, 10 Oct 2010 21:59:04 +0000 (23:59 +0200)]
samdb: Remove dependency on unknown subsystem.

13 years agoutil: Link headers to correct subsystem, fix formatting.
Jelmer Vernooij [Sun, 10 Oct 2010 16:39:07 +0000 (18:39 +0200)]
util: Link headers to correct subsystem, fix formatting.

13 years agodsdb: add missing dependency on samba_socket.
Jelmer Vernooij [Sun, 10 Oct 2010 21:00:59 +0000 (23:00 +0200)]
dsdb: add missing dependency on samba_socket.

13 years agoldb-samba: Rename samdb_relative_path to ldb_relative_path, as it's not samdb-specific.
Jelmer Vernooij [Sun, 10 Oct 2010 21:45:23 +0000 (23:45 +0200)]
ldb-samba: Rename samdb_relative_path to ldb_relative_path, as it's not samdb-specific.

13 years agodsdb: Move attr_in_list to SAMDB_COMMON to avoid circular dependency between SAMDB_CO...
Jelmer Vernooij [Sun, 10 Oct 2010 15:02:10 +0000 (17:02 +0200)]
dsdb: Move attr_in_list to SAMDB_COMMON to avoid circular dependency between SAMDB_COMMON and DSDB_MODULE_HELPERS.

13 years agogensec: Support building without any linked-in modules.
Jelmer Vernooij [Sun, 10 Oct 2010 14:46:55 +0000 (16:46 +0200)]
gensec: Support building without any linked-in modules.

13 years agoidmap: Add missing dependency on ldbsamba.
Jelmer Vernooij [Sun, 10 Oct 2010 16:42:14 +0000 (18:42 +0200)]
idmap: Add missing dependency on ldbsamba.

13 years agosecrets: Add missing dependency on ldbsamba.
Jelmer Vernooij [Sun, 10 Oct 2010 16:41:57 +0000 (18:41 +0200)]
secrets: Add missing dependency on ldbsamba.

13 years agocldapd: Add missing dependency on ldbsamba.
Jelmer Vernooij [Sun, 10 Oct 2010 20:57:18 +0000 (22:57 +0200)]
cldapd: Add missing dependency on ldbsamba.

13 years agoldb-samba: Add ldb_wrap_add, remove last schema reference from ldb_wrap.
Jelmer Vernooij [Sun, 10 Oct 2010 21:25:38 +0000 (23:25 +0200)]
ldb-samba: Add ldb_wrap_add, remove last schema reference from ldb_wrap.

13 years agoldb-samba: Split up ldb_wrap_connect() a bit.
Jelmer Vernooij [Sun, 10 Oct 2010 15:34:21 +0000 (17:34 +0200)]
ldb-samba: Split up ldb_wrap_connect() a bit.

13 years agoldb-samba: Add convenience function for doing a Samba-style LDB init.
Jelmer Vernooij [Sun, 10 Oct 2010 15:15:11 +0000 (17:15 +0200)]
ldb-samba: Add convenience function for doing a Samba-style LDB init.

13 years agosamdb: Add flags argument to samdb_connect().
Jelmer Vernooij [Sun, 10 Oct 2010 15:00:45 +0000 (17:00 +0200)]
samdb: Add flags argument to samdb_connect().

13 years agosamdb: Handle schema setup in samdb, not in more generic ldbsamba.
Jelmer Vernooij [Sun, 10 Oct 2010 14:56:55 +0000 (16:56 +0200)]
samdb: Handle schema setup in samdb, not in more generic ldbsamba.

13 years agotls: add missing dependency on util_tevent.
Jelmer Vernooij [Sun, 10 Oct 2010 21:08:12 +0000 (23:08 +0200)]
tls: add missing dependency on util_tevent.

13 years agowafsamba: Fix init function when building modules as shared objects.
Jelmer Vernooij [Sun, 10 Oct 2010 20:52:35 +0000 (22:52 +0200)]
wafsamba: Fix init function when building modules as shared objects.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
13 years agosocket_wrapper: Make it work on freebsd for udp packets
Stefan Metzmacher [Sun, 10 Oct 2010 10:29:08 +0000 (12:29 +0200)]
socket_wrapper: Make it work on freebsd for udp packets

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Oct 10 12:57:00 UTC 2010 on sn-devel-104

13 years agobuild: make make tests SCREEN=1 work on freebsd
Matthieu Patou [Sat, 9 Oct 2010 23:12:46 +0000 (10:12 +1100)]
build: make make tests SCREEN=1 work on freebsd

13 years agos4-libnet_vampire: Remove unused self_corrected_schema
Kamen Mazdrashki [Sun, 3 Oct 2010 01:29:08 +0000 (04:29 +0300)]
s4-libnet_vampire: Remove unused self_corrected_schema

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sun Oct 10 10:40:38 UTC 2010 on sn-devel-104

13 years agos4-libnet_vampire use a linked list to handle schema objects pending conversion
Andrew Bartlett [Sun, 26 Sep 2010 22:50:54 +0000 (08:50 +1000)]
s4-libnet_vampire use a linked list to handle schema objects pending conversion

13 years agos4-vampire: Optimize Schema decoding conversion
Kamen Mazdrashki [Sat, 25 Sep 2010 10:26:03 +0000 (13:26 +0300)]
s4-vampire: Optimize Schema decoding conversion

memmove() is removed and I am using the beginning
of the list for storage for failed objects

13 years agos4-vampire: Initial implementation for multi-pass schema decoding from DRS data
Kamen Mazdrashki [Fri, 24 Sep 2010 19:56:36 +0000 (22:56 +0300)]
s4-vampire: Initial implementation for multi-pass schema decoding from DRS data

We can't decode all schema object in just one (or even two)
passes when Schema tree has more levels of inheritance.

13 years agos4-dsdb-repl: Print what the error code for failure is
Kamen Mazdrashki [Thu, 23 Sep 2010 21:47:37 +0000 (00:47 +0300)]
s4-dsdb-repl: Print what the error code for failure is

13 years agos4-dsdb: Make dsdb_setup_sorted_accessors() public
Kamen Mazdrashki [Thu, 23 Sep 2010 21:46:50 +0000 (00:46 +0300)]
s4-dsdb: Make dsdb_setup_sorted_accessors() public

We are going to need it while converting DRS schema.

13 years agowafsamba: Clarify needs_python argument name, use pyembed/pyext where
Jelmer Vernooij [Sun, 10 Oct 2010 02:25:50 +0000 (04:25 +0200)]
wafsamba: Clarify needs_python argument name, use pyembed/pyext where
applicable.

Allow using both pyembed and pyext, to prevent unresolved symbols.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 10 03:54:01 UTC 2010 on sn-devel-104

13 years agoheimdal_build: Fix dependencies for hx509.
Jelmer Vernooij [Sun, 10 Oct 2010 02:04:09 +0000 (04:04 +0200)]
heimdal_build: Fix dependencies for hx509.

13 years agosubunithelper: Don't access 'message' attribute directly as it deprecated
Kamen Mazdrashki [Sun, 10 Oct 2010 01:07:56 +0000 (03:07 +0200)]
subunithelper: Don't access 'message' attribute directly as it deprecated

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Oct 10 01:50:09 UTC 2010 on sn-devel-104

13 years agotalloc: Fix #include line in manpage.
Jelmer Vernooij [Sat, 9 Oct 2010 13:11:14 +0000 (15:11 +0200)]
talloc: Fix #include line in manpage.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Oct  9 13:53:25 UTC 2010 on sn-devel-104

13 years agoland: Use temp dir if /memdisk is not available.
Jelmer Vernooij [Wed, 6 Oct 2010 16:10:42 +0000 (18:10 +0200)]
land: Use temp dir if /memdisk is not available.

13 years agos4-test-msds_intid: Verify ATTIDs for Linked Attributes
Kamen Mazdrashki [Sat, 9 Oct 2010 02:40:32 +0000 (05:40 +0300)]
s4-test-msds_intid: Verify ATTIDs for Linked Attributes

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sat Oct  9 03:43:34 UTC 2010 on sn-devel-104

13 years agos4-test-msds_intid: Simplify parameters for _make_error_message() function
Kamen Mazdrashki [Sat, 9 Oct 2010 01:22:24 +0000 (04:22 +0300)]
s4-test-msds_intid: Simplify parameters for _make_error_message() function

so it can be used in more places - when checking for
Linked Attributes ATTIDs for instance

13 years agoMore neccessary const.
Jeremy Allison [Fri, 8 Oct 2010 23:51:24 +0000 (16:51 -0700)]
More neccessary const.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Oct  9 01:47:25 UTC 2010 on sn-devel-104

13 years agoAdd some const. Needed for my SD work.
Jeremy Allison [Fri, 8 Oct 2010 23:50:40 +0000 (16:50 -0700)]
Add some const. Needed for my SD work.

Jeremy

13 years agopytalloc: Fix warning that we are subtracting void* pointers
Kamen Mazdrashki [Fri, 8 Oct 2010 01:19:30 +0000 (04:19 +0300)]
pytalloc: Fix warning that we are subtracting void* pointers

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Fri Oct  8 23:36:54 UTC 2010 on sn-devel-104

13 years agos3: Hang the isilon kernel oplocks off the NULL context
Volker Lendecke [Thu, 7 Oct 2010 20:01:28 +0000 (22:01 +0200)]
s3: Hang the isilon kernel oplocks off the NULL context

All I see is a fd_event that does not need a special destructor.

Tim, Steven, I've added the #error as well for you to remove after review.

Thanks,

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Oct  8 20:48:11 UTC 2010 on sn-devel-104

13 years agos3: Hang the irix kernel oplocks off the NULL ctx
Volker Lendecke [Thu, 7 Oct 2010 19:50:17 +0000 (21:50 +0200)]
s3: Hang the irix kernel oplocks off the NULL ctx

Just a fd_event to be cleaned up. The pipe is closed implicitly.

13 years agos3: Hang the linux kernel oplocks off the NULL ctx
Volker Lendecke [Thu, 7 Oct 2010 19:48:38 +0000 (21:48 +0200)]
s3: Hang the linux kernel oplocks off the NULL ctx

The destructor that is called removes the signal handler. But at process
exit the signal handling is lost anyway.

13 years agos3: Call printer_list_parent_init in the parent
Volker Lendecke [Thu, 7 Oct 2010 19:42:08 +0000 (21:42 +0200)]
s3: Call printer_list_parent_init in the parent

Simo, please check!

13 years agos3: Remove talloc_autofree_context() from get_printer_list_db()
Volker Lendecke [Thu, 7 Oct 2010 19:38:26 +0000 (21:38 +0200)]
s3: Remove talloc_autofree_context() from get_printer_list_db()

Another db that does not need explicit closing

13 years agos3: Remove talloc_autofree_context() from loadparm.c
Volker Lendecke [Thu, 7 Oct 2010 19:29:19 +0000 (21:29 +0200)]
s3: Remove talloc_autofree_context() from loadparm.c

None of these uses requires a special destructor

13 years agos3: Add a little test for the echo responder
Volker Lendecke [Wed, 6 Oct 2010 16:46:43 +0000 (18:46 +0200)]
s3: Add a little test for the echo responder

13 years agos3: Implement echo_TestSleep
Volker Lendecke [Wed, 6 Oct 2010 16:45:41 +0000 (18:45 +0200)]
s3: Implement echo_TestSleep

13 years agotevent: Do not use talloc_autofree_context
Volker Lendecke [Fri, 24 Sep 2010 17:13:05 +0000 (19:13 +0200)]
tevent: Do not use talloc_autofree_context

13 years agoMove talloc_enable_null_tracking() to the s3 daemons
Volker Lendecke [Fri, 24 Sep 2010 16:45:52 +0000 (18:45 +0200)]
Move talloc_enable_null_tracking() to the s3 daemons

13 years agos4:ldap.py - split it up and move SAM related stuff to sam.py
Matthias Dieter Wallnöfer [Thu, 7 Oct 2010 07:42:07 +0000 (09:42 +0200)]
s4:ldap.py - split it up and move SAM related stuff to sam.py

ldap.py would still need some additional split-up but it's a start.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Oct  8 14:05:18 UTC 2010 on sn-devel-104

13 years agos4:ldap_server: rewrite to socket layer to use tstream
Stefan Metzmacher [Wed, 22 Sep 2010 12:24:03 +0000 (14:24 +0200)]
s4:ldap_server: rewrite to socket layer to use tstream

This should make our sasl and tls handling much more robust
against partial sent pdus.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Oct  8 11:55:26 UTC 2010 on sn-devel-104

13 years agos4:lib/tls: buffer writes in tstream_tls_push_function()
Stefan Metzmacher [Fri, 8 Oct 2010 08:19:07 +0000 (10:19 +0200)]
s4:lib/tls: buffer writes in tstream_tls_push_function()

This works arround bugs in gnutls_handshake(),
which diesn't handle EAGAIN correctly, when they use the
push function.

Thanks to Marcel.Ritter@rrze.uni-erlangen.de and
Matthieu Patou <mat@samba.org> for the debugging work
on bug #7218.

metze

13 years agos4:lib/tls: make more clear what the immediate event is for
Stefan Metzmacher [Fri, 8 Oct 2010 07:39:49 +0000 (09:39 +0200)]
s4:lib/tls: make more clear what the immediate event is for

metze

13 years agos4:lib/tls: fix enabled logic in tstream_tls_params_server()
Stefan Metzmacher [Thu, 7 Oct 2010 09:16:48 +0000 (11:16 +0200)]
s4:lib/tls: fix enabled logic in tstream_tls_params_server()

metze

13 years agos3-waf: slowly getting modules to match how they look like in old build.
Günther Deschner [Thu, 7 Oct 2010 19:28:04 +0000 (21:28 +0200)]
s3-waf: slowly getting modules to match how they look like in old build.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Oct  8 09:31:01 UTC 2010 on sn-devel-104

13 years agos3: Fix input check in is_encrypted_packet
Volker Lendecke [Wed, 6 Oct 2010 15:40:58 +0000 (17:40 +0200)]
s3: Fix input check in is_encrypted_packet

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Oct  8 07:40:52 UTC 2010 on sn-devel-104

13 years agoFix bug 7716 - acl_xattr and acl_tdb modules don't store unmodified copies of securit...
Jeremy Allison [Thu, 7 Oct 2010 23:56:36 +0000 (16:56 -0700)]
Fix bug 7716 - acl_xattr and acl_tdb modules don't store unmodified copies of security descriptors.

As pointed out by an OEM, the code within smbd/posix_acl.c, even though passed
a const pointer to a security descriptor, still modifies the ACE entries within
it (which are not const pointers).

This means ACLs stored in the extended attribute by the acl_xattr module have
already been modified by the POSIX acl layer, and are not the original intent
of storing the "unmodified" ACL from the client.

Use dup_sec_desc to make a copy of the incoming ACL on talloc_tos() - that
is what is then modified inside smbd/posix_acl.c, leaving the original ACL
to be correctly stored in the xattr.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct  8 00:37:53 UTC 2010 on sn-devel-104

13 years agos3: Fix the async echo responder for netbios keepalives
Volker Lendecke [Wed, 6 Oct 2010 16:24:13 +0000 (18:24 +0200)]
s3: Fix the async echo responder for netbios keepalives

This fixes a crash in the echo responder when the client started to send the
NetBIOS-Level 0x85-style keepalive packets. We did not correctly check the
packet length, so the code writing the signing seqnum overwrote memory after
the malloc'ed area for the 4 byte keepalive packet.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct  7 19:47:35 UTC 2010 on sn-devel-104

13 years agoFile winattr test
Abhidnya P Chirmule [Thu, 30 Sep 2010 10:56:25 +0000 (16:26 +0530)]
File winattr test

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Oct  7 16:51:19 UTC 2010 on sn-devel-104

13 years agoFile BirthTime test
Abhidnya P Chirmule [Wed, 29 Sep 2010 12:30:49 +0000 (18:00 +0530)]
File BirthTime test

13 years agos3-spoolss: make it possible to have and announce a [prnproc$] share on the printserver.
Günther Deschner [Sat, 2 Oct 2010 20:17:46 +0000 (22:17 +0200)]
s3-spoolss: make it possible to have and announce a [prnproc$] share on the printserver.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct  7 16:09:14 UTC 2010 on sn-devel-104

13 years agos3-rpcclient: add openprinter_ex command.
Günther Deschner [Sat, 2 Oct 2010 19:54:32 +0000 (21:54 +0200)]
s3-rpcclient: add openprinter_ex command.

Guenther

13 years agos4-smbtorture: re-arrange openprinterex tests.
Günther Deschner [Sat, 2 Oct 2010 19:53:54 +0000 (21:53 +0200)]
s4-smbtorture: re-arrange openprinterex tests.

Guenther

13 years agos3-docs: fix typo in "add port command" smb.conf manpage.
Günther Deschner [Sun, 3 Oct 2010 04:55:34 +0000 (06:55 +0200)]
s3-docs: fix typo in "add port command" smb.conf manpage.

Guenther

13 years agosamr: for correctness, rename samr_RidTypeArray to samr_RidAttrArray.
Günther Deschner [Thu, 7 Oct 2010 11:01:29 +0000 (13:01 +0200)]
samr: for correctness, rename samr_RidTypeArray to samr_RidAttrArray.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct  7 12:04:32 UTC 2010 on sn-devel-104

13 years agos4-samr: Fix dcesrv_samr_QueryGroupMember.
Günther Deschner [Thu, 7 Oct 2010 10:45:45 +0000 (12:45 +0200)]
s4-samr: Fix dcesrv_samr_QueryGroupMember.

Guenther

13 years agos3-samr: fix _samr_QueryGroupMember().
Günther Deschner [Thu, 7 Oct 2010 10:45:04 +0000 (12:45 +0200)]
s3-samr: fix _samr_QueryGroupMember().

that array contains attributes, not sid types.

Guenther

13 years agoRevert "s4:ldap_server: rewrite to socket layer to use tstream"
Stefan Metzmacher [Tue, 5 Oct 2010 05:47:51 +0000 (07:47 +0200)]
Revert "s4:ldap_server: rewrite to socket layer to use tstream"

This reverts commit b53fbc75acc525f2e2450370e704a62791271788.

There are problems with problems with broken gnutls versions.

We can readd this once we have the needed configure checks to
detect the bug in gnutls. See https://bugzilla.samba.org/show_bug.cgi?id=7218.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Oct  7 10:31:18 UTC 2010 on sn-devel-104

13 years agos4:dsdb/common/util_samr.c - use an LDB constant for result checking
Matthias Dieter Wallnöfer [Wed, 6 Oct 2010 18:45:36 +0000 (20:45 +0200)]
s4:dsdb/common/util_samr.c - use an LDB constant for result checking

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct  7 07:40:31 UTC 2010 on sn-devel-104

13 years agos4:dsdb/common/util.c - provide message set functions for integer types
Matthias Dieter Wallnöfer [Wed, 6 Oct 2010 17:11:58 +0000 (19:11 +0200)]
s4:dsdb/common/util.c - provide message set functions for integer types

They will be used by the samldb LDB module

13 years agoscript: improvements to bisect-test.py
Andrew Tridgell [Thu, 7 Oct 2010 03:20:15 +0000 (14:20 +1100)]
script: improvements to bisect-test.py

- allow control of all the commands (eg. specify configure command)

- do a bisect reset at the end

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct  7 04:11:21 UTC 2010 on sn-devel-104

13 years agowaf: fixed exit status of test suites
Andrew Tridgell [Thu, 7 Oct 2010 01:25:42 +0000 (12:25 +1100)]
waf: fixed exit status of test suites

use RUN_COMMAND() to handle signal errors and exit status

13 years ago s3: Adding TCP_KEEPALIVE_THRESHOLD and TCP_KEEPALIVE_ABORT_THRESHOLD to the list...
Ira Cooper [Wed, 6 Oct 2010 16:24:27 +0000 (12:24 -0400)]
s3: Adding TCP_KEEPALIVE_THRESHOLD and TCP_KEEPALIVE_ABORT_THRESHOLD to the list of accepted socket settings.

    These are both exclusive to Solaris/OpenSolaris.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct  7 00:26:39 UTC 2010 on sn-devel-104

13 years agotevent: Only call handlers that ask for events
Volker Lendecke [Wed, 6 Oct 2010 16:47:08 +0000 (18:47 +0200)]
tevent: Only call handlers that ask for events

The s3 libsmbclient puts two different handlers on a single fd for readability
and writability. With select this works fine, however without this patch we
unconditionally call the write handler even if the socket is only readable. We
should have called the read handler instead.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct  6 23:40:24 UTC 2010 on sn-devel-104

13 years agoFix crash in SMB2 rename found by gentest. We must always have an lcomp
Jeremy Allison [Tue, 5 Oct 2010 23:47:23 +0000 (16:47 -0700)]
Fix crash in SMB2 rename found by gentest. We must always have an lcomp
in the destination struct for a rename, so set the flag appropriately.

Jeremy.

13 years agomaintainers: delete the old MAINTAINERS file
Andrew Tridgell [Wed, 6 Oct 2010 22:18:31 +0000 (09:18 +1100)]
maintainers: delete the old MAINTAINERS file

this contains some quite obsolete information

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 22:58:52 UTC 2010 on sn-devel-104

13 years agomaintainers: added initial MAINTAINERS.txt
Andrew Tridgell [Wed, 6 Oct 2010 21:23:22 +0000 (08:23 +1100)]
maintainers: added initial MAINTAINERS.txt

initially with no subsystems maintained. Some initial maintainers will
be added soon after discussion.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 22:07:01 UTC 2010 on sn-devel-104

13 years agos3: Make the write end of the echo responder pipe non-blocking
Volker Lendecke [Wed, 6 Oct 2010 13:05:59 +0000 (15:05 +0200)]
s3: Make the write end of the echo responder pipe non-blocking

Without this, we can get a writable pipe end, but the writev call on the pipe
will block.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Oct  6 13:57:30 UTC 2010 on sn-devel-104

13 years agos3-build: use the simpler "make bin/smbtorture" for s4 torture
Andrew Tridgell [Wed, 6 Oct 2010 12:13:14 +0000 (23:13 +1100)]
s3-build: use the simpler "make bin/smbtorture" for s4 torture

and the same for bin/ndrdump

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 12:58:21 UTC 2010 on sn-devel-104

13 years agowaf: allow for commands like "make bin/smbtorture"
Andrew Tridgell [Wed, 6 Oct 2010 12:12:44 +0000 (23:12 +1100)]
waf: allow for commands like "make bin/smbtorture"

I finally worked out the GNU make syntax for this

13 years agos3-spoolss: added another intermittent failure to knownfail
Andrew Tridgell [Wed, 6 Oct 2010 11:06:46 +0000 (22:06 +1100)]
s3-spoolss: added another intermittent failure to knownfail

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 11:55:00 UTC 2010 on sn-devel-104

13 years agoautobuild: only add autobuild.log if it exists
Andrew Tridgell [Wed, 6 Oct 2010 09:15:48 +0000 (20:15 +1100)]
autobuild: only add autobuild.log if it exists

this makes running autobuild on other than sn-devel easier

13 years agowaf: fixed some python3.x portability issues
Andrew Tridgell [Wed, 6 Oct 2010 09:11:01 +0000 (20:11 +1100)]
waf: fixed some python3.x portability issues

these have crept into the tree over time. Maybe we should add testing
of a range of python versions to autobuild?

13 years agowaf: update to waf version 1.5.19
Andrew Tridgell [Wed, 6 Oct 2010 07:55:38 +0000 (18:55 +1100)]
waf: update to waf version 1.5.19

this includes a number of perforance improvements and bug
fixes. Thanks to Thomas for all the recent improvements!

13 years agos4:samldb LDB module - remove "type" parameter of "samldb_fill_object"
Matthias Dieter Wallnöfer [Wed, 6 Oct 2010 09:37:28 +0000 (11:37 +0200)]
s4:samldb LDB module - remove "type" parameter of "samldb_fill_object"

It's a bit redundant given that we have the "type" variable on "ac".

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Oct  6 10:20:45 UTC 2010 on sn-devel-104

13 years agoidtree: fix right shift of signed ints, crash on large ids on AIX
Rusty Russell [Tue, 5 Oct 2010 02:36:19 +0000 (13:06 +1030)]
idtree: fix right shift of signed ints, crash on large ids on AIX

Right-shifting signed integers in undefined; indeed it seems that on
AIX with their compiler, doing a 30-bit shift on (INT_MAX-200) gives
0, not 1 as we might expect.

The obvious fix is to make id and oid unsigned: l (level count) is also
logically unsigned.

(Note: Samba doesn't generally get to ids > 1 billion, but ctdb does)

Reported-by: Chris Cowan <cc@us.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@samba.org>
Autobuild-Date: Wed Oct  6 08:31:09 UTC 2010 on sn-devel-104

13 years agos4-heimdal: disable using the system compile_et for now
Andrew Tridgell [Wed, 6 Oct 2010 07:03:07 +0000 (18:03 +1100)]
s4-heimdal: disable using the system compile_et for now

just checking that compile_et exists isn't enough. It has to actually
work. Quite a few build farm systems have /usr/bin/compile_et, but it
gets link errors when you try to use it (missing symbols et_list_lock
and et_list_unlock)

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 07:48:16 UTC 2010 on sn-devel-104

13 years agowaf: fixed the problem with com_err on Ubuntu 9.04
Andrew Tridgell [Wed, 6 Oct 2010 04:23:58 +0000 (15:23 +1100)]
waf: fixed the problem with com_err on Ubuntu 9.04

this changes CHECK_BUNDLED_SYSTEM() to honor the checkfunctions and
headers options even for libraries found with pkgconfig.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Oct  6 05:06:42 UTC 2010 on sn-devel-104

13 years agos4-test: Fix PYTHONPATH for samba4.schemaInfo.python(dc) test
Kamen Mazdrashki [Wed, 6 Oct 2010 02:12:58 +0000 (05:12 +0300)]
s4-test: Fix PYTHONPATH for samba4.schemaInfo.python(dc) test

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Oct  6 02:54:56 UTC 2010 on sn-devel-104

13 years agoFix crash in SMB2 rename found by gentest. We must always have an lcomp
Jeremy Allison [Tue, 5 Oct 2010 23:47:23 +0000 (16:47 -0700)]
Fix crash in SMB2 rename found by gentest. We must always have an lcomp
in the destination struct for a rename, so set the flag appropriately.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct  6 00:29:51 UTC 2010 on sn-devel-104

13 years agoheimdal-build: Require com_err library to provide com_right_r function.
Jelmer Vernooij [Tue, 5 Oct 2010 15:15:14 +0000 (17:15 +0200)]
heimdal-build: Require com_err library to provide com_right_r function.

13 years agoland: Fix stage description during failure.
Jelmer Vernooij [Tue, 5 Oct 2010 10:43:09 +0000 (12:43 +0200)]
land: Fix stage description during failure.

13 years agoland: Print out failed test in case of subunit failures.
Jelmer Vernooij [Tue, 5 Oct 2010 10:39:30 +0000 (12:39 +0200)]
land: Print out failed test in case of subunit failures.

13 years agoheimdal-com_err: fix the build for systems with older 'com_err' library
Kamen Mazdrashki [Tue, 5 Oct 2010 20:08:24 +0000 (23:08 +0300)]
heimdal-com_err: fix the build for systems with older 'com_err' library

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Oct  5 21:36:41 UTC 2010 on sn-devel-104

13 years agoselftest: make it more obvious we only expect the printjob tests to fail.
Günther Deschner [Tue, 5 Oct 2010 20:21:54 +0000 (22:21 +0200)]
selftest: make it more obvious we only expect the printjob tests to fail.

Guenther

13 years agoRevert "libndr: fix "excess elements in struct initializer" warning."
Günther Deschner [Tue, 5 Oct 2010 19:50:21 +0000 (21:50 +0200)]
Revert "libndr: fix "excess elements in struct initializer" warning."

This reverts commit a416ff26d6ada4ee96bf3963866f67d5788162d1.

13 years agos3-waf: add slightly different mkbuildoptions awk script for waf.
Günther Deschner [Tue, 5 Oct 2010 16:08:51 +0000 (18:08 +0200)]
s3-waf: add slightly different mkbuildoptions awk script for waf.

This allows to run make test (w/o smbtorture4 for now) using waf.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct  5 18:24:55 UTC 2010 on sn-devel-104