samba.git
12 years agonet: Don't crash on invalid command line options.
Kai Blin [Fri, 20 Jun 2008 22:07:21 +0000 (00:07 +0200)]
net: Don't crash on invalid command line options.

This backs out the workaround Jerry added in
4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd.
Thanks for the catch.
(This used to be commit 20e0bb4800938863cb0aac1a19473748132043fc)

12 years agoFix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Jeremy Allison [Fri, 20 Jun 2008 20:23:31 +0000 (13:23 -0700)]
Fix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Fix from hkurma@datadomain.com.
Jeremy.
(This used to be commit 8c87a4319cc83f55fb105cae81a8efbc3fb5b98b)

12 years agoFix bug #5533. Winbindd fails to cope correctly with a workgroup name containing...
Jeremy Allison [Fri, 20 Jun 2008 19:49:14 +0000 (12:49 -0700)]
Fix bug #5533. Winbindd fails to cope correctly with a workgroup name containing a '.'.
Jeremy.
(This used to be commit 96325ff44dc404a68d4ebd423cf78210ec3ff902)

12 years agonet: Fix crash when specifying invalid options on the command line
root [Thu, 19 Jun 2008 17:14:32 +0000 (12:14 -0500)]
net: Fix crash when specifying invalid options on the command line
(This used to be commit 4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd)

12 years agoRemove current_user references from nttrans.c
Volker Lendecke [Thu, 19 Jun 2008 16:48:10 +0000 (18:48 +0200)]
Remove current_user references from nttrans.c
(This used to be commit 5f8a5e68ea166fbeda3af6e5ec381ec09d06f0f6)

12 years agoRemove current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:46:57 +0000 (18:46 +0200)]
Remove current_user references from trans2.c

This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function.
(This used to be commit 5595cdf837edb82db69a3e57bcf3108be7feeeb8)

12 years agoRemove some current_user references from trans2.c
Volker Lendecke [Thu, 19 Jun 2008 16:36:54 +0000 (18:36 +0200)]
Remove some current_user references from trans2.c
(This used to be commit 4c31cc0b62f532eafdc44398b29b773ad8cb0646)

12 years agoRemove reference to current_user from reply.c
Volker Lendecke [Thu, 19 Jun 2008 16:21:41 +0000 (18:21 +0200)]
Remove reference to current_user from reply.c
(This used to be commit e895e44cc7d675d128430fb53c138e5e8736e59f)

12 years agoWrap the unix token info in a unix_user_token in auth_serversupplied_info
Volker Lendecke [Thu, 19 Jun 2008 14:54:12 +0000 (16:54 +0200)]
Wrap the unix token info in a unix_user_token in auth_serversupplied_info

No functional change, this is a preparation for more current_user ref removal
(This used to be commit dcaedf345e62ab74ea87f0a3fa1e3199c75c5445)

12 years agoRemove the "current_user" arg from fsp_belongs_conn
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from fsp_belongs_conn

fsp_belongs_conn only used the vuid struct member anyway, and this is available
in the smb_request structure as well.
(This used to be commit 64e9372ab997739d46669c0cc4a4c6edb11d5e64)

12 years agoRemove the "current_user" arg from check_fsp
Volker Lendecke [Thu, 19 Jun 2008 14:31:59 +0000 (16:31 +0200)]
Remove the "current_user" arg from check_fsp

check_fsp only used the vuid struct member anyway, and this is available in the
smb_request structure as well.
(This used to be commit 8d364c4c3311b406847158fc37e9208d298cf8ba)

12 years agoloadparm: use the return value of the special handlers in lp_load().
Michael Adam [Thu, 19 Jun 2008 15:21:04 +0000 (17:21 +0200)]
loadparm: use the return value of the special handlers in lp_load().

Up to now, the bool return value was silently ignored.

Michael
(This used to be commit c65d425fec964bc0b8778b596615a8bcce0378aa)

12 years agoloadparm: don't treat a missing include file as an error in handle_include().
Michael Adam [Thu, 19 Jun 2008 15:20:22 +0000 (17:20 +0200)]
loadparm: don't treat a missing include file as an error in handle_include().

Michael
(This used to be commit a8ef8870beb91fcd2745aa59de6c59b49ea00e39)

12 years agotestsuite: enable the testparm_s3 tests.
Michael Adam [Thu, 19 Jun 2008 15:19:21 +0000 (17:19 +0200)]
testsuite: enable the testparm_s3 tests.

Michael
(This used to be commit 0f5c13e5735990f4325f98156a7dc410276372fe)

12 years agotestsuite: add a testparm_s3 test script.
Michael Adam [Thu, 19 Jun 2008 15:14:39 +0000 (17:14 +0200)]
testsuite: add a testparm_s3 test script.

This is a first testparm/lp_load test that runs testparm on a couple
of configuration files. The main purpose for now is to test the options
that have special handlers (to check whether the handlers succeed).
In particular, all the Macro expansions that are available via
alloc_sub_basic() are tested with the include handler. This is to
catch such crashbugs as #5548 where %m expansion led to a segfault.

The tests now are very simple. Just check if testparm completes
successfully on the given config files. This can (and should) be
elaborated in the future.

Michael
(This used to be commit eb28146d40b8a8bc2c20b8d222abf191ea178d5a)

12 years agotestsuite: update introductory comment to test_net_regsistry.sh
Michael Adam [Thu, 19 Jun 2008 11:52:49 +0000 (13:52 +0200)]
testsuite: update introductory comment to test_net_regsistry.sh

This is now used to test rpc and local access depending on
command line parameters.

Michael
(This used to be commit 73c17b630317b5019e5d5f2b989b8de081a73e07)

12 years agoRemove current_user_info reference from vfs_recycle.c
Volker Lendecke [Thu, 19 Jun 2008 13:48:05 +0000 (15:48 +0200)]
Remove current_user_info reference from vfs_recycle.c
(This used to be commit fdc03c0a5ba0da4fbc4610880e06150c11d4c737)

12 years agoRemove current_user_info reference from vfs_fake_perms.c
Volker Lendecke [Thu, 19 Jun 2008 13:46:44 +0000 (15:46 +0200)]
Remove current_user_info reference from vfs_fake_perms.c
(This used to be commit a227181e8d2ed0824a323a3d4b4cfda5e438f8ce)

12 years agoRemove current_user_info reference from vfs_expand_msdfs.c
Volker Lendecke [Thu, 19 Jun 2008 13:44:15 +0000 (15:44 +0200)]
Remove current_user_info reference from vfs_expand_msdfs.c
(This used to be commit 05a66980a9b5a7c6222ceb038d819d23fd172186)

12 years agocurrent_user is not used in vfs_aixacl2.c
Volker Lendecke [Thu, 19 Jun 2008 13:43:52 +0000 (15:43 +0200)]
current_user is not used in vfs_aixacl2.c
(This used to be commit 407136abdf45ad832382dba44e1c9a3b4f253f09)

12 years agoRWX on a file does not imply DELETE access
Volker Lendecke [Tue, 17 Jun 2008 14:22:43 +0000 (16:22 +0200)]
RWX on a file does not imply DELETE access

Without this the changed checks in can_delete_file_in_directory give DELETE
access where there is none. So we can end up granting the ntcreate&x preparing
the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at
close time later, which in turn does *not* give the access denied error message
in the Windows GUI.

can_delete_file_in_directory will grant access now by looking at the directory
permissions.
(This used to be commit 51b5364c2afb3a18df4bec2bc1624760ccc01676)

12 years agoFix checks in can_delete_file_in_directory()
Volker Lendecke [Thu, 19 Jun 2008 12:53:46 +0000 (14:53 +0200)]
Fix checks in can_delete_file_in_directory()

With at least NFSv4 ACLs around the write permission for the owner is a bogus
check if we can delete a file in a directory. Like in Windows, there are two
ways which can grant us such: First, the DELETE permission on the file itself,
or if that does not help, the DELETE_CHILD permission on the directory. It
might be a bit more code that runs, but essentially we should end up with the
same set of syscalls in the non-acl case.
(This used to be commit daa9b056645a45edfb3a70e3536011ebe5678970)

12 years agoRemove some code
Volker Lendecke [Thu, 19 Jun 2008 10:03:31 +0000 (12:03 +0200)]
Remove some code

Did not measure it, but I think a single write is better than a read and a
conditional branch
(This used to be commit abe1bed665ad8d1dbf9177dcbb9344b25df9594c)

12 years agoFix typo
Volker Lendecke [Thu, 19 Jun 2008 09:59:55 +0000 (11:59 +0200)]
Fix typo
(This used to be commit 2eef2c682c18ad37b78214c755b9dd7c8b607cb8)

12 years agoFix the build on FreeBSD 4.6.2
Volker Lendecke [Thu, 19 Jun 2008 07:50:34 +0000 (09:50 +0200)]
Fix the build on FreeBSD 4.6.2
(This used to be commit 4f50cb63e9b565ae0747127baa651a1a1874298b)

12 years agoFix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy Allison [Wed, 18 Jun 2008 19:56:36 +0000 (12:56 -0700)]
Fix 'make distclean'. delheaders: no longer exists as a dependency.
Jeremy.
(This used to be commit 8b26afdcddc75d3b9a97309757a97314b406cb59)

12 years agoRemove prototype of unimplemented smbc_chown() function.
Derrell Lipman [Wed, 18 Jun 2008 15:00:46 +0000 (11:00 -0400)]
Remove prototype of unimplemented smbc_chown() function.
(This used to be commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)

12 years agoRevert "Fix a memleak in svcctl_init_keys()"
Volker Lendecke [Wed, 18 Jun 2008 14:30:37 +0000 (16:30 +0200)]
Revert "Fix a memleak in svcctl_init_keys()"

This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc.

This one is very strange: I need to investigate why valgrind showed it as
leaking, and why in my initial tests this did not fail.
(cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c)
(This used to be commit b1e8e5d173cdaa3fb9c1fb1d9aacf8e665bc5d61)

12 years agoFix Bug #5548 (segfauls in handle_include with %m macro expansion).
Michael Adam [Wed, 18 Jun 2008 12:50:53 +0000 (14:50 +0200)]
Fix Bug #5548 (segfauls in handle_include with %m macro expansion).

In alloc_sub_basic, when expanding '%m', substitute "" instead of
NULL for remote_machine when this is NULL. Else a NULL string
is returned.

Michael
(This used to be commit c65b456c6a145d15b7fd27a2a3440a0709fc3277)

12 years agofile_access: add a function header comment for can_access_file_acl().
Michael Adam [Tue, 17 Jun 2008 22:06:46 +0000 (00:06 +0200)]
file_access: add a function header comment for can_access_file_acl().

Michael
(This used to be commit 7d5fb873bde0a84de522650945effeaf602c759e)

12 years agosmbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()
Michael Adam [Tue, 17 Jun 2008 22:02:28 +0000 (00:02 +0200)]
smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()

This is not needed anymore since user_can_access_file_acl() ist used.

Michael
(This used to be commit 3c349f773a52e3de693d3bb79f5060c9f1e01e41)

12 years agofile_access: remove unneeded stat buf parameter from can_access_file_acl().
Michael Adam [Tue, 17 Jun 2008 21:58:49 +0000 (23:58 +0200)]
file_access: remove unneeded stat buf parameter from can_access_file_acl().

This is a security descriptor level function only.

Michael
(This used to be commit 5931540fa1681f026fed42df387d17e43c493c47)

12 years agonet sam: fix typo in comment
Michael Adam [Tue, 17 Jun 2008 21:57:26 +0000 (23:57 +0200)]
net sam: fix typo in comment

Michael
(This used to be commit b9f6904044889328ded229b7ff04d31218f4fef8)

12 years agonet sam: fix typo in debug message.
Michael Adam [Tue, 17 Jun 2008 21:56:42 +0000 (23:56 +0200)]
net sam: fix typo in debug message.

Michael
(This used to be commit 6d7f64c3481d3aa7ec6b0d468f3d6218f62cd92e)

12 years agotestsuite: give admin rights to testuser only for the "net rpc registry" test.
Michael Adam [Tue, 17 Jun 2008 21:54:15 +0000 (23:54 +0200)]
testsuite: give admin rights to testuser only for the "net rpc registry" test.

Remove the user from BUILTIN\Administrators at the end of the tests.
Note: BUILTIN\Administrators is not deletet at the end because that
functionality is not implemented.

Michael
(This used to be commit 1734f9305a38eff05f0147d9c7391ef34085e7b2)

12 years agotestsuite: don't give the testuser administrative rights globally.
Michael Adam [Tue, 17 Jun 2008 21:51:23 +0000 (23:51 +0200)]
testsuite: don't give the testuser administrative rights globally.

It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite
understood yet. Somhow loosing rights fails when the user
belogns to BUILTIN\Administrators at some point.

Michael
(This used to be commit 9fe99c69f35b005b66c1eacb5d999cc73f1bb521)

12 years agoFix a brown paper bag segfault in clitar
Volker Lendecke [Tue, 17 Jun 2008 19:08:56 +0000 (21:08 +0200)]
Fix a brown paper bag segfault in clitar

Thanks to "No Body is Perfect" from gmail, whoever that is :-)

Volker
(cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4)
(This used to be commit b8e1d62b8e8f724b855c8ab9801abee0b2791e36)

12 years agorpcclient: add more generic internal dscracknames call.
Günther Deschner [Wed, 11 Jun 2008 08:12:29 +0000 (10:12 +0200)]
rpcclient: add more generic internal dscracknames call.

Guenther
(This used to be commit 2351b0845ca78707901daca6a6d0425959c6f28e)

12 years agonetapi: use NetUserEnum filter in example code.
Günther Deschner [Mon, 9 Jun 2008 09:02:27 +0000 (11:02 +0200)]
netapi: use NetUserEnum filter in example code.

Guenther
(This used to be commit ad105177686da823ef9cce1c1bedaf0f84a49b8c)

12 years agonetapi: add NetUserEnum filter constants to public headers.
Günther Deschner [Tue, 17 Jun 2008 11:13:10 +0000 (13:13 +0200)]
netapi: add NetUserEnum filter constants to public headers.

Guenther
(This used to be commit 32a66131eb56e1c66b89e348141047c6b98cf35e)

12 years agonetapi: implement NetUserEnum filters.
Günther Deschner [Mon, 9 Jun 2008 09:01:59 +0000 (11:01 +0200)]
netapi: implement NetUserEnum filters.

Guenther
(This used to be commit 0bd69df7704789888eba2a07aba505dce037c4eb)

12 years agore-run make idl.
Günther Deschner [Mon, 9 Jun 2008 09:01:09 +0000 (11:01 +0200)]
re-run make idl.

Guenther
(This used to be commit 383636aaca0e59fef8a010ba697e5edf9ce2648b)

12 years agonetapi: add NetUserEnum filter constants to IDL.
Günther Deschner [Mon, 9 Jun 2008 09:00:23 +0000 (11:00 +0200)]
netapi: add NetUserEnum filter constants to IDL.

Guenther
(This used to be commit 12669b12c25a64b02c0e49b3ef96cf317992b18c)

12 years agonetapi: some IDL cosmetics.
Günther Deschner [Mon, 9 Jun 2008 08:59:23 +0000 (10:59 +0200)]
netapi: some IDL cosmetics.

Guenther
(This used to be commit 4fd6bc61d0034659c5a89bf2eae188a04a3b41eb)

12 years agonetapi: add NetRemoteTOD example code.
Günther Deschner [Tue, 17 Jun 2008 11:18:02 +0000 (13:18 +0200)]
netapi: add NetRemoteTOD example code.

Guenther
(This used to be commit 2b82779a401dd1d14f5842872ac37b2454efc92b)

12 years agonetapi: implement NetRemoteTOD().
Günther Deschner [Fri, 6 Jun 2008 14:41:19 +0000 (16:41 +0200)]
netapi: implement NetRemoteTOD().

Guenther
(This used to be commit 76877680a8a6400bc2d3b5e3b788b7d5fc683850)

12 years agonetapi: make NetRemoteTOD() headers public.
Günther Deschner [Fri, 6 Jun 2008 14:44:35 +0000 (16:44 +0200)]
netapi: make NetRemoteTOD() headers public.

Guenther
(This used to be commit 1262ab1843a8a8cb794f6bbfb113bd2d99ffba22)

12 years agonetapi: add NetRemoteTOD() skeleton.
Günther Deschner [Fri, 6 Jun 2008 11:50:39 +0000 (13:50 +0200)]
netapi: add NetRemoteTOD() skeleton.

Guenther
(This used to be commit 78bc98cb55e36ef175f9c0f6fcd943781a514005)

12 years agore-run make idl.
Günther Deschner [Fri, 6 Jun 2008 10:51:12 +0000 (12:51 +0200)]
re-run make idl.

Guenther
(This used to be commit 782ab0f1c1c0957a1111a76c2c1ea7bd99d38311)

12 years agonetapi: add NetRemoteTOD() to IDL.
Günther Deschner [Fri, 6 Jun 2008 10:50:02 +0000 (12:50 +0200)]
netapi: add NetRemoteTOD() to IDL.

Guenther
(This used to be commit 8dd1a5fabffaea847a348d1467a75d005a16b0bd)

12 years agonet_vampire: add error and result_message to samsync_context.
Günther Deschner [Tue, 17 Jun 2008 17:49:58 +0000 (19:49 +0200)]
net_vampire: add error and result_message to samsync_context.

Guenther
(This used to be commit e0b117200441f842fbc11cc817ab2cde4d63a22e)

12 years agonet_vampire: add domain_name to samsync_context.
Günther Deschner [Tue, 17 Jun 2008 16:02:03 +0000 (18:02 +0200)]
net_vampire: add domain_name to samsync_context.

Guenther
(This used to be commit 7e7f07ec59d23e909809ed32adc8fc399826310d)

12 years agolibads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.
Günther Deschner [Tue, 17 Jun 2008 14:20:29 +0000 (16:20 +0200)]
libads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.

Guenther
(This used to be commit cb7ace209c2051ae02647188715fa6ee324c2bf6)

12 years agoclikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.
Günther Deschner [Tue, 17 Jun 2008 15:58:38 +0000 (17:58 +0200)]
clikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.

Guenther
(This used to be commit ec86852fc6ce2d88ad5835c8fcb337c68fd6f6bc)

12 years agodsgetdcname: allow to use NULL mem_ctx.
Günther Deschner [Tue, 17 Jun 2008 14:18:50 +0000 (16:18 +0200)]
dsgetdcname: allow to use NULL mem_ctx.

Guenther
(This used to be commit d20353d30c2e08a6c6d67ae8b8c2faa26004249c)

12 years agolibads: fix logic error in ads_get_kvno().
Günther Deschner [Tue, 17 Jun 2008 14:17:03 +0000 (16:17 +0200)]
libads: fix logic error in ads_get_kvno().

Guenther
(This used to be commit 132b038581a1a91b4e70c7c44f97f52866609812)

12 years agoFix a memleak in svcctl_init_keys()
Volker Lendecke [Tue, 17 Jun 2008 14:06:42 +0000 (16:06 +0200)]
Fix a memleak in svcctl_init_keys()
(This used to be commit 675bb53398ba29c53d2dcf3c7122cf4770c2f938)

12 years agoFix a segfault in wbcLookupRids
Volker Lendecke [Tue, 17 Jun 2008 13:17:22 +0000 (15:17 +0200)]
Fix a segfault in wbcLookupRids

The done: part could access uninitialized memory if intermediate
BAIL_ON_WBC_ERROR fire.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 31f4c33dcc744e81be54389756378e25aa2bb75e)
(This used to be commit 5b12d8aa510689114e5413be5afe6aeb6ec2d9db)

12 years agoFix a segfault in wbcLookupSid
Volker Lendecke [Tue, 17 Jun 2008 12:53:07 +0000 (14:53 +0200)]
Fix a segfault in wbcLookupSid

If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain
and *name have not been initialized yet. So the cleanup routine in the done:
part of the routine (which did not check for domain!=NULL etc) would access
uninitialized memory.

Jerry, please check!

Thanks,

Volker
(cherry picked from commit 3d7e0cc40b1992f4555807acec4f00450e30e2de)
(This used to be commit ac5ba26bb0488c3fb95072d84898c02b72c5b819)

12 years agoMerge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into 3-3-abartlet
Andrew Bartlett [Tue, 17 Jun 2008 12:46:34 +0000 (22:46 +1000)]
Merge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into 3-3-abartlet
(This used to be commit a09ed6016a41a9ed45716579e59a646545054f63)

12 years agoWithout stdlib.h we don't get a prototype for free().
Andrew Bartlett [Tue, 17 Jun 2008 12:45:29 +0000 (22:45 +1000)]
Without stdlib.h we don't get a prototype for free().

This test fails if GCC emits any warnings (presumably to detect the
function propertly), but unless we include this message then free()
fail.  Why we need to call free in a configure test is probably
something to blame on valgrind...

Andrew Bartlett
(This used to be commit d013f6fadc3e80fabb4a1784207dabc84f9b7dc2)

12 years agoReplace a very unusual variable declaration by a more conventional one
Volker Lendecke [Tue, 17 Jun 2008 12:31:07 +0000 (14:31 +0200)]
Replace a very unusual variable declaration by a more conventional one
(This used to be commit 9c1f334af3111e93bb8dceb661e1bc5519aa94c6)

12 years agoman pages: Move 'smbsh' man page to the examples directory.
Karolin Seeger [Tue, 17 Jun 2008 11:18:17 +0000 (13:18 +0200)]
man pages: Move 'smbsh' man page to the examples directory.

smbsh.c is located in the examples directory. It does not make sense
to install a man page without installing the tool itself.

This fixes bug #4724.

Karolin
(This used to be commit 797ed744b15c94fa4831d9796b40bb0ab5df55b7)

12 years agoFix a memleak in wbcAuthenticateUserEx()
Volker Lendecke [Tue, 17 Jun 2008 11:00:13 +0000 (13:00 +0200)]
Fix a memleak in wbcAuthenticateUserEx()
(cherry picked from commit 72b381689af9cae83ab08532cffd0188f2da4807)
(This used to be commit 20110ee5f181168dc1cbc08b7c22820d68204960)

12 years agoRevert "Fix a memleak caused by a crappy get_sorted_dc_list() API"
Volker Lendecke [Tue, 17 Jun 2008 10:21:03 +0000 (12:21 +0200)]
Revert "Fix a memleak caused by a crappy get_sorted_dc_list() API"

This reverts commit 2ea03a1e95a30e321e390bef9408a1215711de07.
(This used to be commit 80c2e8295a00c3d88372b55b81d03b455feb69b2)

12 years agoRevert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"
Volker Lendecke [Tue, 17 Jun 2008 10:20:54 +0000 (12:20 +0200)]
Revert "Fix a memleak in ads_find_dc() in case get_sorted_dc_list() fails"

This reverts commit df8d089bc63c2a52cbdf3504cded8df620a59902.
(This used to be commit 342f8858200ed7c446516c270e1b4284d92010d8)

12 years agonetapi: Fix Bug #5545 (libnetapi_init without $USER)
Günther Deschner [Tue, 17 Jun 2008 08:31:44 +0000 (10:31 +0200)]
netapi: Fix Bug #5545 (libnetapi_init without $USER)

Based on patch from Erik van Pienbroek.

Guenther
(This used to be commit 71f4cf773022525ba617f09c495dbff97f8eb2d5)

12 years agonet_vampire: fix samsync_process_database().
Günther Deschner [Tue, 17 Jun 2008 08:38:07 +0000 (10:38 +0200)]
net_vampire: fix samsync_process_database().

Turns out the password hashes are not rid encrypted in the samsync reply.

Guenther
(This used to be commit 7d8d60bcbae79f3cdd55b27217145ffbd19f161d)

12 years agonet_vampire: fix build warning.
Günther Deschner [Tue, 17 Jun 2008 08:36:53 +0000 (10:36 +0200)]
net_vampire: fix build warning.

Guenther
(This used to be commit eb4232fec05cd87ea85a781b84a3fbe85f469703)

12 years agonet_vampire: use generic output filename and use correct argv element.
Günther Deschner [Mon, 16 Jun 2008 11:49:05 +0000 (13:49 +0200)]
net_vampire: use generic output filename and use correct argv element.

Guenther
(This used to be commit e0843e631e379645296a5fe34dfc83bc265ebef3)

12 years agonet_vampire: move ldif code out of net_rpc_samsync.c
Günther Deschner [Mon, 16 Jun 2008 10:37:57 +0000 (12:37 +0200)]
net_vampire: move ldif code out of net_rpc_samsync.c

Guenther
(This used to be commit 1d5758ec3a5160e5649242c42f6e4a7b39eb6199)

12 years agonet_vampire: move some samsync functions to libnet.
Günther Deschner [Mon, 16 Jun 2008 10:09:08 +0000 (12:09 +0200)]
net_vampire: move some samsync functions to libnet.

Guenther
(This used to be commit b3b6af0a3e25fab0a14c9c802dbabd3d03448ebe)

12 years agoAdd some debug to notify
Volker Lendecke [Tue, 17 Jun 2008 08:46:20 +0000 (10:46 +0200)]
Add some debug to notify
(This used to be commit 4394235378f85ccb911d662d95f1545a14240bdf)

12 years agoRemove references to SVN.
Karolin Seeger [Tue, 17 Jun 2008 08:36:51 +0000 (10:36 +0200)]
Remove references to SVN.

Karolin
(This used to be commit 9d69a809e370f98057e514a3c755b0b86ee5f610)

12 years agoRemove reference to current_user from modules/nfs4_acls.c .
Michael Adam [Mon, 16 Jun 2008 21:50:17 +0000 (23:50 +0200)]
Remove reference to current_user from modules/nfs4_acls.c .

Michael
(This used to be commit 50fbfa03483de0059d85967dc96f2896e55e6d04)

12 years agoidmap: Fix typos in comments.
Karolin Seeger [Tue, 17 Jun 2008 08:30:19 +0000 (10:30 +0200)]
idmap: Fix typos in comments.

Karolin
(This used to be commit 94a4d7fa3209eb668161b8110af6f877b4833fa7)

12 years agoFix typo.
Karolin Seeger [Tue, 17 Jun 2008 07:44:21 +0000 (09:44 +0200)]
Fix typo.

arguements -> arguments

Karolin
(This used to be commit 16b5b772d216d10613d433884634b1215efbd6e6)

12 years agowinbind cache: Don't create SN cache entries during name-to-sid queries.
Karolin Seeger [Mon, 16 Jun 2008 13:21:28 +0000 (15:21 +0200)]
winbind cache: Don't create SN cache entries during name-to-sid queries.

Clients can request name-to-sid queries for different combinations of
upper and lower case names. We don't want to create the reverse caching
entries for each combination used.

This avoids inconsistent answers on sid-to-name queries.

Please review!

Karolin
(This used to be commit b58e4f6b3d73294d8448c0dff4341183c52e5b7c)

12 years agoFix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
Volker Lendecke [Mon, 16 Jun 2008 11:27:16 +0000 (13:27 +0200)]
Fix bug 5500 -- thanks to mathion at thorrovydeti.com for reporting
(cherry picked from commit 996c3ce6f0dbe79b0679ae30afd873c24fe5b1eb)
(This used to be commit 1f86c7a2a19e66948c9b51572d3c078b6e03ef52)

12 years agoAdd forgotten protoypes
Volker Lendecke [Sun, 15 Jun 2008 16:43:37 +0000 (18:43 +0200)]
Add forgotten protoypes
(This used to be commit dee60935d443bd215e384e626d1114ae65c1a62d)

12 years agoRemove the current_user references from open.c
Volker Lendecke [Sun, 15 Jun 2008 11:41:16 +0000 (13:41 +0200)]
Remove the current_user references from open.c

current_user_info was "only" used in a debug msg, and current_user.ut.uid is
also available via conn->server_info
(This used to be commit d0386914ff0f7b0f1edc3302fdc6a25f211712fa)

12 years agoRemove the current_user reference from fake_file.c
Volker Lendecke [Sun, 15 Jun 2008 11:37:53 +0000 (13:37 +0200)]
Remove the current_user reference from fake_file.c

The current vuid is not only available there, it is also in the current
smb_request structure.
(This used to be commit c8fd5eef32a86888c7a28317f0fdf717a26b7d4c)

12 years agoRemove unused "extern struct current_user" from dir.c
Volker Lendecke [Sun, 15 Jun 2008 09:40:33 +0000 (11:40 +0200)]
Remove unused "extern struct current_user" from dir.c
(This used to be commit b92cfd19b459caad34229dfe941cf15fd14a5ce0)

12 years agoRemove the reference to current_user from file_access.c
Volker Lendecke [Sun, 15 Jun 2008 09:39:31 +0000 (11:39 +0200)]
Remove the reference to current_user from file_access.c

conn holds the current user info
(This used to be commit 093bc5f2b33ebf90e04bc17e51b1695b1b932bf2)

12 years agoFix an uninitialized variable found by the IBM checker
Volker Lendecke [Sat, 14 Jun 2008 22:22:47 +0000 (00:22 +0200)]
Fix an uninitialized variable found by the IBM checker

BAIL_ON_PTR_ERROR jumps to done: which will access extra_data before it's
initialized.

Stefan, please check!

Volker
(cherry picked from commit b59636f78d351ed6d52c4a9fdccdb7850388526c)
(This used to be commit 5663587e5e4703f9e3ff6d78d1f3248053ccd4c0)

12 years agoFix group parsing in libwbclient's copy_group_entry()
Volker Lendecke [Sat, 14 Jun 2008 22:14:27 +0000 (00:14 +0200)]
Fix group parsing in libwbclient's copy_group_entry()

This (also) fixes a flaw pointed out by the IBM checker. When verifying that I
found out that the parsing was not working as I would have expected it to.

Jerry, please check!
(cherry picked from commit c2c7790155ab02e1e351caf2bed192ce72913663)
(This used to be commit 26c05a52b73763dad5ad0525dab6e20014c3f8d6)

12 years agoMove connection-specific vuid cache clear to uid.c
Volker Lendecke [Sat, 14 Jun 2008 14:59:07 +0000 (16:59 +0200)]
Move connection-specific vuid cache clear to uid.c
(This used to be commit 1025f687910ce40283c7344ed67ebd5bf31217b7)

12 years agoSlight refactoring for check_user_ok: It only needs vuid and server_info
Volker Lendecke [Sat, 14 Jun 2008 14:55:02 +0000 (16:55 +0200)]
Slight refactoring for check_user_ok: It only needs vuid and server_info
(This used to be commit 68944ea1ea7a0a63b08cbfc703f5ee29d2627696)

12 years agoGroup the access checks together in check_user_ok()
Volker Lendecke [Sat, 14 Jun 2008 14:46:25 +0000 (16:46 +0200)]
Group the access checks together in check_user_ok()
(This used to be commit 45662b5e8b3c7bc39cb33c5d7deb7e9a91f30a8b)

12 years agoConsistently use snum in check_user_ok
Volker Lendecke [Sat, 14 Jun 2008 14:43:03 +0000 (16:43 +0200)]
Consistently use snum in check_user_ok

Most already used it, these two still used SNUM(conn), where the only caller of
this routine (change_to_user) had set snum = SNUM(conn).
(This used to be commit b14e59bfdbfb62494002e22d0665c4d420484245)

12 years agoCompare the pointer "vuser" to NULL, not 0
Volker Lendecke [Sat, 14 Jun 2008 14:35:22 +0000 (16:35 +0200)]
Compare the pointer "vuser" to NULL, not 0
(This used to be commit 5c916549f002d5e4e06f24d396a2bdca73d384c7)

12 years agoUse the correct cups-devel test for HAVE_IPRINT also
Volker Lendecke [Sat, 14 Jun 2008 08:59:11 +0000 (10:59 +0200)]
Use the correct cups-devel test for HAVE_IPRINT also
(This used to be commit a42d7e1146e7469062ead2c8f22f549a48154e03)

12 years agoCorrectly check for presence of cups-devel
Volker Lendecke [Sat, 14 Jun 2008 08:31:11 +0000 (10:31 +0200)]
Correctly check for presence of cups-devel

On SuSE at least cups-config belongs to cups-libs which does not contain the
headers which are in cups-devel.
(This used to be commit 2408d2493f7c6e0beee58febd547516bbeb0929d)

12 years agonet_vampire: rename process_database to samsync_process_database.
Günther Deschner [Fri, 13 Jun 2008 20:33:46 +0000 (22:33 +0200)]
net_vampire: rename process_database to samsync_process_database.

Guenther
(This used to be commit cf382a87602a63368587ffa2c95b774f2f97c21b)

12 years agonet_vampire: fix ldif_init_context().
Günther Deschner [Fri, 13 Jun 2008 19:57:32 +0000 (21:57 +0200)]
net_vampire: fix ldif_init_context().

Guenther
(This used to be commit 94d45b1bb97ac2b6025d429389993ac43044f5b8)

12 years agonet_vampire: split out rpc_vampire_ldif().
Günther Deschner [Fri, 13 Jun 2008 19:46:59 +0000 (21:46 +0200)]
net_vampire: split out rpc_vampire_ldif().

Guenther
(This used to be commit bcc6d3a0ebdcb904b5a2a4de63d9ed7415e9bb33)

12 years agonet_vampire: add samsync_init_context().
Günther Deschner [Fri, 13 Jun 2008 19:25:53 +0000 (21:25 +0200)]
net_vampire: add samsync_init_context().

Guenther
(This used to be commit 63ca4414b62657983c27d2930483aa56f9c78ccf)

12 years agonet_vampire: add samsync_debug_str().
Günther Deschner [Fri, 13 Jun 2008 19:11:55 +0000 (21:11 +0200)]
net_vampire: add samsync_debug_str().

Guenther
(This used to be commit bbfe5bcaf5ec5d06ffd110ab362ea3f228867603)

12 years agonet_vampire: restructure internal code more.
Günther Deschner [Thu, 12 Jun 2008 10:35:46 +0000 (12:35 +0200)]
net_vampire: restructure internal code more.

Guenther
(This used to be commit 9557504d70fe57098914da131b39212faf4f0a7d)

12 years agonet_vampire: start using talloc for the ldif vampire code.
Günther Deschner [Wed, 11 Jun 2008 00:29:58 +0000 (02:29 +0200)]
net_vampire: start using talloc for the ldif vampire code.

Guenther
(This used to be commit ae179e4f3faccbf2c9f19b6f070f5daf87cdfc50)