samba.git
14 years agoProper fix for #6898 - Samba duplicates file content on appending. Pointed out by...
Jeremy Allison [Mon, 23 Nov 2009 23:01:34 +0000 (15:01 -0800)]
Proper fix for #6898 - Samba duplicates file content on appending. Pointed out by Volker.Restores the pathname handling for FILE_FLAG_POSIX_SEMANTICS but still prevents the O_APPEND problems. Jeremy.
(cherry picked from commit f8bd0559ada056722d7d5ae0286753e7c591650b)
(cherry picked from commit 45bbbb04fb9a8ff8eaa3b64c8cae42c5b8a77027)

14 years agoFix bug #6898 - Samba duplicates file content on appending
Jeremy Allison [Mon, 23 Nov 2009 18:09:47 +0000 (10:09 -0800)]
Fix bug #6898 - Samba duplicates file content on appending
Clients using a Windows open call should not be able to set
FILE_FLAG_POSIX_SEMANTICS in an open.
Jeremy.
(cherry picked from commit 7ebe5b16416a3a09ff8840ab84079fde022a957c)
(cherry picked from commit b0fc15e36714302cd398c4da52673fd1b4361fba)

14 years agos3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever
Volker Lendecke [Mon, 23 Nov 2009 12:58:23 +0000 (13:58 +0100)]
s3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever
(cherry picked from commit 7009361f391176c8e9e3a6fac3fbf5d7dab7fcb9)

14 years agos3: Move a variable declaration to its only use
Volker Lendecke [Mon, 23 Nov 2009 10:54:19 +0000 (11:54 +0100)]
s3: Move a variable declaration to its only use
(cherry picked from commit e6e439f0a4d6d1b9ffb9c5b055f5fecec3259795)

14 years agos3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.
Günther Deschner [Wed, 18 Nov 2009 14:39:52 +0000 (15:39 +0100)]
s3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.

Guenther
(cherry picked from commit 800d6b7820bb949588a799f2835a3d6c07815571)
(cherry picked from commit 4eb7c5472f84edd298cd0fc8fdffa6cfd8702304)

14 years agos3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.
Günther Deschner [Tue, 17 Nov 2009 11:55:45 +0000 (12:55 +0100)]
s3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.

Guenther
(cherry picked from commit 6364c271c4daff94c641eb9e7030f3c9a7ff1ced)
(cherry picked from commit 4d640c449f74ebabb8d1d4003719a5b2735006e9)

14 years agos3-printing: use spoolss types and structs while getting and deleting drivers.
Günther Deschner [Tue, 17 Nov 2009 11:54:02 +0000 (12:54 +0100)]
s3-printing: use spoolss types and structs while getting and deleting drivers.

Guenther
(cherry picked from commit ec56895bdec90cc671a0d562749b3caf161dbdf8)
(cherry picked from commit 450a644e462073a371a8e465c16abf74fd0abdfe)

14 years agos3-printing: use spoolss types and structs while adding drivers.
Günther Deschner [Mon, 16 Nov 2009 14:52:31 +0000 (15:52 +0100)]
s3-printing: use spoolss types and structs while adding drivers.

Guenther
(cherry picked from commit 68cc1166d96ac81abce78a7eb60b7b86d0eb4eda)
(cherry picked from commit 6de2a26cc1c18b08555ff42513c7f2a685feea55)

14 years agos4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.
Günther Deschner [Fri, 20 Nov 2009 15:33:29 +0000 (16:33 +0100)]
s4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.

Guenther
(cherry picked from commit d66b7d80d5ae1a0bf2e3d1e6718f569726da7734)
(cherry picked from commit 9dcb99af64eca362873220d5f03d04d63cf2b0de)

14 years agos3-spoolss: fix spoolss_EnumPrinterKey client and server code.
Günther Deschner [Fri, 20 Nov 2009 15:34:00 +0000 (16:34 +0100)]
s3-spoolss: fix spoolss_EnumPrinterKey client and server code.

Guenther
(cherry picked from commit d464151f3b47c675664f464b1645ca85de663655)
(cherry picked from commit f8d0eae87453015b9fabc511a09079ea9c14b265)

14 years agospoolss: fix spoolss_EnumPrinterKey IDL.
Günther Deschner [Fri, 20 Nov 2009 11:57:13 +0000 (12:57 +0100)]
spoolss: fix spoolss_EnumPrinterKey IDL.

Guenther
(cherry picked from commit 366946f29b58a6efa7acbfe2a74b2ddbad4d32a2)
(cherry picked from commit b61da25c37a715782a2edb9afddb0e9a8fdb45ee)

14 years agos3-build: delete more object files for "make clean".
Günther Deschner [Fri, 20 Nov 2009 11:54:19 +0000 (12:54 +0100)]
s3-build: delete more object files for "make clean".

Guenther
(cherry picked from commit eea5a166e766669b6945bb62c9202fb385179cd1)
(cherry picked from commit 9b1294c4111fd3d8805e9ea4147ac714de943059)

14 years agos3-build: really fix build of winbind_krb5_locator.
Günther Deschner [Thu, 19 Nov 2009 12:44:33 +0000 (13:44 +0100)]
s3-build: really fix build of winbind_krb5_locator.

Guenther
(cherry picked from commit fc9f199f2619635f73e8ee7f3b5359521d63f325)
(cherry picked from commit f9b1682cf2d55d3c255e8a69a2b04d8f0d8fd9b1)

14 years agos3-build: make sure to remove libds and client object files on make clean.
Günther Deschner [Thu, 19 Nov 2009 12:39:24 +0000 (13:39 +0100)]
s3-build: make sure to remove libds and client object files on make clean.

Guenther
(cherry picked from commit bf45447aaa35ee3b26fe76af3c73a77d7b10c2ac)
(cherry picked from commit 05689c61609e075b64f3a01ba1e81646fda3b9d1)

14 years agos3-rpcclient: use the parsed binding string flags for auth choice.
Günther Deschner [Thu, 12 Nov 2009 15:45:33 +0000 (16:45 +0100)]
s3-rpcclient: use the parsed binding string flags for auth choice.

This allows rpcclient to be called like this:

rpcclient ncacn_ip_tcp:w2k8r2[sign,seal] -U administrator%secret -c "dscracknames gd"

Guenther
(cherry picked from commit 3732798008f26052c030e8a8fc9c9404fd6f5669)
(cherry picked from commit 6f76254c31bc61805eca2f5dd8c524ac64577b1f)

14 years agos3: Fix bug 6338 -- net rpc trustdom list always display "none"
Volker Lendecke [Sun, 22 Nov 2009 21:38:45 +0000 (22:38 +0100)]
s3: Fix bug 6338 -- net rpc trustdom list always display "none"
(cherry picked from commit 3fcf1a8f9c369f1181f749d2ec9f214df493e3ab)

14 years agos3: Tune if-conditions in a very hot codepath
Volker Lendecke [Sun, 15 Nov 2009 21:22:38 +0000 (22:22 +0100)]
s3: Tune if-conditions in a very hot codepath

This looks innocent, but it is visible in a netbench run.  Due to boolean
short-circuiting we don't have to execute the conditions on the right-hand side
of the &&. So putting the less likely condition left gains a bit.
(cherry picked from commit 8cb66e2d2310567ff97e3198c37eb4c606ddc45c)

14 years agos3: Remove a pointless memset
Volker Lendecke [Mon, 16 Nov 2009 07:54:55 +0000 (08:54 +0100)]
s3: Remove a pointless memset

We are assigning the complete structure now (we used to assign individual
fields), so this is obsolete.
(cherry picked from commit ca5473494216ec3d85be0ed1878d373638c2a7ae)

14 years agos3: Cache brlock.tdb entries for the fast read&write strict locking code path
Volker Lendecke [Mon, 16 Nov 2009 08:40:47 +0000 (09:40 +0100)]
s3: Cache brlock.tdb entries for the fast read&write strict locking code path

For a netbench run this gains around 2% user-space CPU, fetching a 100MB file
takes around 4% less.
(cherry picked from commit d73dbd22ac40e0308213726294de0319458b4277)

14 years agontlm_auth: use data_blob_talloc() to allocate session key
Kai Blin [Wed, 18 Nov 2009 10:26:57 +0000 (11:26 +0100)]
ntlm_auth: use data_blob_talloc() to allocate session key

Thanks to Shibu Piriyath <shibunair80@ymail.com> for spotting the issue.

(cherry picked from commit 43ed7a413dec10adc8cc4ede09132441b5ba2267)
(cherry picked from commit 7301c6deef3241dd9d0a03cfcd1153a958908c19)

14 years agoFix logic bug where high bits tests was being
Jeremy Allison [Sat, 21 Nov 2009 01:23:20 +0000 (17:23 -0800)]
Fix logic bug where high bits tests was being
done on both Windows and POSIX mkdirs instead of
only on Windows mkdir (as intended). The variable
"file_attributes" had already had FILE_FLAG_POSIX_SEMANTICS
removed above in the function if it had already been set.
Jeremy.
(cherry picked from commit 54ba3f522bd26919183278643b417e9632524be9)
(cherry picked from commit cfb84c68030d4ee584db68b9c43c147c00a01ce2)

14 years agos3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901)
Michael Adam [Fri, 20 Nov 2009 23:14:29 +0000 (00:14 +0100)]
s3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901)

Michael
(cherry picked from commit 2abdeca7af052372b242981ff1ab7863a8951cfd)

14 years agos3:fix endianness bug in dbwrap_change_uint32_atomic() (bug #6901)
Michael Adam [Fri, 20 Nov 2009 23:08:38 +0000 (00:08 +0100)]
s3:fix endianness bug in dbwrap_change_uint32_atomic() (bug #6901)

Michael
(cherry picked from commit caa2ee448efd1ebd6d2078972ed838613e7b5151)

14 years agos3:idmap_ldap: trim the " chars from the location string in idmap_ldap_db_init
Michael Adam [Fri, 20 Nov 2009 11:44:43 +0000 (12:44 +0100)]
s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_db_init

When idmap backend is specified as
idmap backend = ldap:"ldap://server1 ldap://server2"
then currently "ldap://server1 ldap://server2" was passed to
ldap_initialize including the quotes, leading to an ldap error.

Michael
(cherry picked from commit 180c9389c65577e25d09c3879d9768f0a24baa08)

14 years agos3:idmap_ldap: trim the " chars from the location string in idmap_ldap_alloc_init
Michael Adam [Fri, 20 Nov 2009 11:38:44 +0000 (12:38 +0100)]
s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_alloc_init

When idmap alloc backend is specified as
idmap alloc backend = ldap:"ldap://server1 ldap://server2"
then currently "ldap://server1 ldap://server2" was passed to
ldap_initialize including the quotes, leading to an ldap error.

Michael
(cherry picked from commit 687c3de25791dcaad58640adb85844401d166559)

14 years agos3:pdb_ldap: fix a comment typo
Michael Adam [Mon, 16 Nov 2009 10:01:53 +0000 (11:01 +0100)]
s3:pdb_ldap: fix a comment typo

Michael
(cherry picked from commit db7f220770c31bf1dc24244dfd949d012260cce5)

14 years agos3: shortcut uid_to_sid when "ldapsam:trusted = yes"
Michael Adam [Mon, 16 Nov 2009 10:37:18 +0000 (11:37 +0100)]
s3: shortcut uid_to_sid when "ldapsam:trusted = yes"

The normal uid_to_sid behaviour is to call sys_getpwuid()
to get the name for the given uid and then call the
getsampwnam passdb method for the resulting name.

In the ldapsam:trusted case we can reduce the uid_to_sid
operation to one simple search for the uidNumber attribute
and only get the sambaSID attribute from the correspoinding
LDAP object. This reduces the number of ldap roundtrips
for this operation.

Michael
(cherry picked from commit 37dcc8a400ea41fb0a0559c9922cc41ac28ad045)

14 years agos3: Avoid races to change the machine password in winbind
Volker Lendecke [Thu, 19 Nov 2009 16:22:27 +0000 (17:22 +0100)]
s3: Avoid races to change the machine password in winbind

The machine password handler has code to deal with every node in the cluster
trying to change the machine password at the same time. However, it is not very
nice to the DC if everyone tries this simultaneously. This adds a random 0-255
second offset to our timed event. When this fires a bit later than strictly
calculated, someone else might have stepped in and have already changed it. The
timed event handler will handle this gracefully, it won't even try to do it
again.
(cherry picked from commit 25605fbd2b35b97515526d7c7708f73daa448544)

14 years agos3: Protect against flooding the DC with pwchange requests
Volker Lendecke [Thu, 19 Nov 2009 16:20:47 +0000 (17:20 +0100)]
s3: Protect against flooding the DC with pwchange requests

When there is a temporary problem changing passwords we flooded the DC with
pwchange requests. This gives the DC a 60-second break to recover.
(cherry picked from commit a7f742c754e9e658908d113a77241463d8e15d17)

14 years agos3: Re-check the timeout in machine_password_change_handler()
Volker Lendecke [Thu, 19 Nov 2009 16:14:40 +0000 (17:14 +0100)]
s3: Re-check the timeout in machine_password_change_handler()

Someone else might have come in between and changed the password since we
created that timed request
(cherry picked from commit e6eee6c54ec39dc9ba55e397165be9e5f08b22f4)

14 years agos3: Add some debugs to the winbind machine pwchange machinery
Volker Lendecke [Thu, 19 Nov 2009 16:11:32 +0000 (17:11 +0100)]
s3: Add some debugs to the winbind machine pwchange machinery
(cherry picked from commit de8ff3e050405b2c384ef78c1dcb23db90d912a6)

14 years agos3: Factor timeval_string out of current_timestring()
Volker Lendecke [Thu, 19 Nov 2009 10:50:13 +0000 (11:50 +0100)]
s3: Factor timeval_string out of current_timestring()
(cherry picked from commit 9bbec24c67949ed00b24e36b8a3a16bba8c5f5c6)

14 years agos3: Do not kill the whole smb session if a machine pwchange failed
Volker Lendecke [Thu, 19 Nov 2009 16:56:46 +0000 (17:56 +0100)]
s3: Do not kill the whole smb session if a machine pwchange failed
(cherry picked from commit f488e98136b09d1bd50421ec529ca7b51d53d199)

14 years agos3:load_interfaces(): use function gfree_interfaces() that we have.
Michael Adam [Wed, 18 Nov 2009 14:19:09 +0000 (15:19 +0100)]
s3:load_interfaces(): use function gfree_interfaces() that we have.

To reduce code duplication.

Michael
(cherry picked from commit aea3a8f50131744f8393d0179cd04a1b97982028)
(cherry picked from commit 5caad323a212a3f046adb7e5a7d86edc819a2d3a)

14 years agos3: Replace some create_synthetic_smb_fname() calls
Volker Lendecke [Sun, 15 Nov 2009 09:46:23 +0000 (10:46 +0100)]
s3: Replace some create_synthetic_smb_fname() calls

In very hot codepaths like the statcache copy_smb_filename and the subsequent
recursive talloc_free is noticable in the CPU load.
(cherry picked from commit 7d68566b2cac0d686119f64946416199cc0ea0dc)

14 years agos3: Do not talloc in readdir
Volker Lendecke [Mon, 16 Nov 2009 08:49:23 +0000 (09:49 +0100)]
s3: Do not talloc in readdir

This is a hot codepath (called from the stat cache)
(cherry picked from commit 5a80f89b39c367582419cdd2ce0ae29c691a0709)

14 years agoWHATSNEW: Remove rpcclient subcommands.
Karolin Seeger [Wed, 18 Nov 2009 13:43:12 +0000 (14:43 +0100)]
WHATSNEW: Remove rpcclient subcommands.

Karolin
(cherry picked from commit eb8f4d1ea12f46986b0d5e8e4c594863ac8a2419)

14 years agoWHATSNEW: Start with the commit highlights.
Karolin Seeger [Wed, 18 Nov 2009 13:21:31 +0000 (14:21 +0100)]
WHATSNEW: Start with the commit highlights.

Karolin
(cherry picked from commit 7d597bed7776970d6a14087574ab456430f4d52b)

14 years agoWHATSNEW: Start with the major changes section.
Karolin Seeger [Wed, 18 Nov 2009 12:31:16 +0000 (13:31 +0100)]
WHATSNEW: Start with the major changes section.

Karolin
(cherry picked from commit 477b5c90ab3fb7e91dfe06b2ecb678172de375d1)

14 years agos3/docs: Add "max protocol = smb2" to man smb.conf.
Karolin Seeger [Wed, 18 Nov 2009 12:05:24 +0000 (13:05 +0100)]
s3/docs: Add "max protocol = smb2" to man smb.conf.

Karolin
(cherry picked from commit da8aba53d61496d0df2bd32f92030cdee0300f2f)
(cherry picked from commit f3f14c9564b4dd6fe63f9e636307dba86be983e7)

14 years agoStart removing SMB_STRUCT_STAT variables except for
Jeremy Allison [Wed, 18 Nov 2009 00:06:08 +0000 (16:06 -0800)]
Start removing SMB_STRUCT_STAT variables except for
the directory enumeration code (which needs it).
Jeremy.
(cherry picked from commit 7407b526e3214287a8f42073044e2ebab058198a)
(cherry picked from commit 9b68da39ea46a7f8442155eed55b2789aa25b2ed)

14 years agoRemove "store create time" code, cause create time to be stored
Jeremy Allison [Tue, 17 Nov 2009 22:55:02 +0000 (14:55 -0800)]
Remove "store create time" code, cause create time to be stored
in the "user.DOSATTRIB" EA. From the docs:
In Samba 3.5.0 and above the "user.DOSATTRIB" extended attribute has been extended to store
the create time for a file as well as the DOS attributes. This is done in a backwards compatible
way so files created by Samba 3.5.0 and above can still have the DOS attribute read from this
extended attribute by earlier versions of Samba, but they will not be able to read the create
time stored there. Storing the create time separately from the normal filesystem meta-data
allows Samba to faithfully reproduce NTFS semantics on top of a POSIX filesystem.
Passes make test but will need more testing.
Jeremy.
(cherry picked from commit a770caed0ff66ddc2d63ac83d20f4cd7fcc2caf5)
(cherry picked from commit d3b5eaa83a48388c49cc18ac094093609ed79762)

14 years agoDon't overwrite a dynamic pointer with the address of a stack
Jeremy Allison [Mon, 16 Nov 2009 22:55:21 +0000 (14:55 -0800)]
Don't overwrite a dynamic pointer with the address of a stack
variable.
Jeremy.
(cherry picked from commit a2a8dc515cca833c442cc3bb4cf90682e8ba147d)
(cherry picked from commit 66a4681a7817537611df5a800d187d4dee3a9855)

14 years agos3: Fix a memleak in sys_popen
Volker Lendecke [Sat, 14 Nov 2009 16:23:08 +0000 (17:23 +0100)]
s3: Fix a memleak in sys_popen

Found with "dfree command" set
(cherry picked from commit 375a8798131c55f1b65d6feef810513ed384dbf2)

14 years agos3:fix a comment typo
Michael Adam [Sat, 14 Nov 2009 00:23:05 +0000 (01:23 +0100)]
s3:fix a comment typo

Michael
(cherry picked from commit 160787dde879148d9c6018ba0f9ca5eee527537f)

14 years agos3:is_trusted_domain: shortcut if domain name == global_sam_name
Michael Adam [Sat, 14 Nov 2009 00:21:42 +0000 (01:21 +0100)]
s3:is_trusted_domain: shortcut if domain name == global_sam_name

A domain can't have a trust with itself.
This saves some roundtrips to the ldap server for ldapsam.

Michael
(cherry picked from commit dc3a90cf21813526854c12db126d08ebf32f8ae5)

14 years agos3:is_trusted_domain: shortcut if domain name is NULL or empty
Michael Adam [Sat, 14 Nov 2009 00:12:22 +0000 (01:12 +0100)]
s3:is_trusted_domain: shortcut if domain name is NULL or empty

This saves some roundtrips to LDAP in an ldapsm setup.

Michael
(cherry picked from commit 0aa5a60d3033fddd652eb4ea89abdf97db912df3)

14 years agos3:passdb: bump interface VERSION 18->19 (removed uid_to_rid)
Michael Adam [Sat, 14 Nov 2009 00:07:34 +0000 (01:07 +0100)]
s3:passdb: bump interface VERSION 18->19 (removed uid_to_rid)

Michael
(cherry picked from commit 5f5fac8780bdd4a39ae316eb10ebe63513b37ace)

14 years agos3:passdb: remove the uid_to_rid method - we only need uid_to_sid
Michael Adam [Sat, 14 Nov 2009 00:06:35 +0000 (01:06 +0100)]
s3:passdb: remove the uid_to_rid method - we only need uid_to_sid

Michael
(cherry picked from commit 979ef8fddb4af4f5033c625343bf92c7e44c3eed)

14 years agos3:pdb_default_uid_to_sid: fix some debug statements.
Michael Adam [Fri, 13 Nov 2009 23:34:14 +0000 (00:34 +0100)]
s3:pdb_default_uid_to_sid: fix some debug statements.

Michael
(cherry picked from commit b1c7882f83922bbf3e6afeb14cc76561568c3388)

14 years agopam_winbind: fix a printf type mismatch warning
Björn Jacke [Sat, 14 Nov 2009 00:52:49 +0000 (01:52 +0100)]
pam_winbind: fix a printf type mismatch warning
(cherry picked from commit 327e1377c96403e8a83b127470ae8464bf50347d)

14 years agos3/pam: move variable declaration into belonging ifdef section
Björn Jacke [Fri, 13 Nov 2009 22:32:04 +0000 (23:32 +0100)]
s3/pam: move variable declaration into belonging ifdef section

This fixes a unused variable 'addr' warning on some platforms
(cherry picked from commit 8549feed3f343c3280173335f240b4e7be12328f)

14 years agos3: Convert libsmb/cli_message to the async API
Volker Lendecke [Tue, 10 Nov 2009 18:49:41 +0000 (19:49 +0100)]
s3: Convert libsmb/cli_message to the async API
(cherry picked from commit 2b759339601ad853588cb74e986a7a88301aea17)
(cherry picked from commit 1ace5f961629fc02c2ff79ed2bdd86e9e988cf28)

14 years agoutil: str_list_unique() bugfix
Kamen Mazdrashki [Fri, 13 Nov 2009 01:57:48 +0000 (03:57 +0200)]
util: str_list_unique() bugfix

j is actually the index of the last element in the list
size of the list though is j+1 <- to make room for the
terminating NULL element
(cherry picked from commit 5b75201dbb9f2e6799fd5c3eee8da6230caee96c)
(cherry picked from commit 8a5c8d559e6b34544a3cc0811d269d46bcad5182)

14 years agoutil: str_list_unique_2() test implementation
Kamen Mazdrashki [Fri, 13 Nov 2009 01:56:07 +0000 (03:56 +0200)]
util: str_list_unique_2() test implementation

Difference with previous test for str_list_unique() is
that this test allows number of elements and number
of duplicates to be supplied on command line using
--option="list_unique:count=47"
--option="list_unique:dups=7"
(cherry picked from commit b7839b73b10746c374ca2ed96eb152fa3a03e66a)
(cherry picked from commit c2a511b8c95a92676fbf0895d3a6fd627662ecb8)

14 years agoadd e2fsprogs-devel as build dependency this is needed for AD because it contains...
Christian Ambach [Mon, 6 Jul 2009 12:08:57 +0000 (14:08 +0200)]
add e2fsprogs-devel as build dependency this is needed for AD because it contains libcom/libcom_err files and headers

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit d0ac2c8a0ad59a118194102b2f6882e474f750a2)

14 years agopackaging(RHEL-CTDB): add the current githash to the rpm release number by default
Michael Adam [Wed, 4 Nov 2009 11:26:46 +0000 (12:26 +0100)]
packaging(RHEL-CTDB): add the current githash to the rpm release number by default

Disable this (to build a release-rpm) by calling

USE_GITHASH=no makerpms.sh

Michael
(cherry picked from commit cfe3274345a2e29dea0d3055ed831fe4d52179e8)

14 years agopackaging(RHEL-CTDB): enable parallel build
Michael Adam [Thu, 20 Aug 2009 11:37:11 +0000 (13:37 +0200)]
packaging(RHEL-CTDB): enable parallel build

Michael
(cherry picked from commit 3e775a2210bba4af07965c090d565e9185984d76)

14 years agopackaging(RHEL-CTDB): fix packaging of pam_winbind.mo file
Michael Adam [Thu, 20 Aug 2009 11:33:42 +0000 (13:33 +0200)]
packaging(RHEL-CTDB): fix packaging of pam_winbind.mo file

Michael
(cherry picked from commit 7a91ead09f002926230f6e3c248b6ef586509630)

14 years agopackaging(RHEL-CTDB): move the idmap and nss_info modules to the common package
Michael Adam [Mon, 3 Aug 2009 13:30:42 +0000 (15:30 +0200)]
packaging(RHEL-CTDB): move the idmap and nss_info modules to the common package

In this layout, this is the package that contains winbindd related stuff.

Michael
(cherry picked from commit 2d4f971ff5b0f1b582370cb45aa70a53c94ab5da)

14 years agopackaging(RHEL-CTDB): package the winbind_krb5_locator.so plugin
Michael Adam [Mon, 3 Aug 2009 12:32:52 +0000 (14:32 +0200)]
packaging(RHEL-CTDB): package the winbind_krb5_locator.so plugin

Michael
(cherry picked from commit a0c65f9abb239a5a27e3082745c15e8ae19907f5)

14 years agopackaging(RHEL-CTDB): package the manpage of the winbind_krb5_locator plugin
Michael Adam [Mon, 3 Aug 2009 12:05:42 +0000 (14:05 +0200)]
packaging(RHEL-CTDB): package the manpage of the winbind_krb5_locator plugin

Michael
(cherry picked from commit e97d6bd520b7624e09b0fb101e6842b9a91ad804)

14 years agopackaging(RHEL-CTDB): package the manpage of "ldbrename"
Michael Adam [Mon, 3 Aug 2009 12:04:33 +0000 (14:04 +0200)]
packaging(RHEL-CTDB): package the manpage of "ldbrename"

Michael
(cherry picked from commit 2fa621de08364be9b3dea7cce2e4616bfe07d689)

14 years agopackaging(RHEL-CTDB): package the manpage of "sharesec"
Michael Adam [Mon, 3 Aug 2009 12:04:09 +0000 (14:04 +0200)]
packaging(RHEL-CTDB): package the manpage of "sharesec"

Michael
(cherry picked from commit 331b816a0bbe5c201edef20d2bb87ef97f9ee206)

14 years agopackaging(RHEL-CTDB): pam_winbindd man page has moved from section 7 to 8
Michael Adam [Mon, 3 Aug 2009 11:45:40 +0000 (13:45 +0200)]
packaging(RHEL-CTDB): pam_winbindd man page has moved from section 7 to 8

This due to updating the docs tarball to the 3.4 docs.

Michael
(cherry picked from commit d70f61aa50482dd3fbd8f4f754be92a864233eac)

14 years agopackaging(RHEL-CTDB): disable the merged build.
Michael Adam [Wed, 1 Jul 2009 09:06:34 +0000 (11:06 +0200)]
packaging(RHEL-CTDB): disable the merged build.

Michael
(cherry picked from commit 94bcef772d2a78711a345963aa1edc7037d7057d)

14 years agopackaging(RHEL-CTDB): also pack libwbcient in winbind-32bit package
Michael Adam [Thu, 19 Mar 2009 23:47:45 +0000 (00:47 +0100)]
packaging(RHEL-CTDB): also pack libwbcient in winbind-32bit package

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 34be433f948e32fec3a01fe138c526671310253d)

14 years agopackaging(RHEL-CTDB): add new pam_winbind.mo to the common package
Michael Adam [Thu, 19 Mar 2009 23:30:35 +0000 (00:30 +0100)]
packaging(RHEL-CTDB): add new pam_winbind.mo to the common package

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 0c4c24a074b7f3aebadbef93733e19312b0c4289)

14 years agopackaging(RHEL-CTDB): add new binary sharesec to the client package.
Michael Adam [Thu, 19 Mar 2009 23:28:36 +0000 (00:28 +0100)]
packaging(RHEL-CTDB): add new binary sharesec to the client package.

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit f8772b9beda656bc7520a9d357a2407b08e70061)

14 years agopackaging(RHEL-CTDB): add new binary ldbrename to the common rpm
Michael Adam [Thu, 19 Mar 2009 23:26:11 +0000 (00:26 +0100)]
packaging(RHEL-CTDB): add new binary ldbrename to the common rpm

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit e364d9c522a2e2585ce8f74ffb5fad68639074f1)

14 years agopackaging(RHEL-CTDB): fix location of nsswitch/ directory for install
Michael Adam [Mon, 29 Jun 2009 15:07:14 +0000 (17:07 +0200)]
packaging(RHEL-CTDB): fix location of nsswitch/ directory for install

This has been moved to the top level directory in 3.4.

Michael
(cherry picked from commit 5bfcde9f41a87d20490d2d94342892becf90383a)

14 years agopackaging(RHEL-CTDB): don't pass CFLAGS to make.
Michael Adam [Mon, 29 Jun 2009 15:05:00 +0000 (17:05 +0200)]
packaging(RHEL-CTDB): don't pass CFLAGS to make.

This breaks the build since 3.3 since it overwrites the CFLAGS
set by configure.

Michael
(cherry picked from commit 58c72fa02ce943bb47287ca53bfb657b0b1e5b26)

14 years agopackaging(RHEL-CTDB): don't "make proto" any more.
Michael Adam [Mon, 29 Jun 2009 15:03:09 +0000 (17:03 +0200)]
packaging(RHEL-CTDB): don't "make proto" any more.

This has become unnecessary in 3.3

Michael
(cherry picked from commit c4d02edcbbea076e5ba87c52a27054c497dc6c9b)

14 years agopackaging(RHEL-CTDB):makerpms.sh: replace source/ by source3/
Michael Adam [Tue, 23 Jun 2009 21:09:09 +0000 (23:09 +0200)]
packaging(RHEL-CTDB):makerpms.sh: replace source/ by source3/

Michael
(cherry picked from commit c4af2b666b9310693820608b56114bad377d1236)

14 years agopackaging(RHEL-CTDB):makespec.sh: fix detection of version
Michael Adam [Tue, 23 Jun 2009 21:06:40 +0000 (23:06 +0200)]
packaging(RHEL-CTDB):makespec.sh: fix detection of version

Michael
(cherry picked from commit 1421aad532daf93d213e6c1b74ad00535832ece3)

14 years agopackaging(RHEL-CTDB): makeversion.sh: v3-4-test uses source3 instead of source
Michael Adam [Tue, 23 Jun 2009 20:41:51 +0000 (22:41 +0200)]
packaging(RHEL-CTDB): makeversion.sh: v3-4-test uses source3 instead of source

Michael
(cherry picked from commit 3a56367867c3578781b8c4ebaf3047c6d5fa3579)

14 years agopackaging(RHEL-CTDB): makerpms.sh: build winbind-32bit libs in the 64bit build
Michael Adam [Wed, 21 Jan 2009 08:49:12 +0000 (09:49 +0100)]
packaging(RHEL-CTDB): makerpms.sh: build winbind-32bit libs in the 64bit build

Michael
(cherry picked from commit a9a506b6640986548e2ae8540b7ae93960d6ece5)
(cherry picked from commit 63d465cdbf522409b6ba9e6507be908d15ac997a)

14 years agopackaging(RHEL-CTDB): Build winbind-32bit package in the 64bit build
Michael Adam [Tue, 20 Jan 2009 18:47:28 +0000 (19:47 +0100)]
packaging(RHEL-CTDB): Build winbind-32bit package in the 64bit build

Michael
(cherry picked from commit f5cd88a25f360e6609dc5abe24247fab78af6854)
(cherry picked from commit 0fa142fd45d09f7b700eb0a4bb984c16ca28a042)

14 years agopackaging(RHEL-CTDB): extend makespec.sh to extract VENDOR_PATCH from version.h
Michael Adam [Wed, 21 Jan 2009 10:03:34 +0000 (11:03 +0100)]
packaging(RHEL-CTDB): extend makespec.sh to extract VENDOR_PATCH from version.h

Michael
(cherry picked from commit fc122aa276bce379b492e5bdf52ab3e03bc3737f)
(cherry picked from commit fe585b56af225b3bc96eac6b0cd57de4cd305f07)

14 years agopackaging(RHEL-CTDB): The former release number has basically moved into VERSION
Michael Adam [Wed, 21 Jan 2009 09:24:31 +0000 (10:24 +0100)]
packaging(RHEL-CTDB): The former release number has basically moved into VERSION

Michael
(cherry picked from commit d39a1b4a09e86dd040158d545258507666b3cab1)

14 years agos3:smbd: also fill the memcache with sid<->id mappings in ldapsam_sid_to_id()
Michael Adam [Fri, 13 Nov 2009 15:16:50 +0000 (16:16 +0100)]
s3:smbd: also fill the memcache with sid<->id mappings in ldapsam_sid_to_id()

not only the persistent idmap cache.

Michael
(cherry picked from commit ee2565bd461ccfb916c5290c883e5ced3af72141)

14 years agos3:smbd: make idmap cache persistent for "ldapsam:trusted".
Michael Adam [Fri, 13 Nov 2009 14:51:33 +0000 (15:51 +0100)]
s3:smbd: make idmap cache persistent for "ldapsam:trusted".

This stores the mappings found in the idmap cache (which lives
inside gencache). This cache is already read in sid_to_Xid()
and Xid_to_sid() for ldapsam:trusted, this fills the opposite
direction, massively reducing the number of ldap roundtrips
across smbd restarts.

Michael
(cherry picked from commit d5537cbbf931f0bca519371bfd084fb0051acd57)

14 years agoFix large paged search
Volker Lendecke [Mon, 18 May 2009 14:04:04 +0000 (16:04 +0200)]
Fix large paged search

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit afb06a8af3c4e86ef9960c8beb19a22f5fd0f3c2)

14 years agofix bogus "out of memory" winbind msg
Volker Lendecke [Wed, 13 May 2009 08:12:26 +0000 (10:12 +0200)]
fix bogus "out of memory" winbind msg

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit a15ffba403cebd8b915f6fdd3de66114c0871219)

14 years agos3: Convert cli_unix_extensions_version to async
Volker Lendecke [Thu, 12 Nov 2009 22:07:21 +0000 (23:07 +0100)]
s3: Convert cli_unix_extensions_version to async
(cherry picked from commit d718908bbd261c6bad78a202cecd90a72f17c117)

14 years agoRevert "pidl: Fix selftest after s3 code changed"
Jeremy Allison [Fri, 13 Nov 2009 04:31:49 +0000 (20:31 -0800)]
Revert "pidl: Fix selftest after s3 code changed"

This reverts commit 439050fb40e5ce9c476924b01f2254b9aab35a3e.

Not needed in this branch (yet).
(cherry picked from commit a656083180683cf93bc4c1b9885d2749e5d238b2)

14 years agos3-kerberos: remove smb_krb5_get_tkt_from_creds().
Günther Deschner [Thu, 12 Nov 2009 14:42:03 +0000 (15:42 +0100)]
s3-kerberos: remove smb_krb5_get_tkt_from_creds().

Now that cli_krb5_get_ticket() already handles S4U2SELF impersonation, remove
smb_krb5_get_tkt_from_creds() which is not required anymore.

Guenther
(cherry picked from commit 61f0b247633501d6bf4103ca8345048e537c043d)
(cherry picked from commit a40c5eadf6da1d7e8b193f0bfbc2a15fb592b585)

14 years agos3-kerberos: avoid using ERROR_TABLE_BASE_krb5 without checking.
Günther Deschner [Thu, 12 Nov 2009 14:40:42 +0000 (15:40 +0100)]
s3-kerberos: avoid using ERROR_TABLE_BASE_krb5 without checking.

Guenther
(cherry picked from commit 0f8bf47d949fbdf47bdb388ad584652202ce185b)
(cherry picked from commit 07fd6cd68951f88d4c8e12156167a18ee6972be5)

14 years agolib/util Fix comments in rfc1738.c.
Andrew Bartlett [Mon, 2 Nov 2009 05:39:31 +0000 (16:39 +1100)]
lib/util Fix comments in rfc1738.c.

The Samba version does not use static buffers

Andrew Bartlett
(cherry picked from commit 5a8f21cb88e7579c12b3d97299f355bb64957a87)
(cherry picked from commit 0f4674c62cb5ed651221a06f05fe3985351e92db)

14 years agolib/util Use rfc1738.c from Squid for all our URL encode/decode needs.
Andrew Bartlett [Thu, 29 Oct 2009 21:58:34 +0000 (08:58 +1100)]
lib/util Use rfc1738.c from Squid for all our URL encode/decode needs.

Andrew Bartlett
(cherry picked from commit 7a290130bdeb411625f16451af3f2cfd25eeaf00)
(cherry picked from commit fa0f418baa628e63cf2b04e769c840eefa9aa61e)

14 years agolib/util Add rfc1738 escape/unescape code from Squid
Andrew Bartlett [Thu, 29 Oct 2009 06:09:49 +0000 (17:09 +1100)]
lib/util Add rfc1738 escape/unescape code from Squid

This is intended to replace our rfc1738_unescape(), and give us an
rfc1738_escape implementation (and hopefully is better tested and more
secure).

Andrew Bartlett
(cherry picked from commit 87195f55de771546ea74c0ab06d882f900588099)
(cherry picked from commit 4e4c75422f07447622d30192c93ffbd4a7874bc2)

14 years agopidl: Fix selftest after s3 code changed
Volker Lendecke [Mon, 9 Nov 2009 13:26:55 +0000 (14:26 +0100)]
pidl: Fix selftest after s3 code changed
(cherry picked from commit e6df4c2bc28b9204cf0637575b0289657e604830)
(cherry picked from commit 439050fb40e5ce9c476924b01f2254b9aab35a3e)

14 years agoRemove unused variable warning.
Jeremy Allison [Thu, 12 Nov 2009 22:09:25 +0000 (14:09 -0800)]
Remove unused variable warning.
Jeremy.
(cherry picked from commit d2a9f4a2729026da11780ae4b71e289982094bd7)
(cherry picked from commit 5c81851109021cc5e0733b3d153d3e2f18a16a41)

14 years agoRemove erroneous 'presult = NULL' changes. Now presult only gets set
Jeremy Allison [Thu, 12 Nov 2009 21:59:25 +0000 (13:59 -0800)]
Remove erroneous 'presult = NULL' changes. Now presult only gets set
if NTSTATUS == OK.
Jeremy.
(cherry picked from commit 03637130316099d4f3db4ce757af2f34ce46d881)
(cherry picked from commit 421ceb5070007924341b108e1a578b43b39fa058)

14 years agoRevert "Ensure every return path initializes presult as NULL."
Jeremy Allison [Thu, 12 Nov 2009 21:57:13 +0000 (13:57 -0800)]
Revert "Ensure every return path initializes presult as NULL."
Vl is correct, this is the wrong way to fix this.

This reverts commit 83c2c177a5e86d04da37384f1f04230c8274e1e6.
(cherry picked from commit 496d147dc4d50650ef1e88877aa28719458089b8)
(cherry picked from commit ca13c8cef238285c09ef5850a91ca1771a2a9685)

14 years agoEnsure all callers to the rpc_client/cli_pipe functions correctly
Jeremy Allison [Thu, 12 Nov 2009 21:56:33 +0000 (13:56 -0800)]
Ensure all callers to the rpc_client/cli_pipe functions correctly
initialize return variables.
Jeremy.
(cherry picked from commit 5363d6e62c2d4d3275e78d04c48835524c54f620)
(cherry picked from commit 3e0add7c118cff14c3ed8f619920f4938e4795c3)

14 years agoFix bug 6891 - using windows explorer to change ownership on a folder fails with...
Jeremy Allison [Thu, 12 Nov 2009 21:08:04 +0000 (13:08 -0800)]
Fix bug 6891 - using windows explorer to change ownership on a folder fails with Bad File Descriptor.
Jeremy.
(cherry picked from commit 6747a91ca0c350374c54bac5892cf96e5aed029f)
(cherry picked from commit 8702bdbeb552537d10b875b18ca814b9912058af)

14 years agoEnsure every return path initializes presult as NULL.
Jeremy Allison [Thu, 12 Nov 2009 19:49:54 +0000 (11:49 -0800)]
Ensure every return path initializes presult as NULL.
Ensures no crashes in calling code that forgets to
init return as null.
Jeremy.
(cherry picked from commit 83c2c177a5e86d04da37384f1f04230c8274e1e6)
(cherry picked from commit 01cb74f9c9a16d49c79dd5333f0a21790d747cc0)

14 years agos3: Fix debug messages in check_reduced_name
Volker Lendecke [Thu, 12 Nov 2009 10:07:15 +0000 (11:07 +0100)]
s3: Fix debug messages in check_reduced_name
(cherry picked from commit 8006e0e63419fbb8de7e1fadf1edc6a51da9d144)
(cherry picked from commit c2be4f267c6debe5cb1e97d766b681082402b847)

14 years agocifs.upcall: Fix Bug #6868: support building with Heimdal we well as with MIT.
Günther Deschner [Wed, 11 Nov 2009 23:52:38 +0000 (00:52 +0100)]
cifs.upcall: Fix Bug #6868: support building with Heimdal we well as with MIT.

Guenther
(cherry picked from commit b29eed492f1c056adb0b53510be10e738276ca11)
(cherry picked from commit 1230faabf8d836b900cdb9848de9fc12a79155f3)