samba.git
8 years agolibcli/security/sddl.c - fix wrong counter type
Matthias Dieter Wallnöfer [Wed, 16 Feb 2011 08:12:17 +0000 (09:12 +0100)]
libcli/security/sddl.c - fix wrong counter type

This strictly needs to be from type "uint32_t" since "acl->num_aces" is
defined of this type.

8 years agolibcli/security/display_sec.c - fix wrong counter type
Matthias Dieter Wallnöfer [Wed, 16 Feb 2011 08:12:17 +0000 (09:12 +0100)]
libcli/security/display_sec.c - fix wrong counter type

This strictly needs to be of type "uint32_t" due to
"sec_acl->num_aces" which is of type "uint32_t".

8 years agos4: avoid overwritting the dceprc.h file from toplevel librpc
Matthieu Patou [Sun, 20 Feb 2011 10:23:48 +0000 (13:23 +0300)]
s4: avoid overwritting the dceprc.h file from toplevel librpc

Change back to what was the configuration of header_path before
177ddcb084e8f8608bf2012a7c58f7b1e56d2acd so that dcerpc.h is installed
in ${prefix}/include and not in ${prefix}/include/gen_ndr as the
toplevel librpc wants also to put a dcerpc.h file in this directory.

Add some documentation in order to avoid any new regression.

This change should fix problems for openchange team.

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Mon Feb 21 09:47:05 CET 2011 on sn-devel-104

8 years agopyldb: add tests for getting control results
Matthieu Patou [Wed, 9 Feb 2011 09:50:35 +0000 (12:50 +0300)]
pyldb: add tests for getting control results

8 years agopyldb: Add tests for the ldb_result object
Matthieu Patou [Wed, 9 Feb 2011 08:22:46 +0000 (11:22 +0300)]
pyldb: Add tests for the ldb_result object

8 years agopyldb: create LdbResult, return value from ldb.search is now a LdbResult
Matthieu Patou [Mon, 7 Feb 2011 06:50:36 +0000 (09:50 +0300)]
pyldb: create LdbResult, return value from ldb.search is now a LdbResult

8 years agos4-unittests: replace assertEquals(res, []) by assertEquals(len(res), 0)
Matthieu Patou [Wed, 9 Feb 2011 18:51:34 +0000 (21:51 +0300)]
s4-unittests: replace assertEquals(res, []) by assertEquals(len(res), 0)

8 years agoldb: controls marshalling/unmarshalling improvement
Matthieu Patou [Sun, 20 Feb 2011 12:23:27 +0000 (15:23 +0300)]
ldb: controls marshalling/unmarshalling improvement

Add a function to marshall a control to a string
Refactor the code of ldb_control_parse_strings to allow to extract the
core code into ldb_control_parse_from_string so that this function can
be called for just 1 string

8 years agoFix missing dependency on libreplace.
Jelmer Vernooij [Sun, 20 Feb 2011 23:26:12 +0000 (00:26 +0100)]
Fix missing dependency on libreplace.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 21 01:17:33 CET 2011 on sn-devel-104

8 years agos4/drs-tests:Blackbox test to verify DsReplicaSync handling
Kamen Mazdrashki [Sun, 20 Feb 2011 02:21:32 +0000 (04:21 +0200)]
s4/drs-tests:Blackbox test to verify DsReplicaSync handling

DsReplicaSync is indirectly called using 'samba-tool drs options' command
to enable/disable replication and 'samba-tool drs replicate' command
to trigger inbound replication cycle

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sun Feb 20 23:03:03 CET 2011 on sn-devel-104

8 years agos4/samba.tests: Raise BlackboxProcessError exception in case check_output method...
Kamen Mazdrashki [Sun, 20 Feb 2011 02:17:25 +0000 (04:17 +0200)]
s4/samba.tests: Raise BlackboxProcessError exception in case check_output method fails

This way the caller gets the chance to receive STDOUT and STDERR for
a failed process.
We may use this info to check if a process has failed properly,
e.g. with expected output

8 years agos4/samba.tests: Extend CalledProcessError class to store STDOUT and STDERR for a...
Kamen Mazdrashki [Sun, 20 Feb 2011 02:15:08 +0000 (04:15 +0200)]
s4/samba.tests: Extend CalledProcessError class to store STDOUT and STDERR for a failed rocess call

8 years agos4/drs-tests: Allow _net_drs_replicate to force replication and return output from...
Kamen Mazdrashki [Fri, 18 Feb 2011 02:27:19 +0000 (04:27 +0200)]
s4/drs-tests: Allow _net_drs_replicate to force replication and return output from command execution

8 years agos4/drs-tests: Split samba-tool command line generation into separate method
Kamen Mazdrashki [Fri, 18 Feb 2011 02:09:45 +0000 (04:09 +0200)]
s4/drs-tests: Split samba-tool command line generation into separate method

so we can use to exec samba-tool passing different commands

8 years agos4/drs-tests: Inherit DrsReplSchemaTestCase from DrsBaseTestCase
Kamen Mazdrashki [Fri, 18 Feb 2011 01:25:20 +0000 (03:25 +0200)]
s4/drs-tests: Inherit DrsReplSchemaTestCase from DrsBaseTestCase

and remove duplicated functionality

8 years agos4/drs-tests: Inherit DrsFsmoTestCase from DrsBaseTestCase
Kamen Mazdrashki [Fri, 18 Feb 2011 01:25:02 +0000 (03:25 +0200)]
s4/drs-tests: Inherit DrsFsmoTestCase from DrsBaseTestCase

and remove duplicated functionality

8 years agos4/drs-tests: Inherit DrsDeleteObjectTestCase from DrsBaseTestCase
Kamen Mazdrashki [Fri, 18 Feb 2011 01:24:08 +0000 (03:24 +0200)]
s4/drs-tests: Inherit DrsDeleteObjectTestCase from DrsBaseTestCase

and remove duplicated functionality

8 years agos4/drs-tests: Add a base class to hold common functionality for all DRS python tests
Kamen Mazdrashki [Fri, 18 Feb 2011 00:54:50 +0000 (02:54 +0200)]
s4/drs-tests: Add a base class to hold common functionality for all DRS python tests

8 years agos3: Fix pdb_ads_enum_aliasmem for empty aliases
Volker Lendecke [Sun, 20 Feb 2011 18:55:01 +0000 (19:55 +0100)]
s3: Fix pdb_ads_enum_aliasmem for empty aliases

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 20 21:40:40 CET 2011 on sn-devel-104

8 years agos3: Support SetGroupInfo in pdb_ads
Volker Lendecke [Sun, 20 Feb 2011 17:39:30 +0000 (18:39 +0100)]
s3: Support SetGroupInfo in pdb_ads

8 years agos3: Fix a debug message
Volker Lendecke [Sun, 20 Feb 2011 17:39:09 +0000 (18:39 +0100)]
s3: Fix a debug message

8 years agos3: Fix pdb_ads_enum_group_members for empty groups
Volker Lendecke [Sun, 20 Feb 2011 16:53:26 +0000 (17:53 +0100)]
s3: Fix pdb_ads_enum_group_members for empty groups

8 years agos3: Fix error returns in pdb_ads_mod_groupmem
Volker Lendecke [Sun, 20 Feb 2011 16:41:22 +0000 (17:41 +0100)]
s3: Fix error returns in pdb_ads_mod_groupmem

8 years agos4-version: Fix version finding for bzr branches.
Jelmer Vernooij [Sun, 20 Feb 2011 15:28:54 +0000 (16:28 +0100)]
s4-version: Fix version finding for bzr branches.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 20 17:35:45 CET 2011 on sn-devel-104

8 years agoldb-samba: Add missing dependency on pyldb-util.
Jelmer Vernooij [Sun, 30 Jan 2011 09:58:47 +0000 (10:58 +0100)]
ldb-samba: Add missing dependency on pyldb-util.

8 years agos3: Improve a debug message, we have more than pdb_tdb.
Volker Lendecke [Sun, 20 Feb 2011 14:20:26 +0000 (15:20 +0100)]
s3: Improve a debug message, we have more than pdb_tdb.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 20 16:50:05 CET 2011 on sn-devel-104

8 years agos3: Protect tldap_errstr against a NULL ld
Volker Lendecke [Sun, 20 Feb 2011 14:08:41 +0000 (15:08 +0100)]
s3: Protect tldap_errstr against a NULL ld

8 years agos3: Fix return code of pdb_ads_getsamupriv if the user does not exist
Volker Lendecke [Sat, 19 Feb 2011 17:25:25 +0000 (18:25 +0100)]
s3: Fix return code of pdb_ads_getsamupriv if the user does not exist

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Feb 20 11:12:01 CET 2011 on sn-devel-104

8 years agos3: Add ACB_NORMAL to workstations, match RPC-SAMR
Volker Lendecke [Sat, 19 Feb 2011 16:52:50 +0000 (17:52 +0100)]
s3: Add ACB_NORMAL to workstations, match RPC-SAMR

8 years agos3: Make QueryDispInfo and QueryInfo match for guest
Volker Lendecke [Sat, 19 Feb 2011 16:44:48 +0000 (17:44 +0100)]
s3: Make QueryDispInfo and QueryInfo match for guest

8 years agos3: NO_SUCH_USER is a lot more likely than NO_MEMORY
Volker Lendecke [Sat, 19 Feb 2011 22:20:34 +0000 (23:20 +0100)]
s3: NO_SUCH_USER is a lot more likely than NO_MEMORY

8 years agos3: Convert init_system_info to NTSTATUS
Volker Lendecke [Sat, 19 Feb 2011 19:05:07 +0000 (20:05 +0100)]
s3: Convert init_system_info to NTSTATUS

8 years agos3: Slightly simplify Get_Pwnam_alloc
Volker Lendecke [Mon, 14 Feb 2011 20:41:00 +0000 (21:41 +0100)]
s3: Slightly simplify Get_Pwnam_alloc

8 years agos3: Fix some nonempty blank lines
Volker Lendecke [Mon, 14 Feb 2011 20:39:10 +0000 (21:39 +0100)]
s3: Fix some nonempty blank lines

8 years agos3:tests: fix the smbclient_s3 test for multiple users running it.
Michael Adam [Sat, 19 Feb 2011 10:49:43 +0000 (11:49 +0100)]
s3:tests: fix the smbclient_s3 test for multiple users running it.

The test created /tmp/log.smbclient, which lets the test fail if
two users are running the test simultaneously.

Now /tmp/log.test_smbclient_s3.$$ is used.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Feb 19 13:06:57 CET 2011 on sn-devel-104

8 years agos3:tests: remove unused script/tests/test_functions.sh
Michael Adam [Sat, 19 Feb 2011 01:29:54 +0000 (02:29 +0100)]
s3:tests: remove unused script/tests/test_functions.sh

This is not used any more now with selftest.

8 years agos3:tests: include subunit.sh instead of test_functions.sh in test_posix_s3.sh
Michael Adam [Sat, 19 Feb 2011 00:14:54 +0000 (01:14 +0100)]
s3:tests: include subunit.sh instead of test_functions.sh in test_posix_s3.sh

It would actually not be necessary at all to include a script providing
testit() and so on, since this script snippet is currently only sourced
in tests.sh to plan the included test.

8 years agos3:tests: include subunit.sh instead of test_functions.sh in test_ntlm_auth_s3.sh
Michael Adam [Sat, 19 Feb 2011 00:14:54 +0000 (01:14 +0100)]
s3:tests: include subunit.sh instead of test_functions.sh in test_ntlm_auth_s3.sh

It would actually not be necessary at all to include a script providing
testit() and so on, since this script snippet is currently only sourced
in tests.sh to plan the included test.

8 years agos3:tests: include subunit.sh instead of test_functions.sh in test_smbtorture_s3.sh
Michael Adam [Sat, 19 Feb 2011 00:14:54 +0000 (01:14 +0100)]
s3:tests: include subunit.sh instead of test_functions.sh in test_smbtorture_s3.sh

It would actually not be necessary at all to include a script providing
testit() and so on, since this script snippet is currently only sourced
in tests.sh to plan the included test.

8 years agos3:tests: include subunit.sh instead of test_functions.sh in test_wbinfo_s3.sh
Michael Adam [Sat, 19 Feb 2011 00:14:54 +0000 (01:14 +0100)]
s3:tests: include subunit.sh instead of test_functions.sh in test_wbinfo_s3.sh

It would actually not be necessary at all to include a script providing
testit() and so on, since this script snippet is currently only sourced
in tests.sh to plan the included test.

8 years agos3:tests: use the blackbox subunit output formatter for the testparm_s3 test.
Michael Adam [Fri, 18 Feb 2011 23:32:06 +0000 (00:32 +0100)]
s3:tests: use the blackbox subunit output formatter for the testparm_s3 test.

With the old output, failures would go unnoticed by selftest.

8 years agos3:tests: include subunit.sh instead of test_functions.sh in test_local_s3.sh
Michael Adam [Sat, 19 Feb 2011 00:14:54 +0000 (01:14 +0100)]
s3:tests: include subunit.sh instead of test_functions.sh in test_local_s3.sh

It would actually not be necessary at all to include a script providing
testit() and so on, since this script snippet is currently only sourced
in tests.sh to plan the included test.

8 years agos3:tests: use the blackbox subunit output formatter for the smbclient_s3 test.
Michael Adam [Fri, 18 Feb 2011 23:32:06 +0000 (00:32 +0100)]
s3:tests: use the blackbox subunit output formatter for the smbclient_s3 test.

With the old output, failures would go unnoticed by selftest.

8 years agos3: Pass logonHours through pdb_ads
Volker Lendecke [Wed, 16 Feb 2011 15:33:21 +0000 (16:33 +0100)]
s3: Pass logonHours through pdb_ads

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Feb 19 12:22:08 CET 2011 on sn-devel-104

8 years agos3: Add "len" to pdb_set_hours
Volker Lendecke [Wed, 16 Feb 2011 15:47:23 +0000 (16:47 +0100)]
s3: Add "len" to pdb_set_hours

8 years agos3: Let pdb_ads write accountExpires
Volker Lendecke [Tue, 15 Feb 2011 20:42:35 +0000 (21:42 +0100)]
s3: Let pdb_ads write accountExpires

8 years agos3: Fix pdb_ads_pull_time
Volker Lendecke [Tue, 15 Feb 2011 20:41:58 +0000 (21:41 +0100)]
s3: Fix pdb_ads_pull_time

8 years agovfs_smb_traffic_analyzer shall also transfer the clients IP address.
Holger Hetterich [Sun, 13 Feb 2011 17:20:00 +0000 (18:20 +0100)]
vfs_smb_traffic_analyzer shall also transfer the clients IP address.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 19 01:53:18 CET 2011 on sn-devel-104

8 years agoFix alignment issues in SPOOLSS "BUFFER" marshalling.
Jeremy Allison [Fri, 18 Feb 2011 17:01:46 +0000 (09:01 -0800)]
Fix alignment issues in SPOOLSS "BUFFER" marshalling.
Guenther and Metze please check !

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 18 18:49:55 CET 2011 on sn-devel-104

8 years agos3:vfs:syncops add option to disable metasync per share
Christian Ambach [Fri, 18 Feb 2011 12:03:52 +0000 (13:03 +0100)]
s3:vfs:syncops add option to disable metasync per share

introduce an option to disable the metadata sync
in case the filesystem handles this correctly the sync can be
skipped, but synchronization of the data that was written can still
be configured (in opposition to the disable flag disabling all
sync operations)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Feb 18 17:31:59 CET 2011 on sn-devel-104

8 years agos3-smbsharemodes: libsmbsharemodes does neither depend on krb5 or ldap.
Günther Deschner [Fri, 18 Feb 2011 14:54:51 +0000 (15:54 +0100)]
s3-smbsharemodes: libsmbsharemodes does neither depend on krb5 or ldap.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Feb 18 16:46:35 CET 2011 on sn-devel-104

8 years agonsswitch: make libwbclient a public library again.
Günther Deschner [Fri, 18 Feb 2011 14:40:59 +0000 (15:40 +0100)]
nsswitch: make libwbclient a public library again.

Guenther

8 years agos3-waf: we need to globally -Ilib/replace
Günther Deschner [Fri, 18 Feb 2011 14:39:28 +0000 (15:39 +0100)]
s3-waf: we need to globally -Ilib/replace

Guenther

8 years agos3-waf: fix popt support.
Günther Deschner [Fri, 18 Feb 2011 14:33:25 +0000 (15:33 +0100)]
s3-waf: fix popt support.

Guenther

8 years agolib/util/charset Add back setlocale(), but only when called from binaries
Andrew Bartlett [Fri, 18 Feb 2011 02:59:05 +0000 (13:59 +1100)]
lib/util/charset Add back setlocale(), but only when called from binaries

When called from a library, we don't want to call this, as we may
overwrite some of our calling program's context.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 18 09:29:35 CET 2011 on sn-devel-104

8 years agolib/util/charcnv Move iconv handle setup in common
Andrew Bartlett [Fri, 18 Feb 2011 02:47:28 +0000 (13:47 +1100)]
lib/util/charcnv Move iconv handle setup in common

We now use the struct smb_iconv_convenience at the core of all our
iconv code, and use global_iconv_convenience for the callers that
don't specify one.

Andrew Bartlett

8 years agos3-charcnv Don't genreate valid_table on the fly, rely on valid.dat
Andrew Bartlett [Fri, 18 Feb 2011 00:51:33 +0000 (11:51 +1100)]
s3-charcnv Don't genreate valid_table on the fly, rely on valid.dat

This file is always installed, and is only even required for the old,
depricated mangle hash method.

Andrew Bartlett

8 years agolib/util Remove #if _SAMBA_BUILD_ == 4 that isn't required any more
Andrew Bartlett [Thu, 17 Feb 2011 23:52:12 +0000 (10:52 +1100)]
lib/util Remove #if _SAMBA_BUILD_ == 4 that isn't required any more

8 years agolib/util/charset Use top level iconv.c in source3
Andrew Bartlett [Thu, 17 Feb 2011 23:24:58 +0000 (10:24 +1100)]
lib/util/charset Use top level iconv.c in source3

The two files were very similar already, the only change required was
to adopt the s3 module registration fucntion name.

(NTSTATUS wasn't used as the charset code does not otherwise use that
type).

Andrew Bartlett

Signed-off-by: Andrew Tridgell <tridge@samba.org>
8 years agos4-idl: rename s4 server_id.idl to server_id4.idl
Andrew Tridgell [Thu, 17 Feb 2011 23:10:30 +0000 (10:10 +1100)]
s4-idl: rename s4 server_id.idl to server_id4.idl

this avoids a conflict with the new s3 server_id.idl

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agolibrpc make ndr-standard a common library
Andrew Bartlett [Thu, 17 Feb 2011 05:29:28 +0000 (16:29 +1100)]
librpc make ndr-standard a common library

8 years agolibrpc push NDR_SECURITY and NDR_DCERPC to the top level wscript files
Andrew Bartlett [Thu, 17 Feb 2011 05:19:45 +0000 (16:19 +1100)]
librpc push NDR_SECURITY and NDR_DCERPC to the top level wscript files

There isn't any reson to keep these private to source3 and source4 and
more, and doing so creates problems for the top level build.

Andrew Bartlett

8 years agonsswitch: depend on dl
Andrew Tridgell [Thu, 17 Feb 2011 03:13:42 +0000 (14:13 +1100)]
nsswitch: depend on dl

The previous merge in this area didn't preserve the 'dl' depedency,
which may be required on some platforms.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agocharset Remove use of {isupper,islower,toupper,tolower}_w functions
Andrew Bartlett [Wed, 16 Feb 2011 05:30:56 +0000 (16:30 +1100)]
charset Remove use of {isupper,islower,toupper,tolower}_w functions

These now call the common _m functions that consider UTF16 code points.

This removes the code which will make up a 'lame' table in memory, as
this can just as correctly be handled by running the algorithm at runtime (which is to call toupper() and tolower() on characters < 128).

When used, a top level waf build will always locate the correct table
- in the build tree or outside - due to relinking the installed
binary.

Andrew Bartlett

8 years agos3-libads Remove MIT-specific krb5_princ_realm macro calls.
Andrew Bartlett [Tue, 15 Feb 2011 05:34:02 +0000 (16:34 +1100)]
s3-libads Remove MIT-specific krb5_princ_realm macro calls.

When compiled against heimdal, we need to use a more elegant API.

Andrew Bartlett

8 years agos3-waf use lib/util/wscript_build, and avoid duplicate subsystems
Andrew Bartlett [Fri, 18 Feb 2011 05:04:30 +0000 (16:04 +1100)]
s3-waf use lib/util/wscript_build, and avoid duplicate subsystems

8 years agolib/util Make UTIL_LDB conditional on an s4 build
Andrew Bartlett [Thu, 17 Feb 2011 05:39:07 +0000 (16:39 +1100)]
lib/util Make UTIL_LDB conditional on an s4 build

This allows this file to be used in common.

8 years agos3-waf: use SAMBA3_*() build rules in source3/build
Andrew Tridgell [Wed, 9 Feb 2011 04:56:20 +0000 (15:56 +1100)]
s3-waf: use SAMBA3_*() build rules in source3/build

this brings the s3 waf build much closer to the proposed s3build top
level build, using the same bld.SAMBA3_*() rules

There are a few renames of subsystems in here, with a 3 suffix where
it would create a conflict.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agobuild: put links for libs in the right directory
Andrew Tridgell [Thu, 17 Feb 2011 23:52:48 +0000 (10:52 +1100)]
build: put links for libs in the right directory

when a library is declared as libdir/libname, still put the symlink in
bin/shared

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Feb 18 06:03:57 CET 2011 on sn-devel-104

8 years agos4-util: removed the valgrind_strlen() routine
Andrew Tridgell [Thu, 17 Feb 2011 23:44:46 +0000 (10:44 +1100)]
s4-util: removed the valgrind_strlen() routine

this was for a bug in valgrind from 7 years ago.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agolibutil: make waf rules usable by s3 waf build
Andrew Tridgell [Thu, 17 Feb 2011 04:42:10 +0000 (15:42 +1100)]
libutil: make waf rules usable by s3 waf build

we need samba-util to be s4 only for now, because of the debug system
differences

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowaf: improved error message for bad paths in SAMBA_LIBRARY()
Andrew Tridgell [Thu, 17 Feb 2011 04:14:57 +0000 (15:14 +1100)]
waf: improved error message for bad paths in SAMBA_LIBRARY()

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowaf: support building libraries with a directory prefix
Andrew Tridgell [Thu, 17 Feb 2011 03:42:19 +0000 (14:42 +1100)]
waf: support building libraries with a directory prefix

SAMBA_LIBRARY('libsmb/smbclient') can now be built, which
distinguishes it from the binary 'smbclient'

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-waf: fixed the include paths for samba public libraries
Andrew Tridgell [Thu, 17 Feb 2011 03:15:31 +0000 (14:15 +1100)]
s3-waf: fixed the include paths for samba public libraries

this fixes the extra global includes for the s3 waf build to be
conditional on whether talloc, tevent and tdb are system libraries or
not.

This fixes a problem where in-tree includes could be used with system
libraries

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agocharset: allow s3 waf build to use lib/util/charset
Andrew Tridgell [Thu, 17 Feb 2011 03:12:36 +0000 (14:12 +1100)]
charset: allow s3 waf build to use lib/util/charset

the only conflict is with 'CHARSET' itself, which now builds
conditionally on _SAMBA_BUILD_==4

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowaf: added SAMBA3_*() build rules to samba3.py
Andrew Tridgell [Thu, 17 Feb 2011 03:11:33 +0000 (14:11 +1100)]
waf: added SAMBA3_*() build rules to samba3.py

these provide samba build rule wrappers for Samba3 specific subsystems

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowaf: give a more sensible error on symlink_bin with missing directory
Andrew Tridgell [Thu, 17 Feb 2011 03:03:13 +0000 (14:03 +1100)]
waf: give a more sensible error on symlink_bin with missing directory

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agolib/util/charset use get_dyn_CODEPAGEDIR(), which is in common
Andrew Bartlett [Wed, 16 Feb 2011 05:44:41 +0000 (16:44 +1100)]
lib/util/charset use get_dyn_CODEPAGEDIR(), which is in common

This is provided by the s3 and s4 dynconfig implementations.

Andrew Bartlett

8 years agolib/util/charset split codepoints.c into it's own subsystem
Andrew Bartlett [Wed, 16 Feb 2011 05:26:05 +0000 (16:26 +1100)]
lib/util/charset split codepoints.c into it's own subsystem

8 years agolib/util/charset use a path to dynconfig.h that works in s3 and s4
Andrew Bartlett [Wed, 16 Feb 2011 05:25:39 +0000 (16:25 +1100)]
lib/util/charset use a path to dynconfig.h that works in s3 and s4

8 years agolib/util/charset add functions isupper_m and islower_m
Andrew Bartlett [Wed, 16 Feb 2011 05:24:12 +0000 (16:24 +1100)]
lib/util/charset add functions isupper_m and islower_m

8 years agos4-auth: rename 'auth' subsystem to 'auth4'
Andrew Tridgell [Tue, 15 Feb 2011 05:30:35 +0000 (16:30 +1100)]
s4-auth: rename 'auth' subsystem to 'auth4'

this prevents conflicts with the s3 auth modules. The auth modules in
samba3 may appear in production smb.conf files, so it is preferable to
rename the s4 modules for minimal disruption.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agobuild: remember the flags used for undefined variable errors
Andrew Tridgell [Tue, 15 Feb 2011 05:29:13 +0000 (16:29 +1100)]
build: remember the flags used for undefined variable errors

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3build: added NMBDSOCKETDIR to dynconfig
Andrew Tridgell [Tue, 15 Feb 2011 05:28:05 +0000 (16:28 +1100)]
s3build: added NMBDSOCKETDIR to dynconfig

this is needed for the s3 top level build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-dsdb: operational module does not need auth any more
Andrew Tridgell [Tue, 15 Feb 2011 05:27:26 +0000 (16:27 +1100)]
s4-dsdb: operational module does not need auth any more

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-includes: force _SAMBA_BUILD_=3 in source3 includes.h
Andrew Tridgell [Tue, 15 Feb 2011 05:19:46 +0000 (16:19 +1100)]
s3-includes: force _SAMBA_BUILD_=3 in source3 includes.h

this allows a common set of cflags for a top level combined build

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agouid-wrapper: handle uwrap_enabled() as a macro
Andrew Tridgell [Tue, 15 Feb 2011 05:18:58 +0000 (16:18 +1100)]
uid-wrapper: handle uwrap_enabled() as a macro

some s3 code defines uwrap_enabled() as a macro. Detect this, and
don't redeclare the functions

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agobuild: fixed passing of includes= for modules
Andrew Tridgell [Tue, 15 Feb 2011 05:17:30 +0000 (16:17 +1100)]
build: fixed passing of includes= for modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agobuild: added subdir option for module building
Andrew Tridgell [Tue, 15 Feb 2011 05:16:54 +0000 (16:16 +1100)]
build: added subdir option for module building

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agobuild: added allow_undefined_symbols options for libraries and modules
Andrew Tridgell [Tue, 15 Feb 2011 05:15:15 +0000 (16:15 +1100)]
build: added allow_undefined_symbols options for libraries and modules

the s4 build uses linker flags to disallow undefined symbols in
libraries. To accomodate s3 libraries in the top level build we need
to be able to disable this on a per-library basis.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agobuild: make ADD_LDFLAGS() returns the flags that were added
Andrew Tridgell [Tue, 15 Feb 2011 05:13:51 +0000 (16:13 +1100)]
build: make ADD_LDFLAGS() returns the flags that were added

this will be used by the s3 top level build to work out how to undo
the effects of -Wl,-no-undefined

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowaf: library_flags() doesn't only operate on conf objects
Andrew Tridgell [Tue, 15 Feb 2011 05:13:05 +0000 (16:13 +1100)]
waf: library_flags() doesn't only operate on conf objects

use a better name for the first argument

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-build: allow waf build of s3 IDL files from any top directory
Andrew Tridgell [Wed, 9 Feb 2011 06:06:40 +0000 (17:06 +1100)]
s3-build: allow waf build of s3 IDL files from any top directory

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agowaf: added subdir= option in SAMBA_*() rules
Andrew Tridgell [Wed, 9 Feb 2011 04:55:18 +0000 (15:55 +1100)]
waf: added subdir= option in SAMBA_*() rules

this allows you to prepend a subdirectory to the source rules, after
variable substitution. This is useful for the s3 waf build when it is
in s3build/

8 years agowaf: use Utils.WafError() instead of sys.exit(1)
Andrew Tridgell [Wed, 9 Feb 2011 04:54:07 +0000 (15:54 +1100)]
waf: use Utils.WafError() instead of sys.exit(1)

better to raise an expection than just exiting

8 years agotevent: Fix a comment
Volker Lendecke [Thu, 17 Feb 2011 15:45:46 +0000 (16:45 +0100)]
tevent: Fix a comment

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Feb 17 18:16:18 CET 2011 on sn-devel-104

8 years agos4-smbtorture: add more complex spoolss_EnumPrinterDataEx test.
Günther Deschner [Thu, 17 Feb 2011 14:24:00 +0000 (15:24 +0100)]
s4-smbtorture: add more complex spoolss_EnumPrinterDataEx test.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Feb 17 16:46:28 CET 2011 on sn-devel-104

8 years agos3-lsa: support trust objects in _lsa_QuerySecurity().
Günther Deschner [Thu, 1 Jul 2010 20:33:17 +0000 (22:33 +0200)]
s3-lsa: support trust objects in _lsa_QuerySecurity().

Guenther

8 years agos3-lsa: in _lsa_QuerySecurity() query the sd from the lsa policy handle.
Günther Deschner [Thu, 29 Oct 2009 23:05:32 +0000 (00:05 +0100)]
s3-lsa: in _lsa_QuerySecurity() query the sd from the lsa policy handle.

Guenther

8 years agos3-lsa: only proceed in _lsa_EnumTrustedDomainsEx when backend has trusted domain...
Günther Deschner [Thu, 17 Feb 2011 13:37:32 +0000 (14:37 +0100)]
s3-lsa: only proceed in _lsa_EnumTrustedDomainsEx when backend has trusted domain support.

Guenther