Andrew Bartlett [Thu, 9 Feb 2012 21:13:40 +0000 (08:13 +1100)]
gensec: set flag to continue in outer for loop in gensec_use_kerberos_mechs
This should be the correct fix for the valgrind erorr Volker found in
744ed53a62037a659133ccd4de2065491208ae7d. This fix avoids putting
SPNEGO into the list twice when we are in the CRED_DONT_USE_KERBEROS
case.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 21:07:21 +0000 (08:07 +1100)]
Revert "gensec: Fix a memory corruption in gensec_use_kerberos_mechs"
This reverts commit
744ed53a62037a659133ccd4de2065491208ae7d.
The real bug here is that the second half of the outer loop should not
have been run once we found spnego.
Andrew Bartlett
Stefan Metzmacher [Fri, 10 Feb 2012 07:26:40 +0000 (08:26 +0100)]
selftest: mark posix_s3.rpc.spoolss.printer as flakey test
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Feb 10 10:04:15 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 9 Feb 2012 00:25:58 +0000 (11:25 +1100)]
s4-nbt_server: remove unused winsdb_get_seqnumber()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 10 08:21:41 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 9 Feb 2012 04:37:50 +0000 (15:37 +1100)]
s3-libsmb: Remove unused kerberos_set_creds_enctype()
Also remove the unused configure tests for krb5_c_enctype_compare.
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 04:34:45 +0000 (15:34 +1100)]
s3-libsmb: Remove unused kerberos_compatible_enctypes
Also remove the unused configure tests for krb5_c_enctype_compare.
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 04:20:24 +0000 (15:20 +1100)]
s3-lib: Remove unused is_myworkgroup()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 02:40:52 +0000 (13:40 +1100)]
s3-charcnv: Remove unused rpcstr_push()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 02:29:06 +0000 (13:29 +1100)]
s3-libsmb: Remove unused smb_krb5_mk_error()
Also remove now-unused configure checks for krb5_mk_error().
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 02:24:46 +0000 (13:24 +1100)]
s3-param: Remove unused share_defined()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 02:22:37 +0000 (13:22 +1100)]
s4-lib/samba3: Remove unused smbpasswd_decode_acb_info()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 01:49:45 +0000 (12:49 +1100)]
lib/util: Remove unused str_format_nbt_domain()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 01:46:38 +0000 (12:46 +1100)]
charset: Remove unused strcmp_w()
Found by callcatcher.
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 00:28:19 +0000 (11:28 +1100)]
s4-lib/tls: remove unused tls_support()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 00:18:43 +0000 (11:18 +1100)]
s4-cmdline: Remove unused popt_common_dont_ask()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 00:17:02 +0000 (11:17 +1100)]
s3-lib: Remove unused pid_path()
piddir.c calls lp_piddir() directly.
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 00:13:29 +0000 (11:13 +1100)]
s3-registry: Remove unused prs_uint8()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 00:11:10 +0000 (11:11 +1100)]
s3-charcnv: Remove unused pull_string_fn
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Wed, 8 Feb 2012 23:49:49 +0000 (10:49 +1100)]
charset: Remove unused iconv_talloc()
Found by callcatcher: http://www.skynet.ie/~caolan/Packages/callcatcher.html
Andrew Bartlett
Andrew Bartlett [Fri, 10 Feb 2012 04:19:05 +0000 (15:19 +1100)]
build: Add --enable-coverage option to build with gcov support
This allows running lcov over the output.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 21:53:15 +0000 (08:53 +1100)]
heimdal: Re-run lexyacc.sh to remove #line statements
Andrew Bartlett [Thu, 9 Feb 2012 21:49:05 +0000 (08:49 +1100)]
heimdal_build: omit #line statments
This restores and finishes my original commit
80e23c68d83a7c9989f87d5a88a78bb76d222afc, reverted in
68c61a829b8487104483b23052b54c532fecb6ce
heimdal_build omit #line statments to allow valgrind to work again
This time however, the reason to omit line statements is that it
causes more trouble with the lcov code coverage system than the (nil)
value that these statements bring. Otherwise, we have to have a
special case to remove the .gcno and .gcda files for these generated
files.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Feb 2012 21:43:59 +0000 (08:43 +1100)]
heimdal: Re-run lexyacc.sh
Andrew Bartlett [Thu, 9 Feb 2012 21:14:59 +0000 (08:14 +1100)]
credentials: Show returned error_string in debug message
Jelmer Vernooij [Thu, 9 Feb 2012 12:12:06 +0000 (13:12 +0100)]
tests/source: Add wafsamba/ files to list of Python files to check.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Feb 10 01:45:16 CET 2012 on sn-devel-104
Jelmer Vernooij [Thu, 9 Feb 2012 12:08:31 +0000 (13:08 +0100)]
wafsamba: Expand tabs.
Volker Lendecke [Thu, 9 Feb 2012 15:07:12 +0000 (16:07 +0100)]
gensec: Fix a memory corruption in gensec_use_kerberos_mechs
Without this I get the following valgrind error:
==27740== Invalid write of size 8
==27740== at 0x62C53E: gensec_use_kerberos_mechs (gensec_start.c:112)
==27740== by 0x62C623: gensec_security_mechs (gensec_start.c:141)
==27740== by 0x62C777: gensec_security_by_oid (gensec_start.c:181)
==27740== by 0x62DD6E: gensec_start_mech_by_oid (gensec_start.c:735)
==27740== by 0x50D6FD: negprot_spnego (negprot.c:210)
==27740== by 0x5B0DEA: smbd_smb2_request_process_negprot (smb2_negprot.c:209)
==27740== by 0x5AD036: smbd_smb2_request_dispatch (smb2_server.c:1417)
==27740== by 0x5AFB77: smbd_smb2_first_negprot (smb2_server.c:2643)
==27740== by 0x585C00: process_smb (process.c:1641)
==27740== by 0x587F78: smbd_server_connection_read_handler (process.c:2314)
==27740== by 0x587FD6: smbd_server_connection_handler (process.c:2331)
==27740== by 0x99E05B: run_events_poll (events.c:286)
==27740== by 0x584AFF: smbd_server_connection_loop_once (process.c:984)
==27740== by 0x58B2D9: smbd_process (process.c:3389)
==27740== by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740== by 0x99E05B: run_events_poll (events.c:286)
==27740== by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740== by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740== by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740== by 0xDE6DD8: main (server.c:1413)
==27740== Address 0x9ff3538 is 4,232 bytes inside a block of size 8,288 alloc'd
==27740== at 0x4C261D7: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==27740== by 0x6926965: __talloc (talloc.c:560)
==27740== by 0x6926771: talloc_pool (talloc.c:598)
==27740== by 0x93B927: talloc_stackframe_internal (talloc_stack.c:145)
==27740== by 0x93B9D6: talloc_stackframe_pool (talloc_stack.c:171)
==27740== by 0x58B2B7: smbd_process (process.c:3385)
==27740== by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740== by 0x99E05B: run_events_poll (events.c:286)
==27740== by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740== by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740== by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740== by 0xDE6DD8: main (server.c:1413)
In the for-loop we can increment j twice, so we need twice as many output array
elements as input array elements.
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Feb 9 19:44:47 CET 2012 on sn-devel-104
Björn Baumbach [Tue, 7 Feb 2012 10:41:54 +0000 (11:41 +0100)]
s3-printing: Add new printers to registry.
This fixes bug #8554, #8612 and #8748.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Feb 9 16:39:04 CET 2012 on sn-devel-104
Andreas Schneider [Wed, 30 Nov 2011 16:58:30 +0000 (17:58 +0100)]
s3-libsmb: Remove obsolete smb_krb5_locate_kdc.
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Feb 9 14:58:57 CET 2012 on sn-devel-104
Andreas Schneider [Wed, 30 Nov 2011 16:39:22 +0000 (17:39 +0100)]
s3-net: Don't use an internal krb5 for kdc lookup.
This replaces the use of the internal krb5_locate_kdc() function with
our own get_kdc_list() function.
Signed-off-by: Günther Deschner <gd@samba.org>
Stefan Metzmacher [Thu, 9 Feb 2012 09:11:19 +0000 (10:11 +0100)]
tevent: change the version to 0.9.15
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb 9 12:24:19 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 28 Jan 2012 21:18:00 +0000 (22:18 +0100)]
tevent: Fix deleting signal events from within themselves
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Fri, 3 Feb 2012 04:06:48 +0000 (15:06 +1100)]
smbwrapper: Remove smbwrapper
There are now many better ways to access a remote SMB filesystem,
which do not rely on LD_PRELOAD and the associated dangers. FUSE,
gvfs and the CIFS VFS are all much better options which do not require
knowing every possible libc entry point that can deal with a file
descriptor.
As an example of the maintainence that would be required to keep this
going, recent changes to deal with thread races and close-on-exec have
resulted in dup3(), but this isn't currently mapped. While this would
not be hard to add, it illistrates why it is better to move to an
interface designed for this task.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Feb 9 01:58:24 CET 2012 on sn-devel-104
Andrew Bartlett [Wed, 25 Jan 2012 22:23:23 +0000 (09:23 +1100)]
s3-build: remove EXEEXT from Makefiles
As far as I am aware, we do not actually build on any platforms that
require this. The last Stratos VOS release on
ftp://ftp.stratus.com/vos/samba/samba.html was 3.0.5
Andrew Bartlett
Matthias Dieter Wallnöfer [Mon, 14 Nov 2011 16:53:39 +0000 (17:53 +0100)]
s4:join python code - perform a fallback password set operation over libnet
Windows 2000 DCs allow LDAP password set operations only with the help of SSL.
Given the fact that this technique is hard to setup it is easier to use SAMR
over "libnet".
Reviewed-By: Andrew Bartlett <abartlet@samba.org>
Matthias Dieter Wallnöfer [Sun, 8 Jan 2012 15:41:54 +0000 (16:41 +0100)]
s4:join python code - write the SAM account name correctly
It is easier for the comprehension
Reviewed-By: Andrew Bartlett <abartlet@samba.org>
Jeremy Allison [Wed, 8 Feb 2012 20:15:04 +0000 (12:15 -0800)]
Fix shadow variable name warning.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb 8 22:55:08 CET 2012 on sn-devel-104
Jelmer Vernooij [Wed, 8 Feb 2012 13:17:17 +0000 (14:17 +0100)]
regshell: Fix a counter that can actually be non-zero.
This was a regression caused by one of the unsigned patches.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Feb 8 16:00:22 CET 2012 on sn-devel-104
Andrew Bartlett [Wed, 8 Feb 2012 06:41:54 +0000 (17:41 +1100)]
s3-passdb: Remove #if _SAMBA_BUILD_ == 4 from pdb_samba4
pdb_samba4 is only built with waf anyway.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Feb 8 09:17:40 CET 2012 on sn-devel-104
Andrew Bartlett [Fri, 3 Feb 2012 03:51:59 +0000 (14:51 +1100)]
s3-docs: Remove references to long-gone smbmount utilities
Andrew Bartlett [Mon, 30 Jan 2012 21:54:22 +0000 (08:54 +1100)]
auth: rename ntlmssp.c to ntlmssp_util.c
Andrew Bartlett [Mon, 30 Jan 2012 11:44:28 +0000 (22:44 +1100)]
s3-auth Add const to make_user_info_map
Andrew Bartlett [Mon, 6 Feb 2012 06:44:34 +0000 (17:44 +1100)]
s4-messaging: fix pymessaging docstring
Andrew Bartlett [Mon, 4 Jul 2011 00:14:27 +0000 (10:14 +1000)]
s3-build use common VERSION file for all builds
There is no need to have both version files at this point.
Andrew Bartlett
Andrew Tridgell [Wed, 8 Feb 2012 02:01:32 +0000 (13:01 +1100)]
pidl: add more mapped types
when we #define one type to another, we need special handling in the
python generator
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Feb 8 04:50:06 CET 2012 on sn-devel-104
Andrew Tridgell [Wed, 8 Feb 2012 02:00:29 +0000 (13:00 +1100)]
idl: wmi and dcom don't need python bindings
the python generation for these IDL files is currently broken
Amitay Isaacs [Tue, 7 Feb 2012 06:30:22 +0000 (17:30 +1100)]
samba-tool sites: Re-add support for option groups
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Feb 8 02:27:28 CET 2012 on sn-devel-104
Amitay Isaacs [Tue, 7 Feb 2012 06:27:18 +0000 (17:27 +1100)]
samba-tool dns: Re-add support for option groups
Jeremy Allison [Tue, 7 Feb 2012 18:20:36 +0000 (10:20 -0800)]
Remove unused get_file_size() function.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Feb 7 20:56:28 CET 2012 on sn-devel-104
Volker Lendecke [Tue, 7 Feb 2012 15:41:25 +0000 (16:41 +0100)]
s3: Increase debug level of basic ctdb packet handling
This clutters the debug level 10 output significantly without much
value
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Tue Feb 7 18:19:08 CET 2012 on sn-devel-104
Andreas Schneider [Tue, 7 Feb 2012 10:11:15 +0000 (11:11 +0100)]
s3-waf: Link tdbsam against needed libraries.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue Feb 7 12:49:59 CET 2012 on sn-devel-104
Andreas Schneider [Mon, 6 Feb 2012 11:47:16 +0000 (12:47 +0100)]
s3-waf: Link against tdb_compat instead of tdb.
Jelmer Vernooij [Tue, 7 Feb 2012 00:09:41 +0000 (01:09 +0100)]
provision: Make sure target directory is created early.
This is necessary when using the target directory to store temporary
files.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Feb 7 02:45:37 CET 2012 on sn-devel-104
Jelmer Vernooij [Mon, 6 Feb 2012 22:26:36 +0000 (23:26 +0100)]
samba-tool user password: Re-add support for option groups.
Jelmer Vernooij [Mon, 6 Feb 2012 21:06:09 +0000 (22:06 +0100)]
samba-tool: Add optiongroups, necessary for 'samba-tool domain ...'
Jelmer Vernooij [Mon, 6 Feb 2012 16:47:25 +0000 (17:47 +0100)]
crypto: Use libbsd md5 header, if available.
Jelmer Vernooij [Mon, 6 Feb 2012 15:53:52 +0000 (16:53 +0100)]
crypto/md5: Change prototypes to match BSD.
Jelmer Vernooij [Mon, 6 Feb 2012 15:33:38 +0000 (16:33 +0100)]
Revert "samba-tool: moved takes_optiongroups definition to Command base class"
This reverts commit
f6fa8684896b8f3f9f8b7bd3742c99906973274c.
This keeps the main command class fairly slim, and makes it a bit
more obvious where the arguments to run() are coming from.
Conflicts:
source4/scripting/python/samba/netcmd/__init__.py
source4/scripting/python/samba/netcmd/domain.py
source4/scripting/python/samba/netcmd/gpo.py
source4/scripting/python/samba/netcmd/newuser.py
source4/scripting/python/samba/netcmd/testparm.py
source4/scripting/python/samba/netcmd/user.py
source4/scripting/python/samba/tests/samba_tool/__init__.py
Jelmer Vernooij [Mon, 6 Feb 2012 11:20:54 +0000 (12:20 +0100)]
charset/tests: Add prototypes for test functions.
Jelmer Vernooij [Sun, 5 Feb 2012 19:18:59 +0000 (20:18 +0100)]
smb_server: Preserve signedness of string push return value.
Jelmer Vernooij [Sun, 5 Feb 2012 19:12:23 +0000 (20:12 +0100)]
loadparm: handle P_SEP in switches (silences warning with clang).
Jelmer Vernooij [Sun, 5 Feb 2012 15:42:41 +0000 (16:42 +0100)]
pysocketwrapper: fix behaviour to be consistent with 'socket.getsockopt'
socklen_t is unsigned
Jelmer Vernooij [Sun, 5 Feb 2012 14:35:12 +0000 (15:35 +0100)]
torture/libnet: Include prototype headers.
Jelmer Vernooij [Sun, 5 Feb 2012 14:31:31 +0000 (15:31 +0100)]
pyxattr_tdb: Remove pointless check for blob.length < 0.
Jelmer Vernooij [Sun, 5 Feb 2012 14:31:05 +0000 (15:31 +0100)]
crypto: Add prototype for main torture functions.
Horacio G. de Oro [Fri, 3 Feb 2012 01:52:28 +0000 (22:52 -0300)]
Use named argument 'dir' instead of 'prefix' on NamedTemporaryFile for domain.py
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Horacio G. de Oro [Fri, 3 Feb 2012 01:48:26 +0000 (22:48 -0300)]
Use named argument 'dir' instead of 'prefix' on NamedTemporaryFile for source4/setup/provision
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Christof Schmitt [Mon, 6 Feb 2012 18:18:29 +0000 (11:18 -0700)]
s3-winbind: Remove unused bool "local"
"local" is always False, so simply remove it and the if statement
checking its value.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Feb 6 23:27:48 CET 2012 on sn-devel-104
Volker Lendecke [Mon, 6 Feb 2012 15:53:22 +0000 (16:53 +0100)]
s3: FreeBSD does not define sin6_addr.s_addr32
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Feb 6 20:03:58 CET 2012 on sn-devel-104
Ira Cooper [Sun, 5 Feb 2012 14:47:16 +0000 (09:47 -0500)]
s3-nsswitch: Fix warnings on Solaris.
Add "system/passwd.h" so struct group is declared.
Autobuild-User: Ira Cooper <ira@samba.org>
Autobuild-Date: Mon Feb 6 18:28:53 CET 2012 on sn-devel-104
Volker Lendecke [Fri, 3 Feb 2012 02:27:19 +0000 (03:27 +0100)]
lib/util: Add hex_encode_buf
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Feb 6 09:15:33 CET 2012 on sn-devel-104
Ira Cooper [Sat, 4 Feb 2012 00:47:18 +0000 (16:47 -0800)]
s3-popt: Fix configure.developer builds on Solairs.
alloca.h needs to be included, or the build complains the implicit
definition of alloca.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 4 03:27:42 CET 2012 on sn-devel-104
Jeremy Allison [Sat, 4 Feb 2012 00:37:41 +0000 (16:37 -0800)]
Ensure when setting a POSIX ACL, that the uid for a
SMB_ACL_USER_OBJ ACE (the owner ACE entry) has a duplicate
permission entry as an SMB_ACL_USER, and a gid for a
SMB_ACL_GROUP_OBJ ACE (the primary group ACE entry) also has
a duplicate permission entry as an SMB_ACL_GROUP. If not,
then if the ownership or group ownership of this file or
directory gets changed, the user or group can lose their
access.
Jeremy Allison [Fri, 3 Feb 2012 23:58:12 +0000 (15:58 -0800)]
Fix mistaken assignment of gid to uid field.
Jeremy Allison [Fri, 3 Feb 2012 23:28:22 +0000 (15:28 -0800)]
Replace bool flags inside ensure_canon_entry_valid() with pointers.
This will make the second tweak to the ACL mapping on set easier.
Jeremy Allison [Fri, 3 Feb 2012 22:55:34 +0000 (14:55 -0800)]
Fix bug #7933 - samba fails to honor SEC_STD_WRITE_OWNER bit with the acl_xattr module.
Jeremy Allison [Fri, 3 Feb 2012 22:06:38 +0000 (14:06 -0800)]
Replace all malloc/free with talloc on tos.
Michael Adam [Mon, 30 Jan 2012 11:08:38 +0000 (12:08 +0100)]
s4:torture: add a smb2.durable_open.reopen4 test
open a durable handle, logoff, new sessions setup, try durable reopen (fail),
open tcon, durable reopen (succeed)
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Feb 3 12:45:34 CET 2012 on sn-devel-104
Michael Adam [Mon, 30 Jan 2012 11:07:07 +0000 (12:07 +0100)]
s4:torture: add a torture_smb2_session_setup() utility function
Michael Adam [Fri, 27 Jan 2012 16:21:25 +0000 (17:21 +0100)]
s4:torture: add smb2.durable_open test reopen3
Do a durable open, tdis, tree_connect, durable reopen -> fail
Michael Adam [Fri, 27 Jan 2012 16:20:23 +0000 (17:20 +0100)]
s4:torture: add torture_smb2_tree_connect() utility function
This does a tcon based on an existing session, using the
name an host present in the torture context.
Michael Adam [Fri, 27 Jan 2012 12:06:09 +0000 (13:06 +0100)]
s4:torture: add smb2.durable_open test reopen2
durable open, disconnect, new seession, durable reopen
Michael Adam [Fri, 27 Jan 2012 12:03:08 +0000 (13:03 +0100)]
s4:torture: add smb2.durable_open test reopen1
Michael Adam [Thu, 2 Feb 2012 12:41:40 +0000 (13:41 +0100)]
s4:libcli:smb2: don't allocate the smb2_tree struct earlier than necessary in smb2_connect()
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Thu, 2 Feb 2012 12:39:56 +0000 (13:39 +0100)]
s4:libcli/torture:smb2: change smb2_tree_connect to take a smb2_session instead of smb2_tree arguement.
Only the tree->session is needed. This way it is less confusing.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Thu, 2 Feb 2012 12:38:08 +0000 (13:38 +0100)]
s4:torture:smb2: talloc_free the right tree structure in secondary_tcon()
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Thu, 2 Feb 2012 12:36:20 +0000 (13:36 +0100)]
s4:torture:smb2: check for success of talloc in secondary_tcon()
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Thu, 2 Feb 2012 14:56:48 +0000 (15:56 +0100)]
s4:torture:smb2:notify: remove an unused variable
Michael Adam [Thu, 2 Feb 2012 14:53:26 +0000 (15:53 +0100)]
s4:torture:smb2:notify: remove an unused variable
Michael Adam [Thu, 2 Feb 2012 14:42:16 +0000 (15:42 +0100)]
s4:torture:smb2: remove an unused variable from torture_smb2_setinfo()
Michael Adam [Thu, 2 Feb 2012 23:21:50 +0000 (00:21 +0100)]
loadparm: fix a load of uninitialized memory errors found by valgrind.
Matthieu Patou [Sat, 28 Jan 2012 00:12:52 +0000 (16:12 -0800)]
s3-nmbd: don't discard DGRAM frames from local addresses when we are a DC
Winbind use netbios to locate the DC, if samba is also a DC then nmbd
receive request from Winbind that are from a local address, those
requests must not be discarded otherwise winbind can't find the DC and
won't try another method.
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Fri Feb 3 11:09:29 CET 2012 on sn-devel-104
Matthieu Patou [Wed, 25 Jan 2012 05:29:11 +0000 (21:29 -0800)]
s3-pid: Catch with pid filename's change when config file is not smb.conf
This is what is done in pidfile_create
Amitay Isaacs [Fri, 3 Feb 2012 01:04:32 +0000 (12:04 +1100)]
selftest: Fix the exit code of make test when run in buildfarm
When make test is run in buildfarm environment (RUN_FROM_BUILD_FARM=1),
last process in make test pipeline is subunit-filter. This subunit-filter
is responsible for converting failure test result to xfail for known
failures. While converting failures to xfail, it sets exitcode=1. If
this is the last process in the pipeline make test fails, which is
the observed behavior in buildfarm.
In autobuild, there is additional process in the pipeline format-subunit
which processes the output of subunit-filter and correctly terminates
with exit code=0. The buildfarm make test failure is fixed by adding
extra filter-subunit in the pipeline, as the extra filter-subunit
exits correctly with exit code=0.
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Fri Feb 3 07:00:04 CET 2012 on sn-devel-104
Jeremy Allison [Fri, 3 Feb 2012 00:28:39 +0000 (16:28 -0800)]
Only ask for specific permissions required when setting an ACL.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 3 03:07:33 CET 2012 on sn-devel-104
Jeremy Allison [Fri, 3 Feb 2012 00:28:06 +0000 (16:28 -0800)]
Allow a SACL to be sent in cli_set_secdesc().
Volker Lendecke [Thu, 2 Feb 2012 19:32:07 +0000 (20:32 +0100)]
s3: Test for faulty xattr_tdb listxattr
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Feb 2 22:10:49 CET 2012 on sn-devel-104
Volker Lendecke [Thu, 2 Feb 2012 17:11:32 +0000 (18:11 +0100)]
s3-xattr_tdb: Fix listxattr
We have to tell the caller how many bytes we actually want
Volker Lendecke [Thu, 2 Feb 2012 18:41:56 +0000 (19:41 +0100)]
s3-vfstest: Add removexattr
Volker Lendecke [Thu, 2 Feb 2012 18:36:00 +0000 (19:36 +0100)]
s3-vfstest: Add setxattr