22 years ago- todd sabin spotted bugs in samr enum dom users / groups / aliases code:
Luke Leighton [Mon, 8 Mar 1999 19:19:01 +0000 (19:19 +0000)]
- todd sabin spotted bugs in samr enum dom users / groups / aliases code:
  last count (probably an ENUM / resume handle) should always be returned
  even if there are no items being returned.

- got fed up of seven intendation levels in cmd_samr.c, maximum recommended
  in *any* code is three!  made some sub-fns instead.
(This used to be commit 1c330d568225759950401cfb98fe9e99db81419c)

22 years agopass_check.c could receive encrypted password: printing it out as a %s
Luke Leighton [Mon, 8 Mar 1999 18:43:50 +0000 (18:43 +0000)]
pass_check.c could receive encrypted password: printing it out as a %s
results in garbage.  with no password length argument doing dump_data(
100, password, strlen(password)) is the next best alternative.
(This used to be commit 073c8652c13408b883fc73203e5558b1a9a64d62)

22 years agooops, accidentally committed clear-text password reading last week.
Luke Leighton [Mon, 8 Mar 1999 18:42:43 +0000 (18:42 +0000)]
oops, accidentally committed clear-text password reading last week.
(This used to be commit e0b5a866ce2628a5e152af3ef817ee3124e60500)

22 years agoBejamin Kuit. #define MYSQL and MYSQL_ROW to void iff <mysql.h> not found.
Luke Leighton [Mon, 8 Mar 1999 18:41:58 +0000 (18:41 +0000)]
Bejamin Kuit.  #define MYSQL and MYSQL_ROW to void iff <mysql.h> not found.
(This used to be commit 188d9a75edb41e8a0cc0ea6e17c9497771cf3b96)

22 years agospelling mistake, #ifdef'd out for non-developers (oops!)
Luke Leighton [Fri, 5 Mar 1999 22:37:02 +0000 (22:37 +0000)]
spelling mistake, #ifdef'd out for non-developers (oops!)
(This used to be commit 167b0b20e33bef4af5deaff961937dd5fadf481d)

22 years agooops, put -DDEBUG_PASSWORD in wrong place.
Luke Leighton [Fri, 5 Mar 1999 22:33:32 +0000 (22:33 +0000)]
oops, put -DDEBUG_PASSWORD in wrong place.
(This used to be commit 4e89fbb7d9c2c8e776ab0a819cbf1a1294f07c1b)

22 years agoBenjamin Kuit's mods.
Luke Leighton [Fri, 5 Mar 1999 22:03:04 +0000 (22:03 +0000)]
Benjamin Kuit's mods.
(This used to be commit eb63fbdb68f1189593e68272e05d7ebf76652c4c)

22 years agoBenjamin Kuit's latest mysql mods. issue with "make proto" needs to be
Luke Leighton [Wed, 3 Mar 1999 20:48:48 +0000 (20:48 +0000)]
Benjamin Kuit's latest mysql mods.  issue with "make proto" needs to be
(This used to be commit d59a2e669aed7ee33fdca8b8ec126b1c0a984981)

22 years agoadded <mysql.h> autoconf test.
Luke Leighton [Tue, 2 Mar 1999 16:43:27 +0000 (16:43 +0000)]
added <mysql.h> autoconf test.
(This used to be commit 511ef8a58ccfc04d0744f28753bb48d848851980)

22 years agoBenjamin Kuit's MYSQL SAM Database implementation.
Luke Leighton [Mon, 1 Mar 1999 16:31:14 +0000 (16:31 +0000)]
Benjamin Kuit's MYSQL SAM Database implementation.
Copyright (C) Benjamin Kuit <> 1999.
(This used to be commit fdf61e1dabc2c977ee5cf1e9d60e3380f19840da)

22 years agoimproving syntax / useability of rpcclient "shutdown" command:
Luke Leighton [Mon, 1 Mar 1999 16:01:45 +0000 (16:01 +0000)]
improving syntax / useability of rpcclient "shutdown" command:
rpcclient [-m messsage] [-t timeout] [-r or --reboot].
(This used to be commit 8b859797aaa1b88cb1a932fed97b4c3ea2dbdde2)

22 years agoreferred reader to NT Domain FAQ for more info (copy of update to 2.0)
Gerald Carter [Thu, 25 Feb 1999 15:00:24 +0000 (15:00 +0000)]
referred reader to NT Domain FAQ for more info (copy of update to 2.0)
(This used to be commit 644cda5d807d875c956e71a6e49d65c2d7f0d61e)

22 years agoReturn either STATUS_BUFFER_OVERFLOW or ERRDOS/ERRmoredata depending on
Matthew Chapman [Wed, 24 Feb 1999 19:08:43 +0000 (19:08 +0000)]
Return either STATUS_BUFFER_OVERFLOW or ERRDOS/ERRmoredata depending on
whether the client supports 32-bit error codes.
(This used to be commit cb5428308d6978f7bd76c1b878dd4a43135a274d)

22 years agoAdded "lookupdomain" rpcclient command. Not particularly useful currently
Matthew Chapman [Wed, 24 Feb 1999 01:58:08 +0000 (01:58 +0000)]
Added "lookupdomain" rpcclient command. Not particularly useful currently
(you can do "lookupdomain MYDOMAIN" and "lookupdomain BUILTIN" and the
results won't be too surprising), but it will come in useful testing the
new password database code I'm working on.
(This used to be commit d1cc33bcb61305cc9a6e21886237fa291eda9427)

22 years agoWin9x user level security.
Matthew Chapman [Wed, 24 Feb 1999 01:52:30 +0000 (01:52 +0000)]
Win9x user level security.

* Added SAMR_LOOKUP_DOMAIN (-> SamrLookupDomainInSamServer)

* Added real SAMR_ENUM_DOM_GROUPS (corresponding to
SamrEnumerateGroupsInDomain). The existing one is just an alias for
SamrQueryDisplayInformation (see below).

* Added three extra info levels to SAMR_QUERY_DISPINFO. Info level 3 is
what was previously SAMR_ENUM_DOM_GROUPS; info levels 4 and 5 are
simple user/group list requests used by Win9x and I suspect (haven't
checked) the "low speed connection" User Manager.

* Added another two aliases for SAMR_QUERY_DISPINFO, opcodes 0x30 and
0x33. Usually the first is with info level 3 and the second 4 but there is
some overlap so indeed these should be implemented as just aliases.

* Return ERRDOS/ERRmoredata on extra data instead of
STATUS_BUFFER_OVERFLOW for Win95's benefit. On a named pipe this results
in an SMBreadX as usual.

Still need to fix SAMR_QUERY_DOMAIN_INFO which has a hard-coded number of
users and groups - which Win95 proceeds to truncate at.
(This used to be commit 7d03e6e21908f3a759a4e65c5edd850622335e3e)

22 years agoadded jeremy's new c++-like code for parsing of security descriptors.
Luke Leighton [Tue, 23 Feb 1999 22:39:54 +0000 (22:39 +0000)]
added jeremy's new c++-like code for parsing of security descriptors.
(This used to be commit ec1b7000fd88c5a08e438c7033f60e49b9ec44a8)

22 years agosamr_lookup_names "none found" error needed corrections with empty lists.
Luke Leighton [Fri, 19 Feb 1999 17:41:05 +0000 (17:41 +0000)]
samr_lookup_names "none found" error needed corrections with empty lists.
(This used to be commit e164b5080ca966de4227277f7ac031bc96d056ad)

22 years agolast unix group not being listed. spotted by jacques sansdrap.
Luke Leighton [Fri, 19 Feb 1999 15:46:38 +0000 (15:46 +0000)]
last unix group not being listed.  spotted by jacques sansdrap.
(This used to be commit 2d5fc5c7cf2086c396c853c13a3409bfac77d05c)

22 years agoproblem been there for months: reg_r_info not aligning after string buffer.
Luke Leighton [Thu, 18 Feb 1999 18:50:44 +0000 (18:50 +0000)]
problem been there for months: reg_r_info not aligning after string buffer.
(This used to be commit 66e2787ab7db72fb654b995280b294738e77e50a)

22 years agoGot to the bottom of another weird one...
Michael Warfield [Thu, 18 Feb 1999 04:33:06 +0000 (04:33 +0000)]
Got to the bottom of another weird one...

Piping the output of smbmount back to autofs/automount was causing the
automount process to hang.  Reason was that automount was depending
on the pipe to close to continue on, rather than detecting the child
signal.  This occured with debug enabled and the daemon process was not
closing the stdout process.  Disabling debuging avoids the problem.
Debugging is turned off in the cvs repository and a warning placed over
the debugging option.
(This used to be commit 329ceaee49fa0175f78873433bd942865309f633)

22 years agorpcclient shutdown command
Luke Leighton [Tue, 16 Feb 1999 18:04:21 +0000 (18:04 +0000)]
rpcclient shutdown command
(This used to be commit 59f081069a58f6a070ed6016c06153d5e695da93)

22 years agobitmap to strings
Luke Leighton [Tue, 16 Feb 1999 18:02:50 +0000 (18:02 +0000)]
bitmap to strings
(This used to be commit ba5919bcaefa792bae503c7ab19d4b7bbf9bb954)

22 years agoAlways null-terminate strings.
Matthew Chapman [Mon, 15 Feb 1999 05:33:30 +0000 (05:33 +0000)]
Always null-terminate strings.
Also some string length and sizeof(pointer) corrections.
(This used to be commit ce24191939b82985d09eabe945199f38b0fea486)

22 years agoAlways null-terminate strings.
Matthew Chapman [Mon, 15 Feb 1999 05:31:52 +0000 (05:31 +0000)]
Always null-terminate strings.
(This used to be commit b314430b2102e47529b093b1b98b5b6f3b6ea74f)

22 years agoAdded caching of user password if it was entered via getpass. We were already
Michael Warfield [Sun, 14 Feb 1999 23:15:54 +0000 (23:15 +0000)]
Added caching of user password if it was entered via getpass.  We were already
caching the password if it came from the command line or from the environment.
This completes the set and deals with the bloody nusance when reconnecting
a connection after we have gone daemon...  Grrr...

Added code to clean up the mount point following a catastrophic failure
during reconnect.  The smbmount daemon was exiting but leaving the mount
point in an unusable state.  If smbmount must exit following a reconnect
failure, we "unmount" the mount point and clean up mnttab.  Currently,
the unmount works, fixing some really ugly I/O errors and failure when
trying to remount.  The cleanup on mnttab still has problems.  This
is better than what it was and doesn't break anything that wasn't broken
before, so I'm committing this in even with the mnttab problem.  Will
commit the fix to that when I figure out what is busted there...

(This used to be commit ad8389804cec6c6bf04601a1d7bb3fb7aa8c2274)

22 years agoFolding into Samba-2.1.X tree documents added to 2.0.3.
John Terpstra [Sun, 14 Feb 1999 04:40:05 +0000 (04:40 +0000)]
Folding into Samba-2.1.X tree documents added to 2.0.3.
(This used to be commit 1041d53ec246debac0050bdc7e9a6cd72e9ecf49)

22 years ago Fixed a glibc glitch in smbumount.c and reenabled some debugging
Michael Warfield [Sat, 13 Feb 1999 18:36:49 +0000 (18:36 +0000)]
Fixed a glibc glitch in smbumount.c and reenabled some debugging
in smbmount.c
(This used to be commit 4b4a706213032ad49a0653e80721bac5f6284f90)

22 years agoconst cast issues. [p.s - tidy work, matt!]
Luke Leighton [Fri, 12 Feb 1999 15:35:27 +0000 (15:35 +0000)]
const cast issues.  [p.s - tidy work, matt!]
(This used to be commit dad5baef194b18c674c0d908a0e0714c0a1aefa4)

22 years agoconst issues with byte mod / byte read macros.
Luke Leighton [Fri, 12 Feb 1999 15:34:57 +0000 (15:34 +0000)]
const issues with byte mod / byte read macros.
(This used to be commit 98ecb88704c3db26de8b548f4f1526f23401a161)

22 years agoCut and paste error.
Matthew Chapman [Fri, 12 Feb 1999 03:09:24 +0000 (03:09 +0000)]
Cut and paste error.
(This used to be commit 9ea91d89d2a1baa67f5143ecc08eb60c93213242)

22 years agoUNICODE cleanup (see lib/util_unistr.c).
Matthew Chapman [Fri, 12 Feb 1999 00:16:09 +0000 (00:16 +0000)]
UNICODE cleanup (see lib/util_unistr.c).

No more ugly static library buffers and all functions take a destination
string length (especially unistrcpy was rather dangerous; we were only
saved by the fact that datagrams are limited in size).
(This used to be commit a1d39af1ce1d451b811dbd7c2ba391214851b87e)

22 years agoUNICODE issues.
Luke Leighton [Thu, 11 Feb 1999 22:12:49 +0000 (22:12 +0000)]
UNICODE issues.
(This used to be commit 6a437cfb33f24913e0c1f8484c0b08ef317e513b)

22 years agothe UNICODE issue...
Luke Leighton [Thu, 11 Feb 1999 18:50:13 +0000 (18:50 +0000)]
the UNICODE issue...
(This used to be commit 73db80f34183324845407b00f58462ff2d7b47ea)

22 years agoenum dom users buffer was 0x80 not 0x8000. must fix "enumeration" code
Luke Leighton [Thu, 11 Feb 1999 18:48:18 +0000 (18:48 +0000)]
enum dom users buffer was 0x80 not 0x8000.  must fix "enumeration" code
as you need to make multiple enum dom users calls.
(This used to be commit b5396d3c6de4b8cb0e981bab10367e5838f78a53)

22 years agorefinement of random ipc$ SMBtrans torture test. send requests, and
Luke Leighton [Thu, 11 Feb 1999 18:35:26 +0000 (18:35 +0000)]
refinement of random ipc$ SMBtrans torture test.  send requests, and
don't wait for responses :-)
(This used to be commit c1d65e906054297e42d6d177194d3b9ab16c7e35)

22 years agouninitialised pointer being freed if lookupnames failed. oops.
Luke Leighton [Thu, 11 Feb 1999 17:25:26 +0000 (17:25 +0000)]
uninitialised pointer being freed if lookupnames failed.  oops.
(This used to be commit d77de868588b6291353fa7a426b6e5da4b5f2c49)

22 years agouse jeremy's versions of the UNICODE routines.
Luke Leighton [Wed, 10 Feb 1999 22:30:47 +0000 (22:30 +0000)]
use jeremy's versions of the UNICODE routines.
(This used to be commit c5109ff782be8774db47a92b48ca6335ec8d6065)

22 years agoHaving Well-known Domain Groups ("Domain Admins/Guests/Users") returned
Luke Leighton [Tue, 9 Feb 1999 22:13:20 +0000 (22:13 +0000)]
Having Well-known Domain Groups ("Domain Admins/Guests/Users") returned
under SID_NAME_ENUM 0x5 instead of 0x2 (Well-known group instead of
Domain Group) was making it impossible to view these groups from USRMGR.EXE.
(This used to be commit 3072044134eadbf46350b32c1ed0703681b0d590)

22 years agogroups and aliases being "manually" added which do not necessarily have
Luke Leighton [Tue, 9 Feb 1999 21:56:06 +0000 (21:56 +0000)]
groups and aliases being "manually" added which do not necessarily have
representation in the underlying database: removed this code.

for example, with the nt->unix mapping system (don't know about the ldap
one) if you want "Domain Admins" to appear you _must_ put it in the file.

the previous code was adding builtin aliases and well-known groups even
if they weren't in the domain maps.  bad idea.
(This used to be commit 56469578a1af0fbcf6edddf94c498c7bbfb385c6)

22 years agowhen multiple independent large rpc calls come in on the same pipe,
Luke Leighton [Tue, 9 Feb 1999 21:42:39 +0000 (21:42 +0000)]
when multiple independent large rpc calls come in on the same pipe,
prev_pdu_file_offset was not being re-initialised to zero.
(This used to be commit fcaa1214412f5a417a648d4da5c4332f75f59f57)

22 years agoremoval of the use of unistrn2 function: replace it with unistr2_to_str
Luke Leighton [Tue, 9 Feb 1999 19:51:44 +0000 (19:51 +0000)]
removal of the use of unistrn2 function: replace it with unistr2_to_str
which is more appropriate.
(This used to be commit ac72fe1ab3d10f64a5945ccbd4ed3817e30f9f7b)

22 years agopwdb_smb_to_sam was not returning NULL for nt name so that
Luke Leighton [Tue, 9 Feb 1999 16:01:28 +0000 (16:01 +0000)]
pwdb_smb_to_sam was not returning NULL for nt name so that
pwdb_sam_map_names() was using a "blank" static string instead of
a NULL pointer for nt names.  NULL means over-ride, so the nt name
got left as "blank".

this causes nt clients to terminate with extreme prejudice.
(This used to be commit ddd350198202d6a1d2c715b3dce7db3a5d76a63a)

22 years agoFix for NT BSOD problem. There's no reason to have two "NT usernames" running
Matthew Chapman [Tue, 9 Feb 1999 03:57:10 +0000 (03:57 +0000)]
Fix for NT BSOD problem. There's no reason to have two "NT usernames" running
around anyway.

The real problem is, once again, the brokenness of pwdb_sam_map_names et al.
This time it is deciding to return blank NT usernames, which NT's redirector
objects to.

I'm currently working on improving the pwdb/mapping code, should be ready in a
couple of weeks.
(This used to be commit 30a085bf80982c619cd78aee9ad410ece5f88679)

22 years agoUNICODE byte ordering issue: typecast to uint16* replaced with SSVAL()
Luke Leighton [Mon, 8 Feb 1999 23:40:49 +0000 (23:40 +0000)]
UNICODE byte ordering issue: typecast to uint16* replaced with SSVAL()
(This used to be commit 9084b7e33dfe717bd8d5604ee71d137e3baef0f5)

22 years agoreload_services needs to be called prior to init_files but after
Luke Leighton [Mon, 8 Feb 1999 01:46:46 +0000 (01:46 +0000)]
reload_services needs to be called prior to init_files but after
(This used to be commit 9ab81caa065a0e08368fc9137d42ed810fd4b817)

22 years agoiteration of sam passwd entries was an order n-cubed algorithm due
Luke Leighton [Mon, 8 Feb 1999 00:24:57 +0000 (00:24 +0000)]
iteration of sam passwd entries was an order n-cubed algorithm due
to resolution of unix name to nt name being unnecessarily _inside_
another loop.
(This used to be commit d455c9d2c9f60289d78d0331228f5922152070bf)

22 years agoinitialise my name (used in %h) prior to loading smb.conf files.
Luke Leighton [Wed, 3 Feb 1999 17:10:44 +0000 (17:10 +0000)]
initialise my name (used in %h) prior to loading smb.conf files.
(This used to be commit ed128c38a88746ec7822d598e72f0106a30a4af7)

22 years ago%s not $s
Luke Leighton [Wed, 3 Feb 1999 16:30:54 +0000 (16:30 +0000)]
%s not $s
(This used to be commit 62118e15fed8c9a7e13705842d0ae59669a2dd8f)

22 years agocorrections to get data stream for 2nd and subsequent pdus copied from
Luke Leighton [Wed, 3 Feb 1999 01:58:52 +0000 (01:58 +0000)]
corrections to get data stream for 2nd and subsequent pdus copied from
right place (forgot to subtract 0x18 header bytes)
(This used to be commit 5b9a7278da4a25ea217f914c8daae31238fa5cfe)

22 years agocache unix groups so that two-level getgrent calls don't occur.
Luke Leighton [Wed, 3 Feb 1999 00:49:24 +0000 (00:49 +0000)]
cache unix groups so that two-level getgrent calls don't occur.
(This used to be commit f7dfa55a2e191ae780d399026bce48f68cda4bf0)

22 years agomultiple dce/rpc PDUs failed to work after ntlmssp update was added.
Luke Leighton [Wed, 3 Feb 1999 00:48:27 +0000 (00:48 +0000)]
multiple dce/rpc PDUs failed to work after ntlmssp update was added.
(This used to be commit f082f07e764c04b75b6880f852b80faec86f1b1c)

22 years agoserver type announcements modified to include the "role" of the server:
Luke Leighton [Tue, 2 Feb 1999 19:53:10 +0000 (19:53 +0000)]
server type announcements modified to include the "role" of the server:
domain member, pdc, bdc.
(This used to be commit d95bb252f838b3612f5eba5d2b61d7b38b01f5ef)

22 years agoMinor change to bring smbmount in the main branch in line with some bzero
Michael Warfield [Mon, 1 Feb 1999 22:01:29 +0000 (22:01 +0000)]
Minor change to bring smbmount in the main branch in line with some bzero
to memset changes...
(This used to be commit 1cb8fcb33bb9e930d8f3cba4cc1ba5aa880c5f8e)

22 years agocomma after DOM_MAP_USER removed
Luke Leighton [Mon, 1 Feb 1999 16:32:01 +0000 (16:32 +0000)]
comma after DOM_MAP_USER removed
(This used to be commit ce1ae86cbd8dec18ff981d1fce05ed660e263f38)

22 years agoMust set password length to 24 after we encrypt a password.
Matthew Chapman [Mon, 1 Feb 1999 05:25:54 +0000 (05:25 +0000)]
Must set password length to 24 after we encrypt a password.
(This used to be commit af83778abc5fae0df53ed1874181e33bc8de8d94)

22 years agoInitialise NTTIME properly in make_reg_q_enum_key instead of using
Matthew Chapman [Mon, 1 Feb 1999 02:39:37 +0000 (02:39 +0000)]
Initialise NTTIME properly in make_reg_q_enum_key instead of using
unix_to_nt_time hack. Seems to me it's ignored anyway (dummy return
(This used to be commit 1e3873111faf352ef14a098eff250b505ab0b800)

22 years agoFixed a domain functionality problem where NT clients would start
Matthew Chapman [Mon, 1 Feb 1999 02:37:45 +0000 (02:37 +0000)]
Fixed a domain functionality problem where NT clients would start
endlessly repeating a network SAMLOGON (hoping it to change, hmmm...).

( Guess what I found in pwdb_init_sam...

  unix_to_nt_time(&user->logon_time, (time_t)-1);
  unix_to_nt_time(&user->logoff_time, (time_t)-1);
  unix_to_nt_time(&user->kickoff_time, (time_t)-1);
  ... )
(This used to be commit e9c79c85e6d1352693ab13e907b07d4706975891)

22 years agoAdded init_nt_time function which initialises an NTTIME to -1.
Matthew Chapman [Mon, 1 Feb 1999 02:36:24 +0000 (02:36 +0000)]
Added init_nt_time function which initialises an NTTIME to -1.
(This used to be commit e1e3875057bed830fdc0aaa9c85f04a1479fd64a)

22 years agoOk... Yet another round of fixes for smbmount and autofs.
Michael Warfield [Sun, 31 Jan 1999 21:28:55 +0000 (21:28 +0000)]
Ok...  Yet another round of fixes for smbmount and autofs.

1)  The earlier fix for the smbmount race conditions broke the PID
registration with smbfs.  That fix has been backed out and
replaced by a signalling convention from the child smbmount
process back to the parent telling the parent when it is safe
to exit.

2)  Fixing all of this uncovered a NASTY deadly embrace between smbmount,
smbmnt, and autofs.  This was caused by the setsid call in the
daemon code.  The smbmnt process no longer was registered as
"magic" because it was no longer in the autofs process group.
Many many kudos and thanks to H Peter Anvin for giving me the
clue to solving this agravating puzzle.  The setsid was moved
down the where the child signals the parent and a warn left in
its place in the daemonize code.

3)  Fixed (actually worked around with a BUTT UGLY HACK) a problem with
SMB_GET_MOUNTPID in smbumount.c.  The smb_fs.h header file has
the parameter to this ioctl defined as a uid_t.  Unfortunately
that's a 32 bit quantity under glibc and it's currently a 16 bit
quantity in kernel space.  Undefined the macro and redefined
it with a parameter of __kernel_uid_t.  That should keep us
out of trouble till I can have someone fix smb_fs.h in the
kernel sources...
(This used to be commit c5608093e48ed7fd3b7a1e2a4b1af7e4e59fc2f9)

22 years agofix for enumerate domain users (bug spotted by sean matthews).
Luke Leighton [Fri, 29 Jan 1999 21:22:08 +0000 (21:22 +0000)]
fix for enumerate domain users (bug spotted by sean matthews).

also needed to use start index properly and generate next index.

both client and server code need to recognise error code 0x105
when there's not enough room to store all the users in one call.

sort this out another time.
(This used to be commit ad58cdfac6b85d9431216e32e532ad4d60f9c6dd)

22 years agoremoved encrypt-password code pre-cli_session_setup(), session setup
Luke Leighton [Fri, 29 Jan 1999 19:31:52 +0000 (19:31 +0000)]
removed encrypt-password code pre-cli_session_setup(), session setup
fn decides whether to encrypt password or not.
(This used to be commit 6d14db6a6c101e86b3c62d5098a05d29ae4e9cd8)

22 years agouni_svc_name not uni_srv_name
Luke Leighton [Fri, 29 Jan 1999 19:20:27 +0000 (19:20 +0000)]
uni_svc_name not uni_srv_name
(This used to be commit 14080a564a24f8f35cb8711b912c46f7243cd723)

22 years agorpcclient "Service Control Manager" svcenum [-i] command.
Luke Leighton [Thu, 28 Jan 1999 21:11:15 +0000 (21:11 +0000)]
rpcclient "Service Control Manager" svcenum [-i] command.
(This used to be commit a022710f1e3996ecbe6bbe035e1df0bc4c050b34)

22 years agoerror code cleanup
Luke Leighton [Thu, 28 Jan 1999 21:10:38 +0000 (21:10 +0000)]
error code cleanup
(This used to be commit 61c40982d6fde34729dc6850cf3372482392f4c9)

22 years agoreturned cli_session_setup to previous behaviour. added a couple of
Luke Leighton [Thu, 28 Jan 1999 18:40:53 +0000 (18:40 +0000)]
returned cli_session_setup to previous behaviour.  added a couple of
validation checks and also added capability to send plaintext passwords.
send "ntpasslen" of zero to do this.  sending same plaintext password
for pass and ntpass arguments will result in previous behaviour of
encrypting password if server supports it.
(This used to be commit 17f4c5a785cf20901bcb76510e5ea9b0a6928115)

22 years agoService Control Manager - service enumeration.
Luke Leighton [Wed, 27 Jan 1999 20:31:58 +0000 (20:31 +0000)]
Service Control Manager - service enumeration.
(This used to be commit f4dd8f6b566961890b2933b7a413241bf9b93797)

22 years agoset_port warning / unused / global/local variable overlap issues
Luke Leighton [Wed, 27 Jan 1999 19:37:29 +0000 (19:37 +0000)]
set_port warning / unused / global/local variable overlap issues

cmd_svcctl.c tests got put into cvs by mistake.
(This used to be commit 0ed70972d72533558f0fdd43e6ec95ac2102b9d0)

22 years agoFuss fuss fuss.
Christopher R. Hertel [Wed, 27 Jan 1999 18:22:48 +0000 (18:22 +0000)]
Fuss fuss fuss.

Added missing default: statements to two switch blocks.

Chris -)-----
(This used to be commit 0681f6946be2f7b528a1efb6adcc2366a2951644)

22 years ago- got client code cleartext passwords working again in cli_session_setup.
Luke Leighton [Wed, 27 Jan 1999 00:08:33 +0000 (00:08 +0000)]
- got client code cleartext passwords working again in cli_session_setup.
  needed this for some tests.

- removed code that said "if lm password is not encrypted then encrypt both
  lm and nt passwords".  actually it said "if lm password length is not 24
  bytes and we're in security=user mode..."

  it didn't bother to check whether the nt password was NULL or not, and
  doing the encryption inside cli_session_setup is the wrong place.

- checked all instances where cli_session_setup is called with cleartext
  passwords that are expected to then be encrypted (see above) with the
  test "if pwlen != 24...".  there was only one: all the others either
  provide encrypted passwords, do null sessions or use

* recommendation: use cli_establish_connection() in smbwrapper/smbw.c
(This used to be commit 2a509e9606f8aefbefa6e7b49878726464dbed44)

22 years agocompilation errors due to addition of smb file handle parameter.
Luke Leighton [Wed, 27 Jan 1999 00:03:31 +0000 (00:03 +0000)]
compilation errors due to addition of smb file handle parameter.
(This used to be commit 03967986ec6a92785b92fefce9e27b8bb088ea85)

22 years agoPutting back the -p flag in smbclient.
Richard Sharpe [Mon, 25 Jan 1999 01:46:14 +0000 (01:46 +0000)]
Putting back the -p flag in smbclient.

However, it seems that the -s flag
in smbclient is also ignored :-(
(This used to be commit f6c78192664d611d4663ed7459a2789315861eec)

22 years agoMore changes to get SSL working with 2.x.x
Richard Sharpe [Mon, 25 Jan 1999 00:36:45 +0000 (00:36 +0000)]
More changes to get SSL working with 2.x.x

Now, we have most of the configure support done, next
have to fix and other things ...
(This used to be commit 3598d90a325eaf90341832c1aa35ad17f6d34af7)

22 years agoFixing up configure to properly support ssl
Richard Sharpe [Sun, 24 Jan 1999 14:20:19 +0000 (14:20 +0000)]
Fixing up configure to properly support ssl
(This used to be commit 524c4d2978f8b951708ad30316e3d69ed1c39b75)

22 years agoAdding first of the fixes for SSL.
Richard Sharpe [Sun, 24 Jan 1999 14:08:55 +0000 (14:08 +0000)]
Adding first of the fixes for SSL.

A whole bunch of string variables in loadparm.c were
not being initialized properly.  Programs crashed as a result.

This set of code not tested, but same code tested elsewhere,
and all this guarded by #ifdef HAVE_SSL
(This used to be commit fb6048bb8655e8bd87cc69b48c99219d6701a907)

22 years agoIn security=user mode we must allow cli_connect_serverlist to connect to our
Matthew Chapman [Mon, 18 Jan 1999 01:35:43 +0000 (01:35 +0000)]
In security=user mode we must allow cli_connect_serverlist to connect to our
own smbd process, rather than complaining about a password server loop.
(This used to be commit 63d7822b9d87d085194de6895d3e271cedcd3c9a)

22 years agoAdded load_interfaces in smbpasswd to allow name resolution by broadcast and
Matthew Chapman [Mon, 18 Jan 1999 01:32:45 +0000 (01:32 +0000)]
Added load_interfaces in smbpasswd to allow name resolution by broadcast and
multiple interfaces. (Jeremy already committed this in SAMBA_2_0).
(This used to be commit f530e289c6f69961c51511e0220fdd886fbd2c78)

22 years agoA small change to clitar.c (really, I promise :-)
Richard Sharpe [Sun, 17 Jan 1999 01:03:52 +0000 (01:03 +0000)]
A small change to clitar.c (really, I promise :-)

If we are writing the tar file to stdout, set dbf to stderr
so that we do not screw up tar output with log info etc.

Compiles clean and tested with 38MB backup. Honest :-)
(This used to be commit 57301a3eb4723d0790822d3409da788fec4d8378)

22 years agoeclass != ERRDOS && num != ERRmoredata
Matthew Chapman [Fri, 15 Jan 1999 05:09:36 +0000 (05:09 +0000)]
eclass != ERRDOS && num != ERRmoredata
is not the same as
!(eclass == ERRDOS && num == ERRmoredata)

This was causing smbclient to segfault on receiving certain errors.
(This used to be commit 15bd172530af360cf16ad626330dfe2ea92100df)

22 years agoFixed typo in srv_samr.c where samr_add_groupmem and samr_del_groupmem were
Matthew Chapman [Fri, 15 Jan 1999 05:02:41 +0000 (05:02 +0000)]
Fixed typo in srv_samr.c where samr_add_groupmem and samr_del_groupmem were
the wrong way around.
(This used to be commit 2b6f4818858d422399321064245a36be1dba9738)

22 years agoFinally committing my LDAP changes.
Matthew Chapman [Fri, 15 Jan 1999 05:00:26 +0000 (05:00 +0000)]
Finally committing my LDAP changes.

* Added new APIs for modifying groups.
* RIDs are allocated similarly to NT, starting from 1000 and incrementing by 1
  for each new user/group.
* RIDs are now consistently in hex

* Fixed bugs reported by Allan Bjorklund <>:
   - ldap_close_connection is exported by OpenLDAP - changed to ldap_disconnect
   - Missing ldap_connect() in getusergroups functions
   - ldap_next_entry was being called too early while retrieving a sam_struct
   - LDAP globals should be extern in sampassldap.c

* Fixed bugs reported by Martin Hofbauer <>
   - Newly added workstation trust accounts had attributes DU rather than W.
   - User dn's were forced to start with "uid=XX" rather than using the existing
(This used to be commit 91c77f5432169553572bb4d85ad5f09d17524f20)

22 years agoFixed the "You password will expire in 0 days. Would you like to
Gerald Carter [Wed, 13 Jan 1999 00:48:25 +0000 (00:48 +0000)]
Fixed the "You password will expire in 0 days.  Would you like to
change it now?" message when you login to a Samba Controlled domain.

The fix is a hard coded 42 days from right now until you need to
change you pasword again time (see passdb/sampassdb.c:pwdb_smb_to_sam())

Also fixed getsmbfilepwent() so that it will read in the last password
change time correctly.

* Related to this lib/util_pwdb.c:StrnCaseCmp() returns 0 if the
strings match.  Chouldn't this be the pther way?  Oh well.  I
didn't change the return code as it was used in several
other cases (see lib/util_pwdb.c:pwdb_get_last_set_time())
(This used to be commit 175e598dccd042c0f8b045db45fbe3ae928a7387)

22 years agofixed an uninitialized variable in lookupsmbgrpgid() and
Gerald Carter [Wed, 13 Jan 1999 00:40:04 +0000 (00:40 +0000)]
fixed an uninitialized variable in lookupsmbgrpgid() and
lookupsmbpwuid that was causing a SEGFAULT in smbd.
(This used to be commit cabc7e739cb6a6c8dfc4b6988a8ef5837e3312d2)

22 years agoUpdated the docs to match the changes I made to debug2html.
Christopher R. Hertel [Tue, 29 Dec 1998 21:16:08 +0000 (21:16 +0000)]
Updated the docs to match the changes I made to debug2html.
Chris -)-----
(This used to be commit fcbdf5fe9790298d519b678ff3a6121641c1e6d9)

22 years agoWhile writing the man page, I realized that it was a bit silly not to accept
Christopher R. Hertel [Tue, 29 Dec 1998 20:43:01 +0000 (20:43 +0000)]
While writing the man page, I realized that it was a bit silly not to accept
command-line parameters.  I've added that capability.  Of course, the man
page is now wrong.  Sigh.

Chris -)-----
(This used to be commit 300a8c9e5077206b706c522c0b4288b00b7afda7)

22 years agoFirst go at documentation for debug2html.
Christopher R. Hertel [Tue, 29 Dec 1998 18:57:38 +0000 (18:57 +0000)]
First go at documentation for debug2html.

Chris -)-----
(This used to be commit a045186d4d5d8121f46ffc380aeca1904e0686fe)

22 years agoSorry that this is going so slowly.
Christopher R. Hertel [Mon, 28 Dec 1998 22:34:08 +0000 (22:34 +0000)]
Sorry that this is going so slowly.

I've added debug2html to so that it compiles as part of the
normal build.  Fixed a typo in debug2html.c as well.

One problem:  I found it necessary to link with both $(PARAM_OBJ) and
              $(LIB_OBJ).  The result is an executable that is much larger
              than it really needs to be.
(This used to be commit d2d6f0bf362d376f39d0ec7e4b6651ca2b8c8819)

22 years agoModified packaging-prep script to remove use of "rm -f *".
John Terpstra [Sun, 27 Dec 1998 22:31:50 +0000 (22:31 +0000)]
Modified packaging-prep script to remove use of "rm -f *".
(This used to be commit 1d9540bfc00381cd86f47e5673d902352e9f4b55)

22 years agoChanging to PHT standard SPEC settings.
John Terpstra [Mon, 21 Dec 1998 10:12:27 +0000 (10:12 +0000)]
Changing to PHT standard SPEC settings.
(This used to be commit bf2b97f5905419cdfe43b0f0f1f3b7b85881711a)

22 years agofix for potential lsass.exe crashing due to negative response from
Luke Leighton [Sun, 20 Dec 1998 00:37:24 +0000 (00:37 +0000)]
fix for potential lsass.exe crashing due to negative response from
LsaLookupNames being incorrect.  this is a bit wierd: why would the
lsass.exe on the nt _client_ crash due to an LsaLookupNames response
from a samba _server_?
(This used to be commit a15a3f95f2a14ab164ca758e2145444a803190b2)

22 years agoadding start of remote lookup for domain member role.
Luke Leighton [Sun, 20 Dec 1998 00:35:43 +0000 (00:35 +0000)]
adding start of remote lookup for domain member role.
(This used to be commit 090512e18770bab9222a30e68dee83d1612eca10)

22 years agolib_sec_ctxt.o not .c
Luke Leighton [Sun, 20 Dec 1998 00:31:18 +0000 (00:31 +0000)]
lib_sec_ctxt.o not .c
(This used to be commit 2485b8e706a2d0358f075dcb8b03bc75fa122ee1)

22 years agoUpdated makefile-path info contributed on the samba-technical mailing list.
John Terpstra [Sat, 19 Dec 1998 03:29:03 +0000 (03:29 +0000)]
Updated makefile-path info contributed on the samba-technical mailing list.
(This used to be commit bd3770235dd417d06e47d1ba16bcedc8a94e9ff9)

22 years agoFixed problems in debug code because I did not compile
Richard Sharpe [Sat, 19 Dec 1998 02:08:35 +0000 (02:08 +0000)]
Fixed problems in debug code because I did not compile
first :-(
(This used to be commit 47e36bed8fc3cec3a63087f30d680f2431bcfe55)

22 years agoAdded some debugging to clitar ...
Richard Sharpe [Sat, 19 Dec 1998 01:43:24 +0000 (01:43 +0000)]
Added some debugging to clitar ...
(This used to be commit b75af70990c3a9eaed9e3537b79e8e66a0ae8286)

22 years agoFixed tar recurse bug.
Jeremy Allison [Thu, 17 Dec 1998 22:44:56 +0000 (22:44 +0000)]
Fixed tar recurse bug.
(This used to be commit 7be5c8e8f734a2bd8f4e3c38b7f94c501ad35a19)

22 years agoFix bug with nmbd running wild due to recursion in retransmit_or_expire_response_reco...
Jeremy Allison [Thu, 17 Dec 1998 21:41:28 +0000 (21:41 +0000)]
Fix bug with nmbd running wild due to recursion in retransmit_or_expire_response_records().
(This used to be commit d5f05b4faef50e7cfc0ed05a87d92e14102106c6)

22 years agoand in head branch:
Andrew Tridgell [Thu, 17 Dec 1998 01:04:38 +0000 (01:04 +0000)]
and in head branch:

make sure we include sys/mman.h if available
(This used to be commit ccf644388732287da01a943ea826187b5394ebc6)

22 years agoA while back, Andrew and I talked about making the debug parsing code a
Christopher R. Hertel [Wed, 16 Dec 1998 18:50:54 +0000 (18:50 +0000)]
A while back, Andrew and I talked about making the debug parsing code a
better "fit" with other Samba code.  This is a small first step toward
doing what (I think) we agreed to do.

I've moved the key function from ubiqx/debugparse.c into lib/debug.c.  I
have also moved the enum from ubiqx/debugparse.h into the debug section in

The next thing to do is to get debug2html added into the so
that it is always produced when compiling the suite.

Chris -)-----
(This used to be commit 782474f41e0c2bc0b1f098758a3e5cb44e87d8b1)

22 years agoon Linux force fcntl/mmap based shared memory and on other systems
Andrew Tridgell [Tue, 15 Dec 1998 03:16:24 +0000 (03:16 +0000)]
on Linux force fcntl/mmap based shared memory and on other systems
force IPC/shmem based shared memory.
(This used to be commit ef5f752a4ae818d9c739a064410a02fa48a477e3)

22 years agoserver_cryptkey() now calling cli_connectserverlist(). stupid microsoft
Luke Leighton [Mon, 14 Dec 1998 21:22:59 +0000 (21:22 +0000)]
server_cryptkey() now calling cli_connectserverlist().  stupid microsoft
idiotic *SMBSERVER connectionism added to cli_connect_serverlist().
also added check for protocol < LANMAN2.
(This used to be commit c2bcb3a286f22ed4f0f55da2a3eb2bff17906fb1)