samba.git
11 years agosubunit: non-zero exit code if one or more testsuites failed.
Jelmer Vernooij [Fri, 12 Jun 2009 15:53:46 +0000 (17:53 +0200)]
subunit: non-zero exit code if one or more testsuites failed.

11 years agoselftest: Fix references to filenames with knownfailures and slow tests.
Jelmer Vernooij [Fri, 12 Jun 2009 15:45:15 +0000 (17:45 +0200)]
selftest: Fix references to filenames with knownfailures and slow tests.

11 years agoselftest: Document the fact that test runner and formatter are now
Jelmer Vernooij [Fri, 12 Jun 2009 13:54:50 +0000 (15:54 +0200)]
selftest: Document the fact that test runner and formatter are now
separate tools.

11 years agoFix wb_req_more(): Return 0 when done, read_pkt_send needs that
Volker Lendecke [Fri, 12 Jun 2009 15:27:58 +0000 (17:27 +0200)]
Fix wb_req_more(): Return 0 when done, read_pkt_send needs that

11 years agosubunit: Pass canonical names of test results to formatters and filters.
Jelmer Vernooij [Fri, 12 Jun 2009 13:05:59 +0000 (15:05 +0200)]
subunit: Pass canonical names of test results to formatters and filters.

11 years agoActivate tldap tracing in pdb_ads
Volker Lendecke [Fri, 12 Jun 2009 13:02:01 +0000 (15:02 +0200)]
Activate tldap tracing in pdb_ads

11 years agoAdd basic tracing of tldap messages
Volker Lendecke [Fri, 12 Jun 2009 12:52:35 +0000 (14:52 +0200)]
Add basic tracing of tldap messages

11 years agoAdd debugging facility to tldap, analogous to tevent
Volker Lendecke [Fri, 12 Jun 2009 12:50:46 +0000 (14:50 +0200)]
Add debugging facility to tldap, analogous to tevent

11 years agoselftest: Add option to strip output of succeeded tests, and use it on
Jelmer Vernooij [Fri, 12 Jun 2009 12:34:24 +0000 (14:34 +0200)]
selftest: Add option to strip output of succeeded tests, and use it on
the buildfarm.

The matches the behaviour we had earlier in the previous output format.

11 years agoselftest: Remove existing buildfarm output format.
Jelmer Vernooij [Fri, 12 Jun 2009 12:21:15 +0000 (14:21 +0200)]
selftest: Remove existing buildfarm output format.

11 years agoselftest: Output subunit on the buildfarm.
Jelmer Vernooij [Fri, 12 Jun 2009 12:21:03 +0000 (14:21 +0200)]
selftest: Output subunit on the buildfarm.

11 years agopackaging/Debian: Remove outdated Debian package sources and instead refer to
Jelmer Vernooij [Fri, 12 Jun 2009 00:55:26 +0000 (02:55 +0200)]
packaging/Debian: Remove outdated Debian package sources and instead refer to
Debian.org and SerNet packages.

11 years agoad-schema/license.txt: Fix typo.
Jelmer Vernooij [Thu, 11 Jun 2009 23:00:30 +0000 (01:00 +0200)]
ad-schema/license.txt: Fix typo.

11 years agoformat-subunit: Remove subunit output module.
Jelmer Vernooij [Thu, 11 Jun 2009 22:53:27 +0000 (00:53 +0200)]
format-subunit: Remove subunit output module.

We can still use "cat" to obtain a subunit stream from a subunit stream. :-)

11 years agos3: Call va_end() after all va_start()/va_copy() calls.
Andrew Kroeger [Thu, 11 Jun 2009 07:15:28 +0000 (02:15 -0500)]
s3: Call va_end() after all va_start()/va_copy() calls.

There are error paths in S3 where va_end() is not properly called after
va_start() or va_copy() have been called.

These issues were noted while performing an inspection for S4 bug #6129.  Thanks
to Erik Hovland <erik@hovland.org> for the original bug report.

11 years agoRevert "avoid crashes in ndr_print_*() calls"
Andrew Tridgell [Fri, 12 Jun 2009 05:37:48 +0000 (15:37 +1000)]
Revert "avoid crashes in ndr_print_*() calls"

This reverts commit f5a47dc4bf2793ab328c8b0e35adace497819e7d.

This change broke Samba3. We'll need to do it the long way.

11 years agotwo more NT status codes that we get on DRS with w2k8-R2
Andrew Tridgell [Fri, 12 Jun 2009 02:22:53 +0000 (12:22 +1000)]
two more NT status codes that we get on DRS with w2k8-R2

11 years agoavoid crashes in ndr_print_*() calls
Andrew Tridgell [Fri, 12 Jun 2009 02:22:25 +0000 (12:22 +1000)]
avoid crashes in ndr_print_*() calls

This is a hackish fix, but it will do for now

11 years agoalways enable RPC debugging with a debug level >= 100.
Andrew Tridgell [Thu, 11 Jun 2009 05:21:29 +0000 (15:21 +1000)]
always enable RPC debugging with a debug level >= 100.

This helps with tools where setting the binding string is not
possible, such as net

11 years agos3-docs: Fix Bug #4280. Shutdown scripts are called as root for privileged users.
Günther Deschner [Thu, 11 Jun 2009 22:46:38 +0000 (00:46 +0200)]
s3-docs: Fix Bug #4280. Shutdown scripts are called as root for privileged users.

GUenther

11 years agoselftest/buildfarm: Don't assume that a reason being specified is an indication of...
Jelmer Vernooij [Thu, 11 Jun 2009 22:19:02 +0000 (00:19 +0200)]
selftest/buildfarm: Don't assume that a reason being specified is an indication of failure.

11 years agosubunit-filter: Print names of skipped testsuites.
Jelmer Vernooij [Thu, 11 Jun 2009 22:08:19 +0000 (00:08 +0200)]
subunit-filter: Print names of skipped testsuites.

11 years agoAdd supportedCapabilities to our rootDSE
Andrew Bartlett [Thu, 11 Jun 2009 11:04:42 +0000 (21:04 +1000)]
Add supportedCapabilities to our rootDSE

This makes AD client tools happier, as they know they are talking to
an AD server.

per Bug 6229 by Matthieu Patou <mat@matws.net>

Andrew Bartlett

11 years agos4:heimdal: import lorikeet-heimdal-200906080040 (commit 904d0124b46eed7a8ad6e5b73e89...
Andrew Bartlett [Mon, 8 Jun 2009 09:06:16 +0000 (19:06 +1000)]
s4:heimdal: import lorikeet-heimdal-200906080040 (commit 904d0124b46eed7a8ad6e5b73e892ff34b6865ba)

Also including the supporting changes required to pass make test

A number of heimdal functions and constants have changed since we last
imported a tree (for the better, but inconvenient for us).

Andrew Bartlett

11 years agoFix bug #6297 - owner of sticky directory cannot delete files created by others.
Jeremy Allison [Thu, 11 Jun 2009 19:51:45 +0000 (12:51 -0700)]
Fix bug #6297 - owner of sticky directory cannot delete files created by others.
The reason we couldn't delete was we were erroring out early
if requestor was not the owner of the file we wanted to delete,
instead of checking if the requestor owned the directory as well.
If either of these is true, we must go on and check the ACL.
Karolin, this is a must for 3.4.0 and also 3.3.next. I'll update
the bug report with patches for 3.4.0 and 3.3.next and ask vl
to review.
Jeremy.

11 years agos3 passdb ads: add missing character
Tim Prouty [Thu, 11 Jun 2009 17:30:29 +0000 (10:30 -0700)]
s3 passdb ads: add missing character

11 years agos3: Prepare the rename path for passing smb_filename to SMB_VFS_CREATE_FILE
Tim Prouty [Thu, 11 Jun 2009 02:49:31 +0000 (19:49 -0700)]
s3: Prepare the rename path for passing smb_filename to SMB_VFS_CREATE_FILE

11 years agos3: Prepare the do_unlink path for passing smb_filname to SMB_VFS_CREATE_FILE
Tim Prouty [Wed, 10 Jun 2009 23:08:34 +0000 (16:08 -0700)]
s3: Prepare the do_unlink path for passing smb_filname to SMB_VFS_CREATE_FILE

11 years agos3: refactor utility function to handle splitting the directory from the mask
Tim Prouty [Wed, 10 Jun 2009 23:02:00 +0000 (16:02 -0700)]
s3: refactor utility function to handle splitting the directory from the mask

11 years agoselftest: Fix exit code for format-subunit.pl.
Jelmer Vernooij [Thu, 11 Jun 2009 17:59:26 +0000 (19:59 +0200)]
selftest: Fix exit code for format-subunit.pl.

11 years agoselftest: Fix uninitialized variables in selftest output.
Jelmer Vernooij [Thu, 11 Jun 2009 17:47:15 +0000 (19:47 +0200)]
selftest: Fix uninitialized variables in selftest output.

11 years agoFix Samba 3 selftest to use new selftest formatting functions.
Jelmer Vernooij [Thu, 11 Jun 2009 16:45:49 +0000 (18:45 +0200)]
Fix Samba 3 selftest to use new selftest formatting functions.

11 years agosubunit: Sort diff output.
Jelmer Vernooij [Fri, 5 Jun 2009 16:50:45 +0000 (18:50 +0200)]
subunit: Sort diff output.

11 years agoselftest: Make it easier to do subunit diffs from other apps.
Jelmer Vernooij [Fri, 5 Jun 2009 15:37:41 +0000 (17:37 +0200)]
selftest: Make it easier to do subunit diffs from other apps.

11 years agoselftest/subunit: Add diff command that can diff two subunit streams.
Jelmer Vernooij [Fri, 5 Jun 2009 15:25:42 +0000 (17:25 +0200)]
selftest/subunit: Add diff command that can diff two subunit streams.

11 years agoselftest: Properly recognize xfail testsuites.
Jelmer Vernooij [Fri, 5 Jun 2009 14:55:45 +0000 (16:55 +0200)]
selftest: Properly recognize xfail testsuites.

11 years agoselftest/subunit: Remove open_tests argument from parse_results.
Jelmer Vernooij [Fri, 5 Jun 2009 14:36:10 +0000 (16:36 +0200)]
selftest/subunit: Remove open_tests argument from parse_results.

11 years agoselftest: Fix subunit formatting, fix years when filtering subunit
Jelmer Vernooij [Fri, 5 Jun 2009 14:32:52 +0000 (16:32 +0200)]
selftest: Fix subunit formatting, fix years when filtering subunit
streams.

11 years agoselftest: Fix handling of testsuite, reintroduce progress indication.
Jelmer Vernooij [Fri, 5 Jun 2009 14:10:12 +0000 (16:10 +0200)]
selftest: Fix handling of testsuite, reintroduce progress indication.

11 years agoselftest: Remove unnecessary uses.
Jelmer Vernooij [Fri, 5 Jun 2009 12:13:07 +0000 (14:13 +0200)]
selftest: Remove unnecessary uses.

11 years agoselftest/subunit: Remove prefix command.
Jelmer Vernooij [Fri, 5 Jun 2009 12:06:32 +0000 (14:06 +0200)]
selftest/subunit: Remove prefix command.

11 years agoselftest: Fix subunit stream to include the right prefixes rather than
Jelmer Vernooij [Fri, 5 Jun 2009 11:16:46 +0000 (13:16 +0200)]
selftest: Fix subunit stream to include the right prefixes rather than
extending the subunit protocol.

11 years agoMore work supporting prefixes.
Jelmer Vernooij [Thu, 4 Jun 2009 15:30:23 +0000 (17:30 +0200)]
More work supporting prefixes.

11 years agoselftest: Use external processes for filtering known failures and pretty
Jelmer Vernooij [Thu, 4 Jun 2009 11:49:11 +0000 (13:49 +0200)]
selftest: Use external processes for filtering known failures and pretty
formatting.

11 years agoselftest: Avoid decreasing total testsuites if the original total is not
Jelmer Vernooij [Wed, 3 Jun 2009 16:33:50 +0000 (18:33 +0200)]
selftest: Avoid decreasing total testsuites if the original total is not
known.

11 years agoselftest: Use filter-xfail for known failures
Jelmer Vernooij [Wed, 3 Jun 2009 16:19:01 +0000 (18:19 +0200)]
selftest: Use filter-xfail for known failures

11 years agoselftest: Add script to filter out known failures from a subunit stream.
Jelmer Vernooij [Wed, 3 Jun 2009 16:10:15 +0000 (18:10 +0200)]
selftest: Add script to filter out known failures from a subunit stream.

11 years agoSubunit: Support "fail" as alias for "failure" in Subunit streams.
Jelmer Vernooij [Wed, 3 Jun 2009 16:08:54 +0000 (18:08 +0200)]
Subunit: Support "fail" as alias for "failure" in Subunit streams.

11 years agosubunit: Move more Subunit printing logic to Subunit.pm.
Jelmer Vernooij [Wed, 3 Jun 2009 16:03:45 +0000 (18:03 +0200)]
subunit: Move more Subunit printing logic to Subunit.pm.

11 years agosubunit: Support the time: command.
Jelmer Vernooij [Wed, 3 Jun 2009 15:39:54 +0000 (17:39 +0200)]
subunit: Support the time: command.

11 years agoselftest: Use subunit internally, and a separate test output formatter.
Jelmer Vernooij [Wed, 3 Jun 2009 15:23:09 +0000 (17:23 +0200)]
selftest: Use subunit internally, and a separate test output formatter.

11 years agoImplement pdb_enum_alias_memberships
Volker Lendecke [Thu, 11 Jun 2009 16:03:11 +0000 (18:03 +0200)]
Implement pdb_enum_alias_memberships

11 years agoFix build with external talloc.
Jelmer Vernooij [Thu, 11 Jun 2009 02:57:58 +0000 (04:57 +0200)]
Fix build with external talloc.

11 years agoFix build of recurusion fix in reopen_logs()
Andrew Bartlett [Thu, 11 Jun 2009 09:08:33 +0000 (19:08 +1000)]
Fix build of recurusion fix in reopen_logs()

11 years agoA script to compare the differences in nTSecurityDescriptor between 2 hosts
Nadezhda Ivanova [Fri, 29 May 2009 11:45:24 +0000 (14:45 +0300)]
A script to compare the differences in nTSecurityDescriptor between 2 hosts

This script walks the schema, configuration and domain partitions of the locally
installed Ldb and a remote hosts and compares the descriptors disregarding the
difference in domain SID. The goal is to make sure a freshly provisioned Samba
has the correct descriptors so ACLs work correctly. It outputs the descriptors
in short SDDL, where the correct SIDs are to be replaced during provisioning.
Optionally it can be output as an LDIF file with the current local domain and
domain SIDs.

11 years agoDon't recurse in reopen_logs().
Andrew Bartlett [Thu, 11 Jun 2009 08:53:14 +0000 (18:53 +1000)]
Don't recurse in reopen_logs().

Use the state to avoid recursion in reopen_logs(), as DEBUG() can call
this function.

Andrew Bartlett

11 years agoImplement pdb_ads_set_aliasinfo
Volker Lendecke [Wed, 10 Jun 2009 21:56:51 +0000 (23:56 +0200)]
Implement pdb_ads_set_aliasinfo

11 years agopdb_default_aliasinfo is just fine for pdb_ads right now
Volker Lendecke [Wed, 10 Jun 2009 21:56:20 +0000 (23:56 +0200)]
pdb_default_aliasinfo is just fine for pdb_ads right now

11 years agoImplement pdb_ads_lookup_rids
Volker Lendecke [Wed, 10 Jun 2009 10:54:05 +0000 (12:54 +0200)]
Implement pdb_ads_lookup_rids

11 years agoFix a segfault in pdb_ads_delete_user()
Volker Lendecke [Wed, 10 Jun 2009 09:48:31 +0000 (11:48 +0200)]
Fix a segfault in pdb_ads_delete_user()

If a user comes from the passdb cache, priv is NULL

11 years agos3: Prepare the first set of SMB_VFS_CREATE_FILE callers to take an smb_filename...
Tim Prouty [Wed, 10 Jun 2009 17:37:57 +0000 (10:37 -0700)]
s3: Prepare the first set of SMB_VFS_CREATE_FILE callers to take an smb_filename struct

Some of the callers required minimal changes, while others
(copy_internals) required significant changes.  The task is simplified
a little bit because we are able to do operations and checks on the
base_name when a stream isn't used.

This patch should cause no functional changes.

Volker, Jeremy: Please check

11 years agos3: Add utility function for copying an smb_filename struct
Tim Prouty [Wed, 10 Jun 2009 00:04:10 +0000 (17:04 -0700)]
s3: Add utility function for copying an smb_filename struct

11 years agos3: Remove the now unused CFF_DOS_PATH flag
Tim Prouty [Wed, 10 Jun 2009 17:49:21 +0000 (10:49 -0700)]
s3: Remove the now unused CFF_DOS_PATH flag
All paths are now unix paths, making this flag useless.

This flags argument is now unused and can be safely removed.

11 years agos3: Remove unix_convert handling from createfile implementations
Tim Prouty [Sat, 6 Jun 2009 03:24:17 +0000 (20:24 -0700)]
s3: Remove unix_convert handling from createfile implementations

11 years agos3: Make all callers of SMB_VFS_CREATEFILE call unix_convert first
Tim Prouty [Fri, 5 Jun 2009 01:39:55 +0000 (18:39 -0700)]
s3: Make all callers of SMB_VFS_CREATEFILE call unix_convert first

This step is a requirement to change SMB_VFS_CREATEFILE to take an
smb_filename struct.

11 years agos3: Remove extraneous calls to unix_convert
Tim Prouty [Wed, 10 Jun 2009 16:59:42 +0000 (09:59 -0700)]
s3: Remove extraneous calls to unix_convert

Not only are these unnecessary in spirit because unlink_internals
calls unix_convert, but in practice the return value is simply being
ignored right now.

11 years agos3: Remove unused stat structs being passed to SMB_VFS_CREATE_FILE
Tim Prouty [Fri, 5 Jun 2009 23:13:58 +0000 (16:13 -0700)]
s3: Remove unused stat structs being passed to SMB_VFS_CREATE_FILE

11 years agos3-libwbclient: fix unresolved symbols in libwbclient.
Günther Deschner [Wed, 10 Jun 2009 19:23:12 +0000 (21:23 +0200)]
s3-libwbclient: fix unresolved symbols in libwbclient.

Kai, please check.

Guenther

11 years agolib-util: move set_blocking() call into own file.
Günther Deschner [Wed, 10 Jun 2009 19:22:33 +0000 (21:22 +0200)]
lib-util: move set_blocking() call into own file.

Guenther

11 years agoMake ctemp async. Fix the test to pass against W2K3.
Jeremy Allison [Wed, 10 Jun 2009 18:58:00 +0000 (11:58 -0700)]
Make ctemp async. Fix the test to pass against W2K3.
Jeremy.

11 years agos3-build: Fix make test_shlibs and test_nss_modules.
Günther Deschner [Wed, 10 Jun 2009 15:25:12 +0000 (17:25 +0200)]
s3-build: Fix make test_shlibs and test_nss_modules.

Guenther

11 years agomount.cifs: explicitly handle non AF_INET/AF_INET6 addresses
Jeff Layton [Wed, 10 Jun 2009 13:00:21 +0000 (09:00 -0400)]
mount.cifs: explicitly handle non AF_INET/AF_INET6 addresses

If we get a non-AF_INET(6) address, then just skip it and try the next
one in the list.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
11 years agos3/docs: Fix typos.
Karolin Seeger [Wed, 10 Jun 2009 06:39:35 +0000 (08:39 +0200)]
s3/docs: Fix typos.

Fix typos reported by OPC oota <t-oota [at] dh.jp.nec.com>.
Thanks!

Karolin

11 years agofixed some places where RPC-SECRETS needs to be changed to RPC-LSA-SECRETS
Andrew Tridgell [Wed, 10 Jun 2009 02:24:12 +0000 (12:24 +1000)]
fixed some places where RPC-SECRETS needs to be changed to RPC-LSA-SECRETS

this copes with a rename of SECRETS to LSA-SECRETS in an earlier patch
by gd

11 years agofixed the encoding/decoding of the reverse attribute for server side sort
Andrew Tridgell [Wed, 10 Jun 2009 01:45:13 +0000 (11:45 +1000)]
fixed the encoding/decoding of the reverse attribute for server side sort

11 years agoadded asn1 functions for handling booleans in a simple context
Andrew Tridgell [Wed, 10 Jun 2009 01:44:47 +0000 (11:44 +1000)]
added asn1 functions for handling booleans in a simple context

11 years agoClarify and expand the Kerberos notes made by Andrew Bartlett in 2005
Donald T. Davis [Wed, 10 Jun 2009 01:38:27 +0000 (11:38 +1000)]
Clarify and expand the Kerberos notes made by Andrew Bartlett in 2005

Compiled with Andrew over a series of phone calls and gobby sessions,
with the aim of documenting Kerberos requirements for Samba to us an
alternate (ie, MIT) Kerberos library.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agoRemove copy of kerberos-notes.txt added in incorrect location
Andrew Bartlett [Wed, 10 Jun 2009 01:37:49 +0000 (11:37 +1000)]
Remove copy of kerberos-notes.txt added in incorrect location

11 years agoClarify and expand the Kerberos notes made by Andrew Bartlett in 2005
Donald T. Davis [Wed, 10 Jun 2009 01:16:09 +0000 (11:16 +1000)]
Clarify and expand the Kerberos notes made by Andrew Bartlett in 2005

Compiled with Andrew over a series of phone calls and gobby sessions
with Andrew, with the aim of documenting Kerberos requirements for
Samba to us an alternate (ie, MIT) Kerberos library.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agofixed server side sort control
Andrew Tridgell [Wed, 10 Jun 2009 00:33:53 +0000 (10:33 +1000)]
fixed server side sort control

when sorting a record that does not have the requested sort attribute
then put those records last in the sort result

11 years agofixed server side sorting of case-insensitive strings
Andrew Tridgell [Wed, 10 Jun 2009 00:13:55 +0000 (10:13 +1000)]
fixed server side sorting of case-insensitive strings

The sort module uses ldb_comparison_fold() as the comparison function
for case-insensitive attributes. In other places the function is being
used to produce a boolean, but for sorting we care about ordering.

The n1 - n2 return was sorting by length, not value

11 years agoIf there are no mods, don't bother the ldap server
Volker Lendecke [Tue, 9 Jun 2009 20:09:41 +0000 (22:09 +0200)]
If there are no mods, don't bother the ldap server

11 years agoSome more fields in pdb_ads_init_ads_from_sam()
Volker Lendecke [Tue, 9 Jun 2009 20:09:14 +0000 (22:09 +0200)]
Some more fields in pdb_ads_init_ads_from_sam()

11 years agoFix installation path of the subunit python modules.
Timur I Bakeyev [Tue, 9 Jun 2009 18:45:03 +0000 (20:45 +0200)]
Fix installation path of the subunit python modules.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
11 years agos4-tests: Add separate variable for tap2subunit.
Jelmer Vernooij [Tue, 9 Jun 2009 16:09:27 +0000 (18:09 +0200)]
s4-tests: Add separate variable for tap2subunit.

11 years agoDo not pull samAccountName twice
Volker Lendecke [Tue, 9 Jun 2009 19:46:04 +0000 (21:46 +0200)]
Do not pull samAccountName twice

11 years agos3:smbd: only check the next_status for related requests
Stefan Metzmacher [Tue, 9 Jun 2009 17:48:08 +0000 (19:48 +0200)]
s3:smbd: only check the next_status for related requests

metze

11 years agos3:smbd: response with the same SMB2 flags as given by the client
Stefan Metzmacher [Tue, 9 Jun 2009 17:46:29 +0000 (19:46 +0200)]
s3:smbd: response with the same SMB2 flags as given by the client

...but also add the response flag.

metze

11 years agos3:smbd: only pass the chained file handle for related compounded SMB2 requests
Stefan Metzmacher [Tue, 9 Jun 2009 17:31:15 +0000 (19:31 +0200)]
s3:smbd: only pass the chained file handle for related compounded SMB2 requests

metze

11 years agos3:smbd: make sure we pad compounded SMB2 responses to 8 bytes
Stefan Metzmacher [Tue, 9 Jun 2009 17:21:26 +0000 (19:21 +0200)]
s3:smbd: make sure we pad compounded SMB2 responses to 8 bytes

metze

11 years agos3:smbd: skip file handle checks for SMB2 compounded requests
Stefan Metzmacher [Tue, 9 Jun 2009 16:47:26 +0000 (18:47 +0200)]
s3:smbd: skip file handle checks for SMB2 compounded requests

metze

11 years agos3:smbd: more validation of the incoming SMB2 requests
Stefan Metzmacher [Mon, 8 Jun 2009 11:30:32 +0000 (13:30 +0200)]
s3:smbd: more validation of the incoming SMB2 requests

metze

11 years agos3:smbd: for now ignore all non NBT Session Message requests for SMB2
Stefan Metzmacher [Mon, 8 Jun 2009 11:15:00 +0000 (13:15 +0200)]
s3:smbd: for now ignore all non NBT Session Message requests for SMB2

metze

11 years agos3:smbd: don't include 1 byte padding for the dynamic buffer of SMB2 responses
Stefan Metzmacher [Tue, 9 Jun 2009 15:06:40 +0000 (17:06 +0200)]
s3:smbd: don't include 1 byte padding for the dynamic buffer of SMB2 responses

It seems that Windows 2008 and Windows 7 doesn't do this anymore.

metze

11 years agoSMB2-COMPOUND: add some tests for invalid requests
Stefan Metzmacher [Tue, 9 Jun 2009 16:13:53 +0000 (18:13 +0200)]
SMB2-COMPOUND: add some tests for invalid requests

TODO: check why the INVALID1 tests fails with --signing=required.

metze

11 years agos4:smb2srv: don't allow the related flag on the first request in a compounded chain
Stefan Metzmacher [Tue, 9 Jun 2009 17:32:30 +0000 (19:32 +0200)]
s4:smb2srv: don't allow the related flag on the first request in a compounded chain

metze

11 years agos4: smbcli_transport_send hit the socket right away if possible
Sam Liddicott [Tue, 9 Jun 2009 11:51:44 +0000 (12:51 +0100)]
s4: smbcli_transport_send hit the socket right away if possible

[Metze; "make test" on git master outputs exactly the same test summary
with our without this patch (apart from the "using seed" lines)]

If the transport socket is writable, then push the queue along
rather than wait until the caller returns back to the tevent loop.

This strategy keeps the sockets piping hot, and is particularly good
for cases where reading requests from one socket causes lots of
writes on another socket, or where lots of writes are made in a batch.

It doesn't matter if the socket is not writeable yet, packet_queue_run
will return quite cheaply in such a case.

Signed-off-by: Sam Liddicott <sam@liddicott.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agonet: Only use the in memory ccache when not already using a kerberos ticket in net ads
Kai Blin [Tue, 9 Jun 2009 16:05:50 +0000 (18:05 +0200)]
net: Only use the in memory ccache when not already using a kerberos ticket in net ads

11 years agos4:torture: add SMB2-COMPOUND test
Stefan Metzmacher [Mon, 8 Jun 2009 14:26:57 +0000 (16:26 +0200)]
s4:torture: add SMB2-COMPOUND test

metze

11 years agos4:smb2srv: correctly fail remaining compounded requests after a failure
Stefan Metzmacher [Tue, 9 Jun 2009 14:48:25 +0000 (16:48 +0200)]
s4:smb2srv: correctly fail remaining compounded requests after a failure

metze