samba.git
13 years agos4-dsdb: pass parent request to dsdb_module_*() functions
Andrew Tridgell [Mon, 17 Jan 2011 02:12:15 +0000 (13:12 +1100)]
s4-dsdb: pass parent request to dsdb_module_*() functions

this preserves the request hierarchy for dsdb_module_*() calls inside
dsdb ldb modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agoldb: added ldb_req_mark_trusted()
Andrew Tridgell [Mon, 17 Jan 2011 02:11:08 +0000 (13:11 +1100)]
ldb: added ldb_req_mark_trusted()

this is used to mark a ldb child request trusted, if the caller has
validated all inputs. This will be used when creating new child
requests with trusted inputs.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agoldb: inherit parent flags on child requests in modules
Matthias Dieter Wallnöfer [Mon, 17 Jan 2011 00:42:35 +0000 (11:42 +1100)]
ldb: inherit parent flags on child requests in modules

13 years agoweb_server: Display trivial placeholder page if SWAT could not be found.
Jelmer Vernooij [Sun, 16 Jan 2011 23:43:04 +0000 (00:43 +0100)]
web_server: Display trivial placeholder page if SWAT could not be found.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Jan 17 01:27:10 CET 2011 on sn-devel-104

13 years agoweb_server: Fix initialization.
Jelmer Vernooij [Sun, 16 Jan 2011 23:30:49 +0000 (00:30 +0100)]
web_server: Fix initialization.

13 years agoweb_server: Avoid references to swat. Load samba.web_server instead.
Jelmer Vernooij [Sun, 16 Jan 2011 23:25:42 +0000 (00:25 +0100)]
web_server: Avoid references to swat. Load samba.web_server instead.

13 years agoparam: Load web service by default.
Jelmer Vernooij [Sun, 16 Jan 2011 23:25:29 +0000 (00:25 +0100)]
param: Load web service by default.

13 years agos4:dsdb_find_nc_root - fix it up to let the provisioning work correctly
Matthias Dieter Wallnöfer [Sat, 15 Jan 2011 17:12:09 +0000 (18:12 +0100)]
s4:dsdb_find_nc_root - fix it up to let the provisioning work correctly

Use the temporary list unless we have at least the three main
"namingContexts" from the rootDSE available (Default, Configuration, Schema -
these are mandatory on all AD deployments!).

This bug has been discovered by Nadya in relation with her SD work.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Jan 15 19:01:11 CET 2011 on sn-devel-104

13 years agos4:auth/ntlm/auth_sam.c - fix call to "get_server_info_principal"
Matthias Dieter Wallnöfer [Sat, 15 Jan 2011 15:54:23 +0000 (16:54 +0100)]
s4:auth/ntlm/auth_sam.c - fix call to "get_server_info_principal"

This should obviously point to the wrapper not the call itself.

Found out by Tru64 host build warning.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Jan 15 18:05:59 CET 2011 on sn-devel-104

13 years agos3: Avoid some calls to cli_errstr
Volker Lendecke [Sat, 15 Jan 2011 15:32:00 +0000 (16:32 +0100)]
s3: Avoid some calls to cli_errstr

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 15 17:18:54 CET 2011 on sn-devel-104

13 years agos3: Convert cli_set_secdesc to cli_trans
Volker Lendecke [Sat, 15 Jan 2011 15:20:37 +0000 (16:20 +0100)]
s3: Convert cli_set_secdesc to cli_trans

13 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 15 Jan 2011 15:07:31 +0000 (16:07 +0100)]
s3: Fix some nonempty blank lines

13 years agos4:samr RPC server - always interpret filter integer values as signed
Matthias Dieter Wallnöfer [Sat, 15 Jan 2011 12:15:54 +0000 (13:15 +0100)]
s4:samr RPC server - always interpret filter integer values as signed

To prevent platform-dependant problems.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Jan 15 14:54:14 CET 2011 on sn-devel-104

13 years agoAdd OPLOCK4 test which explores how Windows copes with oplock and share mode breaks...
Jeremy Allison [Fri, 14 Jan 2011 23:15:01 +0000 (15:15 -0800)]
Add OPLOCK4 test which explores how Windows copes with oplock and share mode breaks on hard links.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Jan 15 00:59:46 CET 2011 on sn-devel-104

13 years agos4:web_server - immeditately assign "wdata" as private data for the stream socket
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 20:46:37 +0000 (21:46 +0100)]
s4:web_server - immeditately assign "wdata" as private data for the stream socket

This fixes bug #7887.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Jan 14 22:33:13 CET 2011 on sn-devel-104

13 years agos4:urgent_replication.py - remove a now superflous RELAX control
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 17:45:32 +0000 (18:45 +0100)]
s4:urgent_replication.py - remove a now superflous RELAX control

The LSA object creation protection changed to the trusted/untrusted
connection model.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Jan 14 19:30:52 CET 2011 on sn-devel-104

13 years agos4:samldb LDB module - fix "userAccountControl" handling
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 11:10:25 +0000 (12:10 +0100)]
s4:samldb LDB module - fix "userAccountControl" handling

"UF_ACCOUNTDISABLE" is only added automatically if no "userAccountControl" flags
are set on LDAP add operations.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Jan 14 18:29:07 CET 2011 on sn-devel-104

13 years agos3: Fix bug 7917: Yet another bug in chain_reply
Volker Lendecke [Fri, 14 Jan 2011 15:43:00 +0000 (16:43 +0100)]
s3: Fix bug 7917: Yet another bug in chain_reply

Found by Michael Hanscho <samba@micha.priv.at> with a WinCE client.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 14 17:42:05 CET 2011 on sn-devel-104

13 years agos3-waf: fix the build after rpc_winreg removal.
Günther Deschner [Fri, 14 Jan 2011 09:53:17 +0000 (10:53 +0100)]
s3-waf: fix the build after rpc_winreg removal.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 14 11:38:40 CET 2011 on sn-devel-104

13 years agoldb:ldb_dn.c - fix counter type in "ldb_dn_minimise"
Matthias Dieter Wallnöfer [Fri, 14 Jan 2011 08:38:41 +0000 (09:38 +0100)]
ldb:ldb_dn.c - fix counter type in "ldb_dn_minimise"

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Fri Jan 14 10:43:29 CET 2011 on sn-devel-104

13 years agos3:vfs aio_fork children do not go away
Christian Ambach [Thu, 13 Jan 2011 15:04:36 +0000 (16:04 +0100)]
s3:vfs aio_fork children do not go away

on RHEL 5.5, recvmsg() does not return when it is reading
from the socket and the process on the other side closes
its connection. This left aio children around that should
have gone already and were just wasting system resources.

This patch makes the child go away by writing invalid
data to it so that the child exits.

Pair-Programmed-With: Volker Lendecke <vl@samba.org>

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 14 09:57:18 CET 2011 on sn-devel-104

13 years agos3:vfs fix children cleanup in aio_fork
Christian Ambach [Thu, 13 Jan 2011 14:59:18 +0000 (15:59 +0100)]
s3:vfs fix children cleanup in aio_fork

the cleanup loop in aio_fork always stopped operation
on the first inactive child it found. In case lots of
children need to be reaped, it will take multiple runs
before all children are gone

13 years agowaf: this script does need bash
Andrew Tridgell [Fri, 14 Jan 2011 07:18:25 +0000 (18:18 +1100)]
waf: this script does need bash

this is a developer test script. It is not meant to be portable.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jan 14 09:10:20 CET 2011 on sn-devel-104

13 years agowaf: use PYTHONARCHDIR for installing python shared libs
Andrew Tridgell [Fri, 14 Jan 2011 06:20:01 +0000 (17:20 +1100)]
waf: use PYTHONARCHDIR for installing python shared libs

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jan 14 08:19:40 CET 2011 on sn-devel-104

13 years agowaf: new version of waf
Andrew Tridgell [Fri, 14 Jan 2011 06:19:22 +0000 (17:19 +1100)]
waf: new version of waf

this one adds PYTHONARCHDIR to fix bug 7905

thanks to Thomas Nagy for the fix!

13 years agos4-dsdb: only enforce the extended dn rules over ldap
Andrew Tridgell [Fri, 14 Jan 2011 05:39:28 +0000 (16:39 +1100)]
s4-dsdb: only enforce the extended dn rules over ldap

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri Jan 14 07:23:31 CET 2011 on sn-devel-104

13 years agos4-dsdb: removed the last use of samdb_search_*() from the dsdb ldb modules
Andrew Tridgell [Fri, 14 Jan 2011 04:46:32 +0000 (15:46 +1100)]
s4-dsdb: removed the last use of samdb_search_*() from the dsdb ldb modules

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: removed some more samdb_search_*() calls from samldb.c
Andrew Tridgell [Fri, 14 Jan 2011 04:21:42 +0000 (15:21 +1100)]
s4-dsdb: removed some more samdb_search_*() calls from samldb.c

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: replaced another use of samdb_search in a ldb module
Andrew Tridgell [Fri, 14 Jan 2011 00:47:49 +0000 (11:47 +1100)]
s4-dsdb: replaced another use of samdb_search in a ldb module

we should be using the dsdb_module_search*() calls

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: fixed primaryGroupID to use dsdb_module_search_dn()
Andrew Tridgell [Fri, 14 Jan 2011 00:37:09 +0000 (11:37 +1100)]
s4-dsdb: fixed primaryGroupID to use dsdb_module_search_dn()

this avoids using a multi-part extended DN in a search that hits the
check in extended_dn_in

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: fixed filtering of tokengroups
Andrew Tridgell [Thu, 13 Jan 2011 23:41:47 +0000 (10:41 +1100)]
s4-dsdb: fixed filtering of tokengroups

builtin groups are shown in user tokenGroups searches

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agoldb: new ABI file for 0.9.23
Andrew Tridgell [Thu, 13 Jan 2011 06:59:14 +0000 (17:59 +1100)]
ldb: new ABI file for 0.9.23

13 years agos4-kdc: don't ask for an extended DN for krbtgt_dn
Andrew Tridgell [Thu, 13 Jan 2011 06:40:29 +0000 (17:40 +1100)]
s4-kdc: don't ask for an extended DN for krbtgt_dn

otherwise msg->dn would be non-minimal and would fail in searches

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-test: added a tokengroups test
Andrew Tridgell [Thu, 13 Jan 2011 05:56:13 +0000 (16:56 +1100)]
s4-test: added a tokengroups test

this tests that the remote tokenGroups match the internally calculated
ones

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-samdb: give a more useful debug when we can't open the privileges db
Andrew Tridgell [Thu, 13 Jan 2011 05:55:34 +0000 (16:55 +1100)]
s4-samdb: give a more useful debug when we can't open the privileges db

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-auth: fixed status return
Andrew Tridgell [Thu, 13 Jan 2011 05:55:05 +0000 (16:55 +1100)]
s4-auth: fixed status return

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-samba-tool: fixed the gpo command to use the right DN for access checks
Andrew Tridgell [Thu, 13 Jan 2011 04:09:03 +0000 (15:09 +1100)]
s4-samba-tool: fixed the gpo command to use the right DN for access checks

13 years agos4-dsdb: minimise the DN in group expansion
Andrew Tridgell [Thu, 13 Jan 2011 01:26:24 +0000 (12:26 +1100)]
s4-dsdb: minimise the DN in group expansion

this DN we have came from an extended DN search, which means it may
have multiple extended components. We need to minimise the DN before
AD will accept it

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agoldb: added ldb_dn_minimise()
Andrew Tridgell [Thu, 13 Jan 2011 01:13:42 +0000 (12:13 +1100)]
ldb: added ldb_dn_minimise()

this removes any extraneous components from a DN. For an extended DN,
this means removing the string DN and all but the first extended
component.

This is needed as AD returns "invalid syntax" if you don't use
a minimal DN as the base DN for a search. A non-minimal DN also
doesn't ever match in a search expression.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dns: renamed DNS_TYPE_ZERO to DNS_TYPE_TOMBSTONE
Andrew Tridgell [Thu, 13 Jan 2011 00:10:27 +0000 (11:10 +1100)]
s4-dns: renamed DNS_TYPE_ZERO to DNS_TYPE_TOMBSTONE

we now know that these are tombstone records, with a timestamp

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: validate number of extended components
Andrew Tridgell [Thu, 13 Jan 2011 00:08:40 +0000 (11:08 +1100)]
s4-dsdb: validate number of extended components

this checks that the number of extended components in a DN is valid,
to match MS AD behaviour. We need to do this to ensure that our tools
don't try to do operations that will be invalid when used against MS
servers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agoldb: added ldb_dn_get_extended_comp_num()
Andrew Tridgell [Thu, 13 Jan 2011 00:07:15 +0000 (11:07 +1100)]
ldb: added ldb_dn_get_extended_comp_num()

this returns the number of extended components. We need this to
validate a DN in the extended_dn_in module

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-samba_tool Added ACL checking to python GPO management tool
Andrew Bartlett [Tue, 11 Jan 2011 07:40:54 +0000 (18:40 +1100)]
s4-samba_tool Added ACL checking to python GPO management tool

13 years agolibcli/security Add python bindings for se_access_check
Andrew Bartlett [Tue, 11 Jan 2011 06:39:25 +0000 (17:39 +1100)]
libcli/security Add python bindings for se_access_check

Andrew Bartlett

13 years agopyldb Simplify python wrappers for struct ldb_val (LdbValue)
Andrew Bartlett [Tue, 11 Jan 2011 05:45:39 +0000 (16:45 +1100)]
pyldb Simplify python wrappers for struct ldb_val (LdbValue)

Andrew Bartlett

13 years agos4-auth Add get and set methods for auth_session_info python wrapper
Andrew Bartlett [Tue, 11 Jan 2011 05:43:54 +0000 (16:43 +1100)]
s4-auth Add get and set methods for auth_session_info python wrapper

This allows the session key, security_token and credentials to be
manipulated from python.

Andrew Bartlett

Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>

13 years agos4-auth Add function to obtain any user's session_info from a given LDB
Andrew Bartlett [Wed, 22 Dec 2010 06:17:07 +0000 (17:17 +1100)]
s4-auth Add function to obtain any user's session_info from a given LDB

This will be a building block for a tokenGroups test, which can
compare against a remote server (in particular the rootDSE) against
what we would calculate the tokenGroups to be.

(this meant moving some parts out of the auth_sam code into the
containing library)

Andrew Bartlett

13 years agos4-auth use new dsdb_expand_nested_groups()
Andrew Bartlett [Tue, 21 Dec 2010 11:35:13 +0000 (22:35 +1100)]
s4-auth use new dsdb_expand_nested_groups()

This isn't quite as good as using tokenGroups, but that is only
available for BASE searches, and this isn't how the all the callers
work at the moment.

Andrew Bartlett

13 years agos4-dsdb Implement tokenGroups expansion directly in ldb operational module
Andrew Bartlett [Tue, 21 Dec 2010 11:34:16 +0000 (22:34 +1100)]
s4-dsdb Implement tokenGroups expansion directly in ldb operational module

This removes a silly cross-dependency between the ldb moudle stack and auth/

Andrew Bartlett

13 years agoFix bug #7909 - map SYNCHRONIZE acl permission statically in zfs_acl vfs module.
Paul B. Henson [Thu, 13 Jan 2011 18:16:13 +0000 (10:16 -0800)]
Fix bug #7909 - map SYNCHRONIZE acl permission statically in zfs_acl vfs module.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 13 20:02:32 CET 2011 on sn-devel-104

13 years agosecurity: Fixed incorrect indentation in create_descriptor.c
Nadezhda Ivanova [Thu, 13 Jan 2011 13:22:15 +0000 (15:22 +0200)]
security: Fixed incorrect indentation in create_descriptor.c

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Thu Jan 13 15:53:16 CET 2011 on sn-devel-104

13 years agos3-build: remove RPCCLI_WINREG subsystem.
Günther Deschner [Wed, 12 Jan 2011 21:55:43 +0000 (22:55 +0100)]
s3-build: remove RPCCLI_WINREG subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Thu Jan 13 15:06:36 CET 2011 on sn-devel-104

13 years agos3-waf: remove RPCCLI_WINREG subsystem.
Günther Deschner [Wed, 12 Jan 2011 21:55:34 +0000 (22:55 +0100)]
s3-waf: remove RPCCLI_WINREG subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-net_registry: prefer dcerpc_winreg_X functions.
Günther Deschner [Wed, 12 Jan 2011 21:53:52 +0000 (22:53 +0100)]
s3-net_registry: prefer dcerpc_winreg_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-net: prefer dcerpc_winreg_X functions.
Günther Deschner [Wed, 12 Jan 2011 20:59:23 +0000 (21:59 +0100)]
s3-net: prefer dcerpc_winreg_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-spoolss: no need to include cli_winreg header anymore.
Günther Deschner [Wed, 12 Jan 2011 20:11:44 +0000 (21:11 +0100)]
s3-spoolss: no need to include cli_winreg header anymore.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-rpcclient: prefer dcerpc_winreg_X functions.
Günther Deschner [Wed, 12 Jan 2011 20:11:17 +0000 (21:11 +0100)]
s3-rpcclient: prefer dcerpc_winreg_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-build: remove RPCCLI_SRVSVC subsystem.
Günther Deschner [Wed, 12 Jan 2011 12:25:51 +0000 (13:25 +0100)]
s3-build: remove RPCCLI_SRVSVC subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-waf: remove RPCCLI_SRVSVC subsystem.
Günther Deschner [Wed, 12 Jan 2011 12:25:42 +0000 (13:25 +0100)]
s3-waf: remove RPCCLI_SRVSVC subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-rpcclient: prefer dcerpc_srvsvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 12:22:08 +0000 (13:22 +0100)]
s3-rpcclient: prefer dcerpc_srvsvc_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-net: prefer dcerpc_srvsvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 12:11:41 +0000 (13:11 +0100)]
s3-net: prefer dcerpc_srvsvc_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-smbtree: prefer dcerpc_srvsvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 12:01:57 +0000 (13:01 +0100)]
s3-smbtree: prefer dcerpc_srvsvc_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-lanman: prefer dcerpc_srvsvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 12:00:49 +0000 (13:00 +0100)]
s3-lanman: prefer dcerpc_srvsvc_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-libsmbclient: prefer dcerpc_srvsvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 11:58:44 +0000 (12:58 +0100)]
s3-libsmbclient: prefer dcerpc_srvsvc_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-smbclient: prefer dcerpc_srvsvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 11:56:55 +0000 (12:56 +0100)]
s3-smbclient: prefer dcerpc_srvsvc_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-libnetapi: prefer dcerpc_srvsvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 11:51:07 +0000 (12:51 +0100)]
s3-libnetapi: prefer dcerpc_srvsvc_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-build: remove RPCCLI_NETLOGON subsystem.
Günther Deschner [Wed, 12 Jan 2011 11:12:32 +0000 (12:12 +0100)]
s3-build: remove RPCCLI_NETLOGON subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-waf: remove RPCCLI_NETLOGON subsystem.
Günther Deschner [Wed, 12 Jan 2011 11:12:22 +0000 (12:12 +0100)]
s3-waf: remove RPCCLI_NETLOGON subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-rpcclient: prefer dcerpc_netr_X functions.
Günther Deschner [Wed, 12 Jan 2011 11:08:42 +0000 (12:08 +0100)]
s3-rpcclient: prefer dcerpc_netr_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-winbind: prefer dcerpc_netr_X functions.
Günther Deschner [Wed, 12 Jan 2011 10:55:34 +0000 (11:55 +0100)]
s3-winbind: prefer dcerpc_netr_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-rpc_client: prefer dcerpc_netr_X functions.
Günther Deschner [Wed, 12 Jan 2011 10:36:06 +0000 (11:36 +0100)]
s3-rpc_client: prefer dcerpc_netr_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-net: prefer dcerpc_netr_X functions.
Günther Deschner [Wed, 12 Jan 2011 10:27:26 +0000 (11:27 +0100)]
s3-net: prefer dcerpc_netr_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-libnet: prefer dcerpc_netr_X functions.
Günther Deschner [Wed, 12 Jan 2011 10:21:18 +0000 (11:21 +0100)]
s3-libnet: prefer dcerpc_netr_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-libnetapi: prefer dcerpc_netr_X functions.
Günther Deschner [Wed, 12 Jan 2011 10:17:48 +0000 (11:17 +0100)]
s3-libnetapi: prefer dcerpc_netr_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-net: remove some pointless fstrings in "net rpc service".
Günther Deschner [Wed, 12 Jan 2011 18:12:07 +0000 (19:12 +0100)]
s3-net: remove some pointless fstrings in "net rpc service".

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-net: restructure "net rpc service" and add open_scm().
Günther Deschner [Wed, 12 Jan 2011 18:08:48 +0000 (19:08 +0100)]
s3-net: restructure "net rpc service" and add open_scm().

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-net: restructure "net rpc service" and add open_service().
Günther Deschner [Wed, 12 Jan 2011 18:00:16 +0000 (19:00 +0100)]
s3-net: restructure "net rpc service" and add open_service().

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-build: remove RPCCLI_SVCCTL subsystem.
Günther Deschner [Tue, 11 Jan 2011 22:22:18 +0000 (23:22 +0100)]
s3-build: remove RPCCLI_SVCCTL subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-waf: remove RPCCLI_SVCCTL subsystem.
Günther Deschner [Tue, 11 Jan 2011 22:22:07 +0000 (23:22 +0100)]
s3-waf: remove RPCCLI_SVCCTL subsystem.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos3-svcctl: prefer dcerpc_svcctl_X functions.
Günther Deschner [Tue, 11 Jan 2011 22:21:41 +0000 (23:21 +0100)]
s3-svcctl: prefer dcerpc_svcctl_X functions.

Guenther

Signed-off-by: Andreas Schneider <asn@samba.org>
13 years agos4:torture/nbench/nbench.c - initialise "n"
Matthias Dieter Wallnöfer [Sun, 9 Jan 2011 10:41:51 +0000 (11:41 +0100)]
s4:torture/nbench/nbench.c - initialise "n"

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Jan 12 20:38:02 CET 2011 on sn-devel-104

13 years agos4:dns_server/dlz_bind9.c - initialise "ret" variables
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 21:32:12 +0000 (22:32 +0100)]
s4:dns_server/dlz_bind9.c - initialise "ret" variables

13 years agos4:extended_dn_out LDB module - initialise "have_reveal_control"
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 21:21:13 +0000 (22:21 +0100)]
s4:extended_dn_out LDB module - initialise "have_reveal_control"

13 years agos4:librpc/rpc/dcerpc_connect.c - fix uninitialised variable
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 21:14:48 +0000 (22:14 +0100)]
s4:librpc/rpc/dcerpc_connect.c - fix uninitialised variable

13 years agoldb:ltdb_sequence_number - initialise "tmp_ctx" to prevent uninitialisation warning
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 21:04:32 +0000 (22:04 +0100)]
ldb:ltdb_sequence_number - initialise "tmp_ctx" to prevent uninitialisation warning

13 years agoldb:ldbsearch.c - fix possible uninitialised variable
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 21:08:40 +0000 (22:08 +0100)]
ldb:ldbsearch.c - fix possible uninitialised variable

And add a comparison for the "ret" result - this is more standard-oriented

13 years agotorture:drs/rpc/msds_intid.c - proof for the correct "intId"
Matthias Dieter Wallnöfer [Sun, 9 Jan 2011 10:38:53 +0000 (11:38 +0100)]
torture:drs/rpc/msds_intid.c - proof for the correct "intId"

"drs_attr" is uninitialised in this loop

13 years agos4:winbind/idmap.c - we cannot use "failed" until we are in a transaction
Matthias Dieter Wallnöfer [Sun, 9 Jan 2011 10:27:01 +0000 (11:27 +0100)]
s4:winbind/idmap.c - we cannot use "failed" until we are in a transaction

We've to wait until "trans" is initialised.

13 years agoldb:ltdb_sequence_number - check for an OOM exception
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 21:07:30 +0000 (22:07 +0100)]
ldb:ltdb_sequence_number - check for an OOM exception

13 years agoldb:ldb_dn_explode - remove/unify some duplicate initialisations
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 20:59:37 +0000 (21:59 +0100)]
ldb:ldb_dn_explode - remove/unify some duplicate initialisations

13 years agos4:dynconfig/dynconfig.h - fix ending newline warning
Matthias Dieter Wallnöfer [Sat, 8 Jan 2011 21:10:17 +0000 (22:10 +0100)]
s4:dynconfig/dynconfig.h - fix ending newline warning

13 years agodrsuapi.idl: add some more DRSUAPI_ATTID_* values
Stefan Metzmacher [Wed, 12 Jan 2011 14:48:30 +0000 (15:48 +0100)]
drsuapi.idl: add some more DRSUAPI_ATTID_* values

These will be use for "net rpc vampire passwd" in source3.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 12 19:51:53 CET 2011 on sn-devel-104

13 years agos3: Fix some nonempty blank lines
Volker Lendecke [Wed, 12 Jan 2011 17:12:29 +0000 (18:12 +0100)]
s3: Fix some nonempty blank lines

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 12 19:04:25 CET 2011 on sn-devel-104

13 years agos3-docs: Typos in rpcclient man page
Björn Baumbach [Tue, 11 Jan 2011 13:28:26 +0000 (14:28 +0100)]
s3-docs: Typos in rpcclient man page

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 12 18:13:54 CET 2011 on sn-devel-104

13 years agos3-docs: Typos in smbclient man page
Björn Baumbach [Tue, 11 Jan 2011 11:43:59 +0000 (12:43 +0100)]
s3-docs: Typos in smbclient man page

Signed-off-by: Stefan Metzmacher <metze@samba.org>
13 years agos3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking...
Björn Baumbach [Wed, 22 Dec 2010 14:20:29 +0000 (15:20 +0100)]
s3-rpcclient: Fix bug #7880: cmd_spoolss_deletedriver() returned without checking all architectures.

Continues now with next architecture if no driver is available.

Because of the broken behavior of the rpccli_*() functions,
we need special error code handling.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
13 years agos3-net: fix query_service_state() error handling.
Günther Deschner [Wed, 12 Jan 2011 12:57:08 +0000 (13:57 +0100)]
s3-net: fix query_service_state() error handling.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 12 15:22:56 CET 2011 on sn-devel-104

13 years agos3-net: add missing breaks in switch statement in get_share_info().
Günther Deschner [Wed, 12 Jan 2011 12:10:28 +0000 (13:10 +0100)]
s3-net: add missing breaks in switch statement in get_share_info().

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 12 14:31:05 CET 2011 on sn-devel-104

13 years agos3-drsuapi: fix error handling after converting to dcerpc_drsuapi_X functions.
Günther Deschner [Wed, 12 Jan 2011 12:41:16 +0000 (13:41 +0100)]
s3-drsuapi: fix error handling after converting to dcerpc_drsuapi_X functions.

Guenther

13 years agos3-libnetapi: add missing error check after switchting to dcerpc_wkssvc_X functions.
Günther Deschner [Wed, 12 Jan 2011 12:32:10 +0000 (13:32 +0100)]
s3-libnetapi: add missing error check after switchting to dcerpc_wkssvc_X functions.

Guenther