Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 07:25:26 +0000 (09:25 +0200)]
s4:CLDAP - "fill_netlogon_samlogon_reponse" - check for out of memory
Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 07:18:33 +0000 (09:18 +0200)]
s4:acl/descriptor LDB module - distinguish between root and default basedn
The first is the forest base DN, the second the domain base DN. At the moment
we assume that they are both the same but it hasn't to be so.
Nadia, I would invite you to fix the outstanding parts regarding this (I added
comments).
Matthias Dieter Wallnöfer [Mon, 12 Apr 2010 13:02:10 +0000 (15:02 +0200)]
s4:use "samdb_forest_name" for the forest DNS domainname lookup
Matthias Dieter Wallnöfer [Mon, 12 Apr 2010 12:15:34 +0000 (14:15 +0200)]
s4:dsdb/common/util.c - add a call which determines centrally the forest DNS domainname
Volker Lendecke [Fri, 9 Apr 2010 15:19:13 +0000 (17:19 +0200)]
s3: Cache the username map in gencache
This is for uses with a heavy-weight username map script
Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 06:57:07 +0000 (08:57 +0200)]
s4:remove "samdb_root_dn", "samdb_base_dn", "samdb_config_dn" and "samdb_schema_dn"
They aren't needed anymore.
Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 06:41:10 +0000 (08:41 +0200)]
Revert "s4:prefer "samdb_*_dn" basedn calls over the "ldb_get_*_dn" functions"
We should use the "ldb_get_*_basedn" calls since they are available in the LDB
library.
Matthias Dieter Wallnöfer [Tue, 13 Apr 2010 06:24:09 +0000 (08:24 +0200)]
s4:objectclass LDB module - remove a unneeded newline
Jeremy Allison [Tue, 13 Apr 2010 04:40:28 +0000 (21:40 -0700)]
Move to using 64-bit mid values in our internal open file database.
This will allow us to share logic much easier between SMB1 and SMB2
servers.
Jeremy
Andrew Tridgell [Tue, 13 Apr 2010 03:44:28 +0000 (13:44 +1000)]
build: cope with spaces in options passed to ./configure
Andrew Tridgell [Tue, 13 Apr 2010 02:41:26 +0000 (12:41 +1000)]
build: allow cross-builds to use shared libraries
Andrew Tridgell [Tue, 13 Apr 2010 01:45:38 +0000 (11:45 +1000)]
s4-tevent: up tevent version number
tevent now has tevent_re_initialise() which is needed for the s4 build
Andrew Tridgell [Tue, 13 Apr 2010 01:41:13 +0000 (11:41 +1000)]
build: check the type of implied dependencies
an implied dependency needs to be a library or module
Andrew Tridgell [Tue, 13 Apr 2010 01:27:24 +0000 (11:27 +1000)]
build: fixed a typo that prevented --bundled-libraries from working correctly
Jelmer noticed that --minimum-library-version=talloc:2.0.1 --bundled-libraries=!tevent
didn't do the right thing.
Andrew Tridgell [Mon, 12 Apr 2010 23:33:18 +0000 (09:33 +1000)]
build: cope with existing binaries in bin/ left over from the old build
Volker Lendecke [Mon, 12 Apr 2010 19:31:33 +0000 (21:31 +0200)]
s3: Apply some const
Matthias Dieter Wallnöfer [Mon, 12 Apr 2010 12:49:14 +0000 (14:49 +0200)]
s3/s4:netlogon IDL - fix up "struct netr_SamInfo6" regarding the "forest" attribute
According to MS-NRPC 2.2.1.4.13 this should be the DNS domainname, not the
forest one.
Matthias Dieter Wallnöfer [Mon, 12 Apr 2010 12:34:28 +0000 (14:34 +0200)]
s4:auth/auth_sam_reply.c - fix counter types
Matthias Dieter Wallnöfer [Mon, 12 Apr 2010 11:43:43 +0000 (13:43 +0200)]
s4:prefer "samdb_*_dn" basedn calls over the "ldb_get_*_dn" functions
Purely cosmetic change.
Matthias Dieter Wallnöfer [Mon, 12 Apr 2010 11:40:44 +0000 (13:40 +0200)]
s4:torture/ldap/ldap_sort.c - There should be used the "base_dn" not the "root_dn" for the sort test
The (forest) "root_dn" hasn't always to be the same as the (domain) "base_dn"!
Jelmer Vernooij [Mon, 12 Apr 2010 14:11:31 +0000 (16:11 +0200)]
selftest: Cope with strict.
Stefan Metzmacher [Mon, 12 Apr 2010 11:44:19 +0000 (13:44 +0200)]
s4:tortore/rpc/spoolss.c: fix declaration after code warning
metze
Andrew Tridgell [Mon, 12 Apr 2010 12:56:44 +0000 (22:56 +1000)]
s4-ldb: enable waf build of ldb without ldap backend
this is useful for cross-compilation testing, where getting all the
ldap deps installed can be hard
Andrew Tridgell [Mon, 12 Apr 2010 12:06:51 +0000 (22:06 +1000)]
build: added cross-compilation configure options
this enables use of a cross-compilation emulator, so configure tests
run on an emulator of the target platform
Nadezhda Ivanova [Mon, 12 Apr 2010 13:05:37 +0000 (16:05 +0300)]
Fixed a problem with provision missing the default_dir/etc directory.
Volker Lendecke [Fri, 9 Apr 2010 12:30:54 +0000 (14:30 +0200)]
s3: Little refactoring: Factor out skip_space
Volker Lendecke [Fri, 9 Apr 2010 12:28:44 +0000 (14:28 +0200)]
s3: Remove a bogus 0-check, "isspace" can not return true for \0
Volker Lendecke [Mon, 12 Apr 2010 08:34:29 +0000 (10:34 +0200)]
s3: Cache the result of the username map script
Stefan Metzmacher [Mon, 12 Apr 2010 10:49:58 +0000 (12:49 +0200)]
Remove unused pcp/ directory.
metze
Stefan Metzmacher [Mon, 12 Apr 2010 10:49:19 +0000 (12:49 +0200)]
Remove unused swat2 code
metze
Stefan Metzmacher [Mon, 12 Apr 2010 08:55:32 +0000 (10:55 +0200)]
s4:heimdal_build/wscript_build: avoid global deps for hostcc stuff
metze
Stefan Metzmacher [Mon, 12 Apr 2010 08:55:02 +0000 (10:55 +0200)]
lib/replace/wscript: avoid global deps for LIBREPLACE_HOSTCC
metze
Stefan Metzmacher [Mon, 12 Apr 2010 08:16:54 +0000 (10:16 +0200)]
wafsamba: don't add global dependencies to hostcc targets
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:47:49 +0000 (09:47 +0200)]
lib/replace/wscript: inline LIBREPLACE_EXT into 'replace' as the autoconf system does
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:44:47 +0000 (09:44 +0200)]
s4:param/wscript_build: 'dl' is provides via 'replace'
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:43:54 +0000 (09:43 +0200)]
lib/nss_wrapper/wscript_build: 'replace' already includes 'dl'
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:41:19 +0000 (09:41 +0200)]
lib/replace/wscript: add dependency to 'dl'
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:34:39 +0000 (09:34 +0200)]
s4:heimdal_build/wscript: rename HEIMDAL_ROKEN_H => HEIMDAL_ROKEN_HOSTCC
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:33:42 +0000 (09:33 +0200)]
lib/replace/wscript: rename LIBREPLACE_H => LIBREPLACE_HOSTCC
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:30:12 +0000 (09:30 +0200)]
wafsamba: allow passing 'use_hostcc' to SAMBA_SUBSYSTEM()
metze
Andrew Tridgell [Mon, 12 Apr 2010 08:39:50 +0000 (18:39 +1000)]
s4-ldb: fixed a crash bug for non-UTF8 strings
when one of the strings was not valid UTF8, we would try to
dereference NULL
Kai Blin [Mon, 5 Apr 2010 22:28:05 +0000 (00:28 +0200)]
build: Add an always parameter to CHECK_DECLS
Kai Blin [Sun, 11 Apr 2010 19:59:43 +0000 (21:59 +0200)]
s3-waf: Correctly create symlink if SAMBA_BINARY targets are not in the current diectory
Many thanks to ita for pointing out the fix.
Andrew Tridgell [Mon, 12 Apr 2010 06:21:21 +0000 (00:21 -0600)]
build: allow target upgrades from EMPTY to SYSLIB
A library may be initially set as empty if it wasn't needed for a list
of functions in CHECK_FUNCS_IN(). A later check may require the
library.
Pair-Programmed-With: Kai Blin <kai@samba.org>
Andrew Tridgell [Mon, 12 Apr 2010 07:46:01 +0000 (17:46 +1000)]
s4-waf: move the KRB5_DEPRECATED check into lib/replace
this needs to be with the krb5.h check for the source3 build
Stefan Metzmacher [Sun, 11 Apr 2010 17:24:46 +0000 (19:24 +0200)]
s4-waf: inline LIBREPLACE_NETWORK into 'replace'
metze
Stefan Metzmacher [Mon, 12 Apr 2010 07:12:29 +0000 (09:12 +0200)]
lib/replace/wscript: rename REPLACE_H_SOURCE => REPLACE_HOSTCC_SOURCE
metze
Stefan Metzmacher [Mon, 12 Apr 2010 06:29:53 +0000 (08:29 +0200)]
lib/replace/wscript: implement the same getpass detection logic as the autoconf version
metze
Stefan Metzmacher [Sun, 11 Apr 2010 17:16:32 +0000 (19:16 +0200)]
lib/replace/wscript: inline LIBREPLACE_GETPASS into 'replace'
metze
Kamen Mazdrashki [Mon, 12 Apr 2010 00:45:12 +0000 (03:45 +0300)]
s4/libnet: Allocate mem in supplied mem_ctx
In this case, 'libnet_Vampire *r' may not be a pointer to
a talloced memory.
Kamen Mazdrashki [Mon, 12 Apr 2010 00:33:33 +0000 (03:33 +0300)]
s4/py_net: Source code formatting fix
Andrew Tridgell [Mon, 12 Apr 2010 01:12:22 +0000 (11:12 +1000)]
build: use a common autogen-waf.sh for all builds
the symlink will get updated with the right target when waf dist is
used in each directory
Andrew Tridgell [Mon, 12 Apr 2010 01:09:44 +0000 (11:09 +1000)]
build: cope with symlinks between build components in waf dist
This will allow us to have autogen-waf.sh be a symlink to
../buildtools/scripts/autogen-waf.sh in each library.
That will prevent people from updating only the script in source4/,
and forgetting to udpate the scripts in the other libs, as happened
with commit
f3f82496
Jelmer Vernooij [Mon, 12 Apr 2010 00:55:27 +0000 (02:55 +0200)]
s4-net: Add definition of outf.
Andrew Tridgell [Sun, 11 Apr 2010 23:49:56 +0000 (09:49 +1000)]
build: added --minimum-library-version configure option
this allows the packager to override the default choice of system
library version
Kamen Mazdrashki [Sun, 11 Apr 2010 15:43:56 +0000 (18:43 +0300)]
s4: fix a typo
Kamen Mazdrashki [Sun, 11 Apr 2010 14:27:30 +0000 (17:27 +0300)]
s4/libnet: handle errors returned for DsAddEntry_v3 properly
It turns out ms-docs are little bit misleading - in case of
no error, r->out.ctr->ctr3.err_data is not NULL, but
error information (r->out.ctr->ctr3.err_data->v1.info) is NULL!
Kamen Mazdrashki [Sun, 11 Apr 2010 14:24:32 +0000 (17:24 +0300)]
s4/libnet: Add few new lines in the debug log so it is readable again
Kamen Mazdrashki [Sun, 11 Apr 2010 14:04:21 +0000 (17:04 +0300)]
s4/libnet: Dump DRSUAPI_DIRERR_OK as unexpected
Actually DRSUAPI_DIRERR_OK is not valid error to be returned.
I introduce it in the IDL so that I can use it in enum.
So it should be dumped as Unexpected error code
Volker Lendecke [Sun, 11 Apr 2010 13:25:55 +0000 (15:25 +0200)]
s3: Move serverinfo_to_SamInfoX to auth/server_info.c
Volker Lendecke [Sun, 11 Apr 2010 13:25:06 +0000 (15:25 +0200)]
s3: Move [make|free]_user_info to auth/user_info.c
Volker Lendecke [Sun, 11 Apr 2010 20:41:59 +0000 (22:41 +0200)]
s3: Move make_server_info_sam to auth/server_info_sam.c
Volker Lendecke [Sun, 11 Apr 2010 20:38:33 +0000 (22:38 +0200)]
s3: Move sanitize_username to lib/util_str.c
Volker Lendecke [Sun, 11 Apr 2010 20:37:08 +0000 (22:37 +0200)]
s3: Move make_server_info to auth/server_info.c
Volker Lendecke [Sun, 11 Apr 2010 20:32:36 +0000 (22:32 +0200)]
s3: Move check_sam_security to auth/check_sam.c
Volker Lendecke [Sun, 11 Apr 2010 20:26:46 +0000 (22:26 +0200)]
s3: Make check_sam_security public
Volker Lendecke [Sun, 11 Apr 2010 20:23:08 +0000 (22:23 +0200)]
s3: Replace "auth_context" by "challenge" in need_to_increment_bad_pw_count args
Volker Lendecke [Sun, 11 Apr 2010 12:07:12 +0000 (14:07 +0200)]
s3: Replace "auth_context" by "challenge" in sam_password_ok args
Volker Lendecke [Sun, 11 Apr 2010 11:48:55 +0000 (13:48 +0200)]
s3: Move user_in_group() and create_token_from_username() to token_utils.c
Goal is to be able to call check_sam_security from winbind
Volker Lendecke [Sun, 11 Apr 2010 20:56:09 +0000 (22:56 +0200)]
libcli/auth: Fix an uninitialized variable
value.dptr was used uninitialized in the "goto done;"
Kai Blin [Sun, 11 Apr 2010 20:38:38 +0000 (22:38 +0200)]
nsswitch/wbinfo: Fix the S4 header check
Jelmer Vernooij [Sun, 11 Apr 2010 20:16:48 +0000 (22:16 +0200)]
idl: Use C-style comments, because cpp on some platforms doesn't accept
// comments.
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 19:44:20 +0000 (21:44 +0200)]
s4:dbspeed torture - improve also the TDB code part
Always use the label "failed" on failures, always close the database context
(child of "tmp_ctx") when deleting database file.
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 19:37:23 +0000 (21:37 +0200)]
s4:dbspeed torture - remove unneeded newlines on "torture_result"
According to Jelmer's post on the technical list.
Jelmer Vernooij [Sun, 11 Apr 2010 18:56:48 +0000 (20:56 +0200)]
s4: Fix more test results to not conflict with subunit commands.
Jelmer Vernooij [Sun, 11 Apr 2010 18:56:02 +0000 (20:56 +0200)]
subunit: Cope with lowercase test results in tap2subunit.
Also submitted upstream.
Jelmer Vernooij [Sun, 11 Apr 2010 14:55:48 +0000 (16:55 +0200)]
subunit: Remove more test output that could be interpreted by subunit.
Jelmer Vernooij [Sat, 10 Apr 2010 23:39:06 +0000 (01:39 +0200)]
subunit: Support formatting compatible with upstream subunit, for consistency.
Upstream subunit makes a ":" after commands optional, so I've fixed any
places where we might trigger commands accidently. I've filed a bug
about this in subunit.
Jelmer Vernooij [Sat, 10 Apr 2010 22:08:16 +0000 (00:08 +0200)]
selftest: Accept 'testing:' to introduce new tests.
Derrell Lipman [Sun, 11 Apr 2010 15:37:00 +0000 (11:37 -0400)]
[Bug 7345] Incomplete description of function return values in libsmbclient.h
- Fixed documentation on smbc_fstat(), smbc_statvfs(), and smbc_fstatvfs():
All were missing return value upon success
- Fixed documentation on smbc_read:
Documented return value upon EOF
Derrell
Volker Lendecke [Sun, 11 Apr 2010 13:26:23 +0000 (15:26 +0200)]
s3: Use sizeof(chal) instead of a constant
Volker Lendecke [Sun, 11 Apr 2010 10:53:00 +0000 (12:53 +0200)]
s3: Use talloc_stackframe() in user_in_group
Volker Lendecke [Sun, 11 Apr 2010 10:47:28 +0000 (12:47 +0200)]
s3: Use talloc_stackframe() in user_in_group_sid
Volker Lendecke [Sun, 11 Apr 2010 10:47:13 +0000 (12:47 +0200)]
s3: Use talloc_stackframe() in create_token_from_username
Volker Lendecke [Sun, 11 Apr 2010 10:44:01 +0000 (12:44 +0200)]
s3: Fix a memleak in user_in_group_sid
Volker Lendecke [Sun, 11 Apr 2010 10:37:48 +0000 (12:37 +0200)]
s3: Remove the make_auth_methods routine
This was just TALLOC_ZERO_P
Volker Lendecke [Sun, 11 Apr 2010 10:24:07 +0000 (12:24 +0200)]
s3: Fix a typo
Volker Lendecke [Sun, 11 Apr 2010 10:20:24 +0000 (12:20 +0200)]
s3: Make "auth_context" its own talloc parent
Remove "mem_ctx" from "struct auth_context"
Volker Lendecke [Sun, 11 Apr 2010 09:50:55 +0000 (11:50 +0200)]
s3: Fix some nonempty lines
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 10:56:50 +0000 (12:56 +0200)]
s4:samdb_server_site_dn - free unused DNs in the right way
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 09:33:45 +0000 (11:33 +0200)]
s4:torture - "dbspeed" test - add newlines as we have them in the other failure messages
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 09:22:41 +0000 (11:22 +0200)]
s4:torture - "dbspeed" test
Calculate the leaks on base of the "tmp_ctx" not the torture context.
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 09:21:19 +0000 (11:21 +0200)]
s4:torture - "dbspeed" test
Unify error handling.
Matthias Dieter Wallnöfer [Sun, 11 Apr 2010 09:13:31 +0000 (11:13 +0200)]
s4:torture - "dbspeed" test
Add more "talloc_free"s where needed or useful.
Volker Lendecke [Sun, 11 Apr 2010 09:14:24 +0000 (11:14 +0200)]
s3: Cosmetics -- I could not spot where "chal" was initialized
Andrew Bartlett [Fri, 9 Apr 2010 07:18:53 +0000 (17:18 +1000)]
s4:auth Remove event context from anonymous_session()
This should always return a simple structure with no need to consult a
DB, so remove the event context, and simplfy to call helper functions
that don't look at privilages.
Andrew Bartlett
Volker Lendecke [Sat, 10 Apr 2010 20:52:06 +0000 (22:52 +0200)]
s3: Use IS_DC macro in get_global_sam_name()
Much as I dislike macros, this one is there. So why not use it...
Volker Lendecke [Sat, 10 Apr 2010 20:34:51 +0000 (22:34 +0200)]
s3: Remove domain selection from dual_pam_auth
We're in a child, the parent already has chosen the domain by
picking the right child to connect to.
Metze, you've done work on winbind lately, so it goes to you:
Please check :-)
Jelmer Vernooij [Sat, 10 Apr 2010 20:35:57 +0000 (22:35 +0200)]
subunit: Don't abort when receiving test results from tests that weren't
announced.
Jelmer Vernooij [Sat, 10 Apr 2010 20:20:12 +0000 (22:20 +0200)]
selftest: Support passing --load-list to test runners.