11 years agor24388: - ACL retrieval provided incomplete information because the buffer pointer was
Derrell Lipman [Tue, 14 Aug 2007 03:02:34 +0000 (03:02 +0000)]
r24388: - ACL retrieval provided incomplete information because the buffer pointer was
 incremented too far in some circumstances.  In these cases, only the first
 of multiple concatenated strings would be seen.

- Working on bug 4649 pertaining to delete an ACL, this fixes the reported
 crash.  It appears to have been an incomplete switchover from malloc to
 talloc, as the memory was still being freed with SAFE_FREE.

 Deleting ACLs still doesn't work.  Although a valid request is sent to the
 server and a SUCCESS response is returned, the method that's used in
 libsmbclient for deleting ACLs seems to be incorrect.  In looking at the
 samba4 torture tests, it appears that we should be turning on the INHERIT
 flag if we want to delete the ACL.  (I could use some assistance on the
 proper flags to send, from anyone familiar with this stuff.)

- Apply patch from SATOH Fumiyasu to fix bug 4750.  smbc_telldir_ctx() was not
  returning a value useful to smbc_lseekdir_ctx().

(This used to be commit 2ac502e29bd8390252fe4ae8344faab49ca01ff5)

11 years agor24387: Convert readbraw to the new api. Volker, keep checking in
Jeremy Allison [Tue, 14 Aug 2007 01:45:26 +0000 (01:45 +0000)]
r24387: Convert readbraw to the new api. Volker, keep checking in
your patches please :-). I'll work on SMBreadBmpx tomorrow.
(This used to be commit 27e183afa8d23dca6aada1f3810dc53aa8c55ccd)

11 years agor24386: Piss off Volker (not deliberately) by checking in a reply_mknew -> conversion.
Jeremy Allison [Mon, 13 Aug 2007 20:29:24 +0000 (20:29 +0000)]
r24386: Piss off Volker (not deliberately) by checking in a reply_mknew -> conversion.
Sorry vl, remove one of your 15 patches :-).
(This used to be commit a7648ed9d40d6f61362e1488dc30216363870694)

11 years agor24385: Convert call_nt_transact_query_security_desc to the new API
Volker Lendecke [Mon, 13 Aug 2007 20:16:33 +0000 (20:16 +0000)]
r24385: Convert call_nt_transact_query_security_desc to the new API
(This used to be commit f44e0aac2b47ea377c2ce701426e57ee15c42fe7)

11 years agor24384: Convert call_nt_transact_set_security_desc to the new API
Volker Lendecke [Mon, 13 Aug 2007 19:59:00 +0000 (19:59 +0000)]
r24384: Convert call_nt_transact_set_security_desc to the new API
(This used to be commit 925ed1e186da594b5c40d3abbad885060ca87fd0)

11 years agor24383: Convert call_nt_transact_ioctl to the new API
Volker Lendecke [Mon, 13 Aug 2007 19:58:28 +0000 (19:58 +0000)]
r24383: Convert call_nt_transact_ioctl to the new API
(This used to be commit 8e6485e0782e9ab31b07dd9f662bd845f58faf4a)

11 years agor24382: Remove reply_prep_legacy from call_nt_transact_create
Volker Lendecke [Mon, 13 Aug 2007 19:22:07 +0000 (19:22 +0000)]
r24382: Remove reply_prep_legacy from call_nt_transact_create
(This used to be commit 73392485f4c3bf8b4138b500b4882c492bf96358)

11 years agor24381: Push reply_prep_legacy into call_nt_transact_create
Volker Lendecke [Mon, 13 Aug 2007 19:03:52 +0000 (19:03 +0000)]
r24381: Push reply_prep_legacy into call_nt_transact_create
(This used to be commit ca18ba96be84ed12003af84c53cc5f2e92fcc984)

11 years agor24368: Push down reply_prep_legacy one level
Volker Lendecke [Mon, 13 Aug 2007 15:41:29 +0000 (15:41 +0000)]
r24368: Push down reply_prep_legacy one level

Not pretty, but necessary to convert the calls one by one
(This used to be commit 523a463be427da0c3dbe01399e87b82b9f759512)

11 years agor24367: Push reply_prep_legacy into handle_nttrans
Volker Lendecke [Mon, 13 Aug 2007 15:40:37 +0000 (15:40 +0000)]
r24367: Push reply_prep_legacy into handle_nttrans
(This used to be commit 8b5e51c2668799890d033a371e5b9a57b8f086c6)

11 years agor24362: Initialize padding also when no params are sent back
Volker Lendecke [Mon, 13 Aug 2007 14:40:56 +0000 (14:40 +0000)]
r24362: Initialize padding also when no params are sent back
(This used to be commit 03c5e960a21ae78cdd832a5c760015f7fbd83bd9)

11 years agor24361: Push reply_prep_legacy down in reply_nttrans[s]
Volker Lendecke [Mon, 13 Aug 2007 14:29:44 +0000 (14:29 +0000)]
r24361: Push reply_prep_legacy down in reply_nttrans[s]
(This used to be commit d97a2e91d3c44ad39e6a1ee369e1e906d98707f5)

11 years agor24360: Make ndr_print_debug_helper() output readable.
Günther Deschner [Mon, 13 Aug 2007 13:05:17 +0000 (13:05 +0000)]
r24360: Make ndr_print_debug_helper() output readable.

(This used to be commit 45ee3b55d51fcde0e5c0ea56069656d6f2647fff)

11 years agor24359: Fix the build
Volker Lendecke [Mon, 13 Aug 2007 09:49:03 +0000 (09:49 +0000)]
r24359: Fix the build
(This used to be commit b2ac1a3ec59f7c804521e5a478916fba16f4b3d4)

11 years agor24358: Push reply_prep_legacy into reply_nttrans[s]
Volker Lendecke [Mon, 13 Aug 2007 09:12:21 +0000 (09:12 +0000)]
r24358: Push reply_prep_legacy into reply_nttrans[s]
(This used to be commit 197c2310792965f94d66ad7c8016a1594945bdf8)

11 years agor24357: Check wct in reply_nttrans[s]
Volker Lendecke [Mon, 13 Aug 2007 08:50:09 +0000 (08:50 +0000)]
r24357: Check wct in reply_nttrans[s]
(This used to be commit 9ab87e644e4dc54ebbcb8ad300fe338f4a809ba9)

11 years agor24356: Add send_nt_replies_new wrapper
Volker Lendecke [Mon, 13 Aug 2007 08:33:01 +0000 (08:33 +0000)]
r24356: Add send_nt_replies_new wrapper
(This used to be commit 8a910d37ccc767eb8ab25ef2af3a136ad874346f)

11 years agor24355: move reply_outbuf() to the place where it's used
Stefan Metzmacher [Mon, 13 Aug 2007 07:20:19 +0000 (07:20 +0000)]
r24355: move reply_outbuf() to the place where it's used

(This used to be commit c7ed550483233851d395edb4b8443b3296b45fb7)

11 years agor24354: Remove offsetof macro
Volker Lendecke [Sun, 12 Aug 2007 21:23:06 +0000 (21:23 +0000)]
r24354: Remove offsetof macro

Samba4 seems not to suffer from it
(This used to be commit d93b5d50a00286586c931a5876f5933a520b6ce7)

11 years agor24353: Add a getpwuid lookup to wbinfo.
Kai Blin [Sun, 12 Aug 2007 17:36:42 +0000 (17:36 +0000)]
r24353: Add a getpwuid lookup to wbinfo.

Merged from my Samba4 GSoC branch.
Volker, can you check if that's done the way you thought?
(This used to be commit f8560ea66ce522ff11d16f0e36e10853fe2639d7)

11 years agor24351: Remove reply_prep_legacy from reply_read_and_X
Volker Lendecke [Sun, 12 Aug 2007 12:57:56 +0000 (12:57 +0000)]
r24351: Remove reply_prep_legacy from reply_read_and_X
(This used to be commit 8f3e3a21008a2cb6ed73d8629aaf1fa565f19e79)

11 years agor24349: For large read&x we need more than 64k of outbuf.
Volker Lendecke [Sun, 12 Aug 2007 12:15:32 +0000 (12:15 +0000)]
r24349: For large read&x we need more than 64k of outbuf.
(This used to be commit f7e2eec35f7457ec70d75ef099b34f83c9dfd654)

11 years agor24348: Do not use inbuf/outbuf in the sendfile path of read_and_X
Volker Lendecke [Sun, 12 Aug 2007 11:40:27 +0000 (11:40 +0000)]
r24348: Do not use inbuf/outbuf in the sendfile path of read_and_X
(This used to be commit 595ea708ee8c9b6f86648dfdb5ff5a3feafe1f07)

11 years agor24347: fake_sendfile does not need Inbuf/Outbuf
Volker Lendecke [Sun, 12 Aug 2007 11:22:26 +0000 (11:22 +0000)]
r24347: fake_sendfile does not need Inbuf/Outbuf

In the future, we might put the new Linux splice(2) syscall here. This
should also work for reply_write, but getting that in is a bit trickier.
We need to decide very early before fetching the whole buffer that we
have a write call.
(This used to be commit 32921c878a7f60251a9217173951065784077077)

11 years agor24346: Push reply_prep_legacy into send_file_readX
Volker Lendecke [Sun, 12 Aug 2007 09:16:54 +0000 (09:16 +0000)]
r24346: Push reply_prep_legacy into send_file_readX
(This used to be commit cded66a7dc72d41e4d6ea90edd8b03ed080c042f)

11 years agor24341: Make libreplace provide offsetof.
Jelmer Vernooij [Sun, 12 Aug 2007 01:06:02 +0000 (01:06 +0000)]
r24341: Make libreplace provide offsetof.
(This used to be commit 4a5fa715a6af281282092644817599f79806981d)

11 years agor24340: Use standard data type uint32_t rather than tdb-specific u32.
Jelmer Vernooij [Sun, 12 Aug 2007 00:55:03 +0000 (00:55 +0000)]
r24340: Use standard data type uint32_t rather than tdb-specific u32.
(This used to be commit 26d1430283bd4ae8b8a84f3253e33417d509c1a4)

11 years agor24332: schedule_aio_read_and_X does not need InBuf/OutBuf
Volker Lendecke [Sat, 11 Aug 2007 16:28:10 +0000 (16:28 +0000)]
r24332: schedule_aio_read_and_X does not need InBuf/OutBuf
(This used to be commit 9ad91bd20592850d7b6393e1ac7f0e0919d69668)

11 years agor24331: Fix an error where gid_t != 32 bit
Volker Lendecke [Sat, 11 Aug 2007 16:20:27 +0000 (16:20 +0000)]
r24331: Fix an error where gid_t != 32 bit
(This used to be commit 748fdfbd7ba5cc844f1370a968465b19ae698f94)

11 years agor24330: Fix a 64-bit error
Volker Lendecke [Sat, 11 Aug 2007 16:18:11 +0000 (16:18 +0000)]
r24330: Fix a 64-bit error
(This used to be commit 30fd90346550f1c672edb51ab63b8139a6c4053e)

11 years agor24329: Fix a 64-bit bug
Volker Lendecke [Sat, 11 Aug 2007 16:15:39 +0000 (16:15 +0000)]
r24329: Fix a 64-bit bug

enums are not necessarily represented as 32-bit uints. On assignment
(see line 1029) implicit conversion happens, but not when pointers are
(This used to be commit 67ec6863dd91ca2421e4541add99dfd739805242)

11 years agor24328: Restore chain_reply error handling
Volker Lendecke [Sat, 11 Aug 2007 15:02:58 +0000 (15:02 +0000)]
r24328: Restore chain_reply error handling

Get the whole smb header from the second chained function, in particular
the error fields
(This used to be commit 0eb831ca0eadb725242cb4ad75eb7008a5c18bf2)

11 years agor24327: First round of fixes to chain_reply
Volker Lendecke [Sat, 11 Aug 2007 14:37:39 +0000 (14:37 +0000)]
r24327: First round of fixes to chain_reply

The argument to smb_setlen does not contain the nbt header of 4 bytes

The chained function might allocate outbuf itself (as now happens with
reply_read_and_X). This would erroneously overwrite the caller's outbuf.
Give it an outbuf pointer of it's own
(This used to be commit f923bba90866af14b32c0d0ab58acc00a5939fbb)

11 years agor24326: Fix the build for Solaris CC
Volker Lendecke [Sat, 11 Aug 2007 11:50:53 +0000 (11:50 +0000)]
r24326: Fix the build for Solaris CC
(This used to be commit 7af4c1f547accc973f8b3ed88958bdeaf941754a)

11 years agor24325: Push down reply_prep_legacy in reply_read_and_X
Volker Lendecke [Sat, 11 Aug 2007 11:20:21 +0000 (11:20 +0000)]
r24325: Push down reply_prep_legacy in reply_read_and_X
(This used to be commit 9d2354129dad1d4d015d463f138a196f9f72af2f)

11 years agor24324: No reply_prep_legacy() in reply_pipe_read_and_X
Volker Lendecke [Sat, 11 Aug 2007 10:53:36 +0000 (10:53 +0000)]
r24324: No reply_prep_legacy() in reply_pipe_read_and_X
(This used to be commit 304843315c5457ff0288d66d31f1ddb1ef2796f4)

11 years agor24323: Remove the reply_read_and_X wrapper function
Volker Lendecke [Sat, 11 Aug 2007 10:40:35 +0000 (10:40 +0000)]
r24323: Remove the reply_read_and_X wrapper function
(This used to be commit 96b218789401bb9e512339e7c6d9e0c9d9724420)

11 years agor24322: Wrap reply_read_and_X in reply_prep_legacy
Volker Lendecke [Sat, 11 Aug 2007 10:26:40 +0000 (10:26 +0000)]
r24322: Wrap reply_read_and_X in reply_prep_legacy
(This used to be commit 7926b5dfb8d05ad2fe40c3f7658a492f0450e505)

11 years agor24321: Attempt to fix the "hape" cc build
Volker Lendecke [Sat, 11 Aug 2007 09:53:42 +0000 (09:53 +0000)]
r24321: Attempt to fix the "hape" cc build
(This used to be commit 4e819aea0b783110d3b7a27105c588403e79eac9)

11 years agor24320: Fix the wct checks in reply_trans2 and the reply_trans calls
Volker Lendecke [Fri, 10 Aug 2007 21:34:55 +0000 (21:34 +0000)]
r24320: Fix the wct checks in reply_trans2 and the reply_trans calls

No idea what I've been smoking here.

Thanks to Stefan for closely looking
(This used to be commit 708f5af2e8c10d9a0d0027e3c31fa23689e746b8)

11 years agor24319: Check wct in reply_read_and_X
Volker Lendecke [Fri, 10 Aug 2007 21:33:58 +0000 (21:33 +0000)]
r24319: Check wct in reply_read_and_X
(This used to be commit 9ddacdfa131c4a4a852b3d30db1ee22d1852d0c2)

11 years agor24318: Print a prominent warning when reply_prep_legacy is called
Volker Lendecke [Fri, 10 Aug 2007 20:53:27 +0000 (20:53 +0000)]
r24318: Print a prominent warning when reply_prep_legacy is called

This is a temporary function anyway
(This used to be commit 9269e3d5882e97d1c884df6511fa6d63a7b1cfcd)

11 years agor24316: Fix an uninitialized read
Volker Lendecke [Fri, 10 Aug 2007 20:03:31 +0000 (20:03 +0000)]
r24316: Fix an uninitialized read

Jerry, please check this!


(This used to be commit db1b89072c3f214c3cb4be844cd7b417e5361615)

11 years agor24314: Attempt to fix bug 4868
Volker Lendecke [Fri, 10 Aug 2007 14:01:14 +0000 (14:01 +0000)]
r24314: Attempt to fix bug 4868
(This used to be commit 0ced8fcfe124f99159061143f29775aacd6e1c8f)

11 years agor24312: revision 24091 removed the 'FORCE'...
Stefan Metzmacher [Fri, 10 Aug 2007 10:31:28 +0000 (10:31 +0000)]
r24312: revision 24091 removed the 'FORCE'...

(This used to be commit 34d821daf0af6ef1e51dfd5cd99741f426d6956e)

11 years agor24311: add a reply_force_nterror() macro
Stefan Metzmacher [Fri, 10 Aug 2007 10:28:09 +0000 (10:28 +0000)]
r24311: add a reply_force_nterror() macro

(This used to be commit b9ae00f4980c305f2f7334b139f9bc72fd9afbd6)

11 years agor24310: we should not call END_PROFILE(SMBntcreateX); twice...
Stefan Metzmacher [Fri, 10 Aug 2007 10:15:25 +0000 (10:15 +0000)]
r24310: we should not call END_PROFILE(SMBntcreateX); twice...

(This used to be commit 7a98e09f2e4d5eff074e2d71dd1ff2f019a4547a)

11 years agor24309: if no protocol matches, just return choise 0xffff
Stefan Metzmacher [Fri, 10 Aug 2007 10:11:40 +0000 (10:11 +0000)]
r24309: if no protocol matches, just return choise 0xffff
as we've done before revision 24002

(This used to be commit 6014ecbbfd50bc8f4f351dec1f9dd35c3fe62456)

11 years agor24308: this needs a better fix that compiles...
Stefan Metzmacher [Fri, 10 Aug 2007 09:57:30 +0000 (09:57 +0000)]
r24308: this needs a better fix that compiles...

(This used to be commit 1a177eb08d4022c1ef7b5400ffdf426bcb9b97ff)

11 years agor24307: fill in choise with value -1 on error
Stefan Metzmacher [Fri, 10 Aug 2007 09:56:13 +0000 (09:56 +0000)]
r24307: fill in choise with value -1 on error
as we've done before revision 24002

(This used to be commit 2961a35e90aae44c8560b1f4b56bfa6343c837d7)

11 years agor24306: the check_fsp() function has an explicit user argument
Stefan Metzmacher [Fri, 10 Aug 2007 09:53:42 +0000 (09:53 +0000)]
r24306: the check_fsp() function has an explicit user argument
so use it...

(This used to be commit 4154bee0d91dd2ace9a7a627418f652d0d11b959)

11 years agor24304: patch from Bjoern JAcke <bj@SerNet.DE>:
Stefan Metzmacher [Fri, 10 Aug 2007 09:44:13 +0000 (09:44 +0000)]
r24304: patch from Bjoern JAcke <bj@SerNet.DE>:

attached patches add EA support for Solaris. If no one disagrees, can
someone check this in please?

(This used to be commit 81e5afc363e1f0bdc4768c0f5c696f4152fe5b44)

11 years agor24302: add a module that overloads the file_id_create VFS function
Stefan Metzmacher [Fri, 10 Aug 2007 09:05:18 +0000 (09:05 +0000)]
r24302: add a module that overloads the file_id_create VFS function
and alters the device id depending on the configured algorithm.

The algorithm is configured via "fileid:algorithm":
- "fsname" (default) uses a uint64 hash over the mount point
- "fsid" uses the fsid returned from statfs()

This is needed for "clustering = yes" on some clusterfilesystems

(This used to be commit 30f9171cca3e4f523cde7dfc96096c32e5af50be)

11 years agor24291: Fix Coverity ID 364
Volker Lendecke [Thu, 9 Aug 2007 20:54:58 +0000 (20:54 +0000)]
r24291: Fix Coverity ID 364

We've checked num_rids != 0 above.
(This used to be commit dab5449f385248ab1fdd60b240ef6ad4a27ba7f2)

11 years agor24290: fix debug statments to match function name
Herb Lewis [Thu, 9 Aug 2007 19:03:23 +0000 (19:03 +0000)]
r24290: fix debug statments to match function name
(This used to be commit 5ee0bfde50645b822cefefe90bc9168faeeb34ff)

11 years agor24281: Fix bug found by Herb. The vuid entry in the cli_state structure gets
Jeremy Allison [Wed, 8 Aug 2007 23:56:55 +0000 (23:56 +0000)]
r24281: Fix bug found by Herb. The vuid entry in the cli_state structure gets
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try
to authenticate as the user in cli_session_setup this returns an
error "Bad userid" (as seen in wireshark).
"We should only leave cli->vuid != 0 on success. Looks like it's
getting set in the cli_session_setup_blob_receive() call and not
cleared again on error."
(This used to be commit fa8e66dd8d2c68b91b27169c3c43820989f58758)

11 years agor24280: Fix the build of vfs_afsacl.c
Volker Lendecke [Wed, 8 Aug 2007 20:06:17 +0000 (20:06 +0000)]
r24280: Fix the build of vfs_afsacl.c
(This used to be commit c231f7b8f6025e2853eb6ecab43fe87566596234)

11 years agor24279: Remove reply_prep_legacy from reply_write_and_X
Volker Lendecke [Wed, 8 Aug 2007 19:05:30 +0000 (19:05 +0000)]
r24279: Remove reply_prep_legacy from reply_write_and_X
(This used to be commit f18b7a9a282ebb5c31a89a601798f9a0db51867e)

11 years agor24278: Push down reply_prep_legacy in reply_write_and_X
Volker Lendecke [Wed, 8 Aug 2007 18:40:26 +0000 (18:40 +0000)]
r24278: Push down reply_prep_legacy in reply_write_and_X

Remove the need for reply_prep_legacy for reply_pipe_write_and_X
(This used to be commit de143d5fa61aa487613dda729a43dc3d59a72899)

11 years agor24272: try to fix the build on irix...
Stefan Metzmacher [Tue, 7 Aug 2007 14:06:27 +0000 (14:06 +0000)]
r24272: try to fix the build on irix...

(This used to be commit dd7e94258b0fc0157d890d71f05c6fe16b6a2ea9)

11 years agor24271: Push reply_prep_legacy into reply_write_and_X
Volker Lendecke [Tue, 7 Aug 2007 13:43:02 +0000 (13:43 +0000)]
r24271: Push reply_prep_legacy into reply_write_and_X
(This used to be commit 607e7d2447bf19eea872a3a4d1ad499a53f0a935)

11 years agor24270: Fix some END_PROFILE(SMBwriteX)
Volker Lendecke [Tue, 7 Aug 2007 13:14:49 +0000 (13:14 +0000)]
r24270: Fix some END_PROFILE(SMBwriteX)
(This used to be commit 36f2347561ab06b5d8175ad0a9c4da2817e759f9)

11 years agor24269: Check wct in reply_write_and_X
Volker Lendecke [Tue, 7 Aug 2007 13:12:46 +0000 (13:12 +0000)]
r24269: Check wct in reply_write_and_X
(This used to be commit 1297fac11778cb910d1bcd12b6d9d3a6269972db)

11 years agor24268: Fix two crashes for spoolss
Volker Lendecke [Tue, 7 Aug 2007 13:10:21 +0000 (13:10 +0000)]
r24268: Fix two crashes for spoolss

strlcpy does not like a NULL source. Fix a use-after-free.
(This used to be commit c2a214501788b5f0b6f555bd01ed310d331d07fa)

11 years agor24267: Fix the build farm
Volker Lendecke [Tue, 7 Aug 2007 11:50:03 +0000 (11:50 +0000)]
r24267: Fix the build farm

I had only tested with "net getlocalsid". posix_locking_init() calls this
with a NULL name...
(This used to be commit 3eee1fe28057e2e3da2e9d1506f57f3e35fd37b7)

11 years agor24266: Remove the "open files database hash size" parameter
Volker Lendecke [Tue, 7 Aug 2007 11:28:04 +0000 (11:28 +0000)]
r24266: Remove the "open files database hash size" parameter

This has been superseded by the "tdb_hashsize:<tdbname>" parameter
(This used to be commit df40d336afd256f05a0ec3724cc2096fb7114d81)

11 years agor24265: Add the tdb_hashsize:<tdbname> parameter
Volker Lendecke [Tue, 7 Aug 2007 11:21:48 +0000 (11:21 +0000)]
r24265: Add the tdb_hashsize:<tdbname> parameter

This makes it possible to set the default hashsize for any tdb. I would
like to remove the "open files database hash size" in favor of this one.

I'll check that removal in with the next commit, please complain/revert
if it's not ok.

(This used to be commit e9bd7a63a8d462b1fc3bab99ff843e25bffd156b)

11 years agor24254: Fix a segfault in r24102
Volker Lendecke [Mon, 6 Aug 2007 21:03:03 +0000 (21:03 +0000)]
r24254: Fix a segfault in r24102

The really pure bugfix would have replaced pparam by *pparam, but we pulled
the fid anyway.

Metze, in line 2421 the FSP_BELONGS_CONN is commented out, is that intended?
The FSCTL_CREATE_OR_GET_OBJECT_ID ioctl did not have it.

(This used to be commit 2c1376225b98a9325dfc2d00bad1722e63cf522b)

11 years agor24253: From Jan Martin <>.
Jeremy Allison [Mon, 6 Aug 2007 18:54:26 +0000 (18:54 +0000)]
r24253:  From Jan Martin <>.
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.

The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.

smbd/msdfs.c, dfs_path_lookup() does the following with the requested
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes

That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same.  When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.

Bug #4860.

(This used to be commit 42d1c6713a56197ca8dfebf74eb0d483102148f7)

11 years agor24252: Dump guid of msExchMailboxGuid when returned.
Günther Deschner [Mon, 6 Aug 2007 14:03:11 +0000 (14:03 +0000)]
r24252: Dump guid of msExchMailboxGuid when returned.

(This used to be commit 1142f3df546cbf4780c6f54667f7ed31b1a7621b)

11 years agor24251: Neverending fun:
Günther Deschner [Mon, 6 Aug 2007 13:48:57 +0000 (13:48 +0000)]
r24251: Neverending fun:

Heimdal doesn't accept all OIDs and gss_import_name() fails with
instead (which works with at least MIT 1.6.1 and Heimdal 1.0.1).

(This used to be commit f783b32b65ee50e3730ae2d039ca04c9fc5a201a)

11 years agor24250: Merge W_ERROR_HAVE_NO_MEMORY macro from Samba 4.
Günther Deschner [Mon, 6 Aug 2007 10:39:27 +0000 (10:39 +0000)]
r24250: Merge W_ERROR_HAVE_NO_MEMORY macro from Samba 4.

(This used to be commit 054084a2359b5069b872b2e630377dc369c31018)

11 years agor24244: Complete the conversion of reply_trans[s]
Volker Lendecke [Sun, 5 Aug 2007 11:34:57 +0000 (11:34 +0000)]
r24244: Complete the conversion of reply_trans[s]

Remove reply_prep/post_legacy from send_trans_replies
(This used to be commit c08366f840ead5aba7199cf0b058587055b4d98e)

11 years agor24243: Remove reply_prep_legacy from api_reply
Volker Lendecke [Sun, 5 Aug 2007 11:19:24 +0000 (11:19 +0000)]
r24243: Remove reply_prep_legacy from api_reply
(This used to be commit b01664b43b0bd94bb59dec57480d2be954a7298a)

11 years agor24242: Remove reply_prep_legacy from api_rpc_trans_reply
Volker Lendecke [Sun, 5 Aug 2007 10:57:04 +0000 (10:57 +0000)]
r24242: Remove reply_prep_legacy from api_rpc_trans_reply
(This used to be commit 160f65946af9b3e1609b0efb211edc81514fb36f)

11 years agor24241: Remove reply_prep_legacy from api_WNPHS and api_SNPHS
Volker Lendecke [Sun, 5 Aug 2007 10:48:35 +0000 (10:48 +0000)]
r24241: Remove reply_prep_legacy from api_WNPHS and api_SNPHS
(This used to be commit 8702450e91943b1097ae3c8979d60b6962a69632)

11 years agor24240: Push down reply_prep_legacy one level inside api_fd_reply
Volker Lendecke [Sun, 5 Aug 2007 10:37:08 +0000 (10:37 +0000)]
r24240: Push down reply_prep_legacy one level inside api_fd_reply
(This used to be commit 0bb95639d6b49b18f2a7f1131f54239355097119)

11 years agor24239: Push reply_prep_legacy into api_fd_reply
Volker Lendecke [Sun, 5 Aug 2007 10:28:12 +0000 (10:28 +0000)]
r24239: Push reply_prep_legacy into api_fd_reply
(This used to be commit e2a96497928ab959e36639fef2d493640bb6e951)

11 years agor24238: Push down reply_prep_legacy one level
Volker Lendecke [Sun, 5 Aug 2007 10:17:58 +0000 (10:17 +0000)]
r24238: Push down reply_prep_legacy one level
(This used to be commit a6a2d97facf95c7997f3d12457f2811b3b7bde1b)

11 years agor24237: Add send_trans_reply_new
Volker Lendecke [Sun, 5 Aug 2007 10:04:11 +0000 (10:04 +0000)]
r24237: Add send_trans_reply_new
(This used to be commit f0598b3ca0ee04e31855c3e54f3198e6fd968737)

11 years agor24236: Push reply_prep_legacy() into named_pipe()
Volker Lendecke [Sun, 5 Aug 2007 10:01:58 +0000 (10:01 +0000)]
r24236: Push reply_prep_legacy() into named_pipe()
(This used to be commit b38f9347e81364d224e5ca00609099a74410e99c)

11 years agor24235: Make handle_trans reply to errors itself
Volker Lendecke [Sun, 5 Aug 2007 09:46:17 +0000 (09:46 +0000)]
r24235: Make handle_trans reply to errors itself
(This used to be commit 06d0c74b74754c55f4c8ef0899bda08476e7dd4b)

11 years agor24234: Reformatting -- SCNR
Volker Lendecke [Sun, 5 Aug 2007 09:19:21 +0000 (09:19 +0000)]
r24234: Reformatting -- SCNR
(This used to be commit 040d6d5db6d929f1612b1b0dc762b7f55c956740)

11 years agor24233: Push reply_prep_legacy into handle_trans
Volker Lendecke [Sun, 5 Aug 2007 09:18:14 +0000 (09:18 +0000)]
r24233: Push reply_prep_legacy into handle_trans
(This used to be commit dc27c3c668f86d008c27b8a749f5726287ba54a5)

11 years agor24232: Push down reply_prep_legacy inside reply_transs
Volker Lendecke [Sun, 5 Aug 2007 09:01:15 +0000 (09:01 +0000)]
r24232: Push down reply_prep_legacy inside reply_transs
(This used to be commit 511f8bc030a9a16c2e793ce5d06577608e101de4)

11 years agor24231: Push allocating InBuffer/OutBuffer into reply_transs
Volker Lendecke [Sun, 5 Aug 2007 08:47:09 +0000 (08:47 +0000)]
r24231: Push allocating InBuffer/OutBuffer into reply_transs
(This used to be commit 74ae19cca6dd15b65deffbf464cfd0e485da8611)

11 years agor24230: Push down reply_prep_legacy in reply_trans
Volker Lendecke [Sun, 5 Aug 2007 08:31:41 +0000 (08:31 +0000)]
r24230: Push down reply_prep_legacy in reply_trans

The last checkin was for reply_trans, not reply_transs
(This used to be commit 50a2bfd9e04d51aa5e3ae9d6620a98eeb158b6ea)

11 years agor24229: Push allocating InBuffer/OutBuffer into reply_transs
Volker Lendecke [Sun, 5 Aug 2007 08:04:11 +0000 (08:04 +0000)]
r24229: Push allocating InBuffer/OutBuffer into reply_transs
(This used to be commit 39a7809aa4c34bb26178589245c419df44796e22)

11 years agor24225: Convert reply_flush to the new API
Volker Lendecke [Sat, 4 Aug 2007 20:44:33 +0000 (20:44 +0000)]
r24225: Convert reply_flush to the new API
(This used to be commit f843c02f0794964eba02ab983f9c0701801f415c)

11 years agor24224: Check wct in reply_trans
Volker Lendecke [Sat, 4 Aug 2007 20:28:46 +0000 (20:28 +0000)]
r24224: Check wct in reply_trans
(This used to be commit fc8759e63ccec7f1cfb9f1d0ecd0f19a496e4153)

11 years agor24223: Convert reply_echo to the new API
Volker Lendecke [Sat, 4 Aug 2007 20:08:35 +0000 (20:08 +0000)]
r24223: Convert reply_echo to the new API
(This used to be commit 4863ff2899419e791ed0e340821072d004fb1d17)

11 years agor24167: Fix Coverity ID 365
Volker Lendecke [Sat, 4 Aug 2007 10:32:54 +0000 (10:32 +0000)]
r24167: Fix Coverity ID 365

We checked argc>=3 some lines above
(This used to be commit fa385e9f3c980756e428d89e73012cce895c3bf6)

11 years agor24166: Fix Coverity ID 391
Volker Lendecke [Sat, 4 Aug 2007 10:25:27 +0000 (10:25 +0000)]
r24166: Fix Coverity ID 391
(This used to be commit 461974d2cc18c729f152356a9c30cc776f288906)

11 years agor24165: Fix Coverity ID 369.
Volker Lendecke [Sat, 4 Aug 2007 10:18:33 +0000 (10:18 +0000)]
r24165: Fix Coverity ID 369.

This was not really a bug I think, but this change cleans up the code a
(This used to be commit 59b4914df3ecc97a1c629e8c7a066aed8e8d9226)

11 years agor24164: Fix for write cache corruption bug reported by Jean-Francois Panisset <paniss...
Jeremy Allison [Fri, 3 Aug 2007 16:51:43 +0000 (16:51 +0000)]
r24164: Fix for write cache corruption bug reported by Jean-Francois Panisset <>.
Awaiting confirmation from reporter.
(This used to be commit 7bd65060bd965bd17a5d79639cf561b8b578cb36)

11 years agor24163: Remove the send_trans2_replies_new wrapper
Volker Lendecke [Fri, 3 Aug 2007 16:06:44 +0000 (16:06 +0000)]
r24163: Remove the send_trans2_replies_new wrapper

This changes send_trans2_replies to not depend on large buffers anymore
and finishes the trans2 conversion.
(This used to be commit b1d133e4ffa8c9b8219ba6e7b83e23ca4bdd1616)

11 years agor24162: send_trans2_replies is now static in trans2.c
Volker Lendecke [Fri, 3 Aug 2007 15:45:41 +0000 (15:45 +0000)]
r24162: send_trans2_replies is now static in trans2.c
(This used to be commit 47261fb6fecc036cb1605f46bbe24e9b3661ff8c)

11 years agor24161: handle_trans2 takes care of errors itself, no need to do it in reply_transs2
Volker Lendecke [Fri, 3 Aug 2007 15:27:28 +0000 (15:27 +0000)]
r24161: handle_trans2 takes care of errors itself, no need to do it in reply_transs2
(This used to be commit ca26b43e02f25d75e7439c6130f32dc322acd327)

11 years agor24160: process_trans2 in smbd/blocking.c used send_trans2_replies.
Volker Lendecke [Fri, 3 Aug 2007 14:33:38 +0000 (14:33 +0000)]
r24160: process_trans2 in smbd/blocking.c used send_trans2_replies.

Fake a struct smb_request here.

(This used to be commit f712d1c92bee024a165b5facabdac1e2c866d9b1)

11 years agor24159: Convert reply_transs2 to the new API
Volker Lendecke [Fri, 3 Aug 2007 14:02:07 +0000 (14:02 +0000)]
r24159: Convert reply_transs2 to the new API
(This used to be commit a55a4d71ffe9ff1395e02f8bb3ad88fe5132fe99)