Michael Adam [Tue, 6 Nov 2007 05:31:24 +0000 (06:31 +0100)]
Add a const.
Michael
metze [Tue, 6 Nov 2007 07:01:17 +0000 (07:01 +0000)]
libreplace: we should only have one location where we check for required functions
metze
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25864
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
metze [Tue, 6 Nov 2007 06:54:49 +0000 (06:54 +0000)]
libreplace: we need include <unistd.h> before nss_wrapper.h
metze
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25863
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 04:59:50 +0000 (04:59 +0000)]
Fix export dynamic for HPUX.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25861
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 04:26:57 +0000 (04:26 +0000)]
Remove flag that causes problems on some hosts.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25860
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 04:26:52 +0000 (04:26 +0000)]
Wrap native HPUX functions in dl implementation.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25859
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 03:43:50 +0000 (03:43 +0000)]
Check for HPUX dl functions.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25855
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 02:35:46 +0000 (02:35 +0000)]
Move SHLIBEXT determination into a test as well.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25852
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 02:17:05 +0000 (02:17 +0000)]
Move system-specific ldflags checks to libreplace so they can be used by ldb.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25851
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 02:16:55 +0000 (02:16 +0000)]
Add macro for picflag.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25850
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jelmer [Tue, 6 Nov 2007 01:05:19 +0000 (01:05 +0000)]
Add configure test for -Wl,--export-dynamic.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25846
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
metze [Mon, 5 Nov 2007 15:45:08 +0000 (15:45 +0000)]
libreplace: include nss_wrapper.h if NSS_WRAPPER is defined
metze
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25838
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
Jeremy Allison [Tue, 6 Nov 2007 07:17:19 +0000 (23:17 -0800)]
Ensure we null out the address correctly.
Jeremy.
Michael Adam [Tue, 6 Nov 2007 00:09:24 +0000 (01:09 +0100)]
Fix another segfault and make smbfilter run again.
This fix is not complete yet (loop after "client closed connection")
but at least it starts again...
Micheal
Michael Adam [Tue, 6 Nov 2007 00:07:12 +0000 (01:07 +0100)]
Fix a segfault.
Michael
Michael Adam [Tue, 6 Nov 2007 00:06:06 +0000 (01:06 +0100)]
Try to fix the build. There was one forgotten caller
of receive_smb. Jeremy: please check!
Michael
Günther Deschner [Mon, 5 Nov 2007 23:50:47 +0000 (00:50 +0100)]
When deleting a key from the registry make sure the non-default
security descriptor gets deleted as well.
Guenther
Michael Adam [Mon, 5 Nov 2007 22:23:05 +0000 (23:23 +0100)]
Add two const's.
Michael
Jeremy Allison [Mon, 5 Nov 2007 19:12:56 +0000 (11:12 -0800)]
Remove the horror that was the global smb_rw_error.
Each cli struct has it's own local copy of this variable,
so use that in client code. In the smbd server, add one
static to smbd/proccess.c and use that inside smbd. Fix
a bunch of places where smb_rw_error could be set by
calling read_data() in places where we weren't reading
from the SMB client socket (ie. winbindd).
Jeremy.
Michael Adam [Mon, 5 Nov 2007 14:16:11 +0000 (15:16 +0100)]
Fix a typo.
Michael
Günther Deschner [Mon, 5 Nov 2007 01:35:04 +0000 (02:35 +0100)]
Ignore testing tdb.
Guenther
Jeremy Allison [Mon, 5 Nov 2007 06:20:04 +0000 (22:20 -0800)]
Don't alloc struct iface_struct nics[MAX_INTERFACES]; (128 entries)
on the stack - use talloc.
Jeremy
Jeremy Allison [Mon, 5 Nov 2007 06:14:19 +0000 (22:14 -0800)]
This should really be a cond_set_smb_read_error().
Jeremy.
Jeremy Allison [Mon, 5 Nov 2007 06:12:31 +0000 (22:12 -0800)]
Don't use 0 when we mean SMB_READ_OK.
Jeremy.
Günther Deschner [Mon, 5 Nov 2007 02:39:18 +0000 (03:39 +0100)]
Merge commit 'origin/v3-2-test' into branches/upstream
Volker Lendecke [Thu, 1 Nov 2007 16:42:35 +0000 (17:42 +0100)]
Remove unnecessary code
SAFE_FREE checks for NULL anyway, and SMB_STRDUP panics on failure
Volker Lendecke [Tue, 30 Oct 2007 21:58:09 +0000 (22:58 +0100)]
Fix a debug message
Günther Deschner [Fri, 26 Oct 2007 10:58:01 +0000 (12:58 +0200)]
Display sec ace flags.
Guenther
Günther Deschner [Mon, 5 Nov 2007 01:33:58 +0000 (02:33 +0100)]
Make sure we can read SACLs from the registry.
Guenther
Volker Lendecke [Mon, 5 Nov 2007 02:14:16 +0000 (03:14 +0100)]
Fix the smbmount build
Volker Lendecke [Sun, 4 Nov 2007 17:15:37 +0000 (18:15 +0100)]
static pstring removal
Volker Lendecke [Thu, 1 Nov 2007 16:49:31 +0000 (17:49 +0100)]
pstring removal
Volker Lendecke [Sat, 3 Nov 2007 14:03:26 +0000 (15:03 +0100)]
Make load_registry_service return the share number
Jeremy Allison [Mon, 5 Nov 2007 01:15:35 +0000 (17:15 -0800)]
Forgot arg type.
Jeremy.
Jeremy Allison [Sun, 4 Nov 2007 23:38:43 +0000 (15:38 -0800)]
Don't believe len returned from read_smb_length_return_keepalive(),
it may be a UNIX large writeX (which wraps len in that case).
Stevef this should fix your 128k write bug.
Jeremy.
Jeremy Allison [Sun, 4 Nov 2007 06:20:10 +0000 (23:20 -0700)]
Remove most of the remaining globals out of lib/util_sock.c.
I have a plan for dealing with the remaining..... Watch
this space.
Jeremy.
Jeremy Allison [Sun, 4 Nov 2007 05:34:46 +0000 (22:34 -0700)]
Remove more static data from lib/util_sock.c and
callers.
Jeremy.
Jeremy Allison [Sun, 4 Nov 2007 03:27:59 +0000 (20:27 -0700)]
Missed one case where I need to pass down addrlen.
Jeremy
Jeremy Allison [Sun, 4 Nov 2007 01:41:26 +0000 (18:41 -0700)]
I can't get away without a 'length' arg. :-).
Jeremy.
Jeremy Allison [Sun, 4 Nov 2007 01:15:45 +0000 (18:15 -0700)]
Stop get_peer_addr() and client_addr() from using global
statics. Part of my library cleanups.
Jeremy.
Jeremy Allison [Sat, 3 Nov 2007 22:12:42 +0000 (15:12 -0700)]
Remove the smb_read_error global variable and replace
it with accessor functions. "One global or pstring a day...." :-).
Jeremy.
Jeremy Allison [Sat, 3 Nov 2007 17:25:51 +0000 (10:25 -0700)]
Remove unused var noticed by metze.
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 21:23:10 +0000 (14:23 -0700)]
Fix the snprintf checks, and fix a typo in pointer indirection.
These fixes are needed for a working getaddrinfo etc. replacement.
Fixes from Wayne Davison <wayned@samba.org> from rsync.
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 21:22:19 +0000 (14:22 -0700)]
Ensure we use the correct socklen_t values for bind() for
Solaris.
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 19:56:21 +0000 (12:56 -0700)]
Fix typos in calc_sa_size, noticed by jim.brown@miami.edu
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 19:21:34 +0000 (12:21 -0700)]
Change the client library to write directly out of
the incoming buffer in the non-signed case. Speeds
up writes by over 10% or so. Complete the server
recvfile implementation.
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 19:06:15 +0000 (12:06 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 2 Nov 2007 19:05:17 +0000 (12:05 -0700)]
Forgot one more getnameinfo.
Jeremy.
Gerald (Jerry) Carter [Fri, 2 Nov 2007 18:16:40 +0000 (14:16 -0400)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Gerald (Jerry) Carter [Fri, 2 Nov 2007 18:16:06 +0000 (14:16 -0400)]
Fix build breakage when not specifying --with-fhs.
Ensure that CODEPAGEDIR, STATEDIR, and CACHEDIR have values.
Jeremy Allison [Fri, 2 Nov 2007 17:35:10 +0000 (10:35 -0700)]
Argggh. smblen doesn't include the +4, so my smb_doff calculations
shouldn't either :-).
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 17:25:34 +0000 (10:25 -0700)]
Fix Solaris by ensuring we use the IPv4 or IPv6 length
in any getnameinfo calls.
Jeremy
Jeremy Allison [Fri, 2 Nov 2007 16:27:04 +0000 (09:27 -0700)]
Fix state_path to take a const string, not use pstring.
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 05:42:21 +0000 (22:42 -0700)]
Ensure we can't accidently do a pipe write with
unread bytes in the socket buffer.
Jeremy
Jeremy Allison [Fri, 2 Nov 2007 05:24:39 +0000 (22:24 -0700)]
Be careful and take care of the correct lengths in large
writeX calls.
Jeremy.
Jeremy Allison [Fri, 2 Nov 2007 04:51:45 +0000 (21:51 -0700)]
Ensure we detect a large writeX when using recvfile.
More changes needed to make the UNIX_LARGE_WRITEX_CAP
writes work (I'll add these tomorrow).
Jeremy.
Gerald (Jerry) Carter [Fri, 2 Nov 2007 01:30:43 +0000 (21:30 -0400)]
Merge branch 'v3-2-test' of git://git.samba.org/samba into v3-2-test
Jeremy Allison [Fri, 2 Nov 2007 01:30:02 +0000 (18:30 -0700)]
Add brackets so as not to break the POSIX caps return.
Jeremy.
Volker Lendecke [Sat, 20 Oct 2007 09:12:11 +0000 (11:12 +0200)]
Fix for bug 5021
This is a different fix than the bug reporter (Evgeniy Dushistov
<dushistov at mail.ru>, thanks!) created, but it lives without the boolean
status variable. Untested so far, but I can not add attachments to bugs right
now. But to me this looks really obvious.
Gerald (Jerry) Carter [Thu, 1 Nov 2007 19:53:44 +0000 (15:53 -0400)]
Patch 2 of 3 from Debian Samba packagers:
The point is doing the following associations:
- non discardable state data (all TDB files that may need to be backed
up) go to statedir
- shared data (codepage stuff) go to codepagedir
The patch *does not change* the default location for these
directories. So, there is no behaviour change when applying it.
The main change is for samba developers who have to think when dealing
with files that previously pertained to libdir whether they:
- go in statedir
- go in codepagedir
- stay in libdir
Volker Lendecke [Wed, 31 Oct 2007 14:06:22 +0000 (15:06 +0100)]
save memory
Hi!
Attached find a patch that I've wanted to check in for ages.
The whole area probably needs a major rewrite, but this is a
minimal patch that on a 32-bit box saves 1.5k per smbd per
defined share, twice as much on a 64-bit box.
Volker
From
ebb80e664ecc49eb597a45cb57e1067fbae49e62 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@sernet.de>
Date: Wed, 31 Oct 2007 15:04:34 +0100
Subject: [PATCH] Change global->copymap from bool* to a bitmap
We right now have 401 parameters, so with bool being represented as a 64-bit
integer this saves about 3k of memory per smbd per share that is defined in
smb.conf.
Jeremy Allison [Thu, 1 Nov 2007 17:21:27 +0000 (10:21 -0700)]
Add missing recvfile_bytes element - noticed by Kukks.
Jeremy.
Gerald (Jerry) Carter [Thu, 1 Nov 2007 17:00:10 +0000 (13:00 -0400)]
Patch from Debian Samba package maintainers:
Patch 1 of 3:
- Patch 1 adds the new variables
- Patch 2 makes uses of them for files belonging to the "state" path
and the "code pages" path
This patch seemed more easily acceptable, which explains why we
separated it from patch 3
- Patch 3 reassigns files to the "cache" path. Indeed all "debatable"
changes have been moved to that one
The point is adding:
- a path for non discardable state data: basically all TDB files
that may need to be backed up
- a path for shared data: mostly codepage stuff
- a path for cache data to host files such as
browse.dat, printers.tbd, <printer>.tdb
All these are currently mixed in "libdir" (${prefix}/lib/samba by default).
The patch keeps these new paths to point to ${prefix}/lib/samba by default
and does therefore not change the software behaviour. Used alone, it just
adds unused variables...so it can safely be used in sources without any
behaviour change and no impact on Samba developers work.
Michael Adam [Thu, 1 Nov 2007 13:24:27 +0000 (14:24 +0100)]
Enable building the zfsacl VFS module by specifying
"--with-shared-modules=vfs_zfsacl" on the configure command line.
Michael
Jeremy Allison [Wed, 31 Oct 2007 23:32:48 +0000 (16:32 -0700)]
Note when we're setting change time, not write time, and send
message accordingly. Apart from not supporting create time we
now pass the S4 RAW-NOTIFY torture.
Jeremy.
Jeremy Allison [Wed, 31 Oct 2007 22:45:45 +0000 (15:45 -0700)]
Fix some cases where file_set_dosmode was being passed
False instead of NULL. Fix more of the notifications to
be correct for Samba4 RAW-NOTIFY torture (we had missed
one when calling set_ea_dos_attribute().
Jeremy.
Jeremy Allison [Wed, 31 Oct 2007 21:24:52 +0000 (14:24 -0700)]
Fix vfstest link - move socket calls into smbd/process.c
not smbd/server.c
Jeremy
Jeremy Allison [Wed, 31 Oct 2007 21:12:50 +0000 (14:12 -0700)]
Add printout of large read/write caps if detected.
Jeremy.
Jeremy Allison [Wed, 31 Oct 2007 21:01:35 +0000 (14:01 -0700)]
Make explicit draining the socket on RECVFILE. Add
capability for large UNIX write if not signing and
recvfile set. Cope with large UNIX write length on
incoming processing. Stevef - we can now test 1-16Mb
writes from CIFFS.
Jeremy.
Jeremy Allison [Wed, 31 Oct 2007 01:18:40 +0000 (18:18 -0700)]
Handle the disk full error case correctly.
Jeremy.
Jeremy Allison [Wed, 31 Oct 2007 00:42:02 +0000 (17:42 -0700)]
Ensure we don't prematurely clean out the bytes read.
Jeremy.
Jeremy Allison [Tue, 30 Oct 2007 23:22:24 +0000 (16:22 -0700)]
Add new parameter, "min receivefile size" (by default set
to zero). If non-zero, writeX calls greater than this
value will be left in the socket buffer for later handling
with recvfile (or userspace equivalent). Definition of
recvfile for your system is left as an exercise for
the reader (I'm working on getting splice working :-).
Jeremy.
Jeremy Allison [Tue, 30 Oct 2007 19:55:56 +0000 (12:55 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Tue, 30 Oct 2007 19:54:39 +0000 (12:54 -0700)]
Our userlevel SMBwriteX call is non-standard in that it
sometimes uses a 12-word write and doesn't include a pad
byte (as Windows does). Fix this so that we are identical
to Windows clients. This will make recvfile processing
much easier to detect (as we can just read a standard
writeX header length to decide).
Jeremy.
Jeremy Allison [Tue, 30 Oct 2007 17:19:45 +0000 (10:19 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Stefan Metzmacher [Tue, 30 Oct 2007 14:44:27 +0000 (15:44 +0100)]
start smbd, nmbd and winbindd with the same startup message
at debug level 0.
metze
Jeremy Allison [Tue, 30 Oct 2007 00:17:16 +0000 (17:17 -0700)]
Forgot to add recvfile.c
Jeremy.
Jeremy Allison [Tue, 30 Oct 2007 00:16:13 +0000 (17:16 -0700)]
Add in the recvfile entry to the VFS layer with a default
implementation. Needed for the zero-copy write code.
Jeremy.
Jeremy Allison [Mon, 29 Oct 2007 22:03:36 +0000 (15:03 -0700)]
Fix the setup_kaddr() call to cope with IPv6.
This is the last obvious change I can see. At
this point we can start claiming IPv6 support
(Hurrah !:-).
Jeremy.
Jeremy Allison [Mon, 29 Oct 2007 20:34:00 +0000 (13:34 -0700)]
Change our DNS code to cope with AAAA records. A6 records
look like a nightmare to use, so ignore them for now.
Jeremy.
Volker Lendecke [Sun, 28 Oct 2007 10:58:26 +0000 (11:58 +0100)]
Enable vfs objects = /full/path/to/object.so
Right now I'm testing a vfs object. I can't right now in make test, because
"vfs objects" assumes the .so files to be in $libdir/vfs. This patch parses the
module name out of the object name in case it starts with "/". The module name
is assumed to be the last path component's basename.
Jeremy Allison [Sun, 28 Oct 2007 03:29:36 +0000 (20:29 -0700)]
Change all occurrences of zero_addr(&ss,AF_INET) to
zero_addr(&ss). All current uses were always of the
AF_INET form, so simplify the call. If in the future
we need to zero an addr to AF_INET6 this can be
done separately.
Jeremy.
Jeremy Allison [Sat, 27 Oct 2007 19:51:38 +0000 (12:51 -0700)]
Fix zero_addr(&ip, INADDR_ANY); -> zero_addr(&ip, AF_INET)
from Volker's patch.
Jeremy.
Volker Lendecke [Sat, 27 Oct 2007 19:15:07 +0000 (21:15 +0200)]
Two patches
Hi!
Can you check and push them?
Thanks,
Volker
From
b488af5905e2dee12a1a72a3b40801ae5c26f24f Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@sernet.de>
Date: Sat, 27 Oct 2007 14:20:09 +0200
Subject: [PATCH] Fix some warnings and errors
Stefan Metzmacher [Sat, 27 Oct 2007 09:57:48 +0000 (11:57 +0200)]
rerun make idl
metze
metze [Sat, 27 Oct 2007 08:10:14 +0000 (08:10 +0000)]
add NDR_ERR_INVALID_POINTER
metze
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_4_0@25744
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
Jeremy Allison [Sat, 27 Oct 2007 00:58:28 +0000 (17:58 -0700)]
Ensure temporary memory is freed - pointed out by "Li, Ying (ESG)" <ying.li2@hp.com>.
We aren't currently leaking memory, but are leaving it around for
longer than we need to.
Jeremy.
Jeremy Allison [Fri, 26 Oct 2007 23:22:18 +0000 (16:22 -0700)]
Fix popt bool problems (need POPT_ARG_NONE, not POPT_ARG_VALUE).
Reported by kukks - thanks !
Jeremy.
Jeremy Allison [Fri, 26 Oct 2007 23:03:20 +0000 (16:03 -0700)]
Move the horrible hack for link local addresses out of namequery.c
and into util_sock.c. is_ipaddress() now copes with link:local:v6%ifname
addresses, as does interpret_string_addr().
Jeremy
Jeremy Allison [Fri, 26 Oct 2007 23:02:16 +0000 (16:02 -0700)]
Fix a few more sockaddr -> sockaddr_storgage.
Jeremy.
Stefan Metzmacher [Fri, 26 Oct 2007 14:37:32 +0000 (16:37 +0200)]
one more struct in_addr => struct sockaddr_storage
jra: please check this...
metze
Jeremy Allison [Fri, 26 Oct 2007 02:07:25 +0000 (19:07 -0700)]
Fix bug in writing names into gencache
as well as 2 typos where AF_INET6 was mistypes as AF_INET.
JERRY YOU NEED THESE FIXES.
Fixes smbclient -L localhost -U%
Bugs reported by Kukks (thanks kukks).
Jeremy.
Jeremy Allison [Fri, 26 Oct 2007 01:28:36 +0000 (18:28 -0700)]
Fix resolve name to resolve IPv6 addresses of link-local%ifaddr
Jeremy.
Jeremy Allison [Fri, 26 Oct 2007 01:29:49 +0000 (18:29 -0700)]
Fix a mismatched interface where we were using
uint32 instead of enum lsa_SidType.
Jeremy.
Jeremy Allison [Fri, 26 Oct 2007 01:15:02 +0000 (18:15 -0700)]
Fix cast typo - would have broken all dgram sends.
Jeremy.
Jeremy Allison [Fri, 26 Oct 2007 01:11:29 +0000 (18:11 -0700)]
Fixed missing in_addr -> sockaddr_storage conversion (how did
I miss this...).
Jeremy.
Jeremy Allison [Fri, 26 Oct 2007 00:17:46 +0000 (17:17 -0700)]
Fix reversed bool check for access. Found by kukks.
Thanks !
Jeremy.
Jeremy Allison [Thu, 25 Oct 2007 23:22:40 +0000 (16:22 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 25 Oct 2007 23:14:52 +0000 (16:14 -0700)]
When doing reverse lookups actually look up the name, not
just the numeric address (doh!) :-).
Jeremy.
Jeremy Allison [Thu, 25 Oct 2007 22:43:44 +0000 (15:43 -0700)]
Try and fix the Solaris build by adding a missing define
(from Jerry).
Jeremy