24 years agoAdded a very small piece of documentation to describe the binary tree
Christopher R. Hertel [Tue, 14 Oct 1997 19:32:30 +0000 (19:32 +0000)]
Added a very small piece of documentation to describe the binary tree

24 years agopipentlsa.c :
Luke Leighton [Tue, 14 Oct 1997 19:31:07 +0000 (19:31 +0000)]
pipentlsa.c :

lsa close odd bug.

smbparse.c :

smb_io_dom_sid() _does_ need 4-byte alignment before it.

24 years agoAdded a copy of the LGPL to the samba/ubiqx/ directory.
Christopher R. Hertel [Tue, 14 Oct 1997 19:30:07 +0000 (19:30 +0000)]
Added a copy of the LGPL to the samba/ubiqx/ directory.

24 years agobyteorder.h:
Luke Leighton [Tue, 14 Oct 1997 18:37:55 +0000 (18:37 +0000)]

created a RW_PIVAL macro which was missing.


smb_io_dom_sid() was storing its sub-authorities as uint16s instead
of uint32s.  used the DBG_RW_PIVAL macro instead of DBG_RW_PSVAL.


not sure.  something to do with the Query Info reply.


make_rpc_reply() had the packed representation field set to 0x0100 0000
instead of 0x1000 0000, which had the interesting result of turning all
uint32 and uint16 field byte ordering the other way round!

24 years agocredentials, query info reply.
Luke Leighton [Tue, 14 Oct 1997 17:01:43 +0000 (17:01 +0000)]
credentials, query info reply.

24 years agodocs/DIAGNOSIS.txt:
John Terpstra [Tue, 14 Oct 1997 13:12:01 +0000 (13:12 +0000)]
Added comment right up front about "your server is being unfriendly"
type error messages.

Added compile options for RedHat Linux 5.0 series.

24 years agochanged *(uint32*)(clnt_cred) to SIVAL(clnt_cred, ....)
Luke Leighton [Tue, 14 Oct 1997 10:17:12 +0000 (10:17 +0000)]
changed *(uint32*)(clnt_cred) to SIVAL(clnt_cred, ....)

24 years agoBroke my own rule about checking in uncompiled source :-(.
Jeremy Allison [Tue, 14 Oct 1997 00:36:57 +0000 (00:36 +0000)]
Broke my own rule about checking in uncompiled source :-(.

24 years agoAdded fixes for become_user braindamage.
Jeremy Allison [Tue, 14 Oct 1997 00:16:37 +0000 (00:16 +0000)]
Added fixes for become_user braindamage.
Jeremy (

24 years agoanother alignment of client challenge: this one in lsa_io_q_auth_2().
Luke Leighton [Mon, 13 Oct 1997 19:37:43 +0000 (19:37 +0000)]
another alignment of client challenge: this one in lsa_io_q_auth_2().
there are going to be a few of these...

24 years agolsa_io_r_req_chal() - challenge is not 4-byte aligned after the unicode
Luke Leighton [Mon, 13 Oct 1997 18:11:20 +0000 (18:11 +0000)]
lsa_io_r_req_chal() - challenge is not 4-byte aligned after the unicode

24 years agoput a check around become_user(). doesn't authenticate the user, but doesn't
Luke Leighton [Mon, 13 Oct 1997 17:11:07 +0000 (17:11 +0000)]
put a check around become_user().  doesn't authenticate the user, but doesn't
quit the whole pipe, either...

24 years agoresolving some of the confusion over credentials.
Luke Leighton [Mon, 13 Oct 1997 16:32:43 +0000 (16:32 +0000)]
resolving some of the confusion over credentials.

24 years agosplit pipes.c down into util, netlog and ntlsa.
Luke Leighton [Mon, 13 Oct 1997 15:55:54 +0000 (15:55 +0000)]
split pipes.c down into util, netlog and ntlsa.

24 years agodebugging... no idea what i'm doing.
Luke Leighton [Mon, 13 Oct 1997 14:19:17 +0000 (14:19 +0000)]
debugging... no idea what i'm doing.

24 years agoreverted a change made by Luke at his request.
Andrew Tridgell [Mon, 13 Oct 1997 13:49:50 +0000 (13:49 +0000)]
reverted a change made by Luke at his request.

Luke, when you don't know what has been changed in the CVS tree I
highly recommend you point your browser at:

If you click on a filename you can then see all the commits and
changes that have been made to it over time. You can also download any
version of the file or find the differences between any two versions.

All of this is not dependent on the state of your local CVS sandbox,
so it can be used to find out the "true" state of the tree at any

If you suspect some sort of CVS problem (like a change getting
reverted) then please use the above URL to work out what has
happened. You should be able to see exactly who made what changes and

24 years agodebug info added
Luke Leighton [Mon, 13 Oct 1997 13:35:37 +0000 (13:35 +0000)]
debug info added

24 years agoJHT ==> Getting ready for 1.9.18alpha1.
John Terpstra [Mon, 13 Oct 1997 13:00:59 +0000 (13:00 +0000)]
JHT ==> Getting ready for 1.9.18alpha1.
added line "share modes = no" to netlogon share parameter list

updated RedHat RPM build files.
added smbadduser script (modified for RHL).

24 years agochecked in a file with a compile error. oops!
Luke Leighton [Mon, 13 Oct 1997 12:55:07 +0000 (12:55 +0000)]
checked in a file with a compile error.  oops!

24 years agobyteorder.h :
Luke Leighton [Mon, 13 Oct 1997 12:21:56 +0000 (12:21 +0000)]
byteorder.h :

debugging output wasn't (still isn't) perfect.

credentials.c lsaparse.c smbparse.c :

added DEBUG strings.

pipes.c :

lost some changes, to do with setup of RPC headers.  arg.

24 years agoJHT ==> Removed linefeed that caused problems.
John Terpstra [Mon, 13 Oct 1997 12:13:11 +0000 (12:13 +0000)]
JHT ==> Removed linefeed that caused problems.

24 years agoalign_offset() adjusted pointer to wrong location. oops.
Luke Leighton [Mon, 13 Oct 1997 11:15:46 +0000 (11:15 +0000)]
align_offset() adjusted pointer to wrong location.  oops.

24 years agoupdated the "comment =" entry a bit
Andrew Tridgell [Mon, 13 Oct 1997 00:03:37 +0000 (00:03 +0000)]
updated the "comment =" entry a bit

updated the fake oplocks entry a bit

24 years agogetting somewhere.
Luke Leighton [Sun, 12 Oct 1997 19:02:55 +0000 (19:02 +0000)]
getting somewhere.

ipc.c :

removed srvsvc pipe reference: have to do that.

pipes.c lsaparse.c smbparse.c :

more debugging info.  looks a bit like netmon output.

24 years agoupdated rpc header reply: callid wrong; alloc hint a uint32 not a uint16.
Luke Leighton [Sun, 12 Oct 1997 17:07:35 +0000 (17:07 +0000)]
updated rpc header reply: callid wrong; alloc hint a uint32 not a uint16.
still doesn't get rid of the netlogon trans2 request with zero data.

24 years agoipc.c:
Luke Leighton [Sun, 12 Oct 1997 14:17:55 +0000 (14:17 +0000)]

debugging info.  found that data = NULL because of short packet length
indicated from the ntlsaRPC pipe _royally_ stuffs NT's packet handling.
maybe this should go down as a service denial bug to the ntbugtraq list.

pipes.c lsaparse.c smbparse.c :

added more debug stuff.  added length of header to data_len in MSRPC
fragment_length field (0x18 bytes short) which caused the above bug
from NT 4.0.  oops.

24 years agoadded debugging macros (suitable eventually for use in tcpdump, hopefully)
Luke Leighton [Sun, 12 Oct 1997 11:46:42 +0000 (11:46 +0000)]
added debugging macros (suitable eventually for use in tcpdump, hopefully)

24 years agoAdded Finland ftp mirror (PR#175) (Paul)
Samba Release Account [Sun, 12 Oct 1997 04:40:48 +0000 (04:40 +0000)]
Added Finland ftp mirror (PR#175) (Paul)

24 years agoremove { and } from the list of illegal characters in filenames. The
Andrew Tridgell [Sun, 12 Oct 1997 03:48:47 +0000 (03:48 +0000)]
remove { and } from the list of illegal characters in filenames. The
CIFS3 spec does not list them as illegal.

This allows things like the control panel icon to be placed on a Samba

24 years agoJHT ==> Luke, your forgot to change the modified date!
John Terpstra [Sat, 11 Oct 1997 16:03:21 +0000 (16:03 +0000)]
JHT ==> Luke, your forgot to change the modified date!

24 years agonamelogon.c :
Luke Leighton [Sat, 11 Oct 1997 15:10:57 +0000 (15:10 +0000)]
namelogon.c :

added NTLOGON.  (fixed the case 0:)


call to NTLOGON mailslot


defines for NETLOGON and NTLOGON mailslot


added andrew's dump_data() function.

24 years agoupdated Sunsite UK. (Paul)
Samba Release Account [Sat, 11 Oct 1997 03:53:53 +0000 (03:53 +0000)]
updated Sunsite UK. (Paul)

24 years agoUpdated mirrors, combined Sources and Sources&Binaries as our binaries
Samba Release Account [Sat, 11 Oct 1997 02:50:55 +0000 (02:50 +0000)]
Updated mirrors, combined Sources and Sources&Binaries as our binaries
are now with our sources.
Have requested that mirror sites remove the old 'binaries' tree.

24 years agothe usual
Luke Leighton [Fri, 10 Oct 1997 19:49:17 +0000 (19:49 +0000)]
the usual

24 years agoadded api_lsa_sam_logon() and api_sam_logoff(). that's it. lots of
Luke Leighton [Fri, 10 Oct 1997 19:48:51 +0000 (19:48 +0000)]
added api_lsa_sam_logon() and api_sam_logoff().  that's it.  lots of
run-time debugging, now.

24 years agoadded lsa_reply_srv_pwset()
Luke Leighton [Fri, 10 Oct 1997 18:03:30 +0000 (18:03 +0000)]
added lsa_reply_srv_pwset()

24 years agoipc.c :
Luke Leighton [Fri, 10 Oct 1997 16:40:23 +0000 (16:40 +0000)]
ipc.c :

call to api_netlogRPC

lsaparse.c :

renamed lsa_io_q_auth2 to lsa_io_q_auth_2.

pipes.c :

added api_lsa_reply_auth_2() and api_netlogRPC.

proto.h :

the usual.

24 years agoI have to admit that I'm not very good at writing Makefiles.
Christopher R. Hertel [Fri, 10 Oct 1997 16:12:27 +0000 (16:12 +0000)]
I have to admit that I'm not very good at writing Makefiles.
This one will simply create an object file from each of the .c files
in the directory.  These could be linked into a static library, but
I'm not sure that this is worthwhile.  If anyone wants to improved on
what I've got here, please do!  crh -)-----

24 years agoMakefile:
Luke Leighton [Fri, 10 Oct 1997 14:48:05 +0000 (14:48 +0000)]

added credentials.c to smbd


using credential structures instead of char*

password.c uid.c server.c:

added sid and attr to user_struct.


smbhash and str_to_key make public instead of private.

pipes.c smb.h:

lsa structures, sub-functions.



24 years agoThis is the ubiqx binary tree and linked list library.
Christopher R. Hertel [Fri, 10 Oct 1997 14:46:43 +0000 (14:46 +0000)]
This is the ubiqx binary tree and linked list library.
This library is being included as part of the Samba distribution.

24 years agoAfter generating some discussion, listening to the opinions, and thinking
Christopher R. Hertel [Fri, 10 Oct 1997 14:13:48 +0000 (14:13 +0000)]
After generating some discussion, listening to the opinions, and thinking
about it for a while, I've decided to move the tree & list code into a
separate subdirectory.

24 years agoAfter generating some discussion, listening to the opinions, and thinking
Christopher R. Hertel [Fri, 10 Oct 1997 14:12:22 +0000 (14:12 +0000)]
After generating some discussion, listening to the opinions, and thinking
it over, I've decided to move the tree & list code into a subdirectory.

24 years agocorrected paragraph giving the impression that samba can be a domain master
Luke Leighton [Fri, 10 Oct 1997 11:52:09 +0000 (11:52 +0000)]
corrected paragraph giving the impression that samba can be a domain master
for multiple workgroups.

24 years agofixed the log wrapping bug.
Andrew Tridgell [Fri, 10 Oct 1997 02:32:01 +0000 (02:32 +0000)]
fixed the log wrapping bug.

This is a very nasty bug that I think explains quite a few
intermittent problems people have been having with Samba.

It may be worth checking on other cases where errno can be overwritten
by seemingly innocuous things (in this case a DEBUG() line)

24 years agonmblookup.c: Added -A ability to do status on ip address.
Jeremy Allison [Fri, 10 Oct 1997 01:32:26 +0000 (01:32 +0000)]
nmblookup.c: Added -A ability to do status on ip address.
smb.h: Added defines we will need for NT SMB calls.
trans2.c: Fixed SMB_QUERY_FILE_ALT_NAME_INFO return - this is only
for short name returns (and only used when you negotiate NT SMB calls
to boot !).
Jeremy (

24 years agoAdded in oplock info.
Jeremy Allison [Thu, 9 Oct 1997 20:30:29 +0000 (20:30 +0000)]
Added in oplock info.
Jeremy (

24 years agoAdded definition of oplocks parameter.
Jeremy Allison [Thu, 9 Oct 1997 18:48:12 +0000 (18:48 +0000)]
Added definition of oplocks parameter.
Jeremy (

24 years agolocal.h: Fix spelling mistake :-).
Jeremy Allison [Thu, 9 Oct 1997 18:40:52 +0000 (18:40 +0000)]
local.h: Fix spelling mistake :-).
namedbsubnet.c: Stop registering 1x name unless we can be a local master.
reply.c: Remove ERRbaddirectory code.
server.c: Remove abort() - use exit_server() instead.
trans2.c: Remove ERRbaddirectory code.
Jeremy (

24 years agoadded #ifdef NTDOMAIN. added call to api_ntLsarpc instead of api_Lsarpc
Luke Leighton [Thu, 9 Oct 1997 16:14:53 +0000 (16:14 +0000)]
added #ifdef NTDOMAIN.  added call to api_ntLsarpc instead of api_Lsarpc
in ipc.c iff NTDOMAIN is defined.

24 years agomoved the array macros outside of the CAREFUL_ALIGNMENT define.
Luke Leighton [Thu, 9 Oct 1997 15:51:43 +0000 (15:51 +0000)]
moved the array macros outside of the CAREFUL_ALIGNMENT define.

24 years agopipes.c:
Luke Leighton [Thu, 9 Oct 1997 15:48:40 +0000 (15:48 +0000)]

added api_ntlsarpcTNP() function.  hooray!


added LSA #defines needed by above function.

24 years agocredentials.c:
Luke Leighton [Thu, 9 Oct 1997 14:40:46 +0000 (14:40 +0000)]

use UTIME structure (defined and commented in smb.h to be time, secs,
                         since 01jan1970)


another sub-function.


added char *unistr2(uint16 *buff) function.  same as unistr except
    it takes uint16* instead of char*.

smbparse.c smb.h:

more structure sorting.


the usual.

24 years agoJHT ===> Added smbadduser contributed by Mike Zakharoff.
John Terpstra [Thu, 9 Oct 1997 11:24:39 +0000 (11:24 +0000)]
JHT ===> Added smbadduser contributed by Mike Zakharoff.

24 years agoan implementation of the NT domain credentials protocol
Andrew Tridgell [Thu, 9 Oct 1997 10:01:12 +0000 (10:01 +0000)]
an implementation of the NT domain credentials protocol

24 years agobracket some macros
Andrew Tridgell [Thu, 9 Oct 1997 06:36:04 +0000 (06:36 +0000)]
bracket some macros

change MAX_PASSWORD_LENGTH to MAX_PASS_LEN to prevent conflict on some

add #ifdef around soft link dependent code (for systems that don't
have soft links)

24 years agoThis is my library of lists and trees. My hope is to replace all of the
Christopher R. Hertel [Thu, 9 Oct 1997 04:09:56 +0000 (04:09 +0000)]
This is my library of lists and trees.  My hope is to replace all of the
hard coded linked lists that are currently used in Samba with calls to
these modules.  This should make the code simpler, smaller, and (I hope)
faster.  The tree code, in particular, should speed up processing where
large lists are involved.

Chris -)-----

24 years agoPut in fix for read-prediction extending files bug. Hard to test, can't
Jeremy Allison [Wed, 8 Oct 1997 22:23:47 +0000 (22:23 +0000)]
Put in fix for read-prediction extending files bug. Hard to test, can't
get read-prediction to happen :-).
Jeremy (

24 years agoadded a dummy function (space in front so make proto doesn't pick it up)
Luke Leighton [Wed, 8 Oct 1997 21:36:42 +0000 (21:36 +0000)]
added a dummy function (space in front so make proto doesn't pick it up)
to call the unused static functions in pipes.c.  avoids need to move
#if UNDEFINED_NTDOMAIN about, to stop compiler warnings while code is
being developed, but might be released as-is.

24 years agoMakefile: Split definitions for SGI4,5,6.
Jeremy Allison [Wed, 8 Oct 1997 20:34:13 +0000 (20:34 +0000)]
Makefile: Split definitions for SGI4,5,6.
includes.h: Split definitions for SGI4,5,6.
pipes.c: Moved Luke's #ifdef to remove warnings.
quotas.c: Two changes for FreeBSD and SGI.
server.c: Quota changes for large filesystems.
Jeremy (

24 years agoadded api_lsa_lookup_sids() function
Luke Leighton [Wed, 8 Oct 1997 18:36:34 +0000 (18:36 +0000)]
added api_lsa_lookup_sids() function

24 years agoloadparm.c proto.h:
Luke Leighton [Wed, 8 Oct 1997 17:12:07 +0000 (17:12 +0000)]
loadparm.c proto.h:

added lp_domainsid()

lsaparse.c smb.h:

debugging structures and parsing functions


finally got to the functions that will go into the RPC switch statement.

24 years agoupdating lsaparse.c and smbparse.c in line with changes to pipes.c and smb.h
Luke Leighton [Wed, 8 Oct 1997 11:47:46 +0000 (11:47 +0000)]
updating lsaparse.c and smbparse.c in line with changes to pipes.c and smb.h
from yesterday.

24 years agoipc.c: Added ERROR_MORE_DATA error if client buffer too small.
Jeremy Allison [Wed, 8 Oct 1997 00:21:39 +0000 (00:21 +0000)]
ipc.c: Added ERROR_MORE_DATA error if client buffer too small.
server.c: Allow admin_user on read only shares. I think this is
safe but it needs looking at.
Jeremy (

24 years agoI rewrote the name_mangle() and name_len().
Christopher R. Hertel [Tue, 7 Oct 1997 22:04:05 +0000 (22:04 +0000)]
I rewrote the name_mangle() and name_len().
The interface is the same, but I've simplified the code a bit and added
a few comments.  I tested the changes and the output is the same as that
produced by the original (at least, it was in all of my tests).  CRH

24 years agolocking.c: Added fix for race condition in slow share mode code.
Jeremy Allison [Tue, 7 Oct 1997 18:46:19 +0000 (18:46 +0000)]
locking.c: Added fix for race condition in slow share mode code.
lsaparse.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
pipes.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
server.c: Fixed last known oplock race condition.
smb.h: Re-removed USE_OPLOCK defines - someone checked in an old version.
smbparse.c: #ifdef'ed out code so this will compile - LUKE PLEASE CHECK THIS.
Jeremy (

24 years agopipes.c:
Luke Leighton [Tue, 7 Oct 1997 18:18:10 +0000 (18:18 +0000)]

more static unused functions in pipes.c for the LSA RPC stream.


corrections and altercations over the documentation


reflecting alterations in LSA structures...

24 years agoJHT ==> Fixing blocksize argument. Patch by: Llyod Whiteman
John Terpstra [Tue, 7 Oct 1997 16:01:08 +0000 (16:01 +0000)]
JHT ==> Fixing blocksize argument. Patch by: Llyod Whiteman

24 years agopipes.c:
Luke Leighton [Tue, 7 Oct 1997 14:58:07 +0000 (14:58 +0000)]

some routines to create LSA RPC packets.  none of them are used.


more tidy-up.

24 years agoincrease the debug level in the "added interface" debug line
Andrew Tridgell [Tue, 7 Oct 1997 14:36:22 +0000 (14:36 +0000)]
increase the debug level in the "added interface" debug line

24 years agoget rid of SIGCLD_IGNORE for HPUX. A user reported it causing lots
Andrew Tridgell [Tue, 7 Oct 1997 11:14:27 +0000 (11:14 +0000)]
get rid of SIGCLD_IGNORE for HPUX. A user reported it causing lots
of defunct smbd processes.


24 years agoMore references to samba.canberra
Samba Release Account [Tue, 7 Oct 1997 04:56:02 +0000 (04:56 +0000)]
More references to samba.canberra
Mental note: always commit from root directory. :^o

24 years agoOops forgot to run the sgml converters that one last time.
Samba Release Account [Tue, 7 Oct 1997 04:50:53 +0000 (04:50 +0000)]
Oops forgot to run the sgml converters that one last time.
All done.

24 years agoRemoved samba.faq from the docs directory, it was out of date. All FAQs in
Samba Release Account [Tue, 7 Oct 1997 04:47:23 +0000 (04:47 +0000)]
Removed samba.faq from the docs directory, it was out of date. All FAQs in

Replaced all reference to

Replaced references to

Added 3 new mirrors, Greece, Poland, Romania

24 years agoFinally ! Found & fixed crash bug with logging message when deleting
Jeremy Allison [Mon, 6 Oct 1997 19:50:51 +0000 (19:50 +0000)]
Finally ! Found & fixed crash bug with logging message when deleting
invalid share mode entries. Thanks to (Dietmar Berg)
for the stack backtrace.
Jeremy (

24 years agoclient.c: Changed shadowed variable.
Jeremy Allison [Mon, 6 Oct 1997 17:52:25 +0000 (17:52 +0000)]
client.c: Changed shadowed variable.
locking.c: Removed USE_OPLOCKS - now the default.
params.c: Removed unused variable.
proto.h: Updated.
reply.c: Removed USE_OPLOCKS - now the default.
server.c: Removed USE_OPLOCKS - now the default.
smb.h: Removed USE_OPLOCKS - now the default.
smbparse.c: Changed shadowed variable.
status.c: Removed USE_OPLOCKS - now the default.
util.c: Removed USE_OPLOCKS - now the default.
Jeremy (

24 years agolsaparse.c smb.h: added 32 bit "return status" to the response structures.
Luke Leighton [Mon, 6 Oct 1997 14:52:26 +0000 (14:52 +0000)]
lsaparse.c smb.h: added 32 bit "return status" to the response structures.

24 years agoMakefile: added lsaparse.c and smbparse.c
Luke Leighton [Mon, 6 Oct 1997 13:30:54 +0000 (13:30 +0000)]
Makefile:                      added lsaparse.c and smbparse.c
lsaparse.c, smbparse.c, smb.h: more functions / structures.
proto.h:                       the usual.

24 years agoupdating lsa and smb parsing routines and structures.
Luke Leighton [Sun, 5 Oct 1997 14:17:53 +0000 (14:17 +0000)]
updating lsa and smb parsing routines and structures.

24 years agoprocesses LSA queries and responses to/from RPC data stream into structures.
Luke Leighton [Sun, 5 Oct 1997 12:39:51 +0000 (12:39 +0000)]
processes LSA queries and responses to/from RPC data stream into structures.

24 years agosmb.h:
Luke Leighton [Sun, 5 Oct 1997 11:56:08 +0000 (11:56 +0000)]

added more structures, this time for the use in the query and response
of the LSA_XXXX functions.  next target: the NTLOGON mailslots (10 minutes


tidying.  adding some more sub-structure functions.

24 years agoproto.h:
Luke Leighton [Sat, 4 Oct 1997 16:51:43 +0000 (16:51 +0000)]

- recreated, as usual.


- added RPC_HDR structure - the 18 byte MSRPC header


- added smb_io_rpc_hdr() function to read/write the RPC_HDR structure.


- added align2, align4, align_offset functions.
- added skip_unicode_string, unistrcpy, unistrncpy functions.
- modified unistrcpy and unistrncpy to return the number of unicode
  characters returned, effectively making skip_unicode_string redundant.

24 years agoadded some RW_XXXX wrapper macros with an extra i/o argument, to call XXXX
Luke Leighton [Sat, 4 Oct 1997 16:42:09 +0000 (16:42 +0000)]
added some RW_XXXX wrapper macros with an extra i/o argument, to call XXXX
or SXXXX as appropriate.

added some for-loop pointer macros that will do a batch of data into a
(fixed length) buffer.  no length validation is done in the macro itself.

note: there are some CAREFUL_ALIGNMENT macros missing.  i think.

24 years agoadded structures readable and writeable by smbparse.c routines into and out
Luke Leighton [Sat, 4 Oct 1997 16:26:02 +0000 (16:26 +0000)]
added structures readable and writeable by smbparse.c routines into and out
of SMB or Mailslot packets.

24 years agopacket parsing routines. for use in SMB and Mailslots
Luke Leighton [Sat, 4 Oct 1997 16:10:21 +0000 (16:10 +0000)]
packet parsing routines.  for use in SMB and Mailslots

24 years agofix some "shadows global" errors.
Andrew Tridgell [Sat, 4 Oct 1997 05:24:02 +0000 (05:24 +0000)]
fix some "shadows global" errors.

24 years agoa bit of bounds checking
Andrew Tridgell [Sat, 4 Oct 1997 05:21:47 +0000 (05:21 +0000)]
a bit of bounds checking

24 years agoa little hack to smbclient to support extracting NT error codes
Andrew Tridgell [Sat, 4 Oct 1997 05:21:14 +0000 (05:21 +0000)]
a little hack to smbclient to support extracting NT error codes

24 years agoThis is all the NT error codes less than 1000. I extracted them using
Andrew Tridgell [Sat, 4 Oct 1997 05:19:24 +0000 (05:19 +0000)]
This is all the NT error codes less than 1000. I extracted them using

If we want to start supporting NT error codes in Samba (which may be
forced upon us by buggy apps) then this is a good start.

24 years agoJHT ===> Added Sun Solaris binary package building spec files contributed
John Terpstra [Sat, 4 Oct 1997 02:57:14 +0000 (02:57 +0000)]
JHT ===> Added Sun Solaris binary package building spec files contributed
         by Tim Towers <>. Note: Not yet checked.

24 years agonmblookup.c:
Christopher R. Hertel [Sat, 4 Oct 1997 01:07:47 +0000 (01:07 +0000)]
  I've added a -r option.  When specified, nmblookup will attempt to bind
  to port 137.  In order for this to work, the user must be root and the
  port must be available (i.e., nmbd not running).  If either condition is
  not met, nmblookup will default to normal behavior; it will try to bind
  to a free port above 7999.  I also removed an artifact.  The -p <port>
  option was being accepted but falling through to the default, which was
  the usage message.  I removed "p:" from the getopt() list.

  Rewritten.  The scanning is much more linear, and I found and fixed a
  few bugs.  I don't like the way that the scratch buffer is handled,
  but I believe that it is an improvement over the previous version.

Chris -)-----

24 years agoRace condition with multiple oplock break requests happens
Jeremy Allison [Sat, 4 Oct 1997 00:23:57 +0000 (00:23 +0000)]
Race condition with multiple oplock break requests happens
more often than you might think (reproduced here with 4 clients
and netbench :-).
Raising debug log level for report from 1 to 3.
Jeremy (

24 years agoMaking it harder for share_mode_entries to be left with
Jeremy Allison [Fri, 3 Oct 1997 23:45:34 +0000 (23:45 +0000)]
Making it harder for share_mode_entries to be left with
non-zero op_type fields. Paranoia code really.
Jeremy (

24 years agolocking.c: Fixed incorrect parameter count in debug statements. May explain
Jeremy Allison [Fri, 3 Oct 1997 20:36:06 +0000 (20:36 +0000)]
locking.c: Fixed incorrect parameter count in debug statements. May explain
           solaris crashes.
reply.c: Added NT specific error code. Put oplock break code in correct place
         in reply_lockingX.
server.c: Removed unneeded error mapping stuff.
          Fixed race condition in oplock code.
trans2.c: Added NT specific error code.
util.c: Added paranoia check in interpret_addr. Some core dumps
        reported here. Upped fcntl debug levels.

Andrew. Please check the NT specific error code handling (search
for the string "/* Ugly - NT specific hack - but needed (JRA) */",
this makes NT and 95 clients behave correctly here - please check
your Visual Basic apps with this code.

Jeremy (

24 years agoadd "static" to a couple of functions that are only used locally.
Andrew Tridgell [Fri, 3 Oct 1997 03:34:19 +0000 (03:34 +0000)]
add "static" to a couple of functions that are only used locally.

set granted_oplock=False at the start of open_file(). This is

24 years agoproto.h: Updated.
Jeremy Allison [Fri, 3 Oct 1997 03:15:24 +0000 (03:15 +0000)]
proto.h: Updated.
server.c: Updated after netbench observation. Oplocks must be
broken *before* share modes are checked, not after. Netbench seems
to be working now.
smb.h: Added offsets for oplock break time fields.
trans2.c: Upped debug messages.
util.c: Upped debug messages.
Jeremy (

24 years agochange a debug level in reply.c
Andrew Tridgell [Thu, 2 Oct 1997 14:11:34 +0000 (14:11 +0000)]
change a debug level in reply.c

change from ERRbaddirectory to ERRbadpath for ENOTDIR errors. This
reverts to the old Samba code. I've done quite a bit of testing
against NT4 and have yet to get it to produce the ERRbaddirectory
error code. Producing ERRbaddirectory made a visual basic application
that was sent to me not run. This might explain some of the "it
doesn't work any more" complaints we've got about 1.9.17.

Jeremy, can you remember how you got NT to produce ERRbaddirectory?
There might be some specific circumstances we need to cover.

24 years agoAdded debug message for oplock_break().
Jeremy Allison [Thu, 2 Oct 1997 03:26:07 +0000 (03:26 +0000)]
Added debug message for oplock_break().
Jeremy (

24 years agochange the semantics of hosts allow/hosts deny so that a global
Andrew Tridgell [Thu, 2 Oct 1997 03:14:32 +0000 (03:14 +0000)]
change the semantics of hosts allow/hosts deny so that a global
setting applies to all shares regardless of any settings on other
shares. This allows us to immediately drop a connection if it does not
come from a allowed host, without even parsing the first SMB
packet. The next time we get a nasty security hole we can offer people
the option of just setting their hosts allow line.

If we drop a connection in this way we generate a "Not listening for
calling name" response and then exit.

add a per share "oplocks" option in smb.conf. I think its important to
be able to disable oplocks on a per-share basis as there are occasions
then they are definately not wanted, for example when sharing data
between a windows box and a unix application. This also allows us to
tell people "try disabling oplocks" when diagnosing problems.

fix a bug in process_smb(). It was taking the length of the packet
from outbuf, not inbuf (this bug was introduced with the oplocks
code). Jeremy, I assume this wasn't deliberate?

24 years agoModified some debug messages, moved from 5 -> 8.
Jeremy Allison [Thu, 2 Oct 1997 02:36:11 +0000 (02:36 +0000)]
Modified some debug messages, moved from 5 -> 8.
Jeremy (

24 years agoFixed problem with oplock_type being set with no port.
Jeremy Allison [Thu, 2 Oct 1997 00:57:59 +0000 (00:57 +0000)]
Fixed problem with oplock_type being set with no port.
Jeremy (