samba.git
2 years agopidl: Use a static const initialised struct in dcerpc_server_$name_init(void)
Andrew Bartlett [Sun, 20 Nov 2016 22:38:24 +0000 (11:38 +1300)]
pidl: Use a static const initialised struct in dcerpc_server_$name_init(void)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agotorture: Remove access to LSARPC via \\pipe\netlogon in rpc.netlogon for ManyGetDCNam...
Andrew Bartlett [Wed, 9 Nov 2016 01:22:33 +0000 (14:22 +1300)]
torture: Remove access to LSARPC via \\pipe\netlogon in rpc.netlogon for ManyGetDCName test

This exploited the fact that we had \\pipe\lsass in both netlogon.idl and lsarpc.idl

To do this, we reset the binding to a new endpoint and reset the association group.

We add a new test specifically for this "feature" that we can knownfail if we
break it to add other new functionality.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agos4/rpc_server: Show what RPC interfaces are listening on which TCP port
Andrew Bartlett [Tue, 18 Oct 2016 23:45:05 +0000 (12:45 +1300)]
s4/rpc_server: Show what RPC interfaces are listening on which TCP port

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agotalloc: Add tests for talloc_parent() after realloc() of the parent
Andrew Bartlett [Sun, 27 Nov 2016 22:47:41 +0000 (11:47 +1300)]
talloc: Add tests for talloc_parent() after realloc() of the parent

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agotalloc: clarify that talloc_magic never includes the bits in TALLOC_FLAG_MASK
Andrew Bartlett [Tue, 22 Nov 2016 21:26:14 +0000 (10:26 +1300)]
talloc: clarify that talloc_magic never includes the bits in TALLOC_FLAG_MASK

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agotalloc: add ASCII art to describe parent/child arrangement
Andrew Bartlett [Mon, 28 Nov 2016 01:44:40 +0000 (14:44 +1300)]
talloc: add ASCII art to describe parent/child arrangement

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agoFix typo
Alexis La Goutte [Wed, 26 Oct 2016 20:18:09 +0000 (22:18 +0200)]
Fix typo

Fix (minor) typo found in wireshark with lintian tools
https://code.wireshark.org/review/#/c/18485/

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agopython: Add py3compat.h
Petr Viktorin [Tue, 28 Jun 2016 15:58:04 +0000 (17:58 +0200)]
python: Add py3compat.h

This adds a shared header file with macros that enable compatibility
between Python 2 and 3.
The macros are the ones used in ldb/tdb, with some additions
that make sense when the header is shared among several modules.
See the module for a summary of contents.

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agopython: samba.subunit.run: Fix Python 3 compatibility.
Lumir Balhar [Wed, 19 Oct 2016 11:32:59 +0000 (13:32 +0200)]
python: samba.subunit.run: Fix Python 3 compatibility.

Usage of function _test_id() which generates test id in bytes breaks
Python 3 compatibility. After fix, this function is not used any more.

Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agopython: selftesthelpers: Add possibility for planning tests for
Lumir Balhar [Wed, 19 Oct 2016 18:51:47 +0000 (20:51 +0200)]
python: selftesthelpers: Add possibility for planning tests for
'extra_python' (Python 3).

This change allows us to mark modules which are Python 3 compatible
with the keyword argument `py3_compatible`. Then, if building with
Python 3 is configured using --extra-python, `planpythontestsuite`
will plan an extra Python test for each marked module.

Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agopython: wscript_build: Prepare build environment for Python 3 porting
Lumir Balhar [Wed, 19 Oct 2016 18:26:22 +0000 (20:26 +0200)]
python: wscript_build: Prepare build environment for Python 3 porting

Signed-off-by: Lumir Balhar <lbalhar@redhat.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agojoin.py: Attempt to allocate a RID Set during the join
Andrew Bartlett [Mon, 31 Oct 2016 03:48:33 +0000 (16:48 +1300)]
join.py: Attempt to allocate a RID Set during the join

If we are joining the RID Manager, then we should get a RID Set, but
otherwise we should accept failure with the right error code

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agoselftest: Ensure vampiredc has a full copy of localdc before we start
Andrew Bartlett [Wed, 30 Nov 2016 04:09:44 +0000 (17:09 +1300)]
selftest: Ensure vampiredc has a full copy of localdc before we start

Otherwise we may fail tests because we are still pulling in the full replica
from localdc during the tests.  This may block RID allocation in particular.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agoselftest: Rework child process cleanup
Andrew Bartlett [Wed, 30 Nov 2016 01:18:46 +0000 (14:18 +1300)]
selftest: Rework child process cleanup

We now:
 - call gdb_backtrace on the stuck pid to determine why it is stuck
 - cleanup faster as we catch the process exit
   (by not waiting until 1 second after the exit for waitpid() to return -1)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agoselftest/gdb_*: make use of 'mktemp'
Stefan Metzmacher [Wed, 23 Nov 2016 11:26:18 +0000 (12:26 +0100)]
selftest/gdb_*: make use of 'mktemp'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2 years agolibrpc: cab: Fix ndr_size_cab_file() to detect integer wrap.
Jeremy Allison [Wed, 30 Nov 2016 17:23:52 +0000 (09:23 -0800)]
librpc: cab: Fix ndr_size_cab_file() to detect integer wrap.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Dec  1 05:53:43 CET 2016 on sn-devel-144

2 years agolibrpc: cab: Integer wrap protection for ndr_count_cfdata().
Jeremy Allison [Wed, 30 Nov 2016 17:19:43 +0000 (09:19 -0800)]
librpc: cab: Integer wrap protection for ndr_count_cfdata().

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agosmbclient: fix string formatting in print command
Douglas Bagnall [Tue, 1 Nov 2016 01:18:38 +0000 (14:18 +1300)]
smbclient: fix string formatting in print command

At one time, the variables lname and rname were char arrays, but now they
are pointers. When they were arrays, sizeof(rname) was the length of the
array, but now it gives the size of the pointer which is not what we want.

In the case where the filename is -, rname was alloced as size 1, which
could never fit the name it wanted to have contain ("stdin-<pid>").

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agosmbd/service_stream: connection processing flag is not really bool
Douglas Bagnall [Wed, 30 Nov 2016 01:56:16 +0000 (14:56 +1300)]
smbd/service_stream: connection processing flag is not really bool

The warning is:

../source4/smbd/service_stream.c: In function ‘stream_io_handler’:
../source4/smbd/service_stream.c:94:18: warning: increment of a boolean expression [-Wbool-operation]
  conn->processing++;
                    ^~
../source4/smbd/service_stream.c:100:18: warning: decrement of a boolean expression [-Wbool-operation]
  conn->processing--;
                    ^~

while the code in question looks like:

conn->processing++;
if (flags & TEVENT_FD_WRITE) {
conn->ops->send_handler(conn, flags);
} else if (flags & TEVENT_FD_READ) {
conn->ops->recv_handler(conn, flags);
}
conn->processing--;

If this is never going to be nested, processing can be bool and the ++
and -- can be true/false assignments. But it seems possible that these
might be nested so it is better to go the other way.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Dec  1 00:28:05 CET 2016 on sn-devel-144

2 years agolib/registry/regf: better initialise nk_block
Douglas Bagnall [Wed, 30 Nov 2016 01:19:39 +0000 (14:19 +1300)]
lib/registry/regf: better initialise nk_block

We were initialising a uint32_t[5] block with memset(..., 5) when we
surely meant memset(..., 5 * sizeof(uint32_t)) or some equivalent.

Thanks go to gcc-7 and -Wmemset-elt-size. The warning looks like this:

../source4/lib/registry/regf.c: In function ‘reg_create_regf_file’:
../source4/lib/registry/regf.c:2095:2: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
  memset(nk.unk3, 0, 5);
    ^~~~~~

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agoldb: Fix an unused variable warning
Volker Lendecke [Mon, 21 Nov 2016 20:41:51 +0000 (21:41 +0100)]
ldb: Fix an unused variable warning

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agoldb: Fix typos
Volker Lendecke [Mon, 21 Nov 2016 20:40:21 +0000 (21:40 +0100)]
ldb: Fix typos

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agotdb: version 1.3.12 tdb-1.3.12
Stefan Metzmacher [Wed, 30 Nov 2016 15:05:28 +0000 (16:05 +0100)]
tdb: version 1.3.12

* Bug 12455 - tdb mutexes don't work on FreeBSD

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Nov 30 20:02:28 CET 2016 on sn-devel-144

2 years agoparam: fix lp_parameter_value_is_valid() for parametric options
Ralph Wuerthner [Mon, 28 Nov 2016 09:42:33 +0000 (10:42 +0100)]
param: fix lp_parameter_value_is_valid() for parametric options

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Nov 30 04:00:54 CET 2016 on sn-devel-144

2 years agotdb: Fix mutexes on FreeBSD
Volker Lendecke [Mon, 21 Nov 2016 20:00:01 +0000 (21:00 +0100)]
tdb: Fix mutexes on FreeBSD

susv4 on mmap has the following snippet:

> The state of synchronization objects such as mutexes, semaphores,
> barriers, and conditional variables placed in shared memory mapped
> with MAP_SHARED becomes undefined when the last region in any process
> containing the synchronization object is unmapped.

This means we can't keep the mutex mmap area unmapped at any point
in time.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12455

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 29 23:59:52 CET 2016 on sn-devel-144

2 years agotdb: Only mmap the mutex area if not already mmap'ed
Volker Lendecke [Mon, 21 Nov 2016 19:58:08 +0000 (20:58 +0100)]
tdb: Only mmap the mutex area if not already mmap'ed

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12455

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agotdb: NULL out tdb->mutexes in tdb_mutex_munmap
Volker Lendecke [Mon, 21 Nov 2016 19:56:55 +0000 (20:56 +0100)]
tdb: NULL out tdb->mutexes in tdb_mutex_munmap

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12455

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agoctdb-common: Drop CTDB's copy of sys_read() and sys_write()
Martin Schwenke [Tue, 29 Nov 2016 01:55:06 +0000 (12:55 +1100)]
ctdb-common: Drop CTDB's copy of sys_read() and sys_write()

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Tue Nov 29 11:22:40 CET 2016 on sn-devel-144

2 years agoctdb-lock-helper: Drop include of ctdb_private.h
Martin Schwenke [Tue, 29 Nov 2016 01:54:00 +0000 (12:54 +1100)]
ctdb-lock-helper: Drop include of ctdb_private.h

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agolib/util: Make sys_rw available to CTDB
Martin Schwenke [Tue, 29 Nov 2016 01:21:33 +0000 (12:21 +1100)]
lib/util: Make sys_rw available to CTDB

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agontlm_auth4: Remove it
Volker Lendecke [Tue, 22 Nov 2016 00:54:08 +0000 (01:54 +0100)]
ntlm_auth4: Remove it

This had install=False for rather exactly 4 years now. If someone wants to
start working on it again, we can always dig it up from the git history.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 29 02:18:37 CET 2016 on sn-devel-144

2 years agoctdb-daemon: Mark RecoverPDBBySeqNum tunable deprecated
Amitay Isaacs [Fri, 18 Nov 2016 04:09:26 +0000 (15:09 +1100)]
ctdb-daemon: Mark RecoverPDBBySeqNum tunable deprecated

Persistent databases are now always recovered by sequence number, so
there is no need for this tunable.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Nov 25 08:13:59 CET 2016 on sn-devel-144

2 years agoctdb-daemon: Remove unused code cmdline.[ch]
Amitay Isaacs [Fri, 18 Nov 2016 03:57:47 +0000 (14:57 +1100)]
ctdb-daemon: Remove unused code cmdline.[ch]

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Consolidate command line options to ctdbd
Amitay Isaacs [Fri, 18 Nov 2016 03:52:38 +0000 (14:52 +1100)]
ctdb-daemon: Consolidate command line options to ctdbd

This inserts the code from ctdb_cmdline_init() function directly in
main(), so common/cmdline.[ch] can be removed.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-tests: Remove unused test code
Amitay Isaacs [Fri, 18 Nov 2016 03:27:35 +0000 (14:27 +1100)]
ctdb-tests: Remove unused test code

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agos4-torture: Add LZX compressed cabinet test
Günther Deschner [Fri, 23 Sep 2016 15:19:59 +0000 (17:19 +0200)]
s4-torture: Add LZX compressed cabinet test

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov 25 00:17:02 CET 2016 on sn-devel-144

2 years agos4-torture: Add MSZIP compressed cabinet test
Günther Deschner [Fri, 23 Sep 2016 15:19:25 +0000 (17:19 +0200)]
s4-torture: Add MSZIP compressed cabinet test

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos4-torture: Add a validation test for uncompressed Cabinet files
Günther Deschner [Fri, 23 Sep 2016 15:20:30 +0000 (17:20 +0200)]
s4-torture: Add a validation test for uncompressed Cabinet files

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos4-torture: Introduce Cabinet ndr testsuite
Günther Deschner [Fri, 23 Sep 2016 15:18:12 +0000 (17:18 +0200)]
s4-torture: Introduce Cabinet ndr testsuite

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibrpc: Add ndr_cab_get_compression() for Cabinet compression evaluation
Günther Deschner [Mon, 19 Sep 2016 22:20:18 +0000 (00:20 +0200)]
librpc: Add ndr_cab_get_compression() for Cabinet compression evaluation

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibrpc: Add autogenerated file offset calculation for Cabinet files
Günther Deschner [Sat, 24 Sep 2016 00:51:20 +0000 (02:51 +0200)]
librpc: Add autogenerated file offset calculation for Cabinet files

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibrpc: Add autogenerated total cabinet size for Cabinet files
Günther Deschner [Tue, 20 Sep 2016 23:46:54 +0000 (01:46 +0200)]
librpc: Add autogenerated total cabinet size for Cabinet files

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibrpc: Add autogenerated checksum calculation for Cabinet files
Günther Deschner [Thu, 15 Sep 2016 22:15:30 +0000 (00:15 +0200)]
librpc: Add autogenerated checksum calculation for Cabinet files

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agolibrpc: Introduce cab.idl
Günther Deschner [Thu, 15 Sep 2016 11:36:35 +0000 (13:36 +0200)]
librpc: Introduce cab.idl

This allows processing of Windows Cabinet files (required for the MS-PAR
print protocol implementation)

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos3-rpcclient: Add AsyncCorePrinterDriverInstalled command
Günther Deschner [Tue, 22 Nov 2016 11:07:23 +0000 (12:07 +0100)]
s3-rpcclient: Add AsyncCorePrinterDriverInstalled command

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos3-rpcclient: Add rpcclient IRemoteWinspool commands
Günther Deschner [Tue, 15 Jan 2013 14:22:43 +0000 (15:22 +0100)]
s3-rpcclient: Add rpcclient IRemoteWinspool commands

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos3-rpc_cli: Support the use of the object_uuid in rpc_cli interfaces
Günther Deschner [Wed, 23 Jan 2013 09:34:12 +0000 (10:34 +0100)]
s3-rpc_cli: Support the use of the object_uuid in rpc_cli interfaces

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agoWHATSNEW: document new inherit owner option
Uri Simchoni [Wed, 10 Aug 2016 05:38:59 +0000 (08:38 +0300)]
WHATSNEW: document new inherit owner option

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Rowland Penny <rpenny@samba.org>
Autobuild-User(master): Uri Simchoni <uri@samba.org>
Autobuild-Date(master): Thu Nov 24 20:23:46 CET 2016 on sn-devel-144

2 years agoWHATSNEW: document kerberos encryption types
Uri Simchoni [Wed, 10 Aug 2016 05:38:30 +0000 (08:38 +0300)]
WHATSNEW: document kerberos encryption types

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Rowland Penny <rpenny@samba.org>
2 years agodocs: fix funny typo in smb.conf manpage wrt Samba's FSRVP server.
Günther Deschner [Thu, 24 Nov 2016 11:16:51 +0000 (12:16 +0100)]
docs: fix funny typo in smb.conf manpage wrt Samba's FSRVP server.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Nov 24 16:30:13 CET 2016 on sn-devel-144

2 years agoselftest: Fix timestamps on FreeBSD 11
Volker Lendecke [Wed, 23 Nov 2016 12:54:39 +0000 (13:54 +0100)]
selftest: Fix timestamps on FreeBSD 11

FreeBSD's date does not print the %, and \? does not catch that

Tested this manually:

$ echo 'time: 2016-11-23 12:52:19.123456Z'| sed 's/\..*NZ$/.000000Z/'
time: 2016-11-23 12:52:19.123456Z
$ echo 'time: 2016-11-23 12:52:19.%6NZ'| sed 's/\..*NZ$/.000000Z/'
time: 2016-11-23 12:52:19.000000Z
$ echo 'time: 2016-11-23 12:52:19.6NZ'| sed 's/\..*NZ$/.000000Z/'
time: 2016-11-23 12:52:19.000000Z
$ echo 'time: 2016-11-23 12:52:19.NZ'| sed 's/\..*NZ$/.000000Z/'
time: 2016-11-23 12:52:19.000000Z
$

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Nov 24 00:42:55 CET 2016 on sn-devel-144

2 years agos3/dump_core: Honour pipe symbol (|) in system-wide core_pattern under linux
Anoop C S [Wed, 16 Nov 2016 08:55:13 +0000 (08:55 +0000)]
s3/dump_core: Honour pipe symbol (|) in system-wide core_pattern under linux

From man core(5):

"Since  kernel  2.6.19, Linux supports an alternate syntax for the
/proc/sys/kernel/core_pattern file.  If the first character of this
file is a pipe symbol (|), then the remainder of the line is interpreted
as a user-space program to be executed."

Discarding this symbol would result in misleading logs for smbd/nmbd/winbindd.
For example even if core_pattern contains '|', smbd logs would suggest the
following:

...
dumping core in /var/log/samba/cores/smbd
...

and coredump may or may not get created at that location depending on which
helper binary is being used for handling coredumps.

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agoldb: version 1.1.28 ldb-1.1.28
Volker Lendecke [Sat, 12 Nov 2016 14:14:34 +0000 (14:14 +0000)]
ldb: version 1.1.28

* Fix the build with installed ldb-devel 1.1.27
  We depend on LDB_UNPACK_DATA_FLAG_NO_VALUES_ALLOC.

* Some build fixes.

* More performance improvements.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Nov 23 20:48:31 CET 2016 on sn-devel-144

2 years agopyldb: protect PyErr_LDB_ERROR_IS_ERR_RAISE() with do {} while(0)
Stefan Metzmacher [Tue, 8 Nov 2016 08:18:52 +0000 (09:18 +0100)]
pyldb: protect PyErr_LDB_ERROR_IS_ERR_RAISE() with do {} while(0)

This should avoid the following warning:

 CID 1394274:  Control flow issues  (DEADCODE)
 Execution cannot reach this statement: ";".

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2 years agos3-net: use SMB_SIGNING_DEFAULT in connect_to_service()
Günther Deschner [Fri, 18 Nov 2016 17:17:52 +0000 (18:17 +0100)]
s3-net: use SMB_SIGNING_DEFAULT in connect_to_service()

For non IPC$ connections we get NT_STATUS_REVISION_MISMATCH otherwise when using
the connection.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Nov 23 16:52:38 CET 2016 on sn-devel-144

2 years agoparam: validate value in lp_canonicalize_parameter_with_value()
Michael Adam [Wed, 23 Nov 2016 10:14:54 +0000 (11:14 +0100)]
param: validate value in lp_canonicalize_parameter_with_value()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agoparam: use early return in lp_canonicalize_parameter_with_value()
Michael Adam [Wed, 23 Nov 2016 10:12:42 +0000 (11:12 +0100)]
param: use early return in lp_canonicalize_parameter_with_value()

This reduces the indentation and streamlines the flow.
View with "git show -w" to see it's mostly indentation change.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agoparam: add lp_parameter_value_is_valid() function
Ralph Wuerthner [Mon, 21 Nov 2016 13:56:52 +0000 (14:56 +0100)]
param: add lp_parameter_value_is_valid() function

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2 years agonet conf: fix error message
Ralph Wuerthner [Tue, 22 Nov 2016 10:20:22 +0000 (11:20 +0100)]
net conf: fix error message

Signed-off-by: Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2 years agosamba_dnsupdate: Raise after the error count is incremented
Garming Sam [Mon, 25 Jul 2016 23:34:05 +0000 (11:34 +1200)]
samba_dnsupdate: Raise after the error count is incremented

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Tue Nov 22 05:59:40 CET 2016 on sn-devel-144

2 years agosamba_dnsupdate: cmd._run doesn't have Exceptions
Garming Sam [Tue, 26 Jul 2016 21:40:09 +0000 (09:40 +1200)]
samba_dnsupdate: cmd._run doesn't have Exceptions

It returns a return code of -1 instead.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agodoc: Add doxygen for functions in srv_keytab.c
Garming Sam [Thu, 15 Sep 2016 04:04:12 +0000 (16:04 +1200)]
doc: Add doxygen for functions in srv_keytab.c

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10882

2 years agos4-auth: Don't check for NULL saltPrincipal if it doesn't need it
Garming Sam [Wed, 7 Sep 2016 00:18:29 +0000 (12:18 +1200)]
s4-auth: Don't check for NULL saltPrincipal if it doesn't need it

This check causes 4.1 domains to be unable to change their DNS backend
correctly as they do not have the saltPrincipal value stored.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10882
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agoselftest: Ensure we catch errors from samba-tool domain tombstones expunge
Andrew Bartlett [Sun, 6 Nov 2016 22:58:04 +0000 (11:58 +1300)]
selftest: Ensure we catch errors from samba-tool domain tombstones expunge

The previous code would overwrite $? before the return, so always returned 0

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297

2 years agodbcheck: Correct message for orphaned backlinks
Andrew Bartlett [Sun, 6 Nov 2016 22:04:03 +0000 (11:04 +1300)]
dbcheck: Correct message for orphaned backlinks

The backlink name is in attrname, not in link_name

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297

2 years agodbcheck: Be more careful with link checks
Andrew Bartlett [Mon, 24 Oct 2016 21:10:34 +0000 (10:10 +1300)]
dbcheck: Be more careful with link checks

Here we are more careful when checking links, flagging errors only
when a non-deleted forward link appears incorrect.  In particular, we
trust the GUID more than we trust the name, as otherwise we can get
caught out if there is a swap of names, (the link should follow the
swap, staying on the same target GUID).

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297

2 years agoselftest: Add test for link and deleted link behaviour in dbcheck
Andrew Bartlett [Sun, 6 Nov 2016 22:39:53 +0000 (11:39 +1300)]
selftest: Add test for link and deleted link behaviour in dbcheck

The other dbcheck tests were getting over-complex, so we start a new test
here based on tombestone-expunge.sh, as we are looking at very similar
problems

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297

2 years agoupgradeprovision: Remove objectCategory from constructed attrs
Garming Sam [Mon, 21 Nov 2016 02:06:22 +0000 (15:06 +1300)]
upgradeprovision: Remove objectCategory from constructed attrs

The new dbcheck rules identify an error where the GUID of the
objectCategory does not exist (pointing to a non-existent schema
object). As objectClass was not copied over either, it makes sense not
to copy over the objectCategory.

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12297

2 years agopython/provision: Remove unused parameter schema
Andrew Bartlett [Sun, 20 Nov 2016 23:31:24 +0000 (12:31 +1300)]
python/provision: Remove unused parameter schema

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Nov 21 18:49:12 CET 2016 on sn-devel-144

2 years agos4-torture: test valid environment in spoolss_EnumMonitors level 2.
Günther Deschner [Mon, 21 Nov 2016 11:44:54 +0000 (12:44 +0100)]
s4-torture: test valid environment in spoolss_EnumMonitors level 2.

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
2 years agos3-spoolss: use architecture in spoolss_MonitorInfo calls consistently
Günther Deschner [Mon, 21 Nov 2016 10:27:31 +0000 (11:27 +0100)]
s3-spoolss: use architecture in spoolss_MonitorInfo calls consistently

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
2 years agoctdb-recovery: Avoid NULL dereference in failure case
Amitay Isaacs [Fri, 18 Nov 2016 00:47:56 +0000 (11:47 +1100)]
ctdb-recovery: Avoid NULL dereference in failure case

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12434

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Nov 21 12:26:04 CET 2016 on sn-devel-144

2 years agovfs: ceph: convert to new DBG_* macros
Jeff Layton [Fri, 18 Nov 2016 12:31:21 +0000 (07:31 -0500)]
vfs: ceph: convert to new DBG_* macros

...per Jeremy's recommendation.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Nov 21 03:34:26 CET 2016 on sn-devel-144

2 years agoVFS: convert to using ceph_statx structures and functions, when available
Jeff Layton [Thu, 17 Nov 2016 18:13:57 +0000 (13:13 -0500)]
VFS: convert to using ceph_statx structures and functions, when available

Add a configure test for the ceph_statx function, and use that to
determine whether to compile in new functions that use it and its
variants, or whether to use a the older code that fetches birthtimes
from an xattr.

For cephwrap_lstat, we can use ceph_statx with the AT_SYMLINK_NOFOLLOW
flag to get the right lookup semantics.

For setting the times via cephwrap_ntimes, We can just use ceph_setattrx
and pass them all in at the same time.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos4:torture: Add tortue test for AddPrinterDriverEx with COPY_FROM_DIRECTORY
Andreas Schneider [Tue, 15 Nov 2016 17:34:22 +0000 (18:34 +0100)]
s4:torture: Add tortue test for AddPrinterDriverEx with COPY_FROM_DIRECTORY

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415

Pair-Programmed-With: Guenther Deschner <gd@samba.org>

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Nov 20 21:21:32 CET 2016 on sn-devel-144

2 years agolib:torture: Make variables const
Andreas Schneider [Fri, 18 Nov 2016 09:51:57 +0000 (10:51 +0100)]
lib:torture: Make variables const

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3:spoolss: Add some useful debug messages on error
Andreas Schneider [Tue, 15 Nov 2016 13:33:05 +0000 (14:33 +0100)]
s3:spoolss: Add some useful debug messages on error

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3:spoolss: Add support for COPY_FROM_DIRECTORY in AddPrinterDriverEx
Andreas Schneider [Tue, 15 Nov 2016 13:29:29 +0000 (14:29 +0100)]
s3:spoolss: Add support for COPY_FROM_DIRECTORY in AddPrinterDriverEx

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12415

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agontlm_auth: Avoid some statics
Volker Lendecke [Wed, 16 Nov 2016 15:22:46 +0000 (15:22 +0000)]
ntlm_auth: Avoid some statics

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agolib: Remove global xfile.h includes
Volker Lendecke [Wed, 16 Nov 2016 17:17:25 +0000 (17:17 +0000)]
lib: Remove global xfile.h includes

This makes it more obvious where this legacy code is used

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sun Nov 20 06:23:19 CET 2016 on sn-devel-144

2 years agolib: Move x_fgets_slash to xfile.c
Volker Lendecke [Wed, 16 Nov 2016 16:54:38 +0000 (16:54 +0000)]
lib: Move x_fgets_slash to xfile.c

This makes it easier to remove the global #include xfile.h

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agolib: Apply an overflow check
Volker Lendecke [Wed, 16 Nov 2016 15:53:45 +0000 (15:53 +0000)]
lib: Apply an overflow check

Very unlikely here, as the realloc will have failed long before, but
still I would like to check overflow.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agolib: Reformat x_fgets_slash
Volker Lendecke [Wed, 16 Nov 2016 15:47:08 +0000 (15:47 +0000)]
lib: Reformat x_fgets_slash

This is so old code that I'd like to move somewhere else next, but before
that I'd like to clean it up a bit.

No code change, just indentation changed and some {} added.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agolib: Rename fgets_slash to x_fgets_slash
Volker Lendecke [Wed, 16 Nov 2016 15:39:21 +0000 (15:39 +0000)]
lib: Rename fgets_slash to x_fgets_slash

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3:spoolss: Improve debug messages in construct_printer_driver
Andreas Schneider [Wed, 16 Nov 2016 14:31:16 +0000 (15:31 +0100)]
s3:spoolss: Improve debug messages in construct_printer_driver

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3:spoolss: Return error when there is no driver assigned
Andreas Schneider [Wed, 16 Nov 2016 14:29:34 +0000 (15:29 +0100)]
s3:spoolss: Return error when there is no driver assigned

If you create a new printer in Samba, there is no driver assinged.
Detect that early and return the right error code.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos4-torture: add test to compare PRINTER_INFO_STRESS version and OSVersion
Günther Deschner [Fri, 18 Nov 2016 10:59:05 +0000 (11:59 +0100)]
s4-torture: add test to compare PRINTER_INFO_STRESS version and OSVersion

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3-spoolss: set the defaults for os_version defines globally.
Günther Deschner [Wed, 16 Nov 2016 18:24:37 +0000 (19:24 +0100)]
s3-spoolss: set the defaults for os_version defines globally.

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3-spoolss: also set new os_major,minor,build values in printer info 0
Günther Deschner [Wed, 16 Nov 2016 18:17:55 +0000 (19:17 +0100)]
s3-spoolss: also set new os_major,minor,build values in printer info 0

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3:spoolss: Set default OS Version to Windows Server 2003 R2 SP2
Andreas Schneider [Wed, 9 Nov 2016 12:17:27 +0000 (13:17 +0100)]
s3:spoolss: Set default OS Version to Windows Server 2003 R2 SP2

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12416

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3/smbd: fix the last resort check that sets the file type attribute
Jeremy Allison [Fri, 18 Nov 2016 18:20:41 +0000 (10:20 -0800)]
s3/smbd: fix the last resort check that sets the file type attribute

The rule is, a directory (with any other attributes) should always also
set FILE_ATTRIBUTE_DIRECTORY, a file should only set
FILE_ATTRIBUTE_NORMAL if no other attributes is set.

Iow, if a file contains any existing attributes (e.g. FILE_ATTRIBUTE_HIDDEN),
don't add in the FILE_ATTRIBUTE_NORMAL attribute.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12436

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Sat Nov 19 11:55:35 CET 2016 on sn-devel-144

2 years agoctdb-locking: Reset real-time priority in lock helper
Amitay Isaacs [Thu, 17 Nov 2016 05:10:51 +0000 (16:10 +1100)]
ctdb-locking: Reset real-time priority in lock helper

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12392

Earlier we were relying on SCHED_RESET_ON_FORK to reset the priority of lock
helper processes.  Since SCHED_RESET_ON_FORK support has been removed, the
scheduling priority of child processes created using vfork() need to be reset
explicitly in the helper processes.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Fri Nov 18 10:18:27 CET 2016 on sn-devel-144

2 years agoUpdate .ycm_extra_conf.py
Andreas Schneider [Thu, 17 Nov 2016 17:19:05 +0000 (18:19 +0100)]
Update .ycm_extra_conf.py

As we did a lot of cleanup it is time to update .ycm_extra_conf.py and
set picky developer flags by default.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov 18 02:22:10 CET 2016 on sn-devel-144

2 years agos4:torture: Fix cleanup of the secrets object in session_key test
Andreas Schneider [Thu, 17 Nov 2016 15:15:54 +0000 (16:15 +0100)]
s4:torture: Fix cleanup of the secrets object in session_key test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12433

The test is known to be failing if sealing is turned on in some
circumstances. In this case a secret is created and then the function
dcerpc_fetch_session_key() fails. The secret is not removed!

We use torturesecret-%08x with random() to fill in the number. Sometimes
it happens that random() returns a number we already used. So we end up
trying to create a secret for an entry which already exists and run
into a collision

This change makes sure we always cleanup behind us and do not leave
secret objects we created.

Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov 17 22:30:36 CET 2016 on sn-devel-144

2 years agos4:torture: Normalizes names in session_key test
Andreas Schneider [Thu, 17 Nov 2016 14:44:13 +0000 (15:44 +0100)]
s4:torture: Normalizes names in session_key test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12433

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos4:torture: Strip trailing whitespaces in session_key.c
Andreas Schneider [Thu, 17 Nov 2016 14:35:47 +0000 (15:35 +0100)]
s4:torture: Strip trailing whitespaces in session_key.c

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12433

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agolib: Avoid includes.h in access.c
Volker Lendecke [Wed, 16 Nov 2016 16:15:27 +0000 (16:15 +0000)]
lib: Avoid includes.h in access.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Nov 16 22:26:14 CET 2016 on sn-devel-144

2 years agolib: memcache.h needs some includes
Volker Lendecke [Wed, 16 Nov 2016 16:13:12 +0000 (16:13 +0000)]
lib: memcache.h needs some includes

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agosource4: Change to use lib/util/access functions.
Jeremy Allison [Fri, 11 Nov 2016 04:33:17 +0000 (20:33 -0800)]
source4: Change to use lib/util/access functions.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12419

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Nov 16 16:35:12 CET 2016 on sn-devel-144

2 years agolib: util: Add allow_access_nolog().
Jeremy Allison [Mon, 14 Nov 2016 19:48:32 +0000 (11:48 -0800)]
lib: util: Add allow_access_nolog().

Make allow_access() call allow_access_nolog(), then log.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12419

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>