samba.git
7 years agogensec: Fix a memory corruption in gensec_use_kerberos_mechs
Volker Lendecke [Thu, 9 Feb 2012 15:07:12 +0000 (16:07 +0100)]
gensec: Fix a memory corruption in gensec_use_kerberos_mechs

Without this I get the following valgrind error:

==27740== Invalid write of size 8
==27740==    at 0x62C53E: gensec_use_kerberos_mechs (gensec_start.c:112)
==27740==    by 0x62C623: gensec_security_mechs (gensec_start.c:141)
==27740==    by 0x62C777: gensec_security_by_oid (gensec_start.c:181)
==27740==    by 0x62DD6E: gensec_start_mech_by_oid (gensec_start.c:735)
==27740==    by 0x50D6FD: negprot_spnego (negprot.c:210)
==27740==    by 0x5B0DEA: smbd_smb2_request_process_negprot (smb2_negprot.c:209)
==27740==    by 0x5AD036: smbd_smb2_request_dispatch (smb2_server.c:1417)
==27740==    by 0x5AFB77: smbd_smb2_first_negprot (smb2_server.c:2643)
==27740==    by 0x585C00: process_smb (process.c:1641)
==27740==    by 0x587F78: smbd_server_connection_read_handler (process.c:2314)
==27740==    by 0x587FD6: smbd_server_connection_handler (process.c:2331)
==27740==    by 0x99E05B: run_events_poll (events.c:286)
==27740==    by 0x584AFF: smbd_server_connection_loop_once (process.c:984)
==27740==    by 0x58B2D9: smbd_process (process.c:3389)
==27740==    by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==    by 0x99E05B: run_events_poll (events.c:286)
==27740==    by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==    by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==    by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==    by 0xDE6DD8: main (server.c:1413)
==27740==  Address 0x9ff3538 is 4,232 bytes inside a block of size 8,288 alloc'd
==27740==    at 0x4C261D7: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==27740==    by 0x6926965: __talloc (talloc.c:560)
==27740==    by 0x6926771: talloc_pool (talloc.c:598)
==27740==    by 0x93B927: talloc_stackframe_internal (talloc_stack.c:145)
==27740==    by 0x93B9D6: talloc_stackframe_pool (talloc_stack.c:171)
==27740==    by 0x58B2B7: smbd_process (process.c:3385)
==27740==    by 0xDE4CA8: smbd_accept_connection (server.c:469)
==27740==    by 0x99E05B: run_events_poll (events.c:286)
==27740==    by 0x99E2D5: s3_event_loop_once (events.c:349)
==27740==    by 0x99F990: _tevent_loop_once (tevent.c:504)
==27740==    by 0xDE5A9B: smbd_parent_loop (server.c:869)
==27740==    by 0xDE6DD8: main (server.c:1413)

In the for-loop we can increment j twice, so we need twice as many output array
elements as input array elements.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Feb  9 19:44:47 CET 2012 on sn-devel-104

7 years agos3-printing: Add new printers to registry.
Björn Baumbach [Tue, 7 Feb 2012 10:41:54 +0000 (11:41 +0100)]
s3-printing: Add new printers to registry.

This fixes bug #8554, #8612 and #8748.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Feb  9 16:39:04 CET 2012 on sn-devel-104

7 years agos3-libsmb: Remove obsolete smb_krb5_locate_kdc.
Andreas Schneider [Wed, 30 Nov 2011 16:58:30 +0000 (17:58 +0100)]
s3-libsmb: Remove obsolete smb_krb5_locate_kdc.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Feb  9 14:58:57 CET 2012 on sn-devel-104

7 years agos3-net: Don't use an internal krb5 for kdc lookup.
Andreas Schneider [Wed, 30 Nov 2011 16:39:22 +0000 (17:39 +0100)]
s3-net: Don't use an internal krb5 for kdc lookup.

This replaces the use of the internal krb5_locate_kdc() function with
our own get_kdc_list() function.

Signed-off-by: Günther Deschner <gd@samba.org>
7 years agotevent: change the version to 0.9.15 tevent-0.9.15
Stefan Metzmacher [Thu, 9 Feb 2012 09:11:19 +0000 (10:11 +0100)]
tevent: change the version to 0.9.15

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb  9 12:24:19 CET 2012 on sn-devel-104

7 years agotevent: Fix deleting signal events from within themselves
Volker Lendecke [Sat, 28 Jan 2012 21:18:00 +0000 (22:18 +0100)]
tevent: Fix deleting signal events from within themselves

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agosmbwrapper: Remove smbwrapper
Andrew Bartlett [Fri, 3 Feb 2012 04:06:48 +0000 (15:06 +1100)]
smbwrapper: Remove smbwrapper

There are now many better ways to access a remote SMB filesystem,
which do not rely on LD_PRELOAD and the associated dangers.  FUSE,
gvfs and the CIFS VFS are all much better options which do not require
knowing every possible libc entry point that can deal with a file
descriptor.

As an example of the maintainence that would be required to keep this
going, recent changes to deal with thread races and close-on-exec have
resulted in dup3(), but this isn't currently mapped.  While this would
not be hard to add, it illistrates why it is better to move to an
interface designed for this task.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Feb  9 01:58:24 CET 2012 on sn-devel-104

7 years agos3-build: remove EXEEXT from Makefiles
Andrew Bartlett [Wed, 25 Jan 2012 22:23:23 +0000 (09:23 +1100)]
s3-build: remove EXEEXT from Makefiles

As far as I am aware, we do not actually build on any platforms that
require this.  The last Stratos VOS release on
ftp://ftp.stratus.com/vos/samba/samba.html was 3.0.5

Andrew Bartlett

7 years agos4:join python code - perform a fallback password set operation over libnet
Matthias Dieter Wallnöfer [Mon, 14 Nov 2011 16:53:39 +0000 (17:53 +0100)]
s4:join python code - perform a fallback password set operation over libnet

Windows 2000 DCs allow LDAP password set operations only with the help of SSL.
Given the fact that this technique is hard to setup it is easier to use SAMR
over "libnet".

Reviewed-By: Andrew Bartlett <abartlet@samba.org>
7 years agos4:join python code - write the SAM account name correctly
Matthias Dieter Wallnöfer [Sun, 8 Jan 2012 15:41:54 +0000 (16:41 +0100)]
s4:join python code - write the SAM account name correctly

It is easier for the comprehension

Reviewed-By: Andrew Bartlett <abartlet@samba.org>
7 years agoFix shadow variable name warning.
Jeremy Allison [Wed, 8 Feb 2012 20:15:04 +0000 (12:15 -0800)]
Fix shadow variable name warning.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Feb  8 22:55:08 CET 2012 on sn-devel-104

7 years agoregshell: Fix a counter that can actually be non-zero.
Jelmer Vernooij [Wed, 8 Feb 2012 13:17:17 +0000 (14:17 +0100)]
regshell: Fix a counter that can actually be non-zero.

This was a regression caused by one of the unsigned patches.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Feb  8 16:00:22 CET 2012 on sn-devel-104

7 years agos3-passdb: Remove #if _SAMBA_BUILD_ == 4 from pdb_samba4
Andrew Bartlett [Wed, 8 Feb 2012 06:41:54 +0000 (17:41 +1100)]
s3-passdb: Remove #if _SAMBA_BUILD_ == 4 from pdb_samba4

pdb_samba4 is only built with waf anyway.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Feb  8 09:17:40 CET 2012 on sn-devel-104

7 years agos3-docs: Remove references to long-gone smbmount utilities
Andrew Bartlett [Fri, 3 Feb 2012 03:51:59 +0000 (14:51 +1100)]
s3-docs: Remove references to long-gone smbmount utilities

7 years agoauth: rename ntlmssp.c to ntlmssp_util.c
Andrew Bartlett [Mon, 30 Jan 2012 21:54:22 +0000 (08:54 +1100)]
auth: rename ntlmssp.c to ntlmssp_util.c

7 years agos3-auth Add const to make_user_info_map
Andrew Bartlett [Mon, 30 Jan 2012 11:44:28 +0000 (22:44 +1100)]
s3-auth Add const to make_user_info_map

7 years agos4-messaging: fix pymessaging docstring
Andrew Bartlett [Mon, 6 Feb 2012 06:44:34 +0000 (17:44 +1100)]
s4-messaging: fix pymessaging docstring

7 years agos3-build use common VERSION file for all builds
Andrew Bartlett [Mon, 4 Jul 2011 00:14:27 +0000 (10:14 +1000)]
s3-build use common VERSION file for all builds

There is no need to have both version files at this point.

Andrew Bartlett

7 years agopidl: add more mapped types
Andrew Tridgell [Wed, 8 Feb 2012 02:01:32 +0000 (13:01 +1100)]
pidl: add more mapped types

when we #define one type to another, we need special handling in the
python generator

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Feb  8 04:50:06 CET 2012 on sn-devel-104

7 years agoidl: wmi and dcom don't need python bindings
Andrew Tridgell [Wed, 8 Feb 2012 02:00:29 +0000 (13:00 +1100)]
idl: wmi and dcom don't need python bindings

the python generation for these IDL files is currently broken

7 years agosamba-tool sites: Re-add support for option groups
Amitay Isaacs [Tue, 7 Feb 2012 06:30:22 +0000 (17:30 +1100)]
samba-tool sites: Re-add support for option groups

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Feb  8 02:27:28 CET 2012 on sn-devel-104

7 years agosamba-tool dns: Re-add support for option groups
Amitay Isaacs [Tue, 7 Feb 2012 06:27:18 +0000 (17:27 +1100)]
samba-tool dns: Re-add support for option groups

7 years agoRemove unused get_file_size() function.
Jeremy Allison [Tue, 7 Feb 2012 18:20:36 +0000 (10:20 -0800)]
Remove unused get_file_size() function.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Feb  7 20:56:28 CET 2012 on sn-devel-104

7 years agos3: Increase debug level of basic ctdb packet handling
Volker Lendecke [Tue, 7 Feb 2012 15:41:25 +0000 (16:41 +0100)]
s3: Increase debug level of basic ctdb packet handling

This clutters the debug level 10 output significantly without much
value

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Tue Feb  7 18:19:08 CET 2012 on sn-devel-104

7 years agos3-waf: Link tdbsam against needed libraries.
Andreas Schneider [Tue, 7 Feb 2012 10:11:15 +0000 (11:11 +0100)]
s3-waf: Link tdbsam against needed libraries.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue Feb  7 12:49:59 CET 2012 on sn-devel-104

7 years agos3-waf: Link against tdb_compat instead of tdb.
Andreas Schneider [Mon, 6 Feb 2012 11:47:16 +0000 (12:47 +0100)]
s3-waf: Link against tdb_compat instead of tdb.

7 years agoprovision: Make sure target directory is created early.
Jelmer Vernooij [Tue, 7 Feb 2012 00:09:41 +0000 (01:09 +0100)]
provision: Make sure target directory is created early.

This is necessary when using the target directory to store temporary
files.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Feb  7 02:45:37 CET 2012 on sn-devel-104

7 years agosamba-tool user password: Re-add support for option groups.
Jelmer Vernooij [Mon, 6 Feb 2012 22:26:36 +0000 (23:26 +0100)]
samba-tool user password: Re-add support for option groups.

7 years agosamba-tool: Add optiongroups, necessary for 'samba-tool domain ...'
Jelmer Vernooij [Mon, 6 Feb 2012 21:06:09 +0000 (22:06 +0100)]
samba-tool: Add optiongroups, necessary for 'samba-tool domain ...'

7 years agocrypto: Use libbsd md5 header, if available.
Jelmer Vernooij [Mon, 6 Feb 2012 16:47:25 +0000 (17:47 +0100)]
crypto: Use libbsd md5 header, if available.

7 years agocrypto/md5: Change prototypes to match BSD.
Jelmer Vernooij [Mon, 6 Feb 2012 15:53:52 +0000 (16:53 +0100)]
crypto/md5: Change prototypes to match BSD.

7 years agoRevert "samba-tool: moved takes_optiongroups definition to Command base class"
Jelmer Vernooij [Mon, 6 Feb 2012 15:33:38 +0000 (16:33 +0100)]
Revert "samba-tool: moved takes_optiongroups definition to Command base class"

This reverts commit f6fa8684896b8f3f9f8b7bd3742c99906973274c.

This keeps the main command class fairly slim, and makes it a bit
more obvious where the arguments to run() are coming from.

Conflicts:

source4/scripting/python/samba/netcmd/__init__.py
source4/scripting/python/samba/netcmd/domain.py
source4/scripting/python/samba/netcmd/gpo.py
source4/scripting/python/samba/netcmd/newuser.py
source4/scripting/python/samba/netcmd/testparm.py
source4/scripting/python/samba/netcmd/user.py
source4/scripting/python/samba/tests/samba_tool/__init__.py

7 years agocharset/tests: Add prototypes for test functions.
Jelmer Vernooij [Mon, 6 Feb 2012 11:20:54 +0000 (12:20 +0100)]
charset/tests: Add prototypes for test functions.

7 years agosmb_server: Preserve signedness of string push return value.
Jelmer Vernooij [Sun, 5 Feb 2012 19:18:59 +0000 (20:18 +0100)]
smb_server: Preserve signedness of string push return value.

7 years agoloadparm: handle P_SEP in switches (silences warning with clang).
Jelmer Vernooij [Sun, 5 Feb 2012 19:12:23 +0000 (20:12 +0100)]
loadparm: handle P_SEP in switches (silences warning with clang).

7 years agopysocketwrapper: fix behaviour to be consistent with 'socket.getsockopt'
Jelmer Vernooij [Sun, 5 Feb 2012 15:42:41 +0000 (16:42 +0100)]
pysocketwrapper: fix behaviour to be consistent with 'socket.getsockopt'

socklen_t is unsigned

7 years agotorture/libnet: Include prototype headers.
Jelmer Vernooij [Sun, 5 Feb 2012 14:35:12 +0000 (15:35 +0100)]
torture/libnet: Include prototype headers.

7 years agopyxattr_tdb: Remove pointless check for blob.length < 0.
Jelmer Vernooij [Sun, 5 Feb 2012 14:31:31 +0000 (15:31 +0100)]
pyxattr_tdb: Remove pointless check for blob.length < 0.

7 years agocrypto: Add prototype for main torture functions.
Jelmer Vernooij [Sun, 5 Feb 2012 14:31:05 +0000 (15:31 +0100)]
crypto: Add prototype for main torture functions.

7 years agoUse named argument 'dir' instead of 'prefix' on NamedTemporaryFile for domain.py
Horacio G. de Oro [Fri, 3 Feb 2012 01:52:28 +0000 (22:52 -0300)]
Use named argument 'dir' instead of 'prefix' on NamedTemporaryFile for domain.py

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
7 years agoUse named argument 'dir' instead of 'prefix' on NamedTemporaryFile for source4/setup...
Horacio G. de Oro [Fri, 3 Feb 2012 01:48:26 +0000 (22:48 -0300)]
Use named argument 'dir' instead of 'prefix' on NamedTemporaryFile for source4/setup/provision

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
7 years agos3-winbind: Remove unused bool "local"
Christof Schmitt [Mon, 6 Feb 2012 18:18:29 +0000 (11:18 -0700)]
s3-winbind: Remove unused bool "local"

"local" is always False, so simply remove it and the if statement
checking its value.

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Feb  6 23:27:48 CET 2012 on sn-devel-104

7 years agos3: FreeBSD does not define sin6_addr.s_addr32
Volker Lendecke [Mon, 6 Feb 2012 15:53:22 +0000 (16:53 +0100)]
s3: FreeBSD does not define sin6_addr.s_addr32

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Feb  6 20:03:58 CET 2012 on sn-devel-104

7 years agos3-nsswitch: Fix warnings on Solaris.
Ira Cooper [Sun, 5 Feb 2012 14:47:16 +0000 (09:47 -0500)]
s3-nsswitch: Fix warnings on Solaris.

Add "system/passwd.h" so struct group is declared.

Autobuild-User: Ira Cooper <ira@samba.org>
Autobuild-Date: Mon Feb  6 18:28:53 CET 2012 on sn-devel-104

7 years agolib/util: Add hex_encode_buf
Volker Lendecke [Fri, 3 Feb 2012 02:27:19 +0000 (03:27 +0100)]
lib/util: Add hex_encode_buf

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Feb  6 09:15:33 CET 2012 on sn-devel-104

7 years agos3-popt: Fix configure.developer builds on Solairs.
Ira Cooper [Sat, 4 Feb 2012 00:47:18 +0000 (16:47 -0800)]
s3-popt: Fix configure.developer builds on Solairs.

alloca.h needs to be included, or the build complains the implicit
definition of alloca.

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb  4 03:27:42 CET 2012 on sn-devel-104

7 years agoEnsure when setting a POSIX ACL, that the uid for a
Jeremy Allison [Sat, 4 Feb 2012 00:37:41 +0000 (16:37 -0800)]
Ensure when setting a POSIX ACL, that the uid for a
SMB_ACL_USER_OBJ ACE (the owner ACE entry) has a duplicate
permission entry as an SMB_ACL_USER, and a gid for a
SMB_ACL_GROUP_OBJ ACE (the primary group ACE entry) also has
a duplicate permission entry as an SMB_ACL_GROUP. If not,
then if the ownership or group ownership of this file or
directory gets changed, the user or group can lose their
access.

7 years agoFix mistaken assignment of gid to uid field.
Jeremy Allison [Fri, 3 Feb 2012 23:58:12 +0000 (15:58 -0800)]
Fix mistaken assignment of gid to uid field.

7 years agoReplace bool flags inside ensure_canon_entry_valid() with pointers.
Jeremy Allison [Fri, 3 Feb 2012 23:28:22 +0000 (15:28 -0800)]
Replace bool flags inside ensure_canon_entry_valid() with pointers.
This will make the second tweak to the ACL mapping on set easier.

7 years agoFix bug #7933 - samba fails to honor SEC_STD_WRITE_OWNER bit with the acl_xattr module.
Jeremy Allison [Fri, 3 Feb 2012 22:55:34 +0000 (14:55 -0800)]
Fix bug #7933 - samba fails to honor SEC_STD_WRITE_OWNER bit with the acl_xattr module.

7 years agoReplace all malloc/free with talloc on tos.
Jeremy Allison [Fri, 3 Feb 2012 22:06:38 +0000 (14:06 -0800)]
Replace all malloc/free with talloc on tos.

7 years agos4:torture: add a smb2.durable_open.reopen4 test
Michael Adam [Mon, 30 Jan 2012 11:08:38 +0000 (12:08 +0100)]
s4:torture: add a smb2.durable_open.reopen4 test

open a durable handle, logoff, new sessions setup, try durable reopen (fail),
open tcon, durable reopen (succeed)

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Feb  3 12:45:34 CET 2012 on sn-devel-104

7 years agos4:torture: add a torture_smb2_session_setup() utility function
Michael Adam [Mon, 30 Jan 2012 11:07:07 +0000 (12:07 +0100)]
s4:torture: add a torture_smb2_session_setup() utility function

7 years agos4:torture: add smb2.durable_open test reopen3
Michael Adam [Fri, 27 Jan 2012 16:21:25 +0000 (17:21 +0100)]
s4:torture: add smb2.durable_open test reopen3

Do a durable open, tdis, tree_connect, durable reopen -> fail

7 years agos4:torture: add torture_smb2_tree_connect() utility function
Michael Adam [Fri, 27 Jan 2012 16:20:23 +0000 (17:20 +0100)]
s4:torture: add torture_smb2_tree_connect() utility function

This does a tcon based on an existing session, using the
name an host present in the torture context.

7 years agos4:torture: add smb2.durable_open test reopen2
Michael Adam [Fri, 27 Jan 2012 12:06:09 +0000 (13:06 +0100)]
s4:torture: add smb2.durable_open test reopen2

durable open, disconnect, new seession, durable reopen

7 years agos4:torture: add smb2.durable_open test reopen1
Michael Adam [Fri, 27 Jan 2012 12:03:08 +0000 (13:03 +0100)]
s4:torture: add smb2.durable_open test reopen1

7 years agos4:libcli:smb2: don't allocate the smb2_tree struct earlier than necessary in smb2_co...
Michael Adam [Thu, 2 Feb 2012 12:41:40 +0000 (13:41 +0100)]
s4:libcli:smb2: don't allocate the smb2_tree struct earlier than necessary in smb2_connect()

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

7 years agos4:libcli/torture:smb2: change smb2_tree_connect to take a smb2_session instead of...
Michael Adam [Thu, 2 Feb 2012 12:39:56 +0000 (13:39 +0100)]
s4:libcli/torture:smb2: change smb2_tree_connect to take a smb2_session instead of smb2_tree arguement.

Only the tree->session is needed. This way it is less confusing.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

7 years agos4:torture:smb2: talloc_free the right tree structure in secondary_tcon()
Michael Adam [Thu, 2 Feb 2012 12:38:08 +0000 (13:38 +0100)]
s4:torture:smb2: talloc_free the right tree structure in secondary_tcon()

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

7 years agos4:torture:smb2: check for success of talloc in secondary_tcon()
Michael Adam [Thu, 2 Feb 2012 12:36:20 +0000 (13:36 +0100)]
s4:torture:smb2: check for success of talloc in secondary_tcon()

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

7 years agos4:torture:smb2:notify: remove an unused variable
Michael Adam [Thu, 2 Feb 2012 14:56:48 +0000 (15:56 +0100)]
s4:torture:smb2:notify: remove an unused variable

7 years agos4:torture:smb2:notify: remove an unused variable
Michael Adam [Thu, 2 Feb 2012 14:53:26 +0000 (15:53 +0100)]
s4:torture:smb2:notify: remove an unused variable

7 years agos4:torture:smb2: remove an unused variable from torture_smb2_setinfo()
Michael Adam [Thu, 2 Feb 2012 14:42:16 +0000 (15:42 +0100)]
s4:torture:smb2: remove an unused variable from torture_smb2_setinfo()

7 years agoloadparm: fix a load of uninitialized memory errors found by valgrind.
Michael Adam [Thu, 2 Feb 2012 23:21:50 +0000 (00:21 +0100)]
loadparm: fix a load of uninitialized memory errors found by valgrind.

7 years agos3-nmbd: don't discard DGRAM frames from local addresses when we are a DC
Matthieu Patou [Sat, 28 Jan 2012 00:12:52 +0000 (16:12 -0800)]
s3-nmbd: don't discard DGRAM frames from local addresses when we are a DC

Winbind use netbios to locate the DC, if samba is also a DC then nmbd
receive request from Winbind that are from a local address, those
requests must not be discarded otherwise winbind can't find the DC and
won't try another method.

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Fri Feb  3 11:09:29 CET 2012 on sn-devel-104

7 years agos3-pid: Catch with pid filename's change when config file is not smb.conf
Matthieu Patou [Wed, 25 Jan 2012 05:29:11 +0000 (21:29 -0800)]
s3-pid: Catch with pid filename's change when config file is not smb.conf

This is what is done in pidfile_create

7 years agoselftest: Fix the exit code of make test when run in buildfarm
Amitay Isaacs [Fri, 3 Feb 2012 01:04:32 +0000 (12:04 +1100)]
selftest: Fix the exit code of make test when run in buildfarm

When make test is run in buildfarm environment (RUN_FROM_BUILD_FARM=1),
last process in make test pipeline is subunit-filter. This subunit-filter
is responsible for converting failure test result to xfail for known
failures. While converting failures to xfail, it sets exitcode=1. If
this is the last process in the pipeline make test fails, which is
the observed behavior in buildfarm.

In autobuild, there is additional process in the pipeline format-subunit
which processes the output of subunit-filter and correctly terminates
with exit code=0. The buildfarm make test failure is fixed by adding
extra filter-subunit in the pipeline, as the extra filter-subunit
exits correctly with exit code=0.

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Fri Feb  3 07:00:04 CET 2012 on sn-devel-104

7 years agoOnly ask for specific permissions required when setting an ACL.
Jeremy Allison [Fri, 3 Feb 2012 00:28:39 +0000 (16:28 -0800)]
Only ask for specific permissions required when setting an ACL.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb  3 03:07:33 CET 2012 on sn-devel-104

7 years agoAllow a SACL to be sent in cli_set_secdesc().
Jeremy Allison [Fri, 3 Feb 2012 00:28:06 +0000 (16:28 -0800)]
Allow a SACL to be sent in cli_set_secdesc().

7 years agos3: Test for faulty xattr_tdb listxattr
Volker Lendecke [Thu, 2 Feb 2012 19:32:07 +0000 (20:32 +0100)]
s3: Test for faulty xattr_tdb listxattr

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Feb  2 22:10:49 CET 2012 on sn-devel-104

7 years agos3-xattr_tdb: Fix listxattr
Volker Lendecke [Thu, 2 Feb 2012 17:11:32 +0000 (18:11 +0100)]
s3-xattr_tdb: Fix listxattr

We have to tell the caller how many bytes we actually want

7 years agos3-vfstest: Add removexattr
Volker Lendecke [Thu, 2 Feb 2012 18:41:56 +0000 (19:41 +0100)]
s3-vfstest: Add removexattr

7 years agos3-vfstest: Add setxattr
Volker Lendecke [Thu, 2 Feb 2012 18:36:00 +0000 (19:36 +0100)]
s3-vfstest: Add setxattr

7 years agos3-vfstest: Add listxattr
Volker Lendecke [Thu, 2 Feb 2012 16:45:09 +0000 (17:45 +0100)]
s3-vfstest: Add listxattr

7 years agos3-vfstest: Add getxattr
Volker Lendecke [Thu, 2 Feb 2012 15:36:18 +0000 (16:36 +0100)]
s3-vfstest: Add getxattr

7 years agos3: Move stream_depot test to script/tests
Volker Lendecke [Thu, 2 Feb 2012 17:30:40 +0000 (18:30 +0100)]
s3: Move stream_depot test to script/tests

7 years agos3: Use ARRAY_SIZE in bsd_attr_list
Volker Lendecke [Thu, 2 Feb 2012 16:49:22 +0000 (17:49 +0100)]
s3: Use ARRAY_SIZE in bsd_attr_list

7 years agos3: Simplify streams_depot a bit
Volker Lendecke [Wed, 1 Feb 2012 19:40:06 +0000 (20:40 +0100)]
s3: Simplify streams_depot a bit

b0c0b949 is a bit involved. Passing down booleans is almost never
very clear

7 years agos3-vfstest: Fix an uninitialized read in close
Volker Lendecke [Thu, 2 Feb 2012 15:24:30 +0000 (16:24 +0100)]
s3-vfstest: Fix an uninitialized read in close

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Feb  2 18:00:58 CET 2012 on sn-devel-104

7 years agos3-vfstest: Fix a double-free on closing a file
Volker Lendecke [Thu, 2 Feb 2012 15:23:40 +0000 (16:23 +0100)]
s3-vfstest: Fix a double-free on closing a file

"mem_ctx" will be gone after we leave the routine

7 years agos3:auth: fill the sids array of the info3 in wbcAuthUserInfo_to_netr_SamInfo3() ...
Stefan Metzmacher [Wed, 1 Feb 2012 16:04:17 +0000 (17:04 +0100)]
s3:auth: fill the sids array of the info3 in wbcAuthUserInfo_to_netr_SamInfo3() (bug #8739)

Originally, only the rid array was filled and foreign domain sids were omitted.

Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Feb  2 12:59:32 CET 2012 on sn-devel-104

7 years agos3:auth: fix potential gap creation in wbcsids_to_samr_RidWithAttributeArray()
Stefan Metzmacher [Wed, 1 Feb 2012 16:02:52 +0000 (17:02 +0100)]
s3:auth: fix potential gap creation in wbcsids_to_samr_RidWithAttributeArray()

Pair-Programmed-With: Michael Adam <obnox@samba.org>

metze

7 years agos3-libsmb: Remove dead prototype.
Andreas Schneider [Thu, 2 Feb 2012 07:57:28 +0000 (08:57 +0100)]
s3-libsmb: Remove dead prototype.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Feb  2 10:33:13 CET 2012 on sn-devel-104

7 years agobuild: fixed a link order problem
Andrew Tridgell [Thu, 2 Feb 2012 01:36:44 +0000 (12:36 +1100)]
build: fixed a link order problem

this fixes a problem found by obnox where the -L path for CUPS was put
before the path to internal libraries. The install path for CUPS
happened to be the same as for a old system libtevent, which meant we
linked against the old tevent instead of the correct one from our
private library paths.

The problem was that we were adding the -L paths directly to the
ldflags. The waf core code (in ccroot.py) only adds more paths if they
are not there already. So by adding it in ldflags it was not added at
the end of the list. The fix is just to not do the -L processing in
wafsamba and let the waf core do it in the right order

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb  2 06:54:42 CET 2012 on sn-devel-104

7 years agoreplace: Only add bsd dependency when bsd library was found.
Jelmer Vernooij [Thu, 2 Feb 2012 01:48:35 +0000 (02:48 +0100)]
replace: Only add bsd dependency when bsd library was found.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Feb  2 05:18:45 CET 2012 on sn-devel-104

7 years agotdb2: add --disable-tdb2
Rusty Russell [Thu, 2 Feb 2012 01:06:49 +0000 (11:36 +1030)]
tdb2: add --disable-tdb2

I thought you could --disable-tdb2=false, apparently not!  Thanks
Michael Adam...

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Thu Feb  2 03:43:08 CET 2012 on sn-devel-104

7 years agosmbtorture: Do not leak child processes when exiting
Christof Schmitt [Thu, 15 Dec 2011 20:53:48 +0000 (13:53 -0700)]
smbtorture: Do not leak child processes when exiting

When some child processes could not be created, smbtorture would exit
and leave the successfully started child processes running.  Add a loop
to kill the existing child processes for this case.

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Feb  2 01:35:27 CET 2012 on sn-devel-104

7 years agos3-libsmb: Remove dead gssapi code.
Andreas Schneider [Wed, 1 Feb 2012 20:50:31 +0000 (21:50 +0100)]
s3-libsmb: Remove dead gssapi code.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Feb  1 23:29:44 CET 2012 on sn-devel-104

7 years agos3-lib: Fix util_cmdline which doesn't use popt.
Andreas Schneider [Mon, 30 Jan 2012 09:53:18 +0000 (10:53 +0100)]
s3-lib: Fix util_cmdline which doesn't use popt.

This creates its own header file for util_cmdline so it doesn't need to
link against popt.
This should fix linking on FreeBSD.

7 years agos3: Test for bug 8733
Volker Lendecke [Wed, 1 Feb 2012 19:07:24 +0000 (20:07 +0100)]
s3: Test for bug 8733

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Feb  1 21:53:50 CET 2012 on sn-devel-104

7 years agos3-vfstest: Correctly initialize the connection path
Volker Lendecke [Wed, 1 Feb 2012 18:44:32 +0000 (19:44 +0100)]
s3-vfstest: Correctly initialize the connection path

7 years agos3-vfstest: Fix some uninitialized vars
Volker Lendecke [Wed, 1 Feb 2012 18:43:46 +0000 (19:43 +0100)]
s3-vfstest: Fix some uninitialized vars

7 years agos3-vfstest: Fix some pointless statics
Volker Lendecke [Wed, 1 Feb 2012 18:42:55 +0000 (19:42 +0100)]
s3-vfstest: Fix some pointless statics

7 years agos3-vfstest: Fix a typo
Volker Lendecke [Wed, 1 Feb 2012 18:34:22 +0000 (19:34 +0100)]
s3-vfstest: Fix a typo

7 years agos3-vfstest: Fix some nonblank line endings
Volker Lendecke [Wed, 1 Feb 2012 13:42:39 +0000 (14:42 +0100)]
s3-vfstest: Fix some nonblank line endings

7 years agos3:smbd:smb2: fix an assignment-instead-of-check bug conn_snum_used()
Michael Adam [Wed, 1 Feb 2012 14:25:12 +0000 (14:25 +0000)]
s3:smbd:smb2: fix an assignment-instead-of-check bug conn_snum_used()

Accidential "=" instead of "==".

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Feb  1 17:10:15 CET 2012 on sn-devel-104

7 years agoRevert "s4-drs: do not try to contact for replication servers that are not anymore...
Andrew Tridgell [Wed, 1 Feb 2012 05:14:08 +0000 (16:14 +1100)]
Revert "s4-drs: do not try to contact for replication servers that are not anymore in reps*"

This reverts commit 5bfd6251eb22ff701184a95649822a73cf4d157b.

This change has been causing regular segfaults in the build farm since
it was applied. I also think it may be unnecessary as
dreplsrv_refresh_partitions() should already be achieving the same
thing (removing stale replication targets).

I think the segfaults were caused by freeing an in-flight DSA, but I
have been unable to reproduce it outside of the build farm

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Feb  1 07:49:42 CET 2012 on sn-devel-104

7 years agos4-heimdal: the ASN1 compiler now depends on libreplace
Andrew Tridgell [Wed, 1 Feb 2012 01:54:31 +0000 (12:54 +1100)]
s4-heimdal: the ASN1 compiler now depends on libreplace

it uses strlcat(), which we now get from libbsd if available

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Feb  1 05:51:56 CET 2012 on sn-devel-104

7 years agos3-auth Remove unused nt_status_squash from auth_context
Andrew Bartlett [Tue, 31 Jan 2012 10:34:19 +0000 (21:34 +1100)]
s3-auth Remove unused nt_status_squash from auth_context

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Feb  1 04:18:50 CET 2012 on sn-devel-104