13 years agor4672: added the "spnego" flag to the binding string docs
Andrew Tridgell [Tue, 11 Jan 2005 04:56:14 +0000 (04:56 +0000)]
r4672: added the "spnego" flag to the binding string docs
(This used to be commit 360aa583e7359a2e653d385a8d3c7977fd9614d1)

13 years agor4671: Expand the RPC-LSA test to set secret values twice.
Andrew Bartlett [Tue, 11 Jan 2005 03:49:29 +0000 (03:49 +0000)]
r4671: Expand the RPC-LSA test to set secret values twice.

Andrew Bartlett
(This used to be commit 357d9114f002a607f80985588bbac150fa40d2bc)

13 years agor4670: abartlet was worried about floating point precision with my first
Andrew Tridgell [Tue, 11 Jan 2005 03:26:26 +0000 (03:26 +0000)]
r4670: abartlet was worried about floating point precision with my first
version - here is one based purely on 64 bit math
(This used to be commit 1ff04b0dc3e680b6288622576bb373359a594c2f)

13 years agor4669: a timeval_to_nttime() function as requested by abartlet. Andrew, its
Andrew Tridgell [Tue, 11 Jan 2005 03:07:53 +0000 (03:07 +0000)]
r4669: a timeval_to_nttime() function as requested by abartlet. Andrew, its
your responsibility to use/test this :-)
(This used to be commit 2107b0cd7661a631952742bae241cb165b05c5f2)

13 years agor4667: Don't follow a NULL pointer for an idle event handler.
Andrew Bartlett [Tue, 11 Jan 2005 02:18:42 +0000 (02:18 +0000)]
r4667: Don't follow a NULL pointer for an idle event handler.

Fix up some header comments.

Andrew Bartlett
(This used to be commit 62005a3924e2af52c7173098b0b38eca14e03609)

13 years agor4664: SPNEGO auth in our rpc server now works, so add it to the battery of
Andrew Tridgell [Tue, 11 Jan 2005 01:57:44 +0000 (01:57 +0000)]
r4664: SPNEGO auth in our rpc server now works, so add it to the battery of
tests in
(This used to be commit 69ffbd4cedaddd71fad9bab2375dc634479c0ed6)

13 years agor4663: fixed SPNEGO auth in the rpc server
Andrew Tridgell [Tue, 11 Jan 2005 01:53:14 +0000 (01:53 +0000)]
r4663: fixed SPNEGO auth in the rpc server
(This used to be commit 439cbb9ead2443513ecc84f5638924e056ebdc73)

13 years agor4660: Test what we should return for a secret that does not exist.
Andrew Bartlett [Tue, 11 Jan 2005 01:36:26 +0000 (01:36 +0000)]
r4660: Test what we should return for a secret that does not exist.

Andrew Bartlett
(This used to be commit a17a8fbf9a843c2c9e10940878b43ad8e1583091)

13 years agor4659: Revert -r 4657 committed by mistake, until I review and test the
Andrew Bartlett [Mon, 10 Jan 2005 22:56:51 +0000 (22:56 +0000)]
r4659: Revert -r 4657 committed by mistake, until I review and test the
changes (which were to use the common ARCFOUR code for random number

Andrew Bartlett
(This used to be commit 50b3f64a8d555941499f41a7f43819474b81d4b8)

13 years agor4658: (grr, commited wrong file last time).
Andrew Bartlett [Mon, 10 Jan 2005 22:53:52 +0000 (22:53 +0000)]
r4658: (grr, commited wrong file last time).

We really should have a seperate structure for this (the ARCFOUR
sbox), but for now, get the declaration right.

Andrew Bartlett
(This used to be commit 2e16f3a8d31954fdfe4a8832637fcd9191ecab96)

13 years agor4657: This really should be made a structure, so we can't get it wrong, but
Andrew Bartlett [Mon, 10 Jan 2005 22:52:01 +0000 (22:52 +0000)]
r4657: This really should be made a structure, so we can't get it wrong, but
in the meantime, get the declaration right...

Andrew Bartlett
(This used to be commit 1c65db94f03457335133210bda488e2e21209f9a)

13 years agor4650: - make more use of bitmap and enum's
Stefan Metzmacher [Mon, 10 Jan 2005 17:28:36 +0000 (17:28 +0000)]
r4650: - make more use of bitmap and enum's
- move some structs out of misc.idl

(This used to be commit b6543a6e3057b5588ec50a2ebf6c7c932209efe6)

13 years agor4649: make more use of bitmap and enum's
Stefan Metzmacher [Mon, 10 Jan 2005 17:27:10 +0000 (17:27 +0000)]
r4649: make more use of bitmap and enum's

(This used to be commit fa798fe1f0c39dfee7d4c86a8cd5924be8a32922)

13 years agor4648: fix netr_ServerPasswordSet() bugs
Stefan Metzmacher [Mon, 10 Jan 2005 16:12:41 +0000 (16:12 +0000)]
r4648: fix netr_ServerPasswordSet() bugs

(This used to be commit 7feface9b77f2be4f592d04a6131348af761a8e8)

13 years agor4647: - use talloc_zero() instead of ZERO_STRUCTP()
Stefan Metzmacher [Mon, 10 Jan 2005 15:56:37 +0000 (15:56 +0000)]
r4647: - use talloc_zero() instead of ZERO_STRUCTP()

- fix uninitialized memory bug found by valgrind

(This used to be commit 1118a1b1bb09c9a369bb9600fbe8ad3523b7e36f)

13 years agor4644: allow DSSETUP on ncacn_ip_tcp
Andrew Tridgell [Mon, 10 Jan 2005 12:56:34 +0000 (12:56 +0000)]
r4644: allow DSSETUP on ncacn_ip_tcp
(This used to be commit 6f2019c307161953291f6bb5401eefaa7edc3857)

13 years agor4643: RPC-ALTERCONTEXT now passes
Andrew Tridgell [Mon, 10 Jan 2005 12:54:44 +0000 (12:54 +0000)]
r4643: RPC-ALTERCONTEXT now passes
(This used to be commit 153e068711623af94f9a53b20d114b254d42c2a3)

13 years agor4642: added support for alter_context in the server for adding new interfaces to...
Andrew Tridgell [Mon, 10 Jan 2005 12:39:42 +0000 (12:39 +0000)]
r4642: added support for alter_context in the server for adding new interfaces to an existing pipe
(This used to be commit b6af57c86829aadc261cd7b79091cef17c15b967)

13 years agor4641: Push a few more details into the schannel ldb, and into the
Andrew Bartlett [Mon, 10 Jan 2005 12:30:13 +0000 (12:30 +0000)]
r4641: Push a few more details into the schannel ldb, and into the
credentials struct it maintains.

Clearly much of this will be replaced with some system to pass and
store the session_info, as that is the 'right way' to handle this.

Andrew Bartlett
(This used to be commit c6fcb33a887fbf0c0b42c3bc331df942a985128c)

13 years agor4640: first stage in the server side support for multiple context_ids on one pipe
Andrew Tridgell [Mon, 10 Jan 2005 12:15:26 +0000 (12:15 +0000)]
r4640: first stage in the server side support for multiple context_ids on one pipe

this stage does the following:

 - simplifies the dcerpc_handle handling, and all the callers of it

 - split out the context_id depenent state into a linked list of established contexts

 - fixed some talloc handling in several rpc servers that i noticed while doing the above
(This used to be commit fde042b3fc609c94e2c7eedcdd72ecdf489cf63b)

13 years agor4639: initialize all struct members!
Stefan Metzmacher [Mon, 10 Jan 2005 12:14:26 +0000 (12:14 +0000)]
r4639: initialize all struct members!

tridge: sorry for making you such a pain...
        could you check if that fixes your bugs

(This used to be commit c215372eb0916df1e532b77c8365f401a8c32a38)

13 years agor4638: expose lsa and drsuapi on ncalrpc
Andrew Tridgell [Mon, 10 Jan 2005 12:12:44 +0000 (12:12 +0000)]
r4638: expose lsa and drsuapi on ncalrpc
(This used to be commit 4e62bd2a349c0cce8cb82a401fdf1cc33828af6f)

13 years agor4637: log packets when the server code returns an DCERPC_FAULT
Stefan Metzmacher [Mon, 10 Jan 2005 11:14:13 +0000 (11:14 +0000)]
r4637: log packets when the server code returns an DCERPC_FAULT

(This used to be commit 64805e5dc58ad1d1fefc3e36158131fa2d531592)

13 years agor4636: Per tridge's wish (and probably correct behaviour), don't key off a
Andrew Bartlett [Mon, 10 Jan 2005 11:09:31 +0000 (11:09 +0000)]
r4636: Per tridge's wish (and probably correct behaviour), don't key off a
specific GENSEC mech type, but on the behaviour of the mech.

Andrew Bartlett
(This used to be commit f2bd7a5a699b91d99d7dc2a0b3b6c7006274a59c)

13 years agor4635: Fix NTLMSSP to return NT_STATUS_OK when it has constructed the auth
Andrew Bartlett [Mon, 10 Jan 2005 10:48:19 +0000 (10:48 +0000)]
r4635: Fix NTLMSSP to return NT_STATUS_OK when it has constructed the auth
token in the client (the final token in the negotiation).

Consequential fixes in the SPNEGO code, which now uses the out.length
as the indicator of 'I need to send something to the other side'.

Merge the NTLM and SPNEGO DCE-RPC authentication routines in the client.

Fix the RPC-MULTIBIND test consequent to this merge.

Andrew Bartlett
(This used to be commit 43e3516fc03008e97ebb4ad1a0cde464303f43c6)

13 years agor4634: disable sign and seal in ldap_server for now.
Stefan Metzmacher [Mon, 10 Jan 2005 10:45:39 +0000 (10:45 +0000)]
r4634: disable sign and seal in ldap_server for now.

(This used to be commit 872c687184e5317b4477a184e0a954e6de0b8e9e)

13 years agor4632: added spnego testing and no-auth testing in
Andrew Tridgell [Mon, 10 Jan 2005 08:58:53 +0000 (08:58 +0000)]
r4632: added spnego testing and no-auth testing in
(This used to be commit 4f30220a5aafb2843e486be4a743e0fe9e9f462c)

13 years agor4631: don't consider an epmapper insert as a failure for the moment
Andrew Tridgell [Mon, 10 Jan 2005 08:57:54 +0000 (08:57 +0000)]
r4631: don't consider an epmapper insert as a failure for the moment
(This used to be commit ba6caa99a454cb3393c8898f1e5be4a432b820c4)

13 years agor4630: for ncacn_np if we don't have an explicit request for one of the
Andrew Tridgell [Mon, 10 Jan 2005 08:56:55 +0000 (08:56 +0000)]
r4630: for ncacn_np if we don't have an explicit request for one of the
advanced auth types we should do a plain bind. This fixes rpc
connections to ancient servers (like sun cascade)
(This used to be commit 59a5a0b218f7182c541a06ffc4528c1160699033)

13 years agor4629: we now have a global macro NT_STATUS_HAVE_NO_MEMORY()
Stefan Metzmacher [Mon, 10 Jan 2005 08:54:31 +0000 (08:54 +0000)]
r4629: we now have a global macro NT_STATUS_HAVE_NO_MEMORY()
so don't use a local one

(This used to be commit dd217f7916c885e1395f6f2a78e38e10f56e5f0f)

13 years agor4628: this function should be static
Stefan Metzmacher [Mon, 10 Jan 2005 08:30:44 +0000 (08:30 +0000)]
r4628: this function should be static

(This used to be commit 590afa88f15c32bc14b2c23e2c57b3401d9c3de7)

13 years agor4627: - simplified the dcerpc auth code using a common function
Andrew Tridgell [Mon, 10 Jan 2005 07:14:12 +0000 (07:14 +0000)]
r4627: - simplified the dcerpc auth code using a common function

- added support for "spnego" in binding strings. This enables SPNEGO
  auth in the dcerpc client code, using as many allter_context calls as
  are needed

To try SPNEGO do this:

  smbtorture ncacn_ip_tcp:SERVER[spnego,seal] -Uadministrator%password RPC-SAMR
(This used to be commit 9c0a3423f03111c110d21c0d3910e16aa1a8bf87)

13 years agor4626: Jelmer, can you look at why this init is failing? It is preventing all tools...
Andrew Tridgell [Mon, 10 Jan 2005 07:12:13 +0000 (07:12 +0000)]
r4626: Jelmer, can you look at why this init is failing? It is preventing all tools from working
(This used to be commit e59c5adf39c2c840a40a62485195167f80b9ef53)

13 years agor4625: added a test that demonstrates that once a context_id is established,
Andrew Tridgell [Mon, 10 Jan 2005 03:48:19 +0000 (03:48 +0000)]
r4625: added a test that demonstrates that once a context_id is established,
it can't be changed (so you have to create a new context_id, not
change the interface bound to an existing one)
(This used to be commit 5f10a8f8d04d627927d9870c87d6e7d8b98d563c)

13 years agor4624: Several crash fixes for DCOM
Jelmer Vernooij [Sun, 9 Jan 2005 21:35:37 +0000 (21:35 +0000)]
r4624: Several crash fixes for DCOM
More work on the example class implementation
(This used to be commit 1f8f4dd179d5aa0472c676d115dc2fc1749ce32d)

13 years agor4623: Convert values from UTF8 to UTF16 in gconf registry backend (caught
Jelmer Vernooij [Sun, 9 Jan 2005 19:06:49 +0000 (19:06 +0000)]
r4623: Convert values from UTF8 to UTF16 in gconf registry backend (caught
by Andrew Bartlett)
(This used to be commit da3c7712d234291f9c5a3c48daae02bdf0878bf0)

13 years agor4622: Clarify a comment a bit
Volker Lendecke [Sun, 9 Jan 2005 18:53:54 +0000 (18:53 +0000)]
r4622: Clarify a comment a bit
(This used to be commit e76d486b04ee114087a69a659fbc47e585e71510)

13 years agor4621: Add torture tests for epm_Insert and epm_Delete
Jelmer Vernooij [Sun, 9 Jan 2005 14:24:51 +0000 (14:24 +0000)]
r4621: Add torture tests for epm_Insert and epm_Delete
(This used to be commit b1ff60667038aa1e2d7c6ad2015ba33ac5a90dc6)

13 years agor4620: - add interface functions to the auth subsystem so that callers doesn't need to
Stefan Metzmacher [Sun, 9 Jan 2005 12:55:25 +0000 (12:55 +0000)]
r4620: - add interface functions to the auth subsystem so that callers doesn't need to
  use function pointers anymore
- make the module init much easier
- a lot of cleanups

don't try to read the diff in auth/ better read the new files

it passes and

abartlet: please fix spelling fixes

(This used to be commit 3c0d16b8236451f2cfd38fc3db8ae2906106d847)

13 years agor4619: Remove extern declaration of dcerpc_pipes, which is now static
Jelmer Vernooij [Sun, 9 Jan 2005 11:50:45 +0000 (11:50 +0000)]
r4619: Remove extern declaration of dcerpc_pipes, which is now static
(This used to be commit 95e849bf94160ae4807a54b28e351539c1119215)

13 years agor4618: - tidied up the alter_context client code a bit
Andrew Tridgell [Sun, 9 Jan 2005 11:32:12 +0000 (11:32 +0000)]
r4618: - tidied up the alter_context client code a bit

- there is no alter_nak or alter_ack packet, its all done in an

- auto-allocated the contex_ids

- tried to fix up the dcom code to work again with
  alter_context. Jelmer, please take a look :)
(This used to be commit dd1c54add8884376601f2f8a56c01bfb8add030c)

13 years agor4617: basic alter_context requests now work in our client library. The test
Andrew Tridgell [Sun, 9 Jan 2005 09:38:16 +0000 (09:38 +0000)]
r4617: basic alter_context requests now work in our client library. The test
just does a simple LSA/DSSETUP combo, which is what w2k does in the
ACL editor rpc calls that triggered this work
(This used to be commit 0129ec947aa1fa5a7104dc3a666af3cb9bd104f1)

13 years agor4616: the first phase in the addition of proper support for
Andrew Tridgell [Sun, 9 Jan 2005 08:34:05 +0000 (08:34 +0000)]
r4616: the first phase in the addition of proper support for
dcerpc_alter_context and multiple context_ids in the dcerpc client

This stage does the following:

 - split "struct dcerpc_pipe" into two parts, the main part being "struct dcerpc_connection", which
   contains all the parts not dependent on the context, and "struct dcerpc_pipe" which has
   the context dependent part. This is similar to the layering in libcli_*() for SMB

 - disable the current dcerpc_alter code. I've used a #warning until i
   get the 2nd phase finished. I don't know how portable #warning is, but
   it won't be long before I add full alter context support anyway, so it won't last long

 - cleanup the allocation of dcerpc_pipe structures. The previous code
   was quite awkward.
(This used to be commit 4004c69937be7e5dae56f9567ca607f982d395d3)

13 years agor4615: added acl checking on directory search in pvfs
Andrew Tridgell [Sun, 9 Jan 2005 08:27:35 +0000 (08:27 +0000)]
r4615: added acl checking on directory search in pvfs
(This used to be commit 0e61a422bd9a1596a284c176f033e958bbeaa8ce)

13 years agor4614: Fix RPC-SAMLOGON, to use the workstation context (forgot to globally replace).
Andrew Bartlett [Sun, 9 Jan 2005 07:39:31 +0000 (07:39 +0000)]
r4614: Fix RPC-SAMLOGON, to use the workstation context (forgot to globally replace).

Andrew Bartlett
(This used to be commit ddb54d4ea1610b38e011e2f217ded7b6278d5290)

13 years agor4613: Fix stuff I broke in the last commit with the /x regexp flag.
Tim Potter [Sun, 9 Jan 2005 05:31:59 +0000 (05:31 +0000)]
r4613: Fix stuff I broke in the last commit with the /x regexp flag.
(This used to be commit 20f9143221021ab050802d6aed359677bee978ed)

13 years agor4612: make the output for the w2k3 acl bug a bit clearer
Andrew Tridgell [Sun, 9 Jan 2005 04:31:32 +0000 (04:31 +0000)]
r4612: make the output for the w2k3 acl bug a bit clearer
(This used to be commit 24ec8c4274241576683f1f6c86c33a2dfa43848c)

13 years agor4611: - renamed add_socket() to smb_add_socket() as that is less confusing
Andrew Tridgell [Sun, 9 Jan 2005 04:18:14 +0000 (04:18 +0000)]
r4611: - renamed add_socket() to smb_add_socket() as that is less confusing

- removed the spurious call to set_blocking() in the smb server setup.
(This used to be commit 76d905d12e6f65a3670e4167ec79d8876b772ca6)

13 years agor4610: You can't join as a BDC and test against trusted domains. This test
Andrew Bartlett [Sun, 9 Jan 2005 03:04:45 +0000 (03:04 +0000)]
r4610: You can't join as a BDC and test against trusted domains.  This test
only needs WS privilages anyway.

Andrew Bartlett
(This used to be commit a093c4f98e833198ee59064b2cb9b9b45a188a59)

13 years agor4609: add a usefull data_blob_dup_talloc() macro
Stefan Metzmacher [Sun, 9 Jan 2005 02:37:24 +0000 (02:37 +0000)]
r4609: add a usefull data_blob_dup_talloc() macro

(This used to be commit 11e006df1689d4b4b202bca640106fd789495284)

13 years agor4608: - use better error codes
Stefan Metzmacher [Sun, 9 Jan 2005 02:33:16 +0000 (02:33 +0000)]
r4608: - use better error codes
- use new NT_STATUS_* macros for error checking return
- don't use talloc_p anymore

(This used to be commit 372a8eeeefc2ebff50211985372888b5b6d4eb65)

13 years agor4607: add some usefull macros to make the code more readable
Stefan Metzmacher [Sun, 9 Jan 2005 02:30:01 +0000 (02:30 +0000)]
r4607: add some usefull macros to make the code more readable

(This used to be commit 62c45635ff8a158acefd4ae2aae2ffc352a97113)

13 years agor4606: Start adding some more comments and some indentation for the eparser
Tim Potter [Sun, 9 Jan 2005 02:03:59 +0000 (02:03 +0000)]
r4606: Start adding some more comments and some indentation for the eparser
regexps.  Hopefully this will make things a bit easier to understand
later on.
(This used to be commit c325859eb6a0972638bbbb83ebb2dfda489ac8ee)

13 years agor4605: Fix a confusing comment :-)
Volker Lendecke [Sun, 9 Jan 2005 01:14:26 +0000 (01:14 +0000)]
r4605: Fix a confusing comment :-)
(This used to be commit fbd2a90bcdb7426c9a15bd8dc09da9008a0bc1bf)

13 years agor4603: Test creating local and global secrets over LSA.
Andrew Bartlett [Sat, 8 Jan 2005 02:00:28 +0000 (02:00 +0000)]
r4603: Test creating local and global secrets over LSA.

Andrew Bartlett
(This used to be commit 96806136ead3d1949516b2cfe7350a4e10681c28)

13 years agor4600: Remove Data::Dumper import leftover from debugging.
Tim Potter [Fri, 7 Jan 2005 23:23:28 +0000 (23:23 +0000)]
r4600: Remove Data::Dumper import leftover from debugging.

Return more ethereal types and bases for hf fields.  Currently we
assume that enums always fit into a uint16 which will probably  have to
change soon.
(This used to be commit 25f6e11f3156e21c1dc03afa879e9cda2f5dd341)

13 years agor4599: Remove some duplicated code in
Tim Potter [Fri, 7 Jan 2005 22:27:18 +0000 (22:27 +0000)]
r4599: Remove some duplicated code in

Start working on adding support for bitmaps and enums.

In progress tweaks for arrays of structures.
(This used to be commit d39cb7ecb4c193cbba628ee6d6f9b5c5bbf89d33)

13 years agor4597: Recently I've come across a case where I suspect the GetAnyDCName request to
Volker Lendecke [Fri, 7 Jan 2005 18:13:53 +0000 (18:13 +0000)]
r4597: Recently I've come across a case where I suspect the GetAnyDCName request to
kill the domain controller I'm asking. In samba4 torturing the DC is just so
easy, commit the test to randomized ask for DCs for all trusted domains.

(This used to be commit edb918762e1e46909520f13e28dcf8cedb2919b1)

13 years agor4596: added a dynamic inheritance ACLs test. As far as I can tell w2k3 does not do
Andrew Tridgell [Fri, 7 Jan 2005 06:59:53 +0000 (06:59 +0000)]
r4596: added a dynamic inheritance ACLs test. As far as I can tell w2k3 does not do
dynamic inheritance
(This used to be commit ebe6b002843196bc6d6fadfa646aa3bc8eb27af8)

13 years agor4595: on create check access against parent not child ...
Andrew Tridgell [Fri, 7 Jan 2005 05:24:38 +0000 (05:24 +0000)]
r4595: on create check access against parent not child ...
(This used to be commit 5a1a17d3fc771b1e1c61297067f38c87901891d3)

13 years agor4594: Add more testes to the standard 'passes against win2k3' script.
Andrew Bartlett [Fri, 7 Jan 2005 05:02:48 +0000 (05:02 +0000)]
r4594: Add more testes to the standard 'passes against win2k3' script.

Andrew Bartlett
(This used to be commit 07295b3b07984ec3d1de9ed27835dbda7b4b7d0f)

13 years agor4593: don't use the _p function in the testsuite, as when built standalone it doesn't
Andrew Tridgell [Fri, 7 Jan 2005 04:47:58 +0000 (04:47 +0000)]
r4593: don't use the _p function in the testsuite, as when built standalone it doesn't
(This used to be commit 2fe0e2528f14627832942f6404a4b1be4b556c97)

13 years agor4592: fixed typo from talloc testsuite fixup for the new syntax
Andrew Tridgell [Fri, 7 Jan 2005 04:45:11 +0000 (04:45 +0000)]
r4592: fixed typo from talloc testsuite fixup for the new syntax
(This used to be commit 1177200dd9392c088f5b009f55390ad31c367e5f)

13 years agor4591: - converted the other _p talloc functions to not need _p
Andrew Tridgell [Fri, 7 Jan 2005 04:39:16 +0000 (04:39 +0000)]
r4591: - converted the other _p talloc functions to not need _p

- added #if TALLOC_DEPRECATED around the _p functions

- fixes the code that broke from the above

while doing this I fixed quite a number of places that were
incorrectly using the non type-safe talloc functions to use the type
safe ones. Some were even doing multiplies for array allocation, which
is potentially unsafe.
(This used to be commit 6e7754abd0c225527fb38363996a6e241b87b37e)

13 years agor4590: Make RPC-SAMSYNC pass againt Win2k3.
Andrew Bartlett [Fri, 7 Jan 2005 04:09:45 +0000 (04:09 +0000)]
r4590: Make RPC-SAMSYNC pass againt Win2k3.

Andrew Bartlett
(This used to be commit 7bb00a80ac55252b8c05b33fd576b8606470e9be)

13 years agor4589: forgot to commit the new NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED error code
Andrew Tridgell [Fri, 7 Jan 2005 03:43:59 +0000 (03:43 +0000)]
r4589: forgot to commit the new NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED error code
(This used to be commit f4337c988c15dc84e3cfd77b628e92a0996717ea)

13 years agor4588: fixed the double bind in ncalrpc with dcerpc_secondary_connection()
Andrew Tridgell [Fri, 7 Jan 2005 03:38:36 +0000 (03:38 +0000)]
r4588: fixed the double bind in ncalrpc with dcerpc_secondary_connection()
(This used to be commit b65a95c11778fd778ad3c013664aea7d038e16ae)

13 years agor4587: fixed dcerpc_secondary_connection() for ncacn_ip_tcp
Andrew Tridgell [Fri, 7 Jan 2005 03:33:39 +0000 (03:33 +0000)]
r4587: fixed dcerpc_secondary_connection() for ncacn_ip_tcp

this fixes RPC-SAMLOGON and some other tests on ncacn_ip_tcp
(This used to be commit 244370d62424ab3c0f9d6689b0e674d057b3fc09)

13 years agor4586: RPC-LSA now passes against w2k3
Andrew Tridgell [Fri, 7 Jan 2005 03:12:30 +0000 (03:12 +0000)]
r4586: RPC-LSA now passes against w2k3
(This used to be commit e252f80f2bc5de4a3de84acf232f5334b5d448f6)

13 years agor4585: don't consider LookupSids3 failing with NT_STATUS_ACCESS_DENIED (as w2k3 does) or
Andrew Tridgell [Fri, 7 Jan 2005 03:11:18 +0000 (03:11 +0000)]
r4585: don't consider LookupSids3 failing with NT_STATUS_ACCESS_DENIED (as w2k3 does) or
NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED (as longhorn does) to be an error.

fixed the CreateTrustedDomain test to cope with the "torturedomain" being left over
from a previous aborted run
(This used to be commit 429d79815c260781fae6eed28160d7507e780f34)

13 years agor4584: fix pvfs backend to pass the new enhanced RAW-ACLS test. Easy once I really the
Andrew Tridgell [Fri, 7 Jan 2005 02:14:34 +0000 (02:14 +0000)]
r4584: fix pvfs backend to pass the new enhanced RAW-ACLS test. Easy once I really the
strange behaviour I saw was a w2k3 bug :-)
(This used to be commit e729061bcde25d0565a72222e4720ca8074ef23f)

13 years agor4583: print which bit failed in the owner bits check
Andrew Tridgell [Fri, 7 Jan 2005 02:13:07 +0000 (02:13 +0000)]
r4583: print which bit failed in the owner bits check
(This used to be commit f893ad9c45d6d06fa1b6f1f949a7834e7bf99ba7)

13 years agor4582: finally worked out what is going on with the inherited ACLs test and win2003...
Andrew Tridgell [Fri, 7 Jan 2005 01:56:19 +0000 (01:56 +0000)]
r4582: finally worked out what is going on with the inherited ACLs test and win2003. It is a
win2003 bug!

This new test code works against w2k, and against longhorn, but fails
against w2k3. When tested against w2k3 it allows a open with an access
mask that should be denied by the given ACL, after setting up the ACL
using inheritance. Note that only the very specific
SEC_RIGHTS_FILE_ALL mask incorrectly succeeds, so they must have a
special case for that mask. Maybe its an optimisation gone wrong?

I don't know if there are any serious security implications to this,
but it is pretty clearly wrong, and has been fixed in longhorn.
(This used to be commit 4f9fd767dbb5e47f3786f5acda17267d57e839e0)

13 years agor4578: Minor cleanup of ndr_pull_array() and ndr_pull_array_foo() regexps.
Tim Potter [Thu, 6 Jan 2005 23:08:30 +0000 (23:08 +0000)]
r4578: Minor cleanup of ndr_pull_array() and ndr_pull_array_foo() regexps.
(This used to be commit 0f8f0de00fa687920c898a56238cd3e21d83cfb1)

13 years agor4572: remove configure and include/config.h*
Stefan Metzmacher [Thu, 6 Jan 2005 17:21:57 +0000 (17:21 +0000)]
r4572: remove configure and include/config.h*
before running autoheader && autoconf

this fixes bug where configure didn't get correctly updated
(I assume autoconf uses some caching...)

(This used to be commit bfedcbc598706c47981d9ba0e19cae9ea3fab46b)

13 years agor4568: make use of SidType and move it to lsa.idl
Stefan Metzmacher [Thu, 6 Jan 2005 13:34:18 +0000 (13:34 +0000)]
r4568: make use of SidType and move it to lsa.idl

(This used to be commit c2523adc0a0807979fb21b8ba77d556bac82e435)

13 years agor4567: Fix the build for metze.
Andrew Bartlett [Thu, 6 Jan 2005 12:22:20 +0000 (12:22 +0000)]
r4567: Fix the build for metze.

Andrew Bartlett
(This used to be commit d05a9bf1a12c9f0b18c9e65b6aa03fa4283a1b68)

13 years agor4566: Fix Samba4 to pass it's own RPC-SAMLOGON torture test.
Andrew Bartlett [Thu, 6 Jan 2005 12:13:31 +0000 (12:13 +0000)]
r4566: Fix Samba4 to pass it's own RPC-SAMLOGON torture test.

Include RPC-SAMLOGON in the list of tests expected to pass

Remove silly extra loops from the RPC-SAMLOGON test, which mostly just
slowed htings down.

Andrew Bartlett
(This used to be commit 518ca9fb695b0f9d480122a74a2159f7f17a3219)

13 years agor4565: Make the order of the initialisation more sensible.
Andrew Bartlett [Thu, 6 Jan 2005 12:10:54 +0000 (12:10 +0000)]
r4565: Make the order of the initialisation more sensible.

Andrew Bartlett
(This used to be commit 5598cda08b46e61695b753e049288a0b498502c4)

13 years agor4564: added a comment on lsa_EnumAccounts IDL
Andrew Tridgell [Thu, 6 Jan 2005 12:02:39 +0000 (12:02 +0000)]
r4564: added a comment on lsa_EnumAccounts IDL
(This used to be commit 08d7b77efc05571146c54322e684753ccd4cd2d6)

13 years agor4563: fixed lsa_EnumAccounts() server side to return all accounts that have privileg...
Andrew Tridgell [Thu, 6 Jan 2005 12:01:11 +0000 (12:01 +0000)]
r4563: fixed lsa_EnumAccounts() server side to return all accounts that have privileges, as
volker discovered
(This used to be commit 09edc31f3b92105dab585614553ba5e94ccdf588)

13 years agor4560: - fixed crash bugs in the RPC-SCHANNEL and RPC-NETLOGON tests
Andrew Tridgell [Thu, 6 Jan 2005 09:26:14 +0000 (09:26 +0000)]
r4560: - fixed crash bugs in the RPC-SCHANNEL and RPC-NETLOGON tests

- disabled the async netlogon tests for now until we better understand async rpc

- added a script that runs rpc tests that a w2k3 DC
  should pass. This is useful for regression testing when PIDL changes
  are made.
(This used to be commit f7d4d3db489ad79457de70a85ad990159f6e74f8)

13 years agor4559: prevent the RPC-EPMAPPER test from looping forever against w2k3
Andrew Tridgell [Thu, 6 Jan 2005 09:24:41 +0000 (09:24 +0000)]
r4559: prevent the RPC-EPMAPPER test from looping forever against w2k3
(This used to be commit fa3cecddd8065885dd461000de683eb0143eb481)

13 years agor4558: more use of bitmaps and enums
Stefan Metzmacher [Thu, 6 Jan 2005 07:34:14 +0000 (07:34 +0000)]
r4558: more use of bitmaps and enums

(This used to be commit 2a859fbc90a6b043bac318196e42c2949958d57f)

13 years agor4557: support for [flags()] on typedef enum|bitmap
Stefan Metzmacher [Thu, 6 Jan 2005 07:29:55 +0000 (07:29 +0000)]
r4557: support for [flags()] on typedef enum|bitmap

NDR_PAHEX is handled by ndr_print_enum() now

(This used to be commit c3b2d2cca37193fead0df1a8808c3ffcd5180a89)

13 years agor4556: neater (and faster) way of doing alignments and scalars
Andrew Tridgell [Thu, 6 Jan 2005 07:22:47 +0000 (07:22 +0000)]
r4556: neater (and faster) way of doing alignments and scalars
(This used to be commit ec70d9a740ab0b6f83b6b10c1b5313e585164383)

13 years agor4555: fix some dependencies
Stefan Metzmacher [Thu, 6 Jan 2005 07:02:46 +0000 (07:02 +0000)]
r4555: fix some dependencies

(This used to be commit a4d94034239980d8a7ab38dfe2b19936b15d23df)

13 years agor4554: create svcctl_ServerType bitmap
Stefan Metzmacher [Thu, 6 Jan 2005 07:00:54 +0000 (07:00 +0000)]
r4554: create svcctl_ServerType bitmap

(This used to be commit ed1c98cb9d1adbc2616cb26376927c6dee1b579b)

13 years agor4553: fix typo
Stefan Metzmacher [Thu, 6 Jan 2005 06:59:14 +0000 (06:59 +0000)]
r4553: fix typo

(This used to be commit 6f75a06b8691dd0d684a51b7851696613c6a6b11)

13 years agor4552: use samr_AcctFlags in netlogon.idl
Stefan Metzmacher [Thu, 6 Jan 2005 06:34:07 +0000 (06:34 +0000)]
r4552: use samr_AcctFlags in netlogon.idl

(This used to be commit 3e224575e58436fef71897e62f57bfcf120c0da8)

13 years agor4551: add support for a pidl extensions
Stefan Metzmacher [Thu, 6 Jan 2005 06:32:07 +0000 (06:32 +0000)]
r4551: add support for a pidl extensions

'declare bitmap foo1;'
'declare enum foo2;'

and also allow

typedef [public] bitmap ...
typedef [public] enum ...

you need to a forward declaration of bitmaps and enums

when you want to use them in another idl file,
and you need to make the real declaration to be public

see the next commit to samr.idl and netlogon.idl

(This used to be commit a8d61aa47388b82595ee02b9cfd35f15afb93c2a)

13 years agor4550: talloc() is now typesafe. It is exactly equivalent to the old talloc_p() macro...
Andrew Tridgell [Thu, 6 Jan 2005 03:20:56 +0000 (03:20 +0000)]
r4550: talloc() is now typesafe. It is exactly equivalent to the old talloc_p() macro. Use
talloc_size() if you want the old behaviour.

I have kept talloc_p() as an alias for now. Once we change all calls
to be plain talloc() then we can remove it.
(This used to be commit 2011bbeb841fd6bfccf3d44a49f79203f7f55baa)

13 years agor4549: got rid of a lot more uses of plain talloc(), instead using
Andrew Tridgell [Thu, 6 Jan 2005 03:06:58 +0000 (03:06 +0000)]
r4549: got rid of a lot more uses of plain talloc(), instead using
talloc_size() or talloc_array_p() where appropriate.

also fixed a memory leak in pvfs_copy_file() (failed to free a memory
(This used to be commit 89b74b53546e1570b11b3702f40bee58aed8c503)

13 years agor4548: Convert to talloc_p() and talloc_array_p() where appropriate.
Tim Potter [Thu, 6 Jan 2005 02:36:59 +0000 (02:36 +0000)]
r4548: Convert to talloc_p() and talloc_array_p() where appropriate.

(swig stuff seems broken atm though)
(This used to be commit 9eeb976773a8d2ed26a690c73d67f5db735e8d3a)

13 years agor4547: - added talloc_new(ctx) macro that is a neater form of the common talloc(ctx...
Andrew Tridgell [Thu, 6 Jan 2005 02:32:43 +0000 (02:32 +0000)]
r4547: - added talloc_new(ctx) macro that is a neater form of the common talloc(ctx, 0) call.

- cleaned up some talloc usage in various files

I'd like to get to the point that we have no calls to talloc(), at
which point we will rename talloc_p() to talloc(), to encourage
everyone to use the typesafe functions.
(This used to be commit e6c81d7c9f8a6938947d3c1c8a971a0d6d50b67a)

13 years agor4546: Use talloc_p() instad of talloc()
Tim Potter [Thu, 6 Jan 2005 02:10:33 +0000 (02:10 +0000)]
r4546: Use talloc_p() instad of talloc()
(This used to be commit 2ec3a137d7fd8a912bc70e865f7a7798190b8869)

13 years agor4542: use bitmap for samr_FieldsPresent and samr_AcctFlags
Stefan Metzmacher [Wed, 5 Jan 2005 16:54:51 +0000 (16:54 +0000)]
r4542: use bitmap for samr_FieldsPresent and samr_AcctFlags

(This used to be commit 109c91650ac8b4ad28151bdb6debf73ad6a94bfb)

13 years agor4541: make use of new enum and bitmap features
Stefan Metzmacher [Wed, 5 Jan 2005 16:48:58 +0000 (16:48 +0000)]
r4541: make use of new enum and bitmap features

(This used to be commit fd96a07c5a1f4969bfd04ffd3b6990a2dad41cf4)

13 years agor4540: sync enum and bitmap code
Stefan Metzmacher [Wed, 5 Jan 2005 16:31:05 +0000 (16:31 +0000)]
r4540: sync enum and bitmap code

(This used to be commit 2f3aea72ee7d9d90f7b910d11bdd1e96f9f0ebe1)

13 years agor4536: make use of the new enum and bitmap feature of pidl
Stefan Metzmacher [Wed, 5 Jan 2005 15:37:43 +0000 (15:37 +0000)]
r4536: make use of the new enum and bitmap feature of pidl

(This used to be commit 7702d0f9775878c4d7535d9135f41d156146f8d1)