13 years agor6226: A couple of small typos ...
Richard Sharpe [Wed, 6 Apr 2005 16:48:28 +0000 (16:48 +0000)]
r6226: A couple of small typos ...
(This used to be commit d2c5320a18821439e49d3f7bffebc47129b8b057)

13 years agor6223: added a bit more datagram infrastructure and the beginnings of a test
Andrew Tridgell [Wed, 6 Apr 2005 11:17:08 +0000 (11:17 +0000)]
r6223: added a bit more datagram infrastructure and the beginnings of a test
suite. The NBT-DGRAM test does a UDP/138 netlogon request, to which a
windows server sends a reply, but the windows server sends the reply
to the wrong port (it always sends to 138), so the test suite doesn't
see it.
(This used to be commit a7634625dbc944dd8256a822be290010f341a571)

13 years agor6222: fixed the socket wrapper code for getsockname()
Andrew Tridgell [Wed, 6 Apr 2005 10:06:08 +0000 (10:06 +0000)]
r6222: fixed the socket wrapper code for getsockname()
(This used to be commit 11e245a3f0e1523eba3a042db140dec8732aa985)

13 years agor6219: This change allows us to fall back to authenticating without
Richard Sharpe [Tue, 5 Apr 2005 19:53:07 +0000 (19:53 +0000)]
r6219: This change allows us to fall back to authenticating without
DCERPC_SCHANNEL_128 if we fail. Thus, it allows us to work with Windows
NT DCs ...
(This used to be commit 3034b226705c4736d57c9bf4e9470c4d44c72e8e)

13 years agor6215: Add test for LookupNames. Fix CreateUser2 test.
Tim Potter [Tue, 5 Apr 2005 11:54:53 +0000 (11:54 +0000)]
r6215: Add test for LookupNames.  Fix CreateUser2 test.
(This used to be commit e3a69a73222ae3277c2d10d33c5c71b7a14da789)

13 years agor6214: Fix typo in DomainHandle.OpenUser() function.
Tim Potter [Tue, 5 Apr 2005 11:50:47 +0000 (11:50 +0000)]
r6214: Fix typo in DomainHandle.OpenUser() function.

Implement DomainHandle.LookupNames() function.

UserHandle.DeleteUser() closes the handle so don't try and close it
when the GC destroys the class instance.
(This used to be commit 57680163bcc1aa5c707a64dcd1d0998dbc9f0659)

13 years agor6213: Add %array_functions for struct samr_String so we can create and
Tim Potter [Tue, 5 Apr 2005 11:48:16 +0000 (11:48 +0000)]
r6213: Add %array_functions for struct samr_String so we can create and
access arrays of them.
(This used to be commit fc2b73d4d75f383108632935ba047890c816b283)

13 years agor6212: Treat uint8 and int8's as integers instead of chars. Swig maps a char
Tim Potter [Tue, 5 Apr 2005 11:47:21 +0000 (11:47 +0000)]
r6212: Treat uint8 and int8's as integers instead of chars.  Swig maps a char
to a string when we really want an integer.
(This used to be commit 86c62b92e84a6eb1e756a7125777587583a9276e)

13 years agor6211: Use cli_credentials_set_{domain,username,password}() to fill in
Tim Potter [Tue, 5 Apr 2005 09:38:51 +0000 (09:38 +0000)]
r6211: Use cli_credentials_set_{domain,username,password}() to fill in
command line arguments for credentials typemap.  Neat!
(This used to be commit a3e7d71463053101e743a930f2648269d63ecaca)

13 years agor6210: Call cli_credentials_set_conf() when initialising credentials in
Tim Potter [Tue, 5 Apr 2005 09:18:36 +0000 (09:18 +0000)]
r6210: Call cli_credentials_set_conf() when initialising credentials in
cli_credentials typemap.
(This used to be commit 1c88e71ec645d10648f01e0405d29a4a83bc4036)

13 years agor6209: started added code to support mailslot requests over UDP/138
Andrew Tridgell [Tue, 5 Apr 2005 08:35:02 +0000 (08:35 +0000)]
r6209: started added code to support mailslot requests over UDP/138
datagrams. This adds the IDL to parse mailslot packets, plus mailslot
dispatch and listener registration code.

mailslots are used for UDP/138 browse and netlogon packets
(This used to be commit f20e7e5200de736b3451d748ed716be638f93502)

13 years agor6208: Add cli_credentials support for swig wrappers. For the moment it
Tim Potter [Tue, 5 Apr 2005 07:58:02 +0000 (07:58 +0000)]
r6208: Add cli_credentials support for swig wrappers.  For the moment it
only does anonymous connections.
(This used to be commit b09a4723539235fc924134aa50fc4aed040afb33)

13 years agor6207: - clean up source topdir
Stefan Metzmacher [Tue, 5 Apr 2005 07:03:31 +0000 (07:03 +0000)]
r6207: - clean up source topdir
- move provision stuff to setup/
- remove unused scripts

(This used to be commit c35887ca649675f28ca986713a08082420418d74)

13 years agor6206: go baack 10 revisions to get DatabaseDeltas, this shows that the bdc only
Stefan Metzmacher [Tue, 5 Apr 2005 06:55:10 +0000 (06:55 +0000)]
r6206: go baack 10 revisions to get DatabaseDeltas, this shows that the bdc only
need one call to get in sync again (except something like NT_STATUS_MORE_ENTRIES is returned)

also the pdc only need to know the current state values

(This used to be commit f4e12b38937bd8c16fd1a8b13401a65565d4bd00)

13 years agor6197: fix for my last commit, I removed SPOOLSS_ARCHITECTURE, which was "Architecture"
Stefan Metzmacher [Mon, 4 Apr 2005 17:04:03 +0000 (17:04 +0000)]
r6197: fix for my last commit, I removed SPOOLSS_ARCHITECTURE, which was "Architecture"
(sorry richard:-)

disable lookup for DefaultSpoolDirectory until, I have fixed the parsing when WERR_MORE_DATA
is returned

(This used to be commit d5993337b814560cd59d8d08b30fe31e2fb9fd28)

13 years agor6196: Make the comparisons consistent with in the same expression.
Richard Sharpe [Mon, 4 Apr 2005 16:42:31 +0000 (16:42 +0000)]
r6196: Make the comparisons consistent with in the same expression.
(This used to be commit 6f7337163e2eaae2d24ccebcd31787e48f543fbf)

13 years agor6195: I think Metze meant SPOOLSS_ARCHITECTURE_NT_X86, but I could be wrong.
Richard Sharpe [Mon, 4 Apr 2005 16:40:23 +0000 (16:40 +0000)]
r6195: I think Metze meant SPOOLSS_ARCHITECTURE_NT_X86, but I could be wrong.
(This used to be commit 85c2b8b9447efdcefe16517a5509357262c6229c)

13 years agor6194: - fix some spoolss_*Form names and types
Stefan Metzmacher [Mon, 4 Apr 2005 15:19:27 +0000 (15:19 +0000)]
r6194: - fix some spoolss_*Form names and types

- fix GetPrinterData(), look inside the datablob

- add idl for RemoteFindFirstChangeNotify(), without meaning yet, just to not return a DCERPC_FAULT
  when receiving this request

(This used to be commit 92f3d5bd9c700032612ac20dc7635730c555c4da)

13 years agor6193: we don't need to store the handle type here,
Stefan Metzmacher [Mon, 4 Apr 2005 15:15:18 +0000 (15:15 +0000)]
r6193: we don't need to store the handle type here,
it's in handle->wire_handle.handle_type

(This used to be commit 539286bc9fa1638dd564fb2f8ba924a0ede8db08)

13 years agor6192: remove handle->destroy function pointer, this should be done by talloc destruc...
Stefan Metzmacher [Mon, 4 Apr 2005 14:58:52 +0000 (14:58 +0000)]
r6192: remove handle->destroy function pointer, this should be done by talloc destructors now

(This used to be commit 862226f557dddf989cbbdbfd5aa2bf6f2312fdf0)

13 years agor6191: fix spoolss_Enum* push code
Stefan Metzmacher [Mon, 4 Apr 2005 14:25:29 +0000 (14:25 +0000)]
r6191: fix spoolss_Enum* push code

(This used to be commit e66aa87f148d04f4c44b08555345600b8a6278d4)

13 years agor6190: fix gensize on unions
Stefan Metzmacher [Mon, 4 Apr 2005 14:23:34 +0000 (14:23 +0000)]
r6190: fix gensize on unions

(This used to be commit 661e64e9ce91e8029e1a36ef6825e56e5460e32b)

13 years agor6189: move function to the right place
Stefan Metzmacher [Mon, 4 Apr 2005 14:22:28 +0000 (14:22 +0000)]
r6189: move function to the right place

(This used to be commit 08d22a07cfa84fe959320058e8574c8983e1d71f)

13 years agor6188: correct fix for rev 6182
Stefan Metzmacher [Mon, 4 Apr 2005 05:52:53 +0000 (05:52 +0000)]
r6188: correct fix for rev 6182

we should start with an empty switch_list
in ndr_print as we do for ndr_pull/ndr_push

(This used to be commit 848f553117b369fc6697086b3f7d36dd17b60f5b)

13 years agor6187: 1. Make sure that we don't try to delete . and .. in a more portable way.
Richard Sharpe [Sun, 3 Apr 2005 21:37:13 +0000 (21:37 +0000)]
r6187: 1. Make sure that we don't try to delete . and .. in a more portable way.

2. Also, don't try to delete directories.

I am not entirely happy with this patch, and the fact that there is a
define for HAVE_SYS_STAT_H suggests that there are some systems for which
stat will not be defined, which means that the patch is not entirely
(This used to be commit fe7ddad7d44a49b2efe81cb3d0a5b2d09d1892ab)

13 years agor6185: added LIBCLI_DGRAM to the list of libs to be built as part of LIBCLI
Andrew Tridgell [Sun, 3 Apr 2005 04:36:00 +0000 (04:36 +0000)]
r6185: added LIBCLI_DGRAM to the list of libs to be built as part of LIBCLI
(This used to be commit 47e1452da08d06b0b9f15545b3b2b0631f15bac2)

13 years agor6184: the beginnings of the libcli/dgram/ library, and the dgram
Andrew Tridgell [Sun, 3 Apr 2005 04:32:37 +0000 (04:32 +0000)]
r6184: the beginnings of the libcli/dgram/ library, and the dgram
server. Currently just listens on port 138 and parses the packets
(using IDL like the rest of NBT). This allows me to develop the
structures and test with real packets
(This used to be commit 10d64a525349ff96695ad961a3cfeb5bc7c8844f)

13 years agor6182: Jelmer, I think we need to initialize the switch_list, else we are
Richard Sharpe [Sun, 3 Apr 2005 03:58:45 +0000 (03:58 +0000)]
r6182: Jelmer, I think we need to initialize the switch_list, else we are
crash city.
(This used to be commit 6526f21fb72094e8ff62bfc2693a49a3b1679a95)

13 years agor6181: Use ndr_print_set_switch_value() here as well.
Jelmer Vernooij [Sat, 2 Apr 2005 22:46:21 +0000 (22:46 +0000)]
r6181: Use ndr_print_set_switch_value() here as well.
(This used to be commit 4da9d1d5c277eb65d0fe5bf5c4690531dcfb85de)

13 years agor6180: Use token_lists for storing switch values
Jelmer Vernooij [Sat, 2 Apr 2005 20:57:27 +0000 (20:57 +0000)]
r6180: Use token_lists for storing switch values
(This used to be commit f66e11137eed69b44f0739f1064625cbd96243bd)

13 years agor6179: - add new spoolss tests for all spoolss_Enum*() calls which didn't need
Stefan Metzmacher [Sat, 2 Apr 2005 06:51:54 +0000 (06:51 +0000)]
r6179: - add new spoolss tests for all spoolss_Enum*() calls which didn't need
  a handle as parameter,


  we now do cross checks between the different info levels
  and sore the results in a global context,
  so that we later can add cross checks between the different object types

- add idl for EnumMonitors and EnumPrintProcessors

(This used to be commit 92a3721bc7a28d521090b10eb3b1eed089036432)

13 years agor6178: fix ncacn_np connection without sign or seal against NT4
Stefan Metzmacher [Sat, 2 Apr 2005 06:10:45 +0000 (06:10 +0000)]
r6178: fix ncacn_np connection without sign or seal against NT4

(This used to be commit d92100fcc2066454df441a1ea2c7b9940fa19fa1)

13 years agor6177: Use here documents instead of print() statements to generate the
Tim Potter [Sat, 2 Apr 2005 01:43:54 +0000 (01:43 +0000)]
r6177: Use here documents instead of print() statements to generate the
Makefile fragments for the build system.  This allows the file to be
edited without using quite as many backslashes.  Some are still necessary
for interpolation of perl variables though.

I've diffed the new Makefile against the old and there are only some
extra newlines as a result of making things more consistent.
(This used to be commit 3808c5e092e1a11d453d0a043818a10e28c78961)

13 years agor6165: fixed up the userinfo composite code. Fixes include:
Andrew Tridgell [Fri, 1 Apr 2005 11:24:52 +0000 (11:24 +0000)]
r6165: fixed up the userinfo composite code. Fixes include:

- talloc should always be done in the right context. For example, when creating
  the userinfo_state structure, place it inside the composite
  structure, not directly on the pipe. If this isn't done then
  correct cleanup can't happen on errors (as cleanup destroys the top
  level composite context only)

- define private structures like userinfo_state in the userinfo.c
  code, not in the public header

- only keep the parameters we need in the state structure. For
  example, the domain_handle is only needed in the first call, so we
  don't need to keep it around in the state structure, but the level is
  needed in later calls, so we need to keep it

- always initialise [out,ref] parameters in RPC calls. The [ref] part
  means that the call assumes the pointer it has been given is
  valid. If you don't initialise it then you will get a segv on
  recv. This is why the code was dying.

- don't use internal strucrure elements like the pipe
  pipe->conn->pending outside of the internal rpc implementation. That
  is an internal list, trying to use it from external code will cause crashes.

- rpc calls assume that rpc call strucrures remain valid for the
  duration of the call. This means you need to keep the structures
  (such as "struct samr_Close") in the userinfo_state strucrure,
  otherwise it will go out of scope during the async processing

- need to remember to change c->state to SMBCLI_REQUEST_DONE when the
  request has finished in the close handler, otherwise it will loop
  forever trying to close

Mimir, please look at the diff carefully for more detailed info on the fixes
(This used to be commit 01ea1e7762e214e87e74d6f28d6efeb6cdea9736)

13 years agor6164: More comments in the code.
Rafal Szczesniak [Fri, 1 Apr 2005 08:14:57 +0000 (08:14 +0000)]
r6164: More comments in the code.

(This used to be commit 01cbed98b32c2050a665aec51a99288e4afb29c1)

13 years agor6159: Move some more general ndr stuff (alignment calculations) to
Jelmer Vernooij [Thu, 31 Mar 2005 22:50:28 +0000 (22:50 +0000)]
r6159: Move some more general ndr stuff (alignment calculations) to
(This used to be commit f4d550c348e9604439f07329ddbc3cf65891d578)

13 years agor6150: fixed a few socket_wrapper bugs.
Andrew Tridgell [Thu, 31 Mar 2005 12:40:12 +0000 (12:40 +0000)]
r6150: fixed a few socket_wrapper bugs.

  - now works properly with UDP, so the NBT tests work
  - fixed byte order in a few places
  - connect() now fails to non-localhost
  - fixed some places that tested for < 0, which should be == -1 (most syscalls
    return -1 on error, not "negative")
(This used to be commit 61e1eea0fdb13577de2506472c5443ee92656263)

13 years agor6148: Add a showflags target to display the various compiler flags a la
Tim Potter [Thu, 31 Mar 2005 02:40:08 +0000 (02:40 +0000)]
r6148: Add a showflags target to display the various compiler flags a la
showlayout.  There seems to be a bunch of -D and -I stuff in LD_FLAGS
which I don't think should be there.
(This used to be commit 87f88aaceeacf57b4a8a31e005894cbff4a21779)

13 years agor6147: The maxfd was being recalculated on every event loop, which made us
Andrew Tridgell [Thu, 31 Mar 2005 02:14:31 +0000 (02:14 +0000)]
r6147: The maxfd was being recalculated on every event loop, which made us
less scalable. It only needs to be recalculated when we the highest fd
is destroyed.
(This used to be commit 568b9175f329f594404c9091ee5946670c40697e)

13 years agor6144: Apparently there are more systems that have AF_UNIX then
Jelmer Vernooij [Thu, 31 Mar 2005 00:43:26 +0000 (00:43 +0000)]
r6144: Apparently there are more systems that have AF_UNIX then
AF_LOCAL (we already use AF_UNIX in other places).
(This used to be commit 88d93b9782766ab1159a233307ef508881caa615)

13 years agor6143: Put compression support in the subcontext handling functions rather
Jelmer Vernooij [Thu, 31 Mar 2005 00:37:01 +0000 (00:37 +0000)]
r6143: Put compression support in the subcontext handling functions rather
then at the element level.
(This used to be commit fac5edd2b71759c82232713f77ab91b41ed09250)

13 years agor6140: - Add configure option for enabling the socket-wrapper library, so it
Jelmer Vernooij [Wed, 30 Mar 2005 23:28:15 +0000 (23:28 +0000)]
r6140: - Add configure option for enabling the socket-wrapper library, so it
  can be enabled on the buildfarm without requiring --enable-developer
- Support tcp and udp being used on the same port
- FIx some portability issues (should fix the build on
   some hosts on the buildfarm)
- Ignore setting TCP_NODELAY on (semi-)TCP sockets rather then complain about
  it not being supported (saves us from a couple of error messages for each
  connection that is opened)
(This used to be commit 443fb7853b8d3cb516c442fdc595038544b75738)

13 years agor6139: Move socket_wrapper to a seperate directory
Jelmer Vernooij [Wed, 30 Mar 2005 22:09:16 +0000 (22:09 +0000)]
r6139: Move socket_wrapper to a seperate directory
(This used to be commit a2ef9225f15e369af7b884262b997ab321fd24d6)

13 years agor6135: - make use of the new dom_sid28 type
Stefan Metzmacher [Wed, 30 Mar 2005 15:07:14 +0000 (15:07 +0000)]
r6135: - make use of the new dom_sid28 type
  (this fixes parsing of w2k blob, which some times have random gargabe data in the sid buffer)

- make the names of the DsReplicaCoursor*Ctr* 's more consistent
  and fix DsGetNCchangesCtr6 parsing

(This used to be commit 75e427dca9f6b129ead100f7265794189f257c67)

13 years agor6134: add a new type dom_sid28 which is a 28 byte fixed buffer with a dom_sid in it
Stefan Metzmacher [Wed, 30 Mar 2005 15:04:19 +0000 (15:04 +0000)]
r6134: add a new type dom_sid28 which is a 28 byte fixed buffer with a dom_sid in it

(This used to be commit 460d1b089e494efaeb0c8c7fd4601a9ef57123c5)

13 years agor6132: allow up to 15 sub_auth in a dom_sid
Stefan Metzmacher [Wed, 30 Mar 2005 12:27:01 +0000 (12:27 +0000)]
r6132: allow up to 15 sub_auth in a dom_sid
(tridge: asked me for that commit)

(This used to be commit 2791de069a571aaa53283d68b5cc957d82e7ce41)

13 years agor6131: decompression of DsGetNCChanges level 2 responses works now
Stefan Metzmacher [Wed, 30 Mar 2005 11:26:02 +0000 (11:26 +0000)]
r6131: decompression of DsGetNCChanges level 2 responses works now
(and the push side isn't used currently...)

(This used to be commit 2d121c84312723ef6a7a3250a204efa8488f6303)

13 years agor6130: More work on the NDR tree generator
Jelmer Vernooij [Wed, 30 Mar 2005 11:15:51 +0000 (11:15 +0000)]
r6130: More work on the NDR tree generator
(This used to be commit ad7ea50eb29402d213438e5fcaa56f853c00487e)

13 years agor6129: - add our own MSZIP decompression implementation
Stefan Metzmacher [Wed, 30 Mar 2005 10:48:52 +0000 (10:48 +0000)]
r6129: - add our own MSZIP decompression implementation
  (taken from cabextract.c from KDE)
  this code maybe need to be rewritten and the
  compression side needs to be done,
  but for now it seems to works

- remove the dependency to zlib

(This used to be commit 5e8558c5b4365a494aa054c3e08d4084b319e6e5)

13 years agor6128: fix the build
Stefan Metzmacher [Wed, 30 Mar 2005 04:55:02 +0000 (04:55 +0000)]
r6128: fix the build

(This used to be commit 80593150341852af0816e69bd653c93228862e9b)

13 years agor6118: Make it so that we can do --with-zlib=no in configure and also a couple
Richard Sharpe [Wed, 30 Mar 2005 00:15:16 +0000 (00:15 +0000)]
r6118: Make it so that we can do --with-zlib=no in configure and also a couple
of small typos.
(This used to be commit 9b4069e84573f85ce4341ceacd35737a18726a0b)

13 years agor6115: don't try to decompress level 7 buffers yet
Stefan Metzmacher [Tue, 29 Mar 2005 13:07:20 +0000 (13:07 +0000)]
r6115: don't try to decompress level 7 buffers yet

(This used to be commit bbc0f6c5525b03deb9374fd96cb22cff4d3fb2e1)

13 years agor6114: the marker is const and is 0x434B 'CK'
Stefan Metzmacher [Tue, 29 Mar 2005 10:01:34 +0000 (10:01 +0000)]
r6114: the marker is const and is 0x434B 'CK'

(This used to be commit 4b88ff29715a98c728cf70db4889daafed8eeeb2)

13 years agor6113: Move GENSEC and the kerberos code out of libcli/auth, and into
Andrew Bartlett [Tue, 29 Mar 2005 08:24:03 +0000 (08:24 +0000)]
r6113: Move GENSEC and the kerberos code out of libcli/auth, and into
auth/gensec and auth/kerberos.

This also pulls the kerberos configure code out of libads (which is
otherwise dead), and into auth/kerberos/kerberos.m4

Andrew Bartlett
(This used to be commit e074d63f3dcf4f84239a10879112ebaf1cfa6c4f)

13 years agor6112: try to decompress all chunks and put them together
Stefan Metzmacher [Tue, 29 Mar 2005 08:10:31 +0000 (08:10 +0000)]
r6112: try to decompress all chunks and put them together

it produces the correct DATA_BLOB length, but only the first chunk is
successfull decompressed...

(This used to be commit 0d44d077975d756023f1dcc8d2c3ebf06305e355)

13 years agor6109: nicer way to handle compression in the torture test
Stefan Metzmacher [Tue, 29 Mar 2005 06:19:44 +0000 (06:19 +0000)]
r6109: nicer way to handle compression in the torture test

(This used to be commit a3cec189e1f5d137ba2f2829def03b060b59f0e2)

13 years agor6101: only allow properties we know about, that helps to catch typos!
Stefan Metzmacher [Mon, 28 Mar 2005 18:28:16 +0000 (18:28 +0000)]
r6101: only allow properties we know about, that helps to catch typos!

what does length_of() and id() do?

(This used to be commit 55963934db51fadb1340c7a2ec275aa24151dd14)

13 years agor6100: - fix nondiscriminant -> nodiscriminant (that takes me 2 days to find...:-( )
Stefan Metzmacher [Mon, 28 Mar 2005 18:25:47 +0000 (18:25 +0000)]
r6100: - fix nondiscriminant -> nodiscriminant (that takes me 2 days to find...:-( )

- use a DATA_BLOB for the driver specific data in the devmode

(This used to be commit 87d48b20769666b568ac1115246b58995d221148)

13 years agor6099: use the enum print function
Stefan Metzmacher [Mon, 28 Mar 2005 18:23:54 +0000 (18:23 +0000)]
r6099: use the enum print function

(This used to be commit ff32e2182e3f11b1b51110c9d3f34bc8781dec0b)

13 years agor6098: fix parsing of empty union cases
Stefan Metzmacher [Mon, 28 Mar 2005 18:22:45 +0000 (18:22 +0000)]
r6098: fix parsing of empty union cases

(This used to be commit f3c64120a16289472bdc56329d39c7221d00b558)

13 years agor6097: allow compression only on subcontexts
Stefan Metzmacher [Mon, 28 Mar 2005 18:21:13 +0000 (18:21 +0000)]
r6097: allow compression only on subcontexts

(This used to be commit 2a7eead1c8058f829395723028a43b0336a1cf87)

13 years agor6094: Work on the Kerberos code recently merged from Samba 3.0. This fixes
Andrew Bartlett [Mon, 28 Mar 2005 06:40:18 +0000 (06:40 +0000)]
r6094: Work on the Kerberos code recently merged from Samba 3.0.  This fixes
up issues I introduced during the merge, that caused a segfault.

I've still not got the keytab code to work for me (using Samba3 to
generate the keytab) so this is still not fully tested, but it's
better than it was.

To add debugging, I now use the krb5_get_error_message() function from
Heimdal when present, to return the custom error string, which
contains far, far more information than the simple error code does.

(This last point may well be worth merging back into 3.0)

Andrew Bartlett
(This used to be commit ed5755d9d1e48df7ae77a9410d30e10cb8b0cbd7)

13 years agor6093: Patch to fix sys_select so it can't drop signals if another fd
Jeremy Allison [Mon, 28 Mar 2005 03:31:44 +0000 (03:31 +0000)]
r6093: Patch to fix sys_select so it can't drop signals if another fd
is ready to read. Patch from Mark Weaver <>.
(This used to be commit 857e98e8ea842bb94c93b81d7b69e3d304f100f5)

13 years agor6088: Add the socket_wrapper library. This is a very simple library that
Jelmer Vernooij [Mon, 28 Mar 2005 01:00:39 +0000 (01:00 +0000)]
r6088: Add the socket_wrapper library. This is a very simple library that
redirects traffic (currently just IP traffic) over unix domain sockets
if the SOCKET_WRAPPER_DIR environment variable has been set.
Aim is to use this for the Samba4 torture suite on the buildfarm.

The socket_wrapper library can only be used if Samba was compiled with
--enable-developer. passes against a local smbd with SOCKET_WRAPPER_DIR set.
(and ethereal showed no traffic whatsoever)

Stuff that still needs to be fixed in socketwrapper:
 - Give ENETUNREACH if target is not localhost
 - A given port number can only be used for UDP /or/ TCP, not both.
 - Perhaps allow some calls to circumvent socketwrapper (do we need DNS?)
(This used to be commit f8a63a843ccca092d9756b64e09175d37c08550a)

13 years agor6087: - remove the dlopen code for now (before it goes back, it needs to be
Andrew Tridgell [Mon, 28 Mar 2005 00:40:18 +0000 (00:40 +0000)]
r6087: - remove the dlopen code for now (before it goes back, it needs to be
  made into something that isn't a maze of #ifdefs)

- when a module is not found, make it a non-fatal error. Otherwise the standalone ldb
  tools just bail out. The previous code meant that if you had a
  module listed and it wasn't present then you could _never_ fix it,
  as you coudln't open the ldb to remove that module from @MODULES !
(This used to be commit c4728625c093d91e522b80c049e0d42d2b5f143b)

13 years agor6086: default to stderr for error messages in ldb, so we get errors in ldb_connect()
Andrew Tridgell [Mon, 28 Mar 2005 00:37:27 +0000 (00:37 +0000)]
r6086: default to stderr for error messages in ldb, so we get errors in ldb_connect()
(This used to be commit a6e492f95c6f31ed37ee32a13a34fa2847d8352d)

13 years agor6085: dc is case insensitive
Simo Sorce [Mon, 28 Mar 2005 00:06:13 +0000 (00:06 +0000)]
r6085: dc is case insensitive
(This used to be commit 55117f1ab9171ee77cea5a6635411b23e7c542c8)

13 years agor6084: - Introduce the samldb module dependency on samba4
Simo Sorce [Sun, 27 Mar 2005 23:31:43 +0000 (23:31 +0000)]
r6084: - Introduce the samldb module dependency on samba4
- This module will take care of properly filling an user or group object
  with required fields. You just need to provide the dn and the objectclass
  and a user/group get created

(This used to be commit fb9afcaf533a4c32547d1857306e0aece8063953)

13 years agor6079: Add inline documentation on the credentials context API.
Andrew Bartlett [Sun, 27 Mar 2005 06:55:03 +0000 (06:55 +0000)]
r6079: Add inline documentation on the credentials context API.

Andrew Bartlett
(This used to be commit 258c04e3678b936bb564ecef10f14128c0a54510)

13 years agor6078: Correctly fix the failures for NT1 (not SPNEGO) session setups in the
Andrew Bartlett [Sun, 27 Mar 2005 06:26:00 +0000 (06:26 +0000)]
r6078: Correctly fix the failures for NT1 (not SPNEGO) session setups in the
client.  The issue was actually a cut-and-paste bug, I was filling in
the .old not the .nt1 part of the union.

I've also removed the 'error checks' - I'll shortly document the API
for the credentials code to clarify that it will always return a
pointer here, except in cases of programmer error.

Tridge:  I hope this is OK.

Andrew Bartlett
(This used to be commit 6439de9ec8c8d24197ea69dc337473e54c8b36b8)

13 years agor6075: added talloc_enable_null_tracking() (asked for by lifeless)
Andrew Tridgell [Sat, 26 Mar 2005 10:47:44 +0000 (10:47 +0000)]
r6075: added talloc_enable_null_tracking() (asked for by lifeless)
(This used to be commit 40b8ee186af3e7f771c680dbbb03fdcf559bf103)

13 years agor6074: fixed non-spnego connections for new credentials code
Andrew Tridgell [Sat, 26 Mar 2005 10:22:02 +0000 (10:22 +0000)]
r6074: fixed non-spnego connections for new credentials code
(This used to be commit ff6663aac8ed475bf65d9c06d7f2447a9827898c)

13 years agor6070: Fix typo's and fallback to "" as default user name if no
Jelmer Vernooij [Sat, 26 Mar 2005 01:08:59 +0000 (01:08 +0000)]
r6070: Fix typo's and fallback to "" as default user name if no
other username could be guessed.
(This used to be commit 7fe77cd65901776b5a78e8398547f364379259d3)

13 years agor6065: revert test value
Stefan Metzmacher [Fri, 25 Mar 2005 23:18:35 +0000 (23:18 +0000)]
r6065: revert test value

(This used to be commit fca4dc4827c98c02051165c1aedf5bdc5354bdda)

13 years agor6061: add start of compression support in our rpc code
Stefan Metzmacher [Fri, 25 Mar 2005 13:40:17 +0000 (13:40 +0000)]
r6061: add start of compression support in our rpc code

this is not complete cuurently...

but I want other people to test it and help me on finishing it.
(try to change the #if 0 in torture/rpc/drsuapi.c into #if 1)

(This used to be commit 335adef37082a78e0426decb715629bd778e6582)

13 years agor6045: Couple of small GTK+ fixes
Jelmer Vernooij [Thu, 24 Mar 2005 20:29:04 +0000 (20:29 +0000)]
r6045: Couple of small GTK+ fixes
Use uint32_t and uint16_t rather then DWORD and WORD in
the NT4 backend. Add some more unknown fields..
(This used to be commit 6c3b1ec3296c7ab1ddfdcee86162f2eb0d73f5a8)

13 years agor6033: Patch from 'lifeless' to clarify behaviour with NULL pointers.
Andrew Bartlett [Thu, 24 Mar 2005 08:00:15 +0000 (08:00 +0000)]
r6033: Patch from 'lifeless' to clarify behaviour with NULL pointers.

Andrew Bartlett
(This used to be commit 48c518796797f021c9c7f319ca8cd0a0c185f64c)

13 years agor6032: Fix up SetServerPassword2 on NETLOGON for [bigendian]. Clearly nobody
Andrew Bartlett [Thu, 24 Mar 2005 06:30:38 +0000 (06:30 +0000)]
r6032: Fix up SetServerPassword2 on NETLOGON for [bigendian].  Clearly nobody
has the patience to run to completion :-)

It looks to me that the Windows server runs the RC4 over the C struct,
not the NDR data.

Andrew Bartlett
(This used to be commit c324d974134c35b4c50c91d5a932a63c78b67046)

13 years agor6031: don't try to send errors when the socket has been destroyed
Andrew Tridgell [Thu, 24 Mar 2005 04:53:20 +0000 (04:53 +0000)]
r6031: don't try to send errors when the socket has been destroyed
(This used to be commit 54c02846791cd8bda942fec847257c00013d3409)

13 years agor6030: Missing from previous commit, a small header file to link
Andrew Bartlett [Thu, 24 Mar 2005 04:45:41 +0000 (04:45 +0000)]
r6030: Missing from previous commit, a small header file to link
libcli/auth/schannel.c and libcli/auth/schannel_sign.c

Andrew Bartlett
(This used to be commit 1e0e66d7202d3f0e7fb3c90f2ca608fa08a713a6)

13 years agor6028: A MAJOR update to intergrate the new credentails system fully with
Andrew Bartlett [Thu, 24 Mar 2005 04:14:06 +0000 (04:14 +0000)]
r6028: A MAJOR update to intergrate the new credentails system fully with
GENSEC, and to pull SCHANNEL into GENSEC, by making it less 'special'.

GENSEC now no longer has it's own handling of 'set username' etc,
instead it uses cli_credentials calls.

In order to link the credentails code right though Samba, a lot of
interfaces have changed to remove 'username, domain, password'
arguments, and these have been replaced with a single 'struct

In the session setup code, a new parameter 'workgroup' contains the
client/server current workgroup, which seems unrelated to the
authentication exchange (it was being filled in from the auth info).

This allows in particular kerberos to only call back for passwords
when it actually needs to perform the kinit.

The kerberos code has been modified not to use the SPNEGO provided
'principal name' (in the mechListMIC), but to instead use the name the
host was connected to as.  This better matches Microsoft behaviour,
is more secure and allows better use of standard kerberos functions.

To achieve this, I made changes to our socket code so that the
hostname (before name resolution) is now recorded on the socket.

In schannel, most of the code from librpc/rpc/dcerpc_schannel.c is now
in libcli/auth/schannel.c, and it looks much more like a standard
GENSEC module.  The actual sign/seal code moved to
libcli/auth/schannel_sign.c in a previous commit.

The schannel credentails structure is now merged with the rest of the
credentails, as many of the values (username, workstation, domain)
where already present there.  This makes handling this in a generic
manner much easier, as there is no longer a custom entry-point.

The auth_domain module continues to be developed, but is now just as
functional as auth_winbind.  The changes here are consequential to the
schannel changes.

The only removed function at this point is the RPC-LOGIN test
(simulating the load of a WinXP login), which needs much more work to
clean it up (it contains copies of too much code from all over the
torture suite, and I havn't been able to penetrate its 'structure').

Andrew Bartlett
(This used to be commit 2301a4b38a21aa60917973451687063d83d18d66)

13 years agor6027: Add copyright, and add a useful debug message.
Andrew Bartlett [Thu, 24 Mar 2005 04:11:39 +0000 (04:11 +0000)]
r6027: Add copyright, and add a useful debug message.

Andrew Bartlett
(This used to be commit b5260cf0d4c4f2e81a310d1c94160c9fbaaa331f)

13 years agor6026: Update the kerberos keytab code to match Samba3 again.
Andrew Bartlett [Thu, 24 Mar 2005 03:36:53 +0000 (03:36 +0000)]
r6026: Update the kerberos keytab code to match Samba3 again.
(untested at this point).

Andrew Bartlett
(This used to be commit ef7f9a01b4f3fa41fd7981b260fa2fadc7ce10ad)

13 years agor6025: Remove unused variables. This code will be modified again for the new
Andrew Bartlett [Thu, 24 Mar 2005 03:35:51 +0000 (03:35 +0000)]
r6025: Remove unused variables.  This code will be modified again for the new
cli_credentials code shortly.

Andrew Bartlett
(This used to be commit 13d09c8e9a50ae265059e4a0d92a07c651018a6c)

13 years agor6024: Some of the ordering constraints on the popt callbacks were getting
Andrew Bartlett [Thu, 24 Mar 2005 03:32:25 +0000 (03:32 +0000)]
r6024: Some of the ordering constraints on the popt callbacks were getting
painful, so don't call lp_*() functions until the post stage (rather
than in the cli_credentails_init(), which is called in the pre stage),
and don't open the secrets.ldb looking for the machine account details
until we actually need them (well after popt is done, and we know we have the other things right).

Set the domain and realm, as well as the account and password for -P
(fetch machine password) operation.

Allow NETLOGON credentials to be stored in this structure - will allow
SCHANNEL to be made more generic.

Clarify why we don't do special checks for NULL pointers, particularly
in the anonymous check (it indicates a programmer error, not a
run-time condition).

Also make lib/credentials.c a little more consistant.

Andrew Bartlett
(This used to be commit 730e6056b730c15008772c30cd6f7c03fb6b7e5f)

13 years agor6019: Add IDL and server side code for Test_DoublePointer
Jelmer Vernooij [Thu, 24 Mar 2005 00:58:52 +0000 (00:58 +0000)]
r6019: Add IDL and server side code for Test_DoublePointer
(This used to be commit 0559f22bbe854b7d5e15db471e51264cce413e6f)

13 years agor6018: Add idl and server side for Test_Surrounding
Jelmer Vernooij [Thu, 24 Mar 2005 00:56:53 +0000 (00:56 +0000)]
r6018: Add idl and server side for Test_Surrounding
(This used to be commit ed11601aef11df35f30b10e422e7113976dc6f26)

13 years agor6015: Add testprogs/ directory and original rpcecho sources
Jelmer Vernooij [Wed, 23 Mar 2005 23:52:38 +0000 (23:52 +0000)]
r6015: Add testprogs/ directory and original rpcecho sources
( from tridges junkcode at )
(This used to be commit e33397f383342d91326a5c2939c5213a5fc5d9cd)

13 years agor6010: Change the testing order, so we test all transports for each binding
Andrew Bartlett [Wed, 23 Mar 2005 22:15:48 +0000 (22:15 +0000)]
r6010: Change the testing order, so we test all transports for each binding
option, rather than all binding options for each transport.

This means that we get to most of the tests earlier, with at least
some binding options.  (And allows us to have some confidence before
waiting for an RPC-SAMR test to finish with bigendian).

Andrew Bartlett
(This used to be commit 5c3e4df804e38037d0337e8ef288127d6cdda28a)

13 years agor6000: add some notes about the cases where compression (or what ever this is)
Stefan Metzmacher [Wed, 23 Mar 2005 19:24:11 +0000 (19:24 +0000)]
r6000: add some notes about the cases where compression (or what ever this is)
is used, in the reply.

(This used to be commit 618dadb7ef092af0f2c13c2e67874041f54f4e98)

13 years agor5999: ups, remove the testvalue that I used against my w2k3 server
Stefan Metzmacher [Wed, 23 Mar 2005 18:55:12 +0000 (18:55 +0000)]
r5999: ups, remove the testvalue that I used against my w2k3 server

(This used to be commit 3d3e09af16c4f9a6bc8f6ae615f744a04f352ed0)

13 years agor5998: I was wrong with the highwater mark...
Stefan Metzmacher [Wed, 23 Mar 2005 18:54:06 +0000 (18:54 +0000)]
r5998: I was wrong with the highwater mark...

I think I now understand how it works:-)

(This used to be commit f8add2e66a56896d9bb18991091e1b17c29910b1)

13 years agor5992: Rename schannel.c -> schannel_sign.c. The rest of the schannel code
Andrew Bartlett [Wed, 23 Mar 2005 09:05:40 +0000 (09:05 +0000)]
r5992: Rename schannel.c -> schannel_sign.c.  The rest of the schannel code
(from librpc) will be moved into schannel.c soon.

Andrew Bartlett
(This used to be commit d6c80ff74b0550641c253316b37f1050c207791c)

13 years agor5989: Display authentication information (list of available auth protocols
Jelmer Vernooij [Wed, 23 Mar 2005 01:42:29 +0000 (01:42 +0000)]
r5989: Display authentication information (list of available auth protocols
+ principal names per endpoint) to gepdump. Still need to fix memory management
in the GTK+ utilities...
(This used to be commit b48a0af0b0fbf1234627ec785699896a44b23e75)

13 years agor5988: Fix the -P option (use machine account credentials) to use the Samba4
Andrew Bartlett [Wed, 23 Mar 2005 01:30:43 +0000 (01:30 +0000)]
r5988: Fix the -P option (use machine account credentials) to use the Samba4
secrets system, and not the old system from Samba3.

This allowed the code from auth_domain to be shared - we now only
lookup the secrets.ldb in lib/credentials.c.

In order to link the resultant binary, samdb_search() has been moved
from deep inside rpc_server into lib/gendb.c, along with the existing
gendb_search_v().  The vast majority of this patch is the simple
rename that followed,

(Depending on the whole SAMDB for just this function seemed pointless,
and brought in futher dependencies, such as smbencrypt.c).

Andrew Bartlett
(This used to be commit e13c671619bd290a8b3cae8555cb281a9a185ee0)

13 years agor5987: Add credentials callback for gtk+. The gtk+ apps now no longer
Jelmer Vernooij [Wed, 23 Mar 2005 01:02:29 +0000 (01:02 +0000)]
r5987: Add credentials callback for gtk+. The gtk+ apps now no longer
ask for a password when kerberos is being used.
(This used to be commit 642ec7cbef6d392b49ed0fe86d1816d4953e30ad)

13 years agor5986: Fix the build. Metze, could you please verify that this fix is correct?
Jelmer Vernooij [Wed, 23 Mar 2005 01:00:23 +0000 (01:00 +0000)]
r5986: Fix the build. Metze, could you please verify that this fix is correct?
(This used to be commit f3006e623bcf65a05238fbd3362ee958b948e70b)

13 years agor5985: Actually adding auth_domain.c in -r 5983 would probably have been a
Andrew Bartlett [Wed, 23 Mar 2005 00:15:41 +0000 (00:15 +0000)]
r5985: Actually adding auth_domain.c in -r 5983 would probably have been a
good idea....

Andrew Bartlett
(This used to be commit 84b566a36bbe7101c5fbd90c131b13e6c259c990)

13 years agor5984: Add index and attributes to default ldif for secrets.ldb
Andrew Bartlett [Wed, 23 Mar 2005 00:07:21 +0000 (00:07 +0000)]
r5984: Add index and attributes to default ldif for secrets.ldb

Andrew Bartlett
(This used to be commit 41dea45892362c4b25a93d8719fb7843485a7b98)

13 years agor5983: Start support for being a domain member in Samba4.
Andrew Bartlett [Wed, 23 Mar 2005 00:05:44 +0000 (00:05 +0000)]
r5983: Start support for being a domain member in Samba4.

This adds the auth_domain module to the auth subsystem, and cleans up
some small details around the join process (ensuring all the right
info is in the DB).

Andrew Bartlett
(This used to be commit 858cbfb8210239aa85a01da95e5beb9546a998a5)