samba.git
11 years agoWhatsnew
Günther Deschner [Tue, 8 Apr 2008 00:14:44 +0000 (02:14 +0200)]
Whatsnew
(This used to be commit 5cb480a664938d93d6cd059c78da9bc78eb58dcb)

11 years agoRemove unused variable.
James Peach [Mon, 7 Apr 2008 22:28:10 +0000 (15:28 -0700)]
Remove unused variable.
(This used to be commit 3ed2c65bde0c2e5ad10cf777dae8a2d3e626a42c)

11 years agoFix Kerberos interop with Mac OS X 10.5 clients.
Bill Ricker [Mon, 7 Apr 2008 22:02:56 +0000 (15:02 -0700)]
Fix Kerberos interop with Mac OS X 10.5 clients.

Ignore optional req_flags. Use the Kerberos mechanism OID negotiated
with the client rather than hardcoding OID_KERBEROS5_OLD.
(This used to be commit 59a2bcf30fef14ecc826271862b645dd3a61cb48)

11 years agoUse bool for BOOL and true/false for True/False. We need lowercase
James Peach [Mon, 7 Apr 2008 22:00:41 +0000 (15:00 -0700)]
Use bool for BOOL and true/false for True/False. We need lowercase
bool to get the declarations picked up by the prototype parser.
(This used to be commit fd168e7b5065ba15b1cf56522b6810b8e6fdd7d5)

11 years agodbwrap: fix more "tdb_chainunlock failed" messages
Michael Adam [Mon, 7 Apr 2008 21:36:29 +0000 (23:36 +0200)]
dbwrap: fix more "tdb_chainunlock failed" messages

TALLOC_FREE(rec) before transaction_cancel also in dbwrap_trans_delete().

Michael
(This used to be commit 04cd914a1f12691d27ddc67887a757cd813848a7)

11 years agowinbindd: fix break out early condition in fill_grent_mem().
Michael Adam [Mon, 7 Apr 2008 14:38:14 +0000 (16:38 +0200)]
winbindd: fix break out early condition in fill_grent_mem().

if (!&new_glist) would always be skipped, if (new_glist == NULL) is
what must have been meant...

Michael
(This used to be commit c1b60cdecff2a53f0a75a432a1ad7730eb734908)

11 years agoOnly cache password policy results that worked, otherwise we
Bo Yang [Mon, 7 Apr 2008 13:51:42 +0000 (09:51 -0400)]
Only cache password policy results that worked, otherwise we
cannot login until the cache expires even if a connection
to a DC has been restored.
(This used to be commit 8671f9767d7d93a86712741303d6046937c3aae8)

11 years agosmbd: make it possible to change the write time delay for testing
Stefan Metzmacher [Mon, 7 Apr 2008 07:27:22 +0000 (09:27 +0200)]
smbd: make it possible to change the write time delay for testing

metze
(This used to be commit df8c100c2b53575a0d425a2daf52e2d59904746a)

11 years agosmbd: make it possible to disable get_file_infos() on searches
Stefan Metzmacher [Mon, 7 Apr 2008 07:21:19 +0000 (09:21 +0200)]
smbd: make it possible to disable get_file_infos() on searches

metze
(This used to be commit 404a865a34c3a7c67131b3f99e92c11b2abe3e39)

11 years agolocking: combine get_delete_on_close_flag() and get_write_time() into get_file_infos()
Stefan Metzmacher [Tue, 1 Apr 2008 09:40:23 +0000 (11:40 +0200)]
locking: combine get_delete_on_close_flag() and get_write_time() into get_file_infos()

This means we need to fetch the record only once.

metze
(This used to be commit 4130b873291d39e363184fe4e38dc1f24ebe5056)

11 years agoselftest: samba3 passes BASE-DELAYWRITE
Stefan Metzmacher [Wed, 12 Mar 2008 17:26:43 +0000 (18:26 +0100)]
selftest: samba3 passes BASE-DELAYWRITE

metze
(This used to be commit 5df34634317633820993c9ef924d694a8fe1c4fe)

11 years agosmbd: implement the strange write time update logic
Stefan Metzmacher [Wed, 12 Mar 2008 14:39:38 +0000 (15:39 +0100)]
smbd: implement the strange write time update logic

We now never call file_ntimes() directly, every update
is done via smb_set_file_time().

This let samba3 pass the BASE-DELAYWRITE test.

The write time is only updated 2 seconds after the
first write() on any open handle to the current time
(not the time of the first write).

Each handle which had write requests updates the write
time to the current time on close().

If the write time is set explicit via setfileinfo or setpathinfo
the write time is visible directly and a following close
on the same handle doesn't update the write time.

metze
(This used to be commit 2eab212ea2e1bfd8fa716c2c89b2c042f7ba12ea)

11 years agolocking: store the write time in the locking.tdb
Stefan Metzmacher [Wed, 12 Mar 2008 14:32:47 +0000 (15:32 +0100)]
locking: store the write time in the locking.tdb

This is needed to implement the strange write time update
logic later. We need to store 2 time timestamps to
distinguish between the time the file system had before
the first client opened the file and a forced timestamp update.

metze
(This used to be commit 6aaa2ce0eeb46f6735ec984a2e7aadde7a7f456d)

11 years agoFix an uninitialized variable
Volker Lendecke [Mon, 7 Apr 2008 10:19:25 +0000 (12:19 +0200)]
Fix an uninitialized variable
(This used to be commit 8b2d9ee8c54ed84f83fdecf04e656dd66b622abb)

11 years agoincrease log level for this failed setsockopt call. EINVAL is a normal error on Solar...
Björn Jacke [Mon, 7 Apr 2008 09:22:14 +0000 (11:22 +0200)]
increase log level for this failed setsockopt call. EINVAL is a normal error on Solaris when we do this on an already resetted connection.
(This used to be commit 42bc4ff7fd6bfc92bde015ae8f3a9fb62d443cd5)

11 years agoFix bug 5375
Volker Lendecke [Mon, 7 Apr 2008 08:19:25 +0000 (10:19 +0200)]
Fix bug 5375

Thanks to Moskvin for testing
(This used to be commit d3c31aa36c451f0a19496cd33c0b055b466e6b09)

11 years agoFix a misleading debug message
Volker Lendecke [Mon, 7 Apr 2008 08:18:36 +0000 (10:18 +0200)]
Fix a misleading debug message
(This used to be commit 494b32197f0872b115f0cd1a35421d00a89360a6)

11 years agonet_rpc: let get_user_sids() use wbcLookupName(), wbcGidToSid() and wbcGetGroups()
Stefan Metzmacher [Wed, 2 Apr 2008 06:03:11 +0000 (08:03 +0200)]
net_rpc: let get_user_sids() use wbcLookupName(), wbcGidToSid() and wbcGetGroups()

metze
(This used to be commit 31375c02631cb3f37a8bbd4ea17d3ef69c4d07bf)

11 years agonet_rpc: let get_user_tokens() use wbcListUsers()
Stefan Metzmacher [Wed, 2 Apr 2008 06:02:02 +0000 (08:02 +0200)]
net_rpc: let get_user_tokens() use wbcListUsers()

metze
(This used to be commit 4f712452e911db1f0aa74e3ccd636c1a18bdf9ef)

11 years agowbinfo: make use of wbcGetGroups()
Stefan Metzmacher [Sun, 6 Apr 2008 09:58:58 +0000 (11:58 +0200)]
wbinfo: make use of wbcGetGroups()

metze
(This used to be commit c78f4dc043523842cf42f1a3fd4e8f3855518efa)

11 years agolibwbclient: add wbcGetGroups()
Stefan Metzmacher [Sun, 6 Apr 2008 09:55:57 +0000 (11:55 +0200)]
libwbclient: add wbcGetGroups()

metze
(This used to be commit 596d030b976102e7476a2460fce355914c4e8210)

11 years agoFix a C++ warning
Volker Lendecke [Sun, 6 Apr 2008 10:26:15 +0000 (12:26 +0200)]
Fix a C++ warning
(This used to be commit c274fe7d21badb42ca8d4d1115ae6bffdb19485f)

11 years agoRemove external refs to winbindd_fd
Volker Lendecke [Sun, 6 Apr 2008 10:26:01 +0000 (12:26 +0200)]
Remove external refs to winbindd_fd
(This used to be commit 18bf2b2028e64403a79b7cc06d3185a3e526d97d)

11 years agowbcAllocateGid returns a gid_t, not a uid_t
Volker Lendecke [Sun, 6 Apr 2008 09:27:36 +0000 (11:27 +0200)]
wbcAllocateGid returns a gid_t, not a uid_t
(This used to be commit 3130fb7b32285b8501f5ee8cbc62b478c09cccd3)

11 years agoRe-run "make idl"
Volker Lendecke [Sat, 5 Apr 2008 22:47:53 +0000 (00:47 +0200)]
Re-run "make idl"
(This used to be commit 26218826c327d85c2ef8d0d1addaef24d249d6bf)

11 years agoWhen using plaintext ucs2 passwords clistr_push calls ucs2_align, which causes
Jeremy Allison [Fri, 4 Apr 2008 22:28:14 +0000 (15:28 -0700)]
When using plaintext ucs2 passwords clistr_push calls ucs2_align, which causes
the space taken by the unicode password to be one byte too
long (as we're on an odd byte boundary here). Reduce the
count by 1 to cope with this. Fixes smbclient against NetApp
servers which can't cope. Fix from
bryan.kolodziej@allenlund.com in bug #3840.
Jeremy.
(This used to be commit 1e7e7d86a1ae1cd2c3cc3de9f36b7326ad249b82)

11 years agoFix _samr_GetUserPwInfo() (to return more then just zeros).
Günther Deschner [Fri, 4 Apr 2008 10:00:26 +0000 (12:00 +0200)]
Fix _samr_GetUserPwInfo() (to return more then just zeros).

Guenther
(This used to be commit 624371ce32a7c0816963745059e743e5b3e92e2a)

11 years agoFix _samr_GetDomPwInfo (to return more then zeros).
Günther Deschner [Fri, 4 Apr 2008 09:59:32 +0000 (11:59 +0200)]
Fix _samr_GetDomPwInfo (to return more then zeros).

Guenther
(This used to be commit 1cde9579f10ab8c43c25dfd6e5c658c7653f9a37)

11 years agoFix bug #5372. With a large CUPS installation with a remote server, contacting
Jeremy Allison [Fri, 4 Apr 2008 18:14:09 +0000 (11:14 -0700)]
Fix bug #5372. With a large CUPS installation with a remote server, contacting
the server when searching for a name for the location and comment fields can
take so much time the client times out. When searching for a name we don't
use these fields anyway, so add a function get_a_printer_search() which
doesn't contact the CUPS server.
Jeremy.
(This used to be commit 92d9f20852d5384e92a93dd0b051034718840ca8)

11 years agonet_rpc_registry: return available error code on failure in deletevalue.
Michael Adam [Fri, 4 Apr 2008 15:52:35 +0000 (17:52 +0200)]
net_rpc_registry: return available error code on failure in deletevalue.

Michael
(This used to be commit 0dc9840cefb08b2732d294eb45508ce687ded324)

11 years agonet_rpc_registry: consistently return error upon wrong use.
Michael Adam [Fri, 4 Apr 2008 15:50:41 +0000 (17:50 +0200)]
net_rpc_registry: consistently return error upon wrong use.

Michael
(This used to be commit 26e3d71cd0b2d1bb31c50627ea71267328d52448)

11 years agonet: change split_hive_key() to properly allocate subkeyname
Michael Adam [Fri, 4 Apr 2008 15:24:53 +0000 (17:24 +0200)]
net: change split_hive_key() to properly allocate subkeyname

instead of returning a pointer into another string.

Michael
(This used to be commit 68d08ecf92be3444b759300237b2b7cf5238d022)

11 years agonet_rpc_registry: use split_hive_key to normalize hive befor open.
Michael Adam [Fri, 4 Apr 2008 14:46:01 +0000 (16:46 +0200)]
net_rpc_registry: use split_hive_key to normalize hive befor open.

THis allows to specify keys in the form "HKLM/Software/samba",
i.e. "/" instead of "\\".

Michael
(This used to be commit 61d09caef340d2fee303e429f6f25d011cb3023c)

11 years agonet_rpc_registry: use utility function print_registry_value().
Michael Adam [Fri, 4 Apr 2008 11:30:49 +0000 (13:30 +0200)]
net_rpc_registry: use utility function print_registry_value().

Michael
(This used to be commit 3d039b518f04b9dd3c87b9af2ec816e049554e27)

11 years agonet_rpc_registy: use function print_registry_key
Michael Adam [Fri, 4 Apr 2008 11:26:03 +0000 (13:26 +0200)]
net_rpc_registy: use function print_registry_key

Michael
(This used to be commit cc1da3ee2c369181efa6d150c966571d0aff0728)

11 years agonet_registry: split utility function of common interest out into util module.
Michael Adam [Fri, 4 Apr 2008 11:21:03 +0000 (13:21 +0200)]
net_registry: split utility function of common interest out into util module.

Michael
(This used to be commit 3bf890783fadd245c59280173627a6caca2dbefe)

11 years agomapping_tdb: fix enumeration of mappings.
Michael Adam [Fri, 4 Apr 2008 14:56:02 +0000 (16:56 +0200)]
mapping_tdb: fix enumeration of mappings.

db->traverse_read returns the number of traversed object on success.

Michael
(This used to be commit 2be2188a97060f04c2dea3ca9ed0fd3db0b3df7c)

11 years agoMakefile: reassign reg_init_basic.o to REG_BASE_OBJ, where it belongs...
Michael Adam [Fri, 4 Apr 2008 11:07:01 +0000 (13:07 +0200)]
Makefile: reassign reg_init_basic.o to REG_BASE_OBJ, where it belongs...

Michael
(This used to be commit 7b16cb1023abd4fb2b2f08cf723d38c8c6ae68a0)

11 years agomapping.tdb: fix creation of entries with GROUP_PREFIX
Michael Adam [Fri, 4 Apr 2008 13:27:51 +0000 (15:27 +0200)]
mapping.tdb: fix creation of entries with GROUP_PREFIX

Macro is no expanded inside literal string.

Michael
(This used to be commit 872a3d3d38287ab9cbb260d05777481d94e03539)

11 years agoUse sid_array_from_info3 in lookup_usergroups_cached().
Günther Deschner [Fri, 4 Apr 2008 00:53:40 +0000 (02:53 +0200)]
Use sid_array_from_info3 in lookup_usergroups_cached().

Guenther
(This used to be commit 65b4cb20ea3fb806cfd50281e08f32bea70fafce)

11 years agoAlways uppercase cli->srv_name_slash.
Günther Deschner [Thu, 3 Apr 2008 23:44:43 +0000 (01:44 +0200)]
Always uppercase cli->srv_name_slash.

Not that I think it is of any importance...

Guenther
(This used to be commit 352f8440c74bc22416e21783e1dc5fecf5869902)

11 years agoRemove some dead code in rpcclient.
Günther Deschner [Thu, 3 Apr 2008 23:44:16 +0000 (01:44 +0200)]
Remove some dead code in rpcclient.

Guenther
(This used to be commit c7ae1a9b53ef578cf4dfdf8e05915817c69896b5)

11 years agoMove rpccli_try_samr_connects out of rpcclient.
Günther Deschner [Thu, 3 Apr 2008 23:40:29 +0000 (01:40 +0200)]
Move rpccli_try_samr_connects out of rpcclient.

Guenther
(This used to be commit f550cdb6f240830ee1e3a2dfe5f4128bca0cf836)

11 years agoFix pam_winbind macros.
Günther Deschner [Thu, 3 Apr 2008 15:23:22 +0000 (17:23 +0200)]
Fix pam_winbind macros.

Guenther
(This used to be commit 37091859126167e84e55afe8a32025ac0f65065e)

11 years agoUse pwb_context in pam_winbind.
Günther Deschner [Thu, 3 Apr 2008 13:41:26 +0000 (15:41 +0200)]
Use pwb_context in pam_winbind.

Guenther
(This used to be commit bf960f57e7adf09cdf096f2c72065ea1ff8b0daa)

11 years agoAdd _pam_winbind_init/free_context.
Günther Deschner [Thu, 3 Apr 2008 11:23:34 +0000 (13:23 +0200)]
Add _pam_winbind_init/free_context.

Guenther
(This used to be commit d62676cf886d910334b3d6f7ce0147b75ef53aec)

11 years agoAdd pwb_context to pam_winbind.h.
Günther Deschner [Thu, 3 Apr 2008 11:19:46 +0000 (13:19 +0200)]
Add pwb_context to pam_winbind.h.

Guenther
(This used to be commit fe8acb064433b286938e0b572ca1faa8a54414b7)

11 years agoMake more functions in pam_winbind static.
Günther Deschner [Thu, 3 Apr 2008 11:06:14 +0000 (13:06 +0200)]
Make more functions in pam_winbind static.

Guenther
(This used to be commit ea2175ee0e6288ccb132e86b9dd0bf8a0e4169c9)

11 years agowbinfo: use wbcLookupNames()
Stefan Metzmacher [Wed, 2 Apr 2008 04:10:04 +0000 (06:10 +0200)]
wbinfo: use wbcLookupNames()

metze
(This used to be commit 9d0e5a13215d4904084e81fde6098c70ee4d4636)

11 years agowbinfo: use wbcLookupRids()
Stefan Metzmacher [Wed, 2 Apr 2008 04:03:48 +0000 (06:03 +0200)]
wbinfo: use wbcLookupRids()

metze
(This used to be commit 046b26b763b16362dd662a77b2434641bf583bc2)

11 years agowbinfo: use wbcLookupSid()
Stefan Metzmacher [Wed, 2 Apr 2008 03:26:36 +0000 (05:26 +0200)]
wbinfo: use wbcLookupSid()

metze
(This used to be commit b917be4986bd55aeffae03b08cf476ea6302fa26)

11 years agowbinfo: catch NULL domain string as in other places
Stefan Metzmacher [Wed, 2 Apr 2008 04:02:45 +0000 (06:02 +0200)]
wbinfo: catch NULL domain string as in other places

metze
(This used to be commit ff4611832a0b498b83590279a7153e606a4720f5)

11 years agoregistry: remove parameter checks from smbconf backend: they are in libsmbconf.
Michael Adam [Thu, 3 Apr 2008 13:29:25 +0000 (15:29 +0200)]
registry: remove parameter checks from smbconf backend: they are in libsmbconf.

Michael
(This used to be commit 118cf3813336122a060916848e37d2d5d25bff92)

11 years agolibsmbconf: move initialization of registry value down after error checks.
Michael Adam [Thu, 3 Apr 2008 13:16:01 +0000 (15:16 +0200)]
libsmbconf: move initialization of registry value down after error checks.

Michael
(This used to be commit 2a8029985f9bde4da8ca20bc24d937150eab444c)

11 years agoFix rpccli_lsa_lookup_sids_noalloc.
Günther Deschner [Wed, 2 Apr 2008 22:23:50 +0000 (00:23 +0200)]
Fix rpccli_lsa_lookup_sids_noalloc.

When looking up e.g. a trusted doamin account, there is just no name.

Michael, please check.

Guenther
(This used to be commit ea3cfadc2504c891b4784719bd8e6debcc38c879)

11 years agoAdd NT_STATUS_RPC_CANNOT_SUPPORT.
Günther Deschner [Wed, 2 Apr 2008 13:26:27 +0000 (15:26 +0200)]
Add NT_STATUS_RPC_CANNOT_SUPPORT.

Guenther
(This used to be commit 9e15ce03ca66a0b5ffdb39dd2faaad6e0f967e31)

11 years agoFix trusted users on a DC that uses the old idmap syntax. There was no default backen...
Simo Sorce [Tue, 1 Apr 2008 22:25:47 +0000 (18:25 -0400)]
Fix trusted users on a DC that uses the old idmap syntax. There was no default backend therefore on IDs were mapped by default.
(This used to be commit f6069126e5e6d239b1ae00e897a420227f923e3f)

11 years agoFix MSDFS bug noticed by Ofir Azoulay <Ofir.Azoulay@expand.com>.
Jeremy Allison [Wed, 2 Apr 2008 18:23:36 +0000 (11:23 -0700)]
Fix MSDFS bug noticed by Ofir Azoulay <Ofir.Azoulay@expand.com>.
There is no reason to ensure the target host is ourselves, and
this breaks MS clients in some cases.
Jeremy.
(This used to be commit c19fdf43d16ce9fba3e8e12e6192bac31837715e)

11 years agoFix "net rpc trustdom establish" for win2k8 trusts.
Günther Deschner [Wed, 2 Apr 2008 10:29:24 +0000 (12:29 +0200)]
Fix "net rpc trustdom establish" for win2k8 trusts.

When establishing trusts to a windows 2008 dc, the NetServerEnum2 RAP call fails
with some exotic RAP failure. Let's just try a netlogon getdcname call in
that case to convince ourselve we're talking to a proper machine.

Rafael, looks ok?

Guenther
(This used to be commit b12edbeffee1f7d1fd971cde9189e5137ddeb35b)

11 years agoApply some const in clirap.
Günther Deschner [Wed, 2 Apr 2008 10:23:07 +0000 (12:23 +0200)]
Apply some const in clirap.

Guenther
(This used to be commit 8a1a9f967db25d3928f19e46d60af249f934f323)

11 years agoSome fixes for netdomjoin-gui and support for browsing/joining OUs.
Günther Deschner [Wed, 2 Apr 2008 09:18:10 +0000 (11:18 +0200)]
Some fixes for netdomjoin-gui and support for browsing/joining OUs.

Guenther
(This used to be commit 4714bae0dbbb2ad010c2929f83de6bca84cfac46)

11 years agoMake sure to hand down the domain name in libnetapi NetUnjoinDomain.
Günther Deschner [Wed, 2 Apr 2008 09:14:15 +0000 (11:14 +0200)]
Make sure to hand down the domain name in libnetapi NetUnjoinDomain.

Guenther
(This used to be commit 0058ab30de943f134792e3d66051206086987110)

11 years agoFix NETLOGON credential chain with Windows 2008 all over the place.
Günther Deschner [Wed, 2 Apr 2008 00:29:48 +0000 (02:29 +0200)]
Fix NETLOGON credential chain with Windows 2008 all over the place.

In order to avoid receiving NT_STATUS_DOWNGRADE_DETECTED from a w2k8
netr_ServerAuthenticate2 reply, we need to start with the AD netlogon negotiate
flags everywhere (not only when running in security=ads). Only for NT4 we need
to do a downgrade to the returned negotiate flags.

Tested with w2k8, w2ksp4, w2k3r2 and nt4sp6.

Guenther
(This used to be commit 0970369ca0cb9ae465cff40e5c75739824daf1d0)

11 years agosmbd: always close the base_fsp even if the real close returned an error
Stefan Metzmacher [Tue, 1 Apr 2008 16:18:38 +0000 (18:18 +0200)]
smbd: always close the base_fsp even if the real close returned an error

Otherwise we may end up with share mode entry without an open file.

Volker, Jeremy: please check...

metze
(This used to be commit 547eacf6058d2bc5b41b266b70f8f4747aca4eae)

11 years agowbinfo: use wbcInterfaceDetails()
Stefan Metzmacher [Fri, 28 Mar 2008 15:55:53 +0000 (16:55 +0100)]
wbinfo: use wbcInterfaceDetails()

metze
(This used to be commit ff87260f1268d190170608b0808c191ef8f3e942)

11 years agolibwbclient: add wbcInterfaceDetails()
Stefan Metzmacher [Fri, 28 Mar 2008 15:52:18 +0000 (16:52 +0100)]
libwbclient: add wbcInterfaceDetails()

metze
(This used to be commit fee3806326b9ba214e35868271e6481c0c8b9c4b)

11 years agolibwbclient: use WBC_ERROR_IS_OK() in BAIL_ON_WBC_ERROR() macro
Stefan Metzmacher [Mon, 31 Mar 2008 10:01:24 +0000 (12:01 +0200)]
libwbclient: use WBC_ERROR_IS_OK() in BAIL_ON_WBC_ERROR() macro

metze
(This used to be commit de2e8d5db93d32e5ebf04a2018a08f766eb9a233)

11 years agotest: add diagnostic message to net_registry test.
Michael Adam [Tue, 1 Apr 2008 13:51:51 +0000 (15:51 +0200)]
test: add diagnostic message to net_registry test.

Michael
(This used to be commit c04a234f8f6fbdf8e54c69414024d84aa71fec45)

11 years agotest: fix net_registry test "set value to different type" to track error count
Michael Adam [Tue, 1 Apr 2008 13:50:24 +0000 (15:50 +0200)]
test: fix net_registry test "set value to different type" to track error count

missing backslash in call... :-}

Michael
(This used to be commit 8f0c25f01f11857d24556346dc2758549919eba3)

11 years agotest: some cosmetics to net_registry tests.
Michael Adam [Tue, 1 Apr 2008 13:43:35 +0000 (15:43 +0200)]
test: some cosmetics to net_registry tests.

Michael
(This used to be commit dba9db5ae6581df18591eebd19d3649bed0d9367)

11 years agotest: fix net_registry tests to correctly capture output of commands inside one test
Michael Adam [Tue, 1 Apr 2008 13:35:12 +0000 (15:35 +0200)]
test: fix net_registry tests to correctly capture output of commands inside one test

so that failure output is not clobbered by  output of previous
successful commands.

Michael
(This used to be commit cb3dafe5fd8867b000e01979d4232968d994d376)

11 years agotest: fix use of printf in net_registry tests.
Michael Adam [Tue, 1 Apr 2008 13:19:05 +0000 (15:19 +0200)]
test: fix use of printf in net_registry tests.

actually 'printf "%s\n"' is the proper replacement of 'echo -e'

Michael
(This used to be commit 388a40931f1559b134317ef0c85c7cf2598e17fe)

11 years agopo/genmsg: be more portable, use 'printf "%s"' instead of 'echo -n'
Michael Adam [Tue, 1 Apr 2008 13:55:59 +0000 (15:55 +0200)]
po/genmsg: be more portable, use 'printf "%s"' instead of 'echo -n'

Michael
(This used to be commit 0bd50e450baf633ea9d653341f3ce9d81bfdd83f)

11 years agomkversion: be more portable, use 'print "%s"' instead of 'echo -n'
Michael Adam [Tue, 1 Apr 2008 13:54:34 +0000 (15:54 +0200)]
mkversion: be more portable, use 'print "%s"' instead of 'echo -n'

Michael
(This used to be commit 7a23dab1eaf3116079a89cdf348cabc659608031)

11 years agoinstallswat: be more portable, use 'printf "%s"' instead of 'echo -n'
Michael Adam [Tue, 1 Apr 2008 13:53:54 +0000 (15:53 +0200)]
installswat: be more portable, use 'printf "%s"' instead of 'echo -n'

Michael
(This used to be commit 8b015c91c9b10c208fe61cefd71ddc9f4fcbec61)

11 years agoconfigure: be more portable, use 'printf "%s"' instead of "echo -n"
Michael Adam [Tue, 1 Apr 2008 13:52:54 +0000 (15:52 +0200)]
configure: be more portable, use 'printf "%s"' instead of "echo -n"

Michael
(This used to be commit 06dfb0cf7cd39e1072534fc32e79a4b4f6e49cb6)

11 years agotest: be more portable. replace 'echo -n' by 'printf "%s"' in test_functions.sh
Michael Adam [Tue, 1 Apr 2008 11:45:55 +0000 (13:45 +0200)]
test: be more portable. replace 'echo -n' by 'printf "%s"' in test_functions.sh

Michael
(This used to be commit c0c41184277044eb856f91c025f645c198cac188)

11 years agotest: be more portable: replace 'echo -n' by 'printf "%s"' in selftest.sh
Michael Adam [Tue, 1 Apr 2008 11:43:20 +0000 (13:43 +0200)]
test: be more portable: replace 'echo -n' by 'printf "%s"' in selftest.sh

Michael
(This used to be commit b6122406fe938fdaf373ff45214db79de06eb989)

11 years agosmbd: ignore nttrans renames as w2k3 does
Stefan Metzmacher [Tue, 1 Apr 2008 10:29:12 +0000 (12:29 +0200)]
smbd: ignore nttrans renames as w2k3 does

This lets us pass the RAW-RENAME test.

metze

Signed-off-by: Michael Adam <obnox@samba.org>
(This used to be commit 2d50a1fef022023588e9963131951f8f3e4c7c23)

11 years agoaccount_pol: use db_open_trans()
Stefan Metzmacher [Tue, 1 Apr 2008 09:26:29 +0000 (11:26 +0200)]
account_pol: use db_open_trans()

metze
(This used to be commit 888c2802b7bda92baae2dd0c1596f5e04bc3bfaa)

11 years agoaccount_pol: use dbwrap_trans_store_uint32()
Stefan Metzmacher [Fri, 28 Mar 2008 19:04:35 +0000 (20:04 +0100)]
account_pol: use dbwrap_trans_store_uint32()

metze
(This used to be commit b1d63c8c1116f3429fb73aa6842105073385d1e8)

11 years agoConvert account_pol.tdb to dbwrap
Volker Lendecke [Fri, 28 Mar 2008 11:09:56 +0000 (12:09 +0100)]
Convert account_pol.tdb to dbwrap

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 0b36871a0d795183f0e9dc78b654788b1988f06e)

11 years agodbwrap: fix a confusing "tdb_chainunlock failed" message
Stefan Metzmacher [Sun, 30 Mar 2008 11:11:22 +0000 (13:11 +0200)]
dbwrap: fix a confusing "tdb_chainunlock failed" message

Unlock before we cancel the transaction...

metze
(This used to be commit d70a8e9c413a7d3993e0d11db5ae9cbc7fdb12c7)

11 years agodbwrap: add dbwrap_trans_store_uint32()
Stefan Metzmacher [Fri, 28 Mar 2008 19:03:30 +0000 (20:03 +0100)]
dbwrap: add dbwrap_trans_store_uint32()

metze
(This used to be commit 9e739b4c99a9aba5c5bb58f3b6a9fb949e24c581)

11 years agoAdd dbwrap_trans_*_bystring
Volker Lendecke [Fri, 28 Mar 2008 11:02:28 +0000 (12:02 +0100)]
Add dbwrap_trans_*_bystring

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 2cf2684a11027431e6a93992413a5a5a697a4ba0)

11 years agoConvert dbwrap_trans_delete to NTSTATUS
Volker Lendecke [Fri, 28 Mar 2008 10:57:54 +0000 (11:57 +0100)]
Convert dbwrap_trans_delete to NTSTATUS

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit dead193f46c2b19955ab3e5ac5ba343694f4858a)

11 years agoConvert dbwrap_trans_store to NTSTATUS
Volker Lendecke [Fri, 28 Mar 2008 10:53:00 +0000 (11:53 +0100)]
Convert dbwrap_trans_store to NTSTATUS

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 5f4de856af1abe63b13059bbe1615cb5877770d0)

11 years agoAdd dbwrap_[fetch|store]_uint32
Volker Lendecke [Fri, 28 Mar 2008 08:42:37 +0000 (09:42 +0100)]
Add dbwrap_[fetch|store]_uint32

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit f1dd915ce802645166e0c8fc79d18d5ad41cfe7a)

11 years agosharesec: use db_open_trans()
Stefan Metzmacher [Fri, 28 Mar 2008 07:27:11 +0000 (08:27 +0100)]
sharesec: use db_open_trans()

metze
(This used to be commit 1c59142ccc46616c10b98c51601361f203d542d6)

11 years agoConvert share_info.tdb to dbwrap
Volker Lendecke [Thu, 27 Mar 2008 22:10:57 +0000 (23:10 +0100)]
Convert share_info.tdb to dbwrap
(This used to be commit bc9b4c43b8824cd53f9ab613bcbb94cd5193f43e)

11 years agomapping_tdb: use the correct sid for the key creation
Stefan Metzmacher [Fri, 28 Mar 2008 11:20:06 +0000 (12:20 +0100)]
mapping_tdb: use the correct sid for the key creation

metze
(This used to be commit 0d221a3f0a948e173b22585b7833a5441d860a57)

11 years agomapping_tdb: use db_open_trans()
Stefan Metzmacher [Thu, 27 Mar 2008 16:39:58 +0000 (17:39 +0100)]
mapping_tdb: use db_open_trans()

metze
(This used to be commit 16d18df0d069aec645c41e38e8c926ccdaac9388)

11 years agoProtect group_mapping.tdb ops with transactions
Volker Lendecke [Thu, 27 Mar 2008 16:10:31 +0000 (17:10 +0100)]
Protect group_mapping.tdb ops with transactions

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit d702ed73c1b986ded9deaa3abed92c39d71949fc)

11 years agopdb_tdb: use != 0 instead off == -1 for dbwrap functions
Stefan Metzmacher [Thu, 27 Mar 2008 15:55:35 +0000 (16:55 +0100)]
pdb_tdb: use != 0 instead off == -1 for dbwrap functions

metze
(This used to be commit d4826a01369c00b5e83cd62c2412a4eb826e216d)

11 years agopassdb: guard pdb_generate_sam_sid() with a transaction
Stefan Metzmacher [Tue, 1 Apr 2008 09:02:01 +0000 (11:02 +0200)]
passdb: guard pdb_generate_sam_sid() with a transaction

This prevents possible races with some dbwrap backends

metze
(This used to be commit 9322442510d9c2cf16c25f5109fe81b277c44881)

11 years agopassdb/secrets: add secrets_db_ctx() to get the db_context
Stefan Metzmacher [Tue, 1 Apr 2008 09:00:59 +0000 (11:00 +0200)]
passdb/secrets: add secrets_db_ctx() to get the db_context

metze
(This used to be commit 986bc7e8b260265da019b67ec751509eb589d24b)

11 years agoregdb: let regdb_fetch_keys() handle NULL and failure cases in the same way and return -1
Stefan Metzmacher [Tue, 1 Apr 2008 10:56:38 +0000 (12:56 +0200)]
regdb: let regdb_fetch_keys() handle NULL and failure cases in the same way and return -1

metze
(This used to be commit 983fd58805a429792fc8eaa816e2dd908643414e)

11 years agoregdb: get the seqnum before the record, to not miss something
Stefan Metzmacher [Tue, 1 Apr 2008 10:48:08 +0000 (12:48 +0200)]
regdb: get the seqnum before the record, to not miss something

metze
(This used to be commit c214107bd9bbf9b17936757437ec211d7de3048e)

11 years agoregdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
Stefan Metzmacher [Tue, 1 Apr 2008 10:38:54 +0000 (12:38 +0200)]
regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"

This is the fixed version of commit 5c28c74aa06a82559f498373b3d6e9892d5c2cbe.

metze
(This used to be commit 924acd7f695d7514b1a4628468137cf632c8f1f0)

11 years agotest: make registry tests more portable: protect some grep patterns in ' '.
Michael Adam [Tue, 1 Apr 2008 10:48:25 +0000 (12:48 +0200)]
test: make registry tests more portable: protect some grep patterns in ' '.

Michael
(This used to be commit 1cb3b2f065566f981f6cfb8b5efdfad7db49c719)