12 years agor22794: Add "debug_state" and "silent" to pam_winbind.conf template. Honor the silent
Günther Deschner [Fri, 11 May 2007 11:54:41 +0000 (11:54 +0000)]
r22794: Add "debug_state" and "silent" to pam_winbind.conf template. Honor the silent
argument when parsing pam configuration file options.

(This used to be commit 5b4a4df26f32fe1947a0c4fb741a4cb89e308f92)

12 years agor22787: More from Karolin: Make map_unix_group() static to net_sam.c, add "net
Volker Lendecke [Fri, 11 May 2007 08:59:01 +0000 (08:59 +0000)]
r22787: More from Karolin: Make map_unix_group() static to net_sam.c, add "net
sam unmapunixgroup"
(This used to be commit 55e2f35fad8bda3ff2c2ace5323ddeaee87d783e)

12 years agor22786: Some cleanup by Karolin Seeger: Remove unused pdb_find_alias, and change
Volker Lendecke [Fri, 11 May 2007 08:46:54 +0000 (08:46 +0000)]
r22786: Some cleanup by Karolin Seeger: Remove unused pdb_find_alias, and change
return values of some alias-releated pdb functions from BOOL to NTSTATUS

Thanks :-)
(This used to be commit 590d2164b3a33250410338771e160f6ebd1aa89d)

12 years agor22784: fixed change notify for delete on close
Andrew Tridgell [Fri, 11 May 2007 07:22:10 +0000 (07:22 +0000)]
r22784: fixed change notify for delete on close
(This used to be commit 6f52435a72427a8264096ac14bad54020c9d852b)

12 years agor22779: Patch for not prompting for password on cifs mounts when "sec=none"
Steve French [Thu, 10 May 2007 19:16:36 +0000 (19:16 +0000)]
r22779: Patch for not prompting for password on cifs mounts when "sec=none"
(This used to be commit 9af97d8ead85c05d08ee24727525894df5866630)

12 years agor22777: Fix for [Bug 4543] - POSIX ACL support on FreeBSD.
Michael Adam [Thu, 10 May 2007 13:31:15 +0000 (13:31 +0000)]
r22777: Fix for [Bug 4543] - POSIX ACL support on FreeBSD.

This adds vfs_posixacl to the list of static modules and
makes use of HAVE_ACL_GET_PERM_NP.

This is just a quick fix. FreeBSD acl support is still
hardcoded in, but actually this could be
detected in a unified test for freebsd, linux, *,
as suggested in the bugreport. This has still to be
checked and elaborated.

(This used to be commit af94654772f743f0c0b7809ff3f2ef019feb713a)

12 years agor22775: For the cluster code I've developed a wrapper around tdb to put different
Volker Lendecke [Thu, 10 May 2007 10:42:13 +0000 (10:42 +0000)]
r22775: For the cluster code I've developed a wrapper around tdb to put different
database backends in place dynamically.

The main abstractions are db_context and db_record, it should be mainly
self-describing, see include/dbwrap.h.  You open the db just as you would open
a tdb, this time with db_open(). If you want to fetch a record, just do the
db->fetch() call, if you want to do operations on it, you need to get it with

I added dbwrap_file.c (not heavily tested lately) as an example for what can
be done with that abstraction, uses a file per key. So if anybody is willing
to shape that up, we might have a chance on reiserfs again.... :-)

This abstraction works fine for brlock.tdb, locking.tdb, connections.tdb and
sessionid.tdb. It should work fine for the others as well, I just did not yet
get around to convert them.

If nobody loudly screams NO, then I will import the code that uses this soon.

(This used to be commit e9d7484ca246cfca4a1fd23be35edc2783136ebe)

12 years agor22773: - Clean up the the rest of the cruft from my earlier work on the readahead()
Derrell Lipman [Thu, 10 May 2007 02:48:22 +0000 (02:48 +0000)]
r22773: - Clean up the the rest of the cruft from my earlier work on the readahead()
  missing declaration problem.
(This used to be commit 44365130ce794e442f52ec7cf3fc51065f713c5f)

12 years agor22772: - Still working on the fact that readahead() is not declared (on at least one
Derrell Lipman [Thu, 10 May 2007 01:27:18 +0000 (01:27 +0000)]
r22772: - Still working on the fact that readahead() is not declared (on at least one
  OS) but is available for linking.  Instead of running configure tests with
  -Werror-implicit-function-declaration in developer mode (which may lead to
  different library functions being used in developer mode than when not in
  developer mode), add tests for whether readahead is declared.  If not,
  provide a replacement declaration in lib/replace.
(This used to be commit 7d05fa8b32b5b33e95fd9d552d2a45013b4803ec)

12 years agor22771: One liner fix for idmap_ldap
Simo Sorce [Wed, 9 May 2007 21:38:41 +0000 (21:38 +0000)]
r22771: One liner fix for idmap_ldap
Fixes the strange behavior we were seeing about idmap_ldap creating
a new connection for each query.

Jerry we need this in for 3.0.25
(This used to be commit 4fb3e0f65562059bd717ea28df701256e8fa9a77)

12 years agor22767: Argl. Typed in 'svn ci' in the wrong branch. Revert.
Volker Lendecke [Wed, 9 May 2007 11:40:48 +0000 (11:40 +0000)]
r22767: Argl. Typed in 'svn ci' in the wrong branch. Revert.
(This used to be commit 2c5b951eba509e826a29775db992aca474476484)

12 years agor22766: Merge from 3_0:
Volker Lendecke [Wed, 9 May 2007 11:39:55 +0000 (11:39 +0000)]
r22766: Merge from 3_0:

r22412 | obnox | 2007-04-20 14:23:36 +0200 (Fr, 20 Apr 2007) | 5 lines

Add a "deletelocalgroup" subcommand to net sam.

Thanks to Karolin Seeger <>.
(This used to be commit fb6ac8a5b247a961963a9b6a95cd6608c5b53d09)

12 years agor22765: Fix from Alison Winters <> for missing return
Jeremy Allison [Wed, 9 May 2007 00:52:46 +0000 (00:52 +0000)]
r22765: Fix from Alison Winters <> for missing return
in sendfilereadbraw.
(This used to be commit b523e782b0f3a3899e5f448698fbecddd59f4369)

12 years agor22761: This introduces lib/conn_tdb.c with two main functions: connections_traverse
Volker Lendecke [Tue, 8 May 2007 13:44:36 +0000 (13:44 +0000)]
r22761: This introduces lib/conn_tdb.c with two main functions: connections_traverse
and connections_forall. This centralizes all the routines that did individual
tdb_open("connections.tdb") and direct tdb_traverse.

(This used to be commit e43e94cda1ad8876b3cb5d1129080b57fa6ec214)

12 years agor22759: sync lib/talloc with samba4
Stefan Metzmacher [Tue, 8 May 2007 11:12:11 +0000 (11:12 +0000)]
r22759: sync lib/talloc with samba4

(This used to be commit 86c510e3198e03ed6efa61b27530bbb008f6802b)

12 years agor22755: Second half of r22754. As it stands now, string_replace expects a
Volker Lendecke [Mon, 7 May 2007 20:53:10 +0000 (20:53 +0000)]
r22755: Second half of r22754. As it stands now, string_replace expects a
pstring. Give it one, although I hate putting it in :-)

Thanks to Tom Bork! :-)
(This used to be commit f4ea3fd36543120fa7d712e6e650c704e4e23759)

12 years agor22754: When processing a string, ensure we don't write one past
Jeremy Allison [Mon, 7 May 2007 19:27:46 +0000 (19:27 +0000)]
r22754: When processing a string, ensure we don't write one past
the terminating NULL if we've already processed the null
in iconv. Jerry, once I get confirmation from Thomas Bork
this needs to be in 3.0.25 final. Tests fine with valgrind
(This used to be commit 14b167ef6e0f2100bd9cdd05c4457e57e952fa5e)

12 years agor22751: Next step for the cluster merge: sessionid.tdb should contain a 'struct
Volker Lendecke [Mon, 7 May 2007 15:31:12 +0000 (15:31 +0000)]
r22751: Next step for the cluster merge: sessionid.tdb should contain a 'struct
server_id' instead of a 'uint32 pid'
(This used to be commit be7bac55c37676a8137c59a22dfb2e4c4821ac21)

12 years agor22747: Fix some C++ warnings
Volker Lendecke [Mon, 7 May 2007 15:07:49 +0000 (15:07 +0000)]
r22747: Fix some C++ warnings
(This used to be commit a66a04e9f11f6c4462f2b56b447bae4eca7b177c)

12 years agor22745: Add local groups to the --required-membership-sid test. This needs
Volker Lendecke [Mon, 7 May 2007 13:56:57 +0000 (13:56 +0000)]
r22745: Add local groups to the --required-membership-sid test. This needs
merging to 3_0_26 once Michael's net conf changes have been merged. It
depends on token_utils.c.
(This used to be commit a99ab3a2ed44522054175f03b60e63fa05a0378a)

12 years agor22744: Fix a valgrind error. parse_domain_username does not necessarily fill in
Volker Lendecke [Mon, 7 May 2007 13:39:25 +0000 (13:39 +0000)]
r22744: Fix a valgrind error. parse_domain_username does not necessarily fill in
the domain.
(This used to be commit f4f0d7137758cc674876517590807cc3d634043d)

12 years agor22740: Move debug_*_user_token to token_utils.c
Volker Lendecke [Mon, 7 May 2007 12:15:11 +0000 (12:15 +0000)]
r22740: Move debug_*_user_token to token_utils.c
(This used to be commit 4ad9f8aa61cef94be8d38c6e91aac3a5c848f81f)

12 years agor22739: Make prototypes in include/util_tdb.h of some functions from
Michael Adam [Mon, 7 May 2007 11:25:00 +0000 (11:25 +0000)]
r22739: Make prototypes in include/util_tdb.h of some functions from
lib/util_tdb.c exactly match the definitions. (There were
some [u]int_32_t instead of [u]int32, which made a gcc 2.95
on an old AIX without system [u]int32[_t] types complain...)
(This used to be commit 7cae0d61170485eb220f546899dfa78f1805a272)

12 years agor22738: Fix a debug message.
Volker Lendecke [Mon, 7 May 2007 11:04:38 +0000 (11:04 +0000)]
r22738: Fix a debug message.

Günther, please check this!


(This used to be commit 8a038b8cd3f43bb8743eda160b852efdbc80ed70)

12 years agor22737: Fix crash bug (info3 is now talloced).
Günther Deschner [Mon, 7 May 2007 10:14:32 +0000 (10:14 +0000)]
r22737: Fix crash bug (info3 is now talloced).

(This used to be commit 08a7ee8d968b493a17fd669f3dc6fed7abe3d36e)

12 years agor22736: Start to merge the low-hanging fruit from the now 7000-line cluster patch.
Volker Lendecke [Mon, 7 May 2007 09:35:35 +0000 (09:35 +0000)]
r22736: Start to merge the low-hanging fruit from the now 7000-line cluster patch.

This changes "struct process_id" to "struct server_id", keeping both is
just too much hassle. No functional change (I hope ;-))

(This used to be commit 0ad4b1226c9d91b72136310d3bbb640d2c5d67b8)

12 years agor22732: - Testing of libsmbclient against Vista revealed what is likely a bug in
Derrell Lipman [Mon, 7 May 2007 03:07:39 +0000 (03:07 +0000)]
r22732: - Testing of libsmbclient against Vista revealed what is likely a bug in
  Vista.  Vista provides a plethora of kludges to simulate older versions of
  Windows.  The kludges are in the form of shortcuts (or more likely symbolic
  links, but I don't know enough about Vista to determine that definitively)
  and in most cases, attempts to access them get back an "access denied"
  error.  On one particular folder, however, "<share>/Users/All Users", it
  returns an unknown (to ethereal and the Samba3 code) NT status code:
  0x8000002d.  Although this code does not have a high byte of 0xc0 indicating
  that it is an error, it appears to be an alternate form of "access denied".

  Without this patch, libsmbclient times out on an attempt to enumerate that
  folder rather than returning an error to the caller.  This patch corrects
  that problem.
(This used to be commit cc0cd3a12f76b8cd711e3165d4cfe920552f256d)

12 years agor22731: - Fix bug #4594.
Derrell Lipman [Mon, 7 May 2007 03:02:24 +0000 (03:02 +0000)]
r22731: - Fix bug #4594. determines if -Werror-implicit-function-declaration is
  available, and if so it enables that flag if --enable-developer is
  specified.  Since the configure tests themselves did not use that flag, it
  was possible for a configure test to succeed, followed by a failed
  compilation due to a facility being available but not having a proper
  declaration in a header file.  (This bit me with readahead().)  This patch
  ensures that if implicit function declarations will kill the build, the
  feature being tested is deselected so the build will succeed.

  The autoconf manual suggests using return instead of exit in configure
  tests because the declaration for exit is often missing.  We require this
  now, since we error if prototypes are missing.  See section 5.5.1 of  This patch makes
  these changes, because in fact, an external declaration for exit is missing
  here (and likely elsewhere).

  I've verified that the features selected (here) with the original and the new one are the same except for, in my case,
  readahead.  I've also confirmed that the generated Makefile is identical.

  These changes are not being applied to the 3.0.26 branch because it does not
  exhibit the initial problem this patch is supposed to solve since it doesn't
  attempt to use -Werror-implicit-function-declaration.
(This used to be commit 4d42720915b8f65842147171f689127e94d1b973)

12 years agor22730: Fix password changes via pam_winbindd when using "winbind normalize names"
Gerald Carter [Sun, 6 May 2007 22:22:47 +0000 (22:22 +0000)]
r22730: Fix password changes via pam_winbindd when using "winbind normalize names"
and the username has been munged.  Make sure to munge it back before
performing the change_password() request.
(This used to be commit ff025d451e165383ad7d524e0e8176d987554049)

12 years agor22729: add help text for osver and osname options to 'net ads join' (patch from...
Gerald Carter [Sun, 6 May 2007 22:18:44 +0000 (22:18 +0000)]
r22729: add help text for osver and osname options to 'net ads join' (patch from Dnailo A.)
(This used to be commit 3f588e0b65433176f8f80312c1456836717cf6de)

12 years agor22728: Patch from Danilo Almeida <>:
Gerald Carter [Sun, 6 May 2007 21:45:53 +0000 (21:45 +0000)]
r22728: Patch from Danilo Almeida <>:

When asked to create a machine account in an OU as part
of "net ads join" and the account already exists in another
OU, simply move the machine object to the requested OU.
(This used to be commit 3004cc6e593e6659a618de66f659f579e71c07f7)

12 years agor22727: remove outdated comment about templatre shell and homedir
Gerald Carter [Sun, 6 May 2007 21:40:28 +0000 (21:40 +0000)]
r22727: remove outdated comment about templatre shell and homedir
(This used to be commit e8f9bd655829f671e9ce395aa9b4b94ff4bab36a)

12 years agor22726: When performing an offline logon for a user in a trusted domain,
Gerald Carter [Sun, 6 May 2007 21:36:20 +0000 (21:36 +0000)]
r22726: When performing an offline logon for a user in a trusted domain,
take care not to expire the name2sid cache entry just because
that child does not know that the primary domain is offline.
(This used to be commit 0399f52a1cdbb1acf8d41afddf498529ff4923cf)

12 years agor22725: * Don't try to update the sequence_number when offline
Gerald Carter [Sun, 6 May 2007 21:34:24 +0000 (21:34 +0000)]
r22725: * Don't try to update the sequence_number when offline
* Log the NTSTATUS when saving name/sid cache entry
* Allow the backend loolkup_usergroups() call in winbindd_{rpc,ads}.c
  to inform the wcache manager that the group list should not be cached
  (needed for one-way trusts).
(This used to be commit 693ab48408dbb775b57dcc5140e27ad9221852a1)

12 years agor22724: Call an nss_info backend's init() function if the
Gerald Carter [Sun, 6 May 2007 21:31:19 +0000 (21:31 +0000)]
r22724: Call an nss_info backend's init() function if the
previous call was unsuccessful.  needed for offline
(This used to be commit c3a8dc5d136e33b66849c38bfa910cd044cd521f)

12 years agor22720: Fixes for offline auth when using krb5_auth = yes in pam_winbind.
Gerald Carter [Sun, 6 May 2007 21:26:01 +0000 (21:26 +0000)]
r22720: Fixes for offline auth when using krb5_auth = yes in pam_winbind.
Assume that "NO_DOMAIN_CONTROLLERS_FOUND" means that the domain
is offline.
(This used to be commit 30f9cc52bf8270652624c79691d147e05e476583)

12 years agor22719: Missed change for one-way trust support. Ignore password policy
Gerald Carter [Sun, 6 May 2007 21:23:40 +0000 (21:23 +0000)]
r22719: Missed change for one-way trust support.  Ignore password policy
settings from one trusted domain with no incoming trust path.

Guenther, I think this is ok as we only need the pw policy
to give feedback on upcoming expiration times.
(This used to be commit c79ae57388d087496777129d6936cd51aab38d5b)

12 years agor22717: Add Everyone and AuthenticatedUsers to the user's token
Gerald Carter [Sun, 6 May 2007 21:17:02 +0000 (21:17 +0000)]
r22717: Add Everyone and AuthenticatedUsers to the user's token
for use by the require-membership-of pam_winbind option.
(This used to be commit 11f81c5997a014cca9d98c474e7870ebb07c4642)

12 years agor22716: Clarify comment in winbindd_domain structure
Gerald Carter [Sun, 6 May 2007 21:15:45 +0000 (21:15 +0000)]
r22716: Clarify comment in winbindd_domain structure
(This used to be commit 32fd8558bd4531a745a04810a1cb6392dfab16a5)

12 years agor22715: When our primary domain does on or offline, make sure to send a msg
Gerald Carter [Sun, 6 May 2007 21:10:30 +0000 (21:10 +0000)]
r22715: When our primary domain does on or offline, make sure to send a msg
to the idmap child.

Also remove the check for the global offline state in child_msg_offline()
as this means we cannot mark domains offline due to network outages.
(This used to be commit 1b99e8b521eae3e9fa775577de01116bb20fb8b3)

12 years agor22714: Prevent DNS lookup storms when the DNS servers are unreachable.
Gerald Carter [Sun, 6 May 2007 21:06:55 +0000 (21:06 +0000)]
r22714: Prevent DNS lookup storms when the DNS servers are unreachable.
Helps when transitioning from offline to online mode.

Note that this is a quick hack and a better solution
would be to start the DNS server's state between processes
(similar to the namecache entries).
(This used to be commit 4f05c6fe26f4abd7ca71eac339fee2ef5e254369)

12 years agor22713: Offline logon fixes for idmap manager:
Gerald Carter [Sun, 6 May 2007 21:04:30 +0000 (21:04 +0000)]
r22713: Offline logon fixes for idmap manager:

(a) Ignore the negative cache when the domain is offline
(b) don't delete expired entries from the cache as these
    can be used when offline (same model as thw wcache entries)
(c) Delay idmap backend initialization when offline
    as the backend routines will not be called until we go
    online anyways.  This prevents idmap_init() from failing
    when a backend's init() function fails becuase of lack of
    network connectivity
(This used to be commit 4086ef15b395f1a536fb669af2103a33ecc14de4)

12 years agor22712: Inform the user when logging in via pam_winbind
Gerald Carter [Sun, 6 May 2007 20:33:33 +0000 (20:33 +0000)]
r22712: Inform the user when logging in via pam_winbind
and the krb5 tkt cache could not be created due to clock skew.
(This used to be commit 24616f7d6be40b090dc74851b1ea7d09d6976811)

12 years agor22711: Fix a compile warnign in query_user(). Ensure that user_rid
Gerald Carter [Sun, 6 May 2007 20:32:36 +0000 (20:32 +0000)]
r22711: Fix a compile warnign in query_user().  Ensure that user_rid
is initialized.
(This used to be commit ef0304268284df7166ecd1b17328076e7ce40de9)

12 years agor22710: Support one-way trusts.
Gerald Carter [Sun, 6 May 2007 20:16:12 +0000 (20:16 +0000)]
r22710: Support one-way trusts.

* Rely on the fact that name2sid will work for any name
  in a trusted domain will work against our primary domain
  (even in the absense of an incoming trust path)

* Only logons will reliably work and the idmap backend
  is responsible for being able to manage id's without contacting
  the trusted domain

* "getent passwd" and "getent group" for trusted users and groups
  will work but we cannot get the group membership of a user in any
  fashion without the user first logging on (via NTLM or krb5)
  and the netsamlogon_cache being updated.
(This used to be commit dee2bce2af6aab8308dcef4109cc5248cfba5ef5)

12 years agor22709: we can only use tschannel when commectcing to our primary (might need some...
Gerald Carter [Sun, 6 May 2007 19:48:13 +0000 (19:48 +0000)]
r22709: we can only use tschannel when commectcing to our primary (might need some fixing here for a Samba DC)
(This used to be commit 3d2123383d9dab6f0c8832e0f04238aa9a972c70)

12 years agor22708: disable saving the trusted domain list as we want to the parent daemon to...
Gerald Carter [Sun, 6 May 2007 19:46:03 +0000 (19:46 +0000)]
r22708: disable saving the trusted domain list as we want to the parent daemon to manage the complete trusted domain cache
(This used to be commit 3a9152a2acfc7b615a5c6b8764ea9462443f00d1)

12 years agor22707: missed merge from local tree: pass the correct state to the domain when calli...
Gerald Carter [Sun, 6 May 2007 19:42:25 +0000 (19:42 +0000)]
r22707: missed merge from local tree: pass the correct state to the domain when calling the async lookupsid() routine
(This used to be commit 3d814862af7382a9ea56b2c8d3cc9a31dca4bdb6)

12 years agor22706: missed one reference to domain->native_mode in the previous commit
Gerald Carter [Sun, 6 May 2007 19:39:41 +0000 (19:39 +0000)]
r22706: missed one reference to domain->native_mode in the previous commit
(This used to be commit aa2ac5a1944884586c9f7e97c3a0b1b6c418b554)

12 years agor22705: Implement new set_dc_type_and_flags() called based on the
Gerald Carter [Sun, 6 May 2007 19:37:13 +0000 (19:37 +0000)]
r22705: Implement new set_dc_type_and_flags() called based on the
information return from our DC in the DsEnumerateDomainTrusts()
call.   If the fails, we callback ot the older
connect-to-the-remote-domain method.

Note that this means we can only reliably expect the native_mode
flag to be set for our own domain as this information in not
available outside our primary domain from the trusted information.
This is ok as we only really need the flag when trying to
determine to enumerate domain local groups via RPC.

Use the AD flag rather than the native_mode flag when using
ldap to obtain the seq_num for a domain.
(This used to be commit 4b4148a9642f03b8f27dda2132708bcc0cbb3b8e)

12 years agor22704: Implement three step method for enumerating domain trusts.
Gerald Carter [Sun, 6 May 2007 19:17:30 +0000 (19:17 +0000)]
r22704: Implement three step method for enumerating domain trusts.

(a) Query our primary domain for trusts
(b) Query all tree roots in our forest
(c) Query all forest roots in trusted forests.

This will give us a complete trust topology including
domains via transitive Krb5 trusts.  We also store the
trust type, flags, and attributes so we can determine
one-way trusted domains (outgoing only trust path).
Patch for one-way trusts coming in a later check-in.

"wbinfo -m" now lists all domains in the domain_list() as held
by the main winbindd process.
(This used to be commit 9cf6068f1e0a1063d331af17aa493140497b96ef)

12 years agor22703: Convert winbindd_getgrgid() and winbindd_getgetpwnam()
Gerald Carter [Sun, 6 May 2007 19:04:31 +0000 (19:04 +0000)]
r22703: Convert winbindd_getgrgid() and winbindd_getgetpwnam()
to use the same code path after we resolve the name/gid to
a SID.  Use the async lookupname/lookupsid interface.
(This used to be commit d12b8147d6bd34fad680cb8705dc6d7bbea1db12)

12 years agor22702: Convert both lookup name and lookup sid to follow the
Gerald Carter [Sun, 6 May 2007 19:01:54 +0000 (19:01 +0000)]
r22702: Convert both lookup name and lookup sid to follow the
same heuristic.  First try our DC and then try a DC in the
root of our forest.  Use a temporary state since
winbindd_lookupXXX_async() is called from various winbindd
API entry points.

Note this will break the compile.  That will be fixed in the
next commit.
(This used to be commit b442644bac2a7d5853440254257ca34a8e7c25de)

12 years agor22701: Fix the krb5_nt_status error table and add the "no DCs found" mapping
Gerald Carter [Sun, 6 May 2007 18:56:43 +0000 (18:56 +0000)]
r22701: Fix the krb5_nt_status error table and add the "no DCs found" mapping
(This used to be commit 2ab617fbbffbd6bf98ee02150f62b87a2610531f)

12 years agor22700: Add a simple wcache TRUSTDOM api for maintaing a complete
Gerald Carter [Sun, 6 May 2007 18:39:31 +0000 (18:39 +0000)]
r22700: Add a simple wcache TRUSTDOM api for maintaing a complete
list of trusted domains without requiring each winbindd process
to aquire this on its own.  This is needed for various idmap
plugins and for dealing with different trust topoligies.

list_trusted_domain() patches coming next.
(This used to be commit 2da62a3d965a9701e16e644fd6bc728b43f28489)

12 years agor22695: Dummy checkin (reformatting) to make the AIX hosts retry.
Volker Lendecke [Sun, 6 May 2007 13:46:30 +0000 (13:46 +0000)]
r22695: Dummy checkin (reformatting) to make the AIX hosts retry.
(This used to be commit cd55ccef6a1d0c95836feeb5efb5abcaedb35df2)

12 years agor22693: Always compile before checkin.... I've now installed dmapi on my laptop :-)
Volker Lendecke [Sun, 6 May 2007 08:22:59 +0000 (08:22 +0000)]
r22693: Always compile before checkin.... I've now installed dmapi on my laptop :-)
(This used to be commit 7460511c4e92f6fdde430d0c56bbb72377e80b4b)

12 years agor22692: Fix compilation of explicit --without-winbind.
Volker Lendecke [Sat, 5 May 2007 22:47:07 +0000 (22:47 +0000)]
r22692: Fix compilation of explicit --without-winbind.

Thanks to Tom Bork for reporting this!

(This used to be commit 3f956d345143f64f57c02419eb8494c6ed51ce59)

12 years agor22691: Fix a 64-bit warning and a const const discard warning
Volker Lendecke [Sat, 5 May 2007 21:13:40 +0000 (21:13 +0000)]
r22691: Fix a 64-bit warning and a const const discard warning
(This used to be commit 3a2ca1b1b85e268928587287f61d26f992b303a5)

12 years agor22688: Change lock_data in struct byte_range_lock from void * to struct lock_struct *
Volker Lendecke [Sat, 5 May 2007 20:43:06 +0000 (20:43 +0000)]
r22688: Change lock_data in struct byte_range_lock from void * to struct lock_struct *
(This used to be commit 8e0e278961ebf2fa4301874d522636699ace1b9b)

12 years agor22677: One line fix to make net idmap restore work again
Simo Sorce [Fri, 4 May 2007 22:41:35 +0000 (22:41 +0000)]
r22677: One line fix to make net idmap restore work again

Jerry, please add this for 3.0.25 final
(This used to be commit e04ca2d7f8ea2d4c70c2a35201a98c5ecd672d59)

12 years agor22676: Fix zero alloc with create_rpc_blob().
Jeremy Allison [Fri, 4 May 2007 22:15:33 +0000 (22:15 +0000)]
r22676: Fix zero alloc with create_rpc_blob().
(This used to be commit c73963a60ad2d35d69d1ac4c02e24f3272efdd87)

12 years agor22675: Simo's patch for 0 size allocation. Still need
Jeremy Allison [Fri, 4 May 2007 22:01:26 +0000 (22:01 +0000)]
r22675: Simo's patch for 0 size allocation. Still need
to examine parse_misc.c fix.
(This used to be commit 80d981265cd3bc9d73c5da3c514ec736e2dfa73a)

12 years agor22673: Fix for Jerry's reversion. We still need to check size
Jeremy Allison [Fri, 4 May 2007 19:14:51 +0000 (19:14 +0000)]
r22673: Fix for Jerry's reversion. We still need to check size
before talloc.
(This used to be commit 9e4c6ab7392b2dbaccfaced88d3bc7502ff073ee)

12 years agor22666: Expand kerberos_kinit_password_ext() to return NTSTATUS codes and make
Günther Deschner [Fri, 4 May 2007 10:21:39 +0000 (10:21 +0000)]
r22666: Expand kerberos_kinit_password_ext() to return NTSTATUS codes and make
winbindd's kerberized pam_auth use that.

(This used to be commit 0f436eab5b2e5891c341c27cb22db52a72bf1af7)

12 years agor22664: When we have krb5_get_init_creds_opt_get_error() then try to get the NTSTATUS
Günther Deschner [Fri, 4 May 2007 09:55:40 +0000 (09:55 +0000)]
r22664: When we have krb5_get_init_creds_opt_get_error() then try to get the NTSTATUS
codes directly out of the krb5_error edata.

(This used to be commit dcd902f24a59288bbb7400d59c0afc0c8303ed69)

12 years agor22663: Restructure kerberos_kinit_password_ext() error path.
Günther Deschner [Fri, 4 May 2007 09:46:17 +0000 (09:46 +0000)]
r22663: Restructure kerberos_kinit_password_ext() error path.

(This used to be commit 997ded4e3f0dc2199b9a66a9485c919c16fbabc6)

12 years agor22659: merge from SAMBA_4_0:
Stefan Metzmacher [Fri, 4 May 2007 06:59:26 +0000 (06:59 +0000)]
r22659: merge from SAMBA_4_0:

- add AC_GNU_SOURCE macro for systems which don't have it
- fix compiler warning on some systems

(This used to be commit cb785d9bed23fdf930bbd059eeeba5bde04af829)

12 years agor22655: Call correct free-macros in netsamlogon_cache_get() error paths. Forgot those
Günther Deschner [Thu, 3 May 2007 20:12:00 +0000 (20:12 +0000)]
r22655: Call correct free-macros in netsamlogon_cache_get() error paths. Forgot those
in the previous commit.

(This used to be commit fce2fe9903417f4ee58a1ddc03ad0083109b7c50)

12 years agor22654: And this is now Samba 3.0.27pre1-SVN
Gerald Carter [Thu, 3 May 2007 17:05:25 +0000 (17:05 +0000)]
r22654: And this is now Samba 3.0.27pre1-SVN
(This used to be commit 435a6e5e82b5910acc116f211f1dfc3fe32a43ca)

12 years agor22648: Fix comment to match the code.
James Peach [Thu, 3 May 2007 16:14:22 +0000 (16:14 +0000)]
r22648: Fix comment to match the code.
(This used to be commit e93d33b4631e634499b2e74c31d483d306d10367)

12 years agor22647: Avoid leaking a full info3 structure on each winbindd cached login by making
Günther Deschner [Thu, 3 May 2007 12:29:32 +0000 (12:29 +0000)]
r22647: Avoid leaking a full info3 structure on each winbindd cached login by making
netsamlogon_cache_get() return a talloc'ed structure.

(This used to be commit 5b149967cc3ab68057db015e67b688c9b9577f0d)

12 years agor22646: segfault fix in idmap_ldap.c from 3_0_25
Simo Sorce [Thu, 3 May 2007 12:28:25 +0000 (12:28 +0000)]
r22646: segfault fix in idmap_ldap.c from 3_0_25
(This used to be commit 565d7d0b18f18ba11f186667df95bc608a179efa)

12 years agor22644: Fix memleak.
Günther Deschner [Thu, 3 May 2007 11:49:32 +0000 (11:49 +0000)]
r22644: Fix memleak.

(This used to be commit 65a2701f36439db37e8cd6067be69e8ffdc4615b)

12 years agor22643: Don't clear cached U/SID and UG/SID entries when we want to logon offline.
Günther Deschner [Thu, 3 May 2007 11:44:18 +0000 (11:44 +0000)]
r22643: Don't clear cached U/SID and UG/SID entries when we want to logon offline.

(This used to be commit 37f9f466fd05bb06d8539bdb2cb72a730c2af4f4)

12 years agor22641: Install tdbdump and tdbbackup.
Jelmer Vernooij [Wed, 2 May 2007 18:10:57 +0000 (18:10 +0000)]
r22641: Install tdbdump and tdbbackup.
(This used to be commit 232c5c65578e3cddffe7e6ed996de7fc42b32f48)

12 years agor22636: Fix logic bug.
Günther Deschner [Wed, 2 May 2007 15:44:05 +0000 (15:44 +0000)]
r22636: Fix logic bug.

We certainly don't want to crash winbind on each sucessfull
centry_uint{8,16,32,64} read.

Jeremy, please check :-)

(This used to be commit bfcd10766bcac1d50f7624bbe5a72eca57b5e278)

12 years agor22633: Fix typo in debug message.
James Peach [Tue, 1 May 2007 21:22:55 +0000 (21:22 +0000)]
r22633: Fix typo in debug message.
(This used to be commit 4c58b6b1946bf61b24cbdb3c331fee3d48a6b7d2)

12 years agor22631: Remove the possibility of sid_check_is_domain and
James Peach [Tue, 1 May 2007 20:03:44 +0000 (20:03 +0000)]
r22631: Remove the possibility of sid_check_is_domain and
sid_check_is_in_our_domain getting out of sync.
(This used to be commit bbc102172abcb5f7c5c9e777536d7c17afe8b355)

12 years agor22630: Revert svn r22576 (parse change to enum_aliasmem(). Original code was correct
Gerald Carter [Tue, 1 May 2007 16:49:00 +0000 (16:49 +0000)]
r22630: Revert svn r22576 (parse change to enum_aliasmem().  Original code was correct
(This used to be commit cf11b4314987d4d429d09e073c5294d3a9977c52)

12 years agor22615: fix prototype
Michael Adam [Mon, 30 Apr 2007 22:21:46 +0000 (22:21 +0000)]
r22615: fix prototype
(This used to be commit 6999d578aebab4e3216200be1d884caa3578ecc2)

12 years agor22614: Only enable GNU-isms in the Makefile if we can be sure that the GNU
James Peach [Mon, 30 Apr 2007 18:59:34 +0000 (18:59 +0000)]
r22614: Only enable GNU-isms in the Makefile if we can be sure that the GNU
make we found is what will be run when the user invokes "make".
(This used to be commit e3802961c1895f260f04a7955a2a182d657248a0)

12 years agor22613: Fix an uninitialized variable warning
Volker Lendecke [Mon, 30 Apr 2007 17:19:49 +0000 (17:19 +0000)]
r22613: Fix an uninitialized variable warning
(This used to be commit d4c5d5ffb30fe50abb828067b047d5eb61038ddf)

12 years agor22611: Fix from Jens Nissen <>. Fix bad
Jeremy Allison [Mon, 30 Apr 2007 16:32:17 +0000 (16:32 +0000)]
r22611: Fix from Jens Nissen <>. Fix bad
memory leak I introduced into acl code, also remove
redundent extra check for global_sid_System :

global_sid_System == S-1-5-18 which is already
included in the check for a domain of
global_sid_NT_Authority == S-1-5

(This used to be commit 10649540ac11e679997f414d4a6b12d057bd7913)

12 years agor22593: Finish doing the same for raw TALLOC.
Jeremy Allison [Mon, 30 Apr 2007 04:16:56 +0000 (04:16 +0000)]
r22593: Finish doing the same for raw TALLOC.
(This used to be commit aef3c262b724d1283187e732833519c4e6fb088c)

12 years agor22592: Fix TALLOC_SIZE to be consistent.
Jeremy Allison [Mon, 30 Apr 2007 03:41:40 +0000 (03:41 +0000)]
r22592: Fix TALLOC_SIZE to be consistent.
(This used to be commit 8044a6482c7c165a64878982cee5ee9756a0a734)

12 years agor22591: Fix up the examples also.
Jeremy Allison [Mon, 30 Apr 2007 03:38:19 +0000 (03:38 +0000)]
r22591: Fix up the examples also.
(This used to be commit aa5a1591c626e2828244a78f237af8a59af57784)

12 years agor22590: Make TALLOC_ARRAY consistent across all uses.
Jeremy Allison [Mon, 30 Apr 2007 02:51:26 +0000 (02:51 +0000)]
r22590: Make TALLOC_ARRAY consistent across all uses.
That should be it....
(This used to be commit 603233a98bbf65467c8b4f04719d771c70b3b4c9)

12 years agor22589: Make TALLOC_ARRAY consistent across all uses.
Jeremy Allison [Mon, 30 Apr 2007 02:39:34 +0000 (02:39 +0000)]
r22589: Make TALLOC_ARRAY consistent across all uses.
(This used to be commit 8968808c3b5b0208cbad9ac92eaf948f2c546dd9)

12 years agor22588: Make all uses of TALLOC_MEMDUP consistent.
Jeremy Allison [Mon, 30 Apr 2007 01:34:28 +0000 (01:34 +0000)]
r22588: Make all uses of TALLOC_MEMDUP consistent.
(This used to be commit 8ad13718af0ba1fcb10a6f1631b1ed3cb8d11175)

12 years agor22587: Ensure TALLOC_ZERO_ARRAY is consistent.
Jeremy Allison [Mon, 30 Apr 2007 01:17:34 +0000 (01:17 +0000)]
r22587: Ensure TALLOC_ZERO_ARRAY is consistent.
(This used to be commit c3df5d08dd6a983f9d53dc6628a50e571d322e8d)

12 years agor22586: Add a modified version of Simo's patch.
Jeremy Allison [Mon, 30 Apr 2007 00:53:17 +0000 (00:53 +0000)]
r22586: Add a modified version of Simo's patch.
(This used to be commit 18f47f999d28af56e205cd20d10c72ff6f0a3846)

12 years agor22585: Get us into a consistent state with TALLOC_ZERO_ARRAY also.
Jeremy Allison [Mon, 30 Apr 2007 00:48:20 +0000 (00:48 +0000)]
r22585: Get us into a consistent state with TALLOC_ZERO_ARRAY also.
(This used to be commit c622fb8536d955952a0fbf2441a4cb45a9feb9b0)

12 years agor22584: Don't hardcode specific Python version.
Jelmer Vernooij [Sun, 29 Apr 2007 21:46:13 +0000 (21:46 +0000)]
r22584: Don't hardcode specific Python version.

Patch by the Samba packaging team for Debian.
(This used to be commit 1d3f35941bc3b35e115680ac4bddc8e819a0181b)

12 years agor22583: Support non-Linux GNU systems (such as Debians' GNU with FreeBSD kernel and
Jelmer Vernooij [Sun, 29 Apr 2007 21:44:48 +0000 (21:44 +0000)]
r22583: Support non-Linux GNU systems (such as Debians' GNU with FreeBSD kernel and
Hurd systems).

Patch by the Samba packaging team for Debian.
(This used to be commit 1aa64eb02c7eee174a4f9934cba1e5bde5fabfbb)

12 years agor22578: Remove python build directory and generated smbadduser.
Jelmer Vernooij [Sun, 29 Apr 2007 21:37:24 +0000 (21:37 +0000)]
r22578: Remove python build directory and generated smbadduser.

Patch originally by the Debian packaging team for Samba.
(This used to be commit f46492a4dbb61e452ed1a93909986996b7aa2558)

12 years agor22577: Change all of parse/*.c to use standard form. Fix some
Jeremy Allison [Sun, 29 Apr 2007 21:13:13 +0000 (21:13 +0000)]
r22577: Change all of parse/*.c to use standard form. Fix some
marshalling bugs.
(This used to be commit 3df99006f8a52af7cff0fbca1bf16157a8648254)

12 years agor22576: Fix marshalling bug in aliasmem.
Jeremy Allison [Sun, 29 Apr 2007 20:57:04 +0000 (20:57 +0000)]
r22576: Fix marshalling bug in aliasmem.
(This used to be commit 415c476f7242269d6feb2365531f4c8286bdc0f2)

12 years agor22574: Fix reply when we have no dfs shares.
Jeremy Allison [Sun, 29 Apr 2007 19:54:26 +0000 (19:54 +0000)]
r22574: Fix reply when we have no dfs shares.
(This used to be commit f95bf093f9303131618b1de8f9b783ba19644bb3)

12 years agor22573: Fix old bug mixing free() and talloc_free()
Jeremy Allison [Sun, 29 Apr 2007 19:20:48 +0000 (19:20 +0000)]
r22573: Fix old bug mixing free() and talloc_free()
when the add_sid_to_array_XX code was moved
from malloc to talloc. Found running valgrind
and rpcclient. Needs merging for 3.0.25 final.
(This used to be commit 8af56dbd00045049ea3c5022822bbaeeecbd9661)