13 years agor3032: Somewhat stricter syntax for binding strings:
Jelmer Vernooij [Mon, 18 Oct 2004 11:43:26 +0000 (11:43 +0000)]
r3032: Somewhat stricter syntax for binding strings:

 [] is now mandatory
 : after the hostname is no longer allowed

examples of allowed binding strings:


Note that the last two lines are not recognized by smbtorture as a binding
 string yet. dcerpc_parse_binding() does accept them though.
(This used to be commit c15862e778507287bddef7967383d4b5d22eaee9)

13 years agor3031: added support for lock cancelation, which effectively just triggers an early...
Andrew Tridgell [Mon, 18 Oct 2004 09:16:55 +0000 (09:16 +0000)]
r3031: added support for lock cancelation, which effectively just triggers an early lock timeout

added support for more of the bizarre special lock offset semantics of w2k3
(This used to be commit d5bfc910b1200fb283e26572dc57fcf93652fd32)

13 years agor3030: added testing of lock cancel, and some more special offsets (locks
Andrew Tridgell [Mon, 18 Oct 2004 08:41:44 +0000 (08:41 +0000)]
r3030: added testing of lock cancel, and some more special offsets (locks
with the top bit set are special)
(This used to be commit f732a983d4fde29d5ad893ad35fd182ee3d8a75b)

13 years agor3029: implemented byte range lock timeouts.
Andrew Tridgell [Mon, 18 Oct 2004 07:40:17 +0000 (07:40 +0000)]
r3029: implemented byte range lock timeouts.

This adds a pvfs_wait_message() routine which uses the new messaging
system, event timers and talloc destructors to give a nice generic
async event handling system with a easy to use interface. The
extensions to pvfs_lock.c are based on calls to pvfs_wait_message()

We now pass all of our smbtorture locking tests, although while
writing this code I have thought of some additonal tests that should
be added, particularly for lock cancel operations. I'll work on that

This commit also extends the smbtorture lock tests to test the rather
weird 0xEEFFFFFF locking semantics that I have discovered in
win2003. Win2003 treats the 0xEEFFFFFF boundary as special, and will
give different error codes on either side of it. Locks on both sides
are allowed, the only difference is which error code is given when a
lock is denied. Anyone like to hazard a guess as to why? It has
me stumped.
(This used to be commit 4395c0557ab175d6a8dd99df03c266325949ffa5)

13 years agor3028: use talloc_free() instead of talloc_unlink(), as the
Andrew Tridgell [Mon, 18 Oct 2004 00:04:46 +0000 (00:04 +0000)]
r3028: use talloc_free() instead of talloc_unlink(), as the
event_context_merge() code leaves the events as grandchildren of the
events context, not children, so talloc_unlink() will not work after
the merge
(This used to be commit 2d0dfe607dcfb522669d6fb3d566cf121d84274a)

13 years agor3027: got rid of some configure checks we don't need any more
Andrew Tridgell [Sun, 17 Oct 2004 23:59:56 +0000 (23:59 +0000)]
r3027: got rid of some configure checks we don't need any more
(This used to be commit 6a3f356b763b0577e2ad3e7ea74bee932c04a46b)

13 years agor3026: - added automatic retry to messages when the servers listen queue is
Andrew Tridgell [Sun, 17 Oct 2004 22:28:26 +0000 (22:28 +0000)]
r3026: - added automatic retry to messages when the servers listen queue is
  full. This means callers can just "send and forget" rather than
  having to check for a temporary failure. The mechanism takes nice
  advantage of the timed events handling is our events code. A message
  will only fail now if we completely run out of some resource (such
  as memory).

- changed the test code not to do retries itself, but only to warn on real failures
(This used to be commit 8cddc610a25e64c1ad39dd6a2fc2e7f467e04fc9)

13 years agor3025: don't warn about no path in a service, as some backends (like cifs) don't...
Andrew Tridgell [Sun, 17 Oct 2004 22:04:15 +0000 (22:04 +0000)]
r3025: don't warn about no path in a service, as some backends (like cifs) don't need a path
(This used to be commit a8c49a0de3f806bddaf6bd594ec052cf9f4a3fab)

13 years agor3024: run the *_connect() NTVFS initialisation operation as root, to allow
Andrew Tridgell [Sun, 17 Oct 2004 22:03:33 +0000 (22:03 +0000)]
r3024: run the *_connect() NTVFS initialisation operation as root, to allow
backends to open databases and perform any other privileged
operations that might be needed.
(This used to be commit 54fd395025656d9b264ba1c1fab6e3ce8ca3d357)

13 years agor3023: added immediate send of messages when they are first queued. This makes things...
Andrew Tridgell [Sun, 17 Oct 2004 13:33:03 +0000 (13:33 +0000)]
r3023: added immediate send of messages when they are first queued. This makes things a bit more efficient
(This used to be commit 8380225d326e4bfb3f15fddc72c097870713132a)

13 years agor3022: Work on unmarshalling arrays of structs in a buffer (Python string) for
Tim Potter [Sun, 17 Oct 2004 13:24:56 +0000 (13:24 +0000)]
r3022: Work on unmarshalling arrays of structs in a buffer (Python string) for
spoolss.  Doesn't quite work yet.
(This used to be commit 9045645ddf4eb8b5596d220ed936c8731641ef0a)

13 years agor3021: under heavy load the listen queue for messaging unix domain socket can fill...
Andrew Tridgell [Sun, 17 Oct 2004 13:22:37 +0000 (13:22 +0000)]
r3021: under heavy load the listen queue for messaging unix domain socket can fill up, leading to refused
connections. The caller needs to retry. This adds testing of the retry in LOCAL-MESSAGING
(This used to be commit 2c568d4dc20303061a89c815b9a9a0bafc283633)

13 years agor3020: better error handling in socket_unix
Andrew Tridgell [Sun, 17 Oct 2004 13:21:24 +0000 (13:21 +0000)]
r3020: better error handling in socket_unix
(This used to be commit 64514ff5b7734667a1364de925114091fe208b3a)

13 years agor3019: make the LOCAL-MESSAGING test a 2 process test
Andrew Tridgell [Sun, 17 Oct 2004 12:41:31 +0000 (12:41 +0000)]
r3019: make the LOCAL-MESSAGING test a 2 process test
(This used to be commit 68890247c1247f5f9e299ac1f579052cd022e79f)

13 years agor3018: handle STATUS_MORE_ENTRIES from socket_recv() in the messaging code
Andrew Tridgell [Sun, 17 Oct 2004 12:41:04 +0000 (12:41 +0000)]
r3018: handle STATUS_MORE_ENTRIES from socket_recv() in the messaging code
(This used to be commit 13739b68d8357d5d330f12b851d0311feb81e545)

13 years agor3017: nicer memory handling for event_context_merge()
Andrew Tridgell [Sun, 17 Oct 2004 11:37:22 +0000 (11:37 +0000)]
r3017: nicer memory handling for event_context_merge()
(This used to be commit 1cef44505e5de9b8ae5206522b624082ad2343b2)

13 years agor3016: - converted the events code to talloc
Andrew Tridgell [Sun, 17 Oct 2004 10:04:49 +0000 (10:04 +0000)]
r3016: - converted the events code to talloc

- added the new messaging system, based on unix domain sockets. It
  gets over 10k messages/second on my laptop without any socket
  cacheing, which is better than I expected.

- added a LOCAL-MESSAGING torture test
(This used to be commit 3af06478da7ab34a272226d8d9ac87e0a4940cfb)

13 years agor3015: fixed typo noticed by abartlett
Andrew Tridgell [Sun, 17 Oct 2004 05:29:03 +0000 (05:29 +0000)]
r3015: fixed typo noticed by abartlett
(This used to be commit b367209a9f94e471efed233639467babbb2b99d7)

13 years agor3014: got rid of the old intra-smbd messaging system in preparation for the new one
Andrew Tridgell [Sun, 17 Oct 2004 05:12:59 +0000 (05:12 +0000)]
r3014: got rid of the old intra-smbd messaging system in preparation for the new one
(This used to be commit 283e38aeb210e048302dc2759a75879cfc81eeb5)

13 years agor3013: added support for unix domain sockets in the generic socket library. I
Andrew Tridgell [Sun, 17 Oct 2004 05:07:07 +0000 (05:07 +0000)]
r3013: added support for unix domain sockets in the generic socket library. I
will shortly be using this for a rewrite of the intra-smbd messaging
library, which is needed to get lock timeouts working properly (and
share modes, oplocks etc)
(This used to be commit 6f4926d846965a901e40d24546eab356c4a537c7)

13 years agor3012: added initial support for byte range locking in the posix vfs. This is
Andrew Tridgell [Sun, 17 Oct 2004 02:55:47 +0000 (02:55 +0000)]
r3012: added initial support for byte range locking in the posix vfs. This is
enough for us to pass locktest, but does not yet support lock timeouts
and some of the other esoteric features.
(This used to be commit 58a92abd88f190bc60894a68e0528e95ae33fe39)

13 years agor3011: separated the locktest code into a separate module in smbtorture
Andrew Tridgell [Sun, 17 Oct 2004 02:52:37 +0000 (02:52 +0000)]
r3011: separated the locktest code into a separate module in smbtorture
(This used to be commit f4a91be63502c0bb32c52c0558dfc7d4d0a21fae)

13 years agor3010: Do some more PyInt vs PyLong checks.
Tim Potter [Sun, 17 Oct 2004 00:37:36 +0000 (00:37 +0000)]
r3010: Do some more PyInt vs PyLong checks.
(This used to be commit b19dc6cd9c1ac44d970b092f09cf96c737a90fdd)

13 years agor3009: Fix up unmarshall functions to return Python dict instead of a NTSTATUS.
Tim Potter [Sun, 17 Oct 2004 00:27:40 +0000 (00:27 +0000)]
r3009: Fix up unmarshall functions to return Python dict instead of a NTSTATUS.
We can now unmarshall a single printer returned from an EnumPrinters.
(This used to be commit 89da7a9196d40699881f12c9a5fe62301aafd4cf)

13 years agor3007: uint32 values need to be stored in Python longs, as on 32-bit machines
Tim Potter [Sun, 17 Oct 2004 00:20:57 +0000 (00:20 +0000)]
r3007: uint32 values need to be stored in Python longs, as on 32-bit machines
Python ints can only hold int32 values.
(This used to be commit 7c5ada63bf5d876a1b67df2cf7bd44942e4b0a98)

13 years agor3006: Poptify
Jelmer Vernooij [Sat, 16 Oct 2004 19:00:27 +0000 (19:00 +0000)]
r3006: Poptify
(This used to be commit 5c46747c36aa09289c6b2df3927833aec78059fd)

13 years agor3005: added talloc wrappers around tdb_open() and ldb_connect(), so that the
Andrew Tridgell [Sat, 16 Oct 2004 13:47:00 +0000 (13:47 +0000)]
r3005: added talloc wrappers around tdb_open() and ldb_connect(), so that the
caller doesn't have to worry about the constraint of only opening a
database a single time in a process. These wrappers will ensure that
only a single open is done, and will auto-close when the last instance
is gone.

When you are finished with a database pointer, use talloc_free() to
close it.

note that this code does not take account of the threads process
model, and does not yet take account of symlinks or hard links to tdb
(This used to be commit 04e1171996612ddb15f84134cadded68f0d173b2)

13 years agor3004: removed some unused functions
Andrew Tridgell [Sat, 16 Oct 2004 11:20:57 +0000 (11:20 +0000)]
r3004: removed some unused functions
(This used to be commit 247421ee648d1935b68a47195fe1709bb861a7d5)

13 years agor3001: Expose unmarshalling functions for structures marked "public" in the
Tim Potter [Sat, 16 Oct 2004 00:19:33 +0000 (00:19 +0000)]
r3001: Expose unmarshalling functions for structures marked "public" in the
idl.  This allows us to pass a buffer of bytes returned from a spoolss
call and convert it to a Python dictionary.  Works for enumprinters level
(This used to be commit 4bc497a2994b12845a46b2d19f60bb81c9869fc9)

13 years agor2997: Added delete on close tests for readonly files.
Jeremy Allison [Fri, 15 Oct 2004 18:59:46 +0000 (18:59 +0000)]
r2997: Added delete on close tests for readonly files.
(This used to be commit 93efa870400a3f69700e69d30319ffbdbdf94820)

13 years agor2994: More cleanups. Move the generation of NTSTATUS and WERROR exceptions
Tim Potter [Fri, 15 Oct 2004 12:21:49 +0000 (12:21 +0000)]
r2994: More cleanups.  Move the generation of NTSTATUS and WERROR exceptions
from inside a swig %exception block and into the argout typemap.  This
will allow us to wrap functions that don't require exception handling, and
also get rid of some ugly code in dcerpc.i
(This used to be commit 558076cc8ddbdb563869f7d35150310217f30c31)

13 years agor2993: fix comment
Stefan Metzmacher [Fri, 15 Oct 2004 11:11:02 +0000 (11:11 +0000)]
r2993: fix comment

(This used to be commit 23a2c5c1586e5ea0261bc84571486658a262740c)

13 years agor2992: drsuapi uses WERROR not NTSTATUS
Stefan Metzmacher [Fri, 15 Oct 2004 11:08:14 +0000 (11:08 +0000)]
r2992: drsuapi uses WERROR not NTSTATUS

(This used to be commit 757f67c08b0b1309d8a0b900539111c7bc430b0e)

13 years agor2991: add drsuapi_DsGetDomainControllerInfo() idl and torture test
Stefan Metzmacher [Fri, 15 Oct 2004 09:48:40 +0000 (09:48 +0000)]
r2991: add drsuapi_DsGetDomainControllerInfo() idl and torture test

(This used to be commit 98ca7640c59aa8694abde03f5661b8908cf088bb)

13 years agor2990: Add support to pidl for autogenerating ndr_size_*() functions. Adding
Jelmer Vernooij [Fri, 15 Oct 2004 09:22:21 +0000 (09:22 +0000)]
r2990: Add support to pidl for autogenerating ndr_size_*() functions. Adding
the [gensize] property to a struct or union will make pidl generate a
ndr_size_*() function.

(not all nasty bits of NDR are completely covered yet by the
 ndr_size*() functions, support for those will be added when necessary)

I also have a local patch (not applied now) that simplifies the pidl output
and eliminates the number of functions required. It would, however, make
pidl more complex.
(This used to be commit 7c823f886afd0c4c6ee838f17882ca0658417011)

13 years agor2989: fix the printing of unions with negative cases when :print is used
Andrew Tridgell [Fri, 15 Oct 2004 07:38:46 +0000 (07:38 +0000)]
r2989: fix the printing of unions with negative cases when :print is used
(This used to be commit d8152f896119418d95d7697cc2ca23f5319c32a9)

13 years agor2988: this should fix support for negative switch levels in PIDL
Andrew Tridgell [Fri, 15 Oct 2004 07:28:53 +0000 (07:28 +0000)]
r2988: this should fix support for negative switch levels in PIDL
(This used to be commit 21ed51d47f7efd493ad64b564fb6362ef8fb067f)

13 years agor2987: added support for signed 32 bit integers in pidl
Andrew Tridgell [Fri, 15 Oct 2004 07:19:09 +0000 (07:19 +0000)]
r2987: added support for signed 32 bit integers in pidl
(This used to be commit 24122eb93e39de8db3675618b6c227c95eb58d9c)

13 years agor2986: Add correct value to dict when generating wrapper for functions that
Tim Potter [Fri, 15 Oct 2004 07:17:51 +0000 (07:17 +0000)]
r2986: Add correct value to dict when generating wrapper for functions that
return WERROR values.

Clean up WERROR vs NTSTATUS handling a bit.
(This used to be commit e6756e3ee0af3e7e98f6deaf9dc83af9aac1b586)

13 years agor2985: got rid of the unused tdb_lockkeys() and tdb_unlockkeys() functions
Andrew Tridgell [Fri, 15 Oct 2004 06:41:35 +0000 (06:41 +0000)]
r2985: got rid of the unused tdb_lockkeys() and tdb_unlockkeys() functions

they have been broken for 4 years (ever since they were added) and
have been never used, which makes them prime candidates for
(This used to be commit 0b53ab85aae4569c04495f07c18a65fd6b47bf4c)

13 years agor2984: fixed the error code for a non-terminal component of a path name not existing
Andrew Tridgell [Fri, 15 Oct 2004 05:40:13 +0000 (05:40 +0000)]
r2984: fixed the error code for a non-terminal component of a path name not existing
(This used to be commit c6a922dbd844c69bbba83c259169655d17e9f87f)

13 years agor2983: report a failure if a server doesn't update the write time at all
Andrew Tridgell [Fri, 15 Oct 2004 01:37:06 +0000 (01:37 +0000)]
r2983: report a failure if a server doesn't update the write time at all
after 2 minutes
(This used to be commit b2298a1c5f0330a262ac855479060fd677fe8059)

13 years agor2982: added a test that shows the amount of time a server takes to update
Andrew Tridgell [Fri, 15 Oct 2004 01:32:24 +0000 (01:32 +0000)]
r2982: added a test that shows the amount of time a server takes to update
the write time on a file after a write.
(This used to be commit efee3c90f90b1e9dd3351933d27fe8a085c3657f)

13 years agor2981: Fix incorrect locks/unlocks in tdb_lockkeys()/tdb_unlockkeys().
Jeremy Allison [Fri, 15 Oct 2004 00:03:26 +0000 (00:03 +0000)]
r2981: Fix incorrect locks/unlocks in tdb_lockkeys()/tdb_unlockkeys().
Spotted by Taj Khattra <>.
(This used to be commit a7d92301bbf45cb9e475e4876fdbb37644ad5871)

13 years agor2975: Try to emulate NT_STATUS_IS_ERR() functionality for WERRORs. Unfortunately
Tim Potter [Thu, 14 Oct 2004 13:09:59 +0000 (13:09 +0000)]
r2975: Try to emulate NT_STATUS_IS_ERR() functionality for WERRORs.  Unfortunately
this means enumerating all the ones we don't think are errors.
(This used to be commit a079e044f0ef23c6c4307c9da35019ec3e8f1d2a)

13 years agor2974: fix the build
Stefan Metzmacher [Thu, 14 Oct 2004 11:11:21 +0000 (11:11 +0000)]
r2974: fix the build

(This used to be commit 1bb71e7a8699bfd32d171a48c4c3b5f35faf3e51)

13 years agor2973: Allow comma's inside parentheses in property arguments
Jelmer Vernooij [Thu, 14 Oct 2004 10:30:08 +0000 (10:30 +0000)]
r2973: Allow comma's inside parentheses in property arguments
(This used to be commit ab2a788fe75ddaf8ff493477f2006a03959e6ab5)

13 years agor2972: make names more consistent
Stefan Metzmacher [Thu, 14 Oct 2004 10:21:51 +0000 (10:21 +0000)]
r2972: make names more consistent

(This used to be commit 7aa91db53ed5811f0900dd61d63d15e71255285e)

13 years agor2971: fix DsBind idl
Stefan Metzmacher [Thu, 14 Oct 2004 10:16:22 +0000 (10:16 +0000)]
r2971: fix DsBind idl

(This used to be commit 9e50b3214b9de84811640296c19d6068936dfd54)

13 years agor2970: - give somefields names and typdef enums for the possible values
Stefan Metzmacher [Thu, 14 Oct 2004 09:56:04 +0000 (09:56 +0000)]
r2970: - give somefields names and typdef enums for the possible values

- do more crackname tests in the torture test

- move server code for cracknames to a different file

(This used to be commit 18050ea6037b3c0c7cfe975eb9c872368b9e3328)

13 years agor2969: inet_ntoa() takes an address in network byte order, so now that we
Andrew Tridgell [Thu, 14 Oct 2004 09:21:12 +0000 (09:21 +0000)]
r2969: inet_ntoa() takes an address in network byte order, so now that we
parse the RHS as IDL, we need to use htonl() to convert back to
network byte order before we can display the IP
(This used to be commit 45508b85dabf8aa66bff9aeebf99c1faf3d475ec)

13 years agor2968: fixed the byte order problem with the new RHS parsing on ncacn_ip_tcp
Andrew Tridgell [Thu, 14 Oct 2004 09:07:41 +0000 (09:07 +0000)]
r2968: fixed the byte order problem with the new RHS parsing on ncacn_ip_tcp
(This used to be commit cc00f9b6b87783d189df00de0ce9ae92b907e21a)

13 years agor2967: Add some printer enum constants from Samba3's rpc_spoolss.h
Tim Potter [Thu, 14 Oct 2004 07:33:49 +0000 (07:33 +0000)]
r2967: Add some printer enum constants from Samba3's rpc_spoolss.h
(This used to be commit 7983a99479164d04281dd6c34d63733afa3c3612)

13 years agor2966: Handle conversion of DATA_BLOB fields from Python in a slightly nicer
Tim Potter [Thu, 14 Oct 2004 07:33:09 +0000 (07:33 +0000)]
r2966: Handle conversion of DATA_BLOB fields from Python in a slightly nicer
manner.  I'm hoping to get rid of DATA_BLOB's but for the moment they
make it easy to get some spoolss action happening quickly.
(This used to be commit 15f8f73f8bfec099973fb8bf167020ae50346cf6)

13 years agor2965: Ignore *.pyc files in torture directory.
Tim Potter [Thu, 14 Oct 2004 07:25:47 +0000 (07:25 +0000)]
r2965: Ignore *.pyc files in torture directory.

Allow test module name to be specified on command line for pytorture

Start spoolss torture test.
(This used to be commit 44bab84f765f6a4d37733a353fc6b74b09c1b39a)

13 years agor2964: Add spoolss to list of wrapped client functions.
Tim Potter [Thu, 14 Oct 2004 06:45:25 +0000 (06:45 +0000)]
r2964: Add spoolss to list of wrapped client functions.
(This used to be commit 96d31ff19d2fa5b0c5a0ee23000a97cb77637968)

13 years agor2963: Handle structures that contain more than one union as members.
Tim Potter [Thu, 14 Oct 2004 06:35:42 +0000 (06:35 +0000)]
r2963: Handle structures that contain more than one union as members.
(This used to be commit 6a47a079c003c2a139665ad2b5ede5d139049bd1)

13 years agor2962: Tweak to get conversion function for pointers to union compiling again.
Tim Potter [Thu, 14 Oct 2004 05:59:28 +0000 (05:59 +0000)]
r2962: Tweak to get conversion function for pointers to union compiling again.
(This used to be commit 8c9c94d578651c5884db0aa0feb6e16858274fbb)

13 years agor2961: fixed a silly typo
Andrew Tridgell [Thu, 14 Oct 2004 05:38:48 +0000 (05:38 +0000)]
r2961: fixed a silly typo
(This used to be commit f76a1cf640a909aa2a4e26e65f59020f9ab575f4)

13 years agor2960: during a lunchtime discussion I found out that all powerpc processors
Andrew Tridgell [Thu, 14 Oct 2004 05:26:35 +0000 (05:26 +0000)]
r2960: during a lunchtime discussion I found out that all powerpc processors
can correctly (and quickly!) handle unaligned little endian memory
accesses, just like i386. This should reduce code size and speeds
things up quite a lot on ppc, at the expense of some inline asm code
(whcih means it only works with gcc)
(This used to be commit 2a0c427c2bf2f8b0739f12c78151b819388c44d4)

13 years agor2958: the warnings from the swig code in pidl were totally swamping valid
Andrew Tridgell [Wed, 13 Oct 2004 23:33:17 +0000 (23:33 +0000)]
r2958: the warnings from the swig code in pidl were totally swamping valid
warnings, making real errors impossible to spot.

this fixes the warnings, and probably fixes some pidl/python bugs as
(This used to be commit 2f1e9954e3381b1864a6fd9fa8b2231478179d4d)

13 years agor2956: Fix towers_length for now. I'm currently working on a pidl extension
Jelmer Vernooij [Wed, 13 Oct 2004 20:09:46 +0000 (20:09 +0000)]
r2956: Fix towers_length for now. I'm currently working on a pidl extension
that can generate these kinds of functions
(This used to be commit ebca2516502560edfd4056fbb4cfc9718a108efa)

13 years agor2954: add server cracknames code:
Stefan Metzmacher [Wed, 13 Oct 2004 15:06:43 +0000 (15:06 +0000)]
r2954: add server cracknames code:

- we currently only do it for our REALM

(This used to be commit e2df8c4285d3430085594a3a3b5534c514acd1f9)

13 years agor2953: add NTSTATUS_TALLOC_CHECK(x)
Stefan Metzmacher [Wed, 13 Oct 2004 15:04:51 +0000 (15:04 +0000)]

(This used to be commit a2cc9517208adedbcbed4b01d18a1478f75d70df)

13 years agor2952: add idl and torture test for DsCrackNames
Stefan Metzmacher [Wed, 13 Oct 2004 14:25:44 +0000 (14:25 +0000)]
r2952: add idl and torture test for DsCrackNames
(I need to find out what the fields mean but it works)

(This used to be commit eff51fc623f2e7b57e7e53eb81760684815db2f4)

13 years agor2951: fixed the intptr_t test for discard_const()
Andrew Tridgell [Wed, 13 Oct 2004 13:27:52 +0000 (13:27 +0000)]
r2951: fixed the intptr_t test for discard_const()
(This used to be commit 3318cf2722597e57d1731152b2607f6b167e45b9)

13 years agor2950: 0x40000 is clearer than 262144
Andrew Tridgell [Wed, 13 Oct 2004 13:04:55 +0000 (13:04 +0000)]
r2950: 0x40000 is clearer than 262144
(This used to be commit c17d9254d42e5966fbdfeeda18023c8c0203dad1)

13 years agor2949: added some range checks in samr.idl
Andrew Tridgell [Wed, 13 Oct 2004 13:00:57 +0000 (13:00 +0000)]
r2949: added some range checks in samr.idl
(This used to be commit 8921e34f989977efc5f9d4f5eabf21bbb5f52115)

13 years agor2948: added support for the [range(low,high)] attribute in pidl. This allows
Andrew Tridgell [Wed, 13 Oct 2004 12:55:10 +0000 (12:55 +0000)]
r2948: added support for the [range(low,high)] attribute in pidl. This allows
range checking of any integer value, to help protect against denial of
service attacks (which could otherwise cause large memory allocations)
(This used to be commit dbe6430d78f1b9aa59969074077e4afa5adf7570)

13 years agor2941: added pvfs_flush() implementation to the posix backend
Andrew Tridgell [Tue, 12 Oct 2004 22:18:02 +0000 (22:18 +0000)]
r2941: added pvfs_flush() implementation to the posix backend
(This used to be commit dac00ef3b0d0f8467367d7b6ff77db7b63a042cc)

13 years agor2940: Complain when there is an attempt to register a backend for a subsystem that...
Jelmer Vernooij [Tue, 12 Oct 2004 15:57:20 +0000 (15:57 +0000)]
r2940: Complain when there is an attempt to register a backend for a subsystem that does
not (yet) exist
(This used to be commit 0130713fbe3d838964542a700839c4e276b18547)

13 years agor2939: Use /* */ style comments
Jelmer Vernooij [Tue, 12 Oct 2004 12:51:35 +0000 (12:51 +0000)]
r2939: Use /* */ style comments
(This used to be commit c5d4fae3b157c5559b8b15dde16451e91c0fc022)

13 years agor2938: Use IDL to dissect the RHS of floors in protocol towers
Jelmer Vernooij [Tue, 12 Oct 2004 12:41:50 +0000 (12:41 +0000)]
r2938: Use IDL to dissect the RHS of floors in protocol towers
(This used to be commit 273d0049b5339e3288b264e5a4393bfab1d4e239)

13 years agor2937: Make sure all memory is initialized
Jelmer Vernooij [Tue, 12 Oct 2004 12:02:18 +0000 (12:02 +0000)]
r2937: Make sure all memory is initialized
(This used to be commit edf28c42f3c9b41c82a4f642ddae23efbb12c944)

13 years agor2934: - changed the unixuid module to use the nt_user_token instead of the server...
Andrew Tridgell [Tue, 12 Oct 2004 11:30:48 +0000 (11:30 +0000)]
r2934: - changed the unixuid module to use the nt_user_token instead of the server supplied info structure.

- added SID_WORLD and SID_NETWORK to the foreign sids in the
  provisioning, as these are auto-added to the nt_user_token (why is
  that done? Andrew?)
(This used to be commit 1dff12fba88827660a2647457867bf4ff6bc8d3d)

13 years agor2933: Only pull a union once when it occurs in a subcontext
Jelmer Vernooij [Tue, 12 Oct 2004 10:32:54 +0000 (10:32 +0000)]
r2933: Only pull a union once when it occurs in a subcontext
(This used to be commit 309623447eef9ae554e2f25713c2123ab578cc6e)

13 years agor2932: character expansion in strlower_m or strupper_m is considered fatal
Andrew Tridgell [Tue, 12 Oct 2004 06:12:24 +0000 (06:12 +0000)]
r2932: character expansion in strlower_m or strupper_m is considered fatal
(as it could cause a overflow). Print a message giving the character
values involved in the expansion so it can be debugged if it happens.
(This used to be commit 2a6f59f376a132fcbce8c8e9d1b38d8aae3e8561)

13 years agor2931: use next_codepoint() to ensure we properly handle multi-byte characters in...
Andrew Tridgell [Tue, 12 Oct 2004 06:07:55 +0000 (06:07 +0000)]
r2931: use next_codepoint() to ensure we properly handle multi-byte characters in pvfs_unix_path()
(This used to be commit 0acf95d84c51d564f7215d34364c37ca74a2a150)

13 years agor2930: added a security context cache to the unixuid module. The module
Andrew Tridgell [Tue, 12 Oct 2004 05:59:56 +0000 (05:59 +0000)]
r2930: added a security context cache to the unixuid module. The module
doesn't actually leave us in the requested sec context between
requests yet, but it does prevent us from doing the samdb lookup on
every packet.

This change speeds up the BASE-MANGLE test against Samba4 with 5000
operations from 61 seconds to 16 seconds. For reference, Samba3 takes
27 seconds for the same test (the string and filename handling in
Samba4 is much more efficient than Samba3)
(This used to be commit da0481ac75a01270897da5aa24dbb2b431928b30)

13 years agor2929: longhorn does not produce sorted directory listings! This is
Andrew Tridgell [Tue, 12 Oct 2004 05:36:37 +0000 (05:36 +0000)]
r2929: longhorn does not produce sorted directory listings! This is
excellent, as it means we don't lose any compatibility by also not
giving sorted listings. I was very much afraid that applications had
begun to rely on this (as its guaranteed by w2k NTFS).

no longer mark a non-sorting server as an error
(This used to be commit 1d21c9a9d1879f5b3de15d251b6bb379c326002d)

13 years agor2928: - fixed the handling of reserved names (rejecting them with ACCESS_DENIED)
Andrew Tridgell [Tue, 12 Oct 2004 05:33:05 +0000 (05:33 +0000)]
r2928: - fixed the handling of reserved names (rejecting them with ACCESS_DENIED)

- don't check for '.' specially in checking for legal names. Longhorn
  doesn't do this any more, and its a real pain. Longhorn allows for
  filenames ending in '.', and with as many '.' elements as you like.
(This used to be commit 0a475175c53016bfa5b8246819676ddcd8b66feb)

13 years agor2927: imported the hash2 name mangling code from Samba3 into Samba4, but
Andrew Tridgell [Tue, 12 Oct 2004 05:10:43 +0000 (05:10 +0000)]
r2927: imported the hash2 name mangling code from Samba3 into Samba4, but
heavily modified to suit the Samba4 architecture.

Samba4 with posix backend now passes the BASE-MANGLE test
(This used to be commit ed52d69e8a065b6a8df2fb73c89be67acfdbca65)

13 years agor2926: name->dos.attrib is not valid unless name->exists is true
Andrew Tridgell [Tue, 12 Oct 2004 05:07:33 +0000 (05:07 +0000)]
r2926: name->dos.attrib is not valid unless name->exists is true
(This used to be commit f85a0b725d3bf67531e6874d4e8558fb050bb66f)

13 years agor2925: added the definition for a new rpc fault code I am seeing on epmapper from...
Andrew Tridgell [Tue, 12 Oct 2004 05:06:40 +0000 (05:06 +0000)]
r2925: added the definition for a new rpc fault code I am seeing on epmapper from lhorn
(This used to be commit 9ef399a769805ecfc78fc32e066b20e8efe34290)

13 years agor2922: Add note about 'server-side' binding strings
Jelmer Vernooij [Mon, 11 Oct 2004 20:56:17 +0000 (20:56 +0000)]
r2922: Add note about 'server-side' binding strings
(This used to be commit 666611d0343d61847341d8159d69e488f041a7ad)

13 years agor2921: Add a few more protocols and fix the numbers associated with some of
Jelmer Vernooij [Mon, 11 Oct 2004 20:12:51 +0000 (20:12 +0000)]
r2921: Add a few more protocols and fix the numbers associated with some of
the current ones. It took me three hours to realise that the DCOM standard
contains false protocol numbers (apparently someone converted the protocol
numbers to hex twice, i.e. 13 -> 0c and 14 to 0d). There are no longer
duplicates in the list with protocol numbers now.
(This used to be commit f355cd426462a72575ef3c3b769f676334976986)

13 years agor2920: Support passing a handle to a SAMR pipe to a RPC Binding or Select
Jelmer Vernooij [Mon, 11 Oct 2004 20:06:42 +0000 (20:06 +0000)]
r2920: Support passing a handle to a SAMR pipe to a RPC Binding or Select
Host dialog so that one can select a domain from the list of known
(This used to be commit 5e0bab891199c888bdf87faa29acc38d9ca5151b)

13 years agor2916: longhorn client doesn't bother setting the directory bit in ntcreatex
Andrew Tridgell [Mon, 11 Oct 2004 14:35:54 +0000 (14:35 +0000)]
r2916: longhorn client doesn't bother setting the directory bit in ntcreatex
when opening directories. This change allows samba4 server to work
with longhorn client.
(This used to be commit 4a8b0302eff37ccfcb66b91259ee5da20879c652)

13 years agor2915: Open domain first before enumerating users and groups
Jelmer Vernooij [Mon, 11 Oct 2004 14:15:25 +0000 (14:15 +0000)]
r2915: Open domain first before enumerating users and groups
(This used to be commit 9560a6c8cc650c3a519b14c79f497e6bd9ef387e)

13 years agor2914: ... and support enumerating values (data is not handled yet, only the names)
Jelmer Vernooij [Mon, 11 Oct 2004 14:07:20 +0000 (14:07 +0000)]
r2914: ... and support enumerating values (data is not handled yet, only the names)
(This used to be commit b3bc055ac73ff239c2b267717ee91669ecdd4c9b)

13 years agor2913: - Don't print hive name if it is NULL (regtree)
Jelmer Vernooij [Mon, 11 Oct 2004 13:57:30 +0000 (13:57 +0000)]
r2913: - Don't print hive name if it is NULL (regtree)
- Initialise hive name (reg_interface)
- Fix LDB backend (enumerating keys works now!)
(This used to be commit 5086d6b2494f236ef67096b2dd4da4f7402a65c5)

13 years agor2912: Test for the sort-of weird file stamp semantics. The last_write seems to be
Volker Lendecke [Mon, 11 Oct 2004 13:13:51 +0000 (13:13 +0000)]
r2912: Test for the sort-of weird file stamp semantics. The last_write seems to be
updated only by an arbitrary close() after the file was actually written to.

(This used to be commit ab52ebfdccc65ca510d74ce8e0205b45b58550ef)

13 years agor2911: Fix bug in opening relative keys
Jelmer Vernooij [Mon, 11 Oct 2004 11:52:44 +0000 (11:52 +0000)]
r2911: Fix bug in opening relative keys
(This used to be commit e7c256a92cc6cbe1cd6cc11a8fb37feba272d01c)

13 years agor2910: I noticed that the samr torture test was doing its own DOS->UNIX
Andrew Tridgell [Mon, 11 Oct 2004 09:27:19 +0000 (09:27 +0000)]
r2910: I noticed that the samr torture test was doing its own DOS->UNIX
string conversion. For RPC, all string conversions are supposed to be
done by the NDR layer, using string flags set in the IDL. The reason
this wasn't working is that I had been too lazy to do the STR_ASCII
string types properly at the NDR layer when initially writing

This commit fixes the ndr_basic code properly to do all ASCII
varients, by re-using the non-ascii code and a "byte_mul" local
variable. I have also removed the manual string conversion in the SAMR
torture test code.
(This used to be commit aad0e7e9d890bb56447f1f933b8f2bb78a3ee269)

13 years agor2909: fix some RAW-SEARCH torture mem leaks
Andrew Tridgell [Mon, 11 Oct 2004 09:23:19 +0000 (09:23 +0000)]
r2909: fix some RAW-SEARCH torture mem leaks
(This used to be commit 75ca5ba5091c9046159531b917ff17a519013556)

13 years agor2908: fix typo
Simo Sorce [Mon, 11 Oct 2004 09:21:12 +0000 (09:21 +0000)]
r2908: fix typo
(This used to be commit f544f830630c8d0bd37a66dc06683621c4dbcdde)

13 years agor2907: auto destroy iconv memory handles on exit, to make valgrind leak
Andrew Tridgell [Mon, 11 Oct 2004 05:23:46 +0000 (05:23 +0000)]
r2907: auto destroy iconv memory handles on exit, to make valgrind leak
reports easier to read (less noisy)
(This used to be commit e3009492b85ac90836aa9341687df5869f4ea291)

13 years agor2906: fixed a memory leak in the smbclient -L code
Andrew Tridgell [Mon, 11 Oct 2004 05:17:21 +0000 (05:17 +0000)]
r2906: fixed a memory leak in the smbclient -L code
(This used to be commit 0181fe06b4736661871515a7e2ab0d67bc8568fe)

13 years agor2904: - fixed the old style SMBsearch to return the pvfs shortname, not a truncated...
Andrew Tridgell [Mon, 11 Oct 2004 03:27:16 +0000 (03:27 +0000)]
r2904: - fixed the old style SMBsearch to return the pvfs shortname, not a truncated long name.

- short name can be up to 12 bytes, not 11
(This used to be commit 657103ec6264bf4c2986fedd3fc6577746395d49)

13 years agor2903: a considerably more efficient (both in terms of CPU and memory)
Andrew Tridgell [Mon, 11 Oct 2004 03:26:17 +0000 (03:26 +0000)]
r2903: a considerably more efficient (both in terms of CPU and memory)
convert_string_talloc() implementation.

the previous version used a minimum of 512 bytes, which is way above the average
of what is needed.
(This used to be commit abcd841a8530ba3273d56c9001ea277611507be3)