samba.git
24 years agoThis is actually Jeremy, working as Herb :-).
Herb Lewis [Wed, 24 Dec 1997 15:42:14 +0000 (15:42 +0000)]
This is actually Jeremy, working as Herb :-).
Fixed bug where, when server is shut down it would always
do a lm announce broadcast of shutdown. This could cause other
nmbd's to think that they have seen an lm announce broadcast and
start doing it themselves.
Changed to only send lm announce shutdown if admin configured it
or one was seen on the subnet.
Jeremy.

24 years agopreparing for release of 1.9.18alpha14
Samba Release Account [Wed, 24 Dec 1997 10:59:38 +0000 (10:59 +0000)]
preparing for release of 1.9.18alpha14

24 years agoUpdated WHATSNEW.txt for 1.9.18alpha14 release.
Jeremy Allison [Wed, 24 Dec 1997 10:50:43 +0000 (10:50 +0000)]
Updated WHATSNEW.txt for 1.9.18alpha14 release.
Added CVS_ACCESS to tell people how to use cvs
to keep up-to-date.
Jeremy.

24 years agoAdded docs for new signal handling functions.
Jeremy Allison [Wed, 24 Dec 1997 09:33:06 +0000 (09:33 +0000)]
Added docs for new signal handling functions.
Jeremy.

24 years agoAdded SIGUSR1/SIGUSR2 handling.
Jeremy Allison [Wed, 24 Dec 1997 09:30:56 +0000 (09:30 +0000)]
Added SIGUSR1/SIGUSR2 handling.
Sending nmbd/smbd a SIGUSR1 will raise the debug level by one (capped at 10)
sending a SIGUSR2 will lower it (lower limit at zero).
Jeremy.

24 years agonmbd_elections.c: Added new parameter to dump_workgroups call.
Jeremy Allison [Wed, 24 Dec 1997 08:49:44 +0000 (08:49 +0000)]
nmbd_elections.c: Added new parameter to dump_workgroups call.
nmbd_incomingdgrams.c: Deal with announcements with servertype == 0 - these
 are announcements that a machine is shutting down and must be treated differently.
nmbd_serverlistdb.c: Exposed remove_server_from_workgroup as external.
  Added code to dump out workgroups on signal correctly.
nmbd_workgroupdb.c: Added new parameter to dump_workgroups call.
Jeremy.

24 years agoFinally added the code Andrew wanted that will allow a Samba domain
Jeremy Allison [Wed, 24 Dec 1997 07:10:04 +0000 (07:10 +0000)]
Finally added the code Andrew wanted that will allow a Samba domain
master browser to use the *<1b> feature of the Samba WINS server to
get a full workgroup list.
nmbd.c: Added timed call to collect_all_workgroup_names_from_wins_server().
nmbd_browsesync.c: Meat of the code to implement collect_all_workgroup_names_from_wins_server().
nmbd_incomingdgrams.c: Fixed comment typo.
Jeremy.

24 years agoBugfix from Branko Cibej <branko.cibej@hermes.si>
Jeremy Allison [Wed, 24 Dec 1997 04:32:01 +0000 (04:32 +0000)]
Bugfix from Branko Cibej <branko.cibej@hermes.si>
- client.c had a workaround embedded in it for his
earlier bug in StrnCaseCmp - removed this.
Jeremy.

24 years agoBacked out changes that attempted to address a pointer array using -1,0,1.
Christopher R. Hertel [Wed, 24 Dec 1997 02:50:19 +0000 (02:50 +0000)]
Backed out changes that attempted to address a pointer array using -1,0,1.
Jeremy pointed out that there might be problems with this.  Darn shame.

24 years agoFixed nastly little bug where client was sending open_and_X call
Jeremy Allison [Tue, 23 Dec 1997 13:21:36 +0000 (13:21 +0000)]
Fixed nastly little bug where client was sending open_and_X call
with smb_mode (smb_vwv[3]) of 0x20 == DENY_WRITE + read-only-open.
and smb_ofun (smb_vwv[8]) of 0x11 == Create if not exist plus append
on a read-only share.
This was mapped into the strange unix flags of (O_RDONLY|O_CREAT)
- essentially O_CREAT as O_RDONLY == 0.
We were checking the unix flags directly against O_RDONLY instead
of masking off the open mode flag bits before doing the comparison,
so this open was being refused even though it was valid on a
read-only share.
Also ensured that the O_CREAT bit was masked out of the flags
bit if the open was done on a read-only share (as doing a unix
open( filename, O_RDONLY|O_CREAT, xxx) will create a zero length
file if the user had permission to write into the directory - which
should be denied on a read-only share.
Thanks to Mark Peek @ Whistle for giving me this test case.
Jeremy.

24 years agoFixed security bug when 'force user' and 'user only' are set.
Jeremy Allison [Tue, 23 Dec 1997 11:30:58 +0000 (11:30 +0000)]
Fixed security bug when 'force user' and 'user only' are set.
Reported by Brian McCauley <B.A.McCauley@bham.ac.uk>.
Jeremy.

24 years agoFixes to compile under OpenBSD from "Todd T. Fries" <toddf@acm.org>
Jeremy Allison [Tue, 23 Dec 1997 07:15:59 +0000 (07:15 +0000)]
Fixes to compile under OpenBSD from "Todd T. Fries" <toddf@acm.org>
Jeremy.

24 years agoarchitecture.doc: Re-added since I lost it (sorry Dan :-).
Jeremy Allison [Tue, 23 Dec 1997 06:38:36 +0000 (06:38 +0000)]
architecture.doc: Re-added since I lost it (sorry Dan :-).
nmbd.c nmbd_responserecordsdb.c: Spelling mistake fixes.
Jeremy.

24 years agoUpdates for 1.9.18
Dan Shearer [Sun, 21 Dec 1997 00:00:25 +0000 (00:00 +0000)]
Updates for 1.9.18

24 years agoPut it in the right directory :~)
Dan Shearer [Sat, 20 Dec 1997 23:44:25 +0000 (23:44 +0000)]
Put it in the right directory :~)

24 years agoChris' smb.conf parsing doco
Dan Shearer [Sat, 20 Dec 1997 23:40:17 +0000 (23:40 +0000)]
Chris' smb.conf parsing doco

24 years agoFixed stupid bug in read_smb_len where I was calling itself - now
Jeremy Allison [Sat, 20 Dec 1997 14:52:48 +0000 (14:52 +0000)]
Fixed stupid bug in read_smb_len where I was calling itself - now
calling the correct fn.
Jeremy.

24 years agoclient.c:
Jeremy Allison [Sat, 20 Dec 1997 14:36:11 +0000 (14:36 +0000)]
client.c:
clientgen.c:
clientutil.c:
clitar.c: Changed usage of receive_smb to new function client_receive_smb
          except for one use of receive_smb in client.c. This is the
          receive_smb used to discard packets received whilst in a
          keyboard wait state.
util.c: Created new function client_receive_smb that ignores session
        keepalives just as the old receive_smb used to do. Created
        internal function read_smb_length_return_keepalive that is
        used internally by the changed receive_smb call.
        Changed read_smb_len to not use an internal buffer - it is
        never called with a null buffer so such code is redundant.
Jeremy.

24 years agoloadparm.c: Added fix for veto oplock files bug from Charles Hoch <hoch@hplcgh.hpl...
Jeremy Allison [Sat, 20 Dec 1997 10:52:00 +0000 (10:52 +0000)]
loadparm.c: Added fix for veto oplock files bug from Charles Hoch <hoch@hplcgh.hpl.hp.com>
server.c, util.c: Added fix for oplock break requests blocking due to server being
                  blocked in read call. Bug found by Charles Hoch <hoch@hplcgh.hpl.hp.com>.
Jeremy.

24 years agoThis may be a waste of time, but I thought if we keep nibbling at this it might
Dan Shearer [Sat, 20 Dec 1997 10:06:07 +0000 (10:06 +0000)]
This may be a waste of time, but I thought if we keep nibbling at this it might
end up being a curent announce for each new release. Then again maybe we should
start from the one Jeremy and I did for 1.9.17. Just doodling really.

24 years agoMinor spelling, wording changes to intro
Dan Shearer [Sat, 20 Dec 1997 09:52:02 +0000 (09:52 +0000)]
Minor spelling, wording changes to intro

24 years agotrans2.c: Forced trans2_findfirst to behave as NT does in error returns.
Jeremy Allison [Sat, 20 Dec 1997 05:25:37 +0000 (05:25 +0000)]
trans2.c: Forced trans2_findfirst to behave as NT does in error returns.
util.c: Applied fix from Branko Cibej <branko.cibej@hermes.si> where
StrnCaseCmp tests one character too many.
Jeremy.

24 years agoAdding the cache module.
Christopher R. Hertel [Fri, 19 Dec 1997 09:32:58 +0000 (09:32 +0000)]
Adding the cache module.
I'll be using the cache module to replace the name cache in mangle.c.  The
new one should be much faster and should require less memory.
Another feature is that the cache size can be limited by the amount of
memory used in addition to the number of entries allowed.  With the
current cache, the default is to allocate 12800 bytes representing 50
entries (256 bytes each).  With the same amount of memory, I should be able
to load over around two hundred entries.
Changes to the AVL trees were minor (missing comments).
Chris -)-----

24 years agokanji.h: Fixed problems with re-definitions of strchr and others on AIX.
Jeremy Allison [Thu, 18 Dec 1997 11:05:00 +0000 (11:05 +0000)]
kanji.h: Fixed problems with re-definitions of strchr and others on AIX.
nmbd_nameregister.c: Applied fix found by "Eloy A. Paris" <eparis@ven.ra.rockwell.com>
(don't re-use lists after you have freed them :-).
Jeremy.

24 years agoMissed terminating {-1,NULL} in an enum parameter list.
Jeremy Allison [Wed, 17 Dec 1997 04:56:55 +0000 (04:56 +0000)]
Missed terminating {-1,NULL} in an enum parameter list.
Jeremy.

24 years ago- handle ENOSPC in shmem init.
Andrew Tridgell [Tue, 16 Dec 1997 14:06:09 +0000 (14:06 +0000)]
- handle ENOSPC in shmem init.
- be a little bit more friendly about grabbing semaphores

24 years agopreparing for release of 1.9.18alpha13
Samba Release Account [Tue, 16 Dec 1997 12:35:10 +0000 (12:35 +0000)]
preparing for release of 1.9.18alpha13

24 years agoAdded 'missing feature' section for Chris.
Samba Release Account [Tue, 16 Dec 1997 12:26:45 +0000 (12:26 +0000)]
Added 'missing feature' section for Chris.
Jeremy.

24 years agoWHATSNEW.txt - updated for 1.9.18alpha13.
Jeremy Allison [Tue, 16 Dec 1997 12:21:39 +0000 (12:21 +0000)]
WHATSNEW.txt - updated for 1.9.18alpha13.
docs/smb.conf.5: Removed unused NTDOMAIN params. Added new params.
source/loadparm.c: Put #ifdef NTDOMAIN around unused params.
source/nmbd_become_lmb.c: Removed check for workgroup name in lmb name.
Jeremy.

24 years agoAdded new wins & lm announce options.
Jeremy Allison [Tue, 16 Dec 1997 11:32:24 +0000 (11:32 +0000)]
Added new wins & lm announce options.
Jeremy.

24 years agoAdded Lanman announce patch from Jacco de Leeuw <leeuw@wins.uva.nl>.
Jeremy Allison [Tue, 16 Dec 1997 09:20:34 +0000 (09:20 +0000)]
Added Lanman announce patch from Jacco de Leeuw <leeuw@wins.uva.nl>.
Also added code to stop old Samba servers that announce the workgroup
name as master browser name when they are a local master browser.
Jeremy.

24 years agonmbd_incomingdgrams.c: Fix bug with Syntax 5.1 servers reported by SGI where
Jeremy Allison [Tue, 16 Dec 1997 07:30:25 +0000 (07:30 +0000)]
nmbd_incomingdgrams.c: Fix bug with Syntax 5.1 servers reported by SGI where
they do host announcements to LOCAL_MASTER_BROWSER_NAME<00> rather than
WORKGROUP<1d>.
nmbd_incomingrequests.c: Deal with WINS_PROXY_NAME issues - don't reply
with that name if it's the same broadcast net.
nmbd_serverlistdb.c: Stopped writing "Unknown" for local master browsers
we don't know.
nmbd_winsproxy.c: Deal with WINS_PROXY_NAME issues - don't reply
with that name if it's the same broadcast net.
Jeremy.

24 years agofix bug in log file specification
Herb Lewis [Tue, 16 Dec 1997 05:15:00 +0000 (05:15 +0000)]
fix bug in log file specification

24 years agogive out file handles differently on each new connection because of a
Andrew Tridgell [Sun, 14 Dec 1997 18:45:51 +0000 (18:45 +0000)]
give out file handles differently on each new connection because of a
common bug in MS clients where they try to reuse a file descriptor
from an earlier smb connection. This code increases the chance that
the errant client will get an error rather than causing corruption

24 years agoallow name_type 0x20 as well as name_type 0x0 in dns proxying
Andrew Tridgell [Sun, 14 Dec 1997 17:49:41 +0000 (17:49 +0000)]
allow name_type 0x20 as well as name_type 0x0 in dns proxying

24 years agofix a bug that sometimes prevented smbclient from connecting with
Andrew Tridgell [Sun, 14 Dec 1997 17:48:55 +0000 (17:48 +0000)]
fix a bug that sometimes prevented smbclient from connecting with
protocol < LANMAN1

24 years agoThis is it ! The mega-merge of the JRA_NMBD_REWRITE branch
Jeremy Allison [Sat, 13 Dec 1997 14:16:07 +0000 (14:16 +0000)]
This is it ! The mega-merge of the JRA_NMBD_REWRITE branch
back into the main tree.
For the cvs logs of all the files starting nmbd_*.c, look
in the JRA_NMBD_REWRITE branch. That branch has now been
discontinued.
Jeremy.

24 years agoFixed bug reported by Gert-Jan Vons <Gert-Jan.Vons@ocegr.fr>
Jeremy Allison [Fri, 12 Dec 1997 09:10:01 +0000 (09:10 +0000)]
Fixed bug reported by Gert-Jan Vons <Gert-Jan.Vons@ocegr.fr>
with doing a dir /s into a unix directory ending in a ':'.
Jeremy.

24 years agofixed over char 127 problems with isupper/islower.
Jeremy Allison [Thu, 11 Dec 1997 12:25:01 +0000 (12:25 +0000)]
fixed over char 127 problems with isupper/islower.
Jeremy.

24 years agoWhile working on a general-purpose caching module (out soon), I thought of
Christopher R. Hertel [Thu, 11 Dec 1997 11:44:18 +0000 (11:44 +0000)]
While working on a general-purpose caching module (out soon), I thought of
a better way to handle the node pointer array used in ubi_BinTree.  The
change simplified the code a bigbunch.  It also forced updates to all of
the binary tree modules.  CRH

24 years agokanji.c: Patch from Anders Blomdell <anders.blomdell@control.lth.se>
Jeremy Allison [Thu, 11 Dec 1997 11:07:09 +0000 (11:07 +0000)]
kanji.c: Patch from Anders Blomdell <anders.blomdell@control.lth.se>
for problem with kanji sj_strXXX functions.
Jeremy.

24 years agofix typo in directory name
Herb Lewis [Thu, 4 Dec 1997 19:17:02 +0000 (19:17 +0000)]
fix typo in directory name

24 years agoAdded one more USA consultant.
Jeremy Allison [Thu, 4 Dec 1997 18:39:08 +0000 (18:39 +0000)]
Added one more USA consultant.
Jeremy.

24 years agocatch signals in the async dns daemon and allow it to auto-restart if
Andrew Tridgell [Thu, 4 Dec 1997 10:58:40 +0000 (10:58 +0000)]
catch signals in the async dns daemon and allow it to auto-restart if
necessary

24 years agoallow for zero size reads in asyncdns. These can happen after a signal
Andrew Tridgell [Thu, 4 Dec 1997 08:10:49 +0000 (08:10 +0000)]
allow for zero size reads in asyncdns. These can happen after a signal

24 years agogot rid of the WRAP_MALLOC code - mem_man does it better
Andrew Tridgell [Thu, 4 Dec 1997 07:49:37 +0000 (07:49 +0000)]
got rid of the WRAP_MALLOC code - mem_man does it better

24 years agoadded optonal MEM_MAN code
Andrew Tridgell [Thu, 4 Dec 1997 07:48:06 +0000 (07:48 +0000)]
added optonal MEM_MAN code

24 years agodon't use free and alloc as structure elements
Andrew Tridgell [Thu, 4 Dec 1997 07:41:48 +0000 (07:41 +0000)]
don't use free and alloc as structure elements

24 years agoMakefile.lib does nothing, so remove it
Andrew Tridgell [Wed, 3 Dec 1997 14:17:38 +0000 (14:17 +0000)]
Makefile.lib does nothing, so remove it

24 years agoslight cleanup to the linked list handling
Andrew Tridgell [Wed, 3 Dec 1997 05:54:51 +0000 (05:54 +0000)]
slight cleanup to the linked list handling

24 years agoput the default PRINTCAP_NAME def in includes.h not local.h so that
Andrew Tridgell [Wed, 3 Dec 1997 05:22:24 +0000 (05:22 +0000)]
put the default PRINTCAP_NAME def in includes.h not local.h so that
it can see the SYSV definitions

24 years agoapplied a patch from Norm Jacobs to allow "printcap name = lpstat"
Andrew Tridgell [Wed, 3 Dec 1997 05:08:07 +0000 (05:08 +0000)]
applied a patch from Norm Jacobs to allow "printcap name = lpstat"
to use lpstat to obtain the printer list on systemV systems.

I've now made this the default on all SYSV systems.

Jeremy, you were a little worried about the security of this patch. I
believe it's OK as the user has no control over the options given to
popen() and the pipe is only open for reading.

24 years agochange the "username map" option to allow the user to stop the
Andrew Tridgell [Wed, 3 Dec 1997 04:20:39 +0000 (04:20 +0000)]
change the "username map" option to allow the user to stop the
processing part way through the file if a match is found. If a line
starts with ! and a match is made by that line then processing
stops. This allows better wildcard handling.

(patch from Anselm.Kruis@Physik.Uni-Muenchen.DE)

24 years agoallow local_machine and remote_machine (%L and %m macros) to contain
Andrew Tridgell [Wed, 3 Dec 1997 03:57:29 +0000 (03:57 +0000)]
allow local_machine and remote_machine (%L and %m macros) to contain
spaces

24 years agoloadparm.c: Added lp_we_are_a_wins_server as an alias for lp_wins_support.
Jeremy Allison [Wed, 3 Dec 1997 03:50:05 +0000 (03:50 +0000)]
loadparm.c: Added lp_we_are_a_wins_server as an alias for lp_wins_support.
Used by the new nmbd and just makes more sense :-).
Jeremy.

24 years agoadd a warning if the timezone is not a multiple of 1 minute. This
Andrew Tridgell [Wed, 3 Dec 1997 03:46:43 +0000 (03:46 +0000)]
add a warning if the timezone is not a multiple of 1 minute. This
should catch broken timezone files in slackware linux.

24 years agoallow users to disable the NetWkstaUserLogon call in server level
Andrew Tridgell [Wed, 3 Dec 1997 03:43:05 +0000 (03:43 +0000)]
allow users to disable the NetWkstaUserLogon call in server level
security by changing a setting in local.h or adding it to their
Makefile. See comment in local.h

24 years agomake the "printing" option a per share option rather than global. When
Andrew Tridgell [Wed, 3 Dec 1997 03:37:02 +0000 (03:37 +0000)]
make the "printing" option a per share option rather than global. When
printing to lots of different sorts of remote printers this is useful

24 years agoI'm slowly getting though the todo list :-)
Andrew Tridgell [Wed, 3 Dec 1997 03:21:25 +0000 (03:21 +0000)]
I'm slowly getting though the todo list :-)

This change allows people to select the SYSLOG_FACILITY in local.h, or
add it to the Makefile if they want to.

24 years agohopefully handle "ready and waiting" messages in print queue output a
Andrew Tridgell [Wed, 3 Dec 1997 03:00:49 +0000 (03:00 +0000)]
hopefully handle "ready and waiting" messages in print queue output a
little better

24 years agofix toupper(c) on a already uppercase char and tolower(c) on an
Andrew Tridgell [Wed, 3 Dec 1997 02:27:50 +0000 (02:27 +0000)]
fix toupper(c) on a already uppercase char and tolower(c) on an
already lowercase char when using code pages. Jeremy, can you confirm
that this looks right?  It comes from PR#1992

24 years agofixed the help message for -p (someone complained!)
Andrew Tridgell [Tue, 2 Dec 1997 23:32:03 +0000 (23:32 +0000)]
fixed the help message for -p (someone complained!)

24 years agoadd the null string to SMBsetatr calls
Andrew Tridgell [Tue, 2 Dec 1997 23:30:43 +0000 (23:30 +0000)]
add the null string to SMBsetatr calls

24 years agochanging the comment in find_new_file() to say why a base of 1 is used
Andrew Tridgell [Tue, 2 Dec 1997 23:29:57 +0000 (23:29 +0000)]
changing the comment in find_new_file() to say why a base of 1 is used

24 years agothe default GUEST_ACCOUNT should be here not in smb.h
Andrew Tridgell [Tue, 2 Dec 1997 23:28:14 +0000 (23:28 +0000)]
the default GUEST_ACCOUNT should be here not in smb.h

24 years agoHPUX trusted systems need to use bigcrypt() not crypt()
Andrew Tridgell [Tue, 2 Dec 1997 23:27:40 +0000 (23:27 +0000)]
HPUX trusted systems need to use bigcrypt() not crypt()

24 years agoget rid of some things out of smb.h that are already in local.h
Andrew Tridgell [Tue, 2 Dec 1997 23:26:42 +0000 (23:26 +0000)]
get rid of some things out of smb.h that are already in local.h

24 years agodont try getpeername() when Client isn't initialised
Andrew Tridgell [Tue, 2 Dec 1997 23:24:26 +0000 (23:24 +0000)]
dont try getpeername() when Client isn't initialised

24 years agoDocumented the 'veto oplock files' parameter.
Jeremy Allison [Tue, 2 Dec 1997 19:55:44 +0000 (19:55 +0000)]
Documented the 'veto oplock files' parameter.
Jeremy.

24 years agoasyncdns.c: Removed warning when compiling with -DSYNC_DNS.
Jeremy Allison [Tue, 2 Dec 1997 19:00:18 +0000 (19:00 +0000)]
asyncdns.c: Removed warning when compiling with -DSYNC_DNS.
nameelect.c: Tidied up settings of work->ServerType when unbecoming things.
nmbd.c: Fixed pidFile warning.
server.c: Fixed pidFile warning.
Jeremy.

24 years agofix for systems that don't have PWD environment variable defined
Herb Lewis [Mon, 1 Dec 1997 22:49:09 +0000 (22:49 +0000)]
fix for systems that don't have PWD environment variable defined

24 years agoremove stutter from closing instructions
Herb Lewis [Mon, 1 Dec 1997 15:21:23 +0000 (15:21 +0000)]
remove stutter from closing instructions

24 years agodded error checking to scripts
Herb Lewis [Mon, 1 Dec 1997 14:50:52 +0000 (14:50 +0000)]
dded error checking to scripts

24 years agothe logon script example should use %U.bat not %u.bat
Andrew Tridgell [Sun, 30 Nov 1997 05:46:33 +0000 (05:46 +0000)]
the logon script example should use %U.bat not %u.bat

24 years agoclientgen.c: Added cli_mv() (used in a recent torture test).
Jeremy Allison [Sun, 30 Nov 1997 02:58:34 +0000 (02:58 +0000)]
clientgen.c: Added cli_mv() (used in a recent torture test).
reply.c: Changed reply_open_and_X to split out the oplock
request bits from core and extended and if an oplock was granted only set
the corresponding bit on reply.
server.c: Added code to dynamically allocate i/o buffers in oplock_break
(prevents recursion problems) , also made reset of sent_oplock_break
explicit.
Jeremy.

24 years agodon't display locks for dead processes in smbstatus
Andrew Tridgell [Sat, 29 Nov 1997 13:35:09 +0000 (13:35 +0000)]
don't display locks for dead processes in smbstatus

24 years agouse -1 not 0xffffffff in SIVALS() macros
Andrew Tridgell [Sat, 29 Nov 1997 13:29:13 +0000 (13:29 +0000)]
use -1 not 0xffffffff in SIVALS() macros

use the same process_exists() code on all systems (it's probably
faster anyway)

24 years agoadded a sent_oplock_break element to Files[] as a paranoia check so we
Andrew Tridgell [Sat, 29 Nov 1997 02:40:31 +0000 (02:40 +0000)]
added a sent_oplock_break element to Files[] as a paranoia check so we
can't sent a oplock break twice on the same file.

changed some debug levels in the oplock code to level 0 so we can
track down a bug

zero the returned Files[] entry in find_free_file()

don't try to overcome client bugs in the handling of non-encrypted
passwords if in server level security mode

added paranoid null termination of password buffers

slight change to my ajt_panic() routine

24 years agopass the mailslot name to process_logon_packet()
Andrew Tridgell [Fri, 28 Nov 1997 05:52:31 +0000 (05:52 +0000)]
pass the mailslot name to process_logon_packet()

- fixed process_logon_packet() to always send the reply to/from the
correct netbios name (it should match the query)

- only do a NT style QUERYFORPDC if the query came in on a
NT_LOGON_MAILSLOT

Luke, can you check to see if these changes work in your branch with
NT logons?

24 years agoget_entries is an int not a bool
Andrew Tridgell [Fri, 28 Nov 1997 05:48:48 +0000 (05:48 +0000)]
get_entries is an int not a bool

24 years agopreparing for release of 1.9.18alpha12
Samba Release Account [Fri, 28 Nov 1997 03:46:03 +0000 (03:46 +0000)]
preparing for release of 1.9.18alpha12

24 years agothere was a bug in my oplock bugfix :-)
Andrew Tridgell [Fri, 28 Nov 1997 03:39:04 +0000 (03:39 +0000)]
there was a bug in my oplock bugfix :-)

It's fixed properly now :-)

24 years agofixed a very nasty oplock bug. We could send oplock break requests on
Andrew Tridgell [Fri, 28 Nov 1997 03:30:24 +0000 (03:30 +0000)]
fixed a very nasty oplock bug. We could send oplock break requests on
files that aren't open if the file happened to close while the oplock
was in transit. We would end up sending a oplock break request on
another random file (actually the open file that happened to have the
highest fnum). Then we wouldn't get a response, so smbd would keep
sending and would actually flood the net with an infinite number of
oplock break requests!

24 years agooh no! my favourite hack is broken. You can't do:
Andrew Tridgell [Wed, 26 Nov 1997 23:43:06 +0000 (23:43 +0000)]
oh no! my favourite hack is broken. You can't do:

[%U]
path = %H

to get a new homes area. I wonder when it broke?

Anyway, I've fixed it. We can all rest easy now, knowing that you
really can produce an incomprehensible smb.conf and get it to work.

24 years agoget rid of stat command (it is a hangover from an old experiment)
Andrew Tridgell [Tue, 25 Nov 1997 12:20:55 +0000 (12:20 +0000)]
get rid of stat command (it is a hangover from an old experiment)

24 years agoRemind them to read the man page about needing to be root.
Dan Shearer [Mon, 24 Nov 1997 19:10:40 +0000 (19:10 +0000)]
Remind them to read the man page about needing to be root.

24 years agoadded cli_rmdir and cli_mkdir
Andrew Tridgell [Mon, 24 Nov 1997 13:44:52 +0000 (13:44 +0000)]
added cli_rmdir and cli_mkdir

added test in smbtorture for the server updating the directory modify
time when a file is added to a directory

cleanup in smbtorture so no garbage files are left on the server

24 years agoadded a SMB_QUERY_FILE_ALL_INFO test into smbtorture
Andrew Tridgell [Sun, 23 Nov 1997 07:26:42 +0000 (07:26 +0000)]
added a SMB_QUERY_FILE_ALL_INFO test into smbtorture

W95 doesn't seem to support this call.

24 years agoadded some QPATHINFO and QFILEINFO tests into smbtorture.
Andrew Tridgell [Sun, 23 Nov 1997 05:55:44 +0000 (05:55 +0000)]
added some QPATHINFO and QFILEINFO tests into smbtorture.

This tests for things like midnight access times, sticky create times
and word reversed INFO_STANDARD returns

24 years agotest SMBsetatr as well
Andrew Tridgell [Sun, 23 Nov 1997 03:09:59 +0000 (03:09 +0000)]
test SMBsetatr as well

24 years agominor wsmbconf and cgi changes
Andrew Tridgell [Sun, 23 Nov 1997 02:42:22 +0000 (02:42 +0000)]
minor wsmbconf and cgi changes

24 years agoadded a test for the NT SMBgetatr bug in smbtorture
Andrew Tridgell [Sun, 23 Nov 1997 02:41:22 +0000 (02:41 +0000)]
added a test for the NT SMBgetatr bug in smbtorture

added support for choosing the protocol level in smbtorture (-m option)

use -1 for null date in cli_close()

get the attributes right in cli_open()

24 years agothis new cgi code includes the ability to act as a mini web server,
Andrew Tridgell [Sat, 22 Nov 1997 07:51:23 +0000 (07:51 +0000)]
this new cgi code includes the ability to act as a mini web server,
allowing people to use web configuration of Samba without installing a
web server

24 years agofixed some typecasts of (char *) to (unsigned char *)
Andrew Tridgell [Sat, 22 Nov 1997 07:17:32 +0000 (07:17 +0000)]
fixed some typecasts of (char *) to (unsigned char *)

24 years agothe usual :-)
Andrew Tridgell [Sat, 22 Nov 1997 07:10:22 +0000 (07:10 +0000)]
the usual :-)

24 years agoadded true enumerated types in loadparm.c. Now we don't need all those
Andrew Tridgell [Sat, 22 Nov 1997 07:09:12 +0000 (07:09 +0000)]
added true enumerated types in loadparm.c. Now we don't need all those
"interpret_security" and similar functions. This also means that
testparm produces string values for these enumerated types rather than
an integer. This was done to make the web interface much cleaner.

While I was doing this I found a couple of very nasty bugs in the
parm_table code. Someone had added a handle_character_set() function
that treated the char** pointer for a P_STRING as an integer! This
would have caused memory corruption for anyone using the "character
set" option. The loadparm code is delicate - please be careful about
using it's more esoteric features!

I've also removed the "coding system" global and made it a
P_STRING. The integer value was never used anywhere in Samba.

24 years agoJust fixed a *serious* bug in nameelect.c to do with local
Jeremy Allison [Fri, 21 Nov 1997 21:06:40 +0000 (21:06 +0000)]
Just fixed a *serious* bug in nameelect.c to do with local
master browsers. Once we have become a local master, we would
*NEVER* stop announcing ourselves as such. This has serious
implications for the new nmbd code.
Jeremy.

24 years agoAdded in mods for new smb.conf "remote browse sync" option as posted to
John Terpstra [Fri, 21 Nov 1997 14:01:23 +0000 (14:01 +0000)]
Added in mods for new smb.conf "remote browse sync" option as posted to
the samba-1.9.17 tree moments ago.

24 years agouse LocTimeDiff() not TimeDiff() to ensure that longdate conversion is
Andrew Tridgell [Fri, 21 Nov 1997 04:57:37 +0000 (04:57 +0000)]
use LocTimeDiff() not TimeDiff() to ensure that longdate conversion is
consistent (this is really just a cosmetic change)

24 years agoadded some debug lines to the rename code
Andrew Tridgell [Thu, 20 Nov 1997 01:36:36 +0000 (01:36 +0000)]
added some debug lines to the rename code